Fix sonar issues in /crud/service/CrudRestService 27/55327/1
authorSwiton Tomasz <tomasz.switon@nokia.com>
Mon, 25 Jun 2018 12:49:42 +0000 (14:49 +0200)
committerSwiton Tomasz <tomasz.switon@nokia.com>
Mon, 25 Jun 2018 12:49:42 +0000 (14:49 +0200)
Change-Id: Ib221593a6ff9e7fbd355eb4ff97ce6a5d1a5e0e0
Issue-ID: AAI-1241
Signed-off-by: Switon Tomasz <tomasz.switon@nokia.com>
src/main/java/org/onap/crud/service/CrudRestService.java

index 583fee6..35614cf 100644 (file)
@@ -22,6 +22,7 @@ package org.onap.crud.service;
 
 import java.security.cert.X509Certificate;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
@@ -783,7 +784,9 @@ public class CrudRestService {
         X500Principal subjectDn = clientCert.getSubjectX500Principal();
         authUser = subjectDn.toString();
       }
-      isValid = this.auth.validateRequest(authUser.toLowerCase(), action.toString() + ":" + authPolicyFunctionName);
+      if(null != authUser) {
+        isValid = this.auth.validateRequest(authUser.toLowerCase(), action.toString() + ":" + authPolicyFunctionName);
+      }
     } catch (Exception e) {
       logResult(action, uri, e);
       return false;
@@ -816,7 +819,7 @@ public class CrudRestService {
 
   void logResult(Action op, String uri, Exception e) {
 
-    logger.error(CrudServiceMsgs.EXCEPTION_DURING_METHOD_CALL, op.toString(), uri, e.getStackTrace().toString());
+    logger.error(CrudServiceMsgs.EXCEPTION_DURING_METHOD_CALL, op.toString(), uri, Arrays.toString(e.getStackTrace()));
 
     // Clear the MDC context so that no other transaction inadvertently
     // uses our transaction id.