From 63084c36ae0654ed837bccee648ded26694fb66b Mon Sep 17 00:00:00 2001 From: "mark.j.leonard" Date: Wed, 3 Apr 2019 12:23:11 +0100 Subject: [PATCH] Fix new Sonar code smell Log the Exception for missing software versions to prevent a Sonar violation. Change-Id: I1a5da4357947a57c05f2d4a40b788999149d543c Issue-ID: AAI-2281 Signed-off-by: mark.j.leonard --- .../org/onap/aai/babel/csar/vnfcatalog/VnfVendorImageExtractor.java | 1 + .../onap/aai/babel/csar/vnfcatalog/TestVnfVendorImageExtractor.java | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/onap/aai/babel/csar/vnfcatalog/VnfVendorImageExtractor.java b/src/main/java/org/onap/aai/babel/csar/vnfcatalog/VnfVendorImageExtractor.java index d5ba793..870c8c3 100644 --- a/src/main/java/org/onap/aai/babel/csar/vnfcatalog/VnfVendorImageExtractor.java +++ b/src/main/java/org/onap/aai/babel/csar/vnfcatalog/VnfVendorImageExtractor.java @@ -221,6 +221,7 @@ public class VnfVendorImageExtractor { try { return createVendorImageConfigurations(serviceVfList, vnfConfigurationNode); } catch (IllegalArgumentException e) { + applicationLogger.error(ApplicationMsgs.INVALID_CSAR_FILE, e); throw new ToscaToCatalogException(e.getMessage()); } } diff --git a/src/test/java/org/onap/aai/babel/csar/vnfcatalog/TestVnfVendorImageExtractor.java b/src/test/java/org/onap/aai/babel/csar/vnfcatalog/TestVnfVendorImageExtractor.java index d76551a..7ab8ecd 100644 --- a/src/test/java/org/onap/aai/babel/csar/vnfcatalog/TestVnfVendorImageExtractor.java +++ b/src/test/java/org/onap/aai/babel/csar/vnfcatalog/TestVnfVendorImageExtractor.java @@ -109,8 +109,7 @@ public class TestVnfVendorImageExtractor { VnfVendorImageExtractor extractor = new VnfVendorImageExtractor(); SdcToscaHelper helper = new SdcToscaHelper(); - List versions; - versions = extractor.extractSoftwareVersions(helper.buildMappings().getNodeTemplates()); + List versions = extractor.extractSoftwareVersions(helper.buildMappings().getNodeTemplates()); assertThat(versions.size(), is(0)); helper.addNodeTemplate(); -- 2.16.6