Remove the Generator Constants class 71/55471/1
authormark.j.leonard <mark.j.leonard@gmail.com>
Wed, 27 Jun 2018 10:46:19 +0000 (11:46 +0100)
committermark.j.leonard <mark.j.leonard@gmail.com>
Wed, 27 Jun 2018 10:46:37 +0000 (11:46 +0100)
commitdc94e09008ba0eb9dce7541d2c898ddc5c500814
tree8bf2edf12dcf5062f120210be85d1e4f337ece2e
parentf3bf5dd360b93fd7ef6cc8d871a9903de9f27e5a
Remove the Generator Constants class

Move the String constants out of a common class and into the individual
classes where they are used. This eliminates a set of Sonar code smells
relating to non-standard ordering of declarations. It simplifies the
code by removing the need for an empty private constructor in the static
class (i.e. containing static methods only).

Additionally, simplify the AaiModelGenerator interface by removing the
static factory method (which is not currently required). If multiple
implementations are needed we can use Spring annotations in the future.

Issue-ID: AAI-1242
Change-Id: Ica03b66ae2fd899977093d11d3e23dc3f3c8f194
Signed-off-by: mark.j.leonard <mark.j.leonard@gmail.com>
src/main/java/org/onap/aai/babel/parser/ArtifactGeneratorToscaParser.java
src/main/java/org/onap/aai/babel/xml/generator/api/AaiArtifactGenerator.java
src/main/java/org/onap/aai/babel/xml/generator/api/AaiModelGenerator.java
src/main/java/org/onap/aai/babel/xml/generator/data/GeneratorConstants.java [deleted file]
src/main/java/org/onap/aai/babel/xml/generator/model/Model.java
src/main/java/org/onap/aai/babel/xml/generator/model/Widget.java
src/test/java/org/onap/aai/babel/csar/extractor/YamlExtractorTest.java
src/test/java/org/onap/aai/babel/parser/TestToscaParser.java
src/test/java/org/onap/aai/babel/service/CsarToXmlConverterTest.java
src/test/java/org/onap/aai/babel/service/TestGenerateArtifactsServiceImpl.java