/**
- * ============LICENSE_START=======================================================
+ * ============LICENSE_START=======================================================
* org.onap.aai
* ================================================================================
- * Copyright © 2017-2018 AT&T Intellectual Property. All rights reserved.
- * Copyright © 2017-2018 European Software Marketing Ltd.
+ * Copyright © 2017-2019 AT&T Intellectual Property. All rights reserved.
+ * Copyright © 2017-2019 European Software Marketing Ltd.
* ================================================================================
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* limitations under the License.
* ============LICENSE_END=========================================================
*/
+
package org.onap.aai.babel.service;
import static org.hamcrest.Matchers.is;
import static org.junit.Assert.assertThat;
+import com.google.gson.Gson;
import java.io.IOException;
import java.net.URI;
import java.net.URISyntaxException;
-import java.net.URL;
-import java.nio.file.Files;
-import java.nio.file.Paths;
import java.security.cert.X509Certificate;
import java.util.Collections;
import java.util.List;
import java.util.Map.Entry;
-import java.util.stream.Collectors;
import javax.inject.Inject;
import javax.security.auth.x500.X500Principal;
import javax.ws.rs.core.HttpHeaders;
import org.junit.runner.RunWith;
import org.mockito.Mockito;
import org.onap.aai.auth.AAIMicroServiceAuth;
-import org.onap.aai.babel.xml.generator.data.GeneratorConstants;
+import org.onap.aai.babel.service.data.BabelRequest;
+import org.onap.aai.babel.testdata.CsarTest;
+import org.onap.aai.babel.util.ArtifactTestUtils;
import org.springframework.mock.web.MockHttpServletRequest;
import org.springframework.test.context.ContextConfiguration;
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
/**
- * Direct invocation of the generate artifacts service implementation
+ * Direct invocation of the generate artifacts service implementation.
*
*/
@RunWith(SpringJUnit4ClassRunner.class)
System.setProperty("CONFIG_HOME", "src/test/resources");
}
+
@Inject
private AAIMicroServiceAuth auth;
@BeforeClass
public static void setup() {
- URL url = TestGenerateArtifactsServiceImpl.class.getClassLoader().getResource("artifact-generator.properties");
- System.setProperty(GeneratorConstants.PROPERTY_ARTIFACT_GENERATOR_CONFIG_FILE, url.getPath());
+ new ArtifactTestUtils().setGeneratorSystemProperties();
+
+ }
+
+ @Test
+ public void testGenerateArtifacts() throws Exception {
+ Response response = processJsonRequest(CsarTest.VNF_VENDOR_CSAR);
+ assertThat(response.getStatus(), is(Response.Status.OK.getStatusCode()));
+ assertThat(response.getEntity(), is(getResponseJson("response.json")));
+ }
+
+ /**
+ * No VNF Configuration exists.
+ *
+ * @throws URISyntaxException
+ * if the URI cannot be created
+ * @throws IOException
+ * if the resource cannot be loaded
+ */
+ @Test
+ public void testGenerateArtifactsWithoutVnfConfiguration() throws IOException, URISyntaxException {
+ Response response = processJsonRequest(CsarTest.NO_VNF_CONFIG_CSAR);
+ assertThat(response.getStatus(), is(Response.Status.OK.getStatusCode()));
+ assertThat(response.getEntity(), is(getResponseJson("validNoVnfConfigurationResponse.json")));
}
@Test
public void testInvalidCsarFile() throws URISyntaxException, IOException {
- String jsonRequest = readstringFromFile("jsonFiles/invalid_csar_request.json");
- Response response = processJsonRequest(jsonRequest);
+ BabelRequest request = new BabelRequest();
+ request.setArtifactName("hello");
+ request.setArtifactVersion("1.0");
+ request.setCsar("xxxx");
+ Response response = invokeService(new Gson().toJson(request));
assertThat(response.getStatus(), is(Response.Status.INTERNAL_SERVER_ERROR.getStatusCode()));
assertThat(response.getEntity(), is("Error converting CSAR artifact to XML model."));
}
@Test
public void testInvalidJsonFile() throws URISyntaxException, IOException {
- String jsonRequest = readstringFromFile("jsonFiles/invalid_json_request.json");
- Response response = processJsonRequest(jsonRequest);
+ Response response = invokeService("{\"csar:\"xxxx\"");
assertThat(response.getStatus(), is(Response.Status.BAD_REQUEST.getStatusCode()));
assertThat(response.getEntity(), is("Malformed request."));
}
@Test
public void testMissingArtifactName() throws Exception {
- String jsonRequest = readstringFromFile("jsonFiles/missing_artifact_name_request.json");
- Response response = processJsonRequest(jsonRequest);
+ BabelRequest request = new BabelRequest();
+ request.setArtifactVersion("1.0");
+ request.setCsar("");
+ Response response = invokeService(new Gson().toJson(request));
assertThat(response.getStatus(), is(Response.Status.BAD_REQUEST.getStatusCode()));
assertThat(response.getEntity(), is("No artifact name attribute found in the request body."));
}
@Test
public void testMissingArtifactVersion() throws Exception {
- String jsonRequest = readstringFromFile("jsonFiles/missing_artifact_version_request.json");
- Response response = processJsonRequest(jsonRequest);
+ BabelRequest request = new BabelRequest();
+ request.setArtifactName("hello");
+ request.setCsar("");
+ Response response = invokeService(new Gson().toJson(request));
assertThat(response.getStatus(), is(Response.Status.BAD_REQUEST.getStatusCode()));
assertThat(response.getEntity(), is("No artifact version attribute found in the request body."));
}
@Test
public void testMissingCsarFile() throws Exception {
- String jsonRequest = readstringFromFile("jsonFiles/missing_csar_request.json");
- Response response = processJsonRequest(jsonRequest);
+ BabelRequest request = new BabelRequest();
+ request.setArtifactName("test-name");
+ request.setArtifactVersion("1.0");
+ Response response = invokeService(new Gson().toJson(request));
assertThat(response.getStatus(), is(Response.Status.BAD_REQUEST.getStatusCode()));
assertThat(response.getEntity(), is("No csar attribute found in the request body."));
}
/**
- * Create a (mocked) HTTPS request and invoke the Babel generate artifacts API
- *
- * @param request for the Babel Service
+ * Create a (mocked) HTTPS request and invoke the Babel generate artifacts API.
+ *
+ * @param csar
+ * test CSAR file
+ * @return the Response from the HTTP API
+ * @throws URISyntaxException
+ * if the URI cannot be created
+ * @throws IOException
+ * if the resource cannot be loaded
+ */
+ private Response processJsonRequest(CsarTest csar) throws IOException, URISyntaxException {
+ String jsonString = csar.getJsonRequest();
+ return invokeService(jsonString);
+ }
+
+ /**
+ * Create a (mocked) HTTPS request and invoke the Babel generate artifacts API.
+ *
+ * @param jsonString
+ * the JSON request
* @return the Response from the HTTP API
* @throws URISyntaxException
+ * if the URI cannot be created
*/
- private Response processJsonRequest(String jsonRequest) throws URISyntaxException {
+ private Response invokeService(String jsonString) throws URISyntaxException {
UriInfo mockUriInfo = Mockito.mock(UriInfo.class);
Mockito.when(mockUriInfo.getRequestUri()).thenReturn(new URI("/validate")); // NOSONAR (mocked)
Mockito.when(mockUriInfo.getPath(false)).thenReturn("validate"); // URI prefix is stripped by AJSC routing
servletRequest.setAttribute("javax.servlet.request.cipher_suite", "");
GenerateArtifactsServiceImpl service = new GenerateArtifactsServiceImpl(auth);
- return service.generateArtifacts(mockUriInfo, headers, servletRequest, jsonRequest);
+ return service.generateArtifacts(mockUriInfo, headers, servletRequest, jsonString);
}
- private List<String> createSingletonList(String listItem) {
- return Collections.<String>singletonList(listItem);
+ private String getResponseJson(String jsonResponse) throws IOException, URISyntaxException {
+ return new ArtifactTestUtils().getResponseJson(jsonResponse);
}
- private String readstringFromFile(String resourceFile) throws IOException, URISyntaxException {
- return Files
- .lines(Paths
- .get(TestGenerateArtifactsServiceImpl.class.getClassLoader().getResource(resourceFile).toURI()))
- .collect(Collectors.joining());
+ private List<String> createSingletonList(String listItem) {
+ return Collections.<String>singletonList(listItem);
}
}
Code Review / aai / babel.git / blobdiff