From: Instrumental <jonathan.gathman@att.com>
Date: Wed, 3 Jul 2019 13:59:41 +0000 (-0500)
Subject: Approval page flaw
X-Git-Tag: 2.1.15~12^2~2
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=aaf%2Fauthz.git;a=commitdiff_plain;h=e1293ae0c53791a2189e372048e4dd4023a4b0f3

Approval page flaw

Issue-ID: AAF-857
Change-Id: Ib691e240f9427006ec6d909671207cbaaeca7473
Signed-off-by: Instrumental <jonathan.gathman@att.com>
---

diff --git a/auth/auth-gui/src/main/java/org/onap/aaf/auth/gui/pages/ApiDocs.java b/auth/auth-gui/src/main/java/org/onap/aaf/auth/gui/pages/ApiDocs.java
index 106c3889..39e4d0b6 100644
--- a/auth/auth-gui/src/main/java/org/onap/aaf/auth/gui/pages/ApiDocs.java
+++ b/auth/auth-gui/src/main/java/org/onap/aaf/auth/gui/pages/ApiDocs.java
@@ -25,7 +25,6 @@ import java.io.IOException;
 import java.net.ConnectException;
 import java.util.ArrayList;
 import java.util.Collections;
-import java.util.Comparator;
 
 import org.onap.aaf.auth.env.AuthzTrans;
 import org.onap.aaf.auth.gui.AAF_GUI;
diff --git a/auth/auth-gui/src/main/java/org/onap/aaf/auth/gui/pages/ApprovalForm.java b/auth/auth-gui/src/main/java/org/onap/aaf/auth/gui/pages/ApprovalForm.java
index e047a22a..332ecafe 100644
--- a/auth/auth-gui/src/main/java/org/onap/aaf/auth/gui/pages/ApprovalForm.java
+++ b/auth/auth-gui/src/main/java/org/onap/aaf/auth/gui/pages/ApprovalForm.java
@@ -282,9 +282,8 @@ public class ApprovalForm extends Page {
 	//                                    title);
 	                                
 	                            } else {
-	                                userCell = new TextCell(prevUser==null?user:prevUser);
+	                                userCell = new TextCell(user);
 	                            }
-                                prevUser=user;
 	                            AbsCell[] sa = new AbsCell[] {
 	                                userCell,
 	                                new TextCell(appr.getMemo()),
@@ -292,6 +291,7 @@ public class ApprovalForm extends Page {
 	                                new RadioCell("line."+ line,"deny", "denied|"+appr.getTicket())
 	                            };
 	                            rv.add(sa);
+                                prevUser=user;
 	                        } else {
 	                            ++numLeft;
 	                        }