From: burdziak <olaf.burdziakowski@nokia.com>
Date: Mon, 21 May 2018 11:24:59 +0000 (+0200)
Subject: Fix sonar issues in Email
X-Git-Tag: Beijing-2.1.1~28^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=aaf%2Fauthz.git;a=commitdiff_plain;h=95f9931f178ea1d3332a8ab1640c07a21a9107e3

Fix sonar issues in Email

Change-Id: I5f0607852ee433d5f5dcaac747c6a34bd077ae57
Issue-ID: AAF-296
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
---

diff --git a/auth/auth-batch/src/main/java/org/onap/aaf/auth/actions/Email.java b/auth/auth-batch/src/main/java/org/onap/aaf/auth/actions/Email.java
index 25e2ffca..15dfed38 100644
--- a/auth/auth-batch/src/main/java/org/onap/aaf/auth/actions/Email.java
+++ b/auth/auth-batch/src/main/java/org/onap/aaf/auth/actions/Email.java
@@ -46,9 +46,9 @@ public class Email implements Action<Organization,Void, String>{
 
 	
 	public Email(String ... defaultCC) {
-		toList = new ArrayList<String>();
+		toList = new ArrayList<>();
 		this.defaultCC = defaultCC;
-		ccList = new ArrayList<String>();
+		ccList = new ArrayList<>();
 		clear();
 	}
 	
@@ -71,10 +71,8 @@ public class Email implements Action<Organization,Void, String>{
 	}
 
 	public Email addTo(Identity id) {
-		if(id!=null) {
-			if(!toList.contains(id.email())) {
+		if(id!=null && !toList.contains(id.email())) {
 				toList.add(id.email());
-			}
 		}
 		return this;
 	}
@@ -94,10 +92,8 @@ public class Email implements Action<Organization,Void, String>{
 	}
 
 	public Email addCC(Identity id) {
-		if(id!=null) {
-			if(!ccList.contains(id.email())) {
+		if(id!=null && !ccList.contains(id.email())) {
 				ccList.add(id.email());
-			}
 		}
 		return this;
 	}