From: burdziak <olaf.burdziakowski@nokia.com>
Date: Tue, 22 May 2018 07:44:13 +0000 (+0200)
Subject: Fix sonar issued in LocalCA
X-Git-Tag: Beijing-2.1.1~16^2
X-Git-Url: https://gerrit.onap.org/r/gitweb?p=aaf%2Fauthz.git;a=commitdiff_plain;h=1c0d0ad2df58740b22a149a7a5d22e0f85a6b651

Fix sonar issued in LocalCA

Change-Id: I9b97cff8ea4e798e0db5a5ac68f5b29080631f18
Issue-ID: AAF-308
Signed-off-by: burdziak <olaf.burdziakowski@nokia.com>
---

diff --git a/auth/auth-certman/src/main/java/org/onap/aaf/auth/cm/ca/LocalCA.java b/auth/auth-certman/src/main/java/org/onap/aaf/auth/cm/ca/LocalCA.java
index cd8886da..e2287c3b 100644
--- a/auth/auth-certman/src/main/java/org/onap/aaf/auth/cm/ca/LocalCA.java
+++ b/auth/auth-certman/src/main/java/org/onap/aaf/auth/cm/ca/LocalCA.java
@@ -97,7 +97,7 @@ public class LocalCA extends CA {
 			String fileName = f.getName();
 			if(fileName.endsWith(".key")) {
 				caKey = Factory.toPrivateKey(NullTrans.singleton(),f);
-				List<FileReader> frs = new ArrayList<FileReader>(params.length-1);
+				List<FileReader> frs = new ArrayList<>(params.length-1);
 				try {
 					String dir = access.getProperty(CM_PUBLIC_DIR, "");
 					if(!"".equals(dir) && !dir.endsWith("/")) {
@@ -128,8 +128,8 @@ public class LocalCA extends CA {
 					KeyStore keyStore;
 					FileInputStream fis = null;
 					if(fileName.endsWith(".pkcs11")) {
-						String ksType;
-						p = Factory.getSecurityProvider(ksType="PKCS11",params);
+						String ksType="PKCS11";
+						p = Factory.getSecurityProvider(ksType,params);
 						keyStore = KeyStore.getInstance(ksType,p);
 					} else if(fileName.endsWith(".jks")) {
 						keyStore = KeyStore.getInstance("JKS");
@@ -216,7 +216,7 @@ public class LocalCA extends CA {
 					SubjectPublicKeyInfoFactory.createSubjectPublicKeyInfo(new RSAKeyParameters(false,rpk.getModulus(),rpk.getPublicExponent()))
 //					new SubjectPublicKeyInfo(ASN1Sequence.getInstance(caCert.getPublicKey().getEncoded()))
 					);
-			List<GeneralName> lsan = new ArrayList<GeneralName>();
+			List<GeneralName> lsan = new ArrayList<>();
 			for(String s : csrmeta.sans()) {
 				lsan.add(new GeneralName(GeneralName.dNSName,s));
 			}