Sonar Fixes, Formatting

[aaf/authz.git] / auth / auth-cmd / src / main / java / org / onap / aaf / auth / cmd / mgmt / Deny.java

diff --git a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/mgmt/Deny.java b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/mgmt/Deny.java
index 17f2372..3ab26cb 100644 (file)
--- a/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/mgmt/Deny.java
+++ b/auth/auth-cmd/src/main/java/org/onap/aaf/auth/cmd/mgmt/Deny.java
@@ -7,9 +7,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -34,14 +34,14 @@ import org.onap.aaf.cadi.config.Config;
 import org.onap.aaf.misc.env.APIException;
 
 public class Deny extends BaseCmd<Mgmt> {
-    private final static String[] options = {"add","del"};
+    private static final String[] options = {"add","del"};
 
-    public Deny(Mgmt mgmt) throws APIException {
+    public Deny(Mgmt mgmt) {
         super(mgmt, "deny");
         cmds.add(new DenySomething(this,"ip","ipv4or6[,ipv4or6]*"));
         cmds.add(new DenySomething(this,"id","identity[,identity]*"));
     }
-    
+
     public class DenySomething extends Cmd {
 
         private boolean isID;
@@ -54,14 +54,14 @@ public class Deny extends BaseCmd<Mgmt> {
         }
 
         @Override
-        protected int _exec(int _idx, String... args) throws CadiException, APIException, LocatorException {
-                int idx = _idx;
+        protected int _exec(int idxValue, String... args) throws CadiException, APIException, LocatorException {
+                int idx = idxValue;
             String action = args[idx++];
             final int option = whichOption(options, action);
             int rv=409;
-            for(final String name : args[idx++].split(COMMA)) {
+            for (final String name : args[idx++].split(COMMA)) {
                 final String append;
-                if(isID && name.indexOf("@")<0) {
+                if (isID && name.indexOf("@")<0) {
                     append='@'+ access.getProperty(Config.AAF_DEFAULT_REALM,null);
                 } else {
                     append = "";
@@ -73,20 +73,20 @@ public class Deny extends BaseCmd<Mgmt> {
                         int rv = 409;
                         Future<Void> fp;
                         String resp;
-                        switch(option) {
-                            case 0: 
-                                fp = client.create(path, Void.class);
-                                resp = " added";
-                                break;
-                            default: 
-                                fp = client.delete(path, Void.class);
-                                resp = " deleted";
+                        if(option == 0) {
+                            fp = client.create(path, Void.class);
+                            resp = " added";
+                        } else {
+                            fp = client.delete(path, Void.class);
+                            resp = " deleted";
                         }
-                        if(fp.get(AAFcli.timeout())) {
+                        if (fp.get(AAFcli.timeout())) {
                             pw().println(name + append + resp + " on " + client);
                             rv=fp.code();
                         } else {
-                            if(rv==409)rv = fp.code();
+                            if (rv==409) {
+                                rv = fp.code();
+                            };
                             error(fp);
                         }
                         return rv;