From f2a7462d4c7652dec1aa12fac122674be8bc62c3 Mon Sep 17 00:00:00 2001 From: Rupinder Date: Mon, 6 Apr 2020 16:04:15 +0530 Subject: [PATCH] improved code structure Removed code smells Issue-ID: APPC-1859 Change-Id: I241ac80a75fdebfb9048349ae993a891a7a9642d Signed-off-by: Rupinder --- .../java/org/onap/appc/adapter/ansible/impl/ConnectionBuilder.java | 1 - .../onap/appc/adapter/iaas/provider/operation/impl/RestartServer.java | 3 --- .../onap/appc/adapter/restHealthcheck/RestHealthcheckActivator.java | 1 - .../src/main/java/org/onap/appc/ccadaptor/ConfigComponentAdaptor.java | 1 - .../main/java/org/onap/appc/artifact/handler/dbservices/DBService.java | 2 -- 5 files changed, 8 deletions(-) diff --git a/appc-adapters/appc-ansible-adapter/appc-ansible-adapter-bundle/src/main/java/org/onap/appc/adapter/ansible/impl/ConnectionBuilder.java b/appc-adapters/appc-ansible-adapter/appc-ansible-adapter-bundle/src/main/java/org/onap/appc/adapter/ansible/impl/ConnectionBuilder.java index 0bcc1a32c..d2efc6a69 100644 --- a/appc-adapters/appc-ansible-adapter/appc-ansible-adapter-bundle/src/main/java/org/onap/appc/adapter/ansible/impl/ConnectionBuilder.java +++ b/appc-adapters/appc-ansible-adapter/appc-ansible-adapter-bundle/src/main/java/org/onap/appc/adapter/ansible/impl/ConnectionBuilder.java @@ -58,7 +58,6 @@ import org.onap.appc.adapter.ansible.model.AnsibleResultCodes; import com.att.eelf.configuration.EELFLogger; import com.att.eelf.configuration.EELFManager; import org.json.JSONObject; -import org.onap.appc.exceptions.APPCException; import org.apache.commons.lang.StringUtils; /** diff --git a/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/impl/RestartServer.java b/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/impl/RestartServer.java index 518b2e4ba..37d897200 100644 --- a/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/impl/RestartServer.java +++ b/appc-adapters/appc-iaas-adapter/appc-iaas-adapter-bundle/src/main/java/org/onap/appc/adapter/iaas/provider/operation/impl/RestartServer.java @@ -47,11 +47,8 @@ import org.onap.ccsdk.sli.core.sli.SvcLogicContext; import org.slf4j.MDC; import org.onap.appc.logging.LoggingConstants; import org.onap.appc.logging.LoggingUtils; -import java.text.DateFormat; -import java.text.SimpleDateFormat; import java.util.Date; import java.util.Map; -import java.util.TimeZone; import static org.onap.appc.adapter.iaas.provider.operation.common.enums.Operation.RESTART_SERVICE; import static org.onap.appc.adapter.utils.Constants.ADAPTER_NAME; diff --git a/appc-adapters/appc-rest-healthcheck-adapter/appc-rest-healthcheck-adapter-bundle/src/main/java/org/onap/appc/adapter/restHealthcheck/RestHealthcheckActivator.java b/appc-adapters/appc-rest-healthcheck-adapter/appc-rest-healthcheck-adapter-bundle/src/main/java/org/onap/appc/adapter/restHealthcheck/RestHealthcheckActivator.java index 15f1b4fc7..24b72b5a0 100644 --- a/appc-adapters/appc-rest-healthcheck-adapter/appc-rest-healthcheck-adapter-bundle/src/main/java/org/onap/appc/adapter/restHealthcheck/RestHealthcheckActivator.java +++ b/appc-adapters/appc-rest-healthcheck-adapter/appc-rest-healthcheck-adapter-bundle/src/main/java/org/onap/appc/adapter/restHealthcheck/RestHealthcheckActivator.java @@ -23,7 +23,6 @@ package org.onap.appc.adapter.restHealthcheck; import org.onap.appc.adapter.restHealthcheck.impl.RestHealthcheckAdapterImpl; -import org.onap.appc.configuration.Configuration; import com.att.eelf.configuration.EELFLogger; import com.att.eelf.configuration.EELFManager; import org.osgi.framework.BundleActivator; diff --git a/appc-config/appc-config-adaptor/provider/src/main/java/org/onap/appc/ccadaptor/ConfigComponentAdaptor.java b/appc-config/appc-config-adaptor/provider/src/main/java/org/onap/appc/ccadaptor/ConfigComponentAdaptor.java index bb3627596..941157b3c 100644 --- a/appc-config/appc-config-adaptor/provider/src/main/java/org/onap/appc/ccadaptor/ConfigComponentAdaptor.java +++ b/appc-config/appc-config-adaptor/provider/src/main/java/org/onap/appc/ccadaptor/ConfigComponentAdaptor.java @@ -70,7 +70,6 @@ import javax.ws.rs.client.ClientBuilder; import javax.ws.rs.client.Entity; import javax.ws.rs.client.WebTarget; import javax.ws.rs.core.Response; -import javax.ws.rs.core.Feature; public class ConfigComponentAdaptor implements SvcLogicAdaptor { diff --git a/appc-inbound/appc-artifact-handler/provider/src/main/java/org/onap/appc/artifact/handler/dbservices/DBService.java b/appc-inbound/appc-artifact-handler/provider/src/main/java/org/onap/appc/artifact/handler/dbservices/DBService.java index 4f1df9b99..41e440924 100644 --- a/appc-inbound/appc-artifact-handler/provider/src/main/java/org/onap/appc/artifact/handler/dbservices/DBService.java +++ b/appc-inbound/appc-artifact-handler/provider/src/main/java/org/onap/appc/artifact/handler/dbservices/DBService.java @@ -34,11 +34,9 @@ import org.apache.commons.configuration.ConfigurationException; import org.apache.commons.configuration.PropertiesConfiguration; import org.apache.commons.lang.StringUtils; import org.onap.appc.artifact.handler.utils.SdcArtifactHandlerConstants; -import org.onap.ccsdk.sli.adaptors.resource.sql.SqlResource; import org.onap.ccsdk.sli.core.dblib.DbLibService; import org.onap.ccsdk.sli.core.sli.SvcLogicContext; import org.onap.ccsdk.sli.core.sli.SvcLogicException; -import org.onap.ccsdk.sli.core.sli.SvcLogicResource; import org.onap.ccsdk.sli.core.sli.SvcLogicResource.QueryStatus; public class DBService { -- 2.16.6