From 061c44e8928566da6fc7953cd75135a87ebb8a45 Mon Sep 17 00:00:00 2001 From: ToineSiebelink Date: Mon, 9 Jun 2025 18:31:53 +0100 Subject: [PATCH] Remove excessive registration and de-registration logging - changed registration logging to debug level at one more spot Issue-ID: CPS-2816 Change-Id: If495682890c66b0a0afd2ea4972521f32d039459 Signed-off-by: ToineSiebelink --- .../onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasks.java | 2 +- .../ncmp/impl/inventory/sync/ModuleSyncTasksSpec.groovy | 14 ++++++++------ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasks.java b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasks.java index fcd658ae43..29a60ec01e 100644 --- a/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasks.java +++ b/cps-ncmp-service/src/main/java/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasks.java @@ -116,7 +116,7 @@ public class ModuleSyncTasks { private void removeResetCmHandleFromModuleSyncMap(final String resetCmHandleId) { moduleSyncStartedOnCmHandles.delete(resetCmHandleId); - log.info("{} removed from in progress map", resetCmHandleId); + log.debug("{} removed from in progress map", resetCmHandleId); } private static boolean isCmHandleInAdvisedState(final YangModelCmHandle yangModelCmHandle) { diff --git a/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasksSpec.groovy b/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasksSpec.groovy index a2f38c89eb..851662aef8 100644 --- a/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasksSpec.groovy +++ b/cps-ncmp-service/src/test/groovy/org/onap/cps/ncmp/impl/inventory/sync/ModuleSyncTasksSpec.groovy @@ -45,11 +45,13 @@ import static org.onap.cps.ncmp.api.inventory.models.LockReasonCategory.MODULE_U class ModuleSyncTasksSpec extends Specification { - def logger = Spy(ListAppender) + def logAppender = Spy(ListAppender) void setup() { - ((Logger) LoggerFactory.getLogger(ModuleSyncTasks.class)).addAppender(logger) - logger.start() + def logger = LoggerFactory.getLogger(ModuleSyncTasks) + logger.setLevel(Level.DEBUG) + logger.addAppender(logAppender) + logAppender.start() } void cleanup() { @@ -180,9 +182,9 @@ class ModuleSyncTasksSpec extends Specification { moduleSyncStartedOnCmHandles.put('ch-1', 'started') when: 'remove cm handle entry' objectUnderTest.removeResetCmHandleFromModuleSyncMap('ch-1') - then: 'an event is logged with level INFO' + then: 'an event is logged with level DEBUG' def loggingEvent = getLoggingEvent() - assert loggingEvent.level == Level.INFO + assert loggingEvent.level == Level.DEBUG and: 'the log indicates the cm handle entry is removed successfully' assert loggingEvent.formattedMessage == 'ch-1 removed from in progress map' } @@ -225,6 +227,6 @@ class ModuleSyncTasksSpec extends Specification { } def getLoggingEvent() { - return logger.list[0] + return logAppender.list[0] } } -- 2.16.6