From 7ec34a110f0060a73bd9db9d4efdaf53245fbbd2 Mon Sep 17 00:00:00 2001 From: Rina Roi Date: Wed, 7 Aug 2019 10:14:08 +0300 Subject: [PATCH] Use lcpRegionOptionId as value in resume Issue-ID: VID-482 Signed-off-by: Rina Roi Change-Id: Ibe617ba739db8e6217362a8009dedc9bd3465239 --- .../vf-module-homing-data-action.controller.js | 2 +- .../vf-module-homing-data-action/vf-module-homing-data-action.html | 6 +++--- vid-webpack-master/cypress/integration/iFrames/resume.e2e.ts | 3 ++- .../mocks/jsons/defect710619/expectedResumeWithVGResults.json | 3 ++- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/vid-app-common/src/main/webapp/app/vid/scripts/modals/vf-module-homing-data-action/vf-module-homing-data-action.controller.js b/vid-app-common/src/main/webapp/app/vid/scripts/modals/vf-module-homing-data-action/vf-module-homing-data-action.controller.js index 3b5384e14..a7f7e9128 100644 --- a/vid-app-common/src/main/webapp/app/vid/scripts/modals/vf-module-homing-data-action/vf-module-homing-data-action.controller.js +++ b/vid-app-common/src/main/webapp/app/vid/scripts/modals/vf-module-homing-data-action/vf-module-homing-data-action.controller.js @@ -50,7 +50,7 @@ var vfModuleActionModalController = function(COMPONENT, FIELD, $scope, $uibModal DataService.setCloudRegionTenantList(response); $scope.lcpAndTenant = response; $scope.isFeatureFlagCloudOwner = featureFlags.isOn(COMPONENT.FEATURE_FLAGS.FLAG_1810_CR_ADD_CLOUD_OWNER_TO_MSO_REQUEST); - $scope.lcpRegionList = _.uniqBy(response, 'cloudRegionId'); + $scope.lcpRegionList = _.uniqBy(response, 'cloudRegionOptionId'); $scope.vendorInCloudOwnerRegex = /^[^-]*-/; }); } diff --git a/vid-app-common/src/main/webapp/app/vid/scripts/modals/vf-module-homing-data-action/vf-module-homing-data-action.html b/vid-app-common/src/main/webapp/app/vid/scripts/modals/vf-module-homing-data-action/vf-module-homing-data-action.html index eb67e6ed9..3fbe07e83 100644 --- a/vid-app-common/src/main/webapp/app/vid/scripts/modals/vf-module-homing-data-action/vf-module-homing-data-action.html +++ b/vid-app-common/src/main/webapp/app/vid/scripts/modals/vf-module-homing-data-action/vf-module-homing-data-action.html @@ -58,11 +58,11 @@ data-tests-id="lcpRegion" data-ng-model="regionSelection.lcpRegion" data-ng-change="regionSelection.tenant = null; regionSelection.legacyRegion = null;"> - - @@ -81,7 +81,7 @@ data-tests-id="tenant" data-ng-model="regionSelection.tenant"> diff --git a/vid-webpack-master/cypress/integration/iFrames/resume.e2e.ts b/vid-webpack-master/cypress/integration/iFrames/resume.e2e.ts index 65913d46b..cec915a91 100644 --- a/vid-webpack-master/cypress/integration/iFrames/resume.e2e.ts +++ b/vid-webpack-master/cypress/integration/iFrames/resume.e2e.ts @@ -84,6 +84,7 @@ describe('Resume tests', function () { status : 200, url : Cypress.config('baseUrl') + "/flags**", response : { + "FLAG_1810_CR_ADD_CLOUD_OWNER_TO_MSO_REQUEST" : true, "FLAG_ADD_MSO_TESTAPI_FIELD": true, "FLAG_1810_CR_SOFT_DELETE_ALACARTE_VF_MODULE": false } @@ -103,7 +104,7 @@ describe('Resume tests', function () { .getElementByDataTestsId('resumeVFModuleButton-' + vfModuleName).click().then(()=> { cy.getElementByDataTestsId('confirmResumeDeleteButton').should('be.visible') .getElementByDataTestsId('softDeleteButton').should('not.be.visible') - .getElementByDataTestsId('lcpRegion').should('be.visible').select("hvf6") + .getElementByDataTestsId('lcpRegion').should('be.visible').select("option-irma-aic-hvf6") .getElementByDataTestsId('tenant').should('be.visible').select("bae71557c5bb4d5aac6743a4e5f1d054"); cy.getElementByDataTestsId('confirmResumeDeleteButton').not('.button--inactive').click().then(()=> { cy.wait('@actualResumeCall').then(xhr => { diff --git a/vid-webpack-master/cypress/support/jsonBuilders/mocks/jsons/defect710619/expectedResumeWithVGResults.json b/vid-webpack-master/cypress/support/jsonBuilders/mocks/jsons/defect710619/expectedResumeWithVGResults.json index 53cb341a1..d10c2bd32 100644 --- a/vid-webpack-master/cypress/support/jsonBuilders/mocks/jsons/defect710619/expectedResumeWithVGResults.json +++ b/vid-webpack-master/cypress/support/jsonBuilders/mocks/jsons/defect710619/expectedResumeWithVGResults.json @@ -22,7 +22,8 @@ }, "cloudConfiguration": { "lcpCloudRegionId": "hvf6", - "tenantId": "bae71557c5bb4d5aac6743a4e5f1d054" + "tenantId": "bae71557c5bb4d5aac6743a4e5f1d054", + "cloudOwner": "irma-aic" }, "relatedInstanceList": [{ "relatedInstance": { -- 2.16.6