From 9a40270c21325804164ae30caf90ed75711143f2 Mon Sep 17 00:00:00 2001 From: wasala Date: Tue, 3 Apr 2018 08:13:01 +0200 Subject: [PATCH] Fixed Sonar Issues Deleted useless code Change-Id: I8d813d82c5b8b6ae3093d5d6fdec1688dd8eae6d Issue-ID: DCAEGEN2-407 Signed-off-by: wasala --- .../services/prh/tasks/DmaapConsumerTask.java | 1 - .../dcaegen2/services/prh/tasks/ScheduledTask.java | 2 +- .../onap/dcaegen2/services/config/DmaapConfig.java | 29 ---------------------- .../services/config/DmaapCustomConfig.java | 4 ++- .../config/DmaapProducerConfiguration.java | 6 +++-- 5 files changed, 8 insertions(+), 34 deletions(-) delete mode 100644 prh-dmaap-client/src/main/java/org/onap/dcaegen2/services/config/DmaapConfig.java diff --git a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapConsumerTask.java b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapConsumerTask.java index 0762fc81..706794f0 100644 --- a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapConsumerTask.java +++ b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/DmaapConsumerTask.java @@ -38,7 +38,6 @@ public class DmaapConsumerTask implements DmaapTask { public void execute() { logger.debug("Start task DmaapConsumerTask::execute() :: Execution Time - {}", dateTimeFormatter.format( LocalDateTime.now())); - //TODO: ADD implementation for executing request to consume topic from dmaap logger.debug("End task DmaapConsumerTask::execute() :: Execution Time - {}", dateTimeFormatter.format(LocalDateTime.now())); diff --git a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/ScheduledTask.java b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/ScheduledTask.java index 277bc707..90c1466c 100644 --- a/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/ScheduledTask.java +++ b/prh-app-server/src/main/java/org/onap/dcaegen2/services/prh/tasks/ScheduledTask.java @@ -56,7 +56,7 @@ public class ScheduledTask { logger .error("Task scheduledTaskAskingDMaaPOfConsumeEvent()::AAINotFoundException :: Execution Time - {}:{}", dateTimeFormatter.format( - LocalDateTime.now()), e.getMessage()); + LocalDateTime.now()), e); } } diff --git a/prh-dmaap-client/src/main/java/org/onap/dcaegen2/services/config/DmaapConfig.java b/prh-dmaap-client/src/main/java/org/onap/dcaegen2/services/config/DmaapConfig.java deleted file mode 100644 index 430a103a..00000000 --- a/prh-dmaap-client/src/main/java/org/onap/dcaegen2/services/config/DmaapConfig.java +++ /dev/null @@ -1,29 +0,0 @@ -/*- - * ============LICENSE_START======================================================= - * PNF-REGISTRATION-HANDLER - * ================================================================================ - * Copyright (C) 2018 NOKIA Intellectual Property. All rights reserved. - * ================================================================================ - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - * ============LICENSE_END========================================================= - */ -package org.onap.dcaegen2.services.config; - -import java.io.Serializable; - -/** - * @author Przemysław Wąsala on 3/23/18 - */ -interface DmaapConfig extends Serializable { - -} diff --git a/prh-dmaap-client/src/main/java/org/onap/dcaegen2/services/config/DmaapCustomConfig.java b/prh-dmaap-client/src/main/java/org/onap/dcaegen2/services/config/DmaapCustomConfig.java index 1026cc31..ee849338 100644 --- a/prh-dmaap-client/src/main/java/org/onap/dcaegen2/services/config/DmaapCustomConfig.java +++ b/prh-dmaap-client/src/main/java/org/onap/dcaegen2/services/config/DmaapCustomConfig.java @@ -19,10 +19,12 @@ */ package org.onap.dcaegen2.services.config; +import java.io.Serializable; + /** * @author Przemysław Wąsala on 3/28/18 */ -public interface DmaapCustomConfig extends DmaapConfig { +public interface DmaapCustomConfig extends Serializable { String dmmaphostName(); diff --git a/prh-dmaap-client/src/main/java/org/onap/dcaegen2/services/config/DmaapProducerConfiguration.java b/prh-dmaap-client/src/main/java/org/onap/dcaegen2/services/config/DmaapProducerConfiguration.java index 550d9799..b63d68bd 100644 --- a/prh-dmaap-client/src/main/java/org/onap/dcaegen2/services/config/DmaapProducerConfiguration.java +++ b/prh-dmaap-client/src/main/java/org/onap/dcaegen2/services/config/DmaapProducerConfiguration.java @@ -30,11 +30,13 @@ public abstract class DmaapProducerConfiguration implements DmaapCustomConfig { private static final long serialVersionUID = 1L; - public interface Builder extends + interface Builder extends DmaapCustomConfig.Builder { } - public static Builder builder() { + public static DmaapProducerConfiguration.Builder builder() { return ImmutableDmaapProducerConfiguration.builder(); } + + } -- 2.16.6