From bd3aca53b345da9602eb7dba93eba4acfd3513c9 Mon Sep 17 00:00:00 2001 From: Abhai Singh Date: Thu, 4 Jan 2018 11:46:40 +0530 Subject: [PATCH] Fix Sonar ImageDaoZusammenImpl Fixed reported sonar issue Change-Id: I129fa4cbb5ba09c361663f7259807fca690eff0e Issue-ID: SDC-343 Signed-off-by: Abhai Singh --- .../dao/impl/zusammen/ImageDaoZusammenImpl.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java b/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java index 24ca072b23..d6a56bb612 100644 --- a/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java +++ b/openecomp-be/lib/openecomp-sdc-vendor-software-product-lib/openecomp-sdc-vendor-software-product-core/src/main/java/org/openecomp/sdc/vendorsoftwareproduct/dao/impl/zusammen/ImageDaoZusammenImpl.java @@ -38,6 +38,7 @@ public class ImageDaoZusammenImpl implements ImageDao { @Override public void registerVersioning(String versionableEntityType) { + // registerVersioning not implemented for ImageDaoZusammenImpl } @Override @@ -51,11 +52,10 @@ public class ImageDaoZusammenImpl implements ImageDao { private Collection listImages(SessionContext context, ElementContext elementContext, ImageEntity image) { - ElementToImageConvertor convertor = new ElementToImageConvertor(); return zusammenAdaptor .listElementsByName(context, elementContext, new Id(image.getComponentId()), ElementType.Images.name()) - .stream().map(convertor::convert) + .stream().map(new ElementToImageConvertor()::convert) .map(imageEntity -> { imageEntity.setComponentId(image.getComponentId()); imageEntity.setVspId(image.getVspId()); @@ -137,9 +137,9 @@ public class ImageDaoZusammenImpl implements ImageDao { null, ElementType.Images.name()); if (elementOptional.isPresent()) { - Element ImagesElement = elementOptional.get(); - Collection Images = ImagesElement.getSubElements(); - Images.forEach(image -> { + Element imagesElement = elementOptional.get(); + Collection images = imagesElement.getSubElements(); + images.forEach(image -> { ZusammenElement imageZusammenElement = buildElement(image.getElementId(), Action.DELETE); zusammenAdaptor.saveElement(context, elementContext, imageZusammenElement, "Delete image " + "with id " + image.getElementId()); -- 2.16.6