From 34c30f8bf888459e57b2760125922f6f57dc0570 Mon Sep 17 00:00:00 2001
From: shivasubedi <shiva.subedi@est.tech>
Date: Wed, 7 Jul 2021 16:30:36 +0100
Subject: [PATCH] Remove unnecessary version properties

Issue-ID: CPS-495
Signed-off-by: shivasubedi <shiva.subedi@est.tech>
Change-Id: I05fa719442c1ebb267cf50a0122055f94958144a
---
 cps-dependencies/pom.xml | 46 +++++++++++++++-------------------------------
 cps-parent/pom.xml       | 22 +++++++---------------
 2 files changed, 22 insertions(+), 46 deletions(-)

diff --git a/cps-dependencies/pom.xml b/cps-dependencies/pom.xml
index 9fd2f6b30..8be6e1ccc 100755
--- a/cps-dependencies/pom.xml
+++ b/cps-dependencies/pom.xml
@@ -30,28 +30,12 @@
     <description>This artifact contains dependencyManagement declarations of upstream versions.</description>
 
     <properties>
-        <antlr4-runtime.version>4.9.2</antlr4-runtime.version>
-        <archunit.version>0.18.0</archunit.version>
-        <cglib-nodep.version>3.1</cglib-nodep.version>
-        <commons-codec.version>1.15</commons-codec.version>
-        <commons-lang3.version>3.11</commons-lang3.version>
         <groovy.version>3.0.8</groovy.version>
-        <hibernate-types.version>2.10.0</hibernate-types.version>
-        <liquibase.version>4.3.1</liquibase.version>
         <nexusproxy>https://nexus.onap.org</nexusproxy>
         <releaseNexusPath>/content/repositories/releases/</releaseNexusPath>
         <snapshotNexusPath>/content/repositories/snapshots/</snapshotNexusPath>
-        <modelmapper.version>2.3.8</modelmapper.version>
         <sonar.skip>true</sonar.skip>
-        <spock-core.version>2.0-M5-groovy-3.0</spock-core.version>
-        <spock-spring.version>2.0-M5-groovy-3.0</spock-spring.version>
-        <spotbugs.version>4.2.0</spotbugs.version>
-        <springboot.version>2.5.0</springboot.version>
-        <springboot.cloud.version>2020.0.2</springboot.cloud.version>
-        <springfox.version>3.0.0</springfox.version>
-        <swagger.version>2.1.4</swagger.version>
         <testcontainers.version>1.15.1</testcontainers.version>
-        <yangtools.version>5.0.7</yangtools.version>
     </properties>
 
     <distributionManagement>
@@ -72,28 +56,28 @@
             <dependency>
                 <groupId>org.springframework.boot</groupId>
                 <artifactId>spring-boot-dependencies</artifactId>
-                <version>${springboot.version}</version>
+                <version>2.5.0</version>
                 <type>pom</type>
                 <scope>import</scope>
             </dependency>
             <dependency>
                 <groupId>org.springframework.cloud</groupId>
                 <artifactId>spring-cloud-dependencies</artifactId>
-                <version>${springboot.cloud.version}</version>
+                <version>2020.0.2</version>
                 <type>pom</type>
                 <scope>import</scope>
             </dependency>
             <dependency>
                 <groupId>org.opendaylight.yangtools</groupId>
                 <artifactId>yangtools-artifacts</artifactId>
-                <version>${yangtools.version}</version>
+                <version>5.0.7</version>
                 <type>pom</type>
                 <scope>import</scope>
             </dependency>
             <dependency>
                 <groupId>io.swagger.core.v3</groupId>
                 <artifactId>swagger-annotations</artifactId>
-                <version>${swagger.version}</version>
+                <version>2.1.4</version>
             </dependency>
             <!---To be removed once swagger-codegen-maven-plugin is upgraded-->
             <dependency>
@@ -104,17 +88,17 @@
             <dependency>
                 <groupId>io.springfox</groupId>
                 <artifactId>springfox-boot-starter</artifactId>
-                <version>${springfox.version}</version>
+                <version>3.0.0</version>
             </dependency>
             <dependency>
                 <groupId>com.vladmihalcea</groupId>
                 <artifactId>hibernate-types-52</artifactId>
-                <version>${hibernate-types.version}</version>
+                <version>2.10.0</version>
             </dependency>
             <dependency>
                 <groupId>org.antlr</groupId>
                 <artifactId>antlr4-runtime</artifactId>
-                <version>${antlr4-runtime.version}</version>
+                <version>4.9.2</version>
             </dependency>
             <dependency>
                 <groupId>org.codehaus.groovy</groupId>
@@ -129,27 +113,27 @@
             <dependency>
                 <groupId>org.spockframework</groupId>
                 <artifactId>spock-core</artifactId>
-                <version>${spock-core.version}</version>
+                <version>2.0-M5-groovy-3.0</version>
             </dependency>
             <dependency>
                 <groupId>org.spockframework</groupId>
                 <artifactId>spock-spring</artifactId>
-                <version>${spock-spring.version}</version>
+                <version>2.0-M5-groovy-3.0</version>
             </dependency>
             <dependency>
                 <groupId>cglib</groupId>
                 <artifactId>cglib-nodep</artifactId>
-                <version>${cglib-nodep.version}</version>
+                <version>3.1</version>
             </dependency>
             <dependency>
                 <groupId>org.apache.commons</groupId>
                 <artifactId>commons-lang3</artifactId>
-                <version>${commons-lang3.version}</version>
+                <version>3.11</version>
             </dependency>
             <dependency>
                 <groupId>org.modelmapper</groupId>
                 <artifactId>modelmapper</artifactId>
-                <version>${modelmapper.version}</version>
+                <version>2.3.8</version>
             </dependency>
             <dependency>
                 <groupId>org.testcontainers</groupId>
@@ -169,17 +153,17 @@
             <dependency>
                 <groupId>com.github.spotbugs</groupId>
                 <artifactId>spotbugs</artifactId>
-                <version>${spotbugs.version}</version>
+                <version>4.2.0</version>
             </dependency>
             <dependency>
                 <groupId>org.liquibase</groupId>
                 <artifactId>liquibase-core</artifactId>
-                <version>${liquibase.version}</version>
+                <version>4.3.1</version>
             </dependency>
             <dependency>
                 <groupId>com.tngtech.archunit</groupId>
                 <artifactId>archunit-junit5</artifactId>
-                <version>${archunit.version}</version>
+                <version>0.18.0</version>
                 <scope>test</scope>
             </dependency>
         </dependencies>
diff --git a/cps-parent/pom.xml b/cps-parent/pom.xml
index bd857720c..d8660d0e9 100755
--- a/cps-parent/pom.xml
+++ b/cps-parent/pom.xml
@@ -38,15 +38,7 @@
     <properties>
         <app>org.onap.cps.Application</app>
         <java.version>11</java.version>
-        <jsonschema2pojo-maven-plugin.version>1.1.1</jsonschema2pojo-maven-plugin.version>
         <minimum-coverage>0.9</minimum-coverage>
-        <oparent.version>3.1.0</oparent.version>
-        <spotbugs-maven-plugin.version>4.1.3</spotbugs-maven-plugin.version>
-        <spotbugs.slf4j.version>1.8.0-beta4</spotbugs.slf4j.version>
-        <spotbugs.bug-pattern.version>1.5.0</spotbugs.bug-pattern.version>
-        <spotbugs.version>4.2.0</spotbugs.version>
-        <spring-boot-maven-plugin.version>2.3.3.RELEASE</spring-boot-maven-plugin.version>
-        <swagger-codegen-maven-plugin.version>3.0.18</swagger-codegen-maven-plugin.version>
 
         <jacoco.reportDirectory.aggregate>${project.reporting.outputDirectory}/jacoco-aggregate</jacoco.reportDirectory.aggregate>
         <sonar.coverage.jacoco.xmlReportPaths>
@@ -111,7 +103,7 @@
                 <plugin>
                     <groupId>org.springframework.boot</groupId>
                     <artifactId>spring-boot-maven-plugin</artifactId>
-                    <version>${spring-boot-maven-plugin.version}</version>
+                    <version>2.3.3.RELEASE</version>
                     <executions>
                         <execution>
                             <goals>
@@ -125,17 +117,17 @@
                 <plugin>
                     <groupId>io.swagger.codegen.v3</groupId>
                     <artifactId>swagger-codegen-maven-plugin</artifactId>
-                    <version>${swagger-codegen-maven-plugin.version}</version>
+                    <version>3.0.18</version>
                 </plugin>
                 <plugin>
                     <groupId>com.github.spotbugs</groupId>
                     <artifactId>spotbugs-maven-plugin</artifactId>
-                    <version>${spotbugs-maven-plugin.version}</version>
+                    <version>4.1.3</version>
                     <dependencies>
                         <dependency>
                             <groupId>com.github.spotbugs</groupId>
                             <artifactId>spotbugs</artifactId>
-                            <version>${spotbugs.version}</version>
+                            <version>4.2.0</version>
                         </dependency>
                         <dependency>
                             <groupId>${project.groupId}</groupId>
@@ -146,7 +138,7 @@
                             <!-- The SpotBugs Maven plugin uses SLF4J 1.8 beta 2 -->
                             <groupId>org.slf4j</groupId>
                             <artifactId>slf4j-simple</artifactId>
-                            <version>${spotbugs.slf4j.version}</version>
+                            <version>1.8.0-beta4</version>
                         </dependency>
                     </dependencies>
                     <configuration>
@@ -191,7 +183,7 @@
                 <plugin>
                     <groupId>org.jsonschema2pojo</groupId>
                     <artifactId>jsonschema2pojo-maven-plugin</artifactId>
-                    <version>${jsonschema2pojo-maven-plugin.version}</version>
+                    <version>1.1.1</version>
                     <configuration>
                         <targetVersion>${java.version}</targetVersion>
                     </configuration>
@@ -280,7 +272,7 @@
                     <dependency>
                         <groupId>org.onap.oparent</groupId>
                         <artifactId>checkstyle</artifactId>
-                        <version>${oparent.version}</version>
+                        <version>3.1.0</version>
                     </dependency>
                     <dependency>
                         <groupId>${project.groupId}</groupId>
-- 
2.16.6