From d0c2403f1f7088d60b135976c40917302daf8b9e Mon Sep 17 00:00:00 2001 From: "andre.schmid" Date: Tue, 22 Feb 2022 13:50:12 +0000 Subject: [PATCH] Fix bottleneck on simulator requests Removes unnecessary synchronized in one of the simulator methods, which almost all calls pass through. This was restricting to execute calls in parallel. Change-Id: I7c53eee951c02031b78adacdc292aa51e6e66186 Issue-ID: SDC-3885 Signed-off-by: andre.schmid --- .../component/workspace/InterfaceDefinitionOperationsModal.java | 5 +++++ .../src/main/java/org/openecomp/sdc/webseal/simulator/SdcProxy.java | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/integration-tests/src/test/java/org/onap/sdc/frontend/ci/tests/pages/component/workspace/InterfaceDefinitionOperationsModal.java b/integration-tests/src/test/java/org/onap/sdc/frontend/ci/tests/pages/component/workspace/InterfaceDefinitionOperationsModal.java index cb2ee3d282..c8af405411 100644 --- a/integration-tests/src/test/java/org/onap/sdc/frontend/ci/tests/pages/component/workspace/InterfaceDefinitionOperationsModal.java +++ b/integration-tests/src/test/java/org/onap/sdc/frontend/ci/tests/pages/component/workspace/InterfaceDefinitionOperationsModal.java @@ -20,6 +20,7 @@ package org.onap.sdc.frontend.ci.tests.pages.component.workspace; import com.aventstack.extentreports.Status; +import java.time.Duration; import lombok.AllArgsConstructor; import lombok.Getter; import org.onap.sdc.frontend.ci.tests.execute.setup.ExtentTestActions; @@ -27,6 +28,7 @@ import org.onap.sdc.frontend.ci.tests.pages.AbstractPageObject; import org.openqa.selenium.By; import org.openqa.selenium.WebDriver; import org.openqa.selenium.WebElement; +import org.openqa.selenium.interactions.Actions; /** * Represents the Composition Interface Operations Modal. @@ -67,6 +69,9 @@ public class InterfaceDefinitionOperationsModal extends AbstractPageObject { fillInputName(interfaceOperationsData.getInputName()); fillInputValue(interfaceOperationsData.getInputValue()); clickOnSave(); + //there is no feedback from the UI to check if the update was successful. Forcing a wait time trying to guarantee that, + // although time is never a guarantee in this case. + new Actions(webDriver).pause(Duration.ofSeconds(5)).perform(); } private void fillDescription(final String description) { diff --git a/utils/webseal-simulator/src/main/java/org/openecomp/sdc/webseal/simulator/SdcProxy.java b/utils/webseal-simulator/src/main/java/org/openecomp/sdc/webseal/simulator/SdcProxy.java index 51d6796c4c..0637f7e29f 100644 --- a/utils/webseal-simulator/src/main/java/org/openecomp/sdc/webseal/simulator/SdcProxy.java +++ b/utils/webseal-simulator/src/main/java/org/openecomp/sdc/webseal/simulator/SdcProxy.java @@ -146,7 +146,7 @@ public class SdcProxy extends HttpServlet { proxy(request, response, MethodEnum.DELETE); } - private synchronized void proxy(HttpServletRequest request, HttpServletResponse response, MethodEnum methodEnum) throws IOException { + private void proxy(HttpServletRequest request, HttpServletResponse response, MethodEnum methodEnum) throws IOException { Map requestParameters = request.getParameterMap(); String userIdHeader = getUseridFromRequest(request); -- 2.16.6