From b66daa5aa2d3fa3645f579bfd7a69ccf5a48be2f Mon Sep 17 00:00:00 2001 From: rameshiyer27 Date: Mon, 21 Mar 2022 00:00:03 +0000 Subject: [PATCH 1/1] Fix spring transaction issue in getNodetemplates changes on the db service template object gets auto updated to the db by spring transaction. Creating new object copy to avoid the same. Issue-ID: POLICY-3934 Signed-off-by: zrrmmua Change-Id: I0dbd5cb9d2c1119b2f263f60ed470bc8fef85d1e --- .../org/onap/policy/api/main/service/ToscaServiceTemplateService.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/main/src/main/java/org/onap/policy/api/main/service/ToscaServiceTemplateService.java b/main/src/main/java/org/onap/policy/api/main/service/ToscaServiceTemplateService.java index d578d0dc..2e8fc9eb 100644 --- a/main/src/main/java/org/onap/policy/api/main/service/ToscaServiceTemplateService.java +++ b/main/src/main/java/org/onap/policy/api/main/service/ToscaServiceTemplateService.java @@ -550,14 +550,13 @@ public class ToscaServiceTemplateService { throws PfModelException { LOGGER.debug("->getNodeTemplate: name={}, version={}", name, version); List nodeTemplates = new ArrayList<>(); - var jpaNodeTemplates = new JpaToscaNodeTemplates(); var dbServiceTemplate = getDefaultJpaToscaServiceTemplate(); //Return empty if no nodeTemplates present in db if (!ToscaUtils.doNodeTemplatesExist(dbServiceTemplate)) { return nodeTemplates; } - jpaNodeTemplates = dbServiceTemplate.getTopologyTemplate().getNodeTemplates(); + var jpaNodeTemplates = new JpaToscaNodeTemplates(dbServiceTemplate.getTopologyTemplate().getNodeTemplates()); //Filter specific nodeTemplates if (name != null && version != null) { -- 2.16.6