From b46951a48fb48748c61029c1fa3d4cca374ec48c Mon Sep 17 00:00:00 2001 From: Remigiusz Janeczek Date: Tue, 17 Nov 2020 09:54:08 +0100 Subject: [PATCH] [CLIENT] Change certService client to use comma as SANS delimiter Issue-ID: OOM-2632 Signed-off-by: Remigiusz Janeczek Change-Id: I12a39cd514261a555081addb333ef1a99a481424 --- README.md | 3 ++- certService/pom.xml | 4 ++-- certService/version.properties | 2 +- certServiceClient/pom.xml | 4 ++-- .../client/configuration/factory/CsrConfigurationFactory.java | 2 +- .../client/configuration/factory/CsrConfigurationFactoryTest.java | 4 ++-- certServiceClient/version.properties | 2 +- certServiceK8sExternalProvider/pom.xml | 2 +- certServicePostProcessor/pom.xml | 4 ++-- docs/sections/usage.rst | 4 ++-- pom.xml | 2 +- version.properties | 2 +- 12 files changed, 18 insertions(+), 17 deletions(-) diff --git a/README.md b/README.md index 04c3009d..0f4531f2 100644 --- a/README.md +++ b/README.md @@ -7,10 +7,11 @@ More information about the project and all its functionalities you can find unde https://wiki.onap.org/display/DW/OOM+Certification+Service ``` -Project consists of three submodules: +Project consists of four submodules: 1. oom-certservice-api 2. oom-certservice-client 3. oom-certservice-post-processor +4. oom-certservice-k8s-external-provider Detailed information about submodules can be found in ```README.md``` in their directories. diff --git a/certService/pom.xml b/certService/pom.xml index 2c7b5d44..e3e98174 100644 --- a/certService/pom.xml +++ b/certService/pom.xml @@ -18,10 +18,10 @@ org.onap.oom.platform.cert-service oom-certservice - 2.2.0-SNAPSHOT + 2.3.0-SNAPSHOT oom-certservice-api - 2.2.0-SNAPSHOT + 2.3.0-SNAPSHOT oom-certservice-api OOM Certification Service Api jar diff --git a/certService/version.properties b/certService/version.properties index 3ad2137c..8d40756c 100644 --- a/certService/version.properties +++ b/certService/version.properties @@ -1,5 +1,5 @@ major=2 -minor=2 +minor=3 patch=0 base_version=${major}.${minor}.${patch} release_version=${base_version} diff --git a/certServiceClient/pom.xml b/certServiceClient/pom.xml index 9201b813..a99732eb 100644 --- a/certServiceClient/pom.xml +++ b/certServiceClient/pom.xml @@ -18,12 +18,12 @@ oom-certservice org.onap.oom.platform.cert-service - 2.2.0-SNAPSHOT + 2.3.0-SNAPSHOT 4.0.0 oom-certservice-client - 2.2.0-SNAPSHOT + 2.3.0-SNAPSHOT oom-certservice-client OOM Certification Service Api Client jar diff --git a/certServiceClient/src/main/java/org/onap/oom/certservice/client/configuration/factory/CsrConfigurationFactory.java b/certServiceClient/src/main/java/org/onap/oom/certservice/client/configuration/factory/CsrConfigurationFactory.java index 3f87be52..d050a2a3 100644 --- a/certServiceClient/src/main/java/org/onap/oom/certservice/client/configuration/factory/CsrConfigurationFactory.java +++ b/certServiceClient/src/main/java/org/onap/oom/certservice/client/configuration/factory/CsrConfigurationFactory.java @@ -36,7 +36,7 @@ import org.slf4j.LoggerFactory; public class CsrConfigurationFactory implements ConfigurationFactory { private static final Logger LOGGER = LoggerFactory.getLogger(CsrConfigurationFactory.class); - private static final String SANS_DELIMITER = ":"; + private static final String SANS_DELIMITER = ","; private final EnvsForCsr envsForCsr; private final ValidatorsFactory validatorsFactory; diff --git a/certServiceClient/src/test/java/org/onap/oom/certservice/client/configuration/factory/CsrConfigurationFactoryTest.java b/certServiceClient/src/test/java/org/onap/oom/certservice/client/configuration/factory/CsrConfigurationFactoryTest.java index 238b979d..cdcefe2e 100644 --- a/certServiceClient/src/test/java/org/onap/oom/certservice/client/configuration/factory/CsrConfigurationFactoryTest.java +++ b/certServiceClient/src/test/java/org/onap/oom/certservice/client/configuration/factory/CsrConfigurationFactoryTest.java @@ -41,8 +41,8 @@ import static org.onap.oom.certservice.client.api.ExitStatus.CSR_CONFIGURATION_E public class CsrConfigurationFactoryTest { private static final String COMMON_NAME_VALID = "onap.org"; - private static final List SANS_SPLITTED_VALID = List.of("test-name"); - private static final String SANS_VALID = "test-name"; + private static final List SANS_SPLITTED_VALID = List.of("test-name", "test-name-1"); + private static final String SANS_VALID = "test-name,test-name-1"; private static final String COUNTRY_VALID = "US"; private static final String LOCATION_VALID = "San-Francisco"; private static final String ORGANIZATION_VALID = "Linux-Foundation"; diff --git a/certServiceClient/version.properties b/certServiceClient/version.properties index 3ad2137c..8d40756c 100644 --- a/certServiceClient/version.properties +++ b/certServiceClient/version.properties @@ -1,5 +1,5 @@ major=2 -minor=2 +minor=3 patch=0 base_version=${major}.${minor}.${patch} release_version=${base_version} diff --git a/certServiceK8sExternalProvider/pom.xml b/certServiceK8sExternalProvider/pom.xml index a34ffc3f..1672d10f 100644 --- a/certServiceK8sExternalProvider/pom.xml +++ b/certServiceK8sExternalProvider/pom.xml @@ -5,7 +5,7 @@ oom-certservice org.onap.oom.platform.cert-service - 2.2.0-SNAPSHOT + 2.3.0-SNAPSHOT 4.0.0 diff --git a/certServicePostProcessor/pom.xml b/certServicePostProcessor/pom.xml index 0e3e1608..bd79d85d 100644 --- a/certServicePostProcessor/pom.xml +++ b/certServicePostProcessor/pom.xml @@ -5,12 +5,12 @@ oom-certservice org.onap.oom.platform.cert-service - 2.2.0-SNAPSHOT + 2.3.0-SNAPSHOT 4.0.0 oom-certservice-post-processor - 2.2.0-SNAPSHOT + 2.3.0-SNAPSHOT oom-certservice-post-processor An application which conducts certificate post-processing like: merging truststores, copying keystores. jar diff --git a/docs/sections/usage.rst b/docs/sections/usage.rst index e4a75444..48570992 100644 --- a/docs/sections/usage.rst +++ b/docs/sections/usage.rst @@ -31,7 +31,7 @@ CertService client needs the following configuration parameters to work properly - LOCATION *(optional)* - Location for which certificate from CMPv2 server should be issued - STATE *(required)* - State for which certificate from CMPv2 server should be issued - COUNTRY *(required)* - Country for which certificate from CMPv2 server should be issued - - SANS *(optional)(SANS's should be separated by a colon e.g. test.onap.org:onap.com)* - Subject Alternative Names (SANs) for which certificate from CMPv2 server should be issued. + - SANS *(optional)(SANS's should be separated by a comma e.g. test.onap.org,onap.com)* - Subject Alternative Names (SANs) for which certificate from CMPv2 server should be issued. 3. Parameters to establish secure communication to CertService: @@ -71,7 +71,7 @@ To run CertService client as standalone docker container execute following steps LOCATION=San-Francisco STATE=California COUNTRY=US - SANS=test.onap.org:onap.com + SANS=test.onap.org,onap.com #TLS config envs KEYSTORE_PATH=/etc/onap/oom/certservice/certs/certServiceClient-keystore.jks diff --git a/pom.xml b/pom.xml index 179b7712..69b9e68b 100644 --- a/pom.xml +++ b/pom.xml @@ -23,7 +23,7 @@ org.onap.oom.platform.cert-service oom-certservice - 2.2.0-SNAPSHOT + 2.3.0-SNAPSHOT oom-certservice OOM Certification Service pom diff --git a/version.properties b/version.properties index 3ad2137c..8d40756c 100644 --- a/version.properties +++ b/version.properties @@ -1,5 +1,5 @@ major=2 -minor=2 +minor=3 patch=0 base_version=${major}.${minor}.${patch} release_version=${base_version} -- 2.16.6