From 955a4a0d2c1a1740fac46d6946e700442e6079c6 Mon Sep 17 00:00:00 2001 From: Arthur Martella Date: Wed, 18 Oct 2017 15:22:26 -0400 Subject: [PATCH] productFamilyId not found error catching Properly catch JsonException in case when productFamilyId is not present to let if block handle case where it's missing. Change-Id: Id6eb2aaf10bc8636470ced3fe96c1149bb7e905e Issue-id: SO-236 Signed-off-by: Arthur Martella --- .../scripts/CreateGenericALaCarteServiceInstance.groovy | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/bpmn/MSOInfrastructureBPMN/src/main/groovy/org/openecomp/mso/bpmn/infrastructure/scripts/CreateGenericALaCarteServiceInstance.groovy b/bpmn/MSOInfrastructureBPMN/src/main/groovy/org/openecomp/mso/bpmn/infrastructure/scripts/CreateGenericALaCarteServiceInstance.groovy index 9416e6851a..80d714893d 100644 --- a/bpmn/MSOInfrastructureBPMN/src/main/groovy/org/openecomp/mso/bpmn/infrastructure/scripts/CreateGenericALaCarteServiceInstance.groovy +++ b/bpmn/MSOInfrastructureBPMN/src/main/groovy/org/openecomp/mso/bpmn/infrastructure/scripts/CreateGenericALaCarteServiceInstance.groovy @@ -37,6 +37,7 @@ import org.camunda.bpm.engine.runtime.Execution import org.apache.commons.lang3.* import org.apache.commons.codec.binary.Base64; import org.springframework.web.util.UriUtils +import org.json.JSONException; /** * This groovy class supports the CreateGenericALaCarteServiceInstance.bpmn process. @@ -85,7 +86,12 @@ public class CreateGenericALaCarteServiceInstance extends AbstractServiceTaskPro execution.setVariable("source", jsonUtil.getJsonValue(siRequest, "requestDetails.requestInfo.source")) execution.setVariable("serviceInstanceName", jsonUtil.getJsonValue(siRequest, "requestDetails.requestInfo.instanceName")) execution.setVariable("disableRollback", jsonUtil.getJsonValue(siRequest, "requestDetails.requestInfo.suppressRollback")) - String productFamilyId = jsonUtil.getJsonValue(siRequest, "requestDetails.requestInfo.productFamilyId") + String productFamilyId = null; + try { + productFamilyId = jsonUtil.getJsonValue(siRequest, "requestDetails.requestInfo.productFamilyId") + } catch (JSONException e) { + productFamilyId = null; + } if (isBlank(productFamilyId)) { msg = "Input productFamilyId is null" -- 2.16.6