From 8a0a21d1031628619c3a359da4097cdc0d513e99 Mon Sep 17 00:00:00 2001 From: shashikanth Date: Fri, 22 Sep 2017 15:24:41 +0530 Subject: [PATCH] Fix Blocker/Critical sonar issues Fix Blocker/Critical sonar issues in so module https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=CRITICAL Fixed issue Remove this call to "equals"; comparisons between unrelated types always return false. Issue-Id:SO-118 Change-Id: I8e3594958a84efc933206655b7ff96a7d08c24e0 Signed-off-by: shashikanth.vh --- .../org/openecomp/mso/openstack/utils/MsoTenantUtilsFactory.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/utils/MsoTenantUtilsFactory.java b/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/utils/MsoTenantUtilsFactory.java index 219dac6907..bceb7496ab 100644 --- a/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/utils/MsoTenantUtilsFactory.java +++ b/adapters/mso-adapter-utils/src/main/java/org/openecomp/mso/openstack/utils/MsoTenantUtilsFactory.java @@ -20,14 +20,14 @@ package org.openecomp.mso.openstack.utils; -import java.lang.reflect.InvocationTargetException; import org.openecomp.mso.cloud.CloudConfig; import org.openecomp.mso.cloud.CloudConfigFactory; import org.openecomp.mso.cloud.CloudIdentity; import org.openecomp.mso.cloud.CloudSite; import org.openecomp.mso.logger.MsoLogger; import org.openecomp.mso.properties.MsoJavaProperties; -import org.openecomp.mso.openstack.utils.MsoKeystoneUtils; + +import java.lang.reflect.InvocationTargetException; public class MsoTenantUtilsFactory { @@ -55,7 +55,7 @@ public class MsoTenantUtilsFactory { public MsoTenantUtils getTenantUtilsByServerType(String serverType) { MsoTenantUtils tenantU = null; - if (CloudIdentity.IdentityServerType.KEYSTONE.equals(serverType)) { + if (CloudIdentity.IdentityServerType.KEYSTONE.toString().equals(serverType)) { tenantU = new MsoKeystoneUtils (msoPropID); } else { try { -- 2.16.6