From 89e153fdae1b12e96b284c90f79a96d4df31df6f Mon Sep 17 00:00:00 2001 From: Gerrit User 5047 <5047@14b4e41f-c4e3-4fb9-9955-6a9b5656895a> Date: Fri, 15 Jan 2021 10:12:46 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (1 comment) Patch-set: 2 --- a2a02463445ee785e7d8bb72f322a0c508102e70 | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/a2a02463445ee785e7d8bb72f322a0c508102e70 b/a2a02463445ee785e7d8bb72f322a0c508102e70 index 6fb1c89fc..756241ebc 100644 --- a/a2a02463445ee785e7d8bb72f322a0c508102e70 +++ b/a2a02463445ee785e7d8bb72f322a0c508102e70 @@ -22,6 +22,30 @@ "revId": "a2a02463445ee785e7d8bb72f322a0c508102e70", "serverId": "14b4e41f-c4e3-4fb9-9955-6a9b5656895a", "unresolved": true + }, + { + "key": { + "uuid": "86b45e4b_fe959b1b", + "filename": "deployment/noheat/infra-openstack/vagrant/Vagrantfile", + "patchSetId": 1 + }, + "lineNbr": 93, + "author": { + "id": 5047 + }, + "writtenOn": "2021-01-15T10:12:46Z", + "side": 1, + "message": "I agree that it would be beneficial to keep such scripts idempotent.\n\nThis one is set to never run (L150) unless directly requested (as recommended in post-up message L45) - typically once per environment lifetime. Use case I had in mind (and use mostly) is to \"vagrant up\" -\u003e run \"post-up msg\" recommendation -\u003e \"vagrant halt/up\" (when environment is needed). This way I download the image once, store it in DevStack and clean it from /tmp on next boot.\n\nLet me know which location you think would be good for such images (maybe \"/root/os_images\"?) - I\u0027ll patch this snippet with proper location and \"continue download\" flag for wget", + "parentUuid": "b2fc230a_c512d599", + "range": { + "startLine": 86, + "startChar": 0, + "endLine": 93, + "endChar": 6 + }, + "revId": "a2a02463445ee785e7d8bb72f322a0c508102e70", + "serverId": "14b4e41f-c4e3-4fb9-9955-6a9b5656895a", + "unresolved": true } ] } \ No newline at end of file -- 2.16.6