From 86fabf65c621914e38458d5362c78f9bce79c3a9 Mon Sep 17 00:00:00 2001
From: mprzybys <marcin.przybysz@nokia.com>
Date: Tue, 18 Feb 2020 13:33:33 +0000
Subject: [PATCH] Add test case for empty json body send to vesListener API

Issue-ID: INT-1448

Signed-off-by: Marcin Przybysz <marcin.przybysz@nokia.com>
Change-Id: Ic5b5c7fc19c733fe60eb9ab31a870c9b3446d6fb
---
 ...ndatory_domain.json => ves7_missing_mandatory_parameter.json} | 4 ++--
 tests/dcaegen2/testcases/assets/json_events/ves_empty_json.json  | 1 +
 tests/dcaegen2/testcases/dcae_ves.robot                          | 9 +++++++--
 tests/dcaegen2/testcases/resources/dcae_properties.robot         | 3 ++-
 4 files changed, 12 insertions(+), 5 deletions(-)
 rename tests/dcaegen2/testcases/assets/json_events/{ves7_missing_mandatory_domain.json => ves7_missing_mandatory_parameter.json} (96%)
 create mode 100644 tests/dcaegen2/testcases/assets/json_events/ves_empty_json.json

diff --git a/tests/dcaegen2/testcases/assets/json_events/ves7_missing_mandatory_domain.json b/tests/dcaegen2/testcases/assets/json_events/ves7_missing_mandatory_parameter.json
similarity index 96%
rename from tests/dcaegen2/testcases/assets/json_events/ves7_missing_mandatory_domain.json
rename to tests/dcaegen2/testcases/assets/json_events/ves7_missing_mandatory_parameter.json
index 51787555..60d31955 100644
--- a/tests/dcaegen2/testcases/assets/json_events/ves7_missing_mandatory_domain.json
+++ b/tests/dcaegen2/testcases/assets/json_events/ves7_missing_mandatory_parameter.json
@@ -26,8 +26,8 @@
             "eventSeverity": "CRITICAL",
             "vfStatus": "Active",
             "alarmAdditionalInformation": {
-                "PilotNumberPoolSize": "1000"
+               "PilotNumberPoolSize": "1000"
             }
         }
     }
-}
+}
\ No newline at end of file
diff --git a/tests/dcaegen2/testcases/assets/json_events/ves_empty_json.json b/tests/dcaegen2/testcases/assets/json_events/ves_empty_json.json
new file mode 100644
index 00000000..9e26dfee
--- /dev/null
+++ b/tests/dcaegen2/testcases/assets/json_events/ves_empty_json.json
@@ -0,0 +1 @@
+{}
\ No newline at end of file
diff --git a/tests/dcaegen2/testcases/dcae_ves.robot b/tests/dcaegen2/testcases/dcae_ves.robot
index e12097e2..c1635758 100644
--- a/tests/dcaegen2/testcases/dcae_ves.robot
+++ b/tests/dcaegen2/testcases/dcae_ves.robot
@@ -31,10 +31,15 @@ Publish Single VES VNF Measurement Event with wrong JSON
     [Documentation]   Post single event with invalid data to /eventListener/v7 endpoint and expect 400 Response Status Code
     Send Request And Validate Response  Publish Event To VES Collector  ${http_session}  ${VES_EVENTLISTENER_V7}  ${VES_INVALID_JSON_V7}  400
 
-Publish Single VES VNF Measurement Event with missing mandatory parameter domain
+Publish Single VES VNF Measurement Event with missing mandatory parameter
     [Tags]    DCAE-VESC-R1
     [Documentation]   Post single event with lack of one of the mandatory parameters "domain" to /eventListener/v7 endpoint and expect 400 Response Status Code
-    Send Request And Validate Response  Publish Event To VES Collector  ${http_session}  ${VES_EVENTLISTENER_V7}  ${VES_MISSING_MANDATORY_DOMAIN_V7}  400
+    Send Request And Validate Response  Publish Event To VES Collector  ${http_session}  ${VES_EVENTLISTENER_V7}  ${VES_MISSING_MANDATORY_PARAMETER_V7}  400
+
+Publish Single VES VNF Measurement Event with empty json
+    [Tags]    DCAE-VESC-R1
+    [Documentation]   Post single event with empty json to /eventListener/v7 endpoint and expect 400 Response Status Code
+    Send Request And Validate Response  Publish Event To VES Collector  ${http_session}  ${VES_EVENTLISTENER_V7}  ${VES_EMPTY_JSON}  400
 
 Publish Single VES VNF Measurement Event with No Auth over HTTPS
     [Tags]    DCAE-VESC-R1
diff --git a/tests/dcaegen2/testcases/resources/dcae_properties.robot b/tests/dcaegen2/testcases/resources/dcae_properties.robot
index 5262330b..f287ba69 100644
--- a/tests/dcaegen2/testcases/resources/dcae_properties.robot
+++ b/tests/dcaegen2/testcases/resources/dcae_properties.robot
@@ -31,7 +31,8 @@ ${VES_EVENTLISTENER_V7}                  /eventListener/v7
 ${VES_BATCH_EVENT_ENDPOINT_V7}           /eventListener/v7/eventBatch
 ${VES_VALID_JSON_V7}                     %{WORKSPACE}/tests/dcaegen2/testcases/assets/json_events/ves7_valid.json
 ${VES_INVALID_JSON_V7}                   %{WORKSPACE}/tests/dcaegen2/testcases/assets/json_events/ves7_invalid.json
-${VES_MISSING_MANDATORY_DOMAIN_V7}       %{WORKSPACE}/tests/dcaegen2/testcases/assets/json_events/ves7_missing_mandatory_domain.json
+${VES_MISSING_MANDATORY_PARAMETER_V7}    %{WORKSPACE}/tests/dcaegen2/testcases/assets/json_events/ves7_missing_mandatory_parameter.json
+${VES_EMPTY_JSON}                        %{WORKSPACE}/tests/dcaegen2/testcases/assets/json_events/ves_empty_json.json
 ${VES_VALID_BATCH_JSON_V7}               %{WORKSPACE}/tests/dcaegen2/testcases/assets/json_events/ves7_batch_valid.json
 ${EVENT_DATA_FILE}                       %{WORKSPACE}/tests/dcaegen2/testcases/assets/json_events/ves_volte_single_fault_event.json
 ${EVENT_MEASURE_FILE}                    %{WORKSPACE}/tests/dcaegen2/testcases/assets/json_events/ves_vfirewall_measurement.json
-- 
2.16.6