From 3e7ef00ea13529ad35e4ff91c551237840d59366 Mon Sep 17 00:00:00 2001 From: anushadasari Date: Wed, 20 Nov 2019 16:43:57 +0530 Subject: [PATCH] Move "*" string literal on left side of string It is preferable to place string literals on the left-hand side of an equals() or equalsIgnoreCase() method call. Issue-ID: OPTFRA-647 Change-Id: Ibd04d10da4e655be44310ec0459f1fdeab791441 Signed-off-by: anushadasari --- cmso-service/src/main/java/org/onap/optf/cmso/aaf/AafPerm.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmso-service/src/main/java/org/onap/optf/cmso/aaf/AafPerm.java b/cmso-service/src/main/java/org/onap/optf/cmso/aaf/AafPerm.java index d324f18..b8e7f5b 100755 --- a/cmso-service/src/main/java/org/onap/optf/cmso/aaf/AafPerm.java +++ b/cmso-service/src/main/java/org/onap/optf/cmso/aaf/AafPerm.java @@ -90,9 +90,9 @@ public class AafPerm { */ public boolean ok(AafPerm userPerm) { if (type.equals(userPerm.getType())) { - if (userPerm.getInstance().equals("*") || instance.equals("*") || userPerm.getInstance().equals(instance)) { + if ("*".equals(userPerm.getInstance()) || "*".equals(instance) || userPerm.getInstance().equals(instance)) { for (String userAction : userPerm.getActions()) { - if (userAction.equals("*") || actions.contains("*") || actions.contains(userAction)) { + if ("*".equals(userAction) || actions.contains("*") || actions.contains(userAction)) { return true; } } -- 2.16.6