From 3ded702865858013429dda3f3af3d134748e5df7 Mon Sep 17 00:00:00 2001 From: edyta Date: Tue, 31 Mar 2020 15:43:06 +0200 Subject: [PATCH] Fix sonar issue KeyPairFactory Issue-ID: AAF-1118 Signed-off-by: Edyta Krukowska Change-Id: I61d714f30c2f4d21b3b4c538e0d85da55b9b322c --- .../onap/aaf/certservice/client/certification/KeyPairFactory.java | 4 ++-- .../client/certification/exception/KeyPairGenerationException.java | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/KeyPairFactory.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/KeyPairFactory.java index 5bf103ba..85b85ff3 100644 --- a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/KeyPairFactory.java +++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/KeyPairFactory.java @@ -42,8 +42,8 @@ public class KeyPairFactory { LOGGER.info("KeyPair generation started with algorithm: {} and key size: {}", encryptionAlgorithm, keySize); return createKeyPairGenerator().generateKeyPair(); } catch (NoSuchAlgorithmException e) { - LOGGER.error("Generation of KeyPair failed, exception message: {}", e.getMessage()); - throw new KeyPairGenerationException(e); + String errorMessage = String.format("Generation of KeyPair failed, exception message: %s", e.getMessage()); + throw new KeyPairGenerationException(errorMessage); } } diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/exception/KeyPairGenerationException.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/exception/KeyPairGenerationException.java index d03c819d..ec6fbb9c 100644 --- a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/exception/KeyPairGenerationException.java +++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/exception/KeyPairGenerationException.java @@ -24,10 +24,11 @@ import org.onap.aaf.certservice.client.api.ExitableException; public class KeyPairGenerationException extends ExitableException { private static final ExitStatus EXIT_STATUS = ExitStatus.KEY_PAIR_GENERATION_EXCEPTION; - public KeyPairGenerationException(Throwable e) { - super(e); + public KeyPairGenerationException(String errorMessage) { + super(errorMessage); } + public ExitStatus applicationExitStatus() { return EXIT_STATUS; } -- 2.16.6