From 30aa650ccfbd6dd2e98d2a1001e418c2a3c39fd3 Mon Sep 17 00:00:00 2001 From: edyta Date: Thu, 2 Apr 2020 10:57:18 +0200 Subject: [PATCH] Fix sonar secure issue RandomPasswordGenerator Issue-ID: AAF-1118 Signed-off-by: Edyta Krukowska Change-Id: I687b4af22ae07ce6d0bbbc5abfdf53635f30f54f --- .../client/certification/conversion/RandomPasswordGenerator.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/conversion/RandomPasswordGenerator.java b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/conversion/RandomPasswordGenerator.java index 5db7b26f..aa7d6151 100644 --- a/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/conversion/RandomPasswordGenerator.java +++ b/certServiceClient/src/main/java/org/onap/aaf/certservice/client/certification/conversion/RandomPasswordGenerator.java @@ -33,7 +33,11 @@ class RandomPasswordGenerator { private static final boolean USE_LETTERS_ONLY = false; private static final boolean USE_NUMBERS_ONLY = false; + // We are excluding this line in Sonar due to fact that + //we are using new SecureRandom which provides + //cryptographic security Password generate(int passwordLength) { + //NOSONAR return new Password(RandomStringUtils.random( passwordLength, START_POSITION_IN_ASCII_CHARS, -- 2.16.6