From 0fe2333d835dfd768f62fc08923e23410c786a65 Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Mon, 13 Jan 2020 16:36:38 -0500 Subject: [PATCH] Update docker images for java 11 Added debian-slim images based off of jre-slim. Removed alpine images from the build. If it's determined that we need a jdk instead of a jre, then "jre" can be changed to "jdk" in the policy-base Dockerfile. As an alternative, a new policy-docker-jdk image could be created, based off of "jdk" and all of the apt packages added to it. In that case, it would probably be appropriate to removed maven from the packages that are loaded into the policy-common image. Addressed first round of review comments: - use specific version of java 11 - removed docker-maven-plugin version - replaced the images with policy-jre-debian and policy-jdk-debian - added a policy-jdk-alpine image, which includes the jdk & maven, but is significantly smaller than the debian-slim version - added a policy-jre-alpine image Addressed additional review comments: - removed BUILD_VERSION - installed maven packages instead of downloading via curl - added link to /usr/lib/jvm Issue-ID: POLICY-1586 Signed-off-by: Jim Hahn Change-Id: I43fd6a5c5ff9c4a0b537d3f297fdf2ad8248ba75 --- docker_push_manifest.sh | 3 +- policy-base/alpine/README.md | 3 - {policy-common => policy-jdk}/alpine/README.md | 3 +- {policy-common => policy-jdk}/alpine/pom.xml | 16 +-- policy-jdk/alpine/src/main/docker/Dockerfile | 54 ++++++++ policy-jdk/debian-slim/README.md | 3 + policy-jdk/debian-slim/pom.xml | 154 +++++++++++++++++++++ policy-jdk/debian-slim/src/main/docker/Dockerfile | 48 +++++++ {policy-common => policy-jdk}/pom.xml | 4 +- policy-jre/alpine/README.md | 3 + policy-jre/alpine/pom.xml | 154 +++++++++++++++++++++ .../alpine/src/main/docker/Dockerfile | 53 +++---- policy-jre/debian-slim/README.md | 4 + .../alpine => policy-jre/debian-slim}/pom.xml | 14 +- .../debian-slim}/src/main/docker/Dockerfile | 38 ++--- {policy-base => policy-jre}/pom.xml | 4 +- pom.xml | 5 +- 17 files changed, 498 insertions(+), 65 deletions(-) delete mode 100644 policy-base/alpine/README.md rename {policy-common => policy-jdk}/alpine/README.md (76%) rename {policy-common => policy-jdk}/alpine/pom.xml (93%) create mode 100644 policy-jdk/alpine/src/main/docker/Dockerfile create mode 100644 policy-jdk/debian-slim/README.md create mode 100644 policy-jdk/debian-slim/pom.xml create mode 100644 policy-jdk/debian-slim/src/main/docker/Dockerfile rename {policy-common => policy-jdk}/pom.xml (92%) create mode 100644 policy-jre/alpine/README.md create mode 100644 policy-jre/alpine/pom.xml rename {policy-common => policy-jre}/alpine/src/main/docker/Dockerfile (55%) create mode 100644 policy-jre/debian-slim/README.md rename {policy-base/alpine => policy-jre/debian-slim}/pom.xml (93%) rename {policy-base/alpine => policy-jre/debian-slim}/src/main/docker/Dockerfile (62%) rename {policy-base => policy-jre}/pom.xml (92%) diff --git a/docker_push_manifest.sh b/docker_push_manifest.sh index 48ad65e2..210529fa 100755 --- a/docker_push_manifest.sh +++ b/docker_push_manifest.sh @@ -1,6 +1,7 @@ #!/bin/bash -ex # ============LICENSE_START======================================================= # Copyright (C) 2019 ENEA AB. All rights reserved. +# Modifications Copyright (C) 2020 AT&T Intellectual Property. All rights reserved. # ================================================================================ # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -21,7 +22,7 @@ # shellcheck source=/dev/null source version.properties -IMAGES="onap/policy-base-alpine onap/policy-common-alpine" +IMAGES="onap/policy-jre-alpine onap/policy-jre-debian onap/policy-jdk-alpine onap/policy-jdk-debian" ARCHES="amd64 arm64" TIMESTAMP=$(date -u +"%Y%m%d%H%M%S") MT_RELEASE='v0.9.0' diff --git a/policy-base/alpine/README.md b/policy-base/alpine/README.md deleted file mode 100644 index 71204051..00000000 --- a/policy-base/alpine/README.md +++ /dev/null @@ -1,3 +0,0 @@ -The base image for Policy project images. -Contains basic set of packages used in every Policy app container. - diff --git a/policy-common/alpine/README.md b/policy-jdk/alpine/README.md similarity index 76% rename from policy-common/alpine/README.md rename to policy-jdk/alpine/README.md index 1ac70df5..0798eab7 100644 --- a/policy-common/alpine/README.md +++ b/policy-jdk/alpine/README.md @@ -1,2 +1,3 @@ The common image for Policy project images. -Contains common set of packages used in most Policy apps containers. +Contains common set of packages used in most Policy apps containers +needing maven and a full JDK. diff --git a/policy-common/alpine/pom.xml b/policy-jdk/alpine/pom.xml similarity index 93% rename from policy-common/alpine/pom.xml rename to policy-jdk/alpine/pom.xml index b36221c4..b5df9e81 100644 --- a/policy-common/alpine/pom.xml +++ b/policy-jdk/alpine/pom.xml @@ -1,6 +1,7 @@ + + + + 4.0.0 + + + org.onap.policy.docker + policy-jdk + 2.0.0-SNAPSHOT + + + pom + policy-jdk-debian + Policy debian-slim jdk docker image + Policy debian-slim jdk docker image + + + ${project.artifactId}-${project.version} + + + org.codehaus.groovy.maven + gmaven-plugin + 1.0 + + + pre-clean + + execute + + + + println 'Project version: ' + project.properties['dist.project.version']; + def versionArray; + if ( project.properties['dist.project.version'] != null ) { + versionArray = project.properties['dist.project.version'].split('-'); + } + + if ( project.properties['dist.project.version'].endsWith("-SNAPSHOT") ) { + project.properties['project.docker.latesttag.version']=versionArray[0] + "-SNAPSHOT-latest"; + } else { + project.properties['project.docker.latesttag.version']=versionArray[0] + "-STAGING-latest"; + } + + println 'New tag for docker: ' + project.properties['project.docker.latesttag.version']; + if ( "aarch64".equals(System.properties['os.arch']) ) { + project.properties['project.docker.arch'] = "arm64"; + } else { + project.properties['project.docker.arch'] = System.properties['os.arch']; + } + println 'Using arch for docker: ' + project.properties['project.docker.arch']; + + + + + + + io.fabric8 + docker-maven-plugin + + + true + 1.23 + ${docker.pull.registry} + ${docker.push.registry} + + + onap/policy-jdk-debian:latest-${project.docker.arch} + + try + Dockerfile + + ${project.version}-${project.docker.arch} + ${project.docker.latesttag.version}-${project.docker.arch} + + + ${docker.build.version} + + + + + + + + + clean-images + pre-clean + + remove + + + true + + + + + generate-images + generate-sources + + build + + + + + push-images + deploy + + build + push + + + onap/policy-jdk-debian + + + + + + org.apache.maven.plugins + maven-deploy-plugin + + true + + + + org.apache.maven.plugins + maven-install-plugin + + true + + + + + + diff --git a/policy-jdk/debian-slim/src/main/docker/Dockerfile b/policy-jdk/debian-slim/src/main/docker/Dockerfile new file mode 100644 index 00000000..55b47d1b --- /dev/null +++ b/policy-jdk/debian-slim/src/main/docker/Dockerfile @@ -0,0 +1,48 @@ +# ============LICENSE_START======================================================= +# Copyright (C) 2020 AT&T Intellectual Property. All rights reserved. +# ================================================================================ +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# SPDX-License-Identifier: Apache-2.0 +# ============LICENSE_END========================================================= + +# Docker file to build a base image for all policy components images +# + +FROM maven:3.6-jdk-11 + +LABEL maintainer="Policy Team" + +ARG MAVEN_VERSION=3.6.3 +ARG SHA=c35a1803a6e70a126e80b2b3ae33eed961f83ed74d18fcd16909b2d44d7dada3203f1ffe726c17ef8dcca2dcaa9fca676987befeadc9b9f759967a8cb77181c0 +ARG BASE_URL="https://www.apache.org/dyn/mirrors/mirrors.cgi?cca2=us&preferred=http://apache.claz.org/&action=download&filename=maven/maven-3/${MAVEN_VERSION}/binaries" + +ENV POLICY_HOME=/opt/app/policy + +RUN apt-get -y update \ + && apt-get -y install \ + curl \ + httpie \ + jq \ + less \ + python \ + python-pip \ + ssh \ + unzip \ + wget \ + zip \ + && mkdir /usr/lib/jvm \ + && ln -s /usr/local/openjdk-11 /usr/lib/jvm/java-11-openjdk \ + && adduser --shell /bin/bash --disabled-password policy \ + && mkdir -p ${POLICY_HOME}/etc/ssl \ + && chown -R policy:policy ${POLICY_HOME} diff --git a/policy-common/pom.xml b/policy-jdk/pom.xml similarity index 92% rename from policy-common/pom.xml rename to policy-jdk/pom.xml index d63bf4e5..f0959453 100644 --- a/policy-common/pom.xml +++ b/policy-jdk/pom.xml @@ -1,6 +1,7 @@ + + + + 4.0.0 + + + org.onap.policy.docker + policy-jre + 2.0.0-SNAPSHOT + + + pom + policy-jre-alpine + Policy alpine jre docker image + Policy alpine jre docker image + + + ${project.artifactId}-${project.version} + + + org.codehaus.groovy.maven + gmaven-plugin + 1.0 + + + pre-clean + + execute + + + + println 'Project version: ' + project.properties['dist.project.version']; + def versionArray; + if ( project.properties['dist.project.version'] != null ) { + versionArray = project.properties['dist.project.version'].split('-'); + } + + if ( project.properties['dist.project.version'].endsWith("-SNAPSHOT") ) { + project.properties['project.docker.latesttag.version']=versionArray[0] + "-SNAPSHOT-latest"; + } else { + project.properties['project.docker.latesttag.version']=versionArray[0] + "-STAGING-latest"; + } + + println 'New tag for docker: ' + project.properties['project.docker.latesttag.version']; + if ( "aarch64".equals(System.properties['os.arch']) ) { + project.properties['project.docker.arch'] = "arm64"; + } else { + project.properties['project.docker.arch'] = System.properties['os.arch']; + } + println 'Using arch for docker: ' + project.properties['project.docker.arch']; + + + + + + + io.fabric8 + docker-maven-plugin + + + true + 1.23 + ${docker.pull.registry} + ${docker.push.registry} + + + onap/policy-jre-alpine:latest-${project.docker.arch} + + try + Dockerfile + + ${project.version}-${project.docker.arch} + ${project.docker.latesttag.version}-${project.docker.arch} + + + ${docker.build.version} + + + + + + + + + clean-images + pre-clean + + remove + + + true + + + + + generate-images + generate-sources + + build + + + + + push-images + deploy + + build + push + + + onap/policy-jre-alpine + + + + + + org.apache.maven.plugins + maven-deploy-plugin + + true + + + + org.apache.maven.plugins + maven-install-plugin + + true + + + + + + diff --git a/policy-common/alpine/src/main/docker/Dockerfile b/policy-jre/alpine/src/main/docker/Dockerfile similarity index 55% rename from policy-common/alpine/src/main/docker/Dockerfile rename to policy-jre/alpine/src/main/docker/Dockerfile index ba8d2d17..72704140 100644 --- a/policy-common/alpine/src/main/docker/Dockerfile +++ b/policy-jre/alpine/src/main/docker/Dockerfile @@ -1,5 +1,6 @@ # ============LICENSE_START======================================================= # Copyright (C) 2019 Tieto. All rights reserved. +# Modifications Copyright (C) 2020 AT&T Intellectual Property. All rights reserved. # ================================================================================ # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -16,33 +17,37 @@ # SPDX-License-Identifier: Apache-2.0 # ============LICENSE_END========================================================= +# Docker file to build a base image for all policy components images # -# Docker file to build an image that contains common packages for Policy components -# -FROM onap/policy-base-alpine:latest-${project.docker.arch} +# $JAVA_HOME is set to /usr/lib/jvm/java-11-openjdk +# more details at https://hub.docker.com/_/openjdk -LABEL maintainer="Policy Team" +FROM alpine:latest -ARG BUILD_VERSION=${BUILD_VERSION} +LABEL maintainer="Policy Team" -ENV BUILD_VERSION ${BUILD_VERSION} ENV POLICY_HOME=/opt/app/policy -# Install common packages used in 6 out of 7 images -RUN apk add --no-cache \ - busybox-extras \ - httpie \ - jq \ - maven \ - py-pip \ - python - -# Create policy user and group -RUN addgroup -S policy && \ - adduser -S --shell /bin/bash -G policy policy - -# Create common directories and change owner -RUN mkdir -p \ - ${POLICY_HOME}/etc/ssl \ - && chown -R policy:policy ${POLICY_HOME} ${POLICY_HOME}/etc/ssl - +RUN apk update \ + && apk add --no-cache \ + bash \ + busybox-extras \ + coreutils \ + curl \ + findutils \ + grep \ + httpie \ + jq \ + nss \ + openjdk11-jre \ + openssh \ + procps \ + py-pip \ + python \ + unzip \ + wget \ + zip \ + && addgroup -S policy \ + && adduser -S --shell /bin/bash -G policy policy \ + && mkdir -p ${POLICY_HOME}/etc/ssl \ + && chown -R policy:policy ${POLICY_HOME} diff --git a/policy-jre/debian-slim/README.md b/policy-jre/debian-slim/README.md new file mode 100644 index 00000000..40c870eb --- /dev/null +++ b/policy-jre/debian-slim/README.md @@ -0,0 +1,4 @@ +The common image for Policy project images. +Contains basic set of packages used in every Policy app container +needing a JRE, but not a full JDK. + diff --git a/policy-base/alpine/pom.xml b/policy-jre/debian-slim/pom.xml similarity index 93% rename from policy-base/alpine/pom.xml rename to policy-jre/debian-slim/pom.xml index d58a7772..b49710c0 100644 --- a/policy-base/alpine/pom.xml +++ b/policy-jre/debian-slim/pom.xml @@ -1,6 +1,7 @@