From da9e01a78e3205ee7238196a574adcf11c041797 Mon Sep 17 00:00:00 2001 From: Krishnajinka Date: Fri, 31 Aug 2018 20:01:30 +0900 Subject: [PATCH] Add basic main structure for policy-api Define main pom xml and update to include main. Add the main exception parameters rest startstop classes. Add test cases. Modify comments Issue-ID: POLICY-1066 Change-Id: I2e878a58eef4f021e3a9a991738194127edf4d16 Signed-off-by: krisjinka Signed-off-by: krishnajinka --- .gitignore | 1 + main/pom.xml | 86 +++++++ .../onap/policy/api/main/PolicyApiException.java | 47 ++++ .../policy/api/main/PolicyApiRuntimeException.java | 47 ++++ .../api/main/parameters/ApiParameterGroup.java | 94 ++++++++ .../api/main/parameters/ApiParameterHandler.java | 83 +++++++ .../api/main/parameters/RestServerParameters.java | 136 ++++++++++++ .../policy/api/main/rest/ApiRestController.java | 58 +++++ .../onap/policy/api/main/rest/ApiRestServer.java | 139 ++++++++++++ .../policy/api/main/rest/HealthCheckProvider.java | 51 +++++ .../policy/api/main/startstop/ApiActivator.java | 144 ++++++++++++ .../main/startstop/ApiCommandLineArguments.java | 246 +++++++++++++++++++++ .../org/onap/policy/api/main/startstop/Main.java | 148 +++++++++++++ main/src/main/resources/version.txt | 4 + .../policy/api/main/parameters/CommonTestData.java | 52 +++++ .../api/main/parameters/TestApiParameterGroup.java | 92 ++++++++ .../main/parameters/TestApiParameterHandler.java | 219 ++++++++++++++++++ .../policy/api/main/rest/TestApiRestServer.java | 117 ++++++++++ .../api/main/startstop/TestApiActivator.java | 55 +++++ .../onap/policy/api/main/startstop/TestMain.java | 76 +++++++ .../InvalidRestServerParameters.txt | 7 + .../resources/parameters/ApiConfigParameters.json | 9 + .../ApiConfigParameters_InvalidName.json | 9 + ...nfigParameters_InvalidRestServerParameters.json | 9 + .../test/resources/parameters/BadParameters.json | 3 + .../test/resources/parameters/EmptyParameters.json | 0 .../resources/parameters/InvalidParameters.json | 3 + .../resources/parameters/MinimumParameters.json | 9 + .../test/resources/parameters/NoParameters.json | 8 + pom.xml | 202 ++++++++++++++--- 30 files changed, 2129 insertions(+), 25 deletions(-) create mode 100644 main/pom.xml create mode 100644 main/src/main/java/org/onap/policy/api/main/PolicyApiException.java create mode 100644 main/src/main/java/org/onap/policy/api/main/PolicyApiRuntimeException.java create mode 100644 main/src/main/java/org/onap/policy/api/main/parameters/ApiParameterGroup.java create mode 100644 main/src/main/java/org/onap/policy/api/main/parameters/ApiParameterHandler.java create mode 100644 main/src/main/java/org/onap/policy/api/main/parameters/RestServerParameters.java create mode 100644 main/src/main/java/org/onap/policy/api/main/rest/ApiRestController.java create mode 100644 main/src/main/java/org/onap/policy/api/main/rest/ApiRestServer.java create mode 100644 main/src/main/java/org/onap/policy/api/main/rest/HealthCheckProvider.java create mode 100644 main/src/main/java/org/onap/policy/api/main/startstop/ApiActivator.java create mode 100644 main/src/main/java/org/onap/policy/api/main/startstop/ApiCommandLineArguments.java create mode 100644 main/src/main/java/org/onap/policy/api/main/startstop/Main.java create mode 100644 main/src/main/resources/version.txt create mode 100644 main/src/test/java/org/onap/policy/api/main/parameters/CommonTestData.java create mode 100644 main/src/test/java/org/onap/policy/api/main/parameters/TestApiParameterGroup.java create mode 100644 main/src/test/java/org/onap/policy/api/main/parameters/TestApiParameterHandler.java create mode 100644 main/src/test/java/org/onap/policy/api/main/rest/TestApiRestServer.java create mode 100644 main/src/test/java/org/onap/policy/api/main/startstop/TestApiActivator.java create mode 100644 main/src/test/java/org/onap/policy/api/main/startstop/TestMain.java create mode 100644 main/src/test/resources/expectedValidationResults/InvalidRestServerParameters.txt create mode 100644 main/src/test/resources/parameters/ApiConfigParameters.json create mode 100644 main/src/test/resources/parameters/ApiConfigParameters_InvalidName.json create mode 100644 main/src/test/resources/parameters/ApiConfigParameters_InvalidRestServerParameters.json create mode 100644 main/src/test/resources/parameters/BadParameters.json create mode 100644 main/src/test/resources/parameters/EmptyParameters.json create mode 100644 main/src/test/resources/parameters/InvalidParameters.json create mode 100644 main/src/test/resources/parameters/MinimumParameters.json create mode 100644 main/src/test/resources/parameters/NoParameters.json diff --git a/.gitignore b/.gitignore index 236c0b3b..a949ed33 100644 --- a/.gitignore +++ b/.gitignore @@ -7,3 +7,4 @@ target .metadata/ /bin/ +.idea diff --git a/main/pom.xml b/main/pom.xml new file mode 100644 index 00000000..c0a75907 --- /dev/null +++ b/main/pom.xml @@ -0,0 +1,86 @@ + + + 4.0.0 + + org.onap.policy.api + policy-api + 2.0.0-SNAPSHOT + + + main + + ${project.artifactId} + The main module of Policy Api that handles startup, lifecycle management, and parameters. + + + + org.onap.policy.common + capabilities + ${policy.common.version} + + + org.onap.policy.common + policy-endpoints + ${policy.common.version} + + + commons-cli + commons-cli + + + com.google.code.gson + gson + + + org.onap.policy.common + common-parameters + ${policy.common.version} + + + org.onap.policy.common + ONAP-Logging + ${policy.common.version} + + + + + + + + src/main/resources + true + + **/version.txt + + + + src/main/resources + false + + **/version.txt + + + + + + diff --git a/main/src/main/java/org/onap/policy/api/main/PolicyApiException.java b/main/src/main/java/org/onap/policy/api/main/PolicyApiException.java new file mode 100644 index 00000000..8dedc8ad --- /dev/null +++ b/main/src/main/java/org/onap/policy/api/main/PolicyApiException.java @@ -0,0 +1,47 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main; + +/** + * This exception will be called if an error occurs in policy api external service. + */ +public class PolicyApiException extends Exception { + private static final long serialVersionUID = -8507246953751956974L; + + /** + * Instantiates a new policy api exception with a message. + * + * @param message the message + */ + public PolicyApiException(final String message) { + super(message); + } + + /** + * Instantiates a new policy api exception with a message and a caused by exception. + * + * @param message the message + * @param exp the exception that caused this exception to be thrown + */ + public PolicyApiException(final String message, final Exception exp) { + super(message, exp); + } +} diff --git a/main/src/main/java/org/onap/policy/api/main/PolicyApiRuntimeException.java b/main/src/main/java/org/onap/policy/api/main/PolicyApiRuntimeException.java new file mode 100644 index 00000000..a9ec07db --- /dev/null +++ b/main/src/main/java/org/onap/policy/api/main/PolicyApiRuntimeException.java @@ -0,0 +1,47 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main; + +/** + * This runtime exception will be called if a runtime error occurs when using policy api. + */ +public class PolicyApiRuntimeException extends RuntimeException { + private static final long serialVersionUID = -8507246953751956974L; + + /** + * Instantiates a new policy api runtime exception with a message. + * + * @param message the message + */ + public PolicyApiRuntimeException(final String message) { + super(message); + } + + /** + * Instantiates a new policy api runtime exception with a message and a caused by exception. + * + * @param message the message + * @param exp the exception that caused this exception to be thrown + */ + public PolicyApiRuntimeException(final String message, final Exception exp) { + super(message, exp); + } +} diff --git a/main/src/main/java/org/onap/policy/api/main/parameters/ApiParameterGroup.java b/main/src/main/java/org/onap/policy/api/main/parameters/ApiParameterGroup.java new file mode 100644 index 00000000..1b149d03 --- /dev/null +++ b/main/src/main/java/org/onap/policy/api/main/parameters/ApiParameterGroup.java @@ -0,0 +1,94 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.parameters; + +import org.onap.policy.common.parameters.GroupValidationResult; +import org.onap.policy.common.parameters.ParameterGroup; +import org.onap.policy.common.parameters.ValidationStatus; +import org.onap.policy.common.utils.validation.ParameterValidationUtils; + +/** + * Class to hold all parameters needed for Api component. + * + */ +public class ApiParameterGroup implements ParameterGroup { + private String name; + private RestServerParameters restServerParameters; + + /** + * Create the api parameter group. + * + * @param name the parameter group name + */ + public ApiParameterGroup(final String name, final RestServerParameters restServerParameters) { + this.name = name; + this.restServerParameters = restServerParameters; + } + + /** + * Return the name of this parameter group instance. + * + * @return name the parameter group name + */ + @Override + public String getName() { + return name; + } + + /** + * Set the name of this parameter group instance. + * + * @param name the parameter group name + */ + @Override + public void setName(String name) { + this.name=name; + } + + /** + * Return the restServerParameters of this parameter group instance. + * + * @return the restServerParameters + */ + public RestServerParameters getRestServerParameters() { + return restServerParameters; + } + + /** + * Validate the parameter group. + * + * @return the result of the validation + */ + @Override + public GroupValidationResult validate() { + final GroupValidationResult validationResult = new GroupValidationResult(this); + if (!ParameterValidationUtils.validateStringParameter(name)) { + validationResult.setResult("name", ValidationStatus.INVALID, "must be a non-blank string"); + } + if (restServerParameters == null) { + validationResult.setResult("restServerParameters", ValidationStatus.INVALID, + "must have restServerParameters to configure api rest server"); + } else { + validationResult.setResult("restServerParameters", restServerParameters.validate()); + } + return validationResult; + } +} diff --git a/main/src/main/java/org/onap/policy/api/main/parameters/ApiParameterHandler.java b/main/src/main/java/org/onap/policy/api/main/parameters/ApiParameterHandler.java new file mode 100644 index 00000000..4cee10a1 --- /dev/null +++ b/main/src/main/java/org/onap/policy/api/main/parameters/ApiParameterHandler.java @@ -0,0 +1,83 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.parameters; + +import com.google.gson.Gson; +import com.google.gson.GsonBuilder; +import org.onap.policy.common.logging.flexlogger.FlexLogger; +import org.onap.policy.common.logging.flexlogger.Logger; +import org.onap.policy.common.parameters.GroupValidationResult; +import org.onap.policy.api.main.PolicyApiException; +import org.onap.policy.api.main.startstop.ApiCommandLineArguments; + +import java.io.FileReader; + +/** + * This class handles reading, parsing and validating of policy api parameters from JSON files. + */ +public class ApiParameterHandler { + private static final Logger LOGGER = FlexLogger.getLogger(ApiParameterHandler.class); + + /** + * Read the parameters from the parameter file. + * + * @param arguments the arguments passed to policy api + * @return the parameters read from the configuration file + * @throws PolicyApiException on parameter exceptions + */ + public ApiParameterGroup getParameters(final ApiCommandLineArguments arguments) + throws PolicyApiException { + ApiParameterGroup apiParameterGroup = null; + + // Read the parameters + try { + // Read the parameters from JSON using Gson + final Gson gson = new GsonBuilder().create(); + apiParameterGroup = gson.fromJson(new FileReader(arguments.getFullConfigurationFilePath()), + ApiParameterGroup.class); + } catch (final Exception e) { + final String errorMessage = "error reading parameters from \"" + arguments.getConfigurationFilePath() + + "\"\n" + "(" + e.getClass().getSimpleName() + "):" + e.getMessage(); + LOGGER.error(errorMessage, e); + throw new PolicyApiException(errorMessage, e); + } + + // The JSON processing returns null if there is an empty file + if (apiParameterGroup == null) { + final String errorMessage = "no parameters found in \"" + arguments.getConfigurationFilePath() + "\""; + LOGGER.error(errorMessage); + throw new PolicyApiException(errorMessage); + } + + // validate the parameters + final GroupValidationResult validationResult = apiParameterGroup.validate(); + if (!validationResult.isValid()) { + String returnMessage = + "validation error(s) on parameters from \"" + arguments.getConfigurationFilePath() + "\"\n"; + returnMessage += validationResult.getResult(); + + LOGGER.error(returnMessage); + throw new PolicyApiException(returnMessage); + } + + return apiParameterGroup; + } +} diff --git a/main/src/main/java/org/onap/policy/api/main/parameters/RestServerParameters.java b/main/src/main/java/org/onap/policy/api/main/parameters/RestServerParameters.java new file mode 100644 index 00000000..33ecff37 --- /dev/null +++ b/main/src/main/java/org/onap/policy/api/main/parameters/RestServerParameters.java @@ -0,0 +1,136 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.parameters; + +import org.onap.policy.common.parameters.GroupValidationResult; +import org.onap.policy.common.parameters.ParameterGroup; +import org.onap.policy.common.parameters.ValidationStatus; +import org.onap.policy.common.utils.validation.ParameterValidationUtils; + +/** + * Class to hold all parameters needed for api rest server. + * + */ +public class RestServerParameters implements ParameterGroup { + private String name; + private String host; + private int port; + private String userName; + private String password; + + /** + * Constructor for instantiating RestServerParameters. + * + * @param host the host name + * @param port the port + * @param userName the user name + * @param password the password + */ + public RestServerParameters(final String host, final int port, final String userName, final String password) { + super(); + this.host = host; + this.port = port; + this.userName = userName; + this.password = password; + } + + /** + * Return the name of this RestServerParameters instance. + * + * @return name the name of this RestServerParameters + */ + @Override + public String getName() { + return name; + } + + /** + * Return the host of this RestServerParameters instance. + * + * @return the host + */ + public String getHost() { + return host; + } + + /** + * Return the port of this RestServerParameters instance. + * + * @return the port + */ + public int getPort() { + return port; + } + + /** + * Return the user name of this RestServerParameters instance. + * + * @return the userName + */ + public String getUserName() { + return userName; + } + + /** + * Return the password of this RestServerParameters instance. + * + * @return the password + */ + public String getPassword() { + return password; + } + + /** + * Set the name of this RestServerParameters instance. + * + * @param name the name to set + */ + public void setName(final String name) { + this.name = name; + } + + /** + * Validate the rest server parameters. + * + * @return the result of the validation + */ + @Override + public GroupValidationResult validate() { + final GroupValidationResult validationResult = new GroupValidationResult(this); + if (!ParameterValidationUtils.validateStringParameter(host)) { + validationResult.setResult("host", ValidationStatus.INVALID, + "must be a non-blank string containing hostname/ipaddress of the api rest server"); + } + if (!ParameterValidationUtils.validateStringParameter(userName)) { + validationResult.setResult("userName", ValidationStatus.INVALID, + "must be a non-blank string containing userName for api rest server credentials"); + } + if (!ParameterValidationUtils.validateStringParameter(password)) { + validationResult.setResult("password", ValidationStatus.INVALID, + "must be a non-blank string containing password for api rest server credentials"); + } + if (!ParameterValidationUtils.validateIntParameter(port)) { + validationResult.setResult("port", ValidationStatus.INVALID, + "must be a positive integer containing port of the api rest server"); + } + return validationResult; + } +} diff --git a/main/src/main/java/org/onap/policy/api/main/rest/ApiRestController.java b/main/src/main/java/org/onap/policy/api/main/rest/ApiRestController.java new file mode 100644 index 00000000..1dd01a32 --- /dev/null +++ b/main/src/main/java/org/onap/policy/api/main/rest/ApiRestController.java @@ -0,0 +1,58 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.rest; + +import io.swagger.annotations.Api; +import io.swagger.annotations.ApiOperation; +import io.swagger.annotations.Info; +import io.swagger.annotations.SwaggerDefinition; +import io.swagger.annotations.Tag; +import org.onap.policy.common.endpoints.report.HealthCheckReport; + +import javax.ws.rs.GET; +import javax.ws.rs.Path; +import javax.ws.rs.Produces; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; + +/** + * Class to provide api REST services. + * + */ +@Path("/") +@Api +@Produces(MediaType.APPLICATION_JSON) +@SwaggerDefinition( + info = @Info(description = "Policy Api Service", version = "v1.0", title = "Policy Api"), + consumes = { MediaType.APPLICATION_JSON }, produces = { MediaType.APPLICATION_JSON }, + schemes = { SwaggerDefinition.Scheme.HTTP }, + tags = { @Tag(name = "policy-api", description = "Policy Api Service Operations") }) +public class ApiRestController { + + @GET + @Path("healthcheck") + @Produces(MediaType.APPLICATION_JSON) + @ApiOperation(value = "Perform a system healthcheck", + notes = "Provides healthy status of the Policy Api component", response = HealthCheckReport.class) + public Response healthcheck() { + return Response.status(Response.Status.OK).entity(new HealthCheckProvider().performHealthCheck()).build(); + } +} diff --git a/main/src/main/java/org/onap/policy/api/main/rest/ApiRestServer.java b/main/src/main/java/org/onap/policy/api/main/rest/ApiRestServer.java new file mode 100644 index 00000000..1050dbf6 --- /dev/null +++ b/main/src/main/java/org/onap/policy/api/main/rest/ApiRestServer.java @@ -0,0 +1,139 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.rest; + +import org.onap.policy.common.capabilities.Startable; +import org.onap.policy.common.endpoints.http.server.HttpServletServer; +import org.onap.policy.common.logging.flexlogger.FlexLogger; +import org.onap.policy.common.logging.flexlogger.Logger; +import org.onap.policy.api.main.parameters.RestServerParameters; + +import java.util.ArrayList; +import java.util.List; +import java.util.Properties; + +/** + * Class to manage life cycle of api rest server. + * + */ +public class ApiRestServer implements Startable { + + private static final String SEPARATOR = "."; + private static final String HTTP_SERVER_SERVICES = "http.server.services"; + private static final Logger LOGGER = FlexLogger.getLogger(ApiRestServer.class); + + private List servers = new ArrayList<>(); + + private RestServerParameters restServerParameters; + + /** + * Constructor for instantiating ApiRestServer. + * + * @param restServerParameters the rest server parameters + */ + public ApiRestServer(final RestServerParameters restServerParameters) { + this.restServerParameters = restServerParameters; + } + + /** + * {@inheritDoc} + */ + @Override + public boolean start() { + try { + servers = HttpServletServer.factory.build(getServerProperties()); + for (final HttpServletServer server : servers) { + server.start(); + } + } catch (final Exception exp) { + LOGGER.error("Failed to start api http server", exp); + return false; + } + return true; + } + + /** + * Creates the server properties object using restServerParameters. + * + * @return the properties object + */ + private Properties getServerProperties() { + final Properties props = new Properties(); + props.setProperty(HTTP_SERVER_SERVICES, restServerParameters.getName()); + props.setProperty(HTTP_SERVER_SERVICES + SEPARATOR + restServerParameters.getName() + ".host", + restServerParameters.getHost()); + props.setProperty(HTTP_SERVER_SERVICES + SEPARATOR + restServerParameters.getName() + ".port", + Integer.toString(restServerParameters.getPort())); + props.setProperty(HTTP_SERVER_SERVICES + SEPARATOR + restServerParameters.getName() + ".restClasses", + ApiRestController.class.getCanonicalName()); + props.setProperty(HTTP_SERVER_SERVICES + SEPARATOR + restServerParameters.getName() + ".managed", "false"); + props.setProperty(HTTP_SERVER_SERVICES + SEPARATOR + restServerParameters.getName() + ".swagger", "true"); + props.setProperty(HTTP_SERVER_SERVICES + SEPARATOR + restServerParameters.getName() + ".userName", + restServerParameters.getUserName()); + props.setProperty(HTTP_SERVER_SERVICES + SEPARATOR + restServerParameters.getName() + ".password", + restServerParameters.getPassword()); + return props; + } + + /** + * {@inheritDoc} + */ + @Override + public boolean stop() { + for (final HttpServletServer server : servers) { + try { + server.stop(); + } catch (final Exception exp) { + LOGGER.error("Failed to stop api http server", exp); + } + } + return true; + } + + /** + * {@inheritDoc} + */ + @Override + public void shutdown() { + stop(); + } + + /** + * {@inheritDoc} + */ + @Override + public boolean isAlive() { + return !servers.isEmpty(); + } + + /** + * {@inheritDoc} + */ + @Override + public String toString() { + final StringBuilder builder = new StringBuilder(); + builder.append("ApiRestServer [servers="); + builder.append(servers); + builder.append("]"); + return builder.toString(); + } + +} diff --git a/main/src/main/java/org/onap/policy/api/main/rest/HealthCheckProvider.java b/main/src/main/java/org/onap/policy/api/main/rest/HealthCheckProvider.java new file mode 100644 index 00000000..33eda9dc --- /dev/null +++ b/main/src/main/java/org/onap/policy/api/main/rest/HealthCheckProvider.java @@ -0,0 +1,51 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.rest; + +import org.onap.policy.common.endpoints.report.HealthCheckReport; +import org.onap.policy.api.main.startstop.ApiActivator; + +/** + * Class to fetch health check of api service. + * + */ +public class HealthCheckProvider { + + private static final String NOT_ALIVE = "not alive"; + private static final String ALIVE = "alive"; + private static final String URL = "self"; + private static final String NAME = "Policy API"; + + /** + * Performs the health check of api service. + * + * @return Report containing health check status + */ + public HealthCheckReport performHealthCheck() { + final HealthCheckReport report = new HealthCheckReport(); + report.setName(NAME); + report.setUrl(URL); + report.setHealthy(ApiActivator.isAlive()); + report.setCode(ApiActivator.isAlive() ? 200 : 500); + report.setMessage(ApiActivator.isAlive() ? ALIVE : NOT_ALIVE); + return report; + } +} diff --git a/main/src/main/java/org/onap/policy/api/main/startstop/ApiActivator.java b/main/src/main/java/org/onap/policy/api/main/startstop/ApiActivator.java new file mode 100644 index 00000000..2173ef3a --- /dev/null +++ b/main/src/main/java/org/onap/policy/api/main/startstop/ApiActivator.java @@ -0,0 +1,144 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.startstop; + +import org.onap.policy.api.main.rest.ApiRestServer; +import org.onap.policy.common.logging.flexlogger.FlexLogger; +import org.onap.policy.common.logging.flexlogger.Logger; +import org.onap.policy.common.parameters.ParameterService; +import org.onap.policy.api.main.PolicyApiException; +import org.onap.policy.api.main.parameters.ApiParameterGroup; + +/** + * This class wraps a distributor so that it can be activated as a complete service together with all its api + * and forwarding handlers. + */ +public class ApiActivator { + // The logger for this class + private static final Logger LOGGER = FlexLogger.getLogger(ApiActivator.class); + + // The parameters of this policy api activator + private final ApiParameterGroup apiParameterGroup; + + private static boolean alive = false; + + private ApiRestServer restServer; + + /** + * Instantiate the activator for policy api as a complete service. + * + * @param apiParameterGroup the parameters for the api service + */ + public ApiActivator(final ApiParameterGroup apiParameterGroup) { + this.apiParameterGroup = apiParameterGroup; + } + + /** + * Initialize api as a complete service. + * + * @throws PolicyApiException on errors in initializing the service + */ + @SuppressWarnings("unchecked") + public void initialize() throws PolicyApiException { + LOGGER.debug("Policy api starting as a service . . ."); + startApiRestServer(); + registerToParameterService(apiParameterGroup); + ApiActivator.setAlive(true); + LOGGER.debug("Policy api started as a service"); + } + + /** + * Starts the api rest server using configuration parameters. + * + * @throws PolicyApiException if server start fails + */ + private void startApiRestServer() throws PolicyApiException { + apiParameterGroup.getRestServerParameters().setName(apiParameterGroup.getName()); + restServer = new ApiRestServer(apiParameterGroup.getRestServerParameters()); + if (!restServer.start()) { + throw new PolicyApiException( + "Failed to start api rest server. Check log for more details..."); + } + } + + /** + * Terminate policy api. + * + * @throws PolicyApiException on termination errors + */ + public void terminate() throws PolicyApiException { + try { + deregisterToParameterService(apiParameterGroup); + ApiActivator.setAlive(false); + + // Stop the api rest server + restServer.stop(); + } catch (final Exception exp) { + LOGGER.error("Policy api service termination failed", exp); + throw new PolicyApiException(exp.getMessage(), exp); + } + } + + /** + * Get the parameters used by the activator. + * + * @return the parameters of the activator + */ + public ApiParameterGroup getParameterGroup() { + return apiParameterGroup; + } + + /** + * Method to register the parameters to Common Parameter Service. + * + * @param apiParameterGroup the api parameter group + */ + public void registerToParameterService(final ApiParameterGroup apiParameterGroup) { + ParameterService.register(apiParameterGroup); + } + + /** + * Method to deregister the parameters from Common Parameter Service. + * + * @param apiParameterGroup the api parameter group + */ + public void deregisterToParameterService(final ApiParameterGroup apiParameterGroup) { + ParameterService.deregister(apiParameterGroup.getName()); + } + + /** + * Returns the alive status of api service. + * + * @return the alive + */ + public static boolean isAlive() { + return alive; + } + + /** + * Change the alive status of api service. + * + * @param status the status + */ + public static void setAlive(final boolean status) { + alive = status; + } +} diff --git a/main/src/main/java/org/onap/policy/api/main/startstop/ApiCommandLineArguments.java b/main/src/main/java/org/onap/policy/api/main/startstop/ApiCommandLineArguments.java new file mode 100644 index 00000000..4306ef30 --- /dev/null +++ b/main/src/main/java/org/onap/policy/api/main/startstop/ApiCommandLineArguments.java @@ -0,0 +1,246 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.startstop; + +import org.apache.commons.cli.CommandLine; +import org.apache.commons.cli.DefaultParser; +import org.apache.commons.cli.HelpFormatter; +import org.apache.commons.cli.Option; +import org.apache.commons.cli.Options; +import org.apache.commons.cli.ParseException; +import org.onap.policy.common.utils.resources.ResourceUtils; +import org.onap.policy.api.main.PolicyApiException; +import org.onap.policy.api.main.PolicyApiRuntimeException; + +import java.io.File; +import java.io.PrintWriter; +import java.io.StringWriter; +import java.net.URL; +import java.util.Arrays; + +/** + * This class reads and handles command line parameters for the policy api main program. + */ +public class ApiCommandLineArguments { + private static final String FILE_MESSAGE_PREAMBLE = " file \""; + private static final int HELP_LINE_LENGTH = 120; + + // Apache Commons CLI options + private final Options options; + + // The command line options + private String configurationFilePath = null; + + /** + * Construct the options for the CLI editor. + */ + public ApiCommandLineArguments() { + //@formatter:off + options = new Options(); + options.addOption(Option.builder("h") + .longOpt("help") + .desc("outputs the usage of this command") + .required(false) + .type(Boolean.class) + .build()); + options.addOption(Option.builder("v") + .longOpt("version") + .desc("outputs the version of policy api") + .required(false) + .type(Boolean.class) + .build()); + options.addOption(Option.builder("c") + .longOpt("config-file") + .desc("the full path to the configuration file to use, " + + "the configuration file must be a Json file containing the policy api parameters") + .hasArg() + .argName("CONFIG_FILE") + .required(false) + .type(String.class) + .build()); + //@formatter:on + } + + /** + * Construct the options for the CLI editor and parse in the given arguments. + * + * @param args The command line arguments + */ + public ApiCommandLineArguments(final String[] args) { + // Set up the options with the default constructor + this(); + + // Parse the arguments + try { + parse(args); + } catch (final PolicyApiException e) { + throw new PolicyApiRuntimeException("parse error on policy api parameters", e); + } + } + + /** + * Parse the command line options. + * + * @param args The command line arguments + * @return a string with a message for help and version, or null if there is no message + * @throws PolicyApiException on command argument errors + */ + public String parse(final String[] args) throws PolicyApiException { + // Clear all our arguments + setConfigurationFilePath(null); + + CommandLine commandLine = null; + try { + commandLine = new DefaultParser().parse(options, args); + } catch (final ParseException e) { + throw new PolicyApiException("invalid command line arguments specified : " + e.getMessage()); + } + + // Arguments left over after Commons CLI does its stuff + final String[] remainingArgs = commandLine.getArgs(); + + if (remainingArgs.length > 0 && commandLine.hasOption('c') || remainingArgs.length > 0) { + throw new PolicyApiException( + "too many command line arguments specified : " + Arrays.toString(args)); + } + + if (remainingArgs.length == 1) { + configurationFilePath = remainingArgs[0]; + } + + if (commandLine.hasOption('h')) { + return help(Main.class.getCanonicalName()); + } + + if (commandLine.hasOption('v')) { + return version(); + } + + if (commandLine.hasOption('c')) { + setConfigurationFilePath(commandLine.getOptionValue('c')); + } + + return null; + } + + /** + * Validate the command line options. + * + * @throws PolicyApiException on command argument validation errors + */ + public void validate() throws PolicyApiException { + validateReadableFile("policy api configuration", configurationFilePath); + } + + /** + * Print version information for policy api. + * + * @return the version string + */ + public String version() { + return ResourceUtils.getResourceAsString("version.txt"); + } + + /** + * Print help information for policy api. + * + * @param mainClassName the main class name + * @return the help string + */ + public String help(final String mainClassName) { + final HelpFormatter helpFormatter = new HelpFormatter(); + final StringWriter stringWriter = new StringWriter(); + final PrintWriter printWriter = new PrintWriter(stringWriter); + + helpFormatter.printHelp(printWriter, HELP_LINE_LENGTH, mainClassName + " [options...]", "options", options, 0, + 0, ""); + + return stringWriter.toString(); + } + + /** + * Gets the configuration file path. + * + * @return the configuration file path + */ + public String getConfigurationFilePath() { + return configurationFilePath; + } + + /** + * Gets the full expanded configuration file path. + * + * @return the configuration file path + */ + public String getFullConfigurationFilePath() { + return ResourceUtils.getFilePath4Resource(getConfigurationFilePath()); + } + + /** + * Sets the configuration file path. + * + * @param configurationFilePath the configuration file path + */ + public void setConfigurationFilePath(final String configurationFilePath) { + this.configurationFilePath = configurationFilePath; + + } + + /** + * Check set configuration file path. + * + * @return true, if check set configuration file path + */ + public boolean checkSetConfigurationFilePath() { + return configurationFilePath != null && configurationFilePath.length() > 0; + } + + /** + * Validate readable file. + * + * @param fileTag the file tag + * @param fileName the file name + * @throws PolicyApiException on the file name passed as a parameter + */ + private void validateReadableFile(final String fileTag, final String fileName) throws PolicyApiException { + if (fileName == null || fileName.length() == 0) { + throw new PolicyApiException(fileTag + " file was not specified as an argument"); + } + + // The file name refers to a resource on the local file system + final URL fileUrl = ResourceUtils.getUrl4Resource(fileName); + if (fileUrl == null) { + throw new PolicyApiException(fileTag + FILE_MESSAGE_PREAMBLE + fileName + "\" does not exist"); + } + + final File theFile = new File(fileUrl.getPath()); + if (!theFile.exists()) { + throw new PolicyApiException(fileTag + FILE_MESSAGE_PREAMBLE + fileName + "\" does not exist"); + } + if (!theFile.isFile()) { + throw new PolicyApiException( + fileTag + FILE_MESSAGE_PREAMBLE + fileName + "\" is not a normal file"); + } + if (!theFile.canRead()) { + throw new PolicyApiException(fileTag + FILE_MESSAGE_PREAMBLE + fileName + "\" is ureadable"); + } + } +} diff --git a/main/src/main/java/org/onap/policy/api/main/startstop/Main.java b/main/src/main/java/org/onap/policy/api/main/startstop/Main.java new file mode 100644 index 00000000..a533bed5 --- /dev/null +++ b/main/src/main/java/org/onap/policy/api/main/startstop/Main.java @@ -0,0 +1,148 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.startstop; + +import org.onap.policy.api.main.PolicyApiException; +import org.onap.policy.common.logging.flexlogger.FlexLogger; +import org.onap.policy.common.logging.flexlogger.Logger; +import org.onap.policy.api.main.parameters.ApiParameterGroup; +import org.onap.policy.api.main.parameters.ApiParameterHandler; + +import java.util.Arrays; + +/** + * This class initiates ONAP Policy Framework policy api. + * + */ +public class Main { + private static final Logger LOGGER = FlexLogger.getLogger(Main.class); + + // The policy api Activator that activates the policy api service + private ApiActivator activator; + + // The parameters read in from JSON + private ApiParameterGroup parameterGroup; + + /** + * Instantiates the policy api service. + * + * @param args the command line arguments + */ + public Main(final String[] args) { + final String argumentString = Arrays.toString(args); + LOGGER.info("Starting policy api service with arguments - " + argumentString); + + // Check the arguments + final ApiCommandLineArguments arguments = new ApiCommandLineArguments(); + try { + // The arguments return a string if there is a message to print and we should exit + final String argumentMessage = arguments.parse(args); + if (argumentMessage != null) { + LOGGER.info(argumentMessage); + return; + } + + // Validate that the arguments are sane + arguments.validate(); + } catch (final PolicyApiException e) { + LOGGER.error("start of policy api service failed", e); + return; + } + + // Read the parameters + try { + parameterGroup = new ApiParameterHandler().getParameters(arguments); + } catch (final Exception e) { + LOGGER.error("start of policy api service failed", e); + return; + } + + // Now, create the activator for the policy api service + activator = new ApiActivator(parameterGroup); + + // Start the activator + try { + activator.initialize(); + } catch (final PolicyApiException e) { + LOGGER.error("start of policy api service failed, used parameters are " + Arrays.toString(args), + e); + return; + } + + // Add a shutdown hook to shut everything down in an orderly manner + Runtime.getRuntime().addShutdownHook(new PolicyApiShutdownHookClass()); + LOGGER.info("Started policy api service"); + } + + /** + * Get the parameters specified in JSON. + * + * @return the parameters + */ + public ApiParameterGroup getParameters() { + return parameterGroup; + } + + /** + * Shut down Execution. + * + * @throws PolicyApiException on shutdown errors + */ + public void shutdown() throws PolicyApiException { + // clear the parameterGroup variable + parameterGroup = null; + + // clear the api activator + if (activator != null) { + activator.terminate(); + } + } + + /** + * The Class PolicyApiShutdownHookClass terminates the policy api service when its run method is + * called. + */ + private class PolicyApiShutdownHookClass extends Thread { + /* + * (non-Javadoc) + * + * @see java.lang.Runnable#run() + */ + @Override + public void run() { + try { + // Shutdown the policy api service and wait for everything to stop + activator.terminate(); + } catch (final PolicyApiException e) { + LOGGER.warn("error occured during shut down of the policy api service", e); + } + } + } + + /** + * The main method. + * + * @param args the arguments + */ + public static void main(final String[] args) { + new Main(args); + } +} diff --git a/main/src/main/resources/version.txt b/main/src/main/resources/version.txt new file mode 100644 index 00000000..ad413fcd --- /dev/null +++ b/main/src/main/resources/version.txt @@ -0,0 +1,4 @@ +ONAP Policy Framework Api Service +Version: ${project.version} +Built (UTC): ${maven.build.timestamp} +ONAP https://wiki.onap.org \ No newline at end of file diff --git a/main/src/test/java/org/onap/policy/api/main/parameters/CommonTestData.java b/main/src/test/java/org/onap/policy/api/main/parameters/CommonTestData.java new file mode 100644 index 00000000..f86c8570 --- /dev/null +++ b/main/src/test/java/org/onap/policy/api/main/parameters/CommonTestData.java @@ -0,0 +1,52 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.parameters; + +/** + * Class to hold/create all parameters for test cases. + * + */ +public class CommonTestData { + + private static final String REST_SERVER_PASSWORD = "zb!XztG34"; + private static final String REST_SERVER_USER = "healthcheck"; + private static final int REST_SERVER_PORT = 6969; + private static final String REST_SERVER_HOST = "0.0.0.0"; + public static final String API_GROUP_NAME = "ApiGroup"; + + /** + * Returns an instance of ReceptionHandlerParameters for test cases. + * + * @param isEmpty boolean value to represent that object created should be empty or not + * @return the restServerParameters object + */ + public RestServerParameters getRestServerParameters(final boolean isEmpty) { + final RestServerParameters restServerParameters; + if (!isEmpty) { + restServerParameters = new RestServerParameters(REST_SERVER_HOST, REST_SERVER_PORT, REST_SERVER_USER, + REST_SERVER_PASSWORD); + } else { + restServerParameters = new RestServerParameters(null, 0, null, null); + } + return restServerParameters; + } + +} diff --git a/main/src/test/java/org/onap/policy/api/main/parameters/TestApiParameterGroup.java b/main/src/test/java/org/onap/policy/api/main/parameters/TestApiParameterGroup.java new file mode 100644 index 00000000..6ad8c72b --- /dev/null +++ b/main/src/test/java/org/onap/policy/api/main/parameters/TestApiParameterGroup.java @@ -0,0 +1,92 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.parameters; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; + +import org.junit.Test; +import org.onap.policy.common.parameters.GroupValidationResult; + +/** + * Class to perform unit test of ApiParameterGroup. + * + */ +public class TestApiParameterGroup { + CommonTestData commonTestData = new CommonTestData(); + + @Test + public void testApiParameterGroup() { + final RestServerParameters restServerParameters = commonTestData.getRestServerParameters(false); + final ApiParameterGroup apiParameters = new ApiParameterGroup( + CommonTestData.API_GROUP_NAME, restServerParameters); + final GroupValidationResult validationResult = apiParameters.validate(); + assertTrue(validationResult.isValid()); + assertEquals(restServerParameters.getHost(), apiParameters.getRestServerParameters().getHost()); + assertEquals(restServerParameters.getPort(), apiParameters.getRestServerParameters().getPort()); + assertEquals(restServerParameters.getUserName(), + apiParameters.getRestServerParameters().getUserName()); + assertEquals(restServerParameters.getPassword(), + apiParameters.getRestServerParameters().getPassword()); + assertEquals(CommonTestData.API_GROUP_NAME, apiParameters.getName()); + } + + @Test + public void testApiParameterGroup_NullName() { + final RestServerParameters restServerParameters = commonTestData.getRestServerParameters(false); + final ApiParameterGroup apiParameters = new ApiParameterGroup(null, + restServerParameters); + final GroupValidationResult validationResult = apiParameters.validate(); + assertFalse(validationResult.isValid()); + assertEquals(null, apiParameters.getName()); + assertTrue(validationResult.getResult() + .contains("field \"name\" type \"java.lang.String\" value \"null\" INVALID, " + + "must be a non-blank string")); + } + + @Test + public void testApiParameterGroup_EmptyName() { + final RestServerParameters restServerParameters = commonTestData.getRestServerParameters(false); + + final ApiParameterGroup apiParameters = new ApiParameterGroup("", + restServerParameters); + final GroupValidationResult validationResult = apiParameters.validate(); + assertFalse(validationResult.isValid()); + assertEquals("", apiParameters.getName()); + assertTrue(validationResult.getResult().contains("field \"name\" type \"java.lang.String\" value \"\" INVALID, " + + "must be a non-blank string")); + } + + @Test + public void testApiParameterGroup_EmptyRestServerParameters() { + final RestServerParameters restServerParameters = commonTestData.getRestServerParameters(true); + + final ApiParameterGroup apiParameters = new ApiParameterGroup( + CommonTestData.API_GROUP_NAME, restServerParameters); + final GroupValidationResult validationResult = apiParameters.validate(); + assertFalse(validationResult.isValid()); + assertTrue(validationResult.getResult() + .contains("\"org.onap.policy.api.main.parameters.RestServerParameters\" INVALID, " + + "parameter group has status INVALID")); + } +} diff --git a/main/src/test/java/org/onap/policy/api/main/parameters/TestApiParameterHandler.java b/main/src/test/java/org/onap/policy/api/main/parameters/TestApiParameterHandler.java new file mode 100644 index 00000000..7a065240 --- /dev/null +++ b/main/src/test/java/org/onap/policy/api/main/parameters/TestApiParameterHandler.java @@ -0,0 +1,219 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.parameters; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Paths; + +import org.junit.Test; +import org.onap.policy.api.main.PolicyApiException; +import org.onap.policy.api.main.startstop.ApiCommandLineArguments; + +/** + * Class to perform unit test of ApiParameterHandler. + * + */ +public class TestApiParameterHandler { + @Test + public void testParameterHandlerNoParameterFile() throws PolicyApiException { + final String[] noArgumentString = + { "-c", "parameters/NoParameterFile.json" }; + + final ApiCommandLineArguments noArguments = new ApiCommandLineArguments(); + noArguments.parse(noArgumentString); + + try { + new ApiParameterHandler().getParameters(noArguments); + fail("test should throw an exception here"); + } catch (final Exception e) { + assertTrue(e.getMessage().contains("FileNotFoundException")); + } + } + + @Test + public void testParameterHandlerEmptyParameters() throws PolicyApiException { + final String[] emptyArgumentString = + { "-c", "parameters/EmptyParameters.json" }; + + final ApiCommandLineArguments emptyArguments = new ApiCommandLineArguments(); + emptyArguments.parse(emptyArgumentString); + + try { + new ApiParameterHandler().getParameters(emptyArguments); + fail("test should throw an exception here"); + } catch (final Exception e) { + assertEquals("no parameters found in \"parameters/EmptyParameters.json\"", e.getMessage()); + } + } + + @Test + public void testParameterHandlerBadParameters() throws PolicyApiException { + final String[] badArgumentString = + { "-c", "parameters/BadParameters.json" }; + + final ApiCommandLineArguments badArguments = new ApiCommandLineArguments(); + badArguments.parse(badArgumentString); + + try { + new ApiParameterHandler().getParameters(badArguments); + fail("test should throw an exception here"); + } catch (final Exception e) { + assertEquals("error reading parameters from \"parameters/BadParameters.json\"\n" + + "(JsonSyntaxException):java.lang.IllegalStateException: " + + "Expected a string but was BEGIN_ARRAY at line 2 column 15 path $.name", e.getMessage()); + } + } + + @Test + public void testParameterHandlerInvalidParameters() throws PolicyApiException { + final String[] invalidArgumentString = + { "-c", "parameters/InvalidParameters.json" }; + + final ApiCommandLineArguments invalidArguments = new ApiCommandLineArguments(); + invalidArguments.parse(invalidArgumentString); + + try { + new ApiParameterHandler().getParameters(invalidArguments); + fail("test should throw an exception here"); + } catch (final Exception e) { + assertEquals("error reading parameters from \"parameters/InvalidParameters.json\"\n" + + "(JsonSyntaxException):java.lang.IllegalStateException: " + + "Expected a string but was BEGIN_ARRAY at line 2 column 15 path $.name", e.getMessage()); + } + } + + @Test + public void testParameterHandlerNoParameters() throws PolicyApiException { + final String[] noArgumentString = + { "-c", "parameters/NoParameters.json" }; + + final ApiCommandLineArguments noArguments = new ApiCommandLineArguments(); + noArguments.parse(noArgumentString); + + try { + new ApiParameterHandler().getParameters(noArguments); + fail("test should throw an exception here"); + } catch (final Exception e) { + String expMsg = "validation error(s) on parameters from \"parameters/NoParameters.json\"\nparameter group " + + "\"null\" type \"org.onap.policy.api.main.parameters.ApiParameterGroup\" INVALID, parameter " + + "group has status INVALID\n" + + " field \"name\" type \"java.lang.String\" value \"null\" INVALID, must be a non-blank string\n"; + assertEquals(expMsg, e.getMessage()); + } + } + + @Test + public void testParameterHandlerMinumumParameters() throws PolicyApiException { + final String[] minArgumentString = + { "-c", "parameters/MinimumParameters.json" }; + + final ApiCommandLineArguments minArguments = new ApiCommandLineArguments(); + minArguments.parse(minArgumentString); + + final ApiParameterGroup parGroup = new ApiParameterHandler().getParameters(minArguments); + assertEquals(CommonTestData.API_GROUP_NAME, parGroup.getName()); + } + + @Test + public void testApiParameterGroup() throws PolicyApiException { + final String[] apiConfigParameters = + { "-c", "parameters/ApiConfigParameters.json" }; + + final ApiCommandLineArguments arguments = new ApiCommandLineArguments(); + arguments.parse(apiConfigParameters); + + final ApiParameterGroup parGroup = new ApiParameterHandler().getParameters(arguments); + assertTrue(arguments.checkSetConfigurationFilePath()); + assertEquals(CommonTestData.API_GROUP_NAME, parGroup.getName()); + } + + @Test + public void testApiParameterGroup_InvalidName() throws PolicyApiException { + final String[] apiConfigParameters = + { "-c", "parameters/ApiConfigParameters_InvalidName.json" }; + + final ApiCommandLineArguments arguments = new ApiCommandLineArguments(); + arguments.parse(apiConfigParameters); + + try { + new ApiParameterHandler().getParameters(arguments); + fail("test should throw an exception here"); + } catch (final Exception e) { + assertTrue(e.getMessage().contains( + "field \"name\" type \"java.lang.String\" value \" \" INVALID, must be a non-blank string")); + } + } + + @Test + public void testApiParameterGroup_InvalidRestServerParameters() + throws PolicyApiException, IOException { + final String[] apiConfigParameters = + { "-c", "parameters/ApiConfigParameters_InvalidRestServerParameters.json" }; + + final ApiCommandLineArguments arguments = new ApiCommandLineArguments(); + arguments.parse(apiConfigParameters); + + try { + new ApiParameterHandler().getParameters(arguments); + fail("test should throw an exception here"); + } catch (final Exception e) { + final String expectedResult = new String(Files.readAllBytes( + Paths.get("src/test/resources/expectedValidationResults/InvalidRestServerParameters.txt"))) + .replaceAll("\\s+", ""); + assertEquals(expectedResult, e.getMessage().replaceAll("\\s+", "")); + } + } + + @Test + public void testApiVersion() throws PolicyApiException { + final String[] apiConfigParameters = + { "-v" }; + final ApiCommandLineArguments arguments = new ApiCommandLineArguments(); + final String version = arguments.parse(apiConfigParameters); + assertTrue(version.startsWith("ONAP Policy Framework Api Service")); + } + + @Test + public void testApiHelp() throws PolicyApiException { + final String[] apiConfigParameters = + { "-h" }; + final ApiCommandLineArguments arguments = new ApiCommandLineArguments(); + final String help = arguments.parse(apiConfigParameters); + assertTrue(help.startsWith("usage:")); + } + + @Test + public void testApiInvalidOption() throws PolicyApiException { + final String[] apiConfigParameters = + { "-d" }; + final ApiCommandLineArguments arguments = new ApiCommandLineArguments(); + try { + arguments.parse(apiConfigParameters); + } catch (final Exception exp) { + assertTrue(exp.getMessage().startsWith("invalid command line arguments specified")); + } + } +} diff --git a/main/src/test/java/org/onap/policy/api/main/rest/TestApiRestServer.java b/main/src/test/java/org/onap/policy/api/main/rest/TestApiRestServer.java new file mode 100644 index 00000000..ad63d0f1 --- /dev/null +++ b/main/src/test/java/org/onap/policy/api/main/rest/TestApiRestServer.java @@ -0,0 +1,117 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.rest; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; + +import javax.ws.rs.client.Client; +import javax.ws.rs.client.ClientBuilder; +import javax.ws.rs.client.Invocation; +import javax.ws.rs.client.WebTarget; +import javax.ws.rs.core.MediaType; + +import org.glassfish.jersey.client.ClientConfig; +import org.glassfish.jersey.client.authentication.HttpAuthenticationFeature; +import org.junit.Test; +import org.onap.policy.api.main.PolicyApiException; +import org.onap.policy.api.main.parameters.CommonTestData; +import org.onap.policy.api.main.parameters.RestServerParameters; +import org.onap.policy.api.main.startstop.Main; +import org.onap.policy.common.endpoints.report.HealthCheckReport; +import org.onap.policy.common.logging.flexlogger.FlexLogger; +import org.onap.policy.common.logging.flexlogger.Logger; + +/** + * Class to perform unit test of HealthCheckMonitor. + * + */ +public class TestApiRestServer { + + private static final Logger LOGGER = FlexLogger.getLogger(TestApiRestServer.class); + private static final String NOT_ALIVE = "not alive"; + private static final String ALIVE = "alive"; + private static final String SELF = "self"; + private static final String NAME = "Policy API"; + + @Test + public void testHealthCheckSuccess() throws PolicyApiException, InterruptedException { + final String reportString = "Report [name=Policy API, url=self, healthy=true, code=200, message=alive]"; + final Main main = startApiService(); + final HealthCheckReport report = performHealthCheck(); + validateReport(NAME, SELF, true, 200, ALIVE, reportString, report); + stopApiService(main); + } + + @Test + public void testHealthCheckFailure() throws InterruptedException { + final String reportString = "Report [name=Policy API, url=self, healthy=false, code=500, message=not alive]"; + final RestServerParameters restServerParams = new CommonTestData().getRestServerParameters(false); + restServerParams.setName(CommonTestData.API_GROUP_NAME); + final ApiRestServer restServer = new ApiRestServer(restServerParams); + restServer.start(); + final HealthCheckReport report = performHealthCheck(); + validateReport(NAME, SELF, false, 500, NOT_ALIVE, reportString, report); + assertTrue(restServer.isAlive()); + assertTrue(restServer.toString().startsWith("ApiRestServer [servers=")); + restServer.shutdown(); + } + + private Main startApiService() { + final String[] apiConfigParameters = { "-c", "parameters/ApiConfigParameters.json" }; + return new Main(apiConfigParameters); + } + + private void stopApiService(final Main main) throws PolicyApiException { + main.shutdown(); + } + + private HealthCheckReport performHealthCheck() throws InterruptedException { + HealthCheckReport response = null; + final ClientConfig clientConfig = new ClientConfig(); + + final HttpAuthenticationFeature feature = HttpAuthenticationFeature.basic("healthcheck", "zb!XztG34"); + clientConfig.register(feature); + + final Client client = ClientBuilder.newClient(clientConfig); + final WebTarget webTarget = client.target("http://localhost:6969/healthcheck"); + + final Invocation.Builder invocationBuilder = webTarget.request(MediaType.APPLICATION_JSON); + while (response == null) { + try { + response = invocationBuilder.get(HealthCheckReport.class); + } catch (final Exception exp) { + LOGGER.info("the server is not started yet. We will retry again"); + } + } + return response; + } + + private void validateReport(final String name, final String url, final boolean healthy, final int code, + final String message, final String reportString, final HealthCheckReport report) { + assertEquals(name, report.getName()); + assertEquals(url, report.getUrl()); + assertEquals(healthy, report.isHealthy()); + assertEquals(code, report.getCode()); + assertEquals(message, report.getMessage()); + assertEquals(reportString, report.toString()); + } +} diff --git a/main/src/test/java/org/onap/policy/api/main/startstop/TestApiActivator.java b/main/src/test/java/org/onap/policy/api/main/startstop/TestApiActivator.java new file mode 100644 index 00000000..e5ab8101 --- /dev/null +++ b/main/src/test/java/org/onap/policy/api/main/startstop/TestApiActivator.java @@ -0,0 +1,55 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.startstop; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; + +import org.junit.Test; +import org.onap.policy.api.main.PolicyApiException; +import org.onap.policy.api.main.parameters.ApiParameterGroup; +import org.onap.policy.api.main.parameters.ApiParameterHandler; +import org.onap.policy.api.main.parameters.CommonTestData; + + +/** + * Class to perform unit test of ApiActivator. + * + */ +public class TestApiActivator { + + @Test + public void testApiActivator() throws PolicyApiException { + final String[] apiConfigParameters = + { "-c", "parameters/ApiConfigParameters.json" }; + + final ApiCommandLineArguments arguments = + new ApiCommandLineArguments(apiConfigParameters); + + final ApiParameterGroup parGroup = new ApiParameterHandler().getParameters(arguments); + + final ApiActivator activator = new ApiActivator(parGroup); + activator.initialize(); + assertTrue(activator.getParameterGroup().isValid()); + assertEquals(CommonTestData.API_GROUP_NAME, activator.getParameterGroup().getName()); + activator.terminate(); + } +} diff --git a/main/src/test/java/org/onap/policy/api/main/startstop/TestMain.java b/main/src/test/java/org/onap/policy/api/main/startstop/TestMain.java new file mode 100644 index 00000000..47725349 --- /dev/null +++ b/main/src/test/java/org/onap/policy/api/main/startstop/TestMain.java @@ -0,0 +1,76 @@ +/*- + * ============LICENSE_START======================================================= + * Copyright (C) 2018 Samsung Electronics Co., Ltd. All rights reserved. + * ================================================================================ + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + * SPDX-License-Identifier: Apache-2.0 + * ============LICENSE_END========================================================= + */ + +package org.onap.policy.api.main.startstop; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; + +import org.junit.Test; +import org.onap.policy.api.main.PolicyApiException; +import org.onap.policy.api.main.parameters.CommonTestData; + +/** + * Class to perform unit test of Main. + * + */ +public class TestMain { + + @Test + public void testMain() throws PolicyApiException { + final String[] apiConfigParameters = + { "-c", "parameters/ApiConfigParameters.json" }; + final Main main = new Main(apiConfigParameters); + assertTrue(main.getParameters().isValid()); + assertEquals(CommonTestData.API_GROUP_NAME, main.getParameters().getName()); + main.shutdown(); + } + + @Test + public void testMain_NoArguments() { + final String[] apiConfigParameters = + {}; + final Main main = new Main(apiConfigParameters); + assertTrue(main.getParameters() == null); + } + + @Test + public void testMain_InvalidArguments() { + final String[] apiConfigParameters = + { "parameters/ApiConfigParameters.json" }; + final Main main = new Main(apiConfigParameters); + assertTrue(main.getParameters() == null); + } + + @Test + public void testMain_Help() { + final String[] apiConfigParameters = + { "-h" }; + Main.main(apiConfigParameters); + } + + @Test + public void testMain_InvalidParameters() { + final String[] apiConfigParameters = + { "-c", "parameters/ApiConfigParameters_InvalidName.json" }; + final Main main = new Main(apiConfigParameters); + assertTrue(main.getParameters() == null); + } +} diff --git a/main/src/test/resources/expectedValidationResults/InvalidRestServerParameters.txt b/main/src/test/resources/expectedValidationResults/InvalidRestServerParameters.txt new file mode 100644 index 00000000..2ab9c1b4 --- /dev/null +++ b/main/src/test/resources/expectedValidationResults/InvalidRestServerParameters.txt @@ -0,0 +1,7 @@ +validation error(s) on parameters from "parameters/ApiConfigParameters_InvalidRestServerParameters.json" +parameter group "ApiGroup" type "org.onap.policy.api.main.parameters.ApiParameterGroup" INVALID, parameter group has status INVALID + parameter group "null" type "org.onap.policy.api.main.parameters.RestServerParameters" INVALID, parameter group has status INVALID + field "host" type "java.lang.String" value "" INVALID, must be a non-blank string containing hostname/ipaddress of the api rest server + field "port" type "int" value "-1" INVALID, must be a positive integer containing port of the api rest server + field "userName" type "java.lang.String" value "" INVALID, must be a non-blank string containing userName for api rest server credentials + field "password" type "java.lang.String" value "" INVALID, must be a non-blank string containing password for api rest server credentials diff --git a/main/src/test/resources/parameters/ApiConfigParameters.json b/main/src/test/resources/parameters/ApiConfigParameters.json new file mode 100644 index 00000000..8fae1238 --- /dev/null +++ b/main/src/test/resources/parameters/ApiConfigParameters.json @@ -0,0 +1,9 @@ +{ + "name":"ApiGroup", + "restServerParameters":{ + "host":"0.0.0.0", + "port":6969, + "userName":"healthcheck", + "password":"zb!XztG34" + } +} diff --git a/main/src/test/resources/parameters/ApiConfigParameters_InvalidName.json b/main/src/test/resources/parameters/ApiConfigParameters_InvalidName.json new file mode 100644 index 00000000..80fb8232 --- /dev/null +++ b/main/src/test/resources/parameters/ApiConfigParameters_InvalidName.json @@ -0,0 +1,9 @@ +{ + "name":" ", + "restServerParameters":{ + "host":"0.0.0.0", + "port":6969, + "userName":"healthcheck", + "password":"zb!XztG34" + } +} diff --git a/main/src/test/resources/parameters/ApiConfigParameters_InvalidRestServerParameters.json b/main/src/test/resources/parameters/ApiConfigParameters_InvalidRestServerParameters.json new file mode 100644 index 00000000..2d394fbc --- /dev/null +++ b/main/src/test/resources/parameters/ApiConfigParameters_InvalidRestServerParameters.json @@ -0,0 +1,9 @@ +{ + "name":"ApiGroup", + "restServerParameters":{ + "host":"", + "port":-1, + "userName":"", + "password":"" + } +} diff --git a/main/src/test/resources/parameters/BadParameters.json b/main/src/test/resources/parameters/BadParameters.json new file mode 100644 index 00000000..de2040cc --- /dev/null +++ b/main/src/test/resources/parameters/BadParameters.json @@ -0,0 +1,3 @@ +{ + "name" : [] +} \ No newline at end of file diff --git a/main/src/test/resources/parameters/EmptyParameters.json b/main/src/test/resources/parameters/EmptyParameters.json new file mode 100644 index 00000000..e69de29b diff --git a/main/src/test/resources/parameters/InvalidParameters.json b/main/src/test/resources/parameters/InvalidParameters.json new file mode 100644 index 00000000..de2040cc --- /dev/null +++ b/main/src/test/resources/parameters/InvalidParameters.json @@ -0,0 +1,3 @@ +{ + "name" : [] +} \ No newline at end of file diff --git a/main/src/test/resources/parameters/MinimumParameters.json b/main/src/test/resources/parameters/MinimumParameters.json new file mode 100644 index 00000000..61c6c869 --- /dev/null +++ b/main/src/test/resources/parameters/MinimumParameters.json @@ -0,0 +1,9 @@ +{ + "name":"ApiGroup", + "restServerParameters":{ + "host":"0.0.0.0", + "port":6969, + "userName":"healthcheck", + "password":"zb!XztG34" + } +} diff --git a/main/src/test/resources/parameters/NoParameters.json b/main/src/test/resources/parameters/NoParameters.json new file mode 100644 index 00000000..6b0805d3 --- /dev/null +++ b/main/src/test/resources/parameters/NoParameters.json @@ -0,0 +1,8 @@ +{ + "restServerParameters":{ + "host":"0.0.0.0", + "port":6969, + "userName":"healthcheck", + "password":"zb!XztG34" + } +} \ No newline at end of file diff --git a/pom.xml b/pom.xml index 3b7bdd1c..b2d885c7 100644 --- a/pom.xml +++ b/pom.xml @@ -3,6 +3,7 @@ ONAP Policy API ================================================================================ Copyright (C) 2017-2018 AT&T Intellectual Property. All rights reserved. + Modified Copyright (C) 2018 Samsung Electronics Co., Ltd. ================================================================================ Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. @@ -19,30 +20,181 @@ --> - 4.0.0 - - - org.onap.policy.parent - integration - 2.0.0-SNAPSHOT - - - - org.onap.policy.api - policy-api - 2.0.0-SNAPSHOT - - pom - - policy-api - Code that define our external API. - - - - ecomp-site - dav:${nexusproxy}${sitePath} - - + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> + 4.0.0 + + + org.onap.policy.parent + integration + 2.0.0-SNAPSHOT + + + + org.onap.policy.api + policy-api + 2.0.0-SNAPSHOT + + pom + + policy-api + Code that define our external API. + + + + + ${project.basedir}/../target/code-coverage/jacoco-ut.exec + ${project.basedir}/../target/code-coverage/jacoco-it.exec + reuseReports + + 1.3.0-SNAPSHOT + + + + main + + + + + junit + junit + test + + + org.slf4j + slf4j-ext + 1.8.0-beta2 + + + org.slf4j + slf4j-api + + + ch.qos.logback + logback-core + + + ch.qos.logback + logback-classic + + + + + + ecomp-site + dav:${nexusproxy}${sitePath} + + + + + + + org.jacoco + jacoco-maven-plugin + + + pre-unit-test + + prepare-agent + + + ${sonar.jacoco.reportPath} + true + + + + post-unit-test + test + + report + + + ${sonar.jacoco.reportPath} + + + + + + maven-checkstyle-plugin + + + onap-java-style + + check + + process-sources + + + onap-checkstyle/onap-java-style.xml + + ${project.build.sourceDirectory}/src/main/java + true + true + true + + + true + true + warning + + + + + + org.onap.oparent + checkstyle + 1.1.0 + compile + + + + + + + + org.jacoco + jacoco-maven-plugin + ${jacoco.version} + + + + **/gen/** + **/generated-sources/** + **/yang-gen/** + **/pax/** + + + + + + pre-unit-test + + prepare-agent + + + ${sonar.jacoco.reportPath} + + + + + post-unit-test + test + + report + + + ${sonar.jacoco.reportPath} + + + + + + + -- 2.16.6