From 402eae5ca3e064a9a3de70c2df9d85135d34ae7c Mon Sep 17 00:00:00 2001 From: Jim Hahn Date: Fri, 18 Jun 2021 14:03:38 -0400 Subject: [PATCH] Fix new checkstyle issues in xacml-pdp The new version of checkstyle identified new issues. Fixed those. Issue-ID: POLICY-3288 Change-Id: I334e9eb67c9270c4e53b2fb34e576b8bfbf8ec8b Signed-off-by: Jim Hahn --- .../application/common/std/StdCombinedPolicyResultsTranslator.java | 2 +- .../pdp/xacml/application/common/std/StdMatchableTranslator.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdCombinedPolicyResultsTranslator.java b/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdCombinedPolicyResultsTranslator.java index c22545cd..57560715 100644 --- a/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdCombinedPolicyResultsTranslator.java +++ b/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdCombinedPolicyResultsTranslator.java @@ -157,7 +157,7 @@ public class StdCombinedPolicyResultsTranslator extends StdBaseTranslator { * scanAdvice - not implemented in this class. * * @param advice Collection of advice objects - * @param DecisionResponse DecisionResponse object + * @param decisionResponse DecisionResponse object */ @Override protected void scanAdvice(Collection advice, DecisionResponse decisionResponse) { diff --git a/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdMatchableTranslator.java b/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdMatchableTranslator.java index 1d76d0e3..9d0124bb 100644 --- a/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdMatchableTranslator.java +++ b/applications/common/src/main/java/org/onap/policy/pdp/xacml/application/common/std/StdMatchableTranslator.java @@ -167,7 +167,7 @@ public class StdMatchableTranslator extends StdBaseTranslator implements Matcha * contents and their details. * * @param closestMatches Map holding the current set of highest weight policy types - * @param Obligation Obligation object + * @param obligation Obligation object */ protected void scanClosestMatchObligation( Map>>>> closestMatches, Obligation obligation) { @@ -371,8 +371,8 @@ public class StdMatchableTranslator extends StdBaseTranslator implements Matcha * For generating target type, we scan for matchable properties * and use those to build the policy. * - * @param properties Properties section of policy - * @param policyTypes Collection of policy Type to find matchable metadata + * @param policy the policy + * @param template template containing the policy * @return {@code Pair} Returns a TargetType and a Total Weight of matchables. */ protected Pair generateTargetType(ToscaPolicy policy, ToscaServiceTemplate template) { -- 2.16.6