enhanced vnf adapter errog log.

enhanced vnf adapter error log for heatEnvironment when null.
removed the junit tests because of no assertions coverage.
enhanced vnf adapter errog log.

Change-Id: I80d3070ce203c4c8339f0a0e7df6f3731d0a16c2
Issue-ID: SO-1967
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

Fix issue where request was not being updated

Fix issue where request was not being updated

Change-Id: Ib4b3809797449224ac417facfaa4bf48d91a1ecb
Issue-ID: SO-1966
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

issue encoding openstack errors

Fix setting of port to fix unit test issues
Fix formatting error on the file causing build issue
Properly revert change that was made previously
Fix issue where base java library not encoding properly

Change-Id: I2bfa46825d9a99998195dbd7bd422f88fa76ef09
Issue-ID: SO-1965
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

property to determine if delete audit is needed

update the onap delete vf module BB bpmn as well
validate formatting of audit tasks code changes
added a property to determine if delete audit is needed

Change-Id: Id29eed6295ed6623636a4812708e53c5ae440b83
Issue-ID: SO-1964
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

apih resume request handling more generic

getInstanceName throws exception if requestScope doesn't match modelType
Updated to combine separate return statements
Replaced if statements for modelType and added tests
Replace if statements for modelType in ResumeOrchestrationRequest and
added tests
Added coverage for setId in ModelType
Updated to use ModelType setters/getters
model type can now get and set generically
Added modelInfo to RequestBody for resume request
Added getModelType call and unit tests
Moved getModelType from ServiceInstances
Moved getModelType and added unit tests
Added tests for getIsBaseVfModule
Added more tests for isBaseVfModule
Began adding tests for getIsBaseVfModule
Updated currentActiveRequest creation and isBaseVfModule
Updated recipe lookup and setting of aLaCarte to be more general
Updated concurrency control to include other resources

Change-Id: I12ad011d0a021c3ee066e16b4c8a4526d040cbe3
Issue-ID: SO-1963
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

Merge "Use lowercase for table names in beans" into dublin

Merge "Fixing Null Value Exception" into dublin

Merge "bump the SO release version" into dublin

Merge "update INFO.yaml" into dublin

Merge "converted lock time from hard coded value"

Merge "Corrected enum formatting by plugin"

Merge "JUnit tests for RestfulUtil"

Merge "Remove oof_directives from user_directives BB path" into dublin

Merge "Added NPE check for audit"

Fixing Null Value Exception

Change-Id: I07553affad2297e1fa1e4e67b27bb08c51e4b8c3
Issue-ID: SO-1968
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>

Merge "apih to populate original request id"

Corrected enum formatting by plugin

enums are now single item per line

Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7
Issue-ID: SO-1970
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

converted lock time from hard coded value

update lock time property to have a default of 60000
converted lock time from hard coded to property driven

Change-Id: I4a42b85c4241c8865f8dc133be96d7bc92b8574d
Issue-ID: SO-1962
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

Handle multiple host routes correctly for networks

unit test for the method that creates subnets
Remove project name from junit test data
Handle multiple host routes correctly for networks

Change-Id: I537b9bbb68c11901c06ed2366591cedeb3b29acd
Issue-ID: SO-1961
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

apih to populate original request id

Updated schema.sql to fix failing tests
Added constants for request parameters
Added originalRequestId to be saved on resume request
Added originalRequestId to orchestrationRequests response

Change-Id: If2b86d233ee3db9bbe0e1185d92874bca2b3a07a
Issue-ID: SO-1960
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

Added NPE check for audit

Added NPE check so that flow continues when no audit results present

Change-Id: I614dbaff7eaaca86a503da2734d7c5f7a197bb1b
Issue-ID: SO-1959
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

Merge "Renamed NF fields in catalog db pojo"

Merge "Remove update of request status"

fix keypair conflict issue in openstack adapter

Fix wiremock stubs to return proper data and url
Fix copyright header issue on unit test file
Fix keypair issue, clean up unit tests and logging
Fix issues found in unit testing, update data
Fix broken Unit tests that used invalid data
Continue Refactor to support keypair failure scenario
Update logic for when to auto delete a stuck keypair

Change-Id: Ice5256cf0381a3b46d1c442907c0f321a1c0d006
Issue-ID: SO-1897
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

Remove oof_directives from user_directives BB path

Remove oof_directives from user_directives in the
BB code path (as was done for the groovy code path).

Change-Id: I018c3c85cc4a68ab128a2be869567b44fda08e48
Issue-ID: SO-1939
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>

New GroupLevel DeleteE2EServiceInstance flow

Modified the subprocess 'DoDeleteE2EServiceInstance'
to support Group level instances.

Change-Id: I8dfd154bc6eb9c9f7c7dc932bdce215a3b9fd800
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>

Merge "Improvements in AAIClientHelper"

Improvements in AAIClientHelper

Improvements in AAIClientHelper according to the Sonar analysis.
Removed unnecessary exception throwing.
Fixed imports.
Updated java docs.

Issue-ID: SO-1958
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I60835304466bb656f09ba16b487907fa529e5eab

Merge "Improvements in RequestClient"

bump the SO release version

Issue-ID: SO-1929

Change-Id: Idca0ebbe73d0b8d725840167730b354f16753ed6
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>

update INFO.yaml

Issue-ID: SO-1944

Change-Id: I221fc3cce7f72373ad35a6ce07c887e928038348
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>

Handle operation state null from VNFM

Issue-ID: SO-1956
Change-Id: I8d2efe3f9d97a38a533b33eabd0be2a42cebef66
Signed-off-by: MichaelMorris <michael.morris@est.tech>

Merge "Persist native CM workflows in CatalogDB" into dublin

Merge "update INFO.yaml" into dublin

Improvements in RequestClientFactory

Improvements in RequestClientFactory according to the Sonar analysis.
Fixed imports.
Removed unnecessary exceptions handling.
Replaced depreciated  DefaultHttpClient with a new one.

Issue-ID: SO-1947
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Id497bfb620775aac67ad4c5f6d57e0fccce4fd34

Fixing infinte loop of flow

Change-Id: I80dc144750406d5afcec9b4da717a55a3840e503
Issue-ID: SO-1946
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>

Improvements in RequestClient

Improvements in RequestClient according to the Sonar analysis.
Removed unnecessary exceptions handling.
Added junit tests.
Fixed imports.

Issue-ID: SO-1945
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Iee22e7dbeb39ca28c437f9a8a804b81945cb9bc5

update INFO.yaml

Issue-ID: SO-1944

Change-Id: I2d773bed6822eaf440a8f941870fac2fdff1800f
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>

Get operation state from VNFM failing

Issue-ID: SO-1943
Change-Id: I8d0fd3e9cd4aea26e94a18a6e610abd34f2e5fe9
Signed-off-by: MichaelMorris <michael.morris@est.tech>

Merge "Improvements in CamundaClient"

Merge "Remove oof_directives from user_directives" into dublin

Remove oof_directives from user_directives

Oof_directives - when populated with a json
string, breaks the parsing of the user_directives.
Since it is not needed in the user_directives,
remove it.

Change-Id: I0e2c3deef8266df52ac73b95209843ac31f986ef
Issue-ID: SO-1939
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>

Merge "added extra parameters" into dublin

Merge "Fix DeleteE2EServiceInstance flow"

added extra parameters

Issue-ID: SO-1933
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
Change-Id: I7fdd9ff5373e2f27d225f265ff13b4e14a8b3abc

Fixing ETSI BB execution failure

Change-Id: Icbcd43be40c7717a714bc866bf153ac3ea0e427c
Issue-ID: SO-1934
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>

Renamed accessId to remoteid

Issue-ID: SO-1933
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
Change-Id: I6b63286f10ebc129b72a36cf41f0bb85b797f9ef

Improvements in CamundaClient

Removed code duplicates.
Fixed declarations of thrown exceptions.
Fixed imports.

Issue-ID: SO-1936
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ic178341b0049307da033408719ff263a00059ba7

JUnit tests for RestfulUtil

Increased junit tests coverage according to Sonar analyses.
Added missing tests for RestfulUtil.

Issue-ID: SO-1692
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I8744960c0ad3a36ca4c36e23867168bfda5cbd1d

Merge "Fix request body for SDNC req"

Fix UriBuilder import in OofUtils

Import all changes from Casablanca
that were incorrectly removed during
merge from Casablanca back into
master.

Issue-ID: SO-1926
Change-Id: I8355e804586aa80e291f3c72a00bf69ce424316b
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>

Fix sonar issues in mso-openstack-adapters

Fix Either log or rethrow this exception
Fix Replace the type specification in this constructor call with the diamond operator ("<>")
Fix Remove this unused local variable
Fix Iterate over the "entrySet" instead of the "keySet"

Issue-ID: SO-1841
Change-Id: I5e9195d75d29a66a4a360e031ab02ab7c9872388
Signed-off-by: Parshad Patel <pars.patel@samsung.com>

Merge "Corrected instance names" into dublin

Merge "Fix retrieval of mso.config.path" into dublin

Merge "Set response code in UpdateAAIGenericVnf" into dublin

Fix request body for SDNC req

Fix request body for SDNC req.

Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Change-Id: Ia8112b81fa29f886e282445b3c0dc068d487cadd

Merge "Return empty WorkflowInputParameters" into dublin

Corrected instance names

Issue-ID: SO-1931
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
Change-Id: I4c3700cdc1cc058f3a37a77d087d38b2aadad29d

Merge "Fixed errors in  HandlePnf flow" into dublin

Merge "fixed typos and added SERVICE_INSTANCE_ID" into dublin

Set response code in UpdateAAIGenericVnf

Change-Id: I67fb789d40ea86a82379e76b94c2da1bd552cd31
Issue-ID: SO-1927
Signed-off-by: Yang Xu <yxu@futurewei.com>

Fixed errors in  HandlePnf flow

Change-Id: I1cf49f98f26e322b4785cc14f96ee63a5830117e
Issue-ID: SO-1930
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>

Fix sonar for MapEntry

MapEntry bug: make entry private and provide accessors
MapEntry codesmell: move comment 'Required by JAXB' into empty constructor
MapElements codesmell: move explanatory comment inside empty constructor
MapElements codesmell: log error stacktrace
MapAdapter codesmell: use entry set instead of key set for iteration
JAXBMarshallingTest: add test cases to cover 100% of MapElements & other cases

Change-Id: If51f1f86b5ad44b3462424e4fd73cb0eff352124
Issue-ID: SO-1811
Signed-off-by: k.kazak <k.kazak@samsung.com>

fixed typos and added SERVICE_INSTANCE_ID

Change-Id: I68174bf2e67280a4bf65d8f26b04793b76896f04
Issue-ID: SO-1913
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>

Modify scaleOut-related settings

Corrections for execution of VfModule-ScaleOut

Issue-ID: SO-1972
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Ia654a223f1e86749d34d78b5918eda38a0a630c7

Use lowercase for table names in beans

Uppercase table names cause issues on db queries

Issue-ID: SO-1969
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I468cfc6635c68771caf04a1f75d336559877d288

Handle lazy init of activitySpecs

Use Transactional setting for activitySpecs retrieval

Issue-ID: SO-1957
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Idfe57474bfdec055a12a1e8fd787d31ac9dc7507

Merge "Fix Missing Import in OofHoming.groovy" into dublin

Merge "Typo in bpmn mso-request-id variable name" into dublin

Typo in bpmn mso-request-id variable name

Change-Id: I50e7f33a3a38e77c84874d75ab33c5f9bb693f8b
Issue-ID: SO-1922
Signed-off-by: Yang Xu <yang.xu3@huawei.com>

Fix Missing Import in OofHoming.groovy

Issue-ID: SO-1926
Change-Id: Idee7eb0ab789fd8ac335b8c97b344b6e4f4b7fba
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>

Persist native CM workflows in CatalogDB

Add native CM workflows to Workflow table to make them available to VID

Issue-ID: SO-1942
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Ifbf3ed8a513f4704583df8a565dba97344702ede

Merge "Update the version to release" into dublin

Calls to/from VNFM fail

Issue-ID: SO-1909
Change-Id: I2f8a19dfd456316e5436be4e85d8a384d7d5ed6f
Signed-off-by: MichaelMorris <michael.morris@est.tech>
(cherry picked from commit a7160456335b2ce3710efd00658711d431eac0b4)

Update the version to release

Issue-ID: SO-1921

Change-Id: Ib178c25b1d8704f77efa7499d724e0dead85728a
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>

Calls to/from VNFM fail

Issue-ID: SO-1909
Change-Id: I2f8a19dfd456316e5436be4e85d8a384d7d5ed6f
Signed-off-by: MichaelMorris <michael.morris@est.tech>

Fix Build -Use latest SNAPSHOT appc client-libs

Issue-ID: SO-1921
Change-Id: Id20f8f7d77469e8123317447aa974a3e77103761
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>

Fix retrieval of mso.config.path

Fix retrieval of mso.config.path

Issue-ID: SO-1925
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I5eed704334de6335672624f9e9eca809856fb984

Remove update of request status

fix unit test now that method does not update status
Remove update of request status, should not be done

Change-Id: I17958ef76ccfa059893da0c2bcea1baa124d6922
Issue-ID: SO-1915
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

Renamed NF fields in catalog db pojo

- Renamed Nf properties to just Function, Role, Type.

Change-Id: I0cec751e783c1fb7abdcf9f9565eadf89e0ac32c
Issue-ID: SO-1914
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

Merge "exception handling" into dublin

Merge "Add SO Update the repeatable Macro - northbound_request_ref_lookup" into dublin

Merge "Send syncAck on first Activity" into dublin

exception handling

Update the appc client jar version
Throw exception for non success cds call
Fix CreateVcpeResCustServiceSimplifiedTest IT

Issue-ID: SO-1857 SO-1779
Change-Id: Ifee080600051c92fd964a92d16efb67e4ab05d5d
Signed-off-by: eeginux <henry.xie@est.tech>

Return empty WorkflowInputParameters

Return empty WorkflowInputParameters when none are available

Issue-ID: SO-1919
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I057e30bb55f6545c25060c28e1af097286f4e88b

Handle case of null requestInfo

Handle case of null requestInfo

Issue-ID: SO-1918
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Ie8a0dd9e27734d96442eceaa378e5d1e64667b06

Merge "removed unused CatalogDbUtils instantiation" into dublin

removed unused CatalogDbUtils instantiation

Issue-ID: SO-1910
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
Change-Id: I50a2c75e2ce59a4eb7b6fb60076a34cae5482344

HttpLookupUri is now serializable again

cachedValue is now transient
added custom serialization
created serialization unit test for ServiceInstancesUri

Change-Id: Idbc414a8483a4eae9c93ae8b06a1e77cbe683ca8
Issue-ID: SO-1906
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>

Add SO Update the repeatable Macro - northbound_request_ref_lookup

Added dublin - Update repeatable Macro not to lose the ability to
drive flows differently based on service type.
UPDATE northbound_request_ref_lookup SET SERVICE_TYPE = '*' WHERE SERVICE_TYPE = NULL;
Issue-ID: SO-1892
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I3fa58559fe4596b3a0e184a8391ac93fb9496a26

Fix CLOUD_TECHNOLOGY_SPECIFIC_ARTIFACT distribute

Add CLOUD_TECHNOLOGY_SPECIFIC_ARTIFACT type so
it does not cancel the distribution of services.

Change-Id: I68fe4892156312233fe677c0826e95c8aaa8da02
Issue-ID: SO-1907
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>

SDNC request body fix

Request body fix for sdnc requests.

Change-Id: Id3e454be18c62ab8c2e5ee572de55bf3ef7c18a3
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>

Fix instance resource list

Fix instance resource list if group is not list type.

Change-Id: I99d37d5407c925dbb3355de73105de755b30bc04
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>

Merge "Enhanced logic for multilevel list input"

Add WORKFLOW artifactType to SDC Config

Add WORKFLOW artifactType to SDC Config

Issue-ID: SO-1911
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I8933438ae63ca73605a05fec5467806f41fbda10

Merge "Change serviceInstance CM retrieval" into dublin

Merge "Missing modifications for DistributeTraffic actions" into dublin

Merge "Added script for adding original_request_id column"

Set Variable

Fix issue here variable is not set if SI is found.

Issue-ID: SO-1419

Change-Id: If9a75fc57e280c2aba5361096e4ebf01ab13056f
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>

Missing modifications for DistributeTraffic actions

Added input parameters for DistributeTraffic and
DistributeTrafficCheck action

Change-Id: I423979f6e8a682bff2aaff02bba4d79d2fbe22c8
Issue-ID: SO-1553
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>