Dan Timoney [Tue, 19 Sep 2017 23:58:57 +0000 (23:58 +0000)]
Merge "Implement test case for Fabric Discovery Plugin"
Dan Timoney [Tue, 19 Sep 2017 23:58:40 +0000 (23:58 +0000)]
Merge "Refinements to RestApiCall plugin"
Dan Timoney [Tue, 19 Sep 2017 23:58:10 +0000 (23:58 +0000)]
Merge "Use Junit4 instead of Junit3 in sli/common"
Dan Timoney [Tue, 19 Sep 2017 23:54:39 +0000 (23:54 +0000)]
Merge "Using specific exceptions in RestApiCallNode"
Dan Timoney [Tue, 19 Sep 2017 23:52:47 +0000 (23:52 +0000)]
Merge "Fix critical sonar issues"
Dan Timoney [Tue, 19 Sep 2017 23:48:34 +0000 (23:48 +0000)]
Merge "Fix Sonar Issue"
Dan Timoney [Tue, 19 Sep 2017 23:46:53 +0000 (23:46 +0000)]
Merge "Implement fabric discovery DG parameter validation"
Dan Timoney [Tue, 19 Sep 2017 23:06:17 +0000 (19:06 -0400)]
Remove mysql references from sli/adaptors
Remove mysql references from sli/adaptors repository.
Change-Id: I19682626fdb954ce8190d61507eabe0152a6a635
Issue-ID: CCSDK-95
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 19 Sep 2017 21:33:48 +0000 (17:33 -0400)]
Remove mysql dependencies in sli/core
Remove lingering mysql dependencies in sli/core, which prevented odlsli
container from starting up clean. Note: tested this using bareodl container
and verified that these changes install clean AFTER changing incorrect
driver property name in dblib.properties. This patch is fine, but a second
patch to ccsdk/distribution is needed to fix that property file.
Change-Id: I6a900d1c29998867bfbae29d5e113c4e392a8bb9
Issue-ID: CCSDK-95
Signed-off-by: Dan Timoney <dtimoney@att.com>
ramu.n [Tue, 19 Sep 2017 20:47:00 +0000 (02:17 +0530)]
Use Junit4 instead of Junit3 in sli/common
Modified sli/common pom.xml file to take Junit version from parent pom file
and modified one Testfile as per Junit4
Change-Id: Iee4397125d9873def60c77ba8be5d541e0df62fa
Issue-Id: CCSDK-98
Signed-off-by: Ramu N <ramu.n@huawei.com>
Dan Timoney [Tue, 19 Sep 2017 18:31:36 +0000 (18:31 +0000)]
Merge "Fix few Major sonar issues"
Dan Timoney [Tue, 19 Sep 2017 18:31:16 +0000 (18:31 +0000)]
Merge "Fix few Major sonar issues"
Rich Tabedzki [Tue, 19 Sep 2017 18:07:31 +0000 (18:07 +0000)]
Updated XSD Model and path properties
Changes made:
1. updated XSD and aai-path documents
2. Updated named-query to support V11 data types
Issue-ID: CCSDK-97
Change-Id: I02e2cd0246644ade1631db8e963a72ac3cb7cff6
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Dan Timoney [Tue, 19 Sep 2017 17:34:33 +0000 (13:34 -0400)]
Fix mariadb-connector-java references
Remove mariadb-connector-java reference in dblib features.xml
Change-Id: I29f7466a82b25e35b180eb48911dd553c86460fa
Issue-ID: CCSDK-95
Signed-off-by: Dan Timoney <dtimoney@att.com>
Brian Freeman [Tue, 19 Sep 2017 17:04:26 +0000 (17:04 +0000)]
Fix sli dependency
Issue-ID: SDNC-86
Change-Id: Ic6680636fd451942ab9f91598f1b7c63080843c1
Signed-off-by: Brian Freeman <bf1936@att.com>
Brian Freeman [Tue, 19 Sep 2017 16:53:20 +0000 (16:53 +0000)]
Fix sli dependency
Issue-ID: SDNC-86
Change-Id: I4b6a4ab0ba8532802486f18804421dc76fc4c862
Signed-off-by: Brian Freeman <bf1936@att.com>
Brian Freeman [Tue, 19 Sep 2017 16:49:28 +0000 (16:49 +0000)]
Fix sli dependency
Issue-ID: SDNC-86
Change-Id: I91280ab218e2f1f25ab381eaa9f94dce8f2abdc9
Signed-off-by: Brian Freeman <bf1936@att.com>
Gaurav Agrawal [Tue, 19 Sep 2017 13:36:33 +0000 (19:06 +0530)]
Fix critical sonar issues
Fix critical sonar issues in CCSDK SLI Northbound by either logging or
rethrowing the exception
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.northbound%3Accsdk-sli-northbound#resolved=false|severities=CRITICAL
Change-Id: I718f13b5801ea9d69b5c36f75b5387a0ae59cc6a
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Gaurav Agrawal [Tue, 19 Sep 2017 12:10:54 +0000 (17:40 +0530)]
Refinements to RestApiCall plugin
Changes includes:
1) Check for null in JsonParser.convertToProperties() which can otherwise result in null pointer exception
2) Use logger built-in string formatting rather then string concatenation
3) Use StringBuilder for multiple string concatenations
4) Making utility classes final and defines private constructor for them
5) Added testcases/testpoints
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.plugins%3Accsdk-sli-plugins#resolved=false|severities=CRITICAL
Change-Id: Ic047b6d0369827a38a98c52e8365f1fe7266840f
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Gaurav Agrawal [Tue, 19 Sep 2017 10:08:32 +0000 (15:38 +0530)]
Using specific exceptions in RestApiCallNode
Changes includes
1) Sonar critical fixes stating use of specific exceptions instead of generic one
2) Throw exception for invalid input of repeat times.
3) Added testcases
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.plugins%3Accsdk-sli-plugins#resolved=false|severities=CRITICAL
Change-Id: I2633f857e161bf7068c51ef835b7c2cd5eb5aa62
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
surya-huawei [Tue, 19 Sep 2017 10:18:21 +0000 (15:48 +0530)]
Fix Sonar Issue
One major issue in sli/plugins module
*Making anonymous inner class a lambda
for better code readabilty
Issue-Id: CCSDK-87
Change-Id: Ib650546c4c2c86411744379fe5beae828403453d
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Tue, 19 Sep 2017 10:02:16 +0000 (15:32 +0530)]
Fix Sonar Issues
few major issues in sli/northbound
*Remove unused imports
*Iterate over the "entrySet" instead of the "keySet"
*Replace the type specification with the diamond operator ("<>")
Issue-Id: CCSDK-87
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Change-Id: Ib2a6f97d3de759b937c1e2acd2e39312e88ad10b
Arun S. Yerra [Tue, 19 Sep 2017 07:38:58 +0000 (00:38 -0700)]
Implement test case for Fabric Discovery Plugin
Fabric Discovery plugin implements framework to connect to fabric
update notifications from local domain controllers. This task is to implement
unit test case for this module.
Issue-Id: CCSDK-96
Change-Id: I3387f248e693a7da6b4817bc27f87dbc86aea806
Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
surya-huawei [Tue, 19 Sep 2017 06:40:28 +0000 (12:10 +0530)]
Fix Sonar Issue
One blocker issue in sli/adapters module
*check for null dereferencing
Issue-Id: CCSDK-87
Change-Id: I6c2b308bed95069089770cbec7ef728e2a8cc030
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Arun S. Yerra [Tue, 19 Sep 2017 06:23:54 +0000 (23:23 -0700)]
Implement fabric discovery DG parameter validation
Directed Graph to establish notification stream session with local domain
controller passes the REST notification server address. It also passes a
a boolean parameter to to either start or stop the session. This change
adds logic to validate these input parameters,
Issue-Id: CCSDK-88
Change-Id: I3fa05f5badeafbaa15e5ae89a3a60b8e237f212b
Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
Dan Timoney [Mon, 18 Sep 2017 20:02:55 +0000 (20:02 +0000)]
Merge "Replace deprecated APIs with newer one"
Dan Timoney [Mon, 18 Sep 2017 19:43:56 +0000 (15:43 -0400)]
Fix mariadb-connector-java references
Correct mariadb JDBC connector artifactId should be mariadb-java-client,
not mariadb-connector-java
Change-Id: If58a33a1ef22d47e1d5c138bad164b0ad89219eb
Issue-ID: CCSDK-95
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Mon, 18 Sep 2017 19:21:48 +0000 (19:21 +0000)]
Merge "Implement framework to process REST notifications"
Dan Timoney [Mon, 18 Sep 2017 18:56:39 +0000 (14:56 -0400)]
Update sli/core to use Mariadb connectori
Update sli/core (including dblib, notably) to use mariadb-connector
for any jUnit tests. Update Import-Package in dblib provider pom.xml
to import org.mariadb.jdbc so that org.mariadb.jdbc.Driver will
be resolved
Change-Id: I39dfe2cafb955ba1bf05b0ecdb0212d766fcc96c
Issue-ID: CCSDK-95
Signed-off-by: Dan Timoney <dtimoney@att.com>
Arun S. Yerra [Tue, 12 Sep 2017 01:57:40 +0000 (18:57 -0700)]
Implement framework to process REST notifications
Global SDNC controller needs information about network Devices
(mostly PNFs) so as to instantiate/configure service. Domain Controllers
control/manage the network devices within the fabric. This task
is to implement RESTCONF notification processing framework, so that
Global SDNC controller can process notifications from Domain controllers.
Change-Id: Ia5edb5006ac3fd4ec71e55f92a05e79e40ce76d2
Issue-Id: CCSDK-88
Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
Dan Timoney [Mon, 18 Sep 2017 16:38:43 +0000 (16:38 +0000)]
Merge "Fix few Major sonar issues"
Dan Timoney [Mon, 18 Sep 2017 15:33:49 +0000 (11:33 -0400)]
Explicitly import com.mysql.jdbc package
Need to explicitly add com.mysql.jdbc to Import-Package in dblib/provider
pom.xml, so that Class.forName() can resolve com.mysql.jdbc.Driver.
Will also need to add org.mariadb.jdbc,but will do that in a separate
commit
Change-Id: I6a4be5d4e1841690919484940af75a2cb15c357b
Issue-ID: CCSDK-94
Signed-off-by: Dan Timoney <dtimoney@att.com>
ramu.n [Mon, 18 Sep 2017 14:47:36 +0000 (20:17 +0530)]
Fix few Major sonar issues
Fix few Major sonar issues in CCSDK SLI Core module
* Use logger method's built-in string formatting instead of string concatination
* code formatting
* Use Integer.toString() instead of concatenating empty string "" to a primitive
Change-Id: I5a15c9b0049b71d7b0fa06c6791abe766a035c46
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
ramu.n [Mon, 18 Sep 2017 13:37:17 +0000 (19:07 +0530)]
Fix few Major sonar issues
Fix few Major sonar issues in CCSDK SLI Core module
* Remove useless parentheses
* Remove useless assignment to local variable
* Use logger method instead of string formatting
Change-Id: Ie9958d0bc4e754c36c127d465a1953160c2c3e2b
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
Gaurav Agrawal [Mon, 18 Sep 2017 13:07:49 +0000 (18:37 +0530)]
Replace deprecated API with newer one
Replace following deprecated API
1) NotificationProviderService replaced with NotificationPublishService
2) InstanceIdentifier<T> toInstance() replace with build()
Change-Id: I50195bf123052270edf3fd9f74af00262a01e650
Issue-Id: CCSDK-93
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Gaurav Agrawal [Mon, 18 Sep 2017 09:24:37 +0000 (14:54 +0530)]
Replace deprecated APIs with newer one
Replace following deprecated API
1) NotificationProviderService replaced with NotificationPublishService
Change-Id: I3d5117e63083ce77553feb3d3f6d6265576da646
Issue-Id: CCSDK-93
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
shashikanth [Thu, 14 Sep 2017 12:22:04 +0000 (17:52 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in ccsdk/sli/adaptors module
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.adaptors%3Accsdk-sli-adaptors#resolved=false|severities=BLOCKER
Deleted redundant code.
Issue-Id: CCSDK-67
Change-Id: Iccdfc4815b7a28a6e95251c24e7196221f1b25df
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
ramu.n [Mon, 18 Sep 2017 07:12:25 +0000 (12:42 +0530)]
Fix few Major sonar issues
Fix few Major sonar issues in CCSDK SLI Core module
* Remove useless parentheses
* Either log or rethrow the exception
* Add the "@Override" annotation
* Change "try" to a try-with-resources
* Replace duplicate string literals with constants
Change-Id: If52163220d7231ae42ef42b0313d56435f6745e1
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
surya-huawei [Sun, 17 Sep 2017 17:55:14 +0000 (23:25 +0530)]
Fix Sonar Issue in sli/plugins module
One major issue
* move string literal to left side
of string comparison
Issue-Id: CCSDK-87
Change-Id: I1277c4c5515bd45ad6854c63cf6160f17b7725d0
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Sun, 17 Sep 2017 17:40:57 +0000 (23:10 +0530)]
Fix Sonar issue in sli/northbound module
One major issue
* move string literals to left side of
string comparison
Issue-Id: CCSDK-87
Change-Id: Ibd1146a8a12dccc56fb620fe5830efb545ac39a1
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Sun, 17 Sep 2017 17:23:41 +0000 (22:53 +0530)]
Fix Sonar issues in sli/core module
One major issue
* Use try with resources instead of try
Issue-Id: CCSDK-87
Change-Id: Ic30016f70ebc355f80a73c9e4632b7971d2b87be
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Sun, 17 Sep 2017 16:59:09 +0000 (22:29 +0530)]
Fix Sonar Issues in sli/adapter module
one major issue
* Use try with resources instead of try
Issue-Id: CCSDK-87
Change-Id: Iff46703282a6b9ccb3b61c29495c81a49aaed5da
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Sat, 16 Sep 2017 00:11:21 +0000 (00:11 +0000)]
Merge "Fix few Major sonar issues"
Dan Timoney [Fri, 15 Sep 2017 18:03:17 +0000 (14:03 -0400)]
Fix service tag in sli/recording blueprint
One of the service tags in sli/recording blueprint uses attribute 'class'
instead of 'interface' to advertise the service. This is preventing
SDNC container from loading sdnc-sli-recording feature.
Change-Id: I4f6863d74dd6fb8babd91fde53b9680594aa7a31
Issue-ID: SDNC-54
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Fri, 15 Sep 2017 13:52:10 +0000 (13:52 +0000)]
Merge "Log current DG & NodeId using MDC"
Dan Timoney [Fri, 15 Sep 2017 13:42:48 +0000 (13:42 +0000)]
Merge "Fix Blocker/Critical sonar issues"
ramu.n [Fri, 15 Sep 2017 13:15:29 +0000 (18:45 +0530)]
Fix few Major sonar issues
Fix few Major sonar issues in CCSDK SLI Core module
* Remove useless parentheses
* Either log or rethrow the exception
* Remove unused variables
* Add the "@Override" annotation
* Change "try" to a try-with-resources
Change-Id: I64c4bd3c746bb2f226f4f58c39f28a8b2d178953
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
Rich Tabedzki [Fri, 15 Sep 2017 01:02:37 +0000 (01:02 +0000)]
Prepared DBLIB for multi-verndor JDBC Driver
Changes made:
1. removed hardcoded JDBC driver's name and made it a property.
2. Optimized connection pool initialization
3. Removed unused factories.
Change-Id: Id1d1868f7f1a6ae5a0429a97403042a8f6ee78d3
Issue-ID: CCSDK-92
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Marcus G K Williams [Thu, 14 Sep 2017 22:25:57 +0000 (15:25 -0700)]
Log current DG & NodeId using MDC
Uses MDC.put to add current directed
graph and current nodeId to MDC
context which is then logged into the
standard karaf log.
Issue-Id: CCSDK-71
Change-Id: Ieeeea6a89761cdf0ee7a3e63f4e58e182f37ff28
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Dan Timoney [Thu, 14 Sep 2017 20:16:12 +0000 (16:16 -0400)]
Remove pom.xml sections inherited from oparent
Remove pom.xml sections inherited from oparent. In particular, comment
out distributionManagement so that it is inherited from oparent.
Change-Id: I702e70eb712ecfcf02f6707830b1268586c34e09
Issue-ID: CCSDK-43
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Thu, 14 Sep 2017 20:02:25 +0000 (16:02 -0400)]
Use oparent-odlparent in sli/plugins
Update sli/plugins to use oparent-odlparent, used by latest version
of ccsdk odlparent-carbon-sr1 parent.
Change-Id: I315d3e0762f86d1a994c6b0d5c35b2f681b7e538
Issue-ID: CCSDK-43
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Thu, 14 Sep 2017 19:59:25 +0000 (15:59 -0400)]
Use oparent-odlparent in sli/northbound
Update sli/northbound to use oparent-odlparent, used by latest version
of ccsdk odlparent-carbon-sr1 parent.
Change-Id: I77c4452d4af04d3dc4cd0892a9a0dab6c77016bc
Issue-ID: CCSDK-43
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Thu, 14 Sep 2017 18:21:17 +0000 (18:21 +0000)]
Merge "Fix critical issues"
Dan Timoney [Thu, 14 Sep 2017 18:15:38 +0000 (18:15 +0000)]
Merge "Fix SDNC service registration"
Dan Timoney [Thu, 14 Sep 2017 18:14:59 +0000 (18:14 +0000)]
Merge "Fix few sonar issues"
Marcus Williams [Thu, 14 Sep 2017 17:57:40 +0000 (17:57 +0000)]
Merge "Clean up public interfaces"
Marcus Williams [Thu, 14 Sep 2017 17:51:03 +0000 (17:51 +0000)]
Merge "Use oparent-odlparent in sli/core"
Ryan Goulding [Thu, 14 Sep 2017 16:37:10 +0000 (12:37 -0400)]
Fix SDNC service registration
Instead of registgering services via BundleActivator(s), use blueprint
instead. This change deletes the RecordingActivator, as it was just
used to kickstart the service registration using felix dm. The idea
here is to instead use blueprint through recording-blueprint.xml.
The decision was also made to register the Service(s) using the
implementation class name instead of the interface class name for
backwards compatibility reasons. In all reality, registering Service(s)
under the implementation name is less future proof since clients are
no longer able to easily swap in a separate implementation Service.
In the future, we should consider finding usages of this Service and
ensuring that they poll for the interface rather than the implementation.
However, that is separate from this change and is considered future work.
Issue-Id: SDNC-54
Change-Id: I757bb90f91d114668c153ec5debb5c65af44452a
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Marcus Williams [Thu, 14 Sep 2017 16:28:52 +0000 (16:28 +0000)]
Merge "Clean up BaseDBConfiguration class"
Ryan Goulding [Thu, 14 Sep 2017 16:14:12 +0000 (12:14 -0400)]
Clean up public interfaces
The Java programming language assigns certain defaults for methods
and constants defined in interfaces. This change removes the
unnecessary redundant modifiers appropriately.
For example:
* interface methods are public by default
* interface constants are public by default
* interface methods are abstract unless "default" is specifically
used (as of JDK8+).
This is really just to get rid of annoying warnings present in
IDE(s).
Issue-Id: SDNC-79
Change-Id: I2e6b3e4fa02bad1beee2cbb49d3766722eff1ba0
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
ramu.n [Thu, 14 Sep 2017 15:35:22 +0000 (21:05 +0530)]
Fix few sonar issues
Fix few sonar issues in CCSDK SLI Core module
Change-Id: I0e2454f7e23e73087ac42880c5e0b1e4c089dde8
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
shashikanth [Mon, 11 Sep 2017 12:51:17 +0000 (18:21 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in vnfapi module
https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.core%3Asdnc-core#resolved=false|severities=BLOCKER
Issue-Id: CCSDK-67
Change-Id: Ie2ace1bc30bbb50d2b6f25a56e716c7a952e7ea0
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
surya-huawei [Thu, 14 Sep 2017 11:12:27 +0000 (16:42 +0530)]
Fix Sonar Issues
few critical/major issues in sli/plugins module
Issue-Id: CCSDK-87
Change-Id: I4fc33df4ed782670252c9b550349f45b6618c77c
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Thu, 14 Sep 2017 10:26:03 +0000 (15:56 +0530)]
Fix Sonar Issues
few major issues in sli/adaptors module
Issue-Id: CCSDK-87
Change-Id: I43865634fa7d5f5d1b84c7efff691047cfcd5feb
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Thu, 14 Sep 2017 09:55:10 +0000 (15:25 +0530)]
Fix Sonar issues
few major issues in sli/northbound module
Issue-Id: CCSDK-87
Change-Id: I2c1a8b41266aae6941c5f2fdbb8b08ea91dde6ec
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Thu, 14 Sep 2017 06:08:05 +0000 (11:38 +0530)]
Fix critical issues
few critical/major issues in core/sli module
Issue-Id: CCSDK-87
Change-Id: Ib7ef026ecb7fcf658ea8fc66ad5d9b739f02c55b
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Wed, 13 Sep 2017 21:18:25 +0000 (21:18 +0000)]
Merge "Fix Blocker/Critical sonar issues"
Ryan Goulding [Wed, 13 Sep 2017 20:58:19 +0000 (16:58 -0400)]
Clean up BaseDBConfiguration class
This change isn't too big; it mainly just attempts to clean up the
BaseDBConfiguration class using best practices. For example:
* documentation is added surrounding public methods, public constants,
protected variables, and class headers.
* code logic for parsing "optional" integer properties is abstracted
into a separate private static function, which returns a default
value if the given input property cannot be parsed or is not present.
* public functions where the NumberFormatException RuntimeException
might be thrown have the appriorate "throws" modifier added to their
function signatures to indicate that the consumer is responsible for
exception handling.
* constants are extracted in place of "magic numbers"
This is really just code sanitation work.
Change-Id: Ifaf092e10b17f54c7cce0a888aa49bfe8377cdd3
Issue-Id: SDNC-79
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Dan Timoney [Wed, 13 Sep 2017 20:50:22 +0000 (20:50 +0000)]
Merge "Fix Blocker/Critical sonar issues"
Dan Timoney [Wed, 13 Sep 2017 20:32:45 +0000 (16:32 -0400)]
Use oparent-odlparent in sli/core
Update sli/core to use oparent-odlparent. To prevent verify builds from
failing due to unit test errors, also changed unit tests that require
database access to use MariaDB4j to start up a local MariaDB database.
Change-Id: I928b7e1e83bdb328ca9e0785c8b81f67f982eeda
Issue-ID: CCSDK-43
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 13 Sep 2017 20:27:07 +0000 (20:27 +0000)]
Merge "Fix Sonar Issues"
Dan Timoney [Wed, 13 Sep 2017 20:26:57 +0000 (20:26 +0000)]
Merge "Fix Sonar Issues"
Dan Timoney [Wed, 13 Sep 2017 20:25:24 +0000 (20:25 +0000)]
Merge "Fix sonar issues"
Dan Timoney [Wed, 13 Sep 2017 20:20:21 +0000 (20:20 +0000)]
Merge "Fix Sonar Issues"
Dan Timoney [Wed, 13 Sep 2017 20:20:04 +0000 (20:20 +0000)]
Merge "Fix Sonar Issues"
Ryan Goulding [Tue, 12 Sep 2017 19:13:44 +0000 (15:13 -0400)]
Remove unused imports in java files
Code sanitation-- remove unused imports.
Issue-Id: SDNC-79
Change-Id: I5306a9b90f302086459fcac98d04f541ba7c79a4
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
surya-huawei [Mon, 11 Sep 2017 09:46:36 +0000 (15:16 +0530)]
Fix Sonar issues
Few major issues in adapters/aai module
Issue-id: CCSDK-67
Change-Id: I76d9576b742f846e3259ffe9bfaf1845d64abadb
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Tue, 12 Sep 2017 09:59:44 +0000 (15:29 +0530)]
Fix Sonar Issues
few major issues in sli/core/dblib module
Issue-id: CCSDK-87
Change-Id: Ie3b13468d23c1e7dc2228bb7a0cd1bde5cc632e8
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Tue, 12 Sep 2017 06:22:59 +0000 (11:52 +0530)]
Fix Sonar Issues
few major issues in sli/core/filters module
Issue-Id- CCSDK-87
Change-Id: Idbf2b12b866d48161f089271a2403aaee6b8d04f
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Tue, 12 Sep 2017 10:20:07 +0000 (15:50 +0530)]
Fix sonar issues
few major issues in dblib module
Issue-Id: CCSDK-87
Change-Id: I6bc1fe2cf04cec0a5ad3bfb65bc3a10e5f488eea
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Tue, 12 Sep 2017 05:37:35 +0000 (11:07 +0530)]
Fix Sonar Issues
few major issues in sli/core module
Issue-Id: CCSDK-87
Change-Id: I1fb86f084d270906dcf61d33701da54a82f2c3a4
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Ryan Goulding [Thu, 7 Sep 2017 19:21:05 +0000 (15:21 -0400)]
Fix SDNC service registration
Move the northbound to utilize Aries Blueprint instead of ODL's
configuration subsystem
Change-Id: I7388391d40912136176bb28b817157676f71557d
Issue-Id: SDNC-54
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
surya-huawei [Tue, 12 Sep 2017 04:17:40 +0000 (09:47 +0530)]
Fix Sonar Issues
few major issues in sli/core module
Issue-Id: CCSDK-87
Change-Id: Id563cd2fb31f477f96e14b180501feeb37fb24a7
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Mon, 11 Sep 2017 11:06:49 +0000 (16:36 +0530)]
Fix Sonar issues
Few major issues in sli/core module
Issue-id: CCSDK-67
Change-Id: Iad65b30a6b27814c1984d8db42d36f8569c5cb3f
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Mon, 11 Sep 2017 20:25:48 +0000 (20:25 +0000)]
Merge "Fix Blocker/Critical sonar issues"
Dan Timoney [Mon, 11 Sep 2017 20:15:25 +0000 (20:15 +0000)]
Merge "Fix Sonar Issues"
Dan Timoney [Mon, 11 Sep 2017 15:19:51 +0000 (11:19 -0400)]
Remove cast to DBResourceManager
Remove cast to DBResourceManager, which no longer works after
DbLibService is advertised via Aries Blueprint and which is no
longer needed after DbLibService interface exposes getConnection()
method.
Updated version number - seems like an older 0.1.1-SNAPSHOT without
DbLibService change is being used, so trying to see if bumping version will
help.
Change-Id: Ia411d1514bca396cc052f4f16eda6c79e0d13648
Issue-ID: CCSDK-86
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Mon, 11 Sep 2017 15:21:41 +0000 (15:21 +0000)]
Merge "Fix few Blocker sonar issues"
Dan Timoney [Mon, 11 Sep 2017 15:15:31 +0000 (15:15 +0000)]
Merge "Expose getConnection from DblibSeervice"
Dan Timoney [Fri, 8 Sep 2017 22:52:46 +0000 (18:52 -0400)]
Expose getConnection from DblibSeervice
Exposed getConnection from DbLibService class so that it can be accessed
from OSGi client. Prior to blueprint refactoring, this was accessible
by casting DbLibService as DBResourceManager, but that cast no longer
works if OSGi service is advertised by blueprint. It's cleaner to expose
that method in the interface anyway.
Change-Id: I36ed7fe82b0393a952d307a1c79d1d8c0ba11dd4
Issue-ID: CCSDK-86
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Mon, 11 Sep 2017 13:44:50 +0000 (13:44 +0000)]
Merge "Fix few Critical sonar issues"
shashikanth [Mon, 11 Sep 2017 13:22:19 +0000 (18:52 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in ccsdk/core module
https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.core%3Asdnc-core#resolved=false|severities=BLOCKER
Issue-Id: CCSDK-67
Change-Id: Iec86b90f7085f4b96d4f92adf4064b70640fcf22
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
surya-huawei [Mon, 11 Sep 2017 12:21:24 +0000 (17:51 +0530)]
Fix Sonar Issues
Few major issues in Restapi call node
Issue-Id: CCSDK-87
Change-Id: Ieb733fcf178cecb9983b5135be8d7737cb42a1f3
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Mon, 11 Sep 2017 08:51:31 +0000 (14:21 +0530)]
Fix Sonar Issues
Few major issues in adapters module
Issue-id: CCSDK-67
Change-Id: I4ef21d95a5316c61971f506d769714fa37d42d63
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Marcus Williams [Fri, 8 Sep 2017 23:23:33 +0000 (23:23 +0000)]
Merge "Correct parameter reference in features.xml"
Dan Timoney [Fri, 8 Sep 2017 22:59:57 +0000 (18:59 -0400)]
Correct parameter reference in features.xml
Features.xml refers to wrong property name for httpcomponents references.
Change-Id: I6e09f9f89d2d25b9f6de23ce395f8d2bd065acc6
Issue-ID: CCSDK-79
Signed-off-by: Dan Timoney <dtimoney@att.com>
Jessica Wagantall [Fri, 8 Sep 2017 21:49:09 +0000 (14:49 -0700)]
Cleanup project's name in Sonar
The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.
Change-Id: I73a561752044b0d1b03a1b52f4b432f4c3329269
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Jessica Wagantall [Fri, 8 Sep 2017 21:26:25 +0000 (14:26 -0700)]
Cleanup project's name in Sonar
The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.
Change-Id: I8ddd7b466586eb7e90cae83270dcc9d4d5cb41ea
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Jessica Wagantall [Fri, 8 Sep 2017 20:17:30 +0000 (13:17 -0700)]
Cleanup project's name in Sonar
The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.
Change-Id: Iecfd1bf6a7937437728e5cf136b63c896da49b44
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Jessica Wagantall [Fri, 8 Sep 2017 18:53:50 +0000 (11:53 -0700)]
Cleanup project's name in Sonar
The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.
Change-Id: I5ea954dd39d9ca8e083978b1130393001b3e36be
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>