Dan Timoney [Mon, 2 Oct 2017 21:17:10 +0000 (17:17 -0400)]
Add test cases for MdsalHelper
Fix test case for loadProperties, and added test cases for IpAddress
types
Change-Id: Iabf182d32ae3937871dc9656105fdda0c1a9411f
Issue-ID: CCSDK-106
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Mon, 2 Oct 2017 19:48:23 +0000 (15:48 -0400)]
Add test cases for MdsalHelper
Add test cases for MdsalHelper methods toBuilder() and toProperties().
This requires a Yang model, so added a copy of sliapi/model to sli, since
could not use sliapi directly otherwise would create circular
dependency (since sliapi depends on sli).
Change-Id: I4824afe250f93428c73dbeec9f4a4c36ee4f76e6
Issue-ID: CCSDK-106
Signed-off-by: Dan Timoney <dtimoney@att.com>
ramu.n [Fri, 29 Sep 2017 01:02:52 +0000 (06:32 +0530)]
Update VoLTE underlay JSON template
*Add vrf-attribute configuration
*Add BGP protocol type for ac
Change-Id: I6deb5b4ec6d71b18e8d6b67aadaba18b7a27c47b
Issue-Id: SDNC-108
Signed-off-by: Ramu N <ramu.n@huawei.com>
Brian Freeman [Thu, 28 Sep 2017 20:31:06 +0000 (20:31 +0000)]
SLI-API northbound add to docs
Issue-ID: CCSDK-107
Change-Id: Ic4a41466288229140ae3cad79e650d14c7877cc9
Signed-off-by: Brian Freeman <bf1936@att.com>
Dan Timoney [Thu, 28 Sep 2017 13:46:03 +0000 (13:46 +0000)]
Merge "Add a unit test for mdsal"
Dan Timoney [Thu, 28 Sep 2017 13:12:26 +0000 (13:12 +0000)]
Merge "Setup ReadTheDocs"
Dan Timoney [Thu, 28 Sep 2017 13:03:40 +0000 (13:03 +0000)]
Merge "SPTN l3vpn template"
Dan Timoney [Thu, 28 Sep 2017 13:03:22 +0000 (13:03 +0000)]
Merge "Added @Override annotation"
Dan Timoney [Thu, 28 Sep 2017 13:03:11 +0000 (13:03 +0000)]
Merge "Fix major sonar issue"
Dan Timoney [Thu, 28 Sep 2017 13:02:39 +0000 (13:02 +0000)]
Merge "Improve SDNC Sonar coverage"
Dan Timoney [Thu, 28 Sep 2017 13:02:25 +0000 (13:02 +0000)]
Merge "Deleted redundant try catch block"
Dan Timoney [Thu, 28 Sep 2017 13:02:05 +0000 (13:02 +0000)]
Merge "Implement test cases for fabric discovery plugin"
surya-huawei [Thu, 28 Sep 2017 12:29:53 +0000 (17:59 +0530)]
Add a unit test for mdsal
*Add a negative unit test case for ConfigResource
This is to check availability of query and
improve sonar code coverage
Issue-Id: CCSDK-106
Change-Id: Ic276d1cfacce3aea7444adcb7bf09d6cdffb294e
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Brian Freeman [Thu, 28 Sep 2017 12:05:43 +0000 (12:05 +0000)]
Setup ReadTheDocs
Issue-ID: CCSDK-107
Change-Id: I8b0715d07c50734217806ac24e5610b5f478ce04
Signed-off-by: Brian Freeman <bf1936@att.com>
Brian Freeman [Thu, 28 Sep 2017 12:01:42 +0000 (12:01 +0000)]
Setup ReadTheDocs
Issue-ID: CCSDK-107
Change-Id: I6f09524c02f899bd4e6df82e6eda8e94518fe8ec
Signed-off-by: Brian Freeman <bf1936@att.com>
Brian Freeman [Thu, 28 Sep 2017 11:58:46 +0000 (11:58 +0000)]
Setup ReadTheDocs
Issue-ID: CCSDK-107
Change-Id: I36f8eb45a8c897583018342ac15894fb63a823ec
Signed-off-by: Brian Freeman <bf1936@att.com>
Brian Freeman [Thu, 28 Sep 2017 11:03:28 +0000 (11:03 +0000)]
Setup ReadTheDocs
Issue-ID: CCSDK-107
Change-Id: I98bc6f3a3827bb1f4e03eb08474b15e26662705f
Signed-off-by: Brian Freeman <bf1936@att.com>
Dan Timoney [Thu, 28 Sep 2017 10:37:17 +0000 (10:37 +0000)]
Merge "Added l2-dci json template and updated l3-dci"
Gaurav Agrawal [Thu, 28 Sep 2017 09:50:37 +0000 (15:20 +0530)]
Added l2-dci json template and updated l3-dci
Following changes are included:
1) Added l2-dci template
2) Updated l3-dci template to handle paramaters generically for l2 and l3
3) Leaf-List handling
4) Added testcases for l2 and l3 template.
Change-Id: I3142ae35286ea3c55927bedf5a071aaff5b15401
Issue-Id: SDNC-103
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
黄卓垚10112215 [Thu, 28 Sep 2017 06:34:15 +0000 (14:34 +0800)]
SPTN l3vpn template
Change-Id: I3349a43e2dbd8948fbc5573a6c064c45e7a443de
Issue-ID: SDNC-91
Signed-off-by: Zhuoyao Huang <10112215@zte.com.cn>
Dan Timoney [Thu, 28 Sep 2017 07:21:00 +0000 (07:21 +0000)]
Merge "Remove redundant casts"
Dan Timoney [Thu, 28 Sep 2017 07:20:32 +0000 (07:20 +0000)]
Merge "Close the inputstream"
surya-huawei [Thu, 28 Sep 2017 06:01:42 +0000 (11:31 +0530)]
Remove redundant casts
*Remove unnecessary cast to "CachedDataSource"
These unnecessary casting expressions maked the
code harder to read and understand
*Replace type specification with diamond operator
This is to reduce the verbosity of generics code
Issue-Id: CCSDK-87
Change-Id: I6cd2f7d16886ffa6cc26e5dd300b8376705d9366
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Thu, 28 Sep 2017 05:46:21 +0000 (11:16 +0530)]
Close the inputstream
*Use try with resources to close the resource
This is done to ensure that the resource
is closed
Issue-Id: CCSDK-87
Change-Id: Ie5ebcffcec3350902305b35909e64d3cd518c49b
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
shashikanth [Wed, 27 Sep 2017 11:42:46 +0000 (17:12 +0530)]
Added @Override annotation
Fix major sonar issues in ccsdk/sli/core module
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=MAJOR|rules=squid%3AS1161
Add the "@Override" annotation above this method signature
Issue-Id:CCSDK-67
Change-Id: I233be3f88547049a5f78c438e87f2f8c0129df78
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
ramu.n [Thu, 28 Sep 2017 03:15:27 +0000 (08:45 +0530)]
Add VoLTE underlay JSON template
Add VoLTE underlay JSON template used to communicate with 3rd party controller of IP WAN Network
Change-Id: Icc93da198c7a1f3d9ed462e178571e316fde3f83
Issue-Id: SDNC-90
Signed-off-by: Ramu N <ramu.n@huawei.com>
Rich Tabedzki [Thu, 28 Sep 2017 03:00:10 +0000 (03:00 +0000)]
Refined DBLIB blueprint configuration
Changes made:
1. updated DBLibService definition by registering service on two interfaces:
a) javax.sql.DataSource
b) org.onap.ccsdk.sli.core.dblib.DbLibService
Change-Id: If187b07db83ebca5428c809a83f546d9178a2b7f
Issue-ID: CCSDK-102
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Rich Tabedzki [Thu, 28 Sep 2017 02:22:20 +0000 (02:22 +0000)]
Added Blueprint configuration
Changes made:
1. Removed Spring DM configuration for resource-assignment
2. Added blueprint configuration for resource-assignment
Change-Id: Ib084b863a6a5ee1283ba3dfb7b61d61619a27c38
Issue-ID: CCSDK-102
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Dan Timoney [Wed, 27 Sep 2017 19:31:23 +0000 (19:31 +0000)]
Merge "Refinements to core"
Dan Timoney [Wed, 27 Sep 2017 19:30:35 +0000 (19:30 +0000)]
Merge "Add VoLTE Overlay Json template"
surya-huawei [Tue, 26 Sep 2017 07:31:50 +0000 (13:01 +0530)]
Add unit test for SliStringUtils
*Made quotedOrNull method public
This is done for accessing this in ut
*Added a unit test for the SliStringUtils.quotedOrNull()
This is done for increasing code coverage
Issue-Id: CCSDK-106
Change-Id: I9d74c6645256227b23beded5179fbb28ac3d3c04
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Marcus G K Williams [Wed, 27 Sep 2017 17:12:50 +0000 (10:12 -0700)]
Add VoLTE Overlay Json template
Issue-Id: SDNC-43
Change-Id: I9569f853a722dd43ef8723d2ed16077b5b02a1ff
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
ramu.n [Wed, 27 Sep 2017 13:14:14 +0000 (18:44 +0530)]
Add underlay JSON template validation
Add UT test cases to validate the JSON template used to communicate with 3rd party controller of IP WAN Network
Change-Id: I251f5cabecdd7e4f02d0be3bb27d7af4a355c077
Issue-Id: SDNC-90
Signed-off-by: Ramu N <ramu.n@huawei.com>
shashikanth [Wed, 27 Sep 2017 11:01:12 +0000 (16:31 +0530)]
Fix major sonar issue
Fix major sonar issues in ccsdk/sli/core module
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=MAJOR|rules=squid%3AS1161
Add the "@Override" annotation above this method signature.
Issue-Id:CCSDK-67
Change-Id: Ie074574c7bbd2ca394d116e73aa6aab47ad5b8de
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Gaurav Agrawal [Wed, 27 Sep 2017 10:43:04 +0000 (16:13 +0530)]
Refinements to core
Changes includes:
1. Simplifying the test cases.
2. Critical Sonar issue fix for MdsalHelper
3. Critical sonar issue fix for SvcLogicServiceImpl
4. Use logger in-built formatting.
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=CRITICAL
Change-Id: Ib85637fcd2351970f8d96bf6b855db05cf7d9834
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
shashikanth [Wed, 27 Sep 2017 10:13:48 +0000 (15:43 +0530)]
Improve SDNC Sonar coverage
Added initial test cases for ASDC-APIs
Issue-Id: SDNC-101
Change-Id: Iad8be979e39099e4ece8210dbd5d2c9c64b60990
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Dan Timoney [Wed, 27 Sep 2017 07:53:31 +0000 (07:53 +0000)]
Merge "Use Long.toString instead"
Dan Timoney [Wed, 27 Sep 2017 07:47:35 +0000 (07:47 +0000)]
Merge "Some minor refinements in CCSDK SLI Core module"
Dan Timoney [Wed, 27 Sep 2017 07:47:00 +0000 (07:47 +0000)]
Merge "Remove hardcoded dependency versions"
Dan Timoney [Wed, 27 Sep 2017 07:46:26 +0000 (07:46 +0000)]
Merge "Use Map's entrySet instead of keySet"
Dan Timoney [Wed, 27 Sep 2017 07:44:46 +0000 (07:44 +0000)]
Merge "Fixes for SvcLogicActivator"
surya-huawei [Mon, 25 Sep 2017 09:26:04 +0000 (14:56 +0530)]
Use Long.toString instead
Major sonar issue in sli/core module
*Using static method to reduce
memory and cycles
Issue-Id: CCSDK-87
Change-Id: Iaf255892a4bd698934f865a707e54f8e740370ab
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Rich Tabedzki [Tue, 26 Sep 2017 17:19:32 +0000 (17:19 +0000)]
Updated DBLIB svc definition
Changes made:
1. updated DBLibService definition by adding javax.sql.DataSource
Change-Id: I5dd63a81420f451b0ce9bbbc878d351d62ccd819
Issue-ID: CCSDK-102
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
shashikanth [Tue, 26 Sep 2017 09:26:41 +0000 (14:56 +0530)]
Deleted redundant try catch block
Extract this nested try block into a separate method.
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.northbound%3Accsdk-sli-northbound#resolved=false|severities=MAJOR|rules=squid%3AS1141
Issue-Id: CCSDK-87
Change-Id: I989791d876b5a199f75983ba5137770f80995ef1
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
surya-huawei [Mon, 25 Sep 2017 12:01:57 +0000 (17:31 +0530)]
Fix some sonar issues in sli/northbound
*Replace type specification with diamond operator
This is done to reduce the verbosity of generics code
*Replace ("") with ('') in String.lastIndexOf()
This is more efficient for single character
*Remove temp variable which is immediately returned
New variable is not necessary as the caller cannot see this
Issue-Id: CCSDK-87
Change-Id: I353652de723a624935d819b2bc817b4907af98ed
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
ramu.n [Mon, 25 Sep 2017 11:22:45 +0000 (16:52 +0530)]
Some minor refinements in CCSDK SLI Core module
*Remove useless braces while logging exception stack trace
*Register all DG nodes in SvcLogicParser Test file
Change-Id: I7916bec20e36e1def15c24806da2f7e01e79bf4b
Issue-Id: CCSDK-106
Signed-off-by: Ramu N <ramu.n@huawei.com>
surya-huawei [Mon, 25 Sep 2017 09:12:11 +0000 (14:42 +0530)]
Use Map's entrySet instead of keySet
Major Sonar issue in sli/adaptors module
*When both keys and values of map are used,
using entrySet is more efficient
Issue-Id: CCSDK-87
Change-Id: I1a8df0bc42de2c75b5217fd2570fb579d1897760
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Gaurav Agrawal [Mon, 25 Sep 2017 09:18:42 +0000 (14:48 +0530)]
Remove hardcoded dependency versions
Remove the hardcoded junit & common-lang version and rather take from parent pom.
Change-Id: Ibc71ff4b86a2fefc89365017f06333776cb2fed3
Issue-Id: CCSDK-105
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Gaurav Agrawal [Mon, 25 Sep 2017 08:56:18 +0000 (14:26 +0530)]
Fix JUNIT version to pick from parent pom.
Remove the hardcoded version and rather take from parent pom.
Change-Id: I0874903b144e0e175c42dc4e36425528d74ad968
Issue-Id: CCSDK-105
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
surya-huawei [Fri, 22 Sep 2017 13:14:07 +0000 (18:44 +0530)]
Remove unused imports
Removed unused imports to increase the code's readability
Issue-Id: CCSDK-87
Change-Id: Ib8f9dbe1e0a05567c75f7fcd46ab024f5b433fef
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Gaurav Agrawal [Mon, 25 Sep 2017 07:28:52 +0000 (12:58 +0530)]
Fixes for SvcLogicActivator
1. Convert tabs to 4 spaces.
2. Break lines to be less than 120 characters
3. Remove extraneous spaces/parenthesis & redundant assignments.
4. Use logger built-in string format.
5. Fix critical sonar issues.
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=CRITICAL
Change-Id: Idb348f125e92f0e9be30847c41b385411220fd96
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Arun S. Yerra [Mon, 25 Sep 2017 04:42:08 +0000 (21:42 -0700)]
Implement test cases for fabric discovery plugin
This change adds a negative test case to test input from
directed graph to specify whether to start or stop
listening to domain controller notifications.
Issue-id: CCSDK-96
Change-Id: I19e904c39e58e81d39079e233c68383496d8bc59
Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
ramu.n [Sat, 23 Sep 2017 16:58:03 +0000 (22:28 +0530)]
Some minor refinements in CCSDK SLI Core module
Fix few Critical/Major sonar issues in CCSDK SLI Core module
* Define and throw a dedicated exception instead of using a generic one
* Either log or rethrow the exception
* Change "try" to a try-with-resources
* Remove useless assignment to local variable
* Use built-in logger method string formatting instead of string concatination
* code indentation
Change-Id: I83dc1fb931b8021118e259c722f7dfbc1621dce8
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
Arun S. Yerra [Fri, 22 Sep 2017 22:20:32 +0000 (15:20 -0700)]
Implement test cases for fabric discovery plugin
This change adds a negative test case to test input from
directed graph to start listening to domain controller
notifications.
Issue-id: CCSDK-96
Change-Id: I2dd1a4d2264df4c142362e242e04bf9495e0351a
Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
Dan Timoney [Fri, 22 Sep 2017 19:48:31 +0000 (19:48 +0000)]
Merge "Fix Blocker/Critical sonar issues"
Dan Timoney [Fri, 22 Sep 2017 19:47:40 +0000 (19:47 +0000)]
Merge "Fix Blocker/Critical sonar issues"
Dan Timoney [Fri, 22 Sep 2017 19:46:57 +0000 (19:46 +0000)]
Merge "Fix sli dependency"
Dan Timoney [Fri, 22 Sep 2017 19:46:40 +0000 (19:46 +0000)]
Merge "Fix sli dependency"
Dan Timoney [Fri, 22 Sep 2017 19:46:15 +0000 (19:46 +0000)]
Merge "Fix sli dependency"
Patrick Brady [Fri, 22 Sep 2017 16:41:20 +0000 (09:41 -0700)]
Changes to fix failing utils feature
Change-Id: I88d30aaf49da78008c62352d398323fbc0d4dd5b
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-id: CCSDK-102
Dan Timoney [Fri, 22 Sep 2017 12:12:53 +0000 (12:12 +0000)]
Merge "Add "@Override" annotation"
Dan Timoney [Fri, 22 Sep 2017 12:09:12 +0000 (12:09 +0000)]
Merge "Resolved sonar issue."
Dan Timoney [Fri, 22 Sep 2017 12:07:22 +0000 (12:07 +0000)]
Merge "Sql query blocker issue fixed."
surya-huawei [Fri, 22 Sep 2017 11:20:44 +0000 (16:50 +0530)]
Remove unnecessary constructs
*Remove unused imports
*Remove useless paranthesis
This is done as sometimes they can be misleading
*Replace type specification with diamond operator(<>)
This is done to reduce verbosity of generics code
Issue-Id: CCSDK-87
Change-Id: Ic356859939fe40cecec2e65c96d79cd6a655787e
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Fri, 22 Sep 2017 11:10:30 +0000 (16:40 +0530)]
Add "@Override" annotation
Added @Override annotation before method signature
*This is to improve the readability of code
Issue-Id: CCSDK-87
Change-Id: I979eb03ec81b9868012e5c16f48b595c8e53e26e
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Fri, 22 Sep 2017 05:25:16 +0000 (10:55 +0530)]
Use Integer.toString() for type conversion
Major sonar issue in sli/adaptors module
*Intead of implicit type conversion use static method
to save memory and cycles
Issue-Id: CCSDK-87
Change-Id: Icb75229ffb41bdf8b683f2a306acc856ce9106f6
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Thu, 21 Sep 2017 20:07:02 +0000 (16:07 -0400)]
Install sdnc-core utils as karaf package
New utils jar was added in another change, but wasn't bundled as a karaf
feature and was not being installed in container. This broke odlsli
docker container. This change wraps that util package as a new
feature (sdnc-core-utils).
Change-Id: Ie8c1d608e2c67aa1635837bc400cec942761c81c
Issue-ID: CCSDK-54
Signed-off-by: Dan Timoney <dtimoney@att.com>
Bharat saraswal [Thu, 21 Sep 2017 09:39:52 +0000 (15:09 +0530)]
Sql query blocker issue fixed.
Rdundant code and complextity of methods reduced.
@override annotaiton added.
Exception handling and logging impoved.
Issue-ID:CCSDK-87
Change-Id: I3907be73a2f6ccdfadeaed79c87705ae7afdb4ab
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
Bharat saraswal [Thu, 21 Sep 2017 10:53:11 +0000 (16:23 +0530)]
Resolved sonar issue.
Related to exception handling.
@Override method
Redundant code and resulable parameters
Issue-Id:CCSDK-87
Change-Id: I82e2aad453edf5cd647c87322fc75b2a56c37566
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
Dan Timoney [Thu, 21 Sep 2017 14:50:05 +0000 (14:50 +0000)]
Merge "Replace type specification with diamond operator"
Dan Timoney [Thu, 21 Sep 2017 14:49:31 +0000 (14:49 +0000)]
Merge "Improve code coverage for MdsalHelper"
Dan Timoney [Thu, 21 Sep 2017 14:48:36 +0000 (14:48 +0000)]
Merge "Remove unnecessary parentheses"
Dan Timoney [Thu, 21 Sep 2017 14:45:41 +0000 (14:45 +0000)]
Merge "Refinements and test additions to XmlParser"
shashikanth [Thu, 21 Sep 2017 13:54:34 +0000 (19:24 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in ccsdk/sli/adaptors module
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.adaptors%3Accsdk-sli-adaptors#resolved=false|severities=BLOCKER
Fixed Close "PreparedStatement".
Issue-Id: CCSDK-67
Change-Id: I2d4b42067f3286806f7bca8821ce17328d72091f
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Thu, 21 Sep 2017 13:42:31 +0000 (19:12 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in ccsdk/sli/adaptors module
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.adaptors%3Accsdk-sli-adaptors#resolved=false|severities=BLOCKER
Deleted redundant code
Issue-Id: CCSDK-67
Change-Id: I1bbdb60ead844b91dd0e07795f7f929be8cce44c
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Bharat saraswal [Thu, 21 Sep 2017 12:55:09 +0000 (18:25 +0530)]
Resolved below sonar issues.
Method complextity.
Redudant code and varibales.
Exception handling.
Refacting of code.
Issue-Id:CCSDK-87
Change-Id: I757c6a6d3c403f81f725ad97a7759225d0709468
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
surya-huawei [Thu, 21 Sep 2017 11:17:19 +0000 (16:47 +0530)]
Replace type specification with diamond operator
Major issue in sli/plugins module
*Used diamond operator to reduce verbosity of generics code
*Removed unnecessary parantheses as they can be misleading
sometimes
Issue-Id: CCSDK-87
Change-Id: I81c0b566f5beb81d3733549a2f9de81b50d6814c
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Gaurav Agrawal [Thu, 21 Sep 2017 10:59:34 +0000 (16:29 +0530)]
Improve code coverage for MdsalHelper
Changes includes
1. Modified pom to take JUNIT version from parent pom.
2. Added basic testcases for MdsalHelper utilities with test YANG.
3. Made necessary pom additions.
Change-Id: Ib46bd9c8a87db33c90aaaf36736d709a7c17cbdd
Issue-Id: CCSDK-101
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
surya-huawei [Thu, 21 Sep 2017 10:25:14 +0000 (15:55 +0530)]
Use Integer.toString for type conversion
*Used Integer.toString instead of implicit type conversion
This is done to make use of static and reduce cycles
*Removed one unused import
*Removed unnecessary parantheses
Sometimes useless parantheses can be misleading hence removed
Issue-Id: CCSDK-87
Change-Id: I23f56cb7c5a6dafa79f64d5cd8faa0994f0ff288
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Thu, 21 Sep 2017 10:03:03 +0000 (15:33 +0530)]
Remove unnecessary parentheses
*Useless parentheses can sometimes be misleading
and hence removed
Issue-Id: CCSDK-87
Change-Id: I018d791500a42356296d07d04de45517d061bb7f
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Thu, 21 Sep 2017 09:30:19 +0000 (15:00 +0530)]
Move string literals to left hand side
Moving string literals to left-hand side of equals()/equalsIgnore()
*This is done to prevent null pointer exception
from being raised
Issue-Id: CCSDK-87
Change-Id: Ibe9deee4fd48b3037be8708a0e3869d741c9173b
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Bharat saraswal [Thu, 21 Sep 2017 05:47:57 +0000 (11:17 +0530)]
Fix Sonar Issues in sli/core module
Few major issues
*Remove unused variables
To increase code readability
*Replace the type specification with the diamond operator
*Add the "@Override" annotation above this method signature
To increase code readability"
Issue-Id: CCSDK-87
Change-Id: I2f0c16a83ab10a0a3e39a2a1d4db3c195ec2bba8
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
Dan Timoney [Wed, 20 Sep 2017 20:02:58 +0000 (20:02 +0000)]
Merge "Abstract utility classes for re-use"
Dan Timoney [Wed, 20 Sep 2017 20:01:37 +0000 (20:01 +0000)]
Merge "Some minor refinements in CCSDK SLI Northbound"
Dan Timoney [Wed, 20 Sep 2017 20:00:51 +0000 (20:00 +0000)]
Merge "Use entrySet instead of keySet"
Dan Timoney [Wed, 20 Sep 2017 19:59:55 +0000 (19:59 +0000)]
Merge "Fix Sonar Issues in sli/core module"
Dan Timoney [Wed, 20 Sep 2017 19:58:23 +0000 (19:58 +0000)]
Merge "Fixes for MdsalHelper util"
Dan Timoney [Wed, 20 Sep 2017 19:32:15 +0000 (19:32 +0000)]
Merge "Fix Sonar Issue"
Ryan Goulding [Tue, 19 Sep 2017 15:14:41 +0000 (11:14 -0400)]
Abstract utility classes for re-use
When looking at the existing uses of BundleActivator(s), it became
immediately clear that other parts of the code have a strategy based
properties file resolution very similar to those abstracted by dblib.
This change aggregates a separate utils bundle for this functionality,
which is further abstracted for potential reuse with other use cases.
The next use case is in the sli bundle, which will be handled in
a follow-up patch.
Issue-Id: SDNC-54
Change-Id: Ie4d4bb679617474b1983e6044c08cca1742b9893
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
ramu.n [Wed, 20 Sep 2017 11:44:38 +0000 (17:14 +0530)]
Some minor refinements in CCSDK SLI Northbound
Fix few Critical/Major sonar issues in CCSDK SLI Northbound module
* Remove useless parentheses
* Remove useless assignment to local variable
* Use built-in logger method string formatting instead of string concatination
* code indentation
* Replace for loop with foreach
Change-Id: I9a2e3345f23feb2d96045ac714d8acc528de464b
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
surya-huawei [Wed, 20 Sep 2017 11:20:20 +0000 (16:50 +0530)]
Use entrySet instead of keySet
*Iterating over map entries with entrySet
This is done because both key and value are needed and
iterating over entryset is more efficient than keyset
Issue-Id: CCSDK-87
Change-Id: I31d14239c8f7300ff2d3a629683e00b42e61ad86
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Wed, 20 Sep 2017 10:48:41 +0000 (16:18 +0530)]
Remove useless assigment to local variables
*Removed dead stores
This is done to avoid waste of resources
Issue-Id: CCSDK-87
Change-Id: Ie36255c6583792e2535000ee1bd5b2a3018632ff
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Wed, 20 Sep 2017 10:05:23 +0000 (15:35 +0530)]
Fix Sonar Issues in sli/core module
Few major issues
*Remove unused imports
To increase code readability
*Replace the type specification with the diamond operator
To reduce the verbosity of generics code
*Add the "@Override" annotation above this method signature
To increase code readability
*Remove this unnecessary cast to "String"
Unnecessary casting expressions pollutes code
Issue-Id: CCSDK-87
Change-Id: I38952f5026a5c61af73ac16706e8ddc278566b13
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Gaurav Agrawal [Wed, 20 Sep 2017 09:40:54 +0000 (15:10 +0530)]
Fixes for MdsalHelper util
1. Convert tabs to 4 spaces.
2. Break lines to be less than 120 characters
3. Remove extraneous spaces and parenthesis
4. Fixed blocker/critical sonar issues.
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=BLOCKER%2CCRITICAL
Change-Id: I8b40784ecb178409a6fe9a00d28ccd03873044c5
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Gaurav Agrawal [Wed, 20 Sep 2017 07:13:42 +0000 (12:43 +0530)]
Refinements and test additions to XmlParser
Changes includes
1) Added validation for invalid length
2) Added testcases to test length
Change-Id: Iefd56ca470382be139f185fdf84b6c0de0fa99f6
Issue-Id: CCSDK-100
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
surya-huawei [Wed, 20 Sep 2017 06:52:35 +0000 (12:22 +0530)]
Fix Sonar Issue in sli/adaptors module
One blocker issue
*Checking for a null dereferencing
This is to avoid NullPointerException
Issue-Id: CCSDK-87
Change-Id: Ie2192636e3ad8dfa9643cac61b3086c3cd33f126
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Tue, 19 Sep 2017 09:27:17 +0000 (14:57 +0530)]
Fix Sonar Issue
One blocker issue in sli/core module
*Check for null dereferencing
Issue-Id: CCSDK-87
Change-Id: I5ebaef24b3fd6534b5e818c3087e3d8213ed770c
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Gaurav Agrawal [Wed, 20 Sep 2017 06:18:54 +0000 (11:48 +0530)]
Changes to RestApiCall plugin
Changes includes
1. Perform validation of URL syntax during parameter parsing phase.
2. StringBuilder to replace string concatenation within loop.
3. Testcase addition.
4. Sonar critical issue fix for XmlJsonUtil
5) Use logger built-in string formatting rather then string concatenation
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.plugins%3Accsdk-sli-plugins#resolved=false|severities=CRITICAL
Change-Id: I884af51023bbd4983c43707aca97c398d24fc9de
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
ramu.n [Wed, 20 Sep 2017 05:42:43 +0000 (11:12 +0530)]
Fix few Major sonar issues
Fix few Major sonar issues in CCSDK SLI Core module
* Remove useless assignment to local variable
* Use built-in logger method string formatting instead of string concatination
* code indentation
Change-Id: I20fc9d8f4c510f6169e6f989c6f5595371e5f2dd
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
Dan Timoney [Wed, 20 Sep 2017 00:48:48 +0000 (20:48 -0400)]
Remove unthrown exception
Merge build fails because catch statement is trying to catch JSONException
which is not thrown in body of try
Change-Id: I9e29e1698e04f8135799440ca4859aa418d1c54d
Issue-ID: CCSDK-99
Signed-off-by: Dan Timoney <dtimoney@att.com>
Code Review / ccsdk / sli.git / log