jenkins-releng [Wed, 9 Sep 2020 19:22:23 +0000 (19:22 +0000)]
Release policy/drools-applications
jhh [Wed, 9 Sep 2020 18:26:21 +0000 (13:26 -0500)]
disable TdjamTest junits
junits consistently fail in staging jobs
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I968bd9ec2c3e8278358ef3c487592c0b833cef36
jhh [Wed, 9 Sep 2020 15:47:28 +0000 (10:47 -0500)]
delete guard dependency for tdjam
staging job fails as there is no guard dependency.
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I4d803e269c7199ddeb2ebb52df5368259e4f22cd
jhh [Tue, 8 Sep 2020 22:16:37 +0000 (17:16 -0500)]
Update common/models/drools to 1.7.1/2.3.1/1.7.1
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia78684b0f56007941ad6038d78b97bc70f9aa1bb
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Ram Krishna Verma [Thu, 3 Sep 2020 17:31:01 +0000 (17:31 +0000)]
Merge "update the toscapolicy in ruletest set"
Jim Hahn [Thu, 3 Sep 2020 12:48:58 +0000 (12:48 +0000)]
Merge "Add guard filter properties to controller"
Pamela Dragosh [Thu, 3 Sep 2020 12:45:29 +0000 (12:45 +0000)]
Merge "add feature-controlloop-tdjam to drools-apps docker"
Pamela Dragosh [Wed, 26 Aug 2020 17:50:57 +0000 (13:50 -0400)]
Add guard filter properties to controller
Adding new properties to guard Decision call.
Issue-ID: POLICY-2590
Change-Id: Ie4a37990e062c76ac4d6dd1b904ad354736fd27a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Signed-off-by: Jim Hahn <jrh3@att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Taka Cho [Wed, 2 Sep 2020 18:32:06 +0000 (14:32 -0400)]
update the toscapolicy in ruletest set
modelVersion has to be a string
instead an integer
Issue-ID: POLICY-2814
Change-Id: I31c89d69f96076d490c665f4912d25e3892d011a
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Tue, 1 Sep 2020 17:13:02 +0000 (13:13 -0400)]
add feature-controlloop-tdjam to drools-apps docker
the feature-controlloop-tdjam will be installed in
docker, but disable by default
Issue-ID: POLICY-2415
Change-Id: I563a16bc698ce13eb1df0d8aa1cb7b7e7b8290b3
Signed-off-by: Taka Cho <takamune.cho@att.com>
Ram Krishna Verma [Wed, 2 Sep 2020 14:15:47 +0000 (14:15 +0000)]
Merge "Allow guards to be dynamically enabled/disabled"
Jim Hahn [Mon, 31 Aug 2020 21:59:44 +0000 (17:59 -0400)]
Allow guards to be dynamically enabled/disabled
Modified drools-apps so that guards can be dynamically enabled and
disabled. Due to the current design, there are two properties that
control this:
- an actor-level property: when enabled, the DB connection is created,
otherwise a stub connection is created. This property is NOT dynamic
- an engine-level property: when enabled, the connection created by the
actor is used, otherwise a stub connection is used. This property IS
dynamic
Issue-ID: POLICY-2748
Change-Id: I2a5baf908ce274f2eb46a6a3f01df1b3532038ff
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 31 Aug 2020 20:53:44 +0000 (20:53 +0000)]
Merge "Add tdjam-controller"
Straubs, Ralph (rs8887) [Fri, 17 Jul 2020 14:38:02 +0000 (10:38 -0400)]
Add tdjam-controller
the details is on wiki:
https://wiki.onap.org/display/DW/tdjam+Feature+for+Tosca-Driven+Control+Loops
Fixed some eclipse warnings.
Revised the interaction between a manager and its SerialWorkQueue to
address some threading issues. The original code started processing
the event as soon as the manager was created, WHILE it was still being
added to the map. During junit tests, the event responses came back,
within the same thread, which then attempted to remove the manager from
the map. This resulted in a ConcurrentHashMap exception.
Issue-ID: POLICY-2415
Change-Id: I94a4152637be76e5b2aea2d869afd84dfb413a0e
Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Signed-off-by: Taka Cho <takamune.cho@att.com>
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 28 Aug 2020 19:44:11 +0000 (15:44 -0400)]
Tweaks to drools-apps for new usecases controller
Made the following updates:
- modified feature-controlloop-utils to pull from the usecases
controller instead of the frankfurt controller
- modified ONAPInstance in the xacml-pdp Decision request
- log Step2 property changes as info() instead of error()
- log Lock acquisition as info() instead of warn()
Issue-ID: POLICY-2748
Change-Id: I6b4b5877bbd6731acb761d09d0f0dec85561b163
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 28 Aug 2020 18:13:39 +0000 (14:13 -0400)]
Remove legacy policy from rules
Issue-ID: POLICY-2428
Change-Id: I87b66758c8984febcd5fb6e724fac3493f5d4cdf
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Fri, 28 Aug 2020 17:28:37 +0000 (17:28 +0000)]
Merge "Use ToscaPolicy instead of legacy Policy"
Jim Hahn [Wed, 26 Aug 2020 20:57:52 +0000 (16:57 -0400)]
Use ToscaPolicy instead of legacy Policy
Removed usage of policy-yaml and old targetType definition.
Switched to using TOSCA operational policy classes and new
definitions for Target type enum.
Issue-ID: POLICY-2428
Change-Id: I25d1c5219764df27bdae7f2cbeb7ada7bcef4e1e
Signed-off-by: Jim Hahn <jrh3@att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Thu, 30 Jul 2020 22:05:02 +0000 (18:05 -0400)]
Move java code to rules
Added new usecases rules and feature.
Updates per review comments:
- kmodule.xml(s)
Issue-ID: POLICY-2748
Change-Id: I2f5cb05a4269f98a3b0a778730434955f0919b4a
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 30 Jul 2020 22:05:02 +0000 (18:05 -0400)]
Add Usecases-specific event manager
Created new "usecases" event manager.
Also fixed a couple of sonar issues in the new code.
Issue-ID: POLICY-2748
Change-Id: I17a2c41bbf4f4e8158adbd8aa5e32ef570daa9d3
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 30 Jul 2020 22:05:02 +0000 (18:05 -0400)]
Add Step classes for usecases controller
Add usecases-specific classes for managing preprocessor steps.
Issue-ID: POLICY-2748
Change-Id: I62a2bf8fbeb656a5017531a3f3de6a6dbad5a004
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Mon, 24 Aug 2020 15:06:10 +0000 (15:06 +0000)]
Merge "Add "special" Operation classes for new usecases"
jhh [Fri, 21 Aug 2020 18:29:21 +0000 (13:29 -0500)]
remove legacy operational policies support
Issue-ID: POLICY-2765
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I454365943465863b108ba8668b2bc4b201986959
Jim Hahn [Thu, 30 Jul 2020 22:05:02 +0000 (18:05 -0400)]
Add "special" Operation classes for new usecases
Created place-holder for new "usecases" controller. Note: as of yet,
this is still just a normal java project; it will be turned into a
full-fledged kie-based controller in a later review.
Added some Operation and a few other support classes that will be
needed.
Note: the detmTarget() method and it's various supporting methods,
detmXxx(), found in GetTargetEntityOperation2 were cloned from the
pre-existing ControlLoopOperationManager2 class, and modified to fit the
strategy of the new controller. Likewise for the junit tests of those
methods.
Issue-ID: POLICY-2748
Change-Id: Idffa135a11a56bd6afdd2728706fd40168e80912
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 20 Aug 2020 14:11:54 +0000 (10:11 -0400)]
Add generic eventmanager classes
Added classes that are event-agnostic and support moving control from
java into rules.
Updates per review comments:
- removed policy scope
Issue-ID: POLICY-2748-event-mgr
Change-Id: Icf811cc25a3975543fc5c725766b7b9df2bb87b0
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 14 Aug 2020 23:29:51 +0000 (19:29 -0400)]
Remove legacy operational policy from drools-apps
Issue-ID: POLICY-2766
Change-Id: I1ff7bbc4e301cfe6fa746f38c839acf83f7584b6
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Mon, 3 Aug 2020 23:49:45 +0000 (19:49 -0400)]
Refactor BaseRuleTest for Drools apps
1, rename BaseRuleTest to BaseTest.
2, remove drools related code in BaseTest that would use
for tdjam controller.
3, DroolsRuleTest extends BaseTest
that would use for frankfurt controller for drools base.
Issue-ID: POLICY-2750
Change-Id: Ica9637a850de6e929f09532f077ae3e997aa2045
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Thu, 30 Jul 2020 18:18:41 +0000 (14:18 -0400)]
Update INFO.yaml in policy-drools-apps
Verified with Jessica W that the "type" should still be "Addition",
even when updating the PTL.
Updated to Mature, per TSC.
Issue-ID: POLICY-2738
Change-Id: I6385e0474e1b48b3e4f1fa195062ecfc40e03ee7
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Fri, 24 Jul 2020 16:51:43 +0000 (12:51 -0400)]
Add Ajith to policy/drools-apps info
Issue-ID: POLICY-2738
Change-Id: I94d9ff05a6124a36d24190c47c600efc39df58c5
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 21 Jul 2020 20:17:48 +0000 (20:17 +0000)]
Merge "Remove m2 model from drools-apps"
uj426b [Thu, 16 Jul 2020 18:47:45 +0000 (14:47 -0400)]
Support vDNS RainyDay test Case.
Change-Id: I6d2b17c5379b19b04589da4d7bc4a7f6ebc4d23a
Issue-ID: POLICY-2432
Signed-off-by: uj426b <uj426b@att.com>
Jim Hahn [Fri, 17 Jul 2020 19:24:26 +0000 (15:24 -0400)]
Remove m2 model from drools-apps
With the advent of the new Actor model, then m2 model is no longer needed
in drools-apps.
Issue-ID: POLICY-2725
Change-Id: I3aa43619391552c00bd4e138aee96ca5d5bd55a8
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 17 Jul 2020 18:27:19 +0000 (18:27 +0000)]
Merge "remove nexus function from entrypoint"
jhh [Thu, 16 Jul 2020 21:28:54 +0000 (16:28 -0500)]
remove nexus function from entrypoint
Issue-ID: POLICY-2673
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ib1bce9a813435718e83a6671d3790c610c14b709
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Jim Hahn [Thu, 16 Jul 2020 19:17:37 +0000 (15:17 -0400)]
Fix drools-apps CSIT
Saw this in the log:
java.lang.NoClassDefFoundError:
org/onap/policy/models/decisions/concepts/DecisionRequest
Added decisions jar to the (hopefully correct) pom.
Issue-ID: POLICY-2558
Change-Id: I5a2796b3eda6b3b39b2844cd112f5a18acfa0cf8
Signed-off-by: Jim Hahn <jrh3@att.com>
Jorge Hernandez [Wed, 15 Jul 2020 23:55:00 +0000 (23:55 +0000)]
Merge "Update-config simulator prop. with mvn assembly."
uj426b [Mon, 13 Jul 2020 19:30:05 +0000 (15:30 -0400)]
Update-config simulator prop. with mvn assembly.
Change-Id: Ia91fad549dfba0b3caa623be18652b93d0bc7fce
Issue-ID: POLICY-2716
Signed-off-by: uj426b <uj426b@att.com>
Jim Hahn [Wed, 3 Jun 2020 13:26:33 +0000 (09:26 -0400)]
Remove usecases and legacy actor code
Made the following changes to remove usescase and legacy actor
code:
- deleted the usecases controller and feature
- deleted code associated with legacy actors, with the exception
of AaiManager, which is needed by RestControlLoopManager
- moved the contents of the "guard" project into the m2/guard project,
as that is the only thing that still needs it
- modified the m2/GuardContext to get the name of its persistence unit
from the properties so it could be overridden by junit tests
- used eclipselink constants
Also fixed a bug in the properties for the VFC actor.
Addressed review comment:
- removed usecases from Dockerfile
Issue-ID: POLICY-2558
Change-Id: I677d68c9efed9247c3d55773abdcc736b577a6b4
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 10 Jul 2020 22:36:16 +0000 (18:36 -0400)]
Bump drools-apps to 1.7.1-SNAPSHOT
Issue-ID: POLICY-2695
Change-Id: Iec9af37a01ba35c5b5419399cfb3d3bc80093101
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 10 Jul 2020 22:15:31 +0000 (18:15 -0400)]
Release drools-apps 1.7.0 docker artifacts
Issue-ID: POLICY-2695
Change-Id: I98c17adf83d75c410dd29049b1a863564f2a7c33
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 10 Jul 2020 21:10:31 +0000 (17:10 -0400)]
Release drools-apps 1.7.0 maven artifacts
Issue-ID: POLICY-2695
Change-Id: If71c57ab3931aac65ccd6e0e1fb8ef3d8d837e01
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 9 Jul 2020 13:41:47 +0000 (09:41 -0400)]
Refer to released versions drools-apps
Issue-ID: POLICY-2695
Change-Id: I2127501c4ac5472409570a7182209eded5b0f644
Signed-off-by: Jim Hahn <jrh3@att.com>
uj426b [Thu, 9 Jul 2020 21:34:04 +0000 (17:34 -0400)]
FIX context URI and https to false.
Change-Id: Iffecc4655d22b507188ea266e82046f2a82751e8
Issue-ID: POLICY-2703
Signed-off-by: uj426b <uj426b@att.com>
jhh [Wed, 8 Jul 2020 18:48:07 +0000 (13:48 -0500)]
modify jmx script to accommodate json changes
Issue-ID: POLICY-2705
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iea6ea806855f5887e9a6206aa966746d822c3679
Taka Cho [Mon, 6 Jul 2020 16:02:45 +0000 (12:02 -0400)]
fix complete the assertion
add isInstanceOf for assertThatThrownBy.
Issue-ID: POLICY-2616
Change-Id: If49255aec6004870d7d2acfeabe258def872c1fa
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Wed, 1 Jul 2020 20:13:46 +0000 (16:13 -0400)]
Use new Actor names in drools-apps
Modified drools-apps to use XxxActor instead of XxxActorServiceProvider.
This is the second step of the rename.
Issue-ID: POLICY-2684
Change-Id: Iea60e92f914b7719ac765b086650479be9192d98
Signed-off-by: Jim Hahn <jrh3@att.com>
Jorge Hernandez [Thu, 2 Jul 2020 12:43:43 +0000 (12:43 +0000)]
Merge "Updating drools applications dependencies"
RossC [Tue, 30 Jun 2020 14:24:08 +0000 (15:24 +0100)]
Updating drools applications dependencies
Issue-ID: POLICY-2387
Change-Id: I1c3ee615f0a72a9e7cec8ccc573e27a0cbe3f02c
Signed-off-by: RossC <ross.carter@est.tech>
Taka Cho [Mon, 29 Jun 2020 21:12:35 +0000 (17:12 -0400)]
sonar issue - drools apps
- elevate the visibility of readResolve
- test case without assertions
Issue-ID: POLICY-2616
Change-Id: Ifde4b8c5e1281f8625a1203858fbe0467defe353
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Mon, 29 Jun 2020 21:43:07 +0000 (17:43 -0400)]
Fix build breakage in drools-apps due to pair
The Pair changes made in drools-pdp also broke drools-apps builds.
Replaced usage of drools.utils.Pair with apache Pair.
Issue-ID: POLICY-2202
Change-Id: I50aaad47c243637688602ae6cb680a929fe3edd9
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Fri, 26 Jun 2020 15:47:18 +0000 (11:47 -0400)]
controlloop m2 sonar fix
- remove some unused statement
- remove unnecessary check
Issue-ID: POLICY-2616
Change-Id: Ieb2c898a3c6ad7210642aef990b43c9a01fc15b3
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Fri, 26 Jun 2020 22:56:35 +0000 (18:56 -0400)]
Fix build error from Pair changes
This is a quick fix to get around a build error in drools-applications
due to "Pair" changes made in policy-common and/or policy-models.
Issue-ID: POLICY-2202
Change-Id: If1cb60947e55d97ef7cfb1d05d69e07c54c71a05
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Fri, 26 Jun 2020 15:35:12 +0000 (11:35 -0400)]
m2 sonar fix
- "get" returns a string already
- to avoid sonar issue for duplicated strings
- formating
Issue-ID: POLICY-2616
Change-Id: I1fac65bba5ecb402c784dd585ebcd7992cf31545
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Thu, 25 Jun 2020 15:12:36 +0000 (11:12 -0400)]
Use parent snapshot in drools-apps
Fixed checkstyle issues that were subsequently reported.
Also fixed a few eclipse warnings.
Also fixed some of the sonar issues in the files that were touched:
- use "{}" in logger calls
- camelcase method names
- use "<?>" instead of generics
- add serialization ID
Issue-ID: POLICY-2188
Change-Id: I5c94a2e26dd74a61a0a919e1c3da17ab02a5bc9d
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 19 Jun 2020 20:44:04 +0000 (16:44 -0400)]
Changes for checkstyle 8.32
Issue-ID: POLICY-2188
Change-Id: Ib90222c537c5440e0de52fa0acbaa99bbcc4772a
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Tue, 16 Jun 2020 13:42:10 +0000 (09:42 -0400)]
fix sonar for m2/base - 2
- unused import
- Hide Utility Class Constructor : Utility classes
should not have a public or default constructor
Issue-ID: POLICY-2616
Change-Id: I338a739b6e9fb5f4b47898566362b8a87201dae3
Signed-off-by: Taka Cho <takamune.cho@att.com>
Ram Krishna Verma [Wed, 17 Jun 2020 21:24:50 +0000 (21:24 +0000)]
Merge "m2 sonar issues"
Taka Cho [Wed, 17 Jun 2020 14:45:59 +0000 (10:45 -0400)]
m2 sonar issues
- unused import
- logger format
- Extract the assignment out of this expression
- Replace this if-then-else statement
by a single return statement
Issue-ID: POLICY-2616
Change-Id: I2d04569a7070f79fc8979274bce2b87b4b2f3e24
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jorge Hernandez [Wed, 17 Jun 2020 15:30:01 +0000 (15:30 +0000)]
Merge "fix sonar issue for m2/base"
Taka Cho [Tue, 16 Jun 2020 18:08:33 +0000 (14:08 -0400)]
m2/appclcm sonar issue fix
swap the arguments
use assertNull
Issue-ID: POLICY-2616
Change-Id: Id5bd0b7acd0914566dfdebdb42fdcaabf9eb3012
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Mon, 15 Jun 2020 20:55:00 +0000 (16:55 -0400)]
fix sonar issue for m2/base
-using {} in logger in stead
-diamond operator (<>) to reduce
the verbosity of generics code.
-rename this method name to match
the regular expression '^[a-z][a-zA-Z0-9]*$'
Issue-ID: POLICY-2616
Change-Id: I8e722af52b08382ca53190a33a3a27ad1e7d4830
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jorge Hernandez [Tue, 16 Jun 2020 15:42:56 +0000 (15:42 +0000)]
Merge "change audit and metric formats in feature-controlloop-trans"
Joseph Chou [Tue, 9 Jun 2020 18:14:56 +0000 (14:14 -0400)]
change audit and metric formats in feature-controlloop-trans
logging enhancement
Issue-ID: POLICY-2579
Change-Id: Id1e0230d3cd2ac6d921be86f127f3721c65f3e52
Signed-off-by: Joseph Chou <jc2555@att.com>
Jim Hahn [Mon, 15 Jun 2020 15:23:48 +0000 (11:23 -0400)]
Remove deprecated actor properties
Now that the actor change has been merged, the deprecated properties
can be removed from drools-apps. Done.
Issue-ID: POLICY-2632
Change-Id: If4dafc489c32da4dfccd6ebac97e8e7beac2454d
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Mon, 15 Jun 2020 13:44:28 +0000 (13:44 +0000)]
Merge "Adjust properties in anticipation of actor changes"
Jim Hahn [Fri, 12 Jun 2020 22:05:31 +0000 (18:05 -0400)]
Adjust properties in anticipation of actor changes
Issue-ID: POLICY-2632
Change-Id: I4d20fe6b46432298ba796fe978796d5d74e1eb14
Signed-off-by: Jim Hahn <jrh3@att.com>
uj426b [Fri, 12 Jun 2020 19:52:05 +0000 (15:52 -0400)]
Clean up to remove controlloop.simulator.env
Change-Id: Ic336eb24f1f3ecda359f07714e59f075596cc105
Issue-ID: POLICY-2555
Signed-off-by: uj426b <uj426b@att.com>
Liam Fallon [Fri, 12 Jun 2020 14:14:09 +0000 (14:14 +0000)]
Merge "Remove deprecated properties for CDS and VFC"
Pamela Dragosh [Fri, 12 Jun 2020 13:49:26 +0000 (13:49 +0000)]
Merge "sonar issue drools applications - 3"
Jim Hahn [Thu, 11 Jun 2020 19:33:32 +0000 (15:33 -0400)]
Remove deprecated properties for CDS and VFC
Now that the changes to the Actors have been merged, the former properties
can be removed, too.
Also fixed guard operator/operation name since it changed from "Guard"
to "Decision".
Issue-ID: POLICY-2629
Change-Id: I1c8d4575be598a8cab12b1aa4ad9b1d3e1f12113
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Thu, 11 Jun 2020 16:04:57 +0000 (16:04 +0000)]
Merge "Match property changes to CDS and VFC actors"
Ram Krishna Verma [Wed, 10 Jun 2020 22:16:59 +0000 (22:16 +0000)]
Merge "sonar issue drools-application - 2"
Ram Krishna Verma [Wed, 10 Jun 2020 22:16:48 +0000 (22:16 +0000)]
Merge "reduce sonar issue - drool-applications"
Jim Hahn [Wed, 10 Jun 2020 21:49:23 +0000 (17:49 -0400)]
Match property changes to CDS and VFC actors
An "operations" level is being added to the properties for the
CDS and VFC actor. Added the new properties; the old ones can
be deleted once the change to the actors has been merged.
Issue-ID: POLICY-2629
Change-Id: Ib0bb3f62d6a2d3380aa6ec5a6e8b61ddd0a44c00
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Wed, 10 Jun 2020 14:48:42 +0000 (10:48 -0400)]
sonar issue drools applications - 3
get already returns string
redudant return block
unused import
swap expected argument
use equals method instead
useless assignment for payload
Issue-ID: POLICY-2616
Change-Id: Ie4f07085994420b7ea3f39db89f980f6594f01b7
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Tue, 9 Jun 2020 18:51:11 +0000 (14:51 -0400)]
sonar issue drools-application - 2
fixed some sonar issues: removed empty method,
put expected value in the 1st argument
Change-Id: I86747938187abda34e9ab41b735d55fbf920ecd8
Issue-ID: POLICY-2616
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jorge Hernandez [Tue, 9 Jun 2020 18:20:45 +0000 (18:20 +0000)]
Merge "Fix VFC actor properties"
Ram Krishna Verma [Tue, 9 Jun 2020 17:25:51 +0000 (17:25 +0000)]
Merge "Changes for feature-controlloop-util actor conf."
Taka Cho [Tue, 9 Jun 2020 16:04:20 +0000 (12:04 -0400)]
reduce sonar issue - drool-applications
In some conditions for assertTrue, sonarcloud
recommends using assertEquals
Assert.assertTrue(a.equals(b));
Assert.assertTrue(a == b);
Assert.assertTrue(a == null);
Assert.assertTrue(a != null);
Assert.assertFalse(a.equals(b));
Compliant Solution
Assert.assertEquals(a, b);
Assert.assertSame(a, b);
Assert.assertNull(a);
Assert.assertNotNull(a);
Assert.assertNotEquals(a, b);
Change-Id: Ic50bf6e961b74abcc698c2cc0347dd0472fefe71
Issue-ID: POLICY-2616
Signed-off-by: Taka Cho <takamune.cho@att.com>
uj426b [Wed, 3 Jun 2020 19:17:07 +0000 (15:17 -0400)]
Changes for feature-controlloop-util actor conf.
Change-Id: I5b48d716dcb17082ad376de1e1fe58b2f4ea4130
Issue-ID: POLICY-2555
Signed-off-by: uj426b <uj426b@att.com>
Jim Hahn [Thu, 4 Jun 2020 21:08:27 +0000 (17:08 -0400)]
Fix VFC actor properties
The VFC actor doesn't have the same property structure as the
other actors, which meant that the properties listed in the file
were incorrect. Fixed them.
Renamed the operation to "Restart" per review comments.
Issue-ID: POLICY-2407
Change-Id: Icb8ccad518d01a5f23253a9835976eae666566f4
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Tue, 2 Jun 2020 17:29:10 +0000 (17:29 +0000)]
Merge "Use OperationsHistory from models"
Jim Hahn [Mon, 1 Jun 2020 16:32:10 +0000 (12:32 -0400)]
Use actor constants instead of literals
Modified drools-apps to use constants from the actor classes instead
of hard-coded literals. Only made this change in code that uses the
new actor model, as the old code will be deleted during this release.
Issue-ID: POLICY-1242
Change-Id: Iac718159fd7cf571a48ac620585bf2b8f94c1e5d
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 29 May 2020 15:59:53 +0000 (11:59 -0400)]
Use OperationsHistory from models
Deleted Dbao and replaced it with the shared class in policy-models.
Also had to update the queries and the persistence.xml accordingly.
Note: with this change, the "database" project is no longer needed,
so it was deleted.
Issue-ID: POLICY-2581
Change-Id: Idfde68b28b3a27f2ee794fa477d15e0f12717373
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 29 May 2020 19:20:25 +0000 (15:20 -0400)]
Use default serialization provider
The default provider has been changed to gson, so the provider property
no longer has to be set.
Issue-ID: POLICY-1527
Change-Id: I9b555ed3c3b735ca9622314e1ca06476416bae6e
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 27 May 2020 21:57:51 +0000 (17:57 -0400)]
Generate SDNR notification in drools-apps
Modified drools-apps to generate the SDNR notification using the
SDNR-response provided by the actor in the operation outcome, instead of
using the controlloop-response provided in the operation outcome, as the
latter is deprecated.
Issue-ID: POLICY-2593
Change-Id: I70ee4a4b11345a4295d720250a63f407f51cb0bd
Signed-off-by: Jim Hahn <jrh3@att.com>
Liam Fallon [Thu, 28 May 2020 09:15:38 +0000 (09:15 +0000)]
Merge "Do additional processing when control loop times out"
Jim Hahn [Fri, 22 May 2020 21:28:22 +0000 (17:28 -0400)]
Do additional processing when control loop times out
When the overall control loop times out, a notification is sent to
POLICY-CL-MGT, but then the event is discarded. Modified the code
to update the operation history, if an operation had been started,
and to generate an SDNR notification, if appropriate.
Applied the same logic for when a lock is lost.
Issue-ID: POLICY-2582
Change-Id: I35510ec8a3cfc6b2ca9be5751896f3c0f7d9bd09
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 27 May 2020 21:23:10 +0000 (17:23 -0400)]
Use snapshot versions
Issue-ID: POLICY-1526
Change-Id: I999d0aff7c76ad01e4cec65cb44a165a42259ca0
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Tue, 26 May 2020 15:48:51 +0000 (15:48 +0000)]
Merge "Generate SDNR notification even on timeout"
a.sreekumar [Tue, 26 May 2020 13:18:14 +0000 (14:18 +0100)]
Bump Drools-Apps to 1.7.0
Change-Id: I1b4b088d276da6aae3b577102470a6d8e3dcdc6a
Issue-ID: POLICY-2514
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Tue, 26 May 2020 12:37:53 +0000 (13:37 +0100)]
Bump drools-applications to 1.6.5
Change-Id: I52c0b421e6ca94153b7f37ae67fdcd086f14f3fa
Issue-ID: POLICY-2514
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Jim Hahn [Fri, 22 May 2020 20:05:16 +0000 (16:05 -0400)]
Generate SDNR notification even on timeout
If a request to SDNR times out, the actor class does not generate a
notification for the DCAE_CL_RSP topic. Rather than modifying the
actor, decided to modify models to handle that case. Seems like that's
where it belongs anyway, as notifications are more of an application-
level behavior.
Issue-ID: POLICY-2580
Change-Id: Id9426c223b719efce337a604316f19335dae8a94
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 22 May 2020 13:06:58 +0000 (09:06 -0400)]
Use "outcome" to indicate pending record
Mariadb is setting the "endtime" to the current time by default,
so rather than indicate a pending record using a null endtime, just
modified the code set "outcome" to "Started" to indicate a pending record.
Also added code to ensure the "outcome" is never null, as that causes
a DB error.
Also addressed a comment from a previous review to log a warning message
if more than one matching record is found in operations history.
Issue-ID: POLICY-2581
Change-Id: I6bf67551cef46808a79cc15afeb0abbfc1b6d945
Signed-off-by: Jim Hahn <jrh3@att.com>
Jorge Hernandez [Thu, 21 May 2020 23:27:24 +0000 (23:27 +0000)]
Merge "Insert pending record when operation starts"
Jim Hahn [Thu, 21 May 2020 21:47:18 +0000 (17:47 -0400)]
Add secondary indices to operationshistory table
Queries to the operationshistory table will degrade substantially
as more records are added to the DB.
The Dbao class should be moved to policy-models, but for now
we'll just update it in both places (i.e., drools-apps and xacml-pdp).
Issue-ID: POLICY-2581
Change-Id: Ic43cefdfd4d353b73d815bd629ef25f3d2b486c6
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 21 May 2020 21:04:17 +0000 (17:04 -0400)]
Insert pending record when operation starts
Modified code to insert a pending record when an operation starts.
Also modified it to update the existing record when the operation
completes, rather than adding a new record.
Note: the "outcome" for a "pending" record is left unset (i.e., it
is null).
Issue-ID: POLICY-2581
Change-Id: Ia1a02ed5a16b8af1328a49b22478fd57c4b9aca0
Signed-off-by: Jim Hahn <jrh3@att.com>
jhh [Wed, 20 May 2020 22:17:28 +0000 (17:17 -0500)]
release 1.6.4 docker container
Issue-ID: POLICY-2514
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I76daf2eb6ce0526f8295b182b69b59dd23d3b17d
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
jhh [Wed, 20 May 2020 20:51:08 +0000 (15:51 -0500)]
release maven artifacts
Issue-ID: POLICY-2514
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I8d16b1c761e60da4906f5fe9a76fc69a65aa0054
Pamela Dragosh [Wed, 20 May 2020 19:15:43 +0000 (15:15 -0400)]
Point to released drools-pdp
Issue-ID: POLICY-2514
Change-Id: I3d40c6016b9ce4adc95ed7a4e59719e94f9f5b26
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>