Jim Hahn [Fri, 20 Nov 2020 21:38:16 +0000 (16:38 -0500)]
Use new version of A&AI APIs
Just changed the version numbers; the APIs appear to be the same
otherwise.
Issue-ID: POLICY-2788
Change-Id: I842d88184a816c7fd24d935488875ba1337a1754
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 12 Feb 2021 13:30:59 +0000 (08:30 -0500)]
Fix sonars from dependency upgrade
The dependency upgrades in policy-parent caused some new sonars. In
particular, initMocks() has been deprecated - replaced with calls to the
Mockito Runner.
Issue-ID: POLICY-2910
Change-Id: I257b74626f4393aa89d2bf1b7502478422213b71
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 10 Feb 2021 22:07:25 +0000 (17:07 -0500)]
More sonars in drools-apps
Addressed the following issues:
- commented-out code
- don't use eq() with verify()
- use class::cast lambda
Issue-ID: POLICY-2910
Change-Id: I12f4f85fb226f3ddb8305105e988fa90e276e9f6
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Tue, 9 Feb 2021 21:53:59 +0000 (21:53 +0000)]
Merge "Delete unused persistence.xml"
Jim Hahn [Tue, 9 Feb 2021 21:01:35 +0000 (16:01 -0500)]
Delete unused persistence.xml
Deleted the file, as it is no longer needed.
Issue-ID: POLICY-3005
Change-Id: Ia8de5838440c38dc31177e316118db75965d9338
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 9 Feb 2021 18:01:55 +0000 (13:01 -0500)]
Upgrade dependencies
Added target-database property.
Also moved the db-driver value out of persistence.xml and into
properties.
Issue-ID: POLICY-3005
Change-Id: I2c9e53c099e400c32d11632f8732e770a7abba9f
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 5 Feb 2021 20:16:38 +0000 (15:16 -0500)]
Give better messages than NPE for missing data
When data is not available to actor operations, an NPE is generally
thrown. Modified the code to provide more info about what is missing
than simply NPE.
Issue-ID: POLICY-2913
Change-Id: Ic56376ef5fdd0f2e46c2996405fff9aafa3692b9
Signed-off-by: Jim Hahn <jrh3@att.com>
liamfallon [Mon, 4 Jan 2021 13:55:12 +0000 (13:55 +0000)]
Changed identifiers to concept identifiers
The policy models tosca classes ToscaPolicyIdentifier and
ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA
concept, not just TOSCA policies so they are renamed to
ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion
respectively.
The class ToscaPolicyTypeIdentifier is redundant and is replaced by
ToscaConceptIdentifier.
Issue-ID: POLICY-2900
Change-Id: Id5da4e5894a0d646f9f4b68c1e6b0476d4deae05
Signed-off-by: liamfallon <liam.fallon@est.tech>
Ram Krishna Verma [Mon, 23 Nov 2020 15:25:48 +0000 (15:25 +0000)]
Merge "Use Params makeOutcome() without targetEntity"
Jim Hahn [Fri, 20 Nov 2020 20:47:59 +0000 (15:47 -0500)]
Remove legacy simulators
Drools-apps now uses simulators from policy/models. Deleted the legacy
simulators.
Issue-ID: POLICY-2804
Change-Id: Ie118237a52a4272d2f86fbb15b320ea2175ac7f4
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 20 Nov 2020 16:47:02 +0000 (11:47 -0500)]
Use Params makeOutcome() without targetEntity
Planning to remove the second flavor of makeOutcome() from the Params,
so modifying the drools-apps code to work with the first flavor.
Issue-ID: POLICY-2804
Change-Id: Iddb288f7cf53e93919e77aca8afe3869fadb0d37
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Fri, 20 Nov 2020 13:28:27 +0000 (13:28 +0000)]
Merge "Delete preprocessed flag from actors"
Jim Hahn [Wed, 18 Nov 2020 17:04:26 +0000 (12:04 -0500)]
Delete preprocessed flag from actors
Removed the "preprocessed" flag from the Actor parameters, now
that the actors no longer have a startPreprocess() method.
Also removed targetEntity from the parameters.
Issue-ID: POLICY-2804
Change-Id: I13bc80e1b6bb22d8d21b176796ca062109ce6658
Signed-off-by: Jim Hahn <jrh3@att.com>
Jorge Hernandez [Wed, 18 Nov 2020 18:08:45 +0000 (18:08 +0000)]
Merge "move all bash to ash shell scripts for drools-apps"
Taka Cho [Mon, 16 Nov 2020 15:48:39 +0000 (10:48 -0500)]
move all bash to ash shell scripts for drools-apps
this gerrit would be the first step
to not to use any GPL-3.0 and plus license
Issue-ID: POLICY-2847
Change-Id: I6787af6afd4a90d09d3cca86fa2ee7c5b6ea4eb0
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Mon, 26 Oct 2020 20:48:47 +0000 (16:48 -0400)]
Make drools-apps event agnostic
Removed tdjam and frankfurt controllers, which use event-specific
actors.
Issue-ID: POLICY-2804
Change-Id: Ica05f80bf72d039d9c4903591af7fb3793a81159
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 10 Nov 2020 16:39:51 +0000 (11:39 -0500)]
Allow mixed case in check of prov-status
Apparently SO/AAI in Frankfurt are setting the prov-status to "active"
instead of "ACTIVE". Modified the code to ignore case when comparing.
Issue-ID: POLICY-2890-prov-status2
Change-Id: I9e868d320dadcb3ac51570718d10f33d0011ae47
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Fri, 6 Nov 2020 15:38:21 +0000 (10:38 -0500)]
Fix upcoming checkstyle issues
When we upgrade to oparent, these will fail as oparent upgrades
to 8.37 of puppycrawl which fixes a few bugs that should have
flagged these previously.
Issue-ID: POLICY-2887
Change-Id: I2ea37eef859aac08f54ffd1f4b1d6b9e702218e9
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Taka Cho [Thu, 29 Oct 2020 16:53:26 +0000 (12:53 -0400)]
correct filename and restructure directories for s3p
move s3p jmx and shell script under resources
remove old jmx files from the previous release
Issue-ID: POLICY-2832
Change-Id: I2c1d4f2137655bc096b402b12625fa4add15ecf5
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Wed, 28 Oct 2020 21:02:07 +0000 (21:02 +0000)]
Merge "add jmx and shell script for s3p drools-app"
Jim Hahn [Mon, 26 Oct 2020 20:19:28 +0000 (16:19 -0400)]
Bump drools-apps master to 1.8.0 SNAPSHOT
Bumping minor version now that guilin branch has been created.
Also repointed to snapshot versions for dependencies.
Issue-ID: POLICY-2875
Change-Id: Ieb3f8d6ff141d3035141ab8672d3259074f432be
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Mon, 26 Oct 2020 14:11:52 +0000 (10:11 -0400)]
add jmx and shell script for s3p drools-app
modified s3p.jmx from Frankfurt to fit for
Guilin. and modified shell script from Amsterdam
Issue-ID: POLICY-2832
Change-Id: Id9ab2535e6ea8bce0f5f367fbf296fc215d65c9f
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Tue, 20 Oct 2020 18:01:09 +0000 (14:01 -0400)]
Bump drools-apps to 1.7.5 SNAPSHOT
Issue-ID: POLICY-2869
Change-Id: I627c5b1c4c5f946c1187a6966b30d3943825fa71
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 20 Oct 2020 17:41:18 +0000 (13:41 -0400)]
Release drools-apps 1.7.4 docker
Issue-ID: POLICY-2869
Change-Id: I84c5128e0b82c72cd81540174442ceb19407dd3d
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 20 Oct 2020 16:43:04 +0000 (12:43 -0400)]
Release drools-apps 1.7.4 artifacts
Issue-ID: POLICY-2869
Change-Id: Ib0d32f3c87bff3ce402a1435e2a4ef9e0dd01940
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 20 Oct 2020 15:01:57 +0000 (11:01 -0400)]
Use release versions in drools-apps
Issue-ID: POLICY-2869
Change-Id: Ie55fb49b22b7880575395f6fa7676a508f1f2a85
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Tue, 20 Oct 2020 12:11:19 +0000 (08:11 -0400)]
Point drools-apps to models 2.3.5
Issue-ID: POLICY-2869
Change-Id: Ideb10482ffd3e670e6237305ef8ff9d0a0143257
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Taka Cho [Wed, 14 Oct 2020 14:39:09 +0000 (10:39 -0400)]
point to drool-pdp 1.7.4-SNAPSHOT
Issue-ID: POLICY-2864
Change-Id: I45fd53df2d143d1e082db477316b4378d8c5e6a0
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Sat, 10 Oct 2020 21:49:59 +0000 (21:49 +0000)]
Merge "bump drools-apps to 1.7.4-SNAPSHOT"
Taka Cho [Sat, 10 Oct 2020 20:48:19 +0000 (16:48 -0400)]
bump drools-apps to 1.7.4-SNAPSHOT
Issue-ID: POLICY-2839
Change-Id: Ie0bc82d0f8a09dc4d65e056dc7836870dae58835
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Sat, 10 Oct 2020 19:03:34 +0000 (15:03 -0400)]
Release drools-apps 1.7.3 docker image
Issue-ID: POLICY-2863
Change-Id: I5a42abffe141febf35e03c227683515ae4870a5d
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Sat, 10 Oct 2020 17:11:05 +0000 (13:11 -0400)]
Release drools-apps 1.7.3 artifacts
Issue-ID: POLICY-2863
Change-Id: Ifef9714179ae4a19793c6599abe672a5191cc101
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 9 Oct 2020 19:46:32 +0000 (15:46 -0400)]
Use models 2.3.4 and drools-pdp 1.7.3 releases
Issue-ID: POLICY-2863
Change-Id: Iac66e5f4794e9d959490f205b4f00ccfa4c1d332
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 9 Oct 2020 16:47:58 +0000 (12:47 -0400)]
Use models and drools snapshots
Issue-ID: POLICY-2863
Change-Id: I7e436034dfaa1917b1fba050ab832b273730bb41
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Thu, 8 Oct 2020 12:34:34 +0000 (08:34 -0400)]
Bump drools-apps to 1.7.3 snapshot
Issue-ID: POLICY-2839
Change-Id: Iafbc4a301ee8bc2b5fb10f34677f752a87997879
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Thu, 8 Oct 2020 01:34:39 +0000 (21:34 -0400)]
release drools-apps docker 1.7.2
Issue-ID: POLICY-2839
Change-Id: Id515d64554794677ab1c83626fe0f337856498cf
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Wed, 7 Oct 2020 23:32:37 +0000 (19:32 -0400)]
release 1.7.2 drools-apps artifact
Change-Id: Ib135c94c5702dd24908e3251fae035a7894db6de
Issue-ID: POLICY-2839
Change-Id: Ie673f7c20f5a84bc7a1cdf053b51dfa373507ae6
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Wed, 7 Oct 2020 19:30:56 +0000 (15:30 -0400)]
Point to model 2.3.2 and drools-pdp 1.7.2
Issue-ID: POLICY-2839
Change-Id: I2a405e42e81073a3862cf1a3e01a8c0deaccc36e
Signed-off-by: Taka Cho <takamune.cho@att.com>
Pamela Dragosh [Fri, 2 Oct 2020 11:44:17 +0000 (11:44 +0000)]
Merge "Remove cds actor timeout"
Ram Krishna Verma [Wed, 30 Sep 2020 21:35:17 +0000 (17:35 -0400)]
Remove cds actor timeout
During testing we found that cds actor is picking up the timeout from policy configuration.
As discussed, adding a comment for now and we will remove it in next release alog with related code.
Issue-ID: POLICY-2843
Change-Id: I63b589bea344ad7f33e6fc0d34f0ab331411146b
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Thu, 1 Oct 2020 18:00:50 +0000 (18:00 +0000)]
Merge "Fix new sonars in drools-apps"
Jim Hahn [Wed, 30 Sep 2020 16:52:25 +0000 (12:52 -0400)]
Fix new sonars in drools-apps
Addressed the following sonars:
- too many assertions in test method
- rename test class
- use static method to modify static field
- use already defined constant
- code always returns the same value
- use assertNotSame
- use appropriate class name to access static method
- define a constant
- extract nested try block
- don't always return the same value
- use remove() instead of set(null) for thread-local-storage
- add @Override
Issue-ID: POLICY-2852
Change-Id: Icc62acd4ad57afa2d44ed4cdca504a3ac0810228
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Tue, 29 Sep 2020 23:04:46 +0000 (19:04 -0400)]
remove enable frankfurt controller
In G-Rel, we will use usecases controller.
only install frankfurt controller by default
keep disable for frankfurt controller
Issue-ID: POLICY-2849
Change-Id: I3f09a2920b2bf05af0389b56366ce7229d8113c2
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Mon, 14 Sep 2020 13:42:02 +0000 (09:42 -0400)]
Release locks between junit tests
Tdjam junits were randomly failing. Traced it down to the fact that the
locks were being released asynchronously and thus were not always
released when the next test cases requested them.
Also simplified logging for tdjam junit tests.
Fixed the property file so it isn't overwritten by the junit tests.
Changes per review comments:
- changed "Pattern" to "pattern" in logback xml
Issue-ID: POLICY-2789
Change-Id: I325ec69cf7affa531d3c575e3a34bc0b0e1edac7
Signed-off-by: Jim Hahn <jrh3@att.com>
jhh [Wed, 9 Sep 2020 22:15:50 +0000 (17:15 -0500)]
bump snapshot version to 1.7.2-SNAPSHOT
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I4335cf77bd4a228fe0bec2d5eb529789e8144406
jhh [Wed, 9 Sep 2020 21:32:31 +0000 (16:32 -0500)]
docker release 1.7.1
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Id0fc75b4c27ec1fdd4e33eb60c784e3c63e37952
jhh [Wed, 9 Sep 2020 19:41:34 +0000 (14:41 -0500)]
maven release 1.7.1
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iad1b751d39518eb7d38b25b37d02b57f665d24e7
jhh [Wed, 9 Sep 2020 18:26:21 +0000 (13:26 -0500)]
disable TdjamTest junits
junits consistently fail in staging jobs
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I968bd9ec2c3e8278358ef3c487592c0b833cef36
jhh [Wed, 9 Sep 2020 15:47:28 +0000 (10:47 -0500)]
delete guard dependency for tdjam
staging job fails as there is no guard dependency.
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I4d803e269c7199ddeb2ebb52df5368259e4f22cd
jhh [Tue, 8 Sep 2020 22:16:37 +0000 (17:16 -0500)]
Update common/models/drools to 1.7.1/2.3.1/1.7.1
Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia78684b0f56007941ad6038d78b97bc70f9aa1bb
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Ram Krishna Verma [Thu, 3 Sep 2020 17:31:01 +0000 (17:31 +0000)]
Merge "update the toscapolicy in ruletest set"
Jim Hahn [Thu, 3 Sep 2020 12:48:58 +0000 (12:48 +0000)]
Merge "Add guard filter properties to controller"
Pamela Dragosh [Thu, 3 Sep 2020 12:45:29 +0000 (12:45 +0000)]
Merge "add feature-controlloop-tdjam to drools-apps docker"
Pamela Dragosh [Wed, 26 Aug 2020 17:50:57 +0000 (13:50 -0400)]
Add guard filter properties to controller
Adding new properties to guard Decision call.
Issue-ID: POLICY-2590
Change-Id: Ie4a37990e062c76ac4d6dd1b904ad354736fd27a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Signed-off-by: Jim Hahn <jrh3@att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Taka Cho [Wed, 2 Sep 2020 18:32:06 +0000 (14:32 -0400)]
update the toscapolicy in ruletest set
modelVersion has to be a string
instead an integer
Issue-ID: POLICY-2814
Change-Id: I31c89d69f96076d490c665f4912d25e3892d011a
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Tue, 1 Sep 2020 17:13:02 +0000 (13:13 -0400)]
add feature-controlloop-tdjam to drools-apps docker
the feature-controlloop-tdjam will be installed in
docker, but disable by default
Issue-ID: POLICY-2415
Change-Id: I563a16bc698ce13eb1df0d8aa1cb7b7e7b8290b3
Signed-off-by: Taka Cho <takamune.cho@att.com>
Ram Krishna Verma [Wed, 2 Sep 2020 14:15:47 +0000 (14:15 +0000)]
Merge "Allow guards to be dynamically enabled/disabled"
Jim Hahn [Mon, 31 Aug 2020 21:59:44 +0000 (17:59 -0400)]
Allow guards to be dynamically enabled/disabled
Modified drools-apps so that guards can be dynamically enabled and
disabled. Due to the current design, there are two properties that
control this:
- an actor-level property: when enabled, the DB connection is created,
otherwise a stub connection is created. This property is NOT dynamic
- an engine-level property: when enabled, the connection created by the
actor is used, otherwise a stub connection is used. This property IS
dynamic
Issue-ID: POLICY-2748
Change-Id: I2a5baf908ce274f2eb46a6a3f01df1b3532038ff
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 31 Aug 2020 20:53:44 +0000 (20:53 +0000)]
Merge "Add tdjam-controller"
Straubs, Ralph (rs8887) [Fri, 17 Jul 2020 14:38:02 +0000 (10:38 -0400)]
Add tdjam-controller
the details is on wiki:
https://wiki.onap.org/display/DW/tdjam+Feature+for+Tosca-Driven+Control+Loops
Fixed some eclipse warnings.
Revised the interaction between a manager and its SerialWorkQueue to
address some threading issues. The original code started processing
the event as soon as the manager was created, WHILE it was still being
added to the map. During junit tests, the event responses came back,
within the same thread, which then attempted to remove the manager from
the map. This resulted in a ConcurrentHashMap exception.
Issue-ID: POLICY-2415
Change-Id: I94a4152637be76e5b2aea2d869afd84dfb413a0e
Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Signed-off-by: Taka Cho <takamune.cho@att.com>
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 28 Aug 2020 19:44:11 +0000 (15:44 -0400)]
Tweaks to drools-apps for new usecases controller
Made the following updates:
- modified feature-controlloop-utils to pull from the usecases
controller instead of the frankfurt controller
- modified ONAPInstance in the xacml-pdp Decision request
- log Step2 property changes as info() instead of error()
- log Lock acquisition as info() instead of warn()
Issue-ID: POLICY-2748
Change-Id: I6b4b5877bbd6731acb761d09d0f0dec85561b163
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 28 Aug 2020 18:13:39 +0000 (14:13 -0400)]
Remove legacy policy from rules
Issue-ID: POLICY-2428
Change-Id: I87b66758c8984febcd5fb6e724fac3493f5d4cdf
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Fri, 28 Aug 2020 17:28:37 +0000 (17:28 +0000)]
Merge "Use ToscaPolicy instead of legacy Policy"
Jim Hahn [Wed, 26 Aug 2020 20:57:52 +0000 (16:57 -0400)]
Use ToscaPolicy instead of legacy Policy
Removed usage of policy-yaml and old targetType definition.
Switched to using TOSCA operational policy classes and new
definitions for Target type enum.
Issue-ID: POLICY-2428
Change-Id: I25d1c5219764df27bdae7f2cbeb7ada7bcef4e1e
Signed-off-by: Jim Hahn <jrh3@att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Thu, 30 Jul 2020 22:05:02 +0000 (18:05 -0400)]
Move java code to rules
Added new usecases rules and feature.
Updates per review comments:
- kmodule.xml(s)
Issue-ID: POLICY-2748
Change-Id: I2f5cb05a4269f98a3b0a778730434955f0919b4a
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 30 Jul 2020 22:05:02 +0000 (18:05 -0400)]
Add Usecases-specific event manager
Created new "usecases" event manager.
Also fixed a couple of sonar issues in the new code.
Issue-ID: POLICY-2748
Change-Id: I17a2c41bbf4f4e8158adbd8aa5e32ef570daa9d3
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 30 Jul 2020 22:05:02 +0000 (18:05 -0400)]
Add Step classes for usecases controller
Add usecases-specific classes for managing preprocessor steps.
Issue-ID: POLICY-2748
Change-Id: I62a2bf8fbeb656a5017531a3f3de6a6dbad5a004
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Mon, 24 Aug 2020 15:06:10 +0000 (15:06 +0000)]
Merge "Add "special" Operation classes for new usecases"
jhh [Fri, 21 Aug 2020 18:29:21 +0000 (13:29 -0500)]
remove legacy operational policies support
Issue-ID: POLICY-2765
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I454365943465863b108ba8668b2bc4b201986959
Jim Hahn [Thu, 30 Jul 2020 22:05:02 +0000 (18:05 -0400)]
Add "special" Operation classes for new usecases
Created place-holder for new "usecases" controller. Note: as of yet,
this is still just a normal java project; it will be turned into a
full-fledged kie-based controller in a later review.
Added some Operation and a few other support classes that will be
needed.
Note: the detmTarget() method and it's various supporting methods,
detmXxx(), found in GetTargetEntityOperation2 were cloned from the
pre-existing ControlLoopOperationManager2 class, and modified to fit the
strategy of the new controller. Likewise for the junit tests of those
methods.
Issue-ID: POLICY-2748
Change-Id: Idffa135a11a56bd6afdd2728706fd40168e80912
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 20 Aug 2020 14:11:54 +0000 (10:11 -0400)]
Add generic eventmanager classes
Added classes that are event-agnostic and support moving control from
java into rules.
Updates per review comments:
- removed policy scope
Issue-ID: POLICY-2748-event-mgr
Change-Id: Icf811cc25a3975543fc5c725766b7b9df2bb87b0
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 14 Aug 2020 23:29:51 +0000 (19:29 -0400)]
Remove legacy operational policy from drools-apps
Issue-ID: POLICY-2766
Change-Id: I1ff7bbc4e301cfe6fa746f38c839acf83f7584b6
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Mon, 3 Aug 2020 23:49:45 +0000 (19:49 -0400)]
Refactor BaseRuleTest for Drools apps
1, rename BaseRuleTest to BaseTest.
2, remove drools related code in BaseTest that would use
for tdjam controller.
3, DroolsRuleTest extends BaseTest
that would use for frankfurt controller for drools base.
Issue-ID: POLICY-2750
Change-Id: Ica9637a850de6e929f09532f077ae3e997aa2045
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Thu, 30 Jul 2020 18:18:41 +0000 (14:18 -0400)]
Update INFO.yaml in policy-drools-apps
Verified with Jessica W that the "type" should still be "Addition",
even when updating the PTL.
Updated to Mature, per TSC.
Issue-ID: POLICY-2738
Change-Id: I6385e0474e1b48b3e4f1fa195062ecfc40e03ee7
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Fri, 24 Jul 2020 16:51:43 +0000 (12:51 -0400)]
Add Ajith to policy/drools-apps info
Issue-ID: POLICY-2738
Change-Id: I94d9ff05a6124a36d24190c47c600efc39df58c5
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 21 Jul 2020 20:17:48 +0000 (20:17 +0000)]
Merge "Remove m2 model from drools-apps"
uj426b [Thu, 16 Jul 2020 18:47:45 +0000 (14:47 -0400)]
Support vDNS RainyDay test Case.
Change-Id: I6d2b17c5379b19b04589da4d7bc4a7f6ebc4d23a
Issue-ID: POLICY-2432
Signed-off-by: uj426b <uj426b@att.com>
Jim Hahn [Fri, 17 Jul 2020 19:24:26 +0000 (15:24 -0400)]
Remove m2 model from drools-apps
With the advent of the new Actor model, then m2 model is no longer needed
in drools-apps.
Issue-ID: POLICY-2725
Change-Id: I3aa43619391552c00bd4e138aee96ca5d5bd55a8
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 17 Jul 2020 18:27:19 +0000 (18:27 +0000)]
Merge "remove nexus function from entrypoint"
jhh [Thu, 16 Jul 2020 21:28:54 +0000 (16:28 -0500)]
remove nexus function from entrypoint
Issue-ID: POLICY-2673
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ib1bce9a813435718e83a6671d3790c610c14b709
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Jim Hahn [Thu, 16 Jul 2020 19:17:37 +0000 (15:17 -0400)]
Fix drools-apps CSIT
Saw this in the log:
java.lang.NoClassDefFoundError:
org/onap/policy/models/decisions/concepts/DecisionRequest
Added decisions jar to the (hopefully correct) pom.
Issue-ID: POLICY-2558
Change-Id: I5a2796b3eda6b3b39b2844cd112f5a18acfa0cf8
Signed-off-by: Jim Hahn <jrh3@att.com>
Jorge Hernandez [Wed, 15 Jul 2020 23:55:00 +0000 (23:55 +0000)]
Merge "Update-config simulator prop. with mvn assembly."
uj426b [Mon, 13 Jul 2020 19:30:05 +0000 (15:30 -0400)]
Update-config simulator prop. with mvn assembly.
Change-Id: Ia91fad549dfba0b3caa623be18652b93d0bc7fce
Issue-ID: POLICY-2716
Signed-off-by: uj426b <uj426b@att.com>
Jim Hahn [Wed, 3 Jun 2020 13:26:33 +0000 (09:26 -0400)]
Remove usecases and legacy actor code
Made the following changes to remove usescase and legacy actor
code:
- deleted the usecases controller and feature
- deleted code associated with legacy actors, with the exception
of AaiManager, which is needed by RestControlLoopManager
- moved the contents of the "guard" project into the m2/guard project,
as that is the only thing that still needs it
- modified the m2/GuardContext to get the name of its persistence unit
from the properties so it could be overridden by junit tests
- used eclipselink constants
Also fixed a bug in the properties for the VFC actor.
Addressed review comment:
- removed usecases from Dockerfile
Issue-ID: POLICY-2558
Change-Id: I677d68c9efed9247c3d55773abdcc736b577a6b4
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 10 Jul 2020 22:36:16 +0000 (18:36 -0400)]
Bump drools-apps to 1.7.1-SNAPSHOT
Issue-ID: POLICY-2695
Change-Id: Iec9af37a01ba35c5b5419399cfb3d3bc80093101
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 10 Jul 2020 22:15:31 +0000 (18:15 -0400)]
Release drools-apps 1.7.0 docker artifacts
Issue-ID: POLICY-2695
Change-Id: I98c17adf83d75c410dd29049b1a863564f2a7c33
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 10 Jul 2020 21:10:31 +0000 (17:10 -0400)]
Release drools-apps 1.7.0 maven artifacts
Issue-ID: POLICY-2695
Change-Id: If71c57ab3931aac65ccd6e0e1fb8ef3d8d837e01
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 9 Jul 2020 13:41:47 +0000 (09:41 -0400)]
Refer to released versions drools-apps
Issue-ID: POLICY-2695
Change-Id: I2127501c4ac5472409570a7182209eded5b0f644
Signed-off-by: Jim Hahn <jrh3@att.com>
uj426b [Thu, 9 Jul 2020 21:34:04 +0000 (17:34 -0400)]
FIX context URI and https to false.
Change-Id: Iffecc4655d22b507188ea266e82046f2a82751e8
Issue-ID: POLICY-2703
Signed-off-by: uj426b <uj426b@att.com>
jhh [Wed, 8 Jul 2020 18:48:07 +0000 (13:48 -0500)]
modify jmx script to accommodate json changes
Issue-ID: POLICY-2705
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iea6ea806855f5887e9a6206aa966746d822c3679
Taka Cho [Mon, 6 Jul 2020 16:02:45 +0000 (12:02 -0400)]
fix complete the assertion
add isInstanceOf for assertThatThrownBy.
Issue-ID: POLICY-2616
Change-Id: If49255aec6004870d7d2acfeabe258def872c1fa
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Wed, 1 Jul 2020 20:13:46 +0000 (16:13 -0400)]
Use new Actor names in drools-apps
Modified drools-apps to use XxxActor instead of XxxActorServiceProvider.
This is the second step of the rename.
Issue-ID: POLICY-2684
Change-Id: Iea60e92f914b7719ac765b086650479be9192d98
Signed-off-by: Jim Hahn <jrh3@att.com>
Jorge Hernandez [Thu, 2 Jul 2020 12:43:43 +0000 (12:43 +0000)]
Merge "Updating drools applications dependencies"
RossC [Tue, 30 Jun 2020 14:24:08 +0000 (15:24 +0100)]
Updating drools applications dependencies
Issue-ID: POLICY-2387
Change-Id: I1c3ee615f0a72a9e7cec8ccc573e27a0cbe3f02c
Signed-off-by: RossC <ross.carter@est.tech>
Taka Cho [Mon, 29 Jun 2020 21:12:35 +0000 (17:12 -0400)]
sonar issue - drools apps
- elevate the visibility of readResolve
- test case without assertions
Issue-ID: POLICY-2616
Change-Id: Ifde4b8c5e1281f8625a1203858fbe0467defe353
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Mon, 29 Jun 2020 21:43:07 +0000 (17:43 -0400)]
Fix build breakage in drools-apps due to pair
The Pair changes made in drools-pdp also broke drools-apps builds.
Replaced usage of drools.utils.Pair with apache Pair.
Issue-ID: POLICY-2202
Change-Id: I50aaad47c243637688602ae6cb680a929fe3edd9
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Fri, 26 Jun 2020 15:47:18 +0000 (11:47 -0400)]
controlloop m2 sonar fix
- remove some unused statement
- remove unnecessary check
Issue-ID: POLICY-2616
Change-Id: Ieb2c898a3c6ad7210642aef990b43c9a01fc15b3
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Fri, 26 Jun 2020 22:56:35 +0000 (18:56 -0400)]
Fix build error from Pair changes
This is a quick fix to get around a build error in drools-applications
due to "Pair" changes made in policy-common and/or policy-models.
Issue-ID: POLICY-2202
Change-Id: If1cb60947e55d97ef7cfb1d05d69e07c54c71a05
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Fri, 26 Jun 2020 15:35:12 +0000 (11:35 -0400)]
m2 sonar fix
- "get" returns a string already
- to avoid sonar issue for duplicated strings
- formating
Issue-ID: POLICY-2616
Change-Id: I1fac65bba5ecb402c784dd585ebcd7992cf31545
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Thu, 25 Jun 2020 15:12:36 +0000 (11:12 -0400)]
Use parent snapshot in drools-apps
Fixed checkstyle issues that were subsequently reported.
Also fixed a few eclipse warnings.
Also fixed some of the sonar issues in the files that were touched:
- use "{}" in logger calls
- camelcase method names
- use "<?>" instead of generics
- add serialization ID
Issue-ID: POLICY-2188
Change-Id: I5c94a2e26dd74a61a0a919e1c3da17ab02a5bc9d
Signed-off-by: Jim Hahn <jrh3@att.com>