so.git
4 years agomso should not send content type http header to 98/96198/1
Benjamin, Max (mb388a) [Tue, 24 Sep 2019 21:03:54 +0000 (17:03 -0400)]
mso should not send content type http header to

Updated getHeaders to not add Content-Type header on GET requests
Updated getHttpHeaders boolean to includeContentType

Issue-ID: SO-2366
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Idc7333bfff6b2299c3b192fb1307aae1d0260a5d

4 years agoMerge "Prevent reading twice from ResponseEntity stream, since this caused IOErrors."
Seshu Kumar M [Tue, 24 Sep 2019 14:36:09 +0000 (14:36 +0000)]
Merge "Prevent reading twice from ResponseEntity stream, since this caused IOErrors."

4 years agoMerge "VNFM adapter relationship handling improvements"
Steve Smokowski [Tue, 24 Sep 2019 11:52:32 +0000 (11:52 +0000)]
Merge "VNFM adapter relationship handling improvements"

4 years agoMerge "Fix default homing"
Marcus Williams [Mon, 23 Sep 2019 22:11:27 +0000 (22:11 +0000)]
Merge "Fix default homing"

4 years agoMerge "Exception string in checkRelationshipRelatedTo"
Steve Smokowski [Fri, 20 Sep 2019 15:22:05 +0000 (15:22 +0000)]
Merge "Exception string in checkRelationshipRelatedTo"

4 years agoException string in checkRelationshipRelatedTo 14/95814/2
Bhatt, Prema [Tue, 17 Sep 2019 12:08:12 +0000 (08:08 -0400)]
Exception string in checkRelationshipRelatedTo

Exception string in checkRelationshipRelatedTo not being returned
properly. Added a new exception - UnassignNetworkException.
Added a new unit test to test the exception case as per review comment.
Updated UnassignNetworkBBTest.java file to fix the formatting errors.
Updated unit test , removed setVariable, it wasn't needed to do as it
was performed in the actual method call.
Updated pom.xmp  file to fix the formatting errors.
Updated pom.xml file to fix the formatting errors.

Issue-ID: SO-2346
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I617dfbcb07d6080598a3ef8138aad5c7008dcee2

4 years agoupdate logging to match onap logging library 98/95998/1
Plummer, Brittany [Thu, 19 Sep 2019 14:22:19 +0000 (10:22 -0400)]
update logging to match onap logging library

Updated to use changes added to logging library in ONAP
Updated RestClient to set mdc rather than extend filter
Updated filter removal to include new spring filter
Updated to exclude filter causing failure in catdb
Excluded filter causing failures in requestdb
Updated requestdbatt to exclude filter
Updated check for spring filters to fix failing tests

Issue-ID: SO-2353
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Idb081a0f5527690f9dc41c7914a2d721f9022aea

4 years agoVNFM adapter relationship handling improvements 97/95997/1
MichaelMorris [Thu, 19 Sep 2019 09:21:21 +0000 (10:21 +0100)]
VNFM adapter relationship handling improvements

Change-Id: I8fd7af559448b9cdd6fab4bedd8ec001f196a200
Issue-ID: SO-2352
Signed-off-by: MichaelMorris <michael.morris@est.tech>
4 years agoPrevent reading twice from ResponseEntity stream, since this caused IOErrors. 15/95915/1
grabinsk [Wed, 18 Sep 2019 12:59:44 +0000 (14:59 +0200)]
Prevent reading twice from ResponseEntity stream, since this caused IOErrors.

Also moving empty response checks to parseJsonToGelAllPnfCorrelationId

Issue-ID: SO-2349
Signed-off-by: grabinsk <maciej.grabinski@nokia.com>
Change-Id: I316856d56106a1ae715812628695406f4147765d
Signed-off-by: grabinsk <maciej.grabinski@nokia.com>
4 years agoMerge "Async vnf adapter response not getting to bpmn"
Steve Smokowski [Wed, 18 Sep 2019 12:01:15 +0000 (12:01 +0000)]
Merge "Async vnf adapter response not getting to bpmn"

4 years agoAdd SO Update Check if SDC activities deployment end point server Up for custom worlflows 89/95889/1
Bonkur, Venkat (vb8416) [Wed, 18 Sep 2019 06:22:37 +0000 (02:22 -0400)]
Add SO Update Check if SDC activities deployment end point server Up for custom worlflows

Make changes to verify if SDC activities deployment
end point(mso.asdc.config.activity.endpoint) server up
for custom workflows
Issue-ID: SO-2348
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I3b90b6d8e95681a685b23dfaa2f65596532e5b0e

4 years agoFix default homing 34/95734/4
kurczews [Mon, 16 Sep 2019 10:55:00 +0000 (12:55 +0200)]
Fix default homing

Issue-ID: SO-2307
Change-Id: Iee2562c6f38a440006d3a6108ce6f6fd6dbedcf6
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
4 years agoMerge "Build payload APPC parameter from UserParams"
Steve Smokowski [Tue, 17 Sep 2019 14:09:25 +0000 (14:09 +0000)]
Merge "Build payload APPC parameter from UserParams"

4 years agoMerge "Remove the declaration of thrown exception 'org.onap.so.apihandlerinfra.infra...
Steve Smokowski [Tue, 17 Sep 2019 14:07:28 +0000 (14:07 +0000)]
Merge "Remove the declaration of thrown exception 'org.onap.so.apihandlerinfra.infra.rest.exception.NoRecipeException', as it cannot be thrown from method's body."

4 years agoMerge "getentity csar logging"
Steve Smokowski [Tue, 17 Sep 2019 14:06:16 +0000 (14:06 +0000)]
Merge "getentity csar logging"

4 years agoAsync vnf adapter response not getting to bpmn 18/95818/1
Gamboa, Gilbert [Tue, 17 Sep 2019 13:38:30 +0000 (09:38 -0400)]
Async vnf adapter response not getting to bpmn

Async vnf adapter response is not getting to bpmn @OneWay web
methods in VnfAdapterNotifyServiceImpl class do not work with the
@Async  handleCallback() method in CallbackHandlerService. Updating
code to call the non-async version of the (overloaded) handleCallback
method until we can figure out how to properly do @oneway to @async.
Added junits to all methods in VnfAdapterNotifyServiceimpl

Issue-ID: SO-2347
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I0e8b4a60addfc5e742c77e671377fa152ecce4db

4 years agoUse the configurationId associated to vnfc if 63/95763/1
Bonkur, Venkat [Mon, 16 Sep 2019 18:09:16 +0000 (14:09 -0400)]
Use the configurationId associated to vnfc if

Use the configurationId associated to vnfc if present.
removing the  autowiring of the Configuration bean class

Issue-ID: SO-2343
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I29f8f9e50ed04014f74b7f6dfaa2cdedb2f334d0

4 years agoMerge "- Removed the cloud_technology artifact type."
Steve Smokowski [Sat, 14 Sep 2019 13:32:02 +0000 (13:32 +0000)]
Merge "- Removed the cloud_technology artifact type."

4 years ago- Removed the cloud_technology artifact type. 85/95685/1
Merkel, Jeff [Fri, 13 Sep 2019 21:48:40 +0000 (17:48 -0400)]
- Removed the cloud_technology artifact type.

- Removed the cloud_technology artifact type.

Issue-ID: SO-2333
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I17f0bf10d0bdf16acce9bab0af43f7f46dd7546e

4 years agoRemove unused table requestdb.active_requests. 75/95675/1
Sangalang, Felix [Fri, 13 Sep 2019 20:03:34 +0000 (16:03 -0400)]
Remove unused table requestdb.active_requests.

Remove unused table requestdb.active_requests.
renamed file to nearest flyway versioned number

Issue-ID: SO-2332
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I82d3f7b643e486c9d6cc32cd36d3366aa78e2db5

4 years agoServiceRecipeRepository id wrong type Long (vs 37/95637/1
Sangalang, Felix [Fri, 13 Sep 2019 12:29:06 +0000 (08:29 -0400)]
ServiceRecipeRepository id wrong type Long (vs

ServiceRecipeRepository id wrong type Long (vs Integer).

Issue-ID: SO-2329
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Iecc07ea771f18ce832a09de8b62b31b09754f7a5

4 years agoBuild payload APPC parameter from UserParams 15/95615/1
Elena Kuleshov [Thu, 12 Sep 2019 19:55:39 +0000 (15:55 -0400)]
Build payload APPC parameter from UserParams

If a payload parameter is not specified on VID request for APPC interaction, we will need to build it from UserParams from requestCOntext.

Issue-ID: SO-2311
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Ie6affe2bad031d80c43c0358a49cb252fb04f5e2

4 years agoMerge "bump the SO version to 1.5.2" 1.5.2
subhash kumar singh [Thu, 12 Sep 2019 09:37:30 +0000 (09:37 +0000)]
Merge "bump the SO version to 1.5.2"

4 years agobump the SO version to 1.5.2 52/95552/1
seshukm [Thu, 12 Sep 2019 04:30:01 +0000 (10:00 +0530)]
bump the SO version to 1.5.2

Issue-ID: SO-2310

Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: Id1b0ae814631724ff62ce474f42fbc741b7f3d31

4 years agoMerge "Fix the ingestion of mixed resource"
Seshu Kumar M [Wed, 11 Sep 2019 18:14:23 +0000 (18:14 +0000)]
Merge "Fix the ingestion of mixed resource"

4 years agoMerge "Added null check to avoid crash at getErrorCode() call; fixed typos in error...
Lukasz Muszkieta [Wed, 11 Sep 2019 15:06:28 +0000 (15:06 +0000)]
Merge "Added null check to avoid crash at getErrorCode() call; fixed typos in error messages; removed unnecessary try...catch block"

4 years agoMerge "Fixing null issue and adding zooming"
Byung-Woo Jun [Wed, 11 Sep 2019 14:33:39 +0000 (14:33 +0000)]
Merge "Fixing null issue and adding zooming"

4 years agogetentity csar logging 95/95495/1
Merkel, Jeff [Wed, 11 Sep 2019 13:50:34 +0000 (09:50 -0400)]
getentity csar logging

- Updated to use the getEntity API for csar logging.
- Formatted the logging file to pass the build.

Issue-ID: SO-2306
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I98a7aacc6dc69e8e7f787c39fbc0bd6b7a16338a

4 years agoAdded null check to avoid crash at 65/95465/2
Oleksandr Moliavko [Wed, 11 Sep 2019 07:28:00 +0000 (10:28 +0300)]
Added null check to avoid crash at
getErrorCode() call; fixed typos in error
messages; removed unnecessary try...catch block

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko<o.moliavko@samsung.com>
Change-Id: I95765a1a5a10497e366b5d94b89d45b6bde2b212

4 years agoMerge "error message formatter now handles percent"
Steve Smokowski [Wed, 11 Sep 2019 12:58:16 +0000 (12:58 +0000)]
Merge "error message formatter now handles percent"

4 years agoMerge "Removed redundant null checks (at these points vnfCustom can be empty, but...
Lukasz Muszkieta [Wed, 11 Sep 2019 12:58:01 +0000 (12:58 +0000)]
Merge "Removed redundant null checks (at these points vnfCustom can be empty, but not null)"

4 years agoMerge "Integrate Logging Library"
Steve Smokowski [Wed, 11 Sep 2019 12:57:37 +0000 (12:57 +0000)]
Merge "Integrate Logging Library"

4 years agoFixing null issue and adding zooming 87/95487/1
rokenny [Wed, 11 Sep 2019 12:14:52 +0000 (13:14 +0100)]
Fixing null issue and adding zooming

Change-Id: I6a3ff57b6131c10965400beac43c4c8101b24397
Issue-ID: SO-2274
Signed-off-by: rokenny <ronan.kenny@est.tech>
4 years agoMerge "Set payload to empty when it is not specified"
Seshu Kumar M [Wed, 11 Sep 2019 12:15:07 +0000 (12:15 +0000)]
Merge "Set payload to empty when it is not specified"

4 years agoMerge "fix of the instanceParams adding to the CDS request"
Seshu Kumar M [Wed, 11 Sep 2019 12:10:36 +0000 (12:10 +0000)]
Merge "fix of the instanceParams adding to the CDS request"

4 years agoMerge "bug fix - avoid npe in pnf flow"
Seshu Kumar M [Wed, 11 Sep 2019 11:49:12 +0000 (11:49 +0000)]
Merge "bug fix - avoid npe in pnf flow"

4 years agoRemoved redundant null checks (at these points 82/95482/1
Oleksandr Moliavko [Wed, 11 Sep 2019 11:13:24 +0000 (14:13 +0300)]
Removed redundant null checks (at these points
vnfCustom can be empty, but not null)

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I174635fd0df71811c05ea3ad52f8ec5e5b56c58c

4 years agobug fix - avoid npe in pnf flow 68/95468/2
Lukasz Muszkieta [Wed, 11 Sep 2019 07:37:21 +0000 (09:37 +0200)]
bug fix - avoid npe in pnf flow

Change-Id: I8e848c2bdcec0822ae08280223297b4825e9b7c2
Issue-ID: SO-2289
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
4 years agoFix sonar issues 50/95450/1
Parshad Patel [Wed, 11 Sep 2019 04:47:56 +0000 (13:47 +0900)]
Fix sonar issues

Either log or rethrow this exception
Make "attributeValue" transient or serializable
"attributeName" is already a string, there's no need to call "toString()"

Issue-ID: SO-2226
Change-Id: If6ae623202f2c243d73839d0aaefba5ba5c50dd4
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
4 years agoSet payload to empty when it is not specified 49/95449/1
Elena Kuleshov [Wed, 11 Sep 2019 03:04:51 +0000 (23:04 -0400)]
Set payload to empty when it is not specified

Handle a case of non-existent payload and improve error reporting on APPC request construction

Issue-ID: SO-2300
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I93a1ac8ebfcaa0e39b26130e601d3b657cbed503

4 years agoerror message formatter now handles percent 03/95403/1
Benjamin, Max [Tue, 10 Sep 2019 17:52:53 +0000 (13:52 -0400)]
error message formatter now handles percent

error message formatter now handles percent encoding

Issue-ID: SO-2303
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: If4784ab54023b1df43eb7ee266a2797c9a12731b

4 years agoMerge "Add SO Update to default the controller type query as "APPC" instead of null."
Seshu Kumar M [Tue, 10 Sep 2019 16:54:07 +0000 (16:54 +0000)]
Merge "Add SO Update to default the controller type query as "APPC" instead of null."

4 years agoIntegrate Logging Library 93/95393/1
Plummer, Brittany [Tue, 10 Sep 2019 15:29:42 +0000 (11:29 -0400)]
Integrate Logging Library

Updated SO to use ONAP provided filters and constants to meet logging
standards.
Removed redundant classes
Updated constant references

Issue-ID: SO-2301
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ia4e3c2b1a4dcb3881aa34d39885c8b2782880d64

4 years agoMerge "remove the unused import"
Steve Smokowski [Tue, 10 Sep 2019 11:58:37 +0000 (11:58 +0000)]
Merge "remove the unused import"

4 years agoMerge "Created external task utils in a common location"
Steve Smokowski [Tue, 10 Sep 2019 11:58:11 +0000 (11:58 +0000)]
Merge "Created external task utils in a common location"

4 years agoMerge "Added ACTIVATED Orchestration Status same as"
Steve Smokowski [Tue, 10 Sep 2019 11:57:54 +0000 (11:57 +0000)]
Merge "Added ACTIVATED Orchestration Status same as"

4 years agoMerge "updated all sql files including in tests to use"
Steve Smokowski [Tue, 10 Sep 2019 11:57:37 +0000 (11:57 +0000)]
Merge "updated all sql files including in tests to use"

4 years agoMerge "Upgrade swagger apihandlerinfra"
Steve Smokowski [Tue, 10 Sep 2019 11:57:22 +0000 (11:57 +0000)]
Merge "Upgrade swagger apihandlerinfra"

4 years agoMerge "Distribution fails when no user input required in design"
Seshu Kumar M [Tue, 10 Sep 2019 10:14:25 +0000 (10:14 +0000)]
Merge "Distribution fails when no user input required in design"

4 years agoUpgrade swagger apihandlerinfra 06/95206/4
Arindam Mondal [Mon, 9 Sep 2019 06:19:42 +0000 (15:19 +0900)]
Upgrade swagger apihandlerinfra

Issue-ID: SO-2280
Change-Id: If9fb53295ce483b69ff20610da50227062ed5c48
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
4 years agoMerge "General sonar fixes"
Lukasz Muszkieta [Tue, 10 Sep 2019 07:33:34 +0000 (07:33 +0000)]
Merge "General sonar fixes"

4 years agoGeneral sonar fixes 26/95026/5
Arindam Mondal [Thu, 5 Sep 2019 12:35:06 +0000 (21:35 +0900)]
General sonar fixes

+)Format logger
++) Remove toString()
+++) Extract nested IF

Issue-ID: SO-2226
Change-Id: Iff28408584b04ffd03b6aca0f647d0af9090a9c2
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
4 years agoupdated all sql files including in tests to use 70/95270/1
Chan, Mercy [Mon, 9 Sep 2019 20:41:56 +0000 (16:41 -0400)]
updated all sql files including in tests to use

updated all sql files including in tests to use the correct column
name. Updated hibernate mapping to use the correct column name as well.

Issue-ID: SO-2297
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I4a2d3e82a7b182ea1d67d297c0a0d3a35c856255

4 years agoMerge "Add SO Update Check if SDC activities deployment end point for custom worlflow...
Steve Smokowski [Mon, 9 Sep 2019 18:02:15 +0000 (18:02 +0000)]
Merge "Add SO Update Check if SDC activities deployment end point for custom worlflows is alive"

4 years agoAdd SO Update Check if SDC activities deployment end point for custom worlflows is... 44/95244/1
Bonkur, Venkat (vb8416) [Mon, 9 Sep 2019 15:18:36 +0000 (11:18 -0400)]
Add SO Update Check if SDC activities deployment end point for custom worlflows is alive

Make changes to verify if SDC activities deployment
end point(mso.asdc.config.activity.endpoint)  for custom worlflows is alive
Issue-ID: SO-2294
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: Iff916a33b403d507a383cebf8d668bb5cbf9fb55

4 years agofix of the instanceParams adding to the CDS request 18/95218/1
Lukasz Muszkieta [Mon, 9 Sep 2019 10:20:58 +0000 (12:20 +0200)]
fix of the instanceParams adding to the CDS request

Change-Id: I3bff9b5cac47d5fa29fbe503e2c3752a2b207aab
Issue-ID: SO-2208
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
4 years agoDistribution fails when no user input required in design 14/95214/2
sarada prasad sahoo [Mon, 9 Sep 2019 09:28:34 +0000 (14:58 +0530)]
Distribution fails when no user input required in design

When we distribute a design from SDC and design does
not have any user input in properties, then distribution
fails with error ArrayIndexOutOfBoundException

Issue-ID: SO-2279
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: I47bd724e25d81befc09ec452aa63d8519c927520

4 years agoChange names of two of catalogdb tables to lowercase 01/95201/1
Elena Kuleshov [Mon, 9 Sep 2019 05:49:01 +0000 (01:49 -0400)]
Change names of two of catalogdb tables to lowercase

Table name used in Hibernate for catalogdb tables all need to be in lowercase.

Issue-ID: SO-2292
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Ic2079a9d65c9c6d9d5468b9d62422b328f54d72c

4 years agoAdded ACTIVATED Orchestration Status same as 83/95083/2
Sangalang, Felix [Thu, 5 Sep 2019 19:22:50 +0000 (15:22 -0400)]
Added ACTIVATED Orchestration Status same as

Added ACTIVATED Orchestration Status same as ACTIVE.

Issue-ID: SO-2284
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ia62b7ad228d80f3690c3748587a41ee2dc486087

4 years agoCreated external task utils in a common location 91/95191/1
Boslet, Cory [Sun, 8 Sep 2019 15:31:56 +0000 (11:31 -0400)]
Created external task utils in a common location

Created external task utils in a common location then refactored
external task to use these common utils
Updated junit errors and failures in openstack
Removed env param and updated unit test with class
Remove env file from parm in unit test class
Match argu to match class abstract to con.
removed implementation within anonymous class

Issue-ID: SO-2291
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I47c2850d750cbfe7ef67e2396fcb46db43e3cb97

4 years agoMerge "Set AAIClient on AAIValidatorImpl"
Steve Smokowski [Fri, 6 Sep 2019 19:54:32 +0000 (19:54 +0000)]
Merge "Set AAIClient on AAIValidatorImpl"

4 years agoMerge "- Convert NetworkCollection to use GetEntity API."
Steve Smokowski [Fri, 6 Sep 2019 19:54:27 +0000 (19:54 +0000)]
Merge "- Convert NetworkCollection to use GetEntity API."

4 years agoMerge "Added index infra_active_requests optimal query"
Steve Smokowski [Fri, 6 Sep 2019 19:54:02 +0000 (19:54 +0000)]
Merge "Added index infra_active_requests optimal query"

4 years agoSet AAIClient on AAIValidatorImpl 03/95103/1
Elena Kuleshov [Fri, 6 Sep 2019 03:31:35 +0000 (23:31 -0400)]
Set AAIClient on AAIValidatorImpl

AAIValidatorImpl requires setting an initialized AAIClient before validation calls

Issue-ID: SO-2286
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I254e8e01812e47af2855e1c1afaa5904ed792d22

4 years ago- Convert to use the GetEntity API 71/95071/3
Merkel, Jeff [Thu, 5 Sep 2019 18:08:07 +0000 (14:08 -0400)]
- Convert to use the GetEntity API

- Converted to use the GetEntity API for AllottedResources

Issue-ID: SO-2282
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: If5774c95473563e46f345e5d0c5f6880dd315e35

4 years agoAdded index infra_active_requests optimal query 85/95085/1
Parthasarathy, Ramesh [Thu, 5 Sep 2019 19:41:04 +0000 (15:41 -0400)]
Added index infra_active_requests optimal query

Added index infra_active_requests optimal query

Issue-ID: SO-2285
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ia8af787661701c8ae5593c54581e76ba1696d967

4 years ago- Convert NetworkCollection to use GetEntity API. 72/95072/1
Merkel, Jeff [Thu, 5 Sep 2019 18:16:06 +0000 (14:16 -0400)]
- Convert NetworkCollection to use GetEntity API.

- Convert NetworkCollection to use GetEntity API.
- Updated to correctly format the code..
- Fix setting of parsing of the quantity field.

Issue-ID: SO-2283
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I1948a5bae2f9b1df5367bf3dd5a35357d196bdaf

4 years agoMerge "Log exception"
Lukasz Muszkieta [Thu, 5 Sep 2019 08:17:41 +0000 (08:17 +0000)]
Merge "Log exception"

4 years agoLog exception 09/94909/3
Parshad Patel [Wed, 4 Sep 2019 10:03:56 +0000 (19:03 +0900)]
Log exception

Either log or rethrow this exception
Use isEmpty() to check whether the collection is empty or not

Issue-ID: SO-1841
Change-Id: Ia964a871497df8a7211260ad1ad8f1efa8ae4d42
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
4 years agoMerge "fix public NS distribution issue"
Seshu Kumar M [Thu, 5 Sep 2019 04:11:11 +0000 (04:11 +0000)]
Merge "fix public NS distribution issue"

4 years agoMerge "Fix rollback for ConfigAssignBB"
Max Benjamin [Wed, 4 Sep 2019 15:29:25 +0000 (15:29 +0000)]
Merge "Fix rollback for ConfigAssignBB"

4 years agofix public NS distribution issue 18/94818/2
sarada prasad sahoo [Tue, 3 Sep 2019 09:57:13 +0000 (15:27 +0530)]
fix public NS distribution issue

Fix Multiple VFModule under single service distribution

Issue-ID: SO-2275
Change-Id: I7a4a7dbb68d23c0e44f9985b3fdc89816dbfd232
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
4 years agoMerge "General sonar fix add logger"
Lukasz Muszkieta [Wed, 4 Sep 2019 12:16:53 +0000 (12:16 +0000)]
Merge "General sonar fix add logger"

4 years agoMerge "fix create call to A&AI"
Steve Smokowski [Wed, 4 Sep 2019 12:13:24 +0000 (12:13 +0000)]
Merge "fix create call to A&AI"

4 years agoGeneral sonar fix add logger 36/94736/2
Arindam Mondal [Mon, 2 Sep 2019 07:00:18 +0000 (16:00 +0900)]
General sonar fix add logger

Issue-ID: SO-2226
Change-Id: I5a826a9ea75b3065987a274ab7962c4a5fc1d614
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
4 years agoGeneral Sonar fixes 77/94877/1
Arindam Mondal [Wed, 4 Sep 2019 02:19:18 +0000 (11:19 +0900)]
General Sonar fixes

+) Make field transient or serializable
++) Organize imports

Issue-ID: SO-2273
Change-Id: I04eeb02c4052e3a790db865b59f873694fc1514d
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
4 years agoremove the unused import 46/94746/1
Thugutla sailakshmi [Mon, 2 Sep 2019 11:27:04 +0000 (16:57 +0530)]
remove the unused import

remove the unused import

Issue-ID: SO-2174
Change-Id: Idae5e586e08d6b39dcebfccfd5aca5e1c455eb34
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoRemove the declaration of thrown exception 'org.onap.so.apihandlerinfra.infra.rest... 44/94744/1
Thugutla sailakshmi [Mon, 2 Sep 2019 11:16:42 +0000 (16:46 +0530)]
Remove the declaration of thrown exception 'org.onap.so.apihandlerinfra.infra.rest.exception.NoRecipeException', as it cannot be thrown from method's body.

remove the exception

Issue-ID: SO-2174
Change-Id: Ied64bf5774e3f9ba5d5e640d1f934eb3259e4173
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoFix issues in so-cloudify-client 33/94733/2
Parshad Patel [Mon, 2 Sep 2019 06:02:28 +0000 (15:02 +0900)]
Fix issues in so-cloudify-client

Annotate the "CloudifyClientConnector" interface with the @FunctionalInterface annotation
Make this field final
Either log or rethrow this exception
Make "response" transient or serializable

Issue-ID: SO-1841
Change-Id: I13fa6b911d8789aed26fd27da23318f6dbca3760
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
4 years agofix create call to A&AI 00/94700/1
Gamboa, Gilbert [Fri, 30 Aug 2019 17:02:22 +0000 (13:02 -0400)]
fix create call to A&AI

createIfNotExists should be used rather than create

Issue-ID: SO-2269
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I03af6a83460acbb1d7bde01f108d2a5a03d05adf

4 years agoMerge "sonar fix for ExtractPojosForBB class"
Lukasz Muszkieta [Fri, 30 Aug 2019 13:09:08 +0000 (13:09 +0000)]
Merge "sonar fix for ExtractPojosForBB class"

4 years agoMerge "Added back MDC.put to generated missing requestID"
Steve Smokowski [Fri, 30 Aug 2019 12:22:35 +0000 (12:22 +0000)]
Merge "Added back MDC.put to generated missing requestID"

4 years agoMerge "- Make association from the cvnfc to the fabric"
Steve Smokowski [Fri, 30 Aug 2019 12:21:15 +0000 (12:21 +0000)]
Merge "- Make association from the cvnfc to the fabric"

4 years agoMerge "Update requestStatus to FAILED on activity error."
Steve Smokowski [Fri, 30 Aug 2019 12:21:01 +0000 (12:21 +0000)]
Merge "Update requestStatus to FAILED on activity error."

4 years agoMerge "sonar fix-remove unused import"
Lukasz Muszkieta [Fri, 30 Aug 2019 08:37:57 +0000 (08:37 +0000)]
Merge "sonar fix-remove unused import"

4 years agoUpdate requestStatus to FAILED on activity error. 39/94639/1
Elena Kuleshov [Thu, 29 Aug 2019 20:47:28 +0000 (16:47 -0400)]
Update requestStatus to FAILED on activity error.

Update status and related fields in Requests DB on activity error, add a junit to verify error reporting.

Issue-ID: SO-2263
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I1a2e97afb95e4510b4860486c2b7836b014f990e

4 years agoadded fix for missing Error from SDNC prefix 34/94634/1
Chan, Mercy [Thu, 29 Aug 2019 20:12:22 +0000 (16:12 -0400)]
added fix for missing Error from SDNC prefix

added fix for missing Error from SDNC prefix to SDNC callback flow
reverted implementation from bpmn-tasks package and moved them to apih
side, added junit test
renamed error message constant, removed regex check, add error message
porefix directly to actual message

Issue-ID: SO-2267
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I440cf9eff12571f576fcc5f2d28d9f2c8130e4b6

4 years ago- Make association from the cvnfc to the fabric 60/94360/2
Merkel, Jeff [Tue, 27 Aug 2019 17:26:30 +0000 (13:26 -0400)]
- Make association from the cvnfc to the fabric

- Make association from the cvnfc to the fabric config.

Issue-ID: SO-2262
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I8d9c1e5b738ec36fb3c6d9bae4acfef155b0e058

4 years agoFix rollback for ConfigAssignBB 30/94630/2
Munir Ahmad [Thu, 29 Aug 2019 18:15:53 +0000 (14:15 -0400)]
Fix rollback for ConfigAssignBB

Issue-ID: SO-2266

Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Change-Id: Iff2faa9f9b919818c4a5f98a62ec2a66ee7589e4

4 years agoAdded back MDC.put to generated missing requestID 90/94590/3
Sangalang, Felix [Thu, 29 Aug 2019 13:59:30 +0000 (09:59 -0400)]
Added back MDC.put to generated missing requestID

Added back MDC.put to generated missing requestID in logfiles.

Issue-ID: SO-2265
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I67e0b01dfeb609e7a5d7e29f976ec3ec6549e96b

4 years agosonar fix-remove unused import 15/94615/1
Thugutla sailakshmi [Thu, 29 Aug 2019 15:47:17 +0000 (21:17 +0530)]
sonar fix-remove unused import

sonar fix-remove unused import

Issue-ID: SO-2174
Change-Id: I5c13bbf27aa0f03b448fca5c2cea7329512aff01
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoFixing ccvpn parsing issue 42/94342/10
subhash kumar singh [Tue, 27 Aug 2019 12:06:21 +0000 (17:36 +0530)]
Fixing ccvpn parsing issue

Fixing ccvpn parsing issue.

Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Change-Id: Iaee7d003f8d657a93901b51bef9bedab0433b75c

4 years agosonar fix for ExtractPojosForBB class 39/94439/1
Lukasz Muszkieta [Wed, 28 Aug 2019 13:43:29 +0000 (15:43 +0200)]
sonar fix for ExtractPojosForBB class

Change-Id: I2d568604fa5d2e688b367644de620c8e91508aae
Issue-ID: SO-2187
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
4 years agoMerge "Removed unused methods injectSNIROCallbacks() according to comments by maintainer"
Lukasz Muszkieta [Wed, 28 Aug 2019 07:42:16 +0000 (07:42 +0000)]
Merge "Removed unused methods injectSNIROCallbacks() according to comments by maintainer"

4 years agoMerge "Fix issue in mso-api-handler-infra"
Lukasz Muszkieta [Tue, 27 Aug 2019 07:19:25 +0000 (07:19 +0000)]
Merge "Fix issue in mso-api-handler-infra"

4 years agoFix issue in mso-api-handler-infra 22/94322/1
Parshad Patel [Tue, 27 Aug 2019 05:29:12 +0000 (14:29 +0900)]
Fix issue in mso-api-handler-infra

Either log or rethrow this exception
Define a constant instead of duplicating this literal
Immediately throw this expression instead of assigning it to the temporary variable
Remove the declaration of thrown exception 'org.json.JSONException' which is a runtime exception

Issue-ID: SO-1841
Change-Id: I193f21ec2c4214863c8b51faf25fc3561d6be818
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
4 years agoMerge "Add generic neutron network parameters"
Seshu Kumar M [Tue, 27 Aug 2019 05:07:26 +0000 (05:07 +0000)]
Merge "Add generic neutron network parameters"

4 years agoMerge "Fix parsing issue for ccvpn"
Byung-Woo Jun [Mon, 26 Aug 2019 16:03:39 +0000 (16:03 +0000)]
Merge "Fix parsing issue for ccvpn"

4 years agoFix parsing issue for ccvpn 85/92585/7
subhash kumar singh [Fri, 2 Aug 2019 15:47:09 +0000 (21:17 +0530)]
Fix parsing issue for ccvpn

Fix csar parsing issue for ccvpn.

Change-Id: Ie99acbec8a52de7a08d1627c210c0e3fda986520
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
4 years agoAdded default value for when ErrorCode is null in 84/94284/1
Boslet, Cory [Mon, 26 Aug 2019 14:09:09 +0000 (10:09 -0400)]
Added default value for when ErrorCode is null in

Added default value for when ErrorCode is null in mdc
test to see if 404 log gets enhanced by change.
Removed test id from class that was put to test via docker.
Removed setting of partner name and tested with using try/catch
Reverted change to request uri filter per comments
Removed the request filter uri class that rerouted old uri orders
Removed request filter from jersey config files
Updated junit test that were pointing to the old uri to be failure test
corrected formatting issues on ServiceInstancesTest

Issue-ID: SO-2259
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Id8f9daef139a82ee9e934d4d37906ffb7a7aadff