appc/cdt.git
5 years agoFixed error in param-name-value spec file 95/57995/2
Arundathi Patil [Mon, 30 Jul 2018 09:53:25 +0000 (15:23 +0530)]
Fixed error in param-name-value spec file

Test cases in param-name-value.component.spec file failed with below
error,
Error: No Provider for Utility service
Fixed this error

Issue-ID: APPC-1064
Change-Id: Ie0e63be45b1cdde0bd2169168c562452babd6aa5
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoAdded spec file for gcauth guard service 31/58631/2
Arundathi Patil [Thu, 2 Aug 2018 08:59:21 +0000 (14:29 +0530)]
Added spec file for gcauth guard service

Wrote test cases to cover gcauth guard service

Issue-ID: APPC-1064
Change-Id: Iaa01bc22b1fdb52f0cecb7b6c20502c8f6f05a14
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoadded spec for auth-guard component 75/58675/2
Arundathi Patil [Thu, 2 Aug 2018 10:58:45 +0000 (16:28 +0530)]
added spec for auth-guard component

Wrote test case to cover auth-guard component

Issue-ID: APPC-1064
Change-Id: Id9da15a608fd7954c380cffac4d94044ae4fe1f5
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoFixed error in test component spec file 03/58403/2
Arundathi Patil [Wed, 1 Aug 2018 10:56:34 +0000 (16:26 +0530)]
Fixed error in test component spec file

Test cases in test component spec file failed with below error,
Eroor: No provider for NgxSpinnerModule.
Fixed this error

Issue-ID: APPC-1064
Change-Id: I89db4044b3fbc62cae4656e93a6b4519fb5cd0aa
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoReference-dataform- test cases 97/57997/3
Arundathi Patil [Mon, 30 Jul 2018 09:58:56 +0000 (15:28 +0530)]
Reference-dataform- test cases

Wrote test case to cover upload function in refernce-dataform.component

Issue-ID: APPC-1064
Change-Id: I44c62b944c14b9f66fc2117ad7d578b2388e973b
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoTest cases - UtilityService 03/58003/3
Arundathi Patil [Mon, 30 Jul 2018 10:21:36 +0000 (15:51 +0530)]
Test cases - UtilityService

Wrote test cases in uitilityService to cover processApiSubscribe
function

Issue-ID: APPC-1064
Change-Id: Id6852114581a761550f49fa59e749140d377f0fc
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoTest Case - Paramete-definitions.service 93/58193/3
Arundathi Patil [Tue, 31 Jul 2018 09:01:40 +0000 (14:31 +0530)]
Test Case - Paramete-definitions.service

Wrote test case to cover setValues method pf parameter-definitions
service

Issue-ID: APPC-1064
Change-Id: I5e43aba3c6af733cf20922036ef7ad09b86a7cdd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoTest cases - build-artifacts component 97/58197/3
Arundathi Patil [Tue, 31 Jul 2018 09:08:10 +0000 (14:38 +0530)]
Test cases - build-artifacts component

Wrote test cases to cover updateAccessUpdatePages method in
build-artifacts component.

Issue-ID: APPC-1064
Change-Id: If654c89d1daf1d9639aa172c08f3270b6337ba0e
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoabousUs Component : Fixed test case 37/58637/3
Arundathi Patil [Thu, 2 Aug 2018 09:05:40 +0000 (14:35 +0530)]
abousUs Component : Fixed test case

Test case in aboutus component spec file failed with below error,
Error: this.http.get is not a function
Fixed this error

Issue-ID: APPC-1064
Change-Id: I59426d9a96ab67a7fbef6c540be26b7204a7ee7f
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoTest case- myVnfs component 95/58195/2
Arundathi Patil [Tue, 31 Jul 2018 09:04:39 +0000 (14:34 +0530)]
Test case- myVnfs component

Wrote test case to cover navigateToreference method of myVnfs component

Issue-ID: APPC-1064
Change-Id: Ie6417fb2e975164c9d5226d7e270ec4f7dbbdb1a
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agouserloginForm- Fixed test case 43/58643/2
Arundathi Patil [Thu, 2 Aug 2018 09:13:20 +0000 (14:43 +0530)]
userloginForm- Fixed test case

Test case in userlogin form was expecting wrong values because of which
the test case failed. Changed the test case expecting values to proper
values.

Issue-ID: APPC-1064
Change-Id: I9b1aedc70a806b235c0b56d936370e8a1a62d2dd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoFixed error in user-login-form spec file 01/58001/4
Arundathi Patil [Mon, 30 Jul 2018 10:15:23 +0000 (15:45 +0530)]
Fixed error in user-login-form spec file

Test cases in userLogin-form spec file failed with below error,
Error: Cannot read property 'root' of undefined.

This error was because, activated route was not injected into the
testingbed. Fixed this error.

Issue-ID: APPC-1064
Change-Id: Ib9978b73be744204e8dd64b97abbc0959a4e5839
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agofixed error in aboutUs component spec 91/58191/4
Arundathi Patil [Tue, 31 Jul 2018 08:55:02 +0000 (14:25 +0530)]
fixed error in aboutUs component spec

Test cases in aboutus component spec file failed due to the changes made in ts
file. Fixed these issues

Issue-ID: APPC-1064
Change-Id: Ief9c517de5ecb57bac8787e064b2bec3f7c50f2c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoRemoved unwanted code 15/57515/2
Arundathi Patil [Wed, 25 Jul 2018 11:43:56 +0000 (17:13 +0530)]
Removed unwanted code

Removed ngbModal from imports and constructor as it was not used.

Issue-ID: APPC-1054
Change-Id: I92406941099384b1b17472d57c888041deb7e0a4
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoFixed error in template-configuration spec 15/57815/2
Arundathi Patil [Fri, 27 Jul 2018 10:36:59 +0000 (16:06 +0530)]
Fixed error in template-configuration spec

Test cases in template-configuration spec file failed with the below
error,
Error: No provider for UtilityService.
Fixed this error.

Issue-ID: APPC-1064
Change-Id: Ibb580435a3f70024988434eba74b61be80423990
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agorefactored payload in uploadArtifact of reference 31/57031/3
Sandeep J [Fri, 20 Jul 2018 09:09:04 +0000 (14:39 +0530)]
refactored payload in uploadArtifact of reference

refactored payload in uploadArtifact method of reference dataform using
createPayloadForSave method of utlity service

Issue-ID: APPC-1100
Change-Id: I9f91725371da96e6d2384b2348e288ebc0af238d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded progress spinner for spreadsheet upload 39/57039/5
Sandeep J [Fri, 20 Jul 2018 10:26:31 +0000 (15:56 +0530)]
added progress spinner for spreadsheet upload

added progress spinner for spreadsheet upload in test.component,ts

Issue-ID: APPC-1102
Change-Id: I9d030da990eae2e8efe5ae82cd1afd3c675aa286
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoUtilityService: Removed hard coded values 91/57991/1
Arundathi Patil [Mon, 30 Jul 2018 09:46:54 +0000 (15:16 +0530)]
UtilityService: Removed hard coded values

Moved the hard coded values from utility service file to app-contants
file as variables.

Issue-ID: APPC-1054
Change-Id: Iac62da47deeeb66402f413e90ee0ab50130ca185
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoFixed error in spec file 01/57301/2
Arundathi Patil [Tue, 24 Jul 2018 11:27:04 +0000 (16:57 +0530)]
Fixed error in spec file

Test cases in parameter.component spec file failed with below error,
Error: No provider for NGXSpinnerService
Fixed this issue

Issue-ID: APPC-1064
Change-Id: I51d8e79888e182fef11d0c99936953ed0eabd380
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agorefactored payload creation proces in retrieve API 19/57019/3
Sandeep J [Fri, 20 Jul 2018 07:58:33 +0000 (13:28 +0530)]
refactored payload creation proces in retrieve API

refactored payload creation in retrieveNameValueFromAppc method of
param-name-value.component.ts by using the createPayloadForRetrieve
method in utility.service.ts

Issue-ID: APPC-1098
Change-Id: Ia5b4a7c259c9a27958b6df9c59869a79b03064ee
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoAdded spec file for loginGuardService 17/57517/2
Arundathi Patil [Wed, 25 Jul 2018 11:47:05 +0000 (17:17 +0530)]
Added spec file for loginGuardService

Wrote test cases for loginGuardService

Issue-ID: APPC-1064
Change-Id: I9b742c860aa6a523b1c858380e8a025a621f01fd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoadded spec file for confirm.component 93/57493/2
Arundathi Patil [Wed, 25 Jul 2018 11:13:30 +0000 (16:43 +0530)]
added spec file for confirm.component

Wrote test cases for confirm modal component.

Issue-ID: APPC-1064
Change-Id: I6cac13f52730c31cd98e14fc8874012224b938f9
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoFixed error in spec file 97/57297/3
Arundathi Patil [Tue, 24 Jul 2018 11:23:55 +0000 (16:53 +0530)]
Fixed error in spec file

Test cases in myvnfs component spec file failed with the below error,
Error: No provider for notification service
Fixed this issue

Issue-ID: APPC-1064
Change-Id: I39a451414e56b9db3eab7910c79d2d103b44380a
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agorefactor payload creation in parameter.ts 21/57021/3
Sandeep J [Fri, 20 Jul 2018 08:23:22 +0000 (13:53 +0530)]
refactor payload creation in parameter.ts

refactor payload creation in getPD parameter.ts using createPayloadForRetrieve
method in utility.service.ts

Issue-ID: APPC-1099
Change-Id: I976dfebfe60a123784853a7294125cf6075a653b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoFixed test case 93/57293/2
Arundathi Patil [Tue, 24 Jul 2018 11:20:51 +0000 (16:50 +0530)]
Fixed test case

Test case was expecting wrong value from function in test.component.
fixed this issue.

Issue-ID: APPC-1064
Change-Id: I668778c0ae30f218204d652ed9efbd9bc0ace097
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoRemoved hard coded values in myVNFs component 11/57511/2
Arundathi Patil [Wed, 25 Jul 2018 11:38:41 +0000 (17:08 +0530)]
Removed hard coded values in myVNFs component

removed error messages that were hard coded in myvnfs component. Used
the variables from app-constants file for these errors.

Issue-ID: APPC-1064
Change-Id: I5acffb29e18cd0b135ee4bf206c507db26b9765c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agowrote test case for mapping-editor service 59/57159/3
Arundathi Patil [Mon, 23 Jul 2018 11:50:53 +0000 (17:20 +0530)]
wrote test case for mapping-editor service

Wrote unit test cases for mapping-editor service. The covarage for this
file is now 75.96%

Issue-ID: APPC-1064
Change-Id: I4c413a076dd6194da9a19481c0fdc42f0ffe5789
Signed-off-by: Arundathi Patil<arundpil@in.ibm.com>
5 years agorefactord payload creatn for template & param save 43/57143/3
Sandeep J [Mon, 23 Jul 2018 10:42:26 +0000 (16:12 +0530)]
refactord payload creatn for template & param save

refactored payload creation for saving template and param artifacts to
APPC using createPayloadForSave method in utility.service.ts

Issue-ID: APPC-1105
Change-Id: I2dd446aebdbcbc1ffc070993ee53d09e25eeae6b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoFixed error 77/57177/2
Arundathi Patil [Mon, 23 Jul 2018 14:40:06 +0000 (20:10 +0530)]
Fixed error

Test cases in param-name-value component spec file failed with the below
error,
Error: No provider for NgxSpinnerService

Fixed this error

Issue-ID: APPC-1064
Change-Id: Ib4e0b3276525973fb6a625d2366ed26cf3d94173
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoRemoved hard coded values 01/56601/3
Arundathi Patil [Tue, 17 Jul 2018 10:16:17 +0000 (15:46 +0530)]
Removed hard coded values

Moved all the constant values in parameter component to app-Constants
file.

Issue-ID: APPC-1054
Change-Id: I507cc0a4aa8ddc8d6d42e97129b21a235b96b225
Signed-off-by: Arundathi Patil<arundpil@in.ibm.com>
5 years agoMade use of ng2-bootstrap-modal. 13/56713/4
Arundathi Patil [Wed, 18 Jul 2018 10:11:05 +0000 (15:41 +0530)]
Made use of ng2-bootstrap-modal.

This will remove all the duplicate code of ng-bootstrap popup.

Made following changes to the below files,

1. app.module.ts:
a. added the confirm modal component to declarations and entryComponents section because component will be created dynamically.
b. imported BootstrapModalModule from ng2-bootstrap-modal
2. vnfs.module.ts:
a. removed the confirm modal component from declarations and
   entryComponents section as it is already declared as part of
   app.module.ts.
3. confirm.component.ts:
a. added two more varibles 'cancelButtonText' and
   'confirmButtonText' to ConfirmModel interface. these values will
    be sent by the caller code and the button lables will be set
    dynamically.
b. implemented cancel method that sets the modal result value to
   false, this is called on click of close
   button.
4. about.component.ts:
a. Made use of confirm.component.ts.
b. on click of 'view change log' buton we are calling open()
   method which inturn opens the confirm modal component.
5. about.component.html:
a. Removed call to versionLogFile() method as this method is
   called from open() method.
b. Removed the ng-template code of ng-bootstrap which is no more
   required.

Issue-ID: APPC-1088
Change-Id: I9de545debed145ef35e31807acd1e9bd9cc2bad4
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoadded test case in app component 05/56605/2
Arundathi Patil [Tue, 17 Jul 2018 11:23:26 +0000 (16:53 +0530)]
added test case in app component

wrote test case to test selectedNavItem method in app component.

Issue-ID: APPC-1064
Change-Id: I8770fa19b024cbaa0f0bb86217ebe9255469f64b
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agounsubscribed from observables 03/56603/2
Arundathi Patil [Tue, 17 Jul 2018 10:35:00 +0000 (16:05 +0530)]
unsubscribed from observables

Unsubscribed from observables in ngOndestroy method of myvnfs component.
This will release the resources held by the subscription.

Issue-ID: APPC-1049
Change-Id: I7cc7bd5aabeeb20934332541b99314a611d66f93
Signed-off-by: Arundathi Patil<arundpil@in.ibm.com>
5 years agoFixed error in spec file 61/56861/2
Arundathi Patil [Thu, 19 Jul 2018 08:53:13 +0000 (14:23 +0530)]
Fixed error in spec file

All the test cases in template-configuration spec file failed with the
below error.

Error: "No provider for NGXSpinnerService".

Fixed this error.

Issue-ID: APPC-1064
Change-Id: I9ea042519e0f6ba94344d17b9d0e457c4c4480cd
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoUnsubscribed observables 27/56727/4
Arundathi Patil [Wed, 18 Jul 2018 11:19:11 +0000 (16:49 +0530)]
Unsubscribed observables

Unsubscribed from observables in param-name-value component. This will
release any resources that the subscription holds.

Issue-ID: APPC-1049
Change-Id: Ie3aa18bfa9d5129a26abb2f33dd2f80e1cfc8bba
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agocorrected commenting style in licence header 87/56887/2
Sandeep J [Thu, 19 Jul 2018 11:16:48 +0000 (16:46 +0530)]
corrected commenting style in licence header

corrected commenting style in licence header of template configuration
html from "/*" to "<!--"

Issue-ID: APPC-1092
Change-Id: Ie3421a37db62e48495394f54ffd70b14ec2d053b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded progress spinner for uploading param file 59/56359/5
Sandeep J [Fri, 13 Jul 2018 08:23:46 +0000 (13:53 +0530)]
added progress spinner for uploading param file

added progress spinner while uplaoding param file for the user to have a visual representation of the upload

Issue-ID: APPC-1066
Change-Id: I411cca1677e924ee43050843401fd957a2aba3f9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded progress spinner in PD to show file upload 83/56883/2
Sandeep J [Thu, 19 Jul 2018 11:11:13 +0000 (16:41 +0530)]
added progress spinner in PD to show file upload

added progress spinner in PD to show file upload progress

Issue-ID: APPC-1070
Change-Id: I28d237a3a69f68a9e9dbc6433c95dc53c4fbffbf
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agorefactord payload creation for retrieving template 91/56891/2
Sandeep J [Thu, 19 Jul 2018 11:43:19 +0000 (17:13 +0530)]
refactord payload creation for retrieving template

refactored payload creation process for template using utility service
createPayloadForRetrieve method

Issue-ID: APPC-1094
Change-Id: I1901a20c07f5d577ad5962b891f277771040b85f
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoTest case for vm-filtering.pipe 59/56859/2
Arundathi Patil [Thu, 19 Jul 2018 08:34:00 +0000 (14:04 +0530)]
Test case for vm-filtering.pipe

Wrote test case for vm-filtering pipe. the coverage for this file is now
100%.

Issue-ID: APPC-1064
Change-Id: I3ada33f251bbc180052eac8368b4d350a19c6860
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agorefactored payload creation in getArtifacts method 95/56895/2
Sandeep J [Thu, 19 Jul 2018 12:07:09 +0000 (17:37 +0530)]
refactored payload creation in getArtifacts method

refactored payload creation in getArtifacts method of
reference-dataform.component.ts. The payload is created now using
createPayloadForRetrieve method of utility.service.ts

Issue-ID: APPC-1095
Change-Id: I303a67d67b9764ada2d1d37adc9281442f44649e
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to param name value component spec 39/56739/3
Sandeep J [Wed, 18 Jul 2018 12:51:14 +0000 (18:21 +0530)]
added test case to param name value component spec

added test case to param-name-value.spec.ts to increase code coverage

Issue-ID: APPC-1089
Change-Id: I2598eb2b3b7f7551f89f26e2ec6d8f820466cd42
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoRemoved fdescribe 57/56857/1
Arundathi Patil [Thu, 19 Jul 2018 08:38:19 +0000 (14:08 +0530)]
Removed fdescribe

Removed fdescribe which was accidentally checked-in.

Issue-ID: APPC-1064
Change-Id: I08265f3de9cea66836ed7e194e4bd4f9d1159e7f
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoadded util methods to utility service 85/56185/5
Sandeep J [Wed, 11 Jul 2018 11:23:40 +0000 (16:53 +0530)]
added util methods to utility service

added methods in utility service for creating common payload method for save andretrieve and downloading artifact

Issue-ID: APPC-1063
Change-Id: I05d8e0df05bf74fe30358b0a44506baf03442a99
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded progress spinner while uploading template 85/56285/9
Sandeep J [Fri, 13 Jul 2018 07:52:42 +0000 (13:22 +0530)]
added progress spinner while uploading template

added progress spinner while uploading template file so that the user can know visually that the file is being uploaded

Issue-ID: APPC-1069
Change-Id: I4d17a1f64a241dc3dc49154ec6c8abe7babb793a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoFixed error 23/56723/2
Arundathi Patil [Wed, 18 Jul 2018 10:48:49 +0000 (16:18 +0530)]
Fixed error

Unable to run the test cases due to the below error in paramShare
service spec file,

"Argument of type '{ displayName: string; displayValue: string;}[]' is
not assignable to parameter of type 'Expected<{[index: string]: string } >' "

Fixed this error.

Issue-ID: APPC-1064
Change-Id: I9b9e99e9a5ed4a14469eb595625d1b3fd91e6672
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoadded setTimeOut method in PD retrival progres bar 71/56371/4
Sandeep J [Fri, 13 Jul 2018 09:40:51 +0000 (15:10 +0530)]
added setTimeOut method in PD retrival progres bar

added setTimeOut of 3.5 seconds in progress bar for retrieving PD data from APPC

Issue-ID: APPC-1073
Change-Id: I79432be9b3f74dfa84e7a37da6fb8d86c2a779f5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoRemoved fdescribe 07/56607/2
Arundathi Patil [Tue, 17 Jul 2018 11:30:48 +0000 (17:00 +0530)]
Removed fdescribe

Removed fdescribe in mapping-editor service file which was accidentally checked-in in the previous
checkin

Issue-ID: APPC-1064
Change-Id: I1151dda4881ba31198b176e14f9322d18126ab93
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agoguava version upgrade fix nexus IQ 33/56633/1
Taka Cho [Tue, 17 Jul 2018 16:07:42 +0000 (12:07 -0400)]
guava version upgrade fix nexus IQ

upgrade springfox swagger version to avoid security issue from guava.jar

Change-Id: I9c81b12886cbe82faa24e75acd2ea848edbb67e7
Issue-ID: APPC-1025
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agoupgrade http-client to avoid nexus iq issue 31/56631/1
Taka Cho [Tue, 17 Jul 2018 15:57:13 +0000 (11:57 -0400)]
upgrade http-client to avoid nexus iq issue

upgrade http-client version to avoid nexus iq issue

Change-Id: I2fd4f2cd8b7529559cfabde527091c866a9ab359
Issue-ID: APPC-1025
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agoadded error block in getArtifacts method 05/56505/2
Sandeep J [Mon, 16 Jul 2018 11:32:46 +0000 (17:02 +0530)]
added error block in getArtifacts method

added error block in getArtifacts method to handle error scenario like error connecting to appc. The user will be notified with the angular2-notification whenever there is error connecting to appc.

Issue-ID: APPC-1083
Change-Id: I185e390cb0ddef2edea8f08d08ae124c7d05a06c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoreplaced if else logic to switch case 07/56507/3
Sandeep J [Mon, 16 Jul 2018 11:57:52 +0000 (17:27 +0530)]
replaced if else logic to switch case

Replaced the if else logic in decideExtension and populateExistinAction
method with switch case for better presentation of the code as part of
plan for reference dataform code refactor

Issue-ID: APPC-1085
Change-Id: I002e61d53585ba61b96e1e6cb0f12443498df6e9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoUnsubscribed the observables. 77/56277/4
IBM602-PC0F1E3C\Arundathi [Thu, 12 Jul 2018 10:52:11 +0000 (16:22 +0530)]
Unsubscribed the observables.

Unsubscribed the observables in aboutus component.

Issue-ID: APPC-1049
Change-Id: I7f67a75e214f7b9996c269d613b9daa742a5e723
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agoFixed the failng test cases. 97/56497/2
IBM602-PC0F1E3C\Arundathi [Mon, 16 Jul 2018 10:00:37 +0000 (15:30 +0530)]
Fixed the failng test cases.

Fixed the failing test cases for build-artifacts component.
5 of the test cases in build-artifacts component spec were failing with
the below errors,
1. No Provider for Notification Service.
2. Cannot read property 'vnf-type' of undefined.
Fixed the above errors. The coverage for this component is now 84.78%.

Issue-ID: APPC-1064
Change-Id: Ifee45f86ce7093c9783d1f28a313869300bd8e39
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agoRemoved duplicate code. 91/56491/2
IBM602-PC0F1E3C\Arundathi [Mon, 16 Jul 2018 09:00:26 +0000 (14:30 +0530)]
Removed duplicate code.

The same variable values are set on file upload failure either due to
wrong format or due to wrong content of the file being uploaded in
uplaod() and uplaodedFileResult() methods of test component.

Moved this duplicate code to a single method called
setValuesOnFileUploadFailure() and called this method where required.

Issue-ID: APPC-1082
Change-Id: If92d375e3cfa44479c2d7f54915a1b6461bdda89
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agoChanged release name to ONAP 77/56477/2
IBM602-PC0F1E3C\Arundathi [Mon, 16 Jul 2018 06:41:37 +0000 (12:11 +0530)]
Changed release name to ONAP

As per the comment made by Takamune Cho (tc012c@aat.com) in gerrit request
'https://gerrit.onap.org/r/#/c/56277/', changed the release name to ONAP
in vergionlog text file and appVersion json file in aboutUs directory.

Issue-ID: APPC-1081
Change-Id: Ia452b898eb839e434b81f3e875835fd2ae644294
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agoMoved the hard coded values to constant file 91/56091/5
IBM602-PC0F1E3C\Arundathi [Tue, 10 Jul 2018 11:46:08 +0000 (17:16 +0530)]
Moved the hard coded values to constant file

Created a constant file called app-contants and moved the harded coded values in builArtifact component to app-constant
file

Issue-ID: APPC-1054
Change-Id: I2641579cdb6b20f2c51ce4f4d3ca2bd0667d2e81
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agoAdded a unit test case for collapse directive. 87/56187/5
IBM602-PC0F1E3C\Arundathi [Wed, 11 Jul 2018 11:36:43 +0000 (17:06 +0530)]
Added a unit test case for collapse directive.

Added a unit test case that covers the get collapse() function in
collapse directive.

Issue-ID: APPC-1064
Change-Id: I273cb3a515bae9140fd7807cfa2d11bdee254cfa
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agowrote unit test case for parameter component. 75/56375/3
IBM602-PC0F1E3C\Arundathi [Fri, 13 Jul 2018 09:55:51 +0000 (15:25 +0530)]
wrote unit test case for parameter component.

Added unit test cases to cover ngOninit, selectedNavItem and showUpload
methods.

Issue-ID: APPC-1064
Change-Id: I38b885f905a13ca316ee31e5efa6b5bbb74d8506
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agoUnsubscribed from observable subscription. 77/56377/3
IBM602-PC0F1E3C\Arundathi [Fri, 13 Jul 2018 10:04:30 +0000 (15:34 +0530)]
Unsubscribed from observable subscription.

Unsubscribed from observable in navigation component in ngOnDestroy
method. This will dispose the resource that the subscription holds.

Issue-ID: APPC-1049
Change-Id: I63203c7f3af9fb83b58bea91d9a21219611c7f7f
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agoAdded spec file paramShare service. 73/56373/2
IBM602-PC0F1E3C\Arundathi [Fri, 13 Jul 2018 09:49:29 +0000 (15:19 +0530)]
Added spec file paramShare service.

Wrote unit test case for paramShare service. The file is now covered
100%.

Issue-ID: APPC-1064
Change-Id: Ie3f8768577435eba4b2922d239567871f8a5ccaf
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agoAdded spec file for notification service. 75/56275/3
IBM602-PC0F1E3C\Arundathi [Thu, 12 Jul 2018 10:41:23 +0000 (16:11 +0530)]
Added spec file for notification service.

wrote unit test case for notification service.

Issue-ID: APPC-1064
Change-Id: Ib5459ae4795b8d2b225d8953a7d707ce516b8ee3
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agoAdded spec file mapping-editor service. 73/56273/3
IBM602-PC0F1E3C\Arundathi [Thu, 12 Jul 2018 10:19:10 +0000 (15:49 +0530)]
Added spec file mapping-editor service.

Wrote unit test case for mapping-editor service.

Issue-ID: APPC-1064
Change-Id: I99f439a8b8d841d81bf01d85cf9744e64d78fc35
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agoFixed error- Added braces. 07/56407/1
IBM602-PC0F1E3C\Arundathi [Fri, 13 Jul 2018 17:34:08 +0000 (23:04 +0530)]
Fixed error- Added braces.

Added missing braces at the end of the file.

Issue-ID: APPC-1051
Change-Id: I83db0d604bb50b2d7b8fd7fe3f8a61b0cd64ccd8
Signed-off-by: Arundathi <arundpil@in.ibm.com>
5 years agoChange mdbootstrap version 13/56313/1
Patrick Brady [Thu, 12 Jul 2018 19:44:06 +0000 (12:44 -0700)]
Change mdbootstrap version

The current version of mdbootstrap has a problem.
Setting it to 4.5.3 which seems stable.

Change-Id: I45545119ff127c20d588be5fd08c6b367d18de03
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1072

5 years agoFix CDT Nexus ID issue 19/55219/1
Taka Cho [Thu, 21 Jun 2018 18:51:18 +0000 (14:51 -0400)]
Fix CDT Nexus ID issue

Change-Id: I63885258b74576e7d038af92ca2b10363093f55e
Issue-ID: APPC-1025
Signed-off-by: Taka Cho <tc012c@att.com>
6 years agoChange port to match Kubernetes port 83/49183/1
Patrick Brady [Fri, 25 May 2018 19:25:59 +0000 (12:25 -0700)]
Change port to match Kubernetes port

Kubernetes uses a 302 prefix on port numbers. Going
to change the port used for cdt proxy backend to use
this port.

Change-Id: I630b101e28b8cc072166dcbcb0e8de42dfb6d513
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-924

6 years agoUpdate version file for new branch 47/48547/1
Patrick Brady [Tue, 22 May 2018 18:36:26 +0000 (11:36 -0700)]
Update version file for new branch

Change-Id: I9da3a2c965345eb71cf724608f3f55f581668eb0
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-916

6 years agoIncrement versions for new branch 41/48541/1
Patrick Brady [Tue, 22 May 2018 18:15:23 +0000 (11:15 -0700)]
Increment versions for new branch

Change from version 1.3.0-SNAPSHOT to
1.4.0-SNAPSHOT

Change-Id: I4767e1e63c7b5bb76a3fd0aea48ac18d81f7faf7
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-916

6 years agoAdd maven version plugin 87/48387/1
Patrick Brady [Mon, 21 May 2018 21:32:13 +0000 (14:32 -0700)]
Add maven version plugin

This plugin configuration is needed so jenkins can
update the version number of the proxy project to
the release number when the release job is run.

Change-Id: I30f02b150b71cb1cbaea6a5f1ccdac03d8843889
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-910

6 years agoCorrect cdtproxy port for docker 03/48103/2
Patrick Brady [Thu, 17 May 2018 20:38:56 +0000 (13:38 -0700)]
Correct cdtproxy port for docker

The port number and hostname need to be changed
since the proxy will run in the appc docker.

Change-Id: I22463013756f43a3bb5ff0513944b0d18e24c130
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-909

6 years agoMatch cdt version to appc version 01/48101/1
Patrick Brady [Thu, 17 May 2018 20:35:39 +0000 (13:35 -0700)]
Match cdt version to appc version

Change-Id: I09bde6cbea87c1346b5cc293b1e5379973f42034
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-911

6 years agoAdd dist management to pom 21/47921/2
Patrick Brady [Wed, 16 May 2018 21:50:14 +0000 (14:50 -0700)]
Add dist management to pom

Change-Id: I7e0c18c7e0875af106ee95e540e17b9ba961177f
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-905

6 years agoAdding staging plugin 13/47913/1
Patrick Brady [Wed, 16 May 2018 21:22:52 +0000 (14:22 -0700)]
Adding staging plugin

Change-Id: I9d0ed862a34bec2ff720d189f5cecf7afeae38a4
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-905

6 years agoinitial commit for CDT proxy Service 85/46985/4
Kumar, Amaresh (ak583p) [Thu, 10 May 2018 09:05:25 +0000 (14:35 +0530)]
initial commit for CDT proxy Service

Initial commit for CDT proxy server to fix CORS Issues.

Issue-ID: APPC-885
Change-Id: Idf2688dbca3fd6c25636544147ed5b23a5a4ed7f
Signed-off-by: Kumar, Amaresh (ak583p) <ak583p@us.att.com>
6 years agoAdded CORS proxy Server endpoint 73/46873/1
Kumar, Amaresh (ak583p) [Wed, 9 May 2018 16:59:45 +0000 (22:29 +0530)]
Added CORS proxy Server endpoint

Added CORS proxy endpoint for backend calls to enable connection.

Issue-ID: APPC-885
Change-Id: I0bb98feda477cb77312bc707cb52e1296b69245b
Signed-off-by: Kumar, Amaresh (ak583p) <ak583p@us.att.com>
6 years agoadded code to allow headers in request 75/46575/2
sj108s [Tue, 8 May 2018 09:53:57 +0000 (15:23 +0530)]
added code to allow headers in request

changed http util service to allow headers in the api request

Issue-ID: APPC-885
Change-Id: Ia85148eefdc217011155099b33ac39cc638dd734
Signed-off-by: sj108s <sj108s@us.att.com>
6 years agoRemoved the property which toggles configscaleout 75/46475/1
Patrick Brady [Mon, 7 May 2018 21:49:11 +0000 (14:49 -0700)]
Removed the property which toggles configscaleout

Change-Id: I9d5aaa07aeed62c83eea123f34de2735fb58ef02
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-886

6 years agochanged cdt app properties for configscaleout 65/46165/1
sj108s [Fri, 4 May 2018 06:59:46 +0000 (12:29 +0530)]
changed cdt app properties for configscaleout

changed cdt application properties to display configscaleout in reference data

Issue-ID: APPC-877
Change-Id: Id7e37298421aaa1a42379cf40870ced3e329ebca
Signed-off-by: sj108s <sj108s@us.att.com>
6 years agoFixed parsing of retrieved openstack ref data 91/45091/2
sj108s [Fri, 27 Apr 2018 11:04:48 +0000 (16:34 +0530)]
Fixed parsing of retrieved openstack ref data

Fixed parsing of retrieved data in case of openstack action and also
fixed browser hang while syncing large template

Issue-ID: APPC-867
Change-Id: I3058626cb5a21c01a9b261d470672db5d0f17926
Signed-off-by: sj108s <sj108s@us.att.com>
6 years agomade fixes to template identifer and dropdowns 71/44771/1
Gangarajula, Uday Bhasker (ug0221) [Wed, 25 Apr 2018 22:02:04 +0000 (18:02 -0400)]
made fixes to template identifer and dropdowns

Issue-ID: APPC-862
Change-Id: I902f794cec5d69e2118f7a87f5c6fb867a1b2216
Signed-off-by: Gangarajula, Uday Bhasker (ug0221) <ug0221@att.com>
6 years agoChanged environment files url from https to http 15/44615/1
sj108s [Wed, 25 Apr 2018 07:49:42 +0000 (13:19 +0530)]
Changed environment files url from https to http

Changed environment files url from https to http for onap

Issue-ID: APPC-860
Change-Id: If443ae5bf5d152b916523b27bd9947b1aa2a6733
Signed-off-by: sj108s <sj108s@us.att.com>
6 years agoVM data retrieval from APPC for open stack action 11/43311/1
Mohamed Asgar Samiulla(ma926a) [Tue, 17 Apr 2018 09:44:28 +0000 (15:14 +0530)]
VM data retrieval from APPC for open stack action

VM data retrieval and stopping user not to navigate to PD and template
if mandatory fields are missing in reference data.

Issue-ID: APPC-853
Change-Id: Id43500579c6d222a2c17a53db9213372afec565f
Signed-off-by: Mohamed Asgar Samiulla(ma926a) <ma926a@us.att.com>
6 years agoResolved the issues with multiple templates 37/42637/1
Gangarajula, Uday Bhasker (ug0221) [Fri, 13 Apr 2018 02:08:59 +0000 (22:08 -0400)]
Resolved the issues with multiple templates

Issue-ID: APPC-707
Change-Id: Ibdf18a021ea453842ddf4001f947f1f4de276997
Signed-off-by: Gangarajula, Uday Bhasker (ug0221) <ug0221@att.com>
6 years ago[Appc-1806] Login for Test screen, test api urls. 83/41183/2
Mohamed Asgar Samiulla(ma926a) [Mon, 2 Apr 2018 13:30:49 +0000 (19:00 +0530)]
[Appc-1806] Login for Test screen, test api urls.

Test API urls corrected and vserverid removed from poll request.

Issue-ID: APPC-831
Change-Id: I0bc616888afee8683ccbf5238980e97c6ca51af6
Signed-off-by: Mohamed Asgar Samiulla(ma926a) <ma926a@us.att.com>
6 years agoCorrected artifact name for multiple template ids 01/40501/2
sj108s [Mon, 2 Apr 2018 09:16:25 +0000 (14:46 +0530)]
Corrected artifact name for multiple template ids

Made changes in param name value component ts for setting correct
artifact name while saving and retrieving artifacts, in case of multiple
template ids.

Issue-ID: APPC-812
Change-Id: I973f7b763f4c2204425fceb77cdae33944ba3c8d
Signed-off-by: sj108s <sj108s@us.att.com>
6 years agoResolved the issues with configscaleout 95/39295/4
Gangarajula, Uday Bhasker (ug0221) [Tue, 27 Mar 2018 20:51:48 +0000 (16:51 -0400)]
Resolved the issues with configscaleout

Issue-ID: APPC-707
Change-Id: Ie618635618333da7d548ff5a0fe711cc34076f62
Signed-off-by: Gangarajula, Uday Bhasker (ug0221) <ug0221@att.com>
6 years agoFixed couple more defects related to test screen 13/37513/2
sj108s [Wed, 21 Mar 2018 15:55:39 +0000 (21:25 +0530)]
Fixed couple more defects related to test screen

Fixed poll status button alignment and fixed minore defect in test
screen and updated test cases as per code change

Issue-ID: APPC-713
Change-Id: I530739fda78d6ca05fba4cbfaacef8ead3b7c23d
Signed-off-by: sj108s <sj108s@us.att.com>
6 years agoRemoving INSTAR functionality from CDT for ONAP. 79/37179/1
Mohamed Asgar Samiulla(ma926a) [Tue, 20 Mar 2018 16:01:56 +0000 (21:31 +0530)]
Removing INSTAR functionality from CDT for ONAP.

Removed license form package.json.

Issue-ID: APPC-750
Change-Id: If20087a24fc0cf42977e1b1149d6be0ff1387689
Signed-off-by: Mohamed Asgar Samiulla(ma926a) <ma926a@us.att.com>
6 years ago[Appc-1806] Removing INSTAR from CDT for ONAP. 01/36201/1
Mohamed Asgar Samiulla(ma926a) [Fri, 16 Mar 2018 10:40:26 +0000 (16:10 +0530)]
[Appc-1806] Removing INSTAR from CDT for ONAP.

The source name for INSTAR made configurable through a property file.

Issue-ID: APPC-750
Change-Id: I7e0d2ae657d4469f6fae54b5358ddb6f5476b211
Signed-off-by: Mohamed Asgar Samiulla(ma926a) <ma926a@us.att.com>
6 years agoAdded few more test case & fixed modal in template 33/36033/1
sj108s [Thu, 15 Mar 2018 14:56:47 +0000 (20:26 +0530)]
Added few more test case & fixed modal in template

Added few more test cases to improve code coverage and changed trigger
command for modal in template page from Enter to ctrl-4

Issue-ID: APPC-697
Change-Id: I4a158ba687bad0bb2f808428333083200714f18a
Signed-off-by: sj108s <sj108s@us.att.com>
6 years agoRemove ECOMP trademark 05/36005/2
Skip Wonnell [Thu, 15 Mar 2018 13:22:40 +0000 (08:22 -0500)]
Remove ECOMP trademark

Remove ECOMP trademark line from License.txt files at root directory

Issue-ID: APPC-737
Change-Id: Ie2a8d26166361434274b7a4425c931d66df0e0d7
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agomade changes to version info and defects 21/35821/1
Gangarajula, Uday Bhasker (ug0221) [Wed, 14 Mar 2018 20:49:03 +0000 (16:49 -0400)]
made changes to version info and defects

Change-Id: I90fb87f1f32365e44180615f9be1eb6d11060dcf
Issue-ID: APPC-707
Signed-off-by: Gangarajula, Uday Bhasker (ug0221) <ug0221@att.com>
6 years agoFixed defects in test screen & updated test cases 07/35507/1
sj108s [Tue, 13 Mar 2018 14:59:58 +0000 (20:29 +0530)]
Fixed defects in test screen & updated test cases

Fixed few defects raised by ST in test screen and also updated test
cases to improve coverage. Also,changed code to match onap standards,
and rectfied grep code violations.

Issue-ID: APPC-730
Change-Id: I0286c38eb4f76dc8c0253a4ccab721b3ccfeff9d
Signed-off-by: sj108s <sj108s@us.att.com>
6 years agoAdded some test cases on httputil service. 75/34775/1
Mohamed Asgar Samiulla(ma926a) [Thu, 8 Mar 2018 09:24:47 +0000 (14:54 +0530)]
Added some test cases on httputil service.

Created a new test for dropdown.ts

Issue-ID: APPC-717
Change-Id: Ic4e63520bbf16a7bd0d8ca0e0896d15ce3412d5d
Signed-off-by: Mohamed Asgar Samiulla(ma926a) <ma926a@us.att.com>
6 years agoAdd build helper to pom 61/34361/4
Patrick Brady [Tue, 6 Mar 2018 22:07:57 +0000 (17:07 -0500)]
Add build helper to pom

Need to re-add the build helper plugin
to pom in order to attach the zip file for
deployment.

Change-Id: I73afb91e622890601cfd723ef33ac9b40352dd7b
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-627

6 years agoUpgraded version file in package.json 85/34285/3
Kumar, Amaresh (ak583p) [Tue, 6 Mar 2018 15:21:53 +0000 (20:51 +0530)]
Upgraded version file in package.json

increased verion no in package json

Issue-ID: APPC-694
Change-Id: I0af99ea46345a9e8192733bc23778320616674b7
Signed-off-by: Kumar, Amaresh (ak583p) <ak583p@us.att.com>
6 years agoCorrect groupid 51/34351/1
Patrick Brady [Tue, 6 Mar 2018 20:10:44 +0000 (15:10 -0500)]
Correct groupid

Incorrect groupid is causing deploy to fail.

Change-Id: I372e4b0546cfb10cfab9d4c7b193185b038633b7
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-627

6 years agoAdding distribution mgmt 47/34347/2
Patrick Brady [Tue, 6 Mar 2018 19:47:08 +0000 (14:47 -0500)]
Adding distribution mgmt

Merge deploy is failing because repository listings
are missing.

Copied the repository listings over from the main
appc project.

Change-Id: Iee5b976dd34134fb0a0dedec9a070cb8ef151697
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-627

6 years agoRoot pom file cleanup 33/34333/2
Patrick Brady [Tue, 6 Mar 2018 19:10:13 +0000 (14:10 -0500)]
Root pom file cleanup

Remove the unused repository and scm tags from
the root pom file. They are causing merge job to
fail and should not be there.

Change-Id: If3611b093cc818133916e468770d497f8edc56d9
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-627