mojahidi [Wed, 3 Jan 2018 14:36:06 +0000 (20:06 +0530)]
Fixed sonar issues - VendorSoftwareProductUtils
Removed unused methods and method parameters
Change-Id: Ie221c5bfd939db74c15db7d12cff9b41059eb86c
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shrikantawachar [Thu, 4 Jan 2018 13:03:53 +0000 (18:33 +0530)]
Fixing sonar qube issues
EchoMapping.java is not used anywhere hence deleting it.
Change-Id: Ifb26e29bacdd62d1137184b50b0b83a6fb2896e5
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
Abhai Singh [Thu, 4 Jan 2018 12:30:25 +0000 (18:00 +0530)]
Fix ProcessDaoZusammenImpl
Fixed reported sonar issues
Change-Id: Id53e3ab1d70e17dd1a7a10cca3c9ee627fef4771
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Thu, 4 Jan 2018 12:36:12 +0000 (18:06 +0530)]
Fix QuestionnaireDataServiceImpl
Fixed reported sonar issues
Change-Id: I921dc63d9d6d5f85d0553c005cef27cc5aabe531
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Aravindhan123 [Tue, 12 Dec 2017 09:25:31 +0000 (14:55 +0530)]
Fix Sonar Issues
Handles translator-core ToscaConverterImpl violations.
Change-Id: I751ffdde851e23a977c6c05fc1fe5551f247a670
Issue-ID: SDC-343
Signed-off-by: Aravindhan123 <Aravindhan.r@amdocs.com>
Abhai Singh [Thu, 4 Jan 2018 12:22:04 +0000 (17:52 +0530)]
Fix OrchestrationTemplateDaoZusammenImpl
Fixed reported sonar issues, sonar issue related to
exception handling are skipped as they would be fixed later
Change-Id: Ib83c69b7b2cfd7fc6e719b3678424c18c3e2cb8a
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Thu, 4 Jan 2018 11:54:20 +0000 (17:24 +0530)]
Fix OrchestrationTemplateCandidateDaoZusammenImpl
Fixed reported sonar issues, sonar issue related to
exception handling are skipped as they would be fixed later
Change-Id: Ifc28fe4358eb542bcbf666a07bc37d5488df14c7
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
ilanap [Thu, 4 Jan 2018 09:34:59 +0000 (11:34 +0200)]
Replace restful-js with Axios
Change-Id: If47c5b7708885e84d632255557543d292f3ccd69
Issue-ID: SDC-869
Signed-off-by: ilanap <ilanap@amdocs.com>
Abhai Singh [Thu, 4 Jan 2018 07:23:23 +0000 (12:53 +0530)]
Fix Sonar NetworkDaoCassandraImpl
Deleted the file since it is not used, also confirmed
with Tali regarding it
Change-Id: I54cd96688f9b8cb7320578d71d8ad13a90b2bef2
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Thu, 4 Jan 2018 08:16:30 +0000 (13:46 +0530)]
Fix Sonar NicDaoCassandraImpl
Deleted the file since it is not used, also confirmed
with Tali regarding it
Change-Id: Iec438220fcdf041ac7e784abdc8af2bef4ccbd9d
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
sheetalm [Wed, 3 Jan 2018 14:12:55 +0000 (19:42 +0530)]
Fix issue in vendor-license.xml
If MRN is updated in feature group then update all linked EPs and Lkgs
with new different versionUuId. This will generate new version in
vendor-license.xml with updated MRN for EP and Lkgs
Change-Id: Ib05d931397f24b8131471f423ca43af49b98df8b
Issue-ID: SDC-870
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 13:40:27 +0000 (19:10 +0530)]
Fix Sonar issues- ComputeDaoZusammenImpl
Fixed reported sonar issue
Change-Id: Ic7f24226dec3320124bf0acd3f70afdec3466163
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
ojasdubey [Wed, 3 Jan 2018 12:23:32 +0000 (17:53 +0530)]
Heat reupload component dependency issue fix
Resolved merge conflict
Change-Id: Ib9561aa7d5814c3dd9c6015214d656a2800984a9
Issue-ID: SDC-872
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
Abhai Singh [Thu, 4 Jan 2018 05:41:14 +0000 (11:11 +0530)]
Fix Sonar ElementToVSPQuestionnaireConvertor
Fixed reported sonar issue
Change-Id: Ib1918e43a15f41535a3f5e1cd31340fe430eae61
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Thu, 4 Jan 2018 08:21:14 +0000 (13:51 +0530)]
Fix Sonar NicDaoZusammenImpl
Fixed reported sonar issues
Change-Id: Id0b925a8e01ac6aa40f48f4e9c1efa018b4155b1
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Thu, 4 Jan 2018 07:59:43 +0000 (13:29 +0530)]
Fix Sonar NetworkDaoZusammenImpl
Fixed reported sonar issues
Change-Id: I2c401fd6b18a74d74096494ff7b15bc4d53df10e
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
mojahidi [Thu, 4 Jan 2018 07:13:22 +0000 (12:43 +0530)]
Fixed sonar issues - MapValidationResponseToDto
Removed commented code
Change-Id: I2dc73201a53947d68031000f80251a6b29798bfb
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Thu, 4 Jan 2018 07:21:39 +0000 (12:51 +0530)]
Fixed sonar issues-MapImageRequestDtoToImageEntity
Removed commented code
Change-Id: I6b6b78653936800e76957d638df3574306605696
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Abhai Singh [Thu, 4 Jan 2018 06:21:25 +0000 (11:51 +0530)]
Fix Sonar ManifestCreatorNamingConventionImpl
Fixed reported sonar issue
Change-Id: I723be3b861df1106c3039a1368f4f20fe4acfcd0
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Thu, 4 Jan 2018 06:16:40 +0000 (11:46 +0530)]
Fix Sonar ImageDaoZusammenImpl
Fixed reported sonar issue
Change-Id: I129fa4cbb5ba09c361663f7259807fca690eff0e
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
mojahidi [Thu, 4 Jan 2018 05:29:07 +0000 (10:59 +0530)]
Fixed sonar issues - VspItemProperty
Added private constructor
Change-Id: Ic8ba23a009dab76518e9b7e266cc6d56820222b5
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Thu, 4 Jan 2018 05:24:05 +0000 (10:54 +0530)]
Fixed sonar issues - ComponentDependenciesImpl
Fixed all sonar issues
Change-Id: Iaed4ea9bc7df52bd100d5d118b7212813ae22b76
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 14:12:55 +0000 (19:42 +0530)]
Fix Sonar VendorSoftwareProductInfoDaoZusammenImpl
Fixed reported sonar issue
Change-Id: Ifc827f6e1ac4c10272969e643d10b86171a0d963
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 14:02:13 +0000 (19:32 +0530)]
Fix Sonar issues- ElementToProcessConvertor
Fixed reported sonar issue
Change-Id: I631710a9421e34cf7c26a9316e2e3271bf44f587
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 13:54:56 +0000 (19:24 +0530)]
Fix Sonar issues- DeploymentFlavorDaoZusammenImpl
Fixed reported sonar issue
Change-Id: I58f503aa43f0257c263835053bde28442f98a2b5
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
talio [Wed, 3 Jan 2018 15:49:51 +0000 (17:49 +0200)]
fix failing tests
fix failing tests in uploadCSARFileTest.java, and changing error messages
Change-Id: Ied1384d87551242d3eb48987990a6e8a72b26916
Issue-ID: SDC-874
Signed-off-by: talio <tali.orenbach@amdocs.com>
talig [Thu, 4 Jan 2018 06:33:48 +0000 (08:33 +0200)]
Fix Orch Template Candidate Manager test failures
Change-Id: Icd5d96b5cd27b3051828b703fde549217341c320
Issue-ID: SDC-860
Signed-off-by: talig <talig@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 13:27:21 +0000 (18:57 +0530)]
Fix Sonar -ComponentDependencyModelDaoZusammenImpl
Fixed reported sonar issue
Change-Id: I6c8b86cb54bcc6d21920e9ea806dcd40717c2383
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 10:58:47 +0000 (16:28 +0530)]
Fix Sonar violations - ValidationErrorCodes
Removing the files since they are not referenced
Change-Id: Ica5835575222e96abc02132734b1e354d696ae35
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
mojahidi [Thu, 28 Dec 2017 12:20:41 +0000 (17:50 +0530)]
Fixed sonar issues - VersionedVendorSoftwareProd
Fixed all sonar issues
Change-Id: Ibf766225a961e11249fbcebe8115b5426f521a83
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 13:19:33 +0000 (18:49 +0530)]
Fix Sonar issues- ComponentDaoZusammenImpl
Fixed reported sonar issue
Change-Id: Ieda1568b4b20cdaaee47534cbfc0c73bfcca393c
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 13:05:21 +0000 (18:35 +0530)]
Fix Sonar - ComponentArtifactDaoZusammenImpl
Fixed reported sonar issues
Change-Id: I1d74c641d65d47a7ab810bef94b77ef3a55cd071
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
mojahidi [Wed, 3 Jan 2018 12:38:10 +0000 (18:08 +0530)]
ComponentMonitoringForSwaggerFileUpload
Deleted unused interface
Change-Id: I039024b7bd77dca735bdd644da657aa05110b5c8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 3 Jan 2018 12:28:37 +0000 (17:58 +0530)]
deleted unused interface - ComponentUploads
Deleted unused interface
Change-Id: I4793c5486c18ed9ff74f9f70fd079dd5a78fb32b
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
ayalaben [Wed, 3 Jan 2018 06:38:27 +0000 (08:38 +0200)]
Unit Tests
Change-Id: I39ee00e80475aa93b0f99a350b56754c31c6e9b6
Issue-ID: SDC-860
Signed-off-by: ayalaben <ayala.benzvi@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 10:46:01 +0000 (16:16 +0530)]
Fix Sonar violations - ValidationManagerUtil
Fixed reported sonar issues by adding private constructor
Change-Id: I544dcdb7385ce8cf750f5f93695460365cc0e78f
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
miriame [Tue, 2 Jan 2018 13:35:55 +0000 (15:35 +0200)]
select item from workspace- skipping versions page
Change-Id: Iebd3bb33703c2d47265ba133f7b74ec961ba8b2f
Issue-ID: SDC-864
Signed-off-by: miriame <miriam.eini@amdocs.com>
mojahidi [Thu, 28 Dec 2017 13:03:00 +0000 (18:33 +0530)]
fix MIB assignment
Assign mib file to all of the components from the same VFC type
Change-Id: Ia6a1a5a08b7383ec64ace085193b0c8daa399c7f
Issue-ID: SDC-811
Signed-off-by: talio <tali.orenbach@amdocs.com>
shalomb [Tue, 2 Jan 2018 11:48:40 +0000 (13:48 +0200)]
Remove Zusammen cassandra plugin
Remove Zusammen cassandra plugin
Change dependency
Modify imports
Change-Id: Ice66fdd9f3970961723df476c8d1e38040504189
Issue-ID: SDC-862
Signed-off-by: shalomb <shalomb@amdocs.com>
ayalaben [Tue, 2 Jan 2018 09:25:39 +0000 (11:25 +0200)]
Unit Tests
Change-Id: I6b863f3762eaad4f17967d77fc5ad64b23ee9d3a
Issue-ID: SDC-860
Signed-off-by: ayalaben <ayala.benzvi@amdocs.com>
mojahidi [Thu, 28 Dec 2017 13:03:00 +0000 (18:33 +0530)]
Fixed sonar issues - VersionedVendorSoftwareProduc
Fixed all sonar issues except exception handling and newly introduced in collaboration merge
Change-Id: I9d9292411cd9f7ffb32aa284a5d63c86bb01b56d
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shrek2000 [Sun, 31 Dec 2017 08:32:59 +0000 (10:32 +0200)]
sonar issue fix - exception handling
remove exception handling which does nothing to handle the error
Issue-ID: SDC-835
Change-Id: I45e0bc203e15b41f907641bfda130f20e1f00f54
Signed-off-by: shrek2000 <orenkle@amdocs.com>
avigaffa [Sun, 31 Dec 2017 13:07:39 +0000 (15:07 +0200)]
Fixing sonar Exception Handling
Change-Id: I04eb047973a3f5c07dd9dc410cb13af974e8ded1
Issue-ID: SDC-810
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
talig [Mon, 1 Jan 2018 12:52:01 +0000 (14:52 +0200)]
Remove onboarding BE redundant healers
Change-Id: I6b849608e64f88c6b91b1bc772fdb33aaa7e8245
Issue-ID: SDC-845
Signed-off-by: talig <talig@amdocs.com>
talig [Mon, 1 Jan 2018 11:07:47 +0000 (13:07 +0200)]
Fix sonar issues + tests in versioning lib
Change-Id: Ib49288fe49be1e848b9615e548689cdbe0df4fee
Issue-ID: SDC-779
Signed-off-by: talig <talig@amdocs.com>
Michael Lando [Sun, 31 Dec 2017 11:26:46 +0000 (13:26 +0200)]
sonar plug in test
Change-Id: I804066364ce8ab3fba36c3e5a39fbbd4c1e397af
Issue-ID: SDC-776
Signed-off-by: Michael Lando <ml636r@att.com>
ayalaben [Sun, 31 Dec 2017 15:57:36 +0000 (17:57 +0200)]
Fix Owner Healer
Change-Id: I85371b7cd6e2fa6e929b42b4773eef685252bcff
Issue-ID: SDC-837
Signed-off-by: ayalaben <ayala.benzvi@amdocs.com>
vempo [Sun, 31 Dec 2017 09:23:20 +0000 (11:23 +0200)]
Default ctor and styling in HealingEntity
Change-Id: I489ecbf4cd3789febe3ff56e11c1db31bf5e1d89
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Sun, 31 Dec 2017 09:12:53 +0000 (11:12 +0200)]
Default ctors in notification-api module
Change-Id: I823348c05a367ed876a63aaa146a98d1cb869cd8
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
Abhai Singh [Thu, 28 Dec 2017 12:19:51 +0000 (17:49 +0530)]
Fix Sonar issues ResourceBaseValidator
Fixed few reported sonar issues.
One sonar issue is ignored as it would involve change
in method signature of public method
Change-Id: Ib0c97ebce5b05dcc0e7dd3d46f25557cc51c31d8
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Thu, 28 Dec 2017 13:43:06 +0000 (19:13 +0530)]
Fix Sonar violations - ValidationTestUtil
Fixed few reported sonar issues.
One sonar issue related to exception handling
is ignored as it would be fixed later
Change-Id: I316868b2f6634e8858696e87604e73de7c8d5e40
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Thu, 28 Dec 2017 13:56:59 +0000 (19:26 +0530)]
Fix Sonar violations - ValidationUtil
Fixed few reported sonar issues.
Fixed as per review comment
Change-Id: Id3cbdcefe120eb9d807f7b66e1b0f329881ef658
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Thu, 28 Dec 2017 13:01:52 +0000 (18:31 +0530)]
Fix Sonar violations - Validator
Fixed few reported sonar issues.
One sonar issue is ignored as am not sure if
this qualifies to be a functionalInterface
Change-Id: I7b9f4faa4e8359c644f7473d7937c82357f576fd
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Idan Amit [Fri, 29 Dec 2017 07:40:43 +0000 (09:40 +0200)]
SDC Designers Integration - Part 1
Finished first part of designers integration
Added templated configuration file
Added tests
Change-Id: I76e8b413063b939e1eb58da4a5502c4b526168f2
Issue-ID: SDC-687
Signed-off-by: Idan Amit <ia096e@intl.att.com>
mojahidi [Thu, 28 Dec 2017 12:07:41 +0000 (17:37 +0530)]
Fixed sonar issues - ComponentDependencyTracker
Fixed all sonar issues
Change-Id: I6a6ab4217964a8071af86e090570f8cb4a8dc122
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Michael Lando [Sun, 31 Dec 2017 07:57:46 +0000 (09:57 +0200)]
update simulator
Change-Id: I9d3bca6a4d0a4f258094c409a1a4f6df3521030f
Issue-ID: SDC-832
Signed-off-by: Michael Lando <ml636r@att.com>
ayalaben [Wed, 27 Dec 2017 10:05:35 +0000 (12:05 +0200)]
Add Item Owner to item
Change-Id: I91ce289159057bd5c179c64131d74a24aa83ac9f
Issue-ID: SDC-800
Signed-off-by: ayalaben <ayala.benzvi@amdocs.com>
vempo [Fri, 29 Dec 2017 13:36:35 +0000 (15:36 +0200)]
Fixed default constructor in config-lib module
Change-Id: Iae1758b963141df4f6369672d219348242ec796e
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 13:56:25 +0000 (15:56 +0200)]
Default constructors in nosqldb-api module
Change-Id: I94f0828f73ad68c844bd984f04aa5d11e8cda1e7
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 13:51:46 +0000 (15:51 +0200)]
Default constructors in versioning-api module
Change-Id: If43c648f094a7717871bbe5322e61254e2ce23c2
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 14:02:49 +0000 (16:02 +0200)]
Default constructors in action-api module
Change-Id: I0ac01140d94cd55e6e15eabe00361a14866aa43f
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 14:22:45 +0000 (16:22 +0200)]
Default constructors in activity-log-api module
Change-Id: Ibf61aaae8a8023b528eac5982e1488c26060a3e1
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 14:28:00 +0000 (16:28 +0200)]
Default constructors in model-api module
Change-Id: I9db997ab2ffc21aa6d6a31e9248aba65672da0ad
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 14:59:26 +0000 (16:59 +0200)]
Default constructors in vendor-license-api module
Change-Id: I27d68b0e9d2eb73e044a11433358f697d692cd4a
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 15:05:21 +0000 (17:05 +0200)]
Default ctors in vendor-software-product module
Change-Id: I7e852d649c56d6c25f68d9e20c1682f4c3deca0a
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
mojahidi [Thu, 28 Dec 2017 12:13:47 +0000 (17:43 +0530)]
Fixed sonar issues - ItemProperties
Fixed all sonar issues
Change-Id: Iccf3bd86156ece8d3dbc719f7fe40b8356b2710e
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Thu, 28 Dec 2017 12:10:55 +0000 (17:40 +0530)]
Fixed sonar issues - ConfigConstants
Fixed all sonar issues
Change-Id: I2b7657076aa2a296531a0c3677777ea6001102c4
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 09:40:20 +0000 (15:10 +0530)]
Refactored as discussed - OrchestrationUtil
Remvoed exception handling and Constructor fix
Change-Id: I6a97f31d429848fa3c008892c48358bc7f67536a
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 15:00:32 +0000 (20:30 +0530)]
Fix sonar issues -HeatToToscaUtil
Changed as per comments provided
Change-Id: I4787b99b2a8629dbf2c1a68995546e185778f5e8
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
avigaffa [Thu, 28 Dec 2017 07:34:47 +0000 (09:34 +0200)]
Fixing sonar Exception Handling
Change-Id: I0afe103b921ea26de8f701e9a2cff7943ab58110
Issue-ID: SDC-810
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
vempo [Thu, 28 Dec 2017 15:12:44 +0000 (17:12 +0200)]
Fixed broken mapping of ChoiceOrOther
ChoiceOrOther needs default constructor to be recreated by reflection
Change-Id: I194ced8b5e6a60f0dbe6f9b73715cd36c70f5163
Issue-ID: SDC-830
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
mojahidi [Wed, 27 Dec 2017 10:28:32 +0000 (15:58 +0530)]
Fixed sonar issues - OrchestrationUploadFactory
Fixed all sonar issues except exception handling
Change-Id: I694a37df40ef05a6217d2f6db41cd7b15ba1e10e
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 12:44:02 +0000 (18:14 +0530)]
Refactored - ProcessManagerImpl
Refactored as per given comment
Change-Id: I366fc8ac93ce977143adbc3a4698ed5f11010405
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 12:25:08 +0000 (17:55 +0530)]
Fixing sonar qube issues
Refactor code as per review comment.
Change-Id: I49f566c7babebf395a689846734f4932f150a9f8
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 11:09:18 +0000 (16:39 +0530)]
Fixing sonar qube issues
Refactor code as per review comment.
Change-Id: I5419848dd28e1c2276c995308dcdff55c624dd8b
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
mojahidi [Thu, 28 Dec 2017 05:09:55 +0000 (10:39 +0530)]
Fixed sonar issues - ImageManagerImpl
Fixed all sonar issues and refactored as per given comment
Change-Id: I86ec2ac3f72eae3fea5291664865a1c3b4c57791
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 15:00:32 +0000 (20:30 +0530)]
Fix Sonar violations - ConfigurationDataSource
1. Fixed major sonar violations configuration management core
- ConfigurationDataSource
Change-Id: Iee96111b3051a67d25f99a0ba49e99f4d9290345
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 14:38:14 +0000 (20:08 +0530)]
Fix Sonar violations - AggregateConfiguration
1. Fixed major sonar violations configuration management core
- AggregateConfiguration
Change-Id: I311d0e84fbfaf936ec1a260898e0cc0090e05be9
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 14:45:17 +0000 (20:15 +0530)]
Fix Sonar violations - ConfigurationRepository
1. Fixed major sonar violations configuration management core
- ConfigurationRepository
Change-Id: Iab756af7ffae63fe9e644d733225908d121cbd9a
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 14:17:44 +0000 (19:47 +0530)]
Fix Sonar violations - AgglomerateConfiguration
1. Fixed major sonar violations configuration management core
- AgglomerateConfiguration
Change-Id: I1f79df3a1d256aeb45b82d344c507d40f6b83026
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 10:16:30 +0000 (15:46 +0530)]
Fixing sonar qube issues
Refactoring the code as per review comments.
Change-Id: I1edd457f8d0989f815cbf3f28fa0a5124a8c4ac7
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
shrek2000 [Wed, 27 Dec 2017 14:09:34 +0000 (16:09 +0200)]
sonar issue fix - remove dead code
remove dead code.
Issue-ID: SDC-804
Change-Id: I1bae8d3d338730dfad72b155eacebc8e1f5c838f
Signed-off-by: shrek2000 <orenkle@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 14:05:46 +0000 (19:35 +0530)]
Fix Sonar violations - ConfigurationFilter
1. Fixed major sonar violations configuration management core
- ConfigurationFilter
Change-Id: I6fa69a894854026c32ab7e81d7c3749c7bd16841
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
sheetalm [Wed, 27 Dec 2017 08:17:10 +0000 (13:47 +0530)]
Fixed sonar issues - YamlUtil
Fixed violations and Added Copyright. Created constants
Change-Id: I061ed453ed3706410b49774ee2bd0572a1c3a36f
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 09:58:38 +0000 (15:28 +0530)]
Fix sonar issues - Common Methods
Junit and Logger removed
Change-Id: Ic1a987600a8a5ab8c236be242f0f0cd12faf9624
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
talio [Wed, 27 Dec 2017 10:59:05 +0000 (12:59 +0200)]
Add tests
Add unit tests for ToscaTreeManager
Change-Id: I772b63799cd34b687e6c81cb235c1c9a36ad34a2
Issue-ID: SDC-802
Signed-off-by: talio <tali.orenbach@amdocs.com>
mojahidi [Wed, 27 Dec 2017 13:06:28 +0000 (18:36 +0530)]
Fixed sonar issues - OrchestrationTemplateCandidat
Fixed all sonar issues
Change-Id: I3490d2299053475e79354526a854be99ebc5b9de
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
avigaffa [Wed, 27 Dec 2017 12:42:46 +0000 (14:42 +0200)]
Validate notification framework called in test
Call to ItemPermissionsManagerImplTest
Change-Id: I8b1f0e42c0f7b4ebf821f18e9fbbb801f95052c9
Issue-ID: SDC-803
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
mojahidi [Wed, 27 Dec 2017 12:39:24 +0000 (18:09 +0530)]
Fixed sonar issues - NetworkManagerImpl
Fixed all sonar issues
Change-Id: I0baf7c56a68b60a8635dd88638a287098e685b31
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 10:51:50 +0000 (16:21 +0530)]
Fixing sonar qube issues
Removed commented code from MapValidationFileResponseToValidationFileResponseDto file.
Change-Id: I03eca70fe5bc6dfed8ca7762b298e8f83f2ee628
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
mojahidi [Wed, 27 Dec 2017 12:17:14 +0000 (17:47 +0530)]
Fixed sonar issues - MonitoringUploadsManagerImpl
Fixed all sonar issues except exception handling
Change-Id: I799c2d485b509469f6b58b36654b2ee71d97f8c6
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 09:16:35 +0000 (14:46 +0530)]
Refactored as per given comment
Removed exception handling fixes
Change-Id: Ie5a89783a63ebcf4b404db4f2b8be2c7b2140e50
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 11:54:18 +0000 (17:24 +0530)]
Fixed sonar issues - ComputeManagerImpl
Fixed all sonar issues
Change-Id: I04a06aadcf5b142334f571949b22778fa393fcc8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 11:46:54 +0000 (17:16 +0530)]
Fixed sonar issues - ComponentManagerImpl
Fixed all sonar issues
Change-Id: I2cc957cea740c2410c6b5d98e3335a3b1c1684e1
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 05:48:42 +0000 (11:18 +0530)]
Fixed sonar issues - NotSupportedHeatOnboardMethod
Fixed all sonar issues
Change-Id: I877e1bdccf63a20a618dabfa9176d94cf023d2b8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 05:18:24 +0000 (10:48 +0530)]
Fix sonar issues
Removed default constructor and changed few access modifier
Change-Id: Ibc669a1e8973fd6d7f90e474554b4701d1db4c57
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 08:24:27 +0000 (13:54 +0530)]
Fix sonar issues - TranslationContext
Code refactor and variable name change
Change-Id: I528be906feb5255d1b34ed30c7a287ae0d6bb29c
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
shrek2000 [Wed, 27 Dec 2017 12:24:00 +0000 (14:24 +0200)]
Sonar issue Dix - Session is closeable
Cassandra session is closeable and should be protected by try block
Issue-ID: SDC-801
Change-Id: Ib2cc178e029dce1915e2931fe58e4a5d6527dd5f
Signed-off-by: shrek2000 <orenkle@amdocs.com>
sheetalm [Wed, 27 Dec 2017 10:14:02 +0000 (15:44 +0530)]
Fixed sonar issues ToscaFileOutputServiceCsarImpl
Remove unwanted parenthesis. Corrected Copyright
Change-Id: If7cb2a722aa486156d6dc2c1fb90877d0442b3a6
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
mojahidi [Wed, 27 Dec 2017 10:41:01 +0000 (16:11 +0530)]
Fixed sonar issues - DeploymentFlavorManagerImpl
Fixed all sonar issues
Change-Id: Ied0cf9f1d5aac4fb97f7fc09bf3233cb5304c4c3
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Code Review / sdc.git / log