policy/drools-applications.git
3 years agoRefer to released versions drools-apps 95/110095/1
Jim Hahn [Thu, 9 Jul 2020 13:41:47 +0000 (09:41 -0400)]
Refer to released versions drools-apps

Issue-ID: POLICY-2695
Change-Id: I2127501c4ac5472409570a7182209eded5b0f644
Signed-off-by: Jim Hahn <jrh3@att.com>
3 years agoFIX context URI and https to false. 38/110038/3
uj426b [Thu, 9 Jul 2020 21:34:04 +0000 (17:34 -0400)]
FIX context URI and https to false.

Change-Id: Iffecc4655d22b507188ea266e82046f2a82751e8
Issue-ID: POLICY-2703
Signed-off-by: uj426b <uj426b@att.com>
3 years agomodify jmx script to accommodate json changes 85/109985/1
jhh [Wed, 8 Jul 2020 18:48:07 +0000 (13:48 -0500)]
modify jmx script to accommodate json changes

Issue-ID: POLICY-2705
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iea6ea806855f5887e9a6206aa966746d822c3679

3 years agofix complete the assertion 61/109861/1
Taka Cho [Mon, 6 Jul 2020 16:02:45 +0000 (12:02 -0400)]
fix complete the assertion

add isInstanceOf for assertThatThrownBy.

Issue-ID: POLICY-2616
Change-Id: If49255aec6004870d7d2acfeabe258def872c1fa
Signed-off-by: Taka Cho <takamune.cho@att.com>
3 years agoUse new Actor names in drools-apps 05/109805/1
Jim Hahn [Wed, 1 Jul 2020 20:13:46 +0000 (16:13 -0400)]
Use new Actor names in drools-apps

Modified drools-apps to use XxxActor instead of XxxActorServiceProvider.
This is the second step of the rename.

Issue-ID: POLICY-2684
Change-Id: Iea60e92f914b7719ac765b086650479be9192d98
Signed-off-by: Jim Hahn <jrh3@att.com>
3 years agoMerge "Updating drools applications dependencies"
Jorge Hernandez [Thu, 2 Jul 2020 12:43:43 +0000 (12:43 +0000)]
Merge "Updating drools applications dependencies"

3 years agoUpdating drools applications dependencies 91/109691/3
RossC [Tue, 30 Jun 2020 14:24:08 +0000 (15:24 +0100)]
Updating drools applications dependencies

Issue-ID: POLICY-2387
Change-Id: I1c3ee615f0a72a9e7cec8ccc573e27a0cbe3f02c
Signed-off-by: RossC <ross.carter@est.tech>
3 years agosonar issue - drools apps 62/109662/2
Taka Cho [Mon, 29 Jun 2020 21:12:35 +0000 (17:12 -0400)]
sonar issue - drools apps

- elevate the visibility of readResolve
- test case without assertions

Issue-ID: POLICY-2616
Change-Id: Ifde4b8c5e1281f8625a1203858fbe0467defe353
Signed-off-by: Taka Cho <takamune.cho@att.com>
3 years agoFix build breakage in drools-apps due to pair 63/109663/1
Jim Hahn [Mon, 29 Jun 2020 21:43:07 +0000 (17:43 -0400)]
Fix build breakage in drools-apps due to pair

The Pair changes made in drools-pdp also broke drools-apps builds.
Replaced usage of drools.utils.Pair with apache Pair.

Issue-ID: POLICY-2202
Change-Id: I50aaad47c243637688602ae6cb680a929fe3edd9
Signed-off-by: Jim Hahn <jrh3@att.com>
3 years agocontrolloop m2 sonar fix 06/109606/4
Taka Cho [Fri, 26 Jun 2020 15:47:18 +0000 (11:47 -0400)]
controlloop m2 sonar fix

- remove some unused statement
- remove unnecessary check

Issue-ID: POLICY-2616
Change-Id: Ieb2c898a3c6ad7210642aef990b43c9a01fc15b3
Signed-off-by: Taka Cho <takamune.cho@att.com>
3 years agoFix build error from Pair changes 20/109620/1
Jim Hahn [Fri, 26 Jun 2020 22:56:35 +0000 (18:56 -0400)]
Fix build error from Pair changes

This is a quick fix to get around a build error in drools-applications
due to "Pair" changes made in policy-common and/or policy-models.

Issue-ID: POLICY-2202
Change-Id: If1cb60947e55d97ef7cfb1d05d69e07c54c71a05
Signed-off-by: Jim Hahn <jrh3@att.com>
3 years agom2 sonar fix 05/109605/2
Taka Cho [Fri, 26 Jun 2020 15:35:12 +0000 (11:35 -0400)]
m2 sonar fix

- "get" returns a string already
- to avoid sonar issue for duplicated strings
- formating

Issue-ID: POLICY-2616
Change-Id: I1fac65bba5ecb402c784dd585ebcd7992cf31545
Signed-off-by: Taka Cho <takamune.cho@att.com>
3 years agoUse parent snapshot in drools-apps 77/109577/4
Jim Hahn [Thu, 25 Jun 2020 15:12:36 +0000 (11:12 -0400)]
Use parent snapshot in drools-apps

Fixed checkstyle issues that were subsequently reported.
Also fixed a few eclipse warnings.
Also fixed some of the sonar issues in the files that were touched:
- use "{}" in logger calls
- camelcase method names
- use "<?>" instead of generics
- add serialization ID

Issue-ID: POLICY-2188
Change-Id: I5c94a2e26dd74a61a0a919e1c3da17ab02a5bc9d
Signed-off-by: Jim Hahn <jrh3@att.com>
3 years agoChanges for checkstyle 8.32 77/109377/1
Jim Hahn [Fri, 19 Jun 2020 20:44:04 +0000 (16:44 -0400)]
Changes for checkstyle 8.32

Issue-ID: POLICY-2188
Change-Id: Ib90222c537c5440e0de52fa0acbaa99bbcc4772a
Signed-off-by: Jim Hahn <jrh3@att.com>
3 years agofix sonar for m2/base - 2 95/109195/5
Taka Cho [Tue, 16 Jun 2020 13:42:10 +0000 (09:42 -0400)]
fix sonar for m2/base - 2

- unused import
- Hide Utility Class Constructor : Utility classes
  should not have a public or default constructor

Issue-ID: POLICY-2616
Change-Id: I338a739b6e9fb5f4b47898566362b8a87201dae3
Signed-off-by: Taka Cho <takamune.cho@att.com>
3 years agoMerge "m2 sonar issues"
Ram Krishna Verma [Wed, 17 Jun 2020 21:24:50 +0000 (21:24 +0000)]
Merge "m2 sonar issues"

3 years agom2 sonar issues 67/109267/2
Taka Cho [Wed, 17 Jun 2020 14:45:59 +0000 (10:45 -0400)]
m2 sonar issues

- unused import
- logger format
- Extract the assignment out of this expression
- Replace this if-then-else statement
  by a single return statement

Issue-ID: POLICY-2616
Change-Id: I2d04569a7070f79fc8979274bce2b87b4b2f3e24
Signed-off-by: Taka Cho <takamune.cho@att.com>
3 years agoMerge "fix sonar issue for m2/base"
Jorge Hernandez [Wed, 17 Jun 2020 15:30:01 +0000 (15:30 +0000)]
Merge "fix sonar issue for m2/base"

3 years agom2/appclcm sonar issue fix 13/109213/1
Taka Cho [Tue, 16 Jun 2020 18:08:33 +0000 (14:08 -0400)]
m2/appclcm sonar issue fix

swap the arguments
use assertNull

Issue-ID: POLICY-2616
Change-Id: Id5bd0b7acd0914566dfdebdb42fdcaabf9eb3012
Signed-off-by: Taka Cho <takamune.cho@att.com>
3 years agofix sonar issue for m2/base 77/109177/3
Taka Cho [Mon, 15 Jun 2020 20:55:00 +0000 (16:55 -0400)]
fix sonar issue for m2/base

-using {} in logger in stead
-diamond operator (<>) to reduce
 the verbosity of generics code.
-rename this method name to match
 the regular expression '^[a-z][a-zA-Z0-9]*$'

Issue-ID: POLICY-2616
Change-Id: I8e722af52b08382ca53190a33a3a27ad1e7d4830
Signed-off-by: Taka Cho <takamune.cho@att.com>
3 years agoMerge "change audit and metric formats in feature-controlloop-trans"
Jorge Hernandez [Tue, 16 Jun 2020 15:42:56 +0000 (15:42 +0000)]
Merge "change audit and metric formats in feature-controlloop-trans"

3 years agochange audit and metric formats in feature-controlloop-trans 89/108989/5
Joseph Chou [Tue, 9 Jun 2020 18:14:56 +0000 (14:14 -0400)]
change audit and metric formats in feature-controlloop-trans

logging enhancement

Issue-ID: POLICY-2579
Change-Id: Id1e0230d3cd2ac6d921be86f127f3721c65f3e52
Signed-off-by: Joseph Chou <jc2555@att.com>
3 years agoRemove deprecated actor properties 65/109165/1
Jim Hahn [Mon, 15 Jun 2020 15:23:48 +0000 (11:23 -0400)]
Remove deprecated actor properties

Now that the actor change has been merged, the deprecated properties
can be removed from drools-apps.  Done.

Issue-ID: POLICY-2632
Change-Id: If4dafc489c32da4dfccd6ebac97e8e7beac2454d
Signed-off-by: Jim Hahn <jrh3@att.com>
3 years agoMerge "Adjust properties in anticipation of actor changes"
Ram Krishna Verma [Mon, 15 Jun 2020 13:44:28 +0000 (13:44 +0000)]
Merge "Adjust properties in anticipation of actor changes"

3 years agoAdjust properties in anticipation of actor changes 29/109129/1
Jim Hahn [Fri, 12 Jun 2020 22:05:31 +0000 (18:05 -0400)]
Adjust properties in anticipation of actor changes

Issue-ID: POLICY-2632
Change-Id: I4d20fe6b46432298ba796fe978796d5d74e1eb14
Signed-off-by: Jim Hahn <jrh3@att.com>
3 years agoClean up to remove controlloop.simulator.env 27/109127/1
uj426b [Fri, 12 Jun 2020 19:52:05 +0000 (15:52 -0400)]
Clean up to remove controlloop.simulator.env

Change-Id: Ic336eb24f1f3ecda359f07714e59f075596cc105
Issue-ID: POLICY-2555
Signed-off-by: uj426b <uj426b@att.com>
3 years agoMerge "Remove deprecated properties for CDS and VFC"
Liam Fallon [Fri, 12 Jun 2020 14:14:09 +0000 (14:14 +0000)]
Merge "Remove deprecated properties for CDS and VFC"

3 years agoMerge "sonar issue drools applications - 3"
Pamela Dragosh [Fri, 12 Jun 2020 13:49:26 +0000 (13:49 +0000)]
Merge "sonar issue drools applications - 3"

3 years agoRemove deprecated properties for CDS and VFC 75/109075/4
Jim Hahn [Thu, 11 Jun 2020 19:33:32 +0000 (15:33 -0400)]
Remove deprecated properties for CDS and VFC

Now that the changes to the Actors have been merged, the former properties
can be removed, too.
Also fixed guard operator/operation name since it changed from "Guard"
to "Decision".

Issue-ID: POLICY-2629
Change-Id: I1c8d4575be598a8cab12b1aa4ad9b1d3e1f12113
Signed-off-by: Jim Hahn <jrh3@att.com>
3 years agoMerge "Match property changes to CDS and VFC actors"
Ram Krishna Verma [Thu, 11 Jun 2020 16:04:57 +0000 (16:04 +0000)]
Merge "Match property changes to CDS and VFC actors"

3 years agoMerge "sonar issue drools-application - 2"
Ram Krishna Verma [Wed, 10 Jun 2020 22:16:59 +0000 (22:16 +0000)]
Merge "sonar issue drools-application - 2"

3 years agoMerge "reduce sonar issue - drool-applications"
Ram Krishna Verma [Wed, 10 Jun 2020 22:16:48 +0000 (22:16 +0000)]
Merge "reduce sonar issue - drool-applications"

3 years agoMatch property changes to CDS and VFC actors 29/109029/1
Jim Hahn [Wed, 10 Jun 2020 21:49:23 +0000 (17:49 -0400)]
Match property changes to CDS and VFC actors

An "operations" level is being added to the properties for the
CDS and VFC actor.  Added the new properties; the old ones can
be deleted once the change to the actors has been merged.

Issue-ID: POLICY-2629
Change-Id: Ib0bb3f62d6a2d3380aa6ec5a6e8b61ddd0a44c00
Signed-off-by: Jim Hahn <jrh3@att.com>
3 years agosonar issue drools applications - 3 22/109022/3
Taka Cho [Wed, 10 Jun 2020 14:48:42 +0000 (10:48 -0400)]
sonar issue drools applications - 3

get already returns string
redudant return block
unused import
swap expected argument
use equals method instead
useless assignment for payload

Issue-ID: POLICY-2616
Change-Id: Ie4f07085994420b7ea3f39db89f980f6594f01b7
Signed-off-by: Taka Cho <takamune.cho@att.com>
3 years agosonar issue drools-application - 2 91/108991/1
Taka Cho [Tue, 9 Jun 2020 18:51:11 +0000 (14:51 -0400)]
sonar issue drools-application - 2

fixed some sonar issues: removed empty method,
put expected value in the 1st argument

Change-Id: I86747938187abda34e9ab41b735d55fbf920ecd8
Issue-ID: POLICY-2616
Signed-off-by: Taka Cho <takamune.cho@att.com>
3 years agoMerge "Fix VFC actor properties"
Jorge Hernandez [Tue, 9 Jun 2020 18:20:45 +0000 (18:20 +0000)]
Merge "Fix VFC actor properties"

3 years agoMerge "Changes for feature-controlloop-util actor conf."
Ram Krishna Verma [Tue, 9 Jun 2020 17:25:51 +0000 (17:25 +0000)]
Merge "Changes for feature-controlloop-util actor conf."

3 years agoreduce sonar issue - drool-applications 82/108982/1
Taka Cho [Tue, 9 Jun 2020 16:04:20 +0000 (12:04 -0400)]
reduce sonar issue - drool-applications

In some conditions for assertTrue, sonarcloud
recommends using assertEquals

Assert.assertTrue(a.equals(b));
Assert.assertTrue(a == b);
Assert.assertTrue(a == null);
Assert.assertTrue(a != null);
Assert.assertFalse(a.equals(b));

Compliant Solution

Assert.assertEquals(a, b);
Assert.assertSame(a, b);
Assert.assertNull(a);
Assert.assertNotNull(a);
Assert.assertNotEquals(a, b);

Change-Id: Ic50bf6e961b74abcc698c2cc0347dd0472fefe71
Issue-ID: POLICY-2616
Signed-off-by: Taka Cho <takamune.cho@att.com>
3 years agoChanges for feature-controlloop-util actor conf. 48/108748/7
uj426b [Wed, 3 Jun 2020 19:17:07 +0000 (15:17 -0400)]
Changes for feature-controlloop-util actor conf.

Change-Id: I5b48d716dcb17082ad376de1e1fe58b2f4ea4130
Issue-ID: POLICY-2555
Signed-off-by: uj426b <uj426b@att.com>
3 years agoFix VFC actor properties 86/108786/3
Jim Hahn [Thu, 4 Jun 2020 21:08:27 +0000 (17:08 -0400)]
Fix VFC actor properties

The VFC actor doesn't have the same property structure as the
other actors, which meant that the properties listed in the file
were incorrect.  Fixed them.
Renamed the operation to "Restart" per review comments.

Issue-ID: POLICY-2407
Change-Id: Icb8ccad518d01a5f23253a9835976eae666566f4
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoMerge "Use OperationsHistory from models"
Pamela Dragosh [Tue, 2 Jun 2020 17:29:10 +0000 (17:29 +0000)]
Merge "Use OperationsHistory from models"

4 years agoUse actor constants instead of literals 33/108633/2
Jim Hahn [Mon, 1 Jun 2020 16:32:10 +0000 (12:32 -0400)]
Use actor constants instead of literals

Modified drools-apps to use constants from the actor classes instead
of hard-coded literals.  Only made this change in code that uses the
new actor model, as the old code will be deleted during this release.

Issue-ID: POLICY-1242
Change-Id: Iac718159fd7cf571a48ac620585bf2b8f94c1e5d
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoUse OperationsHistory from models 32/108632/2
Jim Hahn [Fri, 29 May 2020 15:59:53 +0000 (11:59 -0400)]
Use OperationsHistory from models

Deleted Dbao and replaced it with the shared class in policy-models.
Also had to update the queries and the persistence.xml accordingly.
Note: with this change, the "database" project is no longer needed,
so it was deleted.

Issue-ID: POLICY-2581
Change-Id: Idfde68b28b3a27f2ee794fa477d15e0f12717373
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoUse default serialization provider 88/108588/1
Jim Hahn [Fri, 29 May 2020 19:20:25 +0000 (15:20 -0400)]
Use default serialization provider

The default provider has been changed to gson, so the provider property
no longer has to be set.

Issue-ID: POLICY-1527
Change-Id: I9b555ed3c3b735ca9622314e1ca06476416bae6e
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoGenerate SDNR notification in drools-apps 14/108414/1
Jim Hahn [Wed, 27 May 2020 21:57:51 +0000 (17:57 -0400)]
Generate SDNR notification in drools-apps

Modified drools-apps to generate the SDNR notification using the
SDNR-response provided by the actor in the operation outcome, instead of
using the controlloop-response provided in the operation outcome, as the
latter is deprecated.

Issue-ID: POLICY-2593
Change-Id: I70ee4a4b11345a4295d720250a63f407f51cb0bd
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoMerge "Do additional processing when control loop times out"
Liam Fallon [Thu, 28 May 2020 09:15:38 +0000 (09:15 +0000)]
Merge "Do additional processing when control loop times out"

4 years agoDo additional processing when control loop times out 57/108357/1
Jim Hahn [Fri, 22 May 2020 21:28:22 +0000 (17:28 -0400)]
Do additional processing when control loop times out

When the overall control loop times out, a notification is sent to
POLICY-CL-MGT, but then the event is discarded.  Modified the code
to update the operation history, if an operation had been started,
and to generate an SDNR notification, if appropriate.
Applied the same logic for when a lock is lost.

Issue-ID: POLICY-2582
Change-Id: I35510ec8a3cfc6b2ca9be5751896f3c0f7d9bd09
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoUse snapshot versions 58/108358/1
Jim Hahn [Wed, 27 May 2020 21:23:10 +0000 (17:23 -0400)]
Use snapshot versions

Issue-ID: POLICY-1526
Change-Id: I999d0aff7c76ad01e4cec65cb44a165a42259ca0
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoMerge "Generate SDNR notification even on timeout"
Ram Krishna Verma [Tue, 26 May 2020 15:48:51 +0000 (15:48 +0000)]
Merge "Generate SDNR notification even on timeout"

4 years agoBump Drools-Apps to 1.7.0 58/108258/1
a.sreekumar [Tue, 26 May 2020 13:18:14 +0000 (14:18 +0100)]
Bump Drools-Apps to 1.7.0

Change-Id: I1b4b088d276da6aae3b577102470a6d8e3dcdc6a
Issue-ID: POLICY-2514
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
4 years agoBump drools-applications to 1.6.5 34/108234/1
a.sreekumar [Tue, 26 May 2020 12:37:53 +0000 (13:37 +0100)]
Bump drools-applications to 1.6.5

Change-Id: I52c0b421e6ca94153b7f37ae67fdcd086f14f3fa
Issue-ID: POLICY-2514
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
4 years agoGenerate SDNR notification even on timeout 56/108156/1
Jim Hahn [Fri, 22 May 2020 20:05:16 +0000 (16:05 -0400)]
Generate SDNR notification even on timeout

If a request to SDNR times out, the actor class does not generate a
notification for the DCAE_CL_RSP topic.  Rather than modifying the
actor, decided to modify models to handle that case.  Seems like that's
where it belongs anyway, as notifications are more of an application-
level behavior.

Issue-ID: POLICY-2580
Change-Id: Id9426c223b719efce337a604316f19335dae8a94
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoUse "outcome" to indicate pending record 39/108139/5
Jim Hahn [Fri, 22 May 2020 13:06:58 +0000 (09:06 -0400)]
Use "outcome" to indicate pending record

Mariadb is setting the "endtime" to the current time by default,
so rather than indicate a pending record using a null endtime, just
modified the code set "outcome" to "Started" to indicate a pending record.
Also added code to ensure the "outcome" is never null, as that causes
a DB error.
Also addressed a comment from a previous review to log a warning message
if more than one matching record is found in operations history.

Issue-ID: POLICY-2581
Change-Id: I6bf67551cef46808a79cc15afeb0abbfc1b6d945
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoMerge "Insert pending record when operation starts"
Jorge Hernandez [Thu, 21 May 2020 23:27:24 +0000 (23:27 +0000)]
Merge "Insert pending record when operation starts"

4 years agoAdd secondary indices to operationshistory table 09/108109/1
Jim Hahn [Thu, 21 May 2020 21:47:18 +0000 (17:47 -0400)]
Add secondary indices to operationshistory table

Queries to the operationshistory table will degrade substantially
as more records are added to the DB.
The Dbao class should be moved to policy-models, but for now
we'll just update it in both places (i.e., drools-apps and xacml-pdp).

Issue-ID: POLICY-2581
Change-Id: Ic43cefdfd4d353b73d815bd629ef25f3d2b486c6
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoInsert pending record when operation starts 05/108105/2
Jim Hahn [Thu, 21 May 2020 21:04:17 +0000 (17:04 -0400)]
Insert pending record when operation starts

Modified code to insert a pending record when an operation starts.
Also modified it to update the existing record when the operation
completes, rather than adding a new record.
Note: the "outcome" for a "pending" record is left unset (i.e., it
is null).

Issue-ID: POLICY-2581
Change-Id: Ia1a02ed5a16b8af1328a49b22478fd57c4b9aca0
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agorelease 1.6.4 docker container 16/108016/2 6.0.0-ONAP
jhh [Wed, 20 May 2020 22:17:28 +0000 (17:17 -0500)]
release 1.6.4 docker container

Issue-ID: POLICY-2514
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I76daf2eb6ce0526f8295b182b69b59dd23d3b17d
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
4 years agorelease maven artifacts 14/108014/1
jhh [Wed, 20 May 2020 20:51:08 +0000 (15:51 -0500)]
release maven artifacts

Issue-ID: POLICY-2514
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I8d16b1c761e60da4906f5fe9a76fc69a65aa0054

4 years agoPoint to released drools-pdp 09/108009/1
Pamela Dragosh [Wed, 20 May 2020 19:15:43 +0000 (15:15 -0400)]
Point to released drools-pdp

Issue-ID: POLICY-2514
Change-Id: I3d40c6016b9ce4adc95ed7a4e59719e94f9f5b26
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoMerge "add stability test scripts"
Pamela Dragosh [Tue, 19 May 2020 22:56:15 +0000 (22:56 +0000)]
Merge "add stability test scripts"

4 years agoadd stability test scripts 09/107909/3
jhh [Tue, 19 May 2020 18:31:39 +0000 (13:31 -0500)]
add stability test scripts

Issue-ID: POLICY-2456
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I89a325cfc2dedd10936c28176a0e11e5c54f24b4
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
4 years agoMerge "Add getter for ControlLoopPolicy instance in ControlLoopProcessor"
Jorge Hernandez [Tue, 19 May 2020 18:04:31 +0000 (18:04 +0000)]
Merge "Add getter for ControlLoopPolicy instance in ControlLoopProcessor"

4 years agoPoint to released artifacts 95/107895/1
Pamela Dragosh [Tue, 19 May 2020 16:36:44 +0000 (12:36 -0400)]
Point to released artifacts

Issue-ID: POLICY-2514
Change-Id: I10aea2d45c9dae37d7c3c14a82a34da661c3ea60
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoAdd getter for ControlLoopPolicy instance in ControlLoopProcessor 22/107822/1
dc443y [Mon, 18 May 2020 21:34:02 +0000 (16:34 -0500)]
Add getter for ControlLoopPolicy instance in ControlLoopProcessor

This is to allow other frameworks, such as M2, to obtain the
ControlLoopPolicy instance after the raw ToscaPolicy has
been adapted.

Issue-ID: POLICY-2574
Change-Id: I003e60991f6e4007bd30f0e9392f6fa8bf21733a
Signed-off-by: dc443y <dc443y@att.com>
4 years agoDo not encode null fields in SO request 98/107698/1
Jim Hahn [Thu, 14 May 2020 16:15:07 +0000 (12:15 -0400)]
Do not encode null fields in SO request

Currently, the default serialization provider for HTTP clients
is jackson, which encodes null fields in requests.  Unfortunately,
SO does not like the null fields.
Fixed this by modifying the SO config parameters to use the GSON
serialization provider.

Issue-ID: POLICY-2568
Change-Id: I6c2e7c985f23e09940d89409c2a84303bfd54b8a
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoMerge "Handle duplicate events in drools-apps"
Jorge Hernandez [Wed, 13 May 2020 19:56:07 +0000 (19:56 +0000)]
Merge "Handle duplicate events in drools-apps"

4 years agoHandle duplicate events in drools-apps 37/107637/3
Jim Hahn [Wed, 13 May 2020 16:55:37 +0000 (12:55 -0400)]
Handle duplicate events in drools-apps

Modified the frankfurt rules to compare the event objects instead of
comparing the request ID when determining if an event is new.  The
event object's equals() method ignores the request ID when doing the
comparison, thus it will treat an event as a duplicate even if the
request ID is different, which is the behavior we want.

Also removed the @Ignore from the junit that tests for duplicate
events in the hope that this change will fix it.  If the docker build
still breaks, then @Ignore can be added back in.

Issue-ID: POLICY-2557
Change-Id: If2b9fd26473d78a356218b951bfe160f93daeb32
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoMake that SO actor uses http by default 35/107635/1
jhh [Wed, 13 May 2020 15:21:29 +0000 (10:21 -0500)]
Make that SO actor uses http by default

Issue-ID: POLICY-2560
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6cd3de9238793fef671c9e058c494c179d4cb25c

4 years agodelete dependency section in junit test op.pom 00/107400/1
jhh [Fri, 8 May 2020 18:42:11 +0000 (13:42 -0500)]
delete dependency section in junit test op.pom

This is to correct junit failures

Issue-ID: POLICY-2551
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I4522f01a8ed8a66ddcb09549d4281adbcd644ab7

4 years agochange the @api path in rest transactions api 22/106822/2
jhh [Wed, 29 Apr 2020 16:41:25 +0000 (11:41 -0500)]
change the @api path in rest transactions api

Issue-ID: POLICY-2530
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: If21e0607edcf75f491be61012779ddfa5d880105
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
4 years agoMerge "Plain move from test dir to src"
Jorge Hernandez [Tue, 28 Apr 2020 13:54:44 +0000 (13:54 +0000)]
Merge "Plain move from test dir to src"

4 years agoBump drools-apps to 1.6.4-SNAPSHOT 41/106741/1
Pamela Dragosh [Tue, 28 Apr 2020 12:40:52 +0000 (08:40 -0400)]
Bump drools-apps to 1.6.4-SNAPSHOT

Issue-ID: POLICY-2510
Change-Id: Ic431fa80f7b389c84b799f8662df81b4f0ea124f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoPlain move from test dir to src 12/106712/2
jhh [Mon, 27 Apr 2020 23:56:34 +0000 (18:56 -0500)]
Plain move from test dir to src

The file was placed there by mistake.

Issue-ID: POLICY-2456
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I37a0bad7963aa9fe2931d68f5779355471cda345
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
4 years agoRelease drools-apps 1.6.3 docker images 89/106689/1
Pamela Dragosh [Mon, 27 Apr 2020 15:35:30 +0000 (11:35 -0400)]
Release drools-apps 1.6.3 docker images

Issue-ID: POLICY-2510
Change-Id: I1be48970e10b9b536740e98f3d16961e3abb6584
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoRelease drools-apps 1.6.3 java 80/106680/1
Pamela Dragosh [Mon, 27 Apr 2020 13:54:24 +0000 (09:54 -0400)]
Release drools-apps 1.6.3 java

Issue-ID: POLICY-2510
Change-Id: Ie1be4eca3007ab05a613e60235797a5648857fc7
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoBump drools-apps 1.6.3-SNAPSHOT 76/106676/1
Pamela Dragosh [Mon, 27 Apr 2020 12:41:07 +0000 (08:41 -0400)]
Bump drools-apps 1.6.3-SNAPSHOT

Before I can re-release, the patch needs to be bumped.

Issue-ID: POLICY-2510
Change-Id: Ib868d0d72cd28f87b5eb7c233f239d219f699954
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoPoint to released policy/parent 70/106670/1
Pamela Dragosh [Mon, 27 Apr 2020 11:33:27 +0000 (07:33 -0400)]
Point to released policy/parent

Pointing to an unavailable SNAPSHOT

Issue-ID: POLICY-2510
Change-Id: Ibc9743908cf67b58db25dadfa1d2151dd72ace57
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoRelease drools-apps 1.6.2 docker image 30/106630/1
Pamela Dragosh [Fri, 24 Apr 2020 21:42:18 +0000 (17:42 -0400)]
Release drools-apps 1.6.2 docker image

Issue-ID: POLICY-2510
Change-Id: I10b78ee3a07f13cdbcf9e7216c927d4b66fdf14f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoRelease droosl-apps 1.6.2 java 26/106626/1
Pamela Dragosh [Fri, 24 Apr 2020 20:58:17 +0000 (16:58 -0400)]
Release droosl-apps 1.6.2 java

Issue-ID: POLICY-2510
Change-Id: I69552a7989d1af08d4345c2b901a9ba4acd28514
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoPoint to released artifacts 19/106619/1
Pamela Dragosh [Fri, 24 Apr 2020 20:00:28 +0000 (16:00 -0400)]
Point to released artifacts

Issue-ID: POLICY-2510
Change-Id: Ie1c77339f42d990dcd608b8afad7153b04fa24f9
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agotransaction tracking improvements with telemetry 20/106520/3
jhh [Thu, 23 Apr 2020 18:18:48 +0000 (13:18 -0500)]
transaction tracking improvements with telemetry

Issue-ID: POLICY-2456
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I75b7e8e787d567cf120d7ae7d65d1bff12e8e24e
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
4 years agoAdd properties needed by A&AI PNF Operation 71/106271/1
Jim Hahn [Mon, 20 Apr 2020 12:41:34 +0000 (08:41 -0400)]
Add properties needed by A&AI PNF Operation

Added properties needed by A&AI PNF Operation.

Issue-ID: POLICY-2505
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I58966faf9eb9900123a085bf8093050440c15170

4 years agoChange CDS operation name to generic "any" 68/106168/1
Jim Hahn [Thu, 16 Apr 2020 23:02:30 +0000 (19:02 -0400)]
Change CDS operation name to generic "any"

Issue-ID: POLICY-2504
Change-Id: I4dec3dfd62fa230ad8f0de66c0d1b71e5393bcbd
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoFix CDS actor properties 14/106114/2
Jim Hahn [Thu, 16 Apr 2020 16:46:50 +0000 (12:46 -0400)]
Fix CDS actor properties

CDS actor properties in drools-apps did not match the properties
in the actor, itself.  Fixed them (as best I could be inspection).

Issue-ID: POLICY-2501
Change-Id: Ibb4ac5ee59762bd740342c1d54fc472a9fca8968
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agobump to 1.6.2-SNAPSHOT 20/106020/1
jhh [Wed, 15 Apr 2020 14:00:31 +0000 (09:00 -0500)]
bump to 1.6.2-SNAPSHOT

Issue-ID: POLICY-2378
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I8feb308f90755a078d0b35e0d8742e385916c225

4 years agorelease 1.6.1 docker image 79/105979/1
jhh [Wed, 15 Apr 2020 01:39:56 +0000 (20:39 -0500)]
release 1.6.1 docker image

Issue-ID: POLICY-2378
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ic1bbfa4faea580a1fca7fd7104f5c062d19a3e25

4 years agoRelease 1.6.1 artifacts 70/105970/1
jhh [Wed, 15 Apr 2020 00:10:21 +0000 (19:10 -0500)]
Release 1.6.1 artifacts

Issue-ID: POLICY-2378
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6cb53e24996486e98535cdeb99ac0e610d696723
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
4 years agoPoint to released common/models/drools 58/105958/1
jhh [Tue, 14 Apr 2020 21:11:43 +0000 (16:11 -0500)]
Point to released common/models/drools

Issue-ID: POLICY-2378
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I65f59ca624865d6738ff32657e27ad05a35f3eb8

4 years agoPoint to common/models fix 70/105870/1
Pamela Dragosh [Mon, 13 Apr 2020 20:46:58 +0000 (16:46 -0400)]
Point to common/models fix

Fix in naming policy and common yaml string fix

Issue-ID: POLICY-2486
Change-Id: I311ec07f58c5dd6fe17d8b5e9368e3b78b73e894
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoAdded vpci and vsonh tests 01/104301/22
pramod.jamkhedkar [Tue, 24 Mar 2020 19:54:09 +0000 (15:54 -0400)]
Added vpci and vsonh tests

Added test cases for vpci and vsonh usecases

Issue-ID: POLICY-2162
Change-Id: Ia69b16e74b82b92366b5065eeccab8d35f647742
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
Signed-off-by: Jim Hahn <jrh3@att.com>
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
4 years agoAdd SDNR notifications to frankfurt rules 63/105563/1
Jim Hahn [Wed, 8 Apr 2020 18:40:37 +0000 (14:40 -0400)]
Add SDNR notifications to frankfurt rules

Issue-ID: POLICY-2468
Change-Id: Ibf4d3e5f62fa3106028dcf85050c270b8eab0a89
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoPoint to parent SNAPSHOT 58/105258/1
Pamela Dragosh [Tue, 7 Apr 2020 12:53:30 +0000 (08:53 -0400)]
Point to parent SNAPSHOT

Issue-ID: POLICY-2378
Change-Id: I1cb44b953e82e73dc35e5568b2df5ef31484a4fd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoMerge "disable but not removed usecases"
Jorge Hernandez [Fri, 3 Apr 2020 15:07:29 +0000 (15:07 +0000)]
Merge "disable but not removed usecases"

4 years agoremove drools-pdp parent from junit test 46/105046/1
jhh [Thu, 2 Apr 2020 21:15:11 +0000 (16:15 -0500)]
remove drools-pdp parent from junit test

parent was wrong an was running into build
problems.

Issue-ID: POLICY-2459
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I502c85934d8d7f88321805f540448c6d280d856b

4 years agodisable but not removed usecases 26/105026/1
jhh [Thu, 2 Apr 2020 18:47:20 +0000 (13:47 -0500)]
disable but not removed usecases

integration testing to be focused on the new frankfurt controller

Issue-ID: POLICY-2465
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I2a15c300bba4647ef613c49a4985f22c5936d00e

4 years agoSynchronize methods for rules 92/104992/1
Jim Hahn [Thu, 2 Apr 2020 13:57:52 +0000 (09:57 -0400)]
Synchronize methods for rules

Added "synchronized" to a few more methods in the event manager class,
just to be safe, as they view/modify data that may be viewed/modified
by other threads.

Issue-ID: POLICY-2385
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ia8404fd3fd53b0de95f939dfff2088867e0f3b24

4 years agoUpdate path properties for new actors 18/104618/2
Jim Hahn [Fri, 27 Mar 2020 21:59:07 +0000 (17:59 -0400)]
Update path properties for new actors

Some of the new actors were modified to get their path prefixes
from the property files.  In addition, the models code was modified
to allow an empty "path", so that is now used, where appropriate.

Issue-ID: POLICY-2441
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I4573c5e2a506fb67be9bd040ce047612007fd969
Signed-off-by: Jim Hahn <jrh3@att.com>
4 years agoPoint to latest snapshots 97/104597/1
Pamela Dragosh [Fri, 27 Mar 2020 17:10:27 +0000 (13:10 -0400)]
Point to latest snapshots

Issue-ID: POLICY-2378
Change-Id: Idcc8a7117c7ff898558e7efce6b51c8ebb4ad7be
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
4 years agoFix userName property for http clients 30/104530/1
Jim Hahn [Thu, 26 Mar 2020 20:19:23 +0000 (16:19 -0400)]
Fix userName property for http clients

The http client property files had "username", but the correct
property name is "userName".  Fixed.
Also updated the models version to the latest snapshot to pick
up the fix to the APPC actor.

Issue-ID: POLICY-2441
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I4d64efcb5b639526beb145ee0231c6d650098d0f

4 years agoExpand env variables in frankfurt properties 98/104498/2
Jim Hahn [Thu, 26 Mar 2020 13:53:53 +0000 (09:53 -0400)]
Expand env variables in frankfurt properties

Issue-ID: POLICY-2434
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I1109a053e46dc8201ff9676da0c9ff93d8b631d5
Signed-off-by: Jim Hahn <jrh3@att.com>