Krzysztof Opasiak [Wed, 23 Oct 2019 10:41:46 +0000 (12:41 +0200)]
Improve OJSI-185 documentation
Add some more details why we no longer consider OJSI-185 as a security
issue.
Issue-ID: OJSI-185
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ifd8a9c42abab82e56a7f87891f0d1a3491b92e6e
(cherry picked from commit
8dfcaf2db45f4145e2bcd5c0eec669e294fa0f6a)
Taka Cho [Thu, 10 Oct 2019 14:40:40 +0000 (10:40 -0400)]
move to org.opendaylight.mdsal.binding.api
reduce deprecated warning
Issue-ID: APPC-1764
Change-Id: Ie833c20222567f38f240cf3922430b43db32c149
Signed-off-by: Taka Cho <takamune.cho@att.com>
Patrick Brady [Fri, 18 Oct 2019 18:50:47 +0000 (11:50 -0700)]
Revert "remove redundant code under appc-common-bundle/java"
Testing to see if this change is causing probels with
sonar coverage.
This reverts commit
3533ff6d195b9966cbf407238bb5d2fd7ca68bb1.
Change-Id: I986f27b3ca80b9e8db6544f17fdf3086152d1701
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1732
Patrick Brady [Fri, 18 Oct 2019 18:49:03 +0000 (11:49 -0700)]
Revert "update mockito version in APPC"
The version is in the parent files again.
This reverts commit
c13a9c95e47b072afb701ad490480036ef36db26.
Change-Id: Ie6cb57e8b1b8efbf5e516820efbbfb144791b97f
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1767
Taka Cho [Thu, 17 Oct 2019 17:57:00 +0000 (13:57 -0400)]
update release note for unknown issue
update release note
Issue-ID: APPC-1766
Change-Id: I200cc60dd8560b30004e2dc260041f755599395d
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Wed, 16 Oct 2019 21:04:43 +0000 (17:04 -0400)]
replace deprecated addMixInAnnotations
addMixInAnnotations(Class<?>, Class<?>)
was deprecated
use addMixIn instead
Issue-ID: APPC-1764
Change-Id: Ic65e1f18a8d427f641a8d36003f29bdbf1b3b58b
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Tue, 15 Oct 2019 14:00:29 +0000 (10:00 -0400)]
update mockito version in APPC
sonar does not take the test coverage from
parent pom file
Issue-ID: APPC-1767
Change-Id: Ic6530ddc553b404f49937d61481ca2e076362e64
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Mon, 14 Oct 2019 17:51:20 +0000 (13:51 -0400)]
update mockito version
sonar does not take the test coverage from
parent pom file
Issue-ID: APPC-1767
Change-Id: I852280c31b40dc8a3bdcadc20947ec9c8040fce7
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Mon, 14 Oct 2019 13:19:21 +0000 (09:19 -0400)]
update release note for unknown issue
update relese note
Issue-ID: APPC-1710
Change-Id: I810a49a8f72ed9c77869b1c1cdb1435c303bdd15
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Thu, 10 Oct 2019 19:36:32 +0000 (15:36 -0400)]
replace deprecated JsonSerialize.Inclusion
@JsonSerialize(include = JsonSerialize.Inclusion.NON_NULL)
was deprecated
use @JsonInclude(Include.NON_NULL) instead
to suppress when property is NULL
Issue-ID: APPC-1764
Change-Id: I1bbe10a156166bc37a167122ff68d1dc183fcd2f
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Wed, 9 Oct 2019 20:41:47 +0000 (16:41 -0400)]
remove duplicated artifact in chef adapter
there are two org.apache.httpcomponents:httpclient
defined in pom file, keep a one from line 63-67
Issue-ID: APPC-1763
Change-Id: Ifd132e316e05c795d68618f8bd13ba6180d55adf
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Wed, 9 Oct 2019 19:58:47 +0000 (15:58 -0400)]
remove redundant code under appc-common-bundle/java
the code should be taken from src/main
not from java
Issue-ID: APPC-1732
Change-Id: I7d9d8ce24917800f01e4aa84c3e31b584485094a
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Wed, 9 Oct 2019 02:11:26 +0000 (22:11 -0400)]
Neon SR1 upgrade
change pom files for
ODL Neon SR1 upgrade
Issue-ID: APPC-1749
Change-Id: Ib10ff74852a2b38933c0df034c71e21665430f62
Signed-off-by: Taka Cho <takamune.cho@att.com>
Patrick Brady [Tue, 8 Oct 2019 20:39:40 +0000 (13:39 -0700)]
Set appc parent 2.7.0-SNAPSHOT
Change-Id: Ib68d389e9e39951e47b785550134729a9f678497
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Tue, 8 Oct 2019 19:29:24 +0000 (12:29 -0700)]
Increment version to 1.7.0-SNAPSHOT
Change-Id: I5c9c5141f39a653e6604551488e955c2f0a68004
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Krzysztof Opasiak [Sat, 5 Oct 2019 20:21:12 +0000 (22:21 +0200)]
Remove OJSI-176 and OJSI-177 from release notes
Both tickets mentioned in the title are false positives.
In OJSI jira they are marked as "Not a bug" thus they shouldn't be
considered as "fixed security issues"
Issue-ID: OJSI-176
Issue-ID: OJSI-177
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I4d3c0939b5df68ed42e334d492a2751143b41e39
Arundathi Patil [Wed, 25 Sep 2019 13:52:11 +0000 (19:22 +0530)]
Sonar Fix: TerminateStack.java
Fixed sonar issues in this file
Issue-ID: APPC-1745
Change-Id: I1e750cfa8f7d4628fca0c9af0051fdfa69778977
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Thu, 19 Sep 2019 15:14:17 +0000 (20:44 +0530)]
Sonar Fix: MigrateServer.java
Fixed sonar issues across this file
Issue-ID: APPC-1740
Change-Id: I8c2377a99a5de9e9926bc96288e51dfe438d0fa0
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Thu, 19 Sep 2019 15:05:31 +0000 (20:35 +0530)]
Sonar Fix: LookupServer.java
Fixed sonar issues across this file
Issue-ID: APPC-1739
Change-Id: Iabbaada720d8b3f2ee3916a0d663b90f8fe23bcb
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Thu, 19 Sep 2019 14:57:43 +0000 (20:27 +0530)]
Sonar Fix: CreateSnapshot.java
Fixed sonar issues across this file
Issue-ID: APPC-1738
Change-Id: Iba43b24d4ae4c14197eed2e5159a4a00dfcfe00b
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Taka Cho [Fri, 27 Sep 2019 15:07:49 +0000 (11:07 -0400)]
remove org.openecomp.sdc artifact
replace to org.onap.sdc
Issue-ID: APPC-736
Change-Id: I6b9b451ad0196e03e7db90e6157e11139f0d0428
Signed-off-by: Taka Cho <takamune.cho@att.com>
Patrick Brady [Thu, 26 Sep 2019 22:00:00 +0000 (15:00 -0700)]
Change to snapshot parent version
Change to appc parent version 2.6.3-SNAPSHOT
Change-Id: I51e4485098a271ff80de64ea6c20a81df94c7d8f
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Thu, 26 Sep 2019 21:30:44 +0000 (14:30 -0700)]
Increment version to 1.6.5-SNAPSHOT
Change-Id: Ic0e49aef6dc78b1a55e8c7c051e716339f3802f6
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Taka Cho [Thu, 26 Sep 2019 13:42:10 +0000 (09:42 -0400)]
APPC R5 release note fix
fixed a typo
Issue-ID: APPC-1722
Change-Id: Id1bb4cdbc019d2b92f57c2610e279d964948daae
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Wed, 25 Sep 2019 13:41:28 +0000 (09:41 -0400)]
APPC R5 release note
added APPC R5 release note
Issue-ID: APPC-1722
Change-Id: Ic1b19e49fef77e3ed3b995f774cb0f69813fcbe9
Signed-off-by: Taka Cho <takamune.cho@att.com>
Patrick Brady [Tue, 24 Sep 2019 21:07:01 +0000 (14:07 -0700)]
Add 1.6.4 release file
Change-Id: I41e0c64e25d61396c700ed4b9c275d21fcef446a
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1735
Taka Cho [Tue, 24 Sep 2019 15:28:10 +0000 (11:28 -0400)]
replaced by tosca.datatype.version
consolidate to tosca.datatype.version
Issue-ID: APPC-736
Change-Id: Ic0bf2c8743d4b299fc135d53323fffbcd6b7c531
Signed-off-by: Taka Cho <takamune.cho@att.com>
Patrick Brady [Fri, 20 Sep 2019 20:41:02 +0000 (13:41 -0700)]
Set appc parent 2.6.2
Change-Id: I4d3fe28ac744a62b448816fe14b645f19a3e5209
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1735
Patrick Brady [Tue, 17 Sep 2019 17:57:00 +0000 (10:57 -0700)]
Increment version to 1.6.4-SNAPSHOT
Change-Id: I0dfdd848265f21e1584903ea14aa4df6d08a2f94
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Arundathi Patil [Wed, 11 Sep 2019 09:11:56 +0000 (14:41 +0530)]
Sonar fix- APPC-1715
Fixed multiple sonar issues across this file
Issue-ID: APPC-1715
Change-Id: I5a7df4bde164b8ec3c8f91f07646d0630d52fa59
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Wed, 11 Sep 2019 09:20:00 +0000 (14:50 +0530)]
Sonar Fix: APPC-1716
Fixed sonar issues across this file
Issue-ID: APPC-1716
Change-Id: Ic9d8d1c0ff22c9d0cc9831793d1e3550e5f62897
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Wed, 11 Sep 2019 09:29:19 +0000 (14:59 +0530)]
Sonar fix: APPC-1717
Fixed sonar issues across these files
Issue-ID: APPC-1717
Change-Id: I25fc139344e88d389e24b91a7d6796fea6f251c2
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Patrick Brady [Wed, 11 Sep 2019 23:53:23 +0000 (16:53 -0700)]
Add 1.6.3 release file
Change-Id: I1211bb9874e6e7bf3c2f3e3858cd2a4d08d4d5bd
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Wed, 11 Sep 2019 18:31:45 +0000 (11:31 -0700)]
Change to released parent 1.6.1
Change-Id: Ieb506dd5bcc146a45c9e75ec27641f80245548e3
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Wed, 11 Sep 2019 17:50:54 +0000 (10:50 -0700)]
Increment version to 1.6.3-SNAPSHOT
Change-Id: I2b1b8329dbad5a8d6cc5ae96e8c44af1ab3d54ea
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Tue, 10 Sep 2019 19:55:45 +0000 (12:55 -0700)]
Fix eelf resource not found
The eelf package needs to be exported from appc-common
where the resource bundle is added. Doing this was
causing karaf to crash on install of artifact-handler.
The cause was all of the classes being exported by the
maven shade plugin of appc-yang-generator. Removing the
shade plugin seemed to have no bad consequences.
Change-Id: Ic0758b342b8109e28ec8e11a48b2693cea7b56db
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1713
Patrick Brady [Thu, 5 Sep 2019 19:12:34 +0000 (12:12 -0700)]
Changes to remove maven-staging-plugin
Root pom ccsdk version updated to latest and
dependency versions are fixed so that they are
compliant with the maven enforcer plugin.
Change-Id: If85006519678a14af6ace21268eb0bfc195e4215
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Mon, 26 Aug 2019 20:54:22 +0000 (13:54 -0700)]
Changes to fix feature installs
Feature installs were causing karaf to freeze following
the upgrade to the Fluorine SR2 version of ODL. These
changes correct the problems.
Change-Id: I8e5a41ba6816da782fea3ebaef3b6918cfc1ad4c
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1630
vmuthukrishnan [Tue, 13 Aug 2019 17:44:22 +0000 (17:44 +0000)]
Updated jersey from com.sun.jersey to org.glassfish.jersey
ODL upgrade
Change-Id: I1167ad7cdb429c9c3e2808db820e3fc26e605383
Signed-off-by: vmuthukrishnan <vmuthukrishnan@aarnanetworks.com>
Issue-ID: APPC-1630
Patrick Brady [Mon, 26 Aug 2019 21:28:53 +0000 (14:28 -0700)]
Change parent version to snapshot
Changing the parent version to snapshot in order to
build with the new version of appc parent which has
the Fluorine SR2 ccsdk parent poms.
Change-Id: I03d9a0d38b6d97bab17cd887562ae42ed1b19611
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1630
Taka Cho [Thu, 22 Aug 2019 14:25:47 +0000 (10:25 -0400)]
update INFO.yaml
Add change section
Issue-ID: APPC-1685
Change-Id: Ie4e2227dc1d6c35ba192613eaa245311796b4bd9
Signed-off-by: Taka Cho <takamune.cho@att.com>
Thugutla Sailakshmi [Wed, 31 Jul 2019 15:24:03 +0000 (20:54 +0530)]
APPC-1681- remove the thrown exception 'org.json.JSONException' which is a runtime exception.
remove the thrown exception
Issue-ID: APPC-1681
Change-Id: I940a5dd42bfe7a52b39be81a016cf4cf47805cae
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
Thugutla Sailakshmi [Wed, 31 Jul 2019 14:54:36 +0000 (20:24 +0530)]
APPC-1681 -Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
APPC-1681 -Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
Issue-ID: APPC-1681
Change-Id: I7f6926bfa1a4f57d99d6732492281b36f041922f
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
dinesha [Wed, 31 Jul 2019 09:10:52 +0000 (14:40 +0530)]
Sonar Fix- ProviderOperation.java
Fixed Sonar Issues accross the file
Issue-ID: APPC-1669
Change-Id: Idccc7e133a93f0af8d2352473d95f755f39f1ae7
Signed-off-by: dinesha <dineshgs@in.ibm.com>
Patrick Brady [Fri, 9 Aug 2019 00:03:47 +0000 (17:03 -0700)]
Revert changes to parent poms
These changes did not work
Change-Id: Ie90d1bf4795cad916f8aea00af9a8cf5bcc847ed
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Thu, 8 Aug 2019 21:58:52 +0000 (14:58 -0700)]
Change parent poms
Changing the parent pom of appc-dispatcher and
appc-directed-graph so that they no longer point
to the root appc pom, instead they point to the
org.onap.appc.parent pom files.
Change-Id: I116bd06471482e19715a3c5ada506f9d700e5576
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Thu, 8 Aug 2019 19:16:26 +0000 (12:16 -0700)]
Attempt to disable nexus staging
Change-Id: Ice20bc6259d9f30438f23e9f8e6c875f4119fee3
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Wed, 7 Aug 2019 21:57:50 +0000 (14:57 -0700)]
Add 1.6.2 release file
Change-Id: Ib8f13865e9702099e99593b1fa301e1dc2da8ec2
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Wed, 7 Aug 2019 20:12:28 +0000 (13:12 -0700)]
Change to release parent version
Change-Id: If572b36cdf00e3c6ada36181fb6c678fbd978e72
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Wed, 7 Aug 2019 20:05:39 +0000 (13:05 -0700)]
Increment version to 1.6.2
Change-Id: If6610d1addd323c1ad0f902a0841b979f017adc9
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Tue, 6 Aug 2019 05:38:23 +0000 (22:38 -0700)]
Add release file for 1.6.1
Change-Id: I19a543c1fea16823039d00290d4831dbeb35c1ea
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Patrick Brady [Sun, 4 Aug 2019 06:06:41 +0000 (23:06 -0700)]
Increment versions after release
Change-Id: I83b000b7c4ac94b5eba396b5e1856a970fa90623
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1686
Taka Cho [Thu, 1 Aug 2019 12:15:28 +0000 (08:15 -0400)]
update INFO.yaml
remove Joss from committer
Issue-ID: APPC-1685
Change-Id: Id223a31e6870a00708e5a0aa3c36d725c4284524
Signed-off-by: Taka Cho <takamune.cho@att.com>
Patrick Brady [Wed, 31 Jul 2019 23:10:43 +0000 (16:10 -0700)]
Add release file for 1.6.0 release
Change-Id: I9ba4c926097457c6d540bdb26efc1967a434249e
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1684
dinesha [Mon, 29 Jul 2019 07:39:51 +0000 (13:09 +0530)]
Sonar Fix- AnsibleServerEmulator.java
Fixed Sonar issues accross the file
Issue-ID: APPC-1669
Change-Id: I49db3c6c23f5cf61fe8d898662abaeb14f7c4422
Signed-off-by: dinesha <dineshgs@in.ibm.com>
dinesha [Mon, 29 Jul 2019 13:02:12 +0000 (18:32 +0530)]
Sonar Fix- RestoreStack.java
Fixed Sonar issues accross the file
Issue-ID: APPC-1669
Change-Id: Icd598fa6c9954c22d4bfd7ab0155823e8b946638
Signed-off-by: dinesha <dineshgs@in.ibm.com>
anushadasari [Tue, 30 Jul 2019 11:45:17 +0000 (17:15 +0530)]
Sonar- Unused Import
The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Issue-ID: APPC-1677
Change-Id: Ieb7f01df8fc1f639c232ca47eefa2145fe45d965
Signed-off-by: anushadasari <danush10@in.ibm.com>
anushadasari [Tue, 30 Jul 2019 09:19:51 +0000 (14:49 +0530)]
Major- Unused "context" local variable.
If a local variable is declared but not used, it is dead code and should be removed. Doing so will improve maintainability because developers will not wonder what the variable is used for.
Issue-ID: APPC-1675
Change-Id: I9cccd6fd529591cbbe7095cce9d5687a712f42d9
Signed-off-by: anushadasari <danush10@in.ibm.com>
Thugutla Sailakshmi [Wed, 24 Jul 2019 10:13:38 +0000 (15:43 +0530)]
AAPC-1659 removing unused import
removing unused import
Issue-ID: APPC-1659
Change-Id: Ib7696e4e0fbefe329eda4eb56feb24701f17c4e6
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
anushadasari [Mon, 29 Jul 2019 07:56:30 +0000 (13:26 +0530)]
SonarFix- MigrateServer.java
The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.
Change-Id: Ic0af785e3d3863f4555ab9614d7a8b3b0f2150b3
Issue-ID: APPC-1670
Signed-off-by: anushadasari <danush10@in.ibm.com>
anushadasari [Wed, 24 Jul 2019 17:19:21 +0000 (22:49 +0530)]
APPC-1663
The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.
Issue-ID: APPC-1663
Change-Id: I98a98f59847a4cdea298f82531530db4048b65b0
Signed-off-by: anushadasari <danush10@in.ibm.com>
Thugutla Sailakshmi [Wed, 24 Jul 2019 09:09:20 +0000 (14:39 +0530)]
AAPC-1658 removing unused import
removing unused import
Issue-ID: APPC-1658
Change-Id: I3eb674031487937b461d045c31d4aa9108b38de6
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
anushadasari [Thu, 25 Jul 2019 16:01:56 +0000 (21:31 +0530)]
SonarFix-Remove declaration of thrown exception
Remove the declaration of thrown exception 'org.onap.appc.exceptions.APPCException', as it cannot be thrown from method's body.
Issue-ID: APPC-1664
Change-Id: I0c66da105d735b4ac97ee35d1e6bea122be80722
Signed-off-by: anushadasari <danush10@in.ibm.com>
Patrick Brady [Tue, 23 Jul 2019 18:54:01 +0000 (11:54 -0700)]
Prepared statements for DG services
Convert sql queries to prepared statements in other
parts of appc.
Change-Id: If29225394de2ab286e4f2f7bdd17f6af6b286576
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: OJSI-25
Patrick Brady [Fri, 19 Jul 2019 20:03:02 +0000 (13:03 -0700)]
Add value of the arguments
Also apply the valueof to non svc context arguments.
The original code would always treat null arguments
as null strings. This replaces that functionality
in the prepared statements.
Change-Id: I88ab22c87b86a8f5ff41946757c40a399c37a6c3
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: OJSI-25
anushadasari [Wed, 24 Jul 2019 16:54:32 +0000 (22:24 +0530)]
AAPC-1655
The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.
Issue-ID: APPC-1655
Change-Id: I64e50083b9b0fe40fa0ba32723e30adb0dbce08e
Signed-off-by: Dasari Anusha <danush10@in.ibm.com>
Signed-off-by: anushadasari <danush10@in.ibm.com>
Thugutla Sailakshmi [Wed, 24 Jul 2019 10:20:04 +0000 (15:50 +0530)]
AAPC-1661-remove unused import 'java.util.TimeZone'
remove unused import 'java.util.TimeZone'
Issue-ID: APPC-1661
Change-Id: I94d4c39a83fb815343fd373557a7d36b3e1213b8
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
anushadasari [Sun, 21 Jul 2019 15:23:51 +0000 (20:53 +0530)]
APPC -1653
The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.
Issue-ID: APPC-1653
Change-Id: I9e3e3b7994cb689e14b70aab73d5dfea54fa4a1f
Signed-off-by: anushadasari <danush10@in.ibm.com>
anushadasari [Sun, 21 Jul 2019 15:05:13 +0000 (20:35 +0530)]
APPC-1652- Removing Duplicate import
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.
Issue-ID: APPC-1652
Change-Id: I64e50083b9b0fe40fa0ba32723e30adb0dbce08e
Signed-off-by: Dasari Anusha <danush10@in.ibm.com>
Signed-off-by: anushadasari <danush10@in.ibm.com>
Change-Id: I1ddafa429afb23a0eb6cb120a20a774ff9a032b8
anushadasari [Sun, 21 Jul 2019 16:52:03 +0000 (22:22 +0530)]
APPC-1654
Remove the declaration of thrown exception 'org.onap.appc.exceptions.APPCException', as it cannot be thrown from method's body.
Issue-ID: APPC-1654
Change-Id: Ib08561aaecf8dea445e0f5ceb3a6d35795dfd8bd
Signed-off-by: anushadasari <danush10@in.ibm.com>
Taka Cho [Fri, 19 Jul 2019 14:28:36 +0000 (10:28 -0400)]
remove opendaylight-karaf-empty
opendaylight-karaf-empty is for testing
purpose and outdated
Issue-ID: APPC-1651
Change-Id: I768b7afa9a60db6413f71320fd11575b1fafce97
Signed-off-by: Taka Cho <takamune.cho@att.com>
Patrick Brady [Wed, 17 Jul 2019 22:02:37 +0000 (15:02 -0700)]
Replace Lists with new ArrayList
The Lists.newArrayList method is not being used here in a
way that provides significant benefit over new ArrayList
and Lists was causing a class not found exception.
Change-Id: I61bbfc5e55cb283c10f3681a7e336ae346347d03
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1613
Patrick Brady [Wed, 17 Jul 2019 20:22:35 +0000 (13:22 -0700)]
Fixes for parameterized sql queries
The old non-parameterized queries would treat null entries in the SvcLogicContext
as "null" string values. The parameterized query treats these as NULL sql values.
This change keeps those values as "null" strings.
Change-Id: Iee7f7a1861bdd82dc65d59db2be7862b49cf1207
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1639
Sudarshan Kumar [Thu, 11 Jul 2019 12:54:46 +0000 (18:24 +0530)]
Sonar Fix - Removed unnecessary cast to Date
Sonar Fix - Removed unnecessary cast to Date
Issue-ID: APPC-1629
Change-Id: Ie37c511ac63abd71708700b376a836e4ed03e92f
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sudarshan Kumar [Fri, 12 Jul 2019 10:50:50 +0000 (16:20 +0530)]
Sonar Fix - Removed unused Variable Utils.java
Sonar Fix - Removed unused Variable Utils.java
Issue-ID: APPC-1629
Change-Id: I557c065ff835834f5eed5eb80bd7136e182217f5
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sudarshan Kumar [Fri, 5 Jul 2019 10:37:36 +0000 (16:07 +0530)]
Sonar Fix - String comparison
Sonar Fix - String comparison
Issue-ID: APPC-1629
Change-Id: I8ea38dfaf629c2be624552a1cf0b0f0e877117cb
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Sudarshan Kumar [Fri, 5 Jul 2019 13:08:38 +0000 (18:38 +0530)]
Sonar Fix - String Comparison
Sonar Fix - String Comparison
Issue-ID: APPC-1629
Change-Id: Ia13da99f101d479aba7009ba4dffc201aa9a3ffe
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
jegadeeshbabu1 [Tue, 9 Jul 2019 06:08:14 +0000 (11:38 +0530)]
Marked field transient
Handled non-serializable fields
Issue-ID: APPC-1637
Change-Id: I3398620e396c3f8bc1504eca8d312bc35d3bbbfd
Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
jegadeeshbabu1 [Thu, 4 Jul 2019 16:12:37 +0000 (21:42 +0530)]
Adhered serializable class contracts
Marked member transient
Issue-ID: APPC-1634
Change-Id: I7bbbf941e692c2755122f3d40a7ca79c59f21749
Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
jegadeeshbabu1 [Sun, 7 Jul 2019 16:49:24 +0000 (22:19 +0530)]
Updated to be an instance variable
Removed static keyword
Issue-ID: APPC-1636
Change-Id: I507d306f50acc010db4d944a078b4d15f5c719a4
Signed-off-by: jegadeeshbabu1 <jegabab1@in.ibm.com>
Sudarshan Kumar [Tue, 9 Jul 2019 11:21:26 +0000 (16:51 +0530)]
Sonar Fix- Removed Unused private field
Sonar Fix- Removed Unused private field
Issue-ID: APPC-1629
Change-Id: Iaab259140e29200473147097c552f75783e5cd0d
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
Lathish [Wed, 19 Jun 2019 15:48:09 +0000 (15:48 +0000)]
Fixed netconf-xml parsing issue
Issue-ID: APPC-1624
Change-Id: I12aa5f1a42d5e09b5eb8886132ea9e5a2c84ef5e
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
Patrick Brady [Wed, 19 Jun 2019 19:35:08 +0000 (12:35 -0700)]
Parameterized queries
Convert all database queries to use java sql
parameterized queries to reduce risk of sql
injection attack.
Change-Id: I15876ce3a2f2e2dfbd6578f5141367deed75d097
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: OJSI-25
Taka Cho [Wed, 19 Jun 2019 18:29:33 +0000 (14:29 -0400)]
update appc release note
fix appc cluster issue
release new appc docker
Issue-ID: APPC-1293
Change-Id: Id4897669e29f3c7c156a3c4c945825758c268a51
Signed-off-by: Taka Cho <takamune.cho@att.com>
Lathish [Tue, 18 Jun 2019 10:16:16 +0000 (10:16 +0000)]
Added cvaas file name in Audit and Sync
Issue-ID: APPC-1590
Change-Id: I09345570fe6cd158102844070e62df7fb1a7aed9
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
Taka Cho [Fri, 14 Jun 2019 18:42:56 +0000 (14:42 -0400)]
fix document error
missing underline
Issue-ID: APPC-1595
Change-Id: Ia1eb87c5f34c43c56e037e9bf925857ecbb9d758
Signed-off-by: Taka Cho <takamune.cho@att.com>
Taka Cho [Thu, 6 Jun 2019 13:52:30 +0000 (09:52 -0400)]
update dublin release note
remove known-issue
APPC-1613
Issue-ID: APPC-1293
Change-Id: Ibacdb95bdc94bee2449596948055bbff3bd51e9e
Signed-off-by: Taka Cho <takamune.cho@att.com>
Lathish [Mon, 10 Jun 2019 13:43:55 +0000 (13:43 +0000)]
Fixed incorrect error message
Issue-ID: APPC-1623
Change-Id: Ib6c58be5e5ddb41c39788208238234335f72e7ea
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
Krzysztof Opasiak [Wed, 5 Jun 2019 21:33:16 +0000 (23:33 +0200)]
Document OJSI-185 vulnerability
Issue-ID: OJSI-185
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I6cbe6a6cb0129bd4ac6ccba35cf018f4a04f80e5
Krzysztof Opasiak [Wed, 5 Jun 2019 21:32:50 +0000 (23:32 +0200)]
Document OJSI-113 vulnerability
Issue-ID: OJSI-113
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I9d0c35e01dd4f2b42bd115455863ca2d0b8dc3c7
Krzysztof Opasiak [Wed, 5 Jun 2019 21:32:21 +0000 (23:32 +0200)]
Document OJSI-112 vulnerability
Issue-ID: OJSI-112
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Id28f332ddcdd5c69f5a82758d05c10d19606faff
Krzysztof Opasiak [Wed, 5 Jun 2019 21:31:54 +0000 (23:31 +0200)]
Document OJSI-95 vulnerability
Issue-ID: OJSI-95
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ica05a626601673f672cc0be6a8c6cdcbe94323f8
Krzysztof Opasiak [Wed, 5 Jun 2019 21:30:42 +0000 (23:30 +0200)]
Document OJSI-63 (CVE-2019-12124) vulnerability
Issue-ID: OJSI-63
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ide989877e0f2765302ad423c0b421e972b4e8046
Krzysztof Opasiak [Wed, 5 Jun 2019 21:30:08 +0000 (23:30 +0200)]
Document OJSI-29 vulnerability
Issue-ID: OJSI-29
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ib8f54aa42fc78198c8b0043b2aa79580a5950672
Krzysztof Opasiak [Wed, 5 Jun 2019 21:29:16 +0000 (23:29 +0200)]
Document OJSI-25 (CVE-2019-12316) vulnerability
Issue-ID: OJSI-25
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ia880184484aadea9147fcac301c87063a00f92ab
Krzysztof Opasiak [Wed, 5 Jun 2019 21:28:26 +0000 (23:28 +0200)]
Document fixed OJSI-104 vulnerability
Issue-ID: OJSI-104
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I42365c3038eb38f170b1543d9f78d68b2e5c9de4
Krzysztof Opasiak [Wed, 5 Jun 2019 21:27:39 +0000 (23:27 +0200)]
Document fixed OJSI-146 vulnerability
Issue-ID: OJSI-146
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I9e02cc26f7cfa9c11941b4ce4aef5de561f4b764
Krzysztof Opasiak [Wed, 5 Jun 2019 21:11:16 +0000 (23:11 +0200)]
Improve security release notes
In order to provide users with more details of project's state in
terms of security let's divide the security release notes into three
sections:
- Fixed Security Issues
Contains a list of security fixes merged during this
release (especially those reported via OJSI tickets).
- Known Security Issues
Contains a list of vulnerabilities detected in project during
release which have not been fixed yet and thus should be mitigated
by the user.
- Known Vulnerabilities in Used Modules
Contains information about NexusIQ scan results
Issue-ID: SECCOM-238
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I9fee2338091ed5a879e0989d13501008d7d6013f
Patrick Brady [Wed, 5 Jun 2019 18:15:13 +0000 (11:15 -0700)]
Fix for jackson annotation
Fasterxml jackson annotations was not available during runtime
and was causing json property annotations to be ignored and
json was not parsing.
Change-Id: I1cb48e6fc54fc39d24bde1683cb141f1f64c9906
Signed-off-by: Patrick Brady <patrick.brady@att.com>
Issue-ID: APPC-1613
Lukasz Rajewski [Wed, 5 Jun 2019 14:04:41 +0000 (16:04 +0200)]
Fix for documentation of DistributeTrafficCheck
Change-Id: I260ef22fb00755e6818868fdadd35bcd88162ffd
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
Issue-ID: APPC-1447