Pamela Dragosh [Fri, 13 Apr 2018 18:29:04 +0000 (14:29 -0400)]
Update to SNAPSHOT 1.2.1
Issue-ID: POLICY-736
Change-Id: I2bc455510e925764d18a1d8e96e072bdadb251c6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Daniel Cruz [Wed, 4 Apr 2018 02:09:58 +0000 (21:09 -0500)]
Fix Event Syntax
The "requestID" field was changed to "requestId" which brakes
the use cases since this does not conform to the events
DCAE will be sending. To avoid further issues with changed
variable names, all onset fields now have a serialized name
that will be used when serializing/deserializing with gson.
Issue-ID: POLICY-681
Change-Id: I731b0c83a9b6c9bbaae0312f76382d7f4644db8c
Signed-off-by: Daniel Cruz <dc443y@att.com>
Jorge Hernandez [Tue, 3 Apr 2018 19:21:04 +0000 (14:21 -0500)]
Configure correct classnames for LCM classes
Change-Id: I5305e71bb0cc844dd37ff6420cd30012f98c88ed
Issue-ID: POLICY-720
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Jorge Hernandez [Mon, 2 Apr 2018 22:23:47 +0000 (17:23 -0500)]
installation enhancements
The following changes aim to have a quicker start of the drools container:
1. For both amsterdam (and the experimental beijing) controllers
dependencies are pre-installed, so the loading of 3rd party
dependencies are faster.
2. Further enhancements in installation.
3. Make sure that the naming of the generated control loop
artifacts have a "control loop" label associated with it,
so in the future, if other applications are added (non
control loop related) do not conflict and is clear.
Change-Id: Iecb84d186fcc34069aa5c4a175a8a4521b38499d
Issue-ID: POLICY-534
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Pamela Dragosh [Thu, 29 Mar 2018 00:25:35 +0000 (17:25 -0700)]
Exclude jackson-databind
we are not using this code yet, but let's remove
jackson-databind. The inclusion of drools-pdp adds
in the latest jackson-databind.
Issue-ID: POLICY-504
Change-Id: I73a1939eb3827a7ef06c40e11764944b3d80685b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 28 Mar 2018 18:22:26 +0000 (11:22 -0700)]
Remove ECOMP trademark
Issue-ID: POLICY-696
Change-Id: Ic33a1f7fd1c5f6368422603a3ed40d8704523240
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
mmis [Tue, 27 Mar 2018 12:13:57 +0000 (13:13 +0100)]
Removed checkstyle warnings
Removed checkstyle warnings from:
policy/drools-applications/controlloop/common/model-impl/appc
policy/drools-applications/controlloop/common/model-impl/appclcm
policy/drools-applications/controlloop/common/model-impl/events
including changes to template files due to renamed methods
Issue-ID: POLICY-705
Change-Id: Ieb93baf43268aa608f204eef1a610354f2adec32
Signed-off-by: mmis <michael.morris@ericsson.com>
Pamela Dragosh [Tue, 27 Mar 2018 14:09:37 +0000 (14:09 +0000)]
Merge "transaction logging through feature part 2"
Jorge Hernandez [Tue, 27 Mar 2018 02:33:00 +0000 (02:33 +0000)]
Merge "Create Drools Scripts for Beijing"
Jorge Hernandez [Mon, 26 Mar 2018 04:50:23 +0000 (23:50 -0500)]
transaction logging through feature part 2
Change-Id: I3b411ee2855a1ffe94ffc67fccfb1e475335d036
Issue-ID: POLICY-533
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Jorge Hernandez [Tue, 27 Mar 2018 00:57:44 +0000 (00:57 +0000)]
Merge "Fix path to logging class"
liamfallon [Tue, 27 Mar 2018 00:09:39 +0000 (17:09 -0700)]
Fix path to logging class
The package path of LoggerUtil changed as below:
From:
import org.onap.policy.drools.utils.LoggerUtil;
To:
import org.onap.policy.drools.utils.logging.LoggerUtil;
Change-Id: I8187d97de5eeab92268baab155fb4de37f4df3ad
Issue-ID: POLICY-448
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Tue, 27 Mar 2018 00:06:19 +0000 (00:06 +0000)]
Merge "Add timeout to SO to wait for success"
Daniel Cruz [Mon, 26 Mar 2018 18:39:05 +0000 (13:39 -0500)]
Create Drools Scripts for Beijing
The create-cl-beijing script will now allow the user to create a rules
jar that does not need to be expanded and also generate test files that
can be used to insert facts for all the supported beijing use cases. The
yaml for each policy is provisioned by the user in case custom yaml is
desired.
In addition to this, a new script is included that will extract the
needed data from the controller properties file to insert facts for all
the supported use cases. This script can be used to insert
ControlLoopParams facts after the create-cl-beijing script is used to
generate the rules artifact. No provisioning necessary other than
specifying where the controller properties file is located.
Issue-ID: POLICY-692
Change-Id: I42f0a08fba133ca36fb1be588a720e4f9598d79f
Signed-off-by: Daniel Cruz <dc443y@att.com>
mmis [Thu, 22 Mar 2018 16:36:47 +0000 (16:36 +0000)]
Removed checkstyle warnings
Removed checkstyle warnings from
policy/drools-applications/controlloop/common/model-impl/aai
including renaming classes:
AAI* -> Aai*
PNF* -> Pnf*
and renaming some methods in those classes
Issue-ID: POLICY-705
Change-Id: I2d59a668728aa58a2c9fbe78c44e924e6cfb4531
Signed-off-by: mmis <michael.morris@ericsson.com>
Jorge Hernandez [Mon, 26 Mar 2018 13:52:37 +0000 (13:52 +0000)]
Merge "Create archetype for Beijing Release"
liamfallon [Tue, 20 Mar 2018 15:30:17 +0000 (15:30 +0000)]
Add timeout to SO to wait for success
The timeout implementation assumes that a finished request is a HTTP-200
together with either a request state of COMPLETE or FAILED in the embedded
request in the response in the JSON. This is the same as what is done earlier
in this class and in, for example, VFC.
Unit test for timeout has also been added.
Change-Id: I637dbecb8d230b8060f7ced76d92d11ec482503e
Issue-ID: POLICY-448
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Fri, 23 Mar 2018 06:14:12 +0000 (01:14 -0500)]
transaction logging through a feature
This is the first of 2 code inspections.
This review contains though most of the work.
It keeps tracks of all in progress transactions
by intercepting all notifications. From that
appropriate metrics can be obtained and logged.
The actual logging of the metrics and enablement
of the feature at install time will come in a
subsequent review.
Change-Id: Ie5c8adfbdeae72758da7da8a1b4133cd4818c6fb
Issue-ID: POLICY-533
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Daniel Cruz [Fri, 23 Mar 2018 13:04:17 +0000 (08:04 -0500)]
Create archetype for Beijing Release
This new archetype is a proof of concept for removing
template expansion from the BRMSGW. The idea is to have
a ueb or dmaap topic that the BRMSGW uses to send params
json and then the pdp-d will deserialize it into a
ControlLoopParams object. The rules engine will then
insert that fact in to the working memory which will be
used for rules matching between onset events and
corresponding policies.
Issue-ID: POLICY-692
Change-Id: I4237221c2216dab16160e79a8f2fdcab6571e1eb
Signed-off-by: Daniel Cruz <dc443y@att.com>
mmis [Thu, 22 Mar 2018 14:20:46 +0000 (14:20 +0000)]
Removed checkstyle warnings
Removed checkstyle warnings in:
policy/controlloop/common/guard
policy/controlloop/common/msb
policy/controlloop/simulators
including renaming of the following classes:
MSBServiceFactory -> MsbServiceFactory
MSBServiceManager -> MsbServiceManager
MSBServiceException -> MsbServiceException
Issue-ID: POLICY-705
Change-Id: I11d62a74fcb77e764121df119cb0bd9b844b485b
Signed-off-by: mmis <michael.morris@ericsson.com>
Pamela Dragosh [Thu, 22 Mar 2018 14:35:27 +0000 (14:35 +0000)]
Merge "Removed checkstyle warnings"
mmis [Wed, 21 Mar 2018 15:22:10 +0000 (15:22 +0000)]
Removed checkstyle warnings
Removed checkstyle warnings in:
policy/drools-applications/controlloop/common/actors
policy/drools-applications/controlloop/common/eventmanager
policy/drools-applications/controlloop/common/feature-controlloop-utils
Issue-ID: POLICY-705
Change-Id: Iccf99b291bc62bc3ba2082ccdb4c1f9e12107896
Signed-off-by: mmis <michael.morris@ericsson.com>
Pamela Dragosh [Thu, 22 Mar 2018 12:25:48 +0000 (12:25 +0000)]
Merge "Fix Serialized Names for Legacy APPC"
CRUZ [Thu, 22 Mar 2018 00:49:32 +0000 (19:49 -0500)]
Fix Serialized Names for Legacy APPC
The legacy APPC request and response messages must be upper camel case.
Issue-ID: POLICY-681
Change-Id: I439fa22b76dd2cb35a054bf93260705b8cf1af51
Signed-off-by: dc443y <dc443y@att.com>
Pamela Dragosh [Tue, 20 Mar 2018 12:37:43 +0000 (12:37 +0000)]
Merge "Fix Serialized Names of A&AI Subtag"
dc443y [Tue, 20 Mar 2018 02:04:50 +0000 (21:04 -0500)]
Fix Serialized Names of A&AI Subtag
Onset events received from DCAE contain an "AAI" subtag that is
capitalized. The casing of the AAI variable was changed to lower case which was making the gson serializer unable to deserialze a simulated onset event that
matches the casing DCAE uses, which resulted in Policy rejecting the
events because they appear to be missing "AAI".
A serialized name was added to preserve the lower cased variable as
sonar wants but will also allow onsets with capitalized AAI
subtags to be processed by the rules engine.
Issue-ID: POLICY-681
Change-Id: Ia37694f606b3fb0898d6c4dadea7c48c5372e64e
Signed-off-by: dc443y <dc443y@att.com>
liamfallon [Wed, 14 Mar 2018 21:39:34 +0000 (21:39 +0000)]
Update oparent version to 1.1.0
Directive from ONAP project that all repos should be
updated. Change vierified with a build with .m2 /org/onap
cleared.
Changed dependency org.onap.msb.java-sdki.msb-java-sdk from
version 1.1.0-SNAPSHOT to version 1.1.0
Change-Id: I46abc49019cb81b726e3f71ca8fe1beed621a426
Issue-ID: POLICY-693
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Pamela Dragosh [Wed, 14 Mar 2018 15:45:21 +0000 (15:45 +0000)]
Merge "Changed SO request to iterate extra props"
Magnusen, Drew (dm741q) [Wed, 14 Mar 2018 13:36:25 +0000 (08:36 -0500)]
Changed SO request to iterate extra props
Modified SoActorServiceProvider.constructRequest() method so that it
iterates over extra properties instead of hard coding array values.
Issue-ID: POLICY-443
Change-Id: I37d6be9dc595bd8d5e9f9f3f63d6890ef1b2f8b3
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
liamfallon [Wed, 14 Mar 2018 11:07:28 +0000 (11:07 +0000)]
Fix artifactid parameter in archetype POM
The parameter ${artifactId} is depricated in POMs. This change replaces that
parameter ${project.artifactId}
Change-Id: I754fe11918707c599847471c438bedfd1285b0ed
Issue-ID: POLICY-238
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Fri, 2 Mar 2018 18:15:50 +0000 (18:15 +0000)]
Merge "Upgrade MSB client for security issues"
Pamela Dragosh [Fri, 2 Mar 2018 16:04:27 +0000 (11:04 -0500)]
Upgrade MSB client for security issues
Via LiZi, the MSB team has made some changes to resolve
their CLM security issues. We will upgrade to their release
version when they have completed that work.
Issue-ID: POLICY-615
Change-Id: I7ccc0e0f14d4d8ae8b6852275308b1aad62acaa3
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Fri, 2 Mar 2018 16:02:28 +0000 (16:02 +0000)]
Merge "Reduce Technical Debt on drools-applications"
liamfallon [Fri, 2 Mar 2018 14:24:23 +0000 (14:24 +0000)]
Reduce Technical Debt on drools-applications
This commit mops up the technical debt issues in
drools-applications that are reaistic to fix witout
major surgery on the code.
note: warnings on non compliant Java class names that are used in
yaml serializaiton and deserailization are ignored.
note: warnings on complexity figures for equals() methods are ignored.
Issue-ID: POLICY-455
Change-Id: I99ccda4bd9932ceb5ccbcfd2778730234b55d7a5
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Pamela Dragosh [Thu, 1 Mar 2018 22:11:20 +0000 (17:11 -0500)]
Remove CLM issues with commons-collections
We know that we are not configuring an LDAP PIP in our
use of the XACML open source. The LDAP implementation
uses Apache Velocity, which uses a very old version
of commons-collections that has security issues. So
we can exclude commons-collections from the build.
Issue-ID: POLICY-504
Change-Id: I6d90731e601f58c8edaca6fe02df30ee2a090c2f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
SwapnilPathak [Wed, 21 Feb 2018 11:26:27 +0000 (16:56 +0530)]
Support vDNS scale out for multiple times
Generation of Unique values for attribute vf-module-name for every scale out operation
Change-Id: I5274361c2f5a4136020a384dbe4a4009607f589a
Issue-ID: POLICY-610
Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
liamfallon [Tue, 13 Feb 2018 11:29:56 +0000 (11:29 +0000)]
Rename maven modules to mirror directory structure
The naming of Maven modules in drools-applications was not
aligned with the directory structure in the git repository
of drools-applications. Therefore it was difficult to
see the strucutre of the repository in Eclipse and other
IDEs. This change amends the Maven module IDs to
reflect the repository directory structure.
This patch reset fixes the previos patch set, where many
references to maven modules internally in drools-applciations
were missed. See also changes in engine and docker repos.
Updated to reflect repo directory structure in maven
artifact groups.
Issue-ID: POLICY-238
Change-Id: I8ab1a7ecdb664045222bbbfda269135e3e449109
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Pamela Dragosh [Fri, 16 Feb 2018 15:41:37 +0000 (10:41 -0500)]
Modify sonar settings to include all sub-modules
We are now including all the sub-modules coverage into one file.
This will now reflect correct statistics for any sub-module that
tests code located in another sub-module.
Issue-ID: POLICY-634
Change-Id: Id96eb9e9f637770932067bd803cb5ccdb571c05a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Mon, 12 Feb 2018 16:54:48 +0000 (16:54 +0000)]
Merge "Fix technical debt/JUnit on policy-yaml"
mmis [Mon, 12 Feb 2018 11:54:51 +0000 (11:54 +0000)]
Fix technical debt/JUnit on policy-yaml
Unit tests added and technical debt removed
Issue-ID: POLICY-455
Change-Id: I31566f9386cb94d78e9af3d6261e31b9cad1cb53
Signed-off-by: mmis <michael.morris@ericsson.com>
liamfallon [Sun, 11 Feb 2018 12:42:11 +0000 (12:42 +0000)]
Tidy dependencies and scopes in POMs
There were some duplicate dependencies in the POMs that were causing warnings.
These have been removed. In cases where the revision of the duplicate
dependencies were different,the latest revision was used.
The scope of the "junit" dependency was "provided" in some POMs. These have been
corrected with the scope of "test" being used for junit dependencies.
Issue-ID: POLICY-238
Change-Id: Ib1cc6f040b0c4d7f2b39ae02bc6fb4590d395809
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Fri, 9 Feb 2018 15:52:57 +0000 (15:52 +0000)]
Merge "Upgrade XACML jar"
Pamela Dragosh [Fri, 9 Feb 2018 15:08:42 +0000 (15:08 +0000)]
Merge "Remove Technical Debt from MSB code"
Pamela Dragosh [Fri, 9 Feb 2018 14:52:40 +0000 (09:52 -0500)]
Upgrade XACML jar
XACML was released with minor fixes for XML files with comments. Mainly
it contained upgrade to dependencies that had fixed security issues. One
still remains but will not be able to be fixed.
Issue-ID: POLICY-616
Change-Id: Ifaf4f92d8da878a1c49dff5fd028744d01999ff5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
liamfallon [Fri, 9 Feb 2018 13:17:41 +0000 (13:17 +0000)]
Remove Technical Debt from MSB code
Some minor warnings showed up in Eclipse on the MSB module. This change
removes those warnings.
Issue-ID: POLICY-455
Change-Id: Ibdd8c563120178d73a55adfd0d8853b6bc82b820
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Thu, 8 Feb 2018 21:54:16 +0000 (21:54 +0000)]
JUint/Technical Debt for eventmanager
Unit test expanded for SO POJOs, technical debt removed in eventmanager.
Change-Id: I7045f5af88fd2c15019befe29a0b4fcd69801c49
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Wed, 7 Feb 2018 20:50:20 +0000 (20:50 +0000)]
Merge "Resolve security issues SONATYPE-2017-0359"
Pamela Dragosh [Wed, 7 Feb 2018 16:01:19 +0000 (11:01 -0500)]
Resolve security issues SONATYPE-2017-0359
Upgrade httpclient to 4.5.5 - the latest version.
Issue-ID: POLICY-612
Change-Id: I5e79918bc447889b1dbcd1bf897c3324f6a0cc0d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Wed, 7 Feb 2018 15:58:54 +0000 (15:58 +0000)]
Merge "Fix technical debt/JUnit on MSB"
eeimmis [Tue, 6 Feb 2018 09:43:40 +0000 (09:43 +0000)]
Fix technical debt/JUnit on MSB
Unit tests added and technical debt removed
Issue-ID: POLICY-455
Change-Id: Ib10613ff7cac64bb576046e038b2acbd66152648
Signed-off-by: mmis <michael.morris@ericsson.com>
liamfallon [Wed, 7 Feb 2018 14:14:46 +0000 (14:14 +0000)]
Log thrown exception in PIPEngineGetHistory
Sonar Critical error highlighted, with thrown execption not logged. The
exception is now logged.
Issue-ID: POLICY-455
Change-Id: If2969a4fe118d22dbd1fb11879ba028487848eb8
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Tue, 6 Feb 2018 14:17:36 +0000 (14:17 +0000)]
Add JUnit and Remove Technical Debt in Guard
Unit test for guard added and technical debt removed.
Issue-ID: POLICY-455
Change-Id: I440766660ddae078013e21b1991ee49c8e488bb3
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Liam Fallon [Mon, 5 Feb 2018 12:02:05 +0000 (12:02 +0000)]
Fix package directory naming to lower case
In macOS (and windows) directory names are case insensitive, but in
Linux they are case sensitive. Therefore, when the "actorServiceProvider"
directory name was renamed to "actorserviceprovider", the change did not
propogate into git when a Macbook was used for development. This error
was discovered when working on a Ubuntu machine and is now fixed.
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Change-Id: Ifebe3d37d42e79fff8da2370369967a25c371b11
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Wed, 31 Jan 2018 13:42:53 +0000 (13:42 +0000)]
Merge "Fix technical debt/JUnit on SO/VFC/SO ACTOR"
Jorge Hernandez [Wed, 31 Jan 2018 13:39:55 +0000 (13:39 +0000)]
Merge "Fix technical debt/JUnit on actor service provider"
Jorge Hernandez [Tue, 30 Jan 2018 18:47:43 +0000 (18:47 +0000)]
Merge "Do not enforce hostname validation"
liamfallon [Sun, 28 Jan 2018 22:24:23 +0000 (22:24 +0000)]
Fix technical debt/JUnit on actor service provider
Unit test for actor service provider added and technical debt removed.
Change-Id: I9573f1c3ff0252b166e06caaa88eb679a1fc7347
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Tue, 30 Jan 2018 17:06:20 +0000 (17:06 +0000)]
Fix technical debt/JUnit on SO/VFC/SO ACTOR
Unit test expanded for SO POJOs, technical debt removed in SO actor and VFC pojos.
Change-Id: I23b886c40c1ac6ac8dc2ebbaade315b71cca9dd0
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Alexis de Talhouët [Mon, 29 Jan 2018 15:38:40 +0000 (10:38 -0500)]
Do not enforce hostname validation
Change-Id: I1c4e5d58126e35a64140c91c0c3afda5e9b3a5bd
Issue-ID: POLICY-510
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
liamfallon [Fri, 26 Jan 2018 14:31:09 +0000 (14:31 +0000)]
Fix Tech Debt/JUnit on SO actor
Unit test for SO actor added. SO actor service provider class refactored to remove technical debt.
Change-Id: I6186ede5661ce483917184f03ee44d57a124b6a4
Issue-ID: POLICY-455
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Tue, 23 Jan 2018 13:47:12 +0000 (13:47 +0000)]
Implement JUnit tests for actor.vfc
JUnit tests for the VFC actor implemented.
Change-Id: Ifcd433a4ce6f46cad46d50f4ce4c7c03e2abec67
Issue-ID: POLICY-455
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Mon, 22 Jan 2018 12:13:47 +0000 (12:13 +0000)]
Fix Tech Debt/JUnit on VFC actor
Unit test for VFC actor added.
Some minor chages to actor service provider class to remove technical debt.
Change-Id: I54ee24bcfa1c82f4a18c0035bdff186d4d3ebdf7
Issue-ID: POLICY-455
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Mon, 22 Jan 2018 14:31:03 +0000 (14:31 +0000)]
Merge "Fix Tech Debt/JUnit on VFC POJOs"
liamfallon [Sat, 20 Jan 2018 11:22:27 +0000 (11:22 +0000)]
Fix Tech Debt/JUnit on APPC and APPCLCM actors
Unit test updated to increase coverage on getter methods.
Constants added for some string literals to reduce technical debt warnings.
Change-Id: I3b175de7c65aa9d342e71adc951d1ee08c9d781b
Issue-ID: POLICY-455
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Fri, 19 Jan 2018 19:55:02 +0000 (19:55 +0000)]
Fix Tech Debt/JUnit on VFC POJOs
Making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods.
Unit test added for all classes in org.onap.policy.vfc
Issue-ID: POLICY-455
Change-Id: I262337a816706cd5243849cd51e57689275545bf
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Fri, 19 Jan 2018 18:56:33 +0000 (18:56 +0000)]
Merge "Fix Technical Debt, add Unit tests for SO"
Jorge Hernandez [Thu, 18 Jan 2018 20:02:58 +0000 (20:02 +0000)]
Merge "Fix Technical Debt, Unit Test for APPCLCM POJOs"
Jorge Hernandez [Thu, 18 Jan 2018 19:49:37 +0000 (19:49 +0000)]
Merge "Fix Tech Debt/JUnit on control loop event POJOs"
Liam Fallon [Wed, 17 Jan 2018 12:03:50 +0000 (12:03 +0000)]
Fix Technical Debt, Unit Test for APPCLCM POJOs
Mainly making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods. Unit test added for all classes in org.onap.policy.appclcm
Issue-ID: POLICY-455
Change-Id: Iae873f94a236cc9faeac5542a9633ca840b696ed
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Jorge Hernandez [Thu, 18 Jan 2018 19:44:09 +0000 (19:44 +0000)]
Merge "Fix Technical Debt, basic JUnit tests for Rest"
vdmeer [Thu, 18 Jan 2018 12:50:32 +0000 (12:50 +0000)]
Fix Technical Debt, add Unit tests for SO
Converted to POJOs, fixed sona lint errors, added JUnit tests
POJOs now have only private members and getters/setters
This implicated actors, simulators, and existing tests
Issue-ID: POLICY-455
Change-Id: I4b80f729565e8675822a890892b15676908f73b4
Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
Pamela Dragosh [Thu, 18 Jan 2018 12:53:09 +0000 (12:53 +0000)]
Merge "Fix Technical Debt for TrafficGenerator"
Liam Fallon [Thu, 18 Jan 2018 10:55:53 +0000 (10:55 +0000)]
Fix Tech Debt/JUnit on control loop event POJOs
Mainly making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods. Unit test added for all classes in org.onap.policy.controlloop
Issue-ID: POLICY-455
Change-Id: I445b7cfaf9eb921a230bbb72b06ff4455fe003ce
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
vdmeer [Wed, 17 Jan 2018 23:13:14 +0000 (23:13 +0000)]
Fix Technical Debt, basic JUnit tests for Rest
Basic tests for get and post
(not testing full user/pw/body)
Issue-ID: POLICY-455
Change-Id: I186ebf969abc239e5056199c2fd8da9f3253d2fc
Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
vdmeer [Wed, 17 Jan 2018 18:52:14 +0000 (18:52 +0000)]
Fix Technical Debt for TrafficGenerator
Changed formatting for checkstyle, changed sequence of statements
Left empty constructors as requested
Issue-ID: POLICY-455
Change-Id: I0e443bba69cede4c006a841d8d34c82391ff1040
Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
vdmeer [Wed, 17 Jan 2018 17:30:04 +0000 (17:30 +0000)]
Added all J Unit tests SDC
Issue-ID: POLICY-455
Change-Id: I8192e8a595642e0d36608591d95f21f3ee574d13
Signed-off-by: vdmeer.sven <sven.van.der.meer@ericsson.com>
Liam Fallon [Tue, 16 Jan 2018 18:42:01 +0000 (18:42 +0000)]
Fix Sonar Technical Debt, Unit Test for APPC POJOs
Mainly making fields private, fixing field and methods to follow Java guidelines, and adding getter and setter methods. Unit test added for all classes in org.onap.policy.appc
Change-Id: If3db740bc146a09f8f7387f02c12b048ad00b201
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Liam Fallon [Mon, 15 Jan 2018 22:43:07 +0000 (22:43 +0000)]
Restore getters and setters to AAINQResponse class
Some get and set methods were deleted from this class in error. This patch restores them.
Change-Id: I4dfaf1215e56f30a1d62d19624fe4da570e99171
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Jorge Hernandez [Mon, 15 Jan 2018 19:02:19 +0000 (19:02 +0000)]
Merge "Cleanup of A&AI message model module."
Alexis de Talhouët [Fri, 5 Jan 2018 18:10:39 +0000 (13:10 -0500)]
Add IntelliJ files to .gitignore
Change-Id: I45dd03d4295322ecc0f10c4673848c1fe85d5e98
Issue-ID: POLICY-509
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
Temoc Rodriguez [Thu, 14 Dec 2017 23:58:32 +0000 (15:58 -0800)]
Add guard junits
Added a few junit files which test most functionality in the guard
submodule. Some minor bugs were found by the junits and fixed those
newly found bugs. Added persistence.xml for use by junits in guard.
Issue-ID: POLICY-490
Change-Id: Ied7e276cfd417e1f396b5a6685a2e9acc9efd109
Signed-off-by: Temoc Rodriguez <cr056n@att.com>
Liam Fallon [Thu, 14 Dec 2017 15:40:18 +0000 (07:40 -0800)]
Cleanup of A&AI message model module.
Fields have been made fields private in POJOs, and wrote JUnit unit tests to bring up code coverage. AAIManager also changed to use non-static methods so that it can be stubbed with Mockito.
Change-Id: I871427ced5db8a1dfd6495fef4e6d84adf264e65
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Pamela Dragosh [Mon, 11 Dec 2017 04:21:33 +0000 (04:21 +0000)]
Merge "Technical Debt in AAI."
Jorge Hernandez [Wed, 6 Dec 2017 21:46:08 +0000 (15:46 -0600)]
remove synchronized calls to avoid race conditions
This is to prevent potential problems where multiple jar versions are
updated one after the other.
Change-Id: I78835b485e57125efb213cfdefba60351d815916
Issue-ID: POLICY-487
Signed-off-by: Jorge Hernandez <jh1730@att.com>
(cherry picked from commit
f2715bc0f272e5e657ed8a82c0f4e520a7c7706d)
Charles Cole [Thu, 7 Dec 2017 18:17:17 +0000 (12:17 -0600)]
Remove guard dependency from simulators
Removed the deendency on guard from the guard simulator tests so that
the guard simulator can be used to test guard functionality.
Issue-ID: POLICY-490
Change-Id: Ie67abb85e9844c412c483b1bbf3fb4aa21f3530a
Signed-off-by: Charles Cole <cc847m@att.com>
Liam Fallon [Wed, 6 Dec 2017 22:06:31 +0000 (23:06 +0100)]
Technical Debt in AAI.
Eliminate the technical debt identified in the drools-applications/controlloop/common/model-impl/aai module by Sonar
Change-Id: I72125baacc217386a4984be04bfc023439eddd13
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Signed-off-by: Liam Fallon <liam.fallon@ericsson.com>
EEILFN [Wed, 6 Dec 2017 17:19:07 +0000 (18:19 +0100)]
Actor service provider for VFC and Actor Unit Test
The service provider in the META-INF/services file for the VFC actor pointed at the APPC actor rather than the VFC actor, this is fixed to now point at the correct actor implementation. Alsothe Actor test POM is missing the actors 'appclcm' and 'vfc', thus excluding them from the unit test
Change-Id: I60bfd160952b7663aab355ae9c8b0aa362484874
Signed-off-by: EEILFN <liam.fallon@ericsson.com>
Issue-ID: POLICY-455
Signed-off-by: EEILFN <liam.fallon@ericsson.com>
Jessica Wagantall [Sun, 19 Nov 2017 02:36:44 +0000 (18:36 -0800)]
Bump minor version
Bump minor version in preparation for Amsterdam
branching.
Change-Id: Ia7e97a72053a2d1cd10c0b9d5c179817c3ac7e23
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Pamela Dragosh [Thu, 16 Nov 2017 19:09:02 +0000 (14:09 -0500)]
Update version.properties 1.1.2
Missed this in the last update.
Issue-ID: POLICY-436
Change-Id: I673f13d75c8676630a94f8706bf1ceea91608518
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 15 Nov 2017 16:47:35 +0000 (11:47 -0500)]
Upgrade to 1.1.2-SNAPSHOT
Released 1.1.1, now must bump patch by 1
Issue-ID: POLICY-436
Change-Id: I3f5e4c369575f6fe1fa06cabb96a5bd43cb11087
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Tue, 14 Nov 2017 00:57:19 +0000 (00:57 +0000)]
Merge "Update SO to use is-base-vf-module=false"
Hockla, Ali (ah999m) [Mon, 13 Nov 2017 23:12:28 +0000 (17:12 -0600)]
Update SO to use is-base-vf-module=false
Issue-ID: POLICY-447
Change-Id: I63cd5d20670f224aa4b9220b99ee40aad4f3e50c
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
Jorge Hernandez [Mon, 13 Nov 2017 18:45:53 +0000 (12:45 -0600)]
default archetype tooling to 1.1.1
Change-Id: I84cf9fe9e954a9ee9bac8eaff56169e44154e9c5
Issue-ID: POLICY-446
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Jorge Hernandez [Sat, 11 Nov 2017 03:54:23 +0000 (03:54 +0000)]
Merge "Fix release job"
Pamela Dragosh [Sat, 11 Nov 2017 01:11:58 +0000 (20:11 -0500)]
Fix release job
Missing staging repo
Issue-ID: POLICY-441
Change-Id: Ib652d90ced62d8e96fd737ddd491c7a96d5dd45c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Hockla, Ali (ah999m) [Fri, 10 Nov 2017 17:27:15 +0000 (11:27 -0600)]
Fix SO Request mismatch and udpate AAI NQ response
Issue-ID: POLICY-438
Change-Id: I1d27d0e5f7d253aa3cba82f5f4b515c01be35d8b
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
Hockla, Ali (ah999m) [Thu, 9 Nov 2017 14:38:35 +0000 (08:38 -0600)]
Fix SO Request structure
Issue-ID: POLICY-438
Change-Id: I05e634782004fff5540b3e6fabb9e22846438cb1
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
Jorge Hernandez [Thu, 9 Nov 2017 04:03:10 +0000 (04:03 +0000)]
Merge "Fix SO Request body"
Jorge Hernandez [Wed, 8 Nov 2017 23:59:42 +0000 (23:59 +0000)]
Merge "Update SNAPSHOT version"
Hockla, Ali (ah999m) [Wed, 8 Nov 2017 23:27:16 +0000 (17:27 -0600)]
Fix SO Request body
- Renamed modelNameVersionId to modelVersionId in SOModelInfo
- Removed requestID from SO Request body
- As a result of this, an SOResponseWrapper was needed in order to
attach the control loop event requestId to use in the SOResponse
rule in drl (the requestID that is returned in the SO response
is a newly generated requestId with no relation to the Policy
control loop event requestId as per Arthur)
- Updated drl to reflect the above mentioned change
- Updated simulator and junits to reflect changes
- Added an additional null httpResponse check/logger statement in SOManager and RestManager
Issue-ID: POLICY-438
Change-Id: I5f414ba69b60b5565cca9073b47f4c4835e5abbf
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>