policy/pap.git
5 years agoOne year cert with new component names 83/85383/2
jhh [Mon, 15 Apr 2019 23:22:08 +0000 (18:22 -0500)]
One year cert with new component names

Change-Id: I46bc9b12d3edef995a2a04ee9a7fdc1830574bd5
Issue-ID: POLICY-1580
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
5 years agoFix sonar issues in PAP 71/85371/3
Jim Hahn [Mon, 15 Apr 2019 18:37:46 +0000 (14:37 -0400)]
Fix sonar issues in PAP

Moved methods into nested class of PdpModifyRequestMap.  Note: they
will have to be moved back out when the broadcast capability is
added.
Removed extra "continue" from Publisher.
Rather than remove unused parameters and cause significant clutter
to the code, chose to use the parameters in a logger call for RequestImpl.
Removed unnecessary cast from UpdateReq.
Use version constant in PapRestControllerV1.
Log exception in PdpGroupQueryControllerV1.
Log exception in PdpGroupStateChangeControllerV1.
Shortened functional in PdpGroupDeleteProvider.
Removed unnecessary type parameters from PdpGroupDeployProvider.
Removed unneeded parameter and exception from ProviderBase.
Extracted common string from Main.
Shorted functionals in PapActivator.
Changed uses of getCanonicalName() to getName(); the former only has
limited use, while the latter is typically what is wanted and is
actually required whenever forClass(name) is used.
Fix junit tests broken by rename of ToscaPolicy version from
"typeVersion" to "type_version".

Change-Id: Ia00e1b3541c9e25b196a951e45681f67aa7f1bfe
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoSupport integer policy-version 47/85347/2
Jim Hahn [Mon, 15 Apr 2019 14:19:26 +0000 (10:19 -0400)]
Support integer policy-version

The deploy/undeploy APIs used by CLAMP only pass the major number
when specifying a policy-version.  Modified the code to handle
policy-versions of the form, major or major.minor.

Change-Id: I3251df162984f287bd1430b8e46da675b4c265ee
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoSupport group-oriented REST API 37/85237/7
Jim Hahn [Fri, 12 Apr 2019 14:00:05 +0000 (10:00 -0400)]
Support group-oriented REST API

Added code to support PDP group create/update & delete REST API calls.
The create/update request can also be used to deploy/undeploy policies.
It is assumed that the create/update request specifies a valid
list of supported policy types for each subgroup (i.e., PDP type).
Updated due to elimination of "version" from group in policy/models.
Added/updated junits.

Change-Id: I1916d9b17dfd5f12129c6f6a2fcf54e706662c10
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoUpdate PDP with null group/subgroup when disabled 53/85253/5
Jim Hahn [Sat, 13 Apr 2019 01:02:53 +0000 (21:02 -0400)]
Update PDP with null group/subgroup when disabled

Modified the code so that, when a PDP is unable to fulfill a request,
an UPDATE is sent to the PDP with group=null and subgroup=null.
Also made updates to eliminate group version due to changes in
policy/models.

Change-Id: I9400ef5f8c365f492113a5b592b9ee6b7218756e
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdding code for db config & initial group creation 19/85119/2
ramverma [Thu, 11 Apr 2019 22:09:38 +0000 (22:09 +0000)]
Adding code for db config & initial group creation

1) Adding code for initial PdpGroup/Subgroup creation.
2) Adding db configuration
3) Updated code as per change in policy/models

Change-Id: If37870925001b333e0537e364eecb266c351cf5a
Issue-ID: POLICY-1635
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoDon't change group version number 09/85109/1
Jim Hahn [Wed, 10 Apr 2019 17:58:05 +0000 (13:58 -0400)]
Don't change group version number

Modified code to update a PdpGroup, adding or removing policies, without
changing the version number.

Change-Id: I10031dff5f6d9c7e568605a8d73af6fe3c740901
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoFix junits broken with policy-id change 03/85103/1
Jim Hahn [Thu, 11 Apr 2019 15:29:16 +0000 (11:29 -0400)]
Fix junits broken with policy-id change

Several junit tests were broken when the json-encoded names were
changed for the fields within ToscaPolicyIdentifierOptVersion.  This
review fixes those junit tests.

Change-Id: I963190b7792a2ebc3165ef04c74f4671c41c37da
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoRemove PDP from all active groups 71/84971/2
Jim Hahn [Wed, 10 Apr 2019 12:48:10 +0000 (08:48 -0400)]
Remove PDP from all active groups

The code to disable a PDP used the group name, extracted from a
prior PdpUpdate request, to identify the group from which the PDP
should be removed.  This is not sufficient, as the requests tracker
may have never seen an update request.  Therefore, the code was
modified to simply remove the PDP from all active groups.  Also
made removeFromGroups(pdpName) public so that it can be used by
other PAP code.

Change-Id: Iedec88cb23e586944563dcc5ac82ff3b9f122f8c
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoMerge "Add junit tests for PdpGroupDeleteProvider"
Jorge Hernandez [Wed, 10 Apr 2019 18:24:05 +0000 (18:24 +0000)]
Merge "Add junit tests for PdpGroupDeleteProvider"

5 years agoMerge "Refactor request map"
Jorge Hernandez [Wed, 10 Apr 2019 18:23:32 +0000 (18:23 +0000)]
Merge "Refactor request map"

5 years agoMerge "Adding final dmaap & db configurations"
Jorge Hernandez [Wed, 10 Apr 2019 17:31:38 +0000 (17:31 +0000)]
Merge "Adding final dmaap & db configurations"

5 years agoAdd junit tests for PdpGroupDeleteProvider 05/84905/1
Jim Hahn [Wed, 10 Apr 2019 16:08:53 +0000 (12:08 -0400)]
Add junit tests for PdpGroupDeleteProvider

Change-Id: Id744a7d49b9fb608ba3379dd43bcbd6a0297891f
Issue-ID: POLICY-1541
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoMerge "Current draft of undeploy"
Liam Fallon [Wed, 10 Apr 2019 16:22:25 +0000 (16:22 +0000)]
Merge "Current draft of undeploy"

5 years agoCurrent draft of undeploy 00/84300/2
Jim Hahn [Wed, 10 Apr 2019 13:26:59 +0000 (09:26 -0400)]
Current draft of undeploy

Change-Id: If3f01a6e92bef9eb889066115537f599e6b09229
Issue-ID: POLICY-1541
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoFix eclipse warning in SessionData 75/84875/1
Jim Hahn [Wed, 10 Apr 2019 13:17:48 +0000 (09:17 -0400)]
Fix eclipse warning in SessionData

Change-Id: I0c11b9704960f1b0b4d4c099a1b582ee259524e0
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdding final dmaap & db configurations 54/84854/2
ramverma [Wed, 10 Apr 2019 11:35:30 +0000 (11:35 +0000)]
Adding final dmaap & db configurations

Change-Id: I547f8a520d84d3593f90256fa91fc964c1d1e83c
Issue-ID: POLICY-1443
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoRefactor request map 62/84762/4
Jim Hahn [Mon, 8 Apr 2019 14:16:00 +0000 (10:16 -0400)]
Refactor request map

Refactored to facilitate the addition of broadcast requests in the
future.
Added disable-PDP capability.
Updated some comments.
Add junit tests.
Only treat null group as broadcast - empty strings are not broadcasts.
Added more logging.

Change-Id: I6f62b8755d20769c333f06752e9d63ac9ed83b57
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoFix review comments & add updateLock 56/84756/1
ramverma [Tue, 9 Apr 2019 21:39:55 +0000 (21:39 +0000)]
Fix review comments & add updateLock

1) Fixing review comments from previous review.
2) Adding updateLock to registration handler & state change provider.

Change-Id: I9f6e0de1f58190e490b28965c84a3a0c7aa90486
Issue-ID: POLICY-1443
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoAdding PdpGroup query & statechange providers 46/84646/5
ramverma [Tue, 9 Apr 2019 16:49:43 +0000 (16:49 +0000)]
Adding PdpGroup query & statechange providers

1) Adding implementation of PdpGroup Query & State change providers for
PAP REST API.
2) Adding support for unregistering Pdp after recieving TERMINATED state
in PdpStatus message.
3) Updating PdpStatusMessageHandler with new filter changes in models.
4) Removing updatePdpStatistics method as we will implement db provider
and REST provider in next release.
5) Fixing few bugs found during Pdp registration testing.
6) Updating the existing test cases to work.
7) Will be adding more exhaustive test cases in another review.

Change-Id: I7aa20bf422671fdc1e06dab5e90aef4ee19a6a02
Issue-ID: POLICY-1541
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoAdds basic performance tests for Policy PAP 46/84546/1
Bilal A [Mon, 8 Apr 2019 16:56:51 +0000 (12:56 -0400)]
Adds basic performance tests for Policy PAP

Includes
1) Basic health and stats tests
2) Log analysis script

Change-Id: I6d8f7a0203251d9b685b89c4d0c8e19cd74c24c6
Issue-ID: POLICY-1460
Signed-off-by: Bilal A <bilal@research.att.com>
5 years agoMerge "Wrong models-pdp in pap"
Pamela Dragosh [Mon, 8 Apr 2019 11:44:37 +0000 (11:44 +0000)]
Merge "Wrong models-pdp in pap"

5 years agoMerge "Add latest-version check to status msg handler"
Liam Fallon [Mon, 8 Apr 2019 05:39:56 +0000 (05:39 +0000)]
Merge "Add latest-version check to status msg handler"

5 years agoWrong models-pdp in pap 37/84437/1
Jim Hahn [Sun, 7 Apr 2019 14:34:45 +0000 (10:34 -0400)]
Wrong models-pdp in pap

Policy/pap was still referring to models-pdp instead of
policy-models-pdp.

Change-Id: Ia39647a7fe3d29fe5d67ee6f8f57a296f4cc4347
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdd latest-version check to status msg handler 10/84410/1
Jim Hahn [Fri, 5 Apr 2019 23:39:52 +0000 (19:39 -0400)]
Add latest-version check to status msg handler

PdpGroupFilter now supports filtering by latest version.  Removed a
TODO from PdpStatusMessageHandler and added the filter parameter.

Change-Id: I67983397b616d8e289c4dc79d912bb4cf26e97ae
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoDelay DB updates until all policies processed 08/84408/3
Jim Hahn [Fri, 5 Apr 2019 21:02:06 +0000 (17:02 -0400)]
Delay DB updates until all policies processed

If an exception is thrown in the middle of processing policies, it's
possible for the DB to reflect a partial deployment.  This change
queues the DB changes so that they're all made at once, after all
policies have been processed.
Extracted sort() into a common place.
Corrected some comments.
Simplified the list retrieval in the junits since all DB creates and
updates are now batched together into one operation each.

Change-Id: I835175fc16d4042c741d36ec69caa8f603d46d5a
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoMerge "Fix csit of policy/pap"
Pamela Dragosh [Fri, 5 Apr 2019 22:25:57 +0000 (22:25 +0000)]
Merge "Fix csit of policy/pap"

5 years agoFix csit of policy/pap 93/84393/1
ramverma [Fri, 5 Apr 2019 20:25:46 +0000 (20:25 +0000)]
Fix csit of policy/pap

Change-Id: I1158a6a7f0582dabafb22961d073db6d14cf2793
Issue-ID: POLICY-1443
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoFlesh out policy deployment REST API 52/84352/2
Jim Hahn [Fri, 5 Apr 2019 13:52:35 +0000 (09:52 -0400)]
Flesh out policy deployment REST API

Also moved the controller, the provider, and supporting classes
to their own dep_undep package.

Change-Id: Ifea1c4dd2ecbf93a8f4d45e130830cf9271103d3
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoFixes per latest models updates 47/84347/1
Jim Hahn [Fri, 5 Apr 2019 13:03:15 +0000 (09:03 -0400)]
Fixes per latest models updates

Changes made per the scrum call on 4/4 moved things around.  In
addition, filter classes were added to the tosca provider.  Both
of these necessitated changes to policy/pap so that things compile.

Change-Id: Iba4c52b650dab0f8d242b06be3fede42dd5b7264
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdding more code to pdp registration handler 56/84156/2
ramverma [Thu, 4 Apr 2019 08:57:18 +0000 (08:57 +0000)]
Adding more code to pdp registration handler

1) Adding more code to pdp registration handler.
2) Fixing few broken files.

Change-Id: Ic8b68f95f7022ce0572345ea358ff380ec8a3e61
Issue-ID: POLICY-1443
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoFix classes in pap to align with change in models 23/84123/2
ramverma [Wed, 3 Apr 2019 17:53:57 +0000 (17:53 +0000)]
Fix classes in pap to align with change in models

Change-Id: I0ecef8f004967e2fffa33eff2ee7e6f035d3d94c
Issue-ID: POLICY-1443
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoChanges in pdp registration handler 04/84104/1
ramverma [Wed, 3 Apr 2019 14:26:01 +0000 (14:26 +0000)]
Changes in pdp registration handler

1) Fix left over comments from previous review.
2) Change from PdpGroups to List<PdpGroup>

Change-Id: I833d4cf2837babf0947c9999220a651f9a69bf7e
Issue-ID: POLICY-1443
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoAdding PdpStatus listener & handler to policy/pap 91/83991/1
ramverma [Tue, 2 Apr 2019 17:50:15 +0000 (17:50 +0000)]
Adding PdpStatus listener & handler to policy/pap

1) Adding PdpHeartbeatListener to keep listening for PdpStatus messages
coming from Pdp's over DMaaP either for registration or just heartbeat.
2) Adding PdpStatusMessageHandler to handle new Pdp registration and
also heartbeat coming from Pdp's.
Registration Flow -
 1. Find the PdpSubgroup based on PdpType & SupportedPolicyTypes coming
    in PdpStatus message.
 2. If not found, don't register pdp and log the error message.
 3. If found, check if PdpInstance is already added.
 4. If not added, add PdpInstance to the subgroup and increment the
    currentInstanceCount.
 5. Create and send PdpUpdate & PdpStateChange message to the Pdp.
 6. Update the changes in DB.

Heatbeat Flow -
 1. Find the PdpInstance based on details in PdpStatus message.
 2. Validate the details from message to what in DB.
 3. If correct, persist the health & statistics information in DB.
 4. If not correct, send a PdpUpdate & PdpStateChange message to the Pdp.

3) Unit tests will come as seperate review.

Change-Id: If705193259999e2ab077b78961282c998b949f57
Issue-ID: POLICY-1443
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoRemove pdpType from tests 82/83982/1
Jim Hahn [Tue, 2 Apr 2019 15:03:51 +0000 (11:03 -0400)]
Remove pdpType from tests

Somehow, pdpType is was still referenced by junit tests.  Thought I
had fixed that, but guess not.

Change-Id: I8060208129cb2c6ba1ecb21d65efb778a2778aa5
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdd mapper class 58/83658/11
Jim Hahn [Fri, 29 Mar 2019 22:36:56 +0000 (18:36 -0400)]
Add mapper class

Added class to map between classes in models-pap and models-pdp.
Used constants in appropriate places.
Re-use maker functions.
Added some comment.
Corrected a comment.
Added mapping method for PdpDeployPolicies.
Added PdpDeployPolicies to "internal" package.
Updated to reflect refactoring of ToscaPolicy.
Fixed bug/typo in assertEquals test.

Updated tests to work with models-pdp not based on PfConceptKey.

Change-Id: I31cd4aaf58fa7dc39cea76349cc1337637a1b786
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoFix issues with timer manager junits 44/83744/4
Jim Hahn [Fri, 29 Mar 2019 13:57:17 +0000 (09:57 -0400)]
Fix issues with timer manager junits

Attempt to fix intermittent issues with junit tests for timer manager.
Eliminated duplicate method in junit test and renamed another method.
Always release a semaphore, just to be sure.
Logged different message depending whether timer is cancelled or expired.
Locked access to the current time to prevent the timer thread from
accessing it while registering a new timer.

Change-Id: Icb499acb18197fd8042eb186f88b61d5c30daeb0
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdding db provider parameters to pap config file 01/83501/1
ramverma [Wed, 27 Mar 2019 16:27:36 +0000 (16:27 +0000)]
Adding db provider parameters to pap config file

Change-Id: I573a345bcf69eb40782277f211fff2b7c69c4f55
Issue-ID: POLICY-1443
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoAdd and register DAO provider wrapper 86/83486/3
Jim Hahn [Wed, 27 Mar 2019 13:07:37 +0000 (09:07 -0400)]
Add and register DAO provider wrapper

Added a DAO provider wrapper supporting a single create() method
to create a DAO provider.  PapActivator registers it at start-up.
Commented out some junit timer tests that seem to fail intermittently -
doesn't impact code coverage.

Removed TODO from close() method.

Change-Id: Ie3abd7c7a4f9ffa7aa086609515a0bb3891585d9
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdd components for PDP communication 78/83278/5
Jim Hahn [Sun, 24 Mar 2019 12:13:58 +0000 (08:13 -0400)]
Add components for PDP communication

Added PAP DAO interfaces.
Added Publisher.
Added TimerManager.
Added RequestDataParams.
Added PdpModifyRequestMapParams.
Added RequestData.
Added PdpModifyRequestMapTest.
Updated timer test.
Extracted nested MessageData classes into their own files.
Addressed merge conflict.
Removed unneeded methods from PapActivator.

Fixed mismatchint action name.

Change-Id: I3aebef68a62b48d9154dd7a4c4ff366f9914717c
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoChanges to PAP infrastructure to support PDP 20/83120/6
Jim Hahn [Sun, 24 Mar 2019 12:13:58 +0000 (08:13 -0400)]
Changes to PAP infrastructure to support PDP

Modified PapActivator to implement the Startable interface and used
that to manage it instead of the original method names.
Replaced pdp-common enums with models-pdp enums.
Added the use of the Registry.
Added parameters to be used for PDP interaction.
Added DAO interface classes.
Modified HTTP client, in junit tests, to use GSON instead of Jackson.
Removed DAO code, as the interfaces are not merged into policy/common
yet.
Added pdpParameters to default json config file.
Changed tabs to spaces in json files.

Removed "internal" classes that were moved to models-pdp.

Change-Id: I969a7747e926680ad403557b44a0a52d289fb6d9
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdding query & state change PAP REST API's 12/82812/1
ramverma [Wed, 20 Mar 2019 15:05:45 +0000 (15:05 +0000)]
Adding query & state change PAP REST API's

Change-Id: I861ace4811032314c3ce2c3f227f17354e127e5e
Issue-ID: POLICY-1541
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoAdd NSS libraries to images 32/82532/1
Jorge Hernandez [Sun, 17 Mar 2019 05:24:34 +0000 (00:24 -0500)]
Add NSS libraries to images

Alpine OpenJDK was updated 2 days ago (3/14), this
upgrade seems to break java applications that depend on libnss*.so
OS libraries, which seem are no longer installed with the jdk.

Added some other libraries to aid when debugging

Change-Id: I0f5cbe5792038cf569940a1b32c109c9dd1e66cc
Issue-ID: POLICY-1604
Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
5 years agoMerge "Update INFO.yaml file"
Pamela Dragosh [Sat, 16 Mar 2019 14:56:13 +0000 (14:56 +0000)]
Merge "Update INFO.yaml file"

5 years agoMerge "Add additional constructors to Exception classes"
Jorge Hernandez [Sat, 16 Mar 2019 14:51:45 +0000 (14:51 +0000)]
Merge "Add additional constructors to Exception classes"

5 years agoUpdate INFO.yaml file 96/82496/1
Jessica Wagantall [Fri, 15 Mar 2019 20:54:13 +0000 (13:54 -0700)]
Update INFO.yaml file

Update missing information blocks and
indentation to pass verify job.

Change-Id: I03eecae246a9da24c82d60aae19cce12b1f62d0b
Issue-ID: CIMAN-134
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
5 years agoUpdates to PDP deploy/undeploy per Ram's comments 11/82311/5
Jim Hahn [Fri, 15 Mar 2019 17:23:57 +0000 (13:23 -0400)]
Updates to PDP deploy/undeploy per Ram's comments

Change-Id: Ic038ec8571cb50918c5f0d63602112ca05233629
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdd additional constructors to Exception classes 69/82469/2
Jim Hahn [Fri, 15 Mar 2019 17:28:08 +0000 (13:28 -0400)]
Add additional constructors to Exception classes

Modified test class to use auto-tester.
Updated comments.
Updated licenses.

Change-Id: I993d0b78f31d15e6e6c35b701ed801616708628a
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdd simple deploy/undeploy REST API 06/82206/1
Jim Hahn [Wed, 13 Mar 2019 21:58:17 +0000 (17:58 -0400)]
Add simple deploy/undeploy REST API

Change-Id: I4b789bfe4f92dae930f3675c6648b90f3c9fc9e4
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdd PDP Group Deploy and Delete REST API stubs 99/79799/6
Jim Hahn [Tue, 12 Mar 2019 15:53:22 +0000 (11:53 -0400)]
Add PDP Group Deploy and Delete REST API stubs

Note: this will not build until the models-pap code has been added.

Added PDP group Delete methods, with and without version.

Added checks for OK status codes.

Added topic configuration.
Still does not have the "simplified" PDP Group deploy/undeploy.
Still won't build without "Move PDP Group classes to concepts subdirectory".

Will add junit tests for code changes in another review.
Updated comments about unlocking after updates.
Made ServiceManager final.
Included topic start/stop actions.
Fixed parameter comment.
Removed unneeded parameters from json files.
Fixed argument test in shell script.
Updated licenses.

Change-Id: I6176d51918ae758e04fb68562dc9ca70534137d4
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoMerge "Refactor REST server tests"
Jorge Hernandez [Thu, 7 Mar 2019 16:10:34 +0000 (16:10 +0000)]
Merge "Refactor REST server tests"

5 years agoMerge "Use Alpine as base docker image in /policy/pap"
Jorge Hernandez [Thu, 7 Mar 2019 14:53:45 +0000 (14:53 +0000)]
Merge "Use Alpine as base docker image in /policy/pap"

5 years agoRefactor REST server tests 05/79805/8
Jim Hahn [Wed, 6 Mar 2019 16:03:57 +0000 (11:03 -0500)]
Refactor REST server tests

Refactored the REST server tests so that each controller has
its own test class.
Also ensure things are shutdown by various tests.

Added comments.
Removed unneeded constant.
Updated license.

Modified code that restarts the REST server during tests.

Modified code to just change the activator's "alive" state to
false, leaving the REST server running.

Fixed comment.

Allocated server port.

Removed file that should not have been included.

Changed code to throw exceptions if activator methods are called while
in the wrong state.

Change-Id: I04a3a6654150797c23b3c86a6a39ecf8bb7f5a78
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoMerge "Use request id instead of PDP name in listener"
Pamela Dragosh [Wed, 6 Mar 2019 16:33:58 +0000 (16:33 +0000)]
Merge "Use request id instead of PDP name in listener"

5 years agoUse request id instead of PDP name in listener 41/79741/5
Jim Hahn [Tue, 5 Mar 2019 22:19:33 +0000 (17:19 -0500)]
Use request id instead of PDP name in listener

Modified the listener that receives messages from the PDPs
to use the request id instead of the PDP name for tracking
purposes.

Modified the listener to make it more generic so any arbitrary ID
can be used, depending on the context.

Combined extractId into handleEvent.

Corrected a comment.

Change-Id: I6b7097c67d73f51b78ae4063341bcb118eb14bbc
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoUse Alpine as base docker image in /policy/pap 51/79751/1
ning.xi [Wed, 6 Mar 2019 03:24:28 +0000 (03:24 +0000)]
Use Alpine as base docker image in /policy/pap

Issue-ID: POLICY-1553
Change-Id: Ie69d32c0d8c23ff2fadeb074e654f20c1acbdf76
Signed-off-by: ning.xi <ning.xi@est.tech>
5 years agoRefactor PAP REST controller 34/79734/2
Jim Hahn [Tue, 5 Mar 2019 20:15:28 +0000 (15:15 -0500)]
Refactor PAP REST controller

Split health check and statistics REST controllers out of the
PAP REST controller and made PAP REST controller into a superclass.

Change-Id: I6f492c9fd5d058d81143ed34d70760dbd05a5770
Issue-ID: POLICY-1542
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoReceive PDP status messages 60/79660/3
Jim Hahn [Wed, 27 Feb 2019 20:35:22 +0000 (15:35 -0500)]
Receive PDP status messages

Added infrastructure code to facilitate receipt and tracking of
PDP status messages.

Removed temporary PdpStatus class.

Use variable for pdp-common version.

Change-Id: Id76c45f26b6d9f5eb9395332b637a0b1e90bc496
Issue-ID: POLICY-1444
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoMerge "Update INFO.yaml Liam's email"
Liam Fallon [Mon, 4 Mar 2019 14:04:58 +0000 (14:04 +0000)]
Merge "Update INFO.yaml Liam's email"

5 years agoMerge "Use Coder class"
Jorge Hernandez [Thu, 28 Feb 2019 18:03:15 +0000 (18:03 +0000)]
Merge "Use Coder class"

5 years agoUpdate INFO.yaml Liam's email 70/79370/1
Pamela Dragosh [Thu, 28 Feb 2019 15:24:56 +0000 (10:24 -0500)]
Update INFO.yaml Liam's email

est.tech

Issue-ID: POLICY-1556
Change-Id: I978b0df092c5bc2020ef16862d8653c230e3936b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoReference lombok from parent 63/79363/2
Pamela Dragosh [Thu, 28 Feb 2019 14:44:47 +0000 (09:44 -0500)]
Reference lombok from parent

Policy/parent now declares lombok dependency - remove the
version so that we are consistent.

Also must change this repo to point to correct policy/parent.

Issue-ID: POLICY-1547
Change-Id: I6530b7d34ba4f4bd826e07e9d27ec83d6be94b0d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoMerge "Add code to publish to PDP"
Jorge Hernandez [Thu, 28 Feb 2019 15:05:33 +0000 (15:05 +0000)]
Merge "Add code to publish to PDP"

5 years agoUse Coder class 07/79307/2
Jim Hahn [Wed, 27 Feb 2019 16:31:34 +0000 (11:31 -0500)]
Use Coder class

Modified existing PAP code to use the Coder class instead of Gson.

Change-Id: I770d0adf201d7c1118085f85c36582e1143deb08
Issue-ID: POLICY-1444
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoAdd code to publish to PDP 16/79216/4
Jim Hahn [Tue, 26 Feb 2019 19:09:35 +0000 (14:09 -0500)]
Add code to publish to PDP

Added code to take an arbitrary object and send it to PDPs using a
topic sink.  Does not include the code or properties needed to
configure the topic.

Fixed method name - test case does not cover what the method name
implied.
Fixed some comments.

Add test to verify that the PdpClient works with a real TopicSink.

Moved coder classes to policy/common.

Change-Id: I4dec746b07d384c5d9d1449ca91fa39a4f680260
Issue-ID: POLICY-1444
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoReplace static methods with single getInstance 18/79118/3
Jim Hahn [Mon, 25 Feb 2019 16:36:23 +0000 (11:36 -0500)]
Replace static methods with single getInstance

Some of the PAP classes use a number of static methods.  These have
been modified to use regular, non-static methods, a single static
method, getInstance.
Also modified PapStatisticsManager so its methods are thread safe.
Changed "instance" to "current" for the activator, as it may be changed.
Fix new checkstyle issues.
Updated copyrights.
Renamed test class to be consistent.
Added test for getCurrent/setCurrent and isAlive.

Change-Id: Id6df55fa4c116852032ad61f80f899fcd292f864
Issue-ID: POLICY-1444
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoUse constants for http property names 52/79052/4
jh7358 [Fri, 22 Feb 2019 21:41:54 +0000 (16:41 -0500)]
Use constants for http property names

Modified the PAP REST server to use constants from policy-endpoints
instead of hard-coding property names.
Also made "alive" volatile.
Also modified to use standard gson as the serialization provider to
ensure that it will always work with gson.
Removed unneeded constant.
Removed trailing whitespace.
Replaced another literal with a constant name.
Updated licenses.

Change-Id: Ibfc6d19ad4dae62ebd610d6127d1d253175ae71e
Issue-ID: POLICY-1444
Signed-off-by: Jim Hahn <jrh3@att.com>
5 years agoMerge "Adds basic stability tests for Policy PAP"
Liam Fallon [Fri, 22 Feb 2019 10:40:53 +0000 (10:40 +0000)]
Merge "Adds basic stability tests for Policy PAP"

5 years agoAdds basic stability tests for Policy PAP 44/78944/1
Bilal A [Thu, 21 Feb 2019 16:31:02 +0000 (11:31 -0500)]
Adds basic stability tests for Policy PAP

Includes
1) Basic health check test
2) Statistics API test

Change-Id: I89bd11e1f10a2b6cdd3cf440654f3415f21f9edb
Issue-ID: POLICY-1460
Signed-off-by: Bilal A <bilal@research.att.com>
5 years agoAdd swagger annotations to PAP API's 60/78860/2
ramverma [Thu, 21 Feb 2019 11:21:10 +0000 (11:21 +0000)]
Add swagger annotations to PAP API's

Change-Id: I2adafa5957bb4ede76196c6ac887a45b3375ce48
Issue-ID: POLICY-1480
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoCreating package & docker image of policy/pap 45/78145/2
ramverma [Mon, 11 Feb 2019 15:20:09 +0000 (15:20 +0000)]
Creating package & docker image of policy/pap

1) Creating zip package of entire policy pap.
2) Creating docker image of policy pap.

Change-Id: I41bd705966e75e9cf501154da71f90d11ff2b3e1
Issue-ID: POLICY-1478
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoAdding statistics endpoint to policy/pap 92/78092/1
ramverma [Thu, 7 Feb 2019 21:52:23 +0000 (21:52 +0000)]
Adding statistics endpoint to policy/pap

1) Adding statistics endpoint to policy pap component.
2) Introducing lombok libraray.
3) Adding configurable support for aaf authentication.
4) Adding configurable support for https communication.
5) Adding related test cases.

Change-Id: Ib3131810c42fbd23878b97302da8d54f095da373
Issue-ID: POLICY-1482
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoAdding healthcheck endpoint to policy/pap 93/77793/2
ramverma [Tue, 5 Feb 2019 10:28:22 +0000 (10:28 +0000)]
Adding healthcheck endpoint to policy/pap

1) Adding healthcheck REST endpoint to policy/pap using the
policy-endpoints module in policy/common.
2) Added the related unit test cases.

Change-Id: I6a215cceccc9cd42494aef1dfcdd46f0f3fd7d13
Issue-ID: POLICY-1477
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoCreate basic structure of pap component 42/77642/1
ramverma [Thu, 31 Jan 2019 13:09:00 +0000 (13:09 +0000)]
Create basic structure of pap component

1) Creating the basic code structure of pap component which includes
main sub-module having Main, PapActivator, PapCommandLineArguments,
PapParameterGroup & PapParameterHandler. Along with few exception
classes. Basicalliy the structure follows the pattern developed in
policy/distribution component.

2) Created the related unit test cases and required test resources.

Change-Id: I67c82f9d072e6c8a306cb983accb693da70e58a2
Issue-ID: POLICY-1476
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoUpgrade policy/parent 2.0.0 46/71246/1
Pamela Dragosh [Thu, 25 Oct 2018 14:56:23 +0000 (10:56 -0400)]
Upgrade policy/parent 2.0.0

Policy parent v2.0.0

Issue-ID: POLICY-1213
Change-Id: I29ac8768b14072872da4a108173b9afd77230023
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoSetup checkstyle and coverage 77/68877/4
Pamela Dragosh [Tue, 25 Sep 2018 13:47:24 +0000 (09:47 -0400)]
Setup checkstyle and coverage

Added plugin management pieces for code coverage and
checkstyle for future development.

Added entries to gitignore for idea and checkstyle.

Removed redundant version.

Change-Id: Idca740a42b562e95319d5c196c1c3d5a0e16f214
Issue-ID: POLICY-1136
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoChanging artifactId for consistency 99/49499/1
ramverma [Wed, 30 May 2018 14:08:00 +0000 (15:08 +0100)]
Changing artifactId for consistency

Change-Id: I4e3a125a265c42d3987de09418aea54e4c9eb8d2
Issue-ID: POLICY-848
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
6 years agoChange pom to refer policy parent 49/48949/1
ramverma [Thu, 24 May 2018 13:23:19 +0000 (14:23 +0100)]
Change pom to refer policy parent

Change-Id: I32a2bc44ab87335738288de1b29c56339f4e17b4
Issue-ID: POLICY-848
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
6 years agoMerge "Update pap repo"
Pamela Dragosh [Tue, 1 May 2018 17:24:47 +0000 (17:24 +0000)]
Merge "Update pap repo"

6 years agoUpdate pap repo 47/45447/1
Pamela Dragosh [Tue, 1 May 2018 14:15:39 +0000 (10:15 -0400)]
Update pap repo

Updated license, readme and version to 2.0.0

Issue-ID: POLICY-771
Change-Id: I8b030a2733144bd7b117824dd4e02b10c687d39d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoAdd INFO.yaml file 71/45371/2
Jessica Wagantall [Tue, 1 May 2018 03:08:33 +0000 (20:08 -0700)]
Add INFO.yaml file

Add INFO.yaml to list:
- Project description
- Properties
- PTL information
- Meeting information
- Committer information

Change-Id: I96d1a9506d8fb811f7f164234c5c454c60b74368
Issue-ID: CIMAN-134
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
6 years agoUpdate oparent version to 1.1.0 45/35845/1
liamfallon [Wed, 14 Mar 2018 21:40:03 +0000 (21:40 +0000)]
Update oparent version to 1.1.0

Directive from ONAP project that all repos should be updated.
Change vierified with a build with .m2 /org/onap cleared.

Change-Id: I8f92975e5f112d64967ca0f2c1cfa5dab56d524d
Issue-ID: POLICY-693
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoCleanup project's name in Sonar 11/11411/1
Jessica Wagantall [Fri, 8 Sep 2017 21:59:40 +0000 (14:59 -0700)]
Cleanup project's name in Sonar

The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.

Change-Id: I817524eff0554b5f9684de7b595ba6da81b07c7c
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
6 years agoRemoving duplicate version entries 41/11141/1
Pamela Dragosh [Fri, 8 Sep 2017 15:46:32 +0000 (11:46 -0400)]
Removing duplicate version entries

Seems oparent sets these and Eclipse dumps warnings that these are duplicates.

Issue-ID: POLICY-216
Change-Id: I006cc0d4d77b452896cc86b2cd0461c0e3161ab2
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoAdd version.properties 49/7949/1
Pamela Dragosh [Thu, 17 Aug 2017 23:30:47 +0000 (19:30 -0400)]
Add version.properties

Need this for deploy

Issue-Id: POLICY-139
Change-Id: I12fc57cd208c3566cf4cb3d1fc5d874bdd9f861a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoAdd missing properties and distributionManagement 47/7847/1
Pamela Dragosh [Thu, 17 Aug 2017 14:29:36 +0000 (10:29 -0400)]
Add missing properties and distributionManagement

In order for the release jobs to execute successfully and the
stage-site jobs to also succeed.

Change-Id: I06be2aaee050517a5a04d7361190b554a4da0627
Issue-Id: POLICY-139
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoFirst commit, adding parent pom 61/6661/3
Pamela Dragosh [Thu, 3 Aug 2017 17:22:41 +0000 (13:22 -0400)]
First commit, adding parent pom

Issue-ID: POLICY-139
Change-Id: I93f9aa48a03d392028f5633a1bc6dd0ad8fd5ef3
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoInitial empty repository
Jessica Wagantall [Tue, 20 Jun 2017 05:13:41 +0000 (05:13 +0000)]
Initial empty repository