Pamela Dragosh [Wed, 1 Apr 2020 14:53:12 +0000 (10:53 -0400)]
Fix optimization supported types
To support 5G slicing use cases, we will support any policy type
that derives from onap.policies.optimization
Similar in functionality to monitoring
Issue-ID: POLICY-2460
Change-Id: I48b071a64b917cea44eb64149539875ba33e2ef5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Fri, 27 Mar 2020 16:59:22 +0000 (12:59 -0400)]
Point to latest snapshots
Issue-ID: POLICY-2378
Change-Id: Ib7304c9c5ae552505fdad267bd0e94df9b35e950
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 25 Mar 2020 23:59:03 +0000 (19:59 -0400)]
Point to models 2.2.2
Issue-ID: POLICY-2378
Change-Id: Iecf281253baae6548575890f0c919dedc36a3787
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Tue, 24 Mar 2020 16:18:55 +0000 (12:18 -0400)]
Bump xacml-pdp to 2.2.1-SNAPSHOT
Issue-ID: POLICY-2378
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I819c9a356ca09e9baf75662bb6cd574540f41206
Pamela Dragosh [Tue, 24 Mar 2020 18:19:11 +0000 (18:19 +0000)]
Merge "Release 2.2.0 xacml-pdp docker image"
Jim Hahn [Tue, 24 Mar 2020 16:51:12 +0000 (12:51 -0400)]
Release 2.2.0 xacml-pdp artifacts
Issue-ID: POLICY-2378
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I29210f82ac30f5a5e92d7308a93c3cb652b0bcd3
Jim Hahn [Tue, 24 Mar 2020 16:02:34 +0000 (12:02 -0400)]
Release 2.2.0 xacml-pdp docker image
Issue-ID: POLICY-2378
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I82b3ca9dc3a7c875bf8f3438a3c05a77b72eeddc
Pamela Dragosh [Mon, 23 Mar 2020 13:31:27 +0000 (09:31 -0400)]
Point to released artifacts and use operation
Minor fix to use "operation" vs "recipe" in the guard
request.
parent, common and models are released.
Issue-ID: POLICY-2378
Change-Id: I4c5005c08fef2e184ce2dccefdef0c2c2ea2dc08
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Thu, 19 Mar 2020 23:58:13 +0000 (19:58 -0400)]
use shutdown to clear handle leak
The XACML github was released with a new method to allow
context factories and PIP engines to release any handles
before releasing the PDP engine. This review includes
that artifact and adds tests to support it.
In addition, added more tests to get code coverage over
90% for both PIPs in ONAP.
Some cleanup in the Matchable types based on last review.
Issue-ID: POLICY-2242
Change-Id: I312f06380ff4d2e16bcfd25b6d1f36ce5dd030e6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Thu, 19 Mar 2020 16:23:08 +0000 (16:23 +0000)]
Merge "Re-factor matchable to reduce complexity"
Pamela Dragosh [Wed, 18 Mar 2020 11:50:22 +0000 (07:50 -0400)]
Re-factor matchable to reduce complexity
This solution is much cleaner than what is in StdMatchableTranslator.
Over 90% code coverage on it - utilizes a callback to retrieve DataType
and PolicyTypes. Support for missing timestamp TOSCA type. Also can
do a better job differentiating between a property contained in the policy
vs a schema.
Changed StdMatchableTranslator to utilize these classes. And removed the
old spaghetti.
Added some JUnit coverage for ToscaPolicyTranslatorUtils.
Removed duplicate code in the XACML Native Exception classes.
Issue-ID: POLICY-2242
Change-Id: I18f898d9e65f6da28e3b27517d40f8d389de18a0
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
jhh [Wed, 18 Mar 2020 15:46:58 +0000 (10:46 -0500)]
renew policy certs till 03/17/2021
Issue-ID: POLICY-2402
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I111f60b9ef60ee9524808653be020f94ae9db170
Pamela Dragosh [Mon, 16 Mar 2020 15:09:36 +0000 (11:09 -0400)]
Missing support for PolicySetType
Adds support for PolicySetType specifically for Native policies. When/If
the other applications change to support they can easily do so.
Adding some more code coverage for Native application and translator.
Issue-ID: POLICY-2433
Change-Id: I463ca9f04928d759624a2176598b463057d386bd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Sun, 15 Mar 2020 02:36:22 +0000 (22:36 -0400)]
Add code coverage XacmlPolicyUtils
Fix spelling error and add code cover >95% for the
XacmlPolicyUtils.
Issue-ID: POLICY-2242
Change-Id: I21f239e6bd42073ff84883d04f2b8bee1466b8e0
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Fri, 13 Mar 2020 18:41:33 +0000 (14:41 -0400)]
Bump XacmlPdpApplicationManager code coverage
From under 50% to over 90%.
Issue-ID: POLICY-2242
Change-Id: Ie061bddbdd2fcdb37bed608847449e5bc92173b5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 11 Mar 2020 18:06:42 +0000 (14:06 -0400)]
Better error handling for decisions
Throw exceptions when requests cannot be created and return
error information back. Consolidated some code to avoid sonar
duplication issues.
Companion review to https://gerrit.onap.org/r/c/policy/models/+/103548
Issue-ID: POLICY-2242
Change-Id: Ic873af933dab82e3aeef6335f55939666be20385
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 11 Mar 2020 16:09:29 +0000 (16:09 +0000)]
Merge "Added support for application/xacml+json in native app"
Chenfei Gao [Tue, 10 Mar 2020 20:13:17 +0000 (16:13 -0400)]
Added support for application/xacml+json in native app
Issue-ID: POLICY-2182
Change-Id: I13246e08afdc2f5a380b5737c72851f271211d46
Signed-off-by: Chenfei Gao <cgao@research.att.com>
Pamela Dragosh [Wed, 11 Mar 2020 14:35:04 +0000 (10:35 -0400)]
Fix sonar logging bugs
These did not show up locally - sonarqube must have a new
version or rules to pick these up.
Issue-ID: POLICY-2242
Change-Id: I3df5aee84f696cde6b07c68913bbd55e95c8ba3b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Tue, 10 Mar 2020 20:17:36 +0000 (16:17 -0400)]
Misc XACML code coverage
Removed duplicate code from operations history classes.
added code coverage to other classes.
cleared sonar in main for args
Issue-ID: POLICY-2242
Change-Id: Ief548c96a180c132a3f17681d9cbc018c62e42ac
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Tue, 10 Mar 2020 16:41:47 +0000 (12:41 -0400)]
Bump monitoring app code coverage
Cleaned up some code to remove unnecessary branches. Add more
test cases specifically for query parameters.
Coverage should be above 90% for this repo.
Issue-ID: POLICY-2242
Change-Id: I20a75aacd75f9b8c87abb47e88b81ab8f2d30626
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Tue, 10 Mar 2020 11:54:05 +0000 (07:54 -0400)]
Fix optimization bug add coverage plus
Fix a NPE bug and add more code coverage.
Also is missing returning of context details for subscriber policies.
This code is a bit ad-hoc and there is a separate JIRA POLICY-2147 to
support re-factoring this codebase.
Added scanning for advice to be returned. For optimization, because of
the need for some changes in XACML github dependency, we are stuck with
a little narly code to get it to fully work. POLICY-2417 is created to
address this in Guilen.
Upgraded to released XACML artifact - this has been tested locally for
a few weeks with naming, guard and this optimzation code. It removed
Jackson in lieu of Json, cleaned up some security fixes, upgraded
dependencies, and added more code coverage.
Issue-ID: POLICY-2066
Change-Id: I3cae99de265c815200ec2ce71e471338772bdb5b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Sun, 8 Mar 2020 14:41:26 +0000 (10:41 -0400)]
Updates to support fixed guard policy types
Because the new TOSCA compliant policy types support required
fields, we can simplify the guard translator to utilize Match
in the target vs the previous complicated Condition usage.
Added test coverage to bump above 90% specifically for the
guard and coordination code.
Added a sonar exclusion for the test module.
Issue-ID: POLICY-2244
Change-Id: Ia90d117bd7b86d28a2268fd5ab8315dce7bf0c12
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Chenfei Gao [Thu, 5 Mar 2020 19:18:34 +0000 (14:18 -0500)]
Added xacml.properties to packages for native app
Issue-ID: POLICY-2182
Change-Id: Ife38e989aeda445c9fc2531bb92426f2d28bb818
Signed-off-by: Chenfei Gao <cgao@research.att.com>
Pamela Dragosh [Sun, 1 Mar 2020 21:53:13 +0000 (16:53 -0500)]
Point to docker 2.0.1
policy/docker is released
Issue-ID: POLICY-2378
Change-Id: I1ca967d48dca59d72d3490044ee499770d04f286
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Ram Krishna Verma [Sun, 1 Mar 2020 15:45:46 +0000 (15:45 +0000)]
Merge "Build XACML PDP support for native xacml policy type"
Chenfei Gao [Fri, 28 Feb 2020 19:45:48 +0000 (14:45 -0500)]
Build XACML PDP support for native xacml policy type
Added a new native application to the service loader framework
Added a new translator for the native application
Added custom serialization providers for xacml+json and xacml+xml
Added a new endpoint for native xacml decision api
Added a new api provider function to handle the native xacml api calls
Added corresponding junit tests
Issue-ID: POLICY-2182
Change-Id: I30fa4637612c324d543f9952386cf1a27a52d76c
Signed-off-by: Chenfei Gao <cgao@research.att.com>
pramod.jamkhedkar [Thu, 27 Feb 2020 17:55:59 +0000 (12:55 -0500)]
XACML pdp support for clc.
Added policies for SON and PCI to support each blocking the other, with test cases and appropriate requests
Issue-ID: POLICY-2163
Change-Id: I8153f9cd973a7cd6824fcd6c9787628a74148d46
Signed-off-by: pramod.jamkhedkar <pramod@research.att.com>
Pamela Dragosh [Mon, 24 Feb 2020 18:31:45 +0000 (13:31 -0500)]
Upgrades to cucumber
To keep in step with policy/parent upgrades.
Issue-ID: POLICY-2381
Change-Id: Ic25821bcf410e2fdf261abd155eb21030c509aa1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 19 Feb 2020 21:59:01 +0000 (16:59 -0500)]
Use datatype in matchable translator
With the new changes to models/api, the full policy template will
be retrieved along with inherited policy types and datatypes.
Changed api caller to return tosca template instead of individual
policy type so all policy types and data types are available.
Changed stdmatchabletranslator to be able to flexibly go deep with
list/map of datatypes of attributes. NOTE: This should be re-factored
at a later date as its a bit messy.
The naming application was used to test this code, but it was determined
by the CCSDK team that they will not do filtering this release. Instead,
switched to combined results policy type to return the full policy type.
Issue-ID: POLICY-1740
Change-Id: Ieb4e46e7fb2c639a1155be3bc07f5587c4f7b09a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Thu, 13 Feb 2020 17:23:53 +0000 (12:23 -0500)]
Add missing apps/naming directory for testing
Just clears a warning from main JUnit tests.
Issue-ID: POLICY-1740
Change-Id: Ie9e5bb0463bf5827085a714a61a5d87021f37860
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Bruno Sakoto [Fri, 7 Feb 2020 19:33:19 +0000 (14:33 -0500)]
Review intellij git ignored files
Issue-ID: POLICY-2359
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Ie2203067494ee9f59c56fd9cfc7ed9023b797e44
Ram Krishna Verma [Wed, 5 Feb 2020 21:32:11 +0000 (16:32 -0500)]
Updating module names to resolve conflicts
Issue-ID: POLICY-2355
Change-Id: I2933cf17fa790113eaaf8b9adc199c3b8fdc0e75
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Pamela Dragosh [Tue, 21 Jan 2020 15:06:05 +0000 (10:06 -0500)]
Remove assembly warning
Use ${file.separator}
Issue-ID: POLICY-2329
Change-Id: I1bca4f17ea562d656edc368aa8fc34d59206203d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Thu, 16 Jan 2020 21:32:58 +0000 (16:32 -0500)]
Use alpine image for xacml-pdp
Issue-ID: POLICY-1586
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I4ed9fa70dd95d061f0cd4c81822853b92387e2f6
Pamela Dragosh [Thu, 16 Jan 2020 21:01:22 +0000 (21:01 +0000)]
Merge "Ensure one jacoco output file"
Jim Hahn [Thu, 16 Jan 2020 18:51:21 +0000 (13:51 -0500)]
Add missing property file to xacml tarball
When attempting to run the xacml-pdp CSIT, the log file contains a
complain about a missing apps/naming/xacml.properties file; it was
missing from the tarball.
Issue-ID: POLICY-1586
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ie967efb9b82b0aabe513df9ea213867faca06840
Pamela Dragosh [Thu, 16 Jan 2020 17:31:52 +0000 (12:31 -0500)]
Ensure one jacoco output file
Sub-modules under sub-modules need to set the path to
ensure a single jacoco-ut.exec file is produced and
appended to.
This doesn't seem to affect the results, but I'd like
to be consistent.
Issue-ID: POLICY-2321
Change-Id: Ia2223df55ce0f4be6e81fa61bf7df711e12ad760
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Wed, 15 Jan 2020 21:46:49 +0000 (16:46 -0500)]
Update policy-xacml-pdp for java11 docker
Issue-ID: POLICY-1586
Change-Id: I6ff51d191a506297cbe69161114c0721b59bb5d2
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Tue, 14 Jan 2020 20:12:03 +0000 (15:12 -0500)]
Update sonar configuration
policy/parent now has the configuration
don't need to evaluate packages and testsuites
Issue-ID: POLICY-2321
Change-Id: I957e0d69845afa2fed5907ab3edd8dcf69596a0e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
HOCKLA [Tue, 14 Jan 2020 17:39:47 +0000 (11:39 -0600)]
policy/xacml-pdp jdk11 upgrades
Issue-ID: POLICY-1596
Change-Id: I00164ea17eb9d547b45c01e5f46f7aaf0f9a25e2
Signed-off-by: HOCKLA <ah999m@att.com>
HOCKLA [Fri, 10 Jan 2020 21:09:21 +0000 (15:09 -0600)]
Point to policy/models release version
Issue-ID: POLICY-1592
Change-Id: Ie53416e58b439f4dfec17eb260ece3326eaf53d3
Signed-off-by: HOCKLA <ah999m@att.com>
a.sreekumar [Wed, 8 Jan 2020 13:04:35 +0000 (13:04 +0000)]
Enabling logback file to be loaded using oom configmap
Change-Id: Icda10390a6ff3b6b524907562050658f3b283afd
Issue-ID: POLICY-2308
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
HOCKLA [Thu, 2 Jan 2020 17:45:22 +0000 (11:45 -0600)]
Removed supported policy types from Pdp-Status message
Issue-ID: POLICY-2230
Change-Id: I363dc450b6d7aaf13696c50792cbea5a8d643413
Signed-off-by: HOCKLA <ah999m@att.com>
Pamela Dragosh [Wed, 11 Dec 2019 15:00:21 +0000 (10:00 -0500)]
Add optimization subscriber request
Adding support for a preliminary request to pull subscriber details.
The returned decision adds scope attributes for the original request.
Fixed some checkstyle issues due to new checkstyle requirements.
Issue-ID: POLICY-2066
Change-Id: Ief02d896ce33e4864bb20e9185b0d0f5eb254bfd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Sun, 8 Dec 2019 22:44:31 +0000 (17:44 -0500)]
Add SDNC naming application
Requires changes to StdMatchableTranslator to go deeper when
searching for matchable attributes.
NOTE: will re-visit the StdMatchableTranslator at a later date
in order to support more robust Policy Types. And document best
practices for defining matchables.
Issue-ID: POLICY-1740
Change-Id: I291cf1c2e6eba0a677a3312dd11f0e56178a805b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Sun, 8 Dec 2019 12:32:33 +0000 (07:32 -0500)]
Changes for optimization refactoring
Companion review to https://gerrit.onap.org/r/c/policy/models/+/99288
The policy types for optimization were refactored, so the xacml
optimization application tests need to accomodate that.
Issue-ID: POLICY-2066
Change-Id: Ibc03b0652e771175a2fa38f5c3a3d81c7e371147
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
HOCKLA [Thu, 5 Dec 2019 19:16:28 +0000 (13:16 -0600)]
Point to release versions of policy/parent and policy/common
Issue-ID: POLICY-1583
Change-Id: I0fb606c7ba7334a6826a1246c76fe1970b1f9a44
Signed-off-by: HOCKLA <ah999m@att.com>
Pamela Dragosh [Mon, 2 Dec 2019 19:38:05 +0000 (14:38 -0500)]
Clear some simple xacml sonar
Missing assertions in JUnit test cases.
Use replace vs replaceAll
Swapping arguments
Issue-ID: POLICY-2079
Change-Id: I5accd462eab3d4f6b3321e375d4ba1084caf4b8c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
HOCKLA [Fri, 15 Nov 2019 14:52:39 +0000 (08:52 -0600)]
Changed Xacml-pdp to report pdp group defined in XacmlPdpParameters config file
Ignore the pdp group specified in the PdpUpdate message.
Updated junits and test resources.
Issue-ID: POLICY-2229
Change-Id: I0c7a33c45424cef6440b0837e1dd22a7487c5d44
Signed-off-by: HOCKLA <ah999m@att.com>
Liam Fallon [Thu, 14 Nov 2019 21:01:24 +0000 (21:01 +0000)]
Merge "Added 'onap.monitoring.*' in list of supported policy types"
Ali Hockla [Tue, 12 Nov 2019 17:49:32 +0000 (11:49 -0600)]
Added 'onap.monitoring.*' in list of supported policy types
Issue-ID: POLICY-2223
Change-Id: I1a7a1b4083ff74ca86455e1ab6ae7f96b8c04d35
Signed-off-by: Ali Hockla <ah999m@att.com>
Pamela Dragosh [Mon, 11 Nov 2019 17:37:51 +0000 (12:37 -0500)]
Do not hardcode io.fabric8 plugin
policy/parent now has this defined
Issue-ID: POLICY-2222
Change-Id: Ia054539a41f58dde26bf30d9d3b0f7f95da3b20d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Wed, 13 Nov 2019 13:55:40 +0000 (13:55 +0000)]
Merge "Implement closest match algorithm"
Pamela Dragosh [Mon, 4 Nov 2019 21:18:08 +0000 (16:18 -0500)]
Implement closest match algorithm
Needed to add more obligations, which make it easier to
scan through obligations and be able to pull information
about the policy.
Adding weight as an obligation for Optimization policies in
order to implement "closest match" algorithm.
Moved Obligation to a support class.
Added JUnit code coverage on the translator classes.
Split some methods up to reduce complexity via sonar.
Issue-ID: POLICY-2066
Change-Id: Ibb13d2dc0a63ab2a6d585b0697a0c1d129fa8f7b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Ali Hockla [Fri, 8 Nov 2019 18:54:02 +0000 (12:54 -0600)]
Added support to return status and error if pdp-x failed to load policy
Issue-ID: POLICY-2175
Change-Id: I32d2fe78846f58d6e700100dd523732817f1f04d
Signed-off-by: Ali Hockla <ah999m@att.com>
Ali Hockla [Tue, 5 Nov 2019 14:15:20 +0000 (08:15 -0600)]
Added support for 'Active' and 'Passive' states.
Removed the rest server start/stop from the Activator because the engine
starts in PASSIVE state.
Added code to start/stop the rest server when a pdp state change occurs.
Issue-ID: POLICY-2154
Change-Id: Iec6fcc990dc3dde702a911eb4f90d29e25c395a2
Signed-off-by: Ali Hockla <ah999m@att.com>
Liam Fallon [Mon, 4 Nov 2019 17:14:20 +0000 (17:14 +0000)]
Merge "Added abbreviated decision API call to stability and performance JMeter tests"
Pamela Dragosh [Sun, 3 Nov 2019 22:42:09 +0000 (17:42 -0500)]
More examples of optimization policies and cleanup
Fixed a couple of sonar issues - log exception and do not
nest more 3 if-else-try.
Cleaned up the JUnit test to make debugging a bit easier.
Added more examples for testing optimization tests.
Moved the target back into the Policy and kept the Condition
on the Rule. Works exactly the same, just a bit cleaner and
one less rule to deal with.
Issue-ID: POLICY-2066
Change-Id: Ife28dc2ce959dcf1fb8ca72061ebc5dca862a7f4
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Ali Hockla [Fri, 1 Nov 2019 13:38:21 +0000 (08:38 -0500)]
Added abbreviated decision API call to stability and performance JMeter tests
Issue-ID: POLICY-2168
Change-Id: I3bd0ef114374f5d01e2d93501ed6cf0748097987
Signed-off-by: Ali Hockla <ah999m@att.com>
liamfallon [Fri, 1 Nov 2019 11:55:29 +0000 (11:55 +0000)]
Add common Jersey version
Add a common version of Jersey for all Policy Framework components.
Issue-ID: POLICY-2209
Change-Id: I0d61800b423bffbe584e29621a87068eef4c1e6c
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Mon, 28 Oct 2019 12:51:10 +0000 (08:51 -0400)]
Optimization improvements and test cases
* StdBaseTranslator added helpful support methods and
can now add obligations to either rule, policy or policy sets.
* StdMatchablePolicyRequest improved to support optional
policy-type as part of the request to refine the output results.
* Added more tests to ensure that the decision is returning the
appropriate results.
* Added more Javadoc for code.
* Added some sonar fix for either log or throw exception.
Issue-ID: POLICY-2066
Change-Id: I90d6d90c2cdbb627e96cfce1d2632b2439a1e477
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Liam Fallon [Thu, 24 Oct 2019 20:28:19 +0000 (20:28 +0000)]
Merge "Fix sonar and coverage"
Pamela Dragosh [Thu, 24 Oct 2019 16:42:38 +0000 (12:42 -0400)]
Fix sonar and coverage
Turns out cyclomatic complexity is there in one method.
The other JUnits in the applications cover the rest of
the class, when time permits I will add that in there
for completeness.
Issue-ID: POLICY-2066
Change-Id: I31fd43625883bd569d4078bbd684554f6f3fbf53
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Thu, 24 Oct 2019 13:22:40 +0000 (13:22 +0000)]
Merge "Removed type_version from abbreviated Monitor decision results"
HOCKLA [Wed, 23 Oct 2019 17:24:12 +0000 (12:24 -0500)]
Removed type_version from abbreviated Monitor decision results
Issue-ID: POLICY-2126
Change-Id: I2a4907bb61651d9cfe2793e69404d9ccbe41ccd8
Signed-off-by: HOCKLA <ah999m@att.com>
Pamela Dragosh [Tue, 22 Oct 2019 17:06:56 +0000 (13:06 -0400)]
Consolidate common translatable code some sonar
There is duplicate code for some common translation of policy
decision responses and for scanning obligations.
Removed some TODO items (left others because I want to look
at them more closely).
Stored System.lineSeparator into a static var so that I can
remove some unnecessary ifs. There's still one left that I
am not worried about.
Gson as a static variable.
Issue-ID: POLICY-2066
Change-Id: I9c8162d5ad1c5f884be347dd94631fa74ca76f85
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Mon, 21 Oct 2019 18:21:54 +0000 (14:21 -0400)]
Use yaml policies in models-examples
Now that yaml is supported, use those policies that are
stored in the models-examples that are preloaded into the
api.
Fixed a minor checkstyle issue. Not sure why it was missed.
Issue-ID: POLICY-2066
Change-Id: I2f4384a310bfa818555de5dacb477daf82fac6de
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Mon, 21 Oct 2019 12:56:25 +0000 (12:56 +0000)]
Merge "Modified Decision API to accept query parameters and abbreviate Monitor decision results"
HOCKLA [Mon, 14 Oct 2019 19:25:29 +0000 (14:25 -0500)]
Modified Decision API to accept query parameters and abbreviate Monitor decision results
Issue-ID: POLICY-2126
Change-Id: I18d50a8746ede792ec9507ab98125383c5914ba1
Signed-off-by: HOCKLA <ah999m@att.com>
jhh [Wed, 16 Oct 2019 16:58:59 +0000 (11:58 -0500)]
override cert stores
Issue-ID: POLICY-2064
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia98f383de7e1946e49c1f2c6117f2065c84ad26e
Pamela Dragosh [Mon, 16 Sep 2019 17:09:46 +0000 (13:09 -0400)]
Sonar xacml-pdp issues
Either log or re-throw exception
Refactor to not nest more than 3 statements
Refactor to throw at most one exception
Move variable to comply with Java Code conventions
String literal on LHS
Issue-ID: POLICY-2079
Change-Id: Iac33623ef4694cf38c4a69c8f0b9040d8439998e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Ali Hockla [Tue, 1 Oct 2019 23:42:04 +0000 (18:42 -0500)]
Removed TestUtils from common and into a 'xacml-test' project
Issue-ID: POLICY-2090
Change-Id: Id688e305f878f56e374e6bd9047d9d6c75fbe0c6
Signed-off-by: Ali Hockla <ah999m@att.com>
Pamela Dragosh [Fri, 13 Sep 2019 16:12:45 +0000 (12:12 -0400)]
Upgrade to Tosca derivedFrom fix
Upgrade to models fix for derivedFrom() append of 0.0.0
And some sonar fixes for:
Exceptions should be either logged or rethrown but not both
Preconditions" and logging arguments should not require evaluation
Reduced cognitive complexity
Issue-ID: POLICY-2079
Change-Id: Ied8630020e8a737c33b1484db953df133c89398f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Thu, 12 Sep 2019 20:05:18 +0000 (16:05 -0400)]
Add yaml support to xacml-pdp rest server
Also modified code to use StandardYamlCoder.
Change-Id: I0596c8b054339ac68ef8c4250cd25b9ff88d47e4
Issue-ID: POLICY-2085
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 10 Sep 2019 15:14:09 +0000 (11:14 -0400)]
Bump versions for xacml-pdp master
Change-Id: I6ca46b3bbc9529c6fef5a332b224a4de69e3cdef
Issue-ID: POLICY-2045
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Tue, 10 Sep 2019 00:29:52 +0000 (20:29 -0400)]
Release xacml-pdp 2.1.2
Releasing 2.1.2
Issue-ID: POLICY-2045
Change-Id: I2c7c1968a6b194d7f582062a27416ffc57c4ad68
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Mon, 9 Sep 2019 23:47:56 +0000 (19:47 -0400)]
Upgrade to released artifacts
Upgrade to released parent, common and models
Issue-ID: POLICY-2045
Change-Id: I4ee2e7d752d45449d7d2c0173c3b6b672e160166
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Fri, 30 Aug 2019 19:21:05 +0000 (15:21 -0400)]
Integrate using Policy Type to find Matchable
Utilize's Jim's helper class to pull from API policy types
definitions so that Xacml PDP can determine which properties
are "matchable".
Override initialize to set translator parameters.
Utilize the metadata section of ToscaProperties to store
the matchable field.
Updated Matchable Request to be dynamic with respect to the
incoming resource attributes.
Stored the policy types as JSON.
Issue-ID: POLICY-1899
Change-Id: Icff3605495b0a34ebfcdfa54346095ce2d8468a4
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Tue, 3 Sep 2019 15:07:16 +0000 (11:07 -0400)]
Change "pap" to "policy-api" in xacml-pdp config
The json config file is really only an example, but the example leads
users down the wrong path, because it implies that xacml-pdp connects
to "pap" to get policy type information, when it actually talks to
"policy-api". Updated the config file.
Change-Id: Id2a42264591acd37b7813673fdcaa790257a9d8a
Issue-ID: POLICY-1911
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 28 Aug 2019 19:20:18 +0000 (15:20 -0400)]
Get policy type from policy-api
Added a class to retrieve a policy type from the policy-api.
Updated property files to include parameters that are needed
to configure it.
Updates per review comments:
- change PolicyApi to PolicyApiCaller
- use HttpClientFactory
- removed superfluous constructors from exception classes
- changed parameters to use RestServerParameters instead of BusTopicParams
Change-Id: I8aad6ca5a733c8ad9cc983496e745ebe7400dd17
Issue-ID: POLICY-1911
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 23 Aug 2019 22:40:54 +0000 (18:40 -0400)]
XACML junit spews dmaap errors
Modified junit parameters to specify "noop" instead of "dmaap"
in the topic properties, eliminating the dmaap error messages
from the log.
Change-Id: I350d988d10219e6ded2c011a4ed117fd5e71876a
Issue-ID: POLICY-1725
Signed-off-by: Jim Hahn <jrh3@att.com>
jhh [Fri, 23 Aug 2019 03:42:23 +0000 (22:42 -0500)]
update keystore
Issue-ID: POLICY-1988
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I544a0bdf63582cdff74765d7fad1b7f993d0bfa0
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Bruno Sakoto [Wed, 7 Aug 2019 14:09:22 +0000 (10:09 -0400)]
Review maven dependency for snakeyaml
Remove explicit version for snakeyaml maven dependency and inherit it
from integration parent artifact.
Issue-ID: POLICY-1603
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: Iae360f073f9962014fbb64dbe150e75edc49d039
Jim Hahn [Wed, 7 Aug 2019 16:34:50 +0000 (12:34 -0400)]
Bump version of policy/xacml-pdp
Change-Id: I2770d2803c79b5eb72b69bb6aa4a1da43a0f6a0b
Issue-ID: POLICY-1965
Signed-off-by: Jim Hahn <jrh3@att.com>
jhh [Tue, 6 Aug 2019 17:09:51 +0000 (12:09 -0500)]
Add release 2.1.1 file
Issue-ID: POLICY-1953
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I352905ea9e2876879896cc0842df43139d487d65
jhh [Mon, 5 Aug 2019 13:53:04 +0000 (08:53 -0500)]
Update to latest common/models released versions
policy/models: 2.1.2
policy/common: 1.5.1
Issue-ID: POLICY-1953
Change-Id: I9ea6939e760ae5098896aedcfa632cc7426e927d
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Jorge Hernandez [Wed, 31 Jul 2019 14:34:22 +0000 (14:34 +0000)]
Merge "Use new addTopic() method in xacml-pdp"
Ram Krishna Verma [Wed, 31 Jul 2019 10:19:50 +0000 (10:19 +0000)]
Merge "Fix guard table creation during startup issue"
Michael Mokry [Tue, 23 Jul 2019 18:54:30 +0000 (13:54 -0500)]
Fix guard table creation during startup issue
- Added -hpolicydb to the mysql command in the script
- Made this configurable by utilizing the existing parameters in
xacml.properties for db connections. No OOM or CSIT changes should be
needed now.
PATCH UPDATE:
- used Awk to extract property values
- removed echo except one needed for the base64 command, as far
as I can tell it is needed when assigning output to a variable,
I tried to get it to work unsuccessfully.
- added exit code 2 for missing properties as suggested by Jorge
and Jim
PATCH UPDATE:
- remove echo from base64 using Jim's suggestion
- Added code to remove escape backslashes from properties file,
I didn't see these locally but when testing in windriver they
show up in the xacml.properties file on OOM installs
- More changes per Jorge's latest review
Change-Id: I79c0502d8a4fadd2160785014fcb9db3c0faab5e
Issue-ID: POLICY-1934
Signed-off-by: Michael Mokry <michael.mokry@att.com>
Jim Hahn [Tue, 30 Jul 2019 15:53:14 +0000 (11:53 -0400)]
Use new addTopic() method in xacml-pdp
Replaced ParameterUtils with the use of the new
addTopic(TopicParameterGroup) method.
Change-Id: I35bf8a78d4670835dda005cdb218665a3bf48a16
Issue-ID: POLICY-1953
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 26 Jul 2019 13:18:44 +0000 (09:18 -0400)]
Add stopBubbling to lombok.config for XACML-PDP
Change-Id: If489f95f80f324620bbcdca85d0fe2b4b2285d31
Issue-ID: POLICY-1938
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 24 Jul 2019 16:37:07 +0000 (16:37 +0000)]
Merge "Add more junit coverage to xacml-pdp (round #2)"
Pamela Dragosh [Wed, 24 Jul 2019 13:21:28 +0000 (13:21 +0000)]
Merge "S3P Stability and Performance Tests"
Jim Hahn [Tue, 23 Jul 2019 14:57:03 +0000 (10:57 -0400)]
Add more junit coverage to xacml-pdp (round #2)
Also removed unused methods.
Also extracted constants.
Change-Id: I8d2cff05a365f145f2080369e9ea52d08be7e508
Issue-ID: POLICY-1772
Signed-off-by: Jim Hahn <jrh3@att.com>
Michael Mokry [Tue, 23 Jul 2019 19:09:49 +0000 (14:09 -0500)]
S3P Stability and Performance Tests
- Modified the jmeter scripts to include performance and stability testing with
Decision APIs
Change-Id: If10e5c598406af21d620b359a1f20b64fd433b18
Issue-ID: POLICY-1773
Signed-off-by: Michael Mokry <michael.mokry@att.com>
Jim Hahn [Tue, 23 Jul 2019 19:00:59 +0000 (15:00 -0400)]
Fixed xacml-pdp registration
Apparently, TimerTasks may not be cancelled and then re-scheduled.
Modified the code to use a scheduled thread pool instead.
Change-Id: I2e26a5a37636f570f362481823a0274fe558e2e9
Issue-ID: POLICY-1939
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 22 Jul 2019 14:57:57 +0000 (10:57 -0400)]
Add junit coverage to xacml-pdp
Change-Id: I9b59dcd27705e40c424b6a76420e0395adbe44bb
Issue-ID: POLICY-1772
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 17 Jul 2019 13:59:40 +0000 (09:59 -0400)]
Modify xacml-pdp to use RestServer from common
Change-Id: I331483e2e28f2c57160b3eaace40fc84a1c13727
Issue-ID: POLICY-1652
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 10 Jul 2019 12:43:33 +0000 (08:43 -0400)]
Added comment to checkstyle suppression
Change-Id: I7c7c89e8b4367bbc2ea7a97e403eb253e955a9a5
Issue-ID: POLICY-1074
Signed-off-by: Jim Hahn <jrh3@att.com>