cps.git
9 months agoFix sonar issue in performance test ResourceMeter 78/138378/2
danielhanrahan [Wed, 3 Jul 2024 14:41:40 +0000 (15:41 +0100)]
Fix sonar issue in performance test ResourceMeter

Replace busy loop with await().until as suggested by sonar

Issue-ID: CPS-89
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ic6c870c419a67708082ceb05ef3ccba884ae375e

9 months agoMerge "Improve handling of Invalid Operation exception"
Sourabh Sourabh [Mon, 1 Jul 2024 14:08:27 +0000 (14:08 +0000)]
Merge "Improve handling of Invalid Operation exception"

9 months agoMerge "Fix incorrect use of getAnchors(dataspace, schemasets)"
Daniel Hanrahan [Mon, 1 Jul 2024 13:52:29 +0000 (13:52 +0000)]
Merge "Fix incorrect use of getAnchors(dataspace, schemasets)"

9 months agoImprove handling of Invalid Operation exception 50/138350/1
ToineSiebelink [Mon, 1 Jul 2024 10:24:49 +0000 (11:24 +0100)]
Improve handling of Invalid Operation exception

- MOve to API package
- Handle in REST Controller to return BAD REQUEST

Issue-ID: CPS-2256
Change-Id: I4f96519aaf2e7f781729c8b8671ea02630a2e0a8
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
9 months agorepackage 'data' feature 37/138337/2
ToineSiebelink [Thu, 27 Jun 2024 11:49:27 +0000 (12:49 +0100)]
repackage 'data' feature

- moved relevant classes into these (new) packages:
api.data.exceptions
api.data.models
impl.data
impl.data.async
impl.data.exceptions
impl.data.models
impl.data.utils
utils.events
- removed old unused event class
- moves some missed inventory related class to the right place

Issue-ID: CPS-2256
Change-Id: I75563e063acc0054769d8f2b13146e6c1d1c6054
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
9 months agomove lcm/common events classes 39/138339/1
ToineSiebelink [Thu, 27 Jun 2024 14:35:37 +0000 (15:35 +0100)]
move lcm/common events classes

-moved api.impl.events.lcm to impl.inventory.sync.lcm
-moved most api.impl.events class to utils.events
(remaining classes in api.impl.events belong to cmsubscrption and Priyank wil take care of those)

Issue-ID: CPS-2258
Change-Id: I1818194e708aa0d9c713b470e878997c2f26fb13
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
9 months agoMerge "Simplify package structure cps-ncmp-rest"
Priyank Maheshwari [Thu, 27 Jun 2024 11:02:43 +0000 (11:02 +0000)]
Merge "Simplify package structure cps-ncmp-rest"

9 months agoSimplify package structure cps-ncmp-rest 34/138334/1
ToineSiebelink [Thu, 27 Jun 2024 08:06:31 +0000 (09:06 +0100)]
Simplify package structure cps-ncmp-rest

Issue-ID: CPS-2294
Change-Id: Idc3605c1b877be13a8d344875612da6bef791fc7
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
9 months agoMerge "Move TrustLevel Feature"
Priyank Maheshwari [Wed, 26 Jun 2024 14:33:36 +0000 (14:33 +0000)]
Merge "Move TrustLevel Feature"

9 months agoMove TrustLevel Feature 25/138325/4
ToineSiebelink [Tue, 25 Jun 2024 13:40:40 +0000 (14:40 +0100)]
Move TrustLevel Feature

-Moved TrustLevel impl from Controller to Inventory Facade
-Applied new package name convention using impl\inventory\trustlevel for this (sub)feature
-Renamed some trustlevel related classes to better describe their role
-Disabled failing architecture test (agreed this is tech. debt and created CPS-2293)
-Refactored YangDataConverter method names and signatures (moved Spec to correct place)
-Cleaned up names and javadoc of class now called DeviceTrustLevelMessageConsumer
-Applied conventions to modified test methods

Issue-ID: CPS-2255
Change-Id: Iccd20541488e6b61444bb2c7406c90e61a34124d
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
9 months agoMerge "Disable the java debug port permanently"
Sourabh Sourabh [Wed, 26 Jun 2024 11:36:00 +0000 (11:36 +0000)]
Merge "Disable the java debug port permanently"

9 months agoDisable the java debug port permanently 28/138328/1
halil.cakal [Wed, 26 Jun 2024 11:03:38 +0000 (12:03 +0100)]
Disable the java debug port permanently

Issue-ID: CPS-1864

Change-Id: I0366b126920cf0bc706545bc5b4e469d3faa2486
Signed-off-by: halil.cakal <halil.cakal@est.tech>
9 months agoMerge "Clean up the k6 test suite"
Daniel Hanrahan [Wed, 26 Jun 2024 08:09:46 +0000 (08:09 +0000)]
Merge "Clean up the k6 test suite"

9 months agoFix incorrect use of getAnchors(dataspace, schemasets) 05/138305/3
danielhanrahan [Fri, 21 Jun 2024 10:12:45 +0000 (11:12 +0100)]
Fix incorrect use of getAnchors(dataspace, schemasets)

There is an issue in a method deleteDataNodes(dataspace, anchors)
where it doesn't send data update events. This is because it fetches
anchors using a method getAnchors(dataspace, schemaSetNames), when it
needs to fetch anchors by name: getAnchors(dataspace, anchorNames)

Changes:
- Rename getAnchors method using schemasets to getAnchorsBySchemaSetNames
- Add a method getAnchors(dataspace, anchorNames)
- Update test of deleteDataNodes method using getAnchors so it checks
  that data update events are sent

Issue-ID: CPS-2254
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I55fe853f0a9278a66a5724bf4cf2723b0e2fbc8b

9 months agoRepackage Inventory Feature 54/138154/3
ToineSiebelink [Mon, 24 Jun 2024 12:24:57 +0000 (13:24 +0100)]
Repackage Inventory Feature

- decided that cm handle queries is part of 'inventory' feature
- a lot of files (~100 total) have changes because of some files have been moved.
- The reviewers should probably just focus on the MOVED/renamed (~30) files
- New packages (top level only):
-- org.onap.cps.ncmp.api.inventory
-- org.onap.cps.ncmp.impl.inventory
-- org.onap.cps.ncmp.impl.models  (common models NOT used in API, this was unforeseen)
-- org.onap.cps.ncmp.impl.utils
- I am NOT updating copyright years as part of this commit since there are no real code changes and it is simply NOT worth the effort
TODO:
- extend scope to 'TrustLevel' as an 'internal feature' (TBD)

Issue-ID: CPS-2255
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I40b4efc8326068ab9ae1f31b77f46b2fe8579431

9 months agoClean up the k6 test suite 06/138306/2
halil.cakal [Fri, 21 Jun 2024 14:22:57 +0000 (15:22 +0100)]
Clean up the k6 test suite

- Remove the tests that are not in the Characteristics
- Set .625 seconds/operation for cm handle id search with module filter
- Set 13 seconds/operation for cm handle search with module filter

Issue-ID: CPS-2286

Change-Id: I88d5773abadb29ce46914029332384ae8e55e032
Signed-off-by: halil.cakal <halil.cakal@est.tech>
9 months agoFix compile issue after facade introduction 04/138304/1
danielhanrahan [Fri, 21 Jun 2024 10:49:48 +0000 (11:49 +0100)]
Fix compile issue after facade introduction

Due to automatic rebase, a method got renamed in one commit but not
the other.

Issue-ID: CPS-2263
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Id0fa8eba79cb98bb24419bfddc0c9b9e8c9a42d3

9 months agoMerge "Introducing NCMP Facades"
Sourabh Sourabh [Fri, 21 Jun 2024 09:28:37 +0000 (09:28 +0000)]
Merge "Introducing NCMP Facades"

9 months agoMerge "Spliting a data-job into sub-jobs for DMI Plugin"
Sourabh Sourabh [Fri, 21 Jun 2024 08:50:46 +0000 (08:50 +0000)]
Merge "Spliting a data-job into sub-jobs for DMI Plugin"

9 months agoIntroducing NCMP Facades 28/138228/5
ToineSiebelink [Thu, 13 Jun 2024 15:52:45 +0000 (16:52 +0100)]
Introducing NCMP Facades

- NetworkCmProxyDataService was polluted with many non-data operations
- it is now split into:
1) NetworkCmProxyFacade, a single thin facade for the (main) controler to redirect calls to the correct services
2) CmHandleRegistrationService(Impl), methods related to registration only
- introduced NetworkCmProxyInventoryFacade for the invenoty controller
- renamed some services for consitency and clarification
- Use facade to acces ncmp data request handlers (instead of direct from controller)
- remove unnecesarry wrappings between request handlers and facade
- split facades according to names: data & inventory
(the REST controllers are not split properly so I think one rest controller will end up needing both facades)

Issue-ID: CPS-2263
Change-Id: I250732aa16ec28b43ff642d2adf10ba36f67290e
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
9 months agoBump CPS version to 3.5.1-SNAPSHOT 96/138296/2
mpriyank [Thu, 20 Jun 2024 14:22:14 +0000 (15:22 +0100)]
Bump CPS version to 3.5.1-SNAPSHOT

- bump cps version to 3.5.1-SNAPSHOT
- updated release notes to make it ready for the next release

Issue-ID: CPS-2283
Change-Id: I242cae7c95a87c1a9e225cce3eb7b36097f1e5ba
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
9 months agoMaven container yaml for release 95/138295/1
mpriyank [Thu, 20 Jun 2024 13:32:31 +0000 (14:32 +0100)]
Maven container yaml for release

- added maven container yaml to release cps 3.5.0 version

Issue-ID: CPS-2283
Change-Id: I45ce5b440d8ca2f6ff3999971202f9fc3bd4a8fa
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
9 months agoSpliting a data-job into sub-jobs for DMI Plugin 40/138240/7
leventecsanyi [Mon, 17 Jun 2024 09:11:24 +0000 (11:11 +0200)]
Spliting a data-job into sub-jobs for DMI Plugin

    - algorithm for create sub-job requests
    - added new method to DmiServiceUrlBuilder to get the write job url
    - created WriteOperationExaminer, DmiSubJobClient & testware

Issue-ID: CPS-2142
Change-Id: I258d334ef346cd388341a1deb4078d24d8bdb7cc
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
9 months agoMaven yaml for release 93/138293/1
mpriyank [Thu, 20 Jun 2024 13:00:56 +0000 (14:00 +0100)]
Maven yaml for release

- added maven yaml file to release cps 3.5.0

Issue-ID: CPS-2283
Change-Id: Ifc9cc9f33381d64bf573593949cf59303ff8d0fc
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
9 months agoRelease notes and OpenApi sync 91/138291/1
mpriyank [Thu, 20 Jun 2024 11:59:02 +0000 (12:59 +0100)]
Release notes and OpenApi sync

- Release notes updated and openapi syncd for CPS-Core and NCMP

Issue-ID: CPS-2283
Change-Id: Iafdebc65cbcec01bf0d6e6963bd9601fea5f5081
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
9 months agoAddressed an adaptability issue 86/138286/2
sourabh_sourabh [Wed, 19 Jun 2024 13:35:30 +0000 (14:35 +0100)]
Addressed an adaptability issue

- Defined a constant instead of duplicating literal "No data nodes 4 times.

Issue-ID: CPS-478
Change-Id: I2b980a228217e85424342d4c2b9e97c5cfa618d1
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
9 months agoHandle high frequency (faster then DMI) of passthrough request in NCMP 74/138274/4
sourabh_sourabh [Mon, 17 Jun 2024 18:45:00 +0000 (19:45 +0100)]
Handle high frequency (faster then DMI) of passthrough request in NCMP

- Added pendingAcquireMaxCount property into appliaction.yml.
- Added findbugs google annotations dependency.
- Supressed "BC_UNCONFIRMED_CAST_OF_RETURN_VALUE" spotbugs low error for
  reactor.netty.resources.ConnectionProvider.

Issue-ID: CPS-2262
Change-Id: Ie755e40282473933f2052fbe7654e7090bb9b337
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
9 months agoMerge "[k6] Add JVM warmup phase (#2)"
Priyank Maheshwari [Mon, 17 Jun 2024 16:01:24 +0000 (16:01 +0000)]
Merge "[k6] Add JVM warmup phase (#2)"

9 months agoMerge "[k6] Refactoring k6 tests (#1)"
Priyank Maheshwari [Mon, 17 Jun 2024 13:13:24 +0000 (13:13 +0000)]
Merge "[k6] Refactoring k6 tests (#1)"

9 months agoRefactor and Move NCMP Data Request Handlers 25/138225/5
ToineSiebelink [Fri, 14 Jun 2024 09:01:56 +0000 (10:01 +0100)]
Refactor and Move NCMP Data Request Handlers

- Simplified NCMP Rest Request Handlers
- Moved responsEntity wrapping to Controller so most handler methods can have clear return types
- Moved NCMP Rest Request Handlers  to Service Layer
- Moved related exceptions and utils to Service Layer
- Used Lombok for constructors
- Improved related testware

Issue-ID: CPS-2266
Change-Id: I0025fab1c92e0d613825093b6e4b43dae044c01a
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
9 months ago[k6] Add JVM warmup phase (#2) 12/138212/6
danielhanrahan [Wed, 12 Jun 2024 15:50:07 +0000 (16:50 +0100)]
[k6] Add JVM warmup phase (#2)

To account for JVM warmup effect, the k6 test suite is run twice:
initially, the whole test suite is run without recording results.

- Added environment variables to allow setting total CM-handles and
  batch size for registration. By reducing total CM-handles during
  warm-up, many more operations will be run.

Issue-ID: CPS-2264
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ib1d1e76d31719d788a3e026797faa0a425b320a2

9 months ago[k6] Refactoring k6 tests (#1) 64/138164/5
danielhanrahan [Mon, 10 Jun 2024 20:32:12 +0000 (21:32 +0100)]
[k6] Refactoring k6 tests (#1)

This commit moves all common request logic into a common folder.
It is needed to avoid duplication before adding JVM warmup phase.

- move registration-related code into common folder
- move passthrough operations into common folder

Issue-ID: CPS-2208
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ia9ebf61d21044b43063bde153f9c526e67d607c8

9 months agoUpdate ONAP DMI version in NCMP 24/138224/1
mpriyank [Fri, 14 Jun 2024 14:02:53 +0000 (15:02 +0100)]
Update ONAP DMI version in NCMP

- update the docker compose file to point to latest version on
  onap-dmi-plugin. Same to be used to run the CSITs during build.

Issue-ID: CPS-2271
Change-Id: Ifbb2ee9c9548d54979a04595e19062d9192bfd1d
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
9 months ago #2: Used async version of web client for single cm handle read operation 57/138157/7
sourabh_sourabh [Tue, 11 Jun 2024 07:56:54 +0000 (08:56 +0100)]
 #2: Used async version of web client for single cm handle read operation

 - Code change is done to use async web client for single cm handle
   read data operation.
 - CpsNcmpTaskExecutor class and groovy test code is removed.
 - Use of supplier code is removed from cm handle Query service.

Issue-ID:CPS-2259
Change-Id: I2b7a36e8a151a9224937afd876fceb30be6a24ce
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
9 months ago #1: Used async version of web client for batch read operation 52/138152/7
sourabh_sourabh [Fri, 7 Jun 2024 18:10:45 +0000 (19:10 +0100)]
 #1: Used async version of web client for batch read operation

  - Exposed async version of post method into dmi rest client.
  - Code change is done to use async web client for batch data
   operation.
  - Use of CpsNcmpTaskExecutor code is removed.

Issue-ID: CPS-2174
Change-Id: I7840fd8c6d9debe42e50c860f9cf39d64274df72
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
9 months agoMerge "[k6] Refactor k6 tests for CM handle searches"
Lee Anjella Macabuhay [Mon, 10 Jun 2024 08:31:59 +0000 (08:31 +0000)]
Merge "[k6] Refactor k6 tests for CM handle searches"

10 months agoMerge "Cm Subscription: Predicates optional now"
Lee Anjella Macabuhay [Thu, 6 Jun 2024 20:01:42 +0000 (20:01 +0000)]
Merge "Cm Subscription: Predicates optional now"

10 months ago[k6] Refactor k6 tests for CM handle searches 51/138151/1
danielhanrahan [Thu, 6 Jun 2024 19:43:21 +0000 (20:43 +0100)]
[k6] Refactor k6 tests for CM handle searches

A cleanup of the k6 tests to avoid code duplication

Issue-ID: CPS-2208
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If1e58ee87300cd28ed72b365d9a86e2709dc6c13

10 months ago#1: Dedicated web client instance is assigned for data, model and health services 86/138086/14
sourabh_sourabh [Mon, 27 May 2024 17:28:10 +0000 (18:28 +0100)]
#1: Dedicated web client instance is assigned for data, model and health services

 - Switched web client instance based on dmi service type (like data or model)
 - 3 diff. beans are configured for data, model and health dmi service.
 - Added configurable properties for data and model.
 - Hard coded properties are assigned for health service.

Issue-ID: CPS-2231
Change-Id: I39fb739c07c41430dae43509fe29ece5306b7d71
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
10 months agoCm Subscription: Predicates optional now 42/138142/1
mpriyank [Thu, 6 Jun 2024 10:47:46 +0000 (11:47 +0100)]
Cm Subscription: Predicates optional now

- making the predicates sectional OPTIONAL as the schemas are common for
  both create and delete use case and we dont have the need to send in
  the predicates information for DELETE use case.
- Delete is done based on the incoming subscriptionId only

Issue-ID: CPS-2252
Change-Id: I43ec480821a6088c5fa161480ce2b29b660a2ba5
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoCPS Delta API 2: Delta between anchor and payload 59/135859/53
Arpit Singh [Thu, 7 Sep 2023 11:35:37 +0000 (17:05 +0530)]
CPS Delta API 2: Delta between anchor and payload

  - Second API to get Delta between an anchor and JSON payload
  - added new API getDeltaByDataspaceAnchorAndPayload
  - added controller and service layer methods
    getDeltaByDataspaceAnchorAndPayload
  - Core Delta algorithm remains same as the first API.
    getDeltaByDataspaceAnchorAndPayload will call getDeltaBetweenDataNodes

Issue-ID: CPS-1836
Signed-off-by: Arpit Singh <as00745003@techmahindra.com>
Change-Id: Id74cd930ce48e5cb414aa62c5381b79675788a37

10 months agoMerge "Change ApplicationEvent for ModelLoading"
Toine Siebelink [Thu, 6 Jun 2024 08:16:39 +0000 (08:16 +0000)]
Merge "Change ApplicationEvent for ModelLoading"

10 months agoXML content support on update node leaves 63/137163/27
Rudrangi Anupriya [Wed, 5 Jun 2024 18:25:14 +0000 (23:55 +0530)]
XML content support on update node leaves

Issue-ID: CPS-2071
Change-Id: Ibe7f59fbfcbb03703626132c6d5c2afde0e7ab4b
Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
10 months agoChange ApplicationEvent for ModelLoading 50/137850/4
mpriyank [Tue, 7 May 2024 12:57:48 +0000 (13:57 +0100)]
Change ApplicationEvent for ModelLoading

- Application to use ApplicationStartedEvent as the trigger to start the
  ModelLoading process instead of ApplicationReadyEvent
- Modified the testware to reflect the same

Issue-ID: CPS-2211
Change-Id: I3176b6373f585ec1915c3d43c553e233660225f5
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoMerge "CM SUBSCRIPTION: Add delete use case #2 (DMI-NCMP)"
Priyank Maheshwari [Wed, 5 Jun 2024 08:20:20 +0000 (08:20 +0000)]
Merge "CM SUBSCRIPTION: Add delete use case #2 (DMI-NCMP)"

10 months agoMerge "Added OpenTelemetry to CPS"
Toine Siebelink [Wed, 5 Jun 2024 07:11:05 +0000 (07:11 +0000)]
Merge "Added OpenTelemetry to CPS"

10 months agoMerge "CM SUBSCRIPTION: Add delete use case #1 (Client-NCMP)"
Priyank Maheshwari [Tue, 4 Jun 2024 15:10:48 +0000 (15:10 +0000)]
Merge "CM SUBSCRIPTION: Add delete use case #1 (Client-NCMP)"

10 months agoAdded OpenTelemetry to CPS 67/137767/11
david.mcweeney [Thu, 25 Apr 2024 13:37:33 +0000 (14:37 +0100)]
Added OpenTelemetry to CPS

Change-Id: I192fa53e293ea43cdff92ebd44d0382eb290bb76
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2172

10 months agoCM SUBSCRIPTION: Add delete use case #2 (DMI-NCMP) 03/138103/2
emaclee [Thu, 30 May 2024 05:48:23 +0000 (06:48 +0100)]
CM SUBSCRIPTION: Add delete use case #2 (DMI-NCMP)

Issue-ID: CPS-2241
Change-Id: I218c46e9c16cc78025450494f5019bde1f351a40
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
10 months agoCM SUBSCRIPTION: Add delete use case #1 (Client-NCMP) 02/138102/2
emaclee [Thu, 30 May 2024 05:33:51 +0000 (06:33 +0100)]
CM SUBSCRIPTION: Add delete use case #1 (Client-NCMP)

Issue-ID: CPS-2241
Change-Id: Idd074ff4d29cf11f45f1c69200788b2f39b49e74
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
10 months agoCM SUBSCRIPTION: Update schemas 10/138110/1
mpriyank [Fri, 31 May 2024 08:46:11 +0000 (09:46 +0100)]
CM SUBSCRIPTION: Update schemas

- updated the cm subscription schemas with proper case as agreed before
  for the events
- fixed the tests to reflect the camelCase change

Issue-ID: CPS-2245
Change-Id: I64fb8b27a5f64280dfa19d86ae310e6b5309de39
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoSimplify Code around building DMI URLs 94/138094/4
ToineSiebelink [Mon, 27 May 2024 14:02:35 +0000 (15:02 +0100)]
Simplify Code around building DMI URLs

- Bug analysis showed some unclear and complicated code for building URLs
- This patch is to clean up the related code and show more clearly what is encoded and what is not
- Use SPringBoot provided builder to apply correct encoding of all URI parts
- DmiOperations base class no longer need as no common code model and data operations anymore
- Converted builder to POJO (client needs to provide the only dmi properties upon build)
- Added some missing test (in affected code) to increase coverage percntage
(as the production code has significantly reduced in size the overal coverage was inadvertently reduced below the treshold)
- Added more unit test. Now impl.operations' package has 100%
- removed the test fro Dmi Exception that was incorrectly callign the handleException methdod directly instead of mocking an exception
it was really a dupclicate of a test I added but I was able to re-use the event checkign in my test

Issue-ID: CPS-2246
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I1ff196cd03bbb95f5877ee590c321febeb672800

10 months agoMerge "CPS-2187 - Move Module Set Tag into request body for dmi data access passthrou...
Sourabh Sourabh [Wed, 29 May 2024 14:14:37 +0000 (14:14 +0000)]
Merge "CPS-2187 - Move Module Set Tag into request body for dmi data access passthrough calls"

10 months agoCPS-2187 - Move Module Set Tag into request body for dmi data access passthrough... 89/138089/6
david.mcweeney [Tue, 28 May 2024 11:48:38 +0000 (12:48 +0100)]
CPS-2187 - Move Module Set Tag into request body for dmi data access passthrough calls

Change-Id: I9c807d2ef5b3712bf3f8ee5db7663d9628eef3bb
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2187

10 months agoAdjust K6 thresholds 95/138095/2
danielhanrahan [Tue, 28 May 2024 17:28:32 +0000 (18:28 +0100)]
Adjust K6 thresholds

- Adjust timings based on previous runs.
- Reduce from 5 to 4 parallel clients for CM handle searches
  to avoid OutOfMemoryErrors.

Issue-ID: CPS-2208
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I339cc3df84b2295bb11371ab73b4948f43615c15

10 months agoRestructure(package) DataJobs feature in NCMP Service 73/138073/6
leventecsanyi [Thu, 23 May 2024 14:40:13 +0000 (16:40 +0200)]
Restructure(package) DataJobs feature in NCMP Service

   - restructured already existing classes
   - added testware for AlternateIdMatcher

Issue-ID: CPS 2240
Change-Id: I5691ed99627353903689cd2929163f77ed8c4eca
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
10 months agoMerge "CmDataSubscription status code update"
Lee Anjella Macabuhay [Tue, 28 May 2024 11:30:04 +0000 (11:30 +0000)]
Merge "CmDataSubscription status code update"

10 months agoMerge "Print summary report for K6 tests"
Daniel Hanrahan [Tue, 28 May 2024 10:16:20 +0000 (10:16 +0000)]
Merge "Print summary report for K6 tests"

10 months agoPrint summary report for K6 tests 82/138082/3
halil.cakal [Mon, 27 May 2024 15:06:59 +0000 (16:06 +0100)]
Print summary report for K6 tests

- add a generic template to print summary of k6 test results
- remove container logs since its around 50 mb

Issue-ID: CPS-2215
Change-Id: I8971fc30b9dc8be2ed16eda6755d17a91f608b48
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Signed-off-by: halil.cakal <halil.cakal@est.tech>
10 months agoCmDataSubscription status code update 84/138084/1
mpriyank [Mon, 27 May 2024 12:33:36 +0000 (13:33 +0100)]
CmDataSubscription status code update

- Removing the unused NcmpRespnseStatus internal codes and messages
- Introducing statusCode 1 for ACCEPTED and 104 for REJECTED of
  CmSubscription
- Added check for status code and message both in the flow

Issue-ID: CPS-2238
Change-Id: Id99f099a398392dbef1504f9d7c658665d163902
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoCmSubscription overlapping case 75/138075/4
mpriyank [Fri, 24 May 2024 10:38:06 +0000 (11:38 +0100)]
CmSubscription overlapping case

- Directly ACCEPT the CmSubscription request in case of overlapping
  scenario
- The confirmation will be sent out when the DMI timeout has happened
- No request sent out to DMI plugin in this scenario

Issue-ID: CPS-2237
Change-Id: Ic799801058e9c8e1c2db8780a42ab85ea306f45e
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoMerge "CM SUBSCRIPTION: add new subscription for non existing xpath"
Priyank Maheshwari [Thu, 23 May 2024 15:29:37 +0000 (15:29 +0000)]
Merge "CM SUBSCRIPTION: add new subscription for non existing xpath"

10 months agoMerge "Add k6 performance tests for NCMP"
Lee Anjella Macabuhay [Thu, 23 May 2024 14:36:15 +0000 (14:36 +0000)]
Merge "Add k6 performance tests for NCMP"

10 months agoMerge "Remove un-used code of RestTemplate"
Toine Siebelink [Thu, 23 May 2024 12:26:32 +0000 (12:26 +0000)]
Merge "Remove un-used code of RestTemplate"

10 months agoCM SUBSCRIPTION: add new subscription for non existing xpath 91/137991/7
emaclee [Mon, 20 May 2024 07:54:44 +0000 (08:54 +0100)]
CM SUBSCRIPTION: add new subscription for non existing xpath

- added new method for when adding new subscription for non
  existing xpath but existing cmhandle

Issue-ID: CPS-2207
Change-Id: I149fbaea2f276503cb9d45c8807519bbe0417f3b
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
10 months agoAdd k6 performance tests for NCMP 27/137827/9
danielhanrahan [Mon, 29 Apr 2024 15:16:42 +0000 (16:16 +0100)]
Add k6 performance tests for NCMP

This commit adds K6 tests for NCMP functionalities:
- Registration of 20000 CM-handles
- Synchronous single CM-handle passthrough read operation
- CM-handle and ID searches for no filter, module, and public property
- De-registration of 20000 CM-handles
- A mixed load test
Also includes a README and shell scripts to run all tests.

Issue-ID: CPS-2199
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ia2e59674057ed28f5f9ceed9465133f7c0ce8318

10 months agoRemove un-used code of RestTemplate 36/138036/5
sourabh_sourabh [Tue, 21 May 2024 11:16:43 +0000 (12:16 +0100)]
Remove un-used code of RestTemplate

 - Removed unused property belons to resttemplate
 - Refactored dmi properties class (from static internal class)
 - Overriden getter method of dmi basepath that removes any leading and trailing slashes from it.

Issue-ID: CPS-2202
Change-Id: I16f61388fce2a6b9e258788fa826d485581d6138
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
10 months agoRemove allowReserved from Swagger definitions for CPS & NCMP 39/138039/2
ToineSiebelink [Wed, 22 May 2024 11:05:24 +0000 (12:05 +0100)]
Remove allowReserved from Swagger definitions for CPS & NCMP

- this option was used on some URL parameters (by accident)
- does not seem to affect production code but is at least misleading

Issue-ID: CPS-2230
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I32712a840346715f4891304c2059d49f10e959d6

10 months agoMerge "re-enable Operation Too Large Exception: limit 200"
Toine Siebelink [Wed, 22 May 2024 10:40:38 +0000 (10:40 +0000)]
Merge "re-enable Operation Too Large Exception: limit 200"

10 months agoMerge "Fix performance build output being lost"
Lee Anjella Macabuhay [Wed, 22 May 2024 09:40:13 +0000 (09:40 +0000)]
Merge "Fix performance build output being lost"

10 months agore-enable Operation Too Large Exception: limit 200 37/138037/1
ToineSiebelink [Wed, 22 May 2024 08:41:55 +0000 (09:41 +0100)]
re-enable Operation Too Large Exception: limit 200

- settign limit to 200

Issue-ID:CPS-2164

Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I728af7658e3f4e0900f286a544dea3bdb5d6773f

10 months agoFix performance build output being lost 19/138019/3
halil.cakal [Mon, 20 May 2024 14:10:45 +0000 (15:10 +0100)]
Fix performance build output being lost

- this fix for CpsPath Registry attributes Query plot
- also include bump up lombok to latest to fix the error
  does not have member field
  com.sun.tools.javac.tree.JCTree qualid
- rename conflicting the performance
  test name: CpsPath Registry attributes Query to fix plot issue

Issue-ID: CPS-2232

Change-Id: I7a0536ac2b48565df62fa46dddd27785addafa42
Signed-off-by: halil.cakal <halil.cakal@est.tech>
10 months agoCPS-2182 - #4 Add module Set tag to NCMPs DMI Batch Data interface 62/137862/13
david.mcweeney [Wed, 8 May 2024 14:11:12 +0000 (15:11 +0100)]
CPS-2182 - #4 Add module Set tag to NCMPs DMI Batch Data interface

Change-Id: I46b261e0a0ef2d37a307291931ba67762fb7767d
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2182

10 months agoMerge "CPS-2187 - #6 Add module Set Tag to ncmp (single cm handle) data request to...
Toine Siebelink [Mon, 20 May 2024 08:46:02 +0000 (08:46 +0000)]
Merge "CPS-2187 - #6 Add module Set Tag to ncmp (single cm handle) data request to dmi"

10 months agoMerge "CmSubscription topics param update"
Lee Anjella Macabuhay [Mon, 20 May 2024 08:26:25 +0000 (08:26 +0000)]
Merge "CmSubscription topics param update"

10 months agoReplaced RestTemplate with WebClient in synchronous DMI calls 79/137879/6
sourabh_sourabh [Tue, 7 May 2024 11:31:44 +0000 (12:31 +0100)]
Replaced RestTemplate with WebClient in synchronous DMI calls

    - added DmiWebClientConfiguration
    - use WebClient in DmiRestClient
    - fixed unit tests
    - encode query params for DMI request
    - added configurable buffer size
    - Re-used ncmp.dmi.httpclient.maximumConnectionsTotal parameter
(as documented in RTD) to control webclient connection poolsize

Issue-ID: CPS-2173
Change-Id: I21584563034d58e8ae3ff3cbcf172e0d14b408fb
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
10 months agoCmSubscription topics param update 48/137948/2
mpriyank [Thu, 16 May 2024 15:35:49 +0000 (16:35 +0100)]
CmSubscription topics param update

- topic application parameters updated to be in sync with the actual
  convention we are following for the flow.
- environment variables also updated to follow the same
- removed the unused parameters related to notification

Issue-ID: CPS-2210
Change-Id: If5adb3dac1ce81df5afe2e99f99513adc2011cc9
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoSet CPS Project Status to 'Mature' 38/137938/1
ToineSiebelink [Thu, 16 May 2024 14:33:16 +0000 (15:33 +0100)]
Set CPS Project Status to 'Mature'

As approved by TSC on 2024-05-16
See also https://wiki.onap.org/display/DW/ONAP+Project+and+Component+Lifecycle

Issue-ID: CPS-2224
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I60933c208a98adb65cf68e7fdc352839846a772c

10 months agoMerge "Integration for getting cm handle by longest alternate id match"
Toine Siebelink [Thu, 16 May 2024 13:42:27 +0000 (13:42 +0000)]
Merge "Integration for getting cm handle by longest alternate id match"

10 months agoCPS-2187 - #6 Add module Set Tag to ncmp (single cm handle) data request to dmi 14/137914/3
david.mcweeney [Wed, 15 May 2024 15:35:48 +0000 (16:35 +0100)]
CPS-2187 - #6 Add module Set Tag to ncmp (single cm handle) data request to dmi

Change-Id: I59cdb021d8f2f767b943f09715f4becad820e786
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2187

10 months agoMerge "CPS-2181 - #1 Included Module Set Tag in NCMP calls to DMI for Yang Module...
Toine Siebelink [Thu, 16 May 2024 08:18:10 +0000 (08:18 +0000)]
Merge "CPS-2181 - #1 Included Module Set Tag in NCMP calls to DMI for Yang Module Resources"

10 months agoMerge "More fine tuning around remainin plots"
Toine Siebelink [Wed, 15 May 2024 14:34:52 +0000 (14:34 +0000)]
Merge "More fine tuning around remainin plots"

10 months agoMore fine tuning around remainin plots 10/137910/1
halil.cakal [Wed, 15 May 2024 13:50:33 +0000 (14:50 +0100)]
More fine tuning around remainin plots

- Fine tuning for the plots only:
- Read datatrees for multiple xpaths
- Query with all descendants
- Writing 200 devices
- Saving list of 50 devices

Issue-ID: CPS-2192

Change-Id: I508e31cd861a4006cac41ebbbe307b7bd2acde2f
Signed-off-by: halil.cakal <halil.cakal@est.tech>
10 months agoCPS-2181 - #1 Included Module Set Tag in NCMP calls to DMI for Yang Module Resources 38/137838/8
david.mcweeney [Wed, 1 May 2024 11:08:00 +0000 (12:08 +0100)]
CPS-2181 - #1 Included Module Set Tag in NCMP calls to DMI for Yang Module Resources

Change-Id: I4f8cf79667e3155f49b9109d26b5807f5d54f90c
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2181

10 months agoIntegration for getting cm handle by longest alternate id match 34/137834/3
sourabh_sourabh [Thu, 2 May 2024 15:46:21 +0000 (16:46 +0100)]
Integration for getting cm handle by longest alternate id match

- Added a new integration test to check total time and memory taken to
  get cm handle by its longest match alternate id.

Issue-ID: CPS-2176
Change-Id: I7a6b299c46803a0878406f1e16fdae970b361dd9
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
10 months agoBump CPS to 3.5.0-SNAPSHOT 02/137902/1
mpriyank [Wed, 15 May 2024 09:39:02 +0000 (10:39 +0100)]
Bump CPS to 3.5.0-SNAPSHOT

- bump cps to 3.5.0-SNAPSHOT

Issue-ID: CPS-2228
Change-Id: I8a6d7e702b557d5b90dd384bbe429de4958ef77f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoMerge "CPS Bump to 3.4.10-SNAPSHOT"
Daniel Hanrahan [Tue, 14 May 2024 12:25:36 +0000 (12:25 +0000)]
Merge "CPS Bump to 3.4.10-SNAPSHOT"

10 months agoMerge "Adjust percentage limits to 10 percent below the threshold"
Toine Siebelink [Tue, 14 May 2024 11:51:10 +0000 (11:51 +0000)]
Merge "Adjust percentage limits to 10 percent below the threshold"

10 months agoCPS Bump to 3.4.10-SNAPSHOT 89/137889/2
mpriyank [Tue, 14 May 2024 09:09:55 +0000 (10:09 +0100)]
CPS Bump to 3.4.10-SNAPSHOT

- bumping CPS to 3.4.10-SNAPSHOT version

Issue-ID: CPS-2221
Change-Id: I8513582791078762bfb9d828966028c233e031db
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoMerge "container yaml for cps 3.4.9"
Daniel Hanrahan [Tue, 14 May 2024 08:59:23 +0000 (08:59 +0000)]
Merge "container yaml for cps 3.4.9"

10 months agocontainer yaml for cps 3.4.9 87/137887/1
mpriyank [Mon, 13 May 2024 17:28:53 +0000 (18:28 +0100)]
container yaml for cps 3.4.9

- container yaml to release CPS 3.4.9

Issue-ID: CPS-2221
Change-Id: I8dee6c42230f38c7a1fdf1dc7821e71c5da2af06
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoMaven stage yaml for CPS 3.4.9 86/137886/2
mpriyank [Mon, 13 May 2024 17:22:14 +0000 (18:22 +0100)]
Maven stage yaml for CPS 3.4.9

- maven stage yaml to release CPS 3.4.9

Issue-ID: CPS-2221
Change-Id: Ifc16ed01cc4d7928d5f9ec86ebe668ab26285584
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoAdjust percentage limits to 10 percent below the threshold 85/137885/1
halil.cakal [Mon, 13 May 2024 12:43:55 +0000 (13:43 +0100)]
Adjust percentage limits to 10 percent below the threshold

Issue-ID: CPS-2192

Change-Id: Iac37751b17f186e550ce12e3e17968d90cbf432a
Signed-off-by: halil.cakal <halil.cakal@est.tech>
10 months agoMerge "Ncmp out event for REJECTED scenario"
Daniel Hanrahan [Fri, 10 May 2024 13:22:05 +0000 (13:22 +0000)]
Merge "Ncmp out event for REJECTED scenario"

10 months agoNcmp out event for REJECTED scenario 70/137870/1
mpriyank [Thu, 9 May 2024 15:04:40 +0000 (16:04 +0100)]
Ncmp out event for REJECTED scenario

- Handling and publishing the event to client when dmi plugin rejects
  applying the subscription
- test scenarios to support the same

Issue-ID: CPS-2214
Change-Id: I2ac6d125a7262a7428a962d81a26a33594b570d9
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoFine tuning of the performance plots 69/137869/2
halil.cakal [Thu, 9 May 2024 14:24:46 +0000 (15:24 +0100)]
Fine tuning of the performance plots

- Fine tune some of the performance plots which are
  not align to the limit

Issue-ID: CPS-2200

Change-Id: I925443aa74a4eb814728d0642db0951c76f86186
Signed-off-by: halil.cakal <halil.cakal@est.tech>
10 months agoRelease note for cps-change-event toggle 66/137866/1
mpriyank [Thu, 9 May 2024 10:46:09 +0000 (11:46 +0100)]
Release note for cps-change-event toggle

- Release notes to enable and disable the toggle functionality
  introduced.
- If the CPS change events are of no interest to them then they can be
  disabled by the environment variable CPS_CHANGE_EVENT_NOTIFICATIONS_ENABLED

Issue-ID: CPS-2211
Change-Id: If2fddb6a499e24194b3eeca2ecdf99b8fb5ec687
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
10 months agoConditional cps change events 54/137854/3
mpriyank [Tue, 7 May 2024 14:33:19 +0000 (15:33 +0100)]
Conditional cps change events

- introduced a parameter to control the cps core change event
  notifications. we should be able to disable these notifications
  without affecting other notification flows.
- fixed the LayeredArchitectureTest as we are accessing the Anchor model
  in the events package now.

Issue-ID: CPS-2213
Change-Id: Id875925bc14de1cc6e8fa3193c0df470e09fe43f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
11 months agoMerge "Schedule response to client"
Lee Anjella Macabuhay [Tue, 7 May 2024 09:57:09 +0000 (09:57 +0000)]
Merge "Schedule response to client"

11 months agoMerge "[BUG] Correctly parse observedTimestamp"
Lee Anjella Macabuhay [Fri, 3 May 2024 14:55:32 +0000 (14:55 +0000)]
Merge "[BUG] Correctly parse observedTimestamp"