Liam Fallon [Mon, 5 Jul 2021 07:36:38 +0000 (07:36 +0000)]
Merge "Fix Sonar Issues in apex examples-adaptive"
a.sreekumar [Tue, 29 Jun 2021 12:57:14 +0000 (13:57 +0100)]
Cleanup input & outputFields from Task definition
1) Remove the usage of inputField and outputField from Task definition.
2) Fix issues around populating events to task in case of State
Finalizer Logic.
Change-Id: Ief17f400729410b83c6b7c665980d443e0cf6f28
Issue-ID: POLICY-3336
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
lapentafd [Tue, 29 Jun 2021 10:31:34 +0000 (11:31 +0100)]
Fix Sonar Issues in apex examples-adaptive
Replacing local-variable type inference
Replaced EqualsAndHashCode ToString
methods with lombok annotation in AutoLearn class
Issue-ID: POLICY-3093
Change-Id: I3f3911222f0e34ad3c7687d7a1e1aad218448303
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Jim Hahn [Wed, 30 Jun 2021 03:36:29 +0000 (03:36 +0000)]
Merge "Use unique name in apex-pdp messages"
a.sreekumar [Tue, 29 Jun 2021 13:47:03 +0000 (14:47 +0100)]
Fixing checkstyle issue in APEX
Change-Id: I6b88d59a54617cb9f14a5aaa2638f87a6c1ef3e9
Issue-ID: POLICY-3209
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Jim Hahn [Tue, 29 Jun 2021 12:33:33 +0000 (12:33 +0000)]
Merge "Changes to support multiple outputs from a state"
Liam Fallon [Tue, 29 Jun 2021 07:56:19 +0000 (07:56 +0000)]
Merge "Fix sonar issues in apex plugins and testsuites"
Jim Hahn [Mon, 28 Jun 2021 20:01:47 +0000 (16:01 -0400)]
Use unique name in apex-pdp messages
Used name generator for apex-pdp instance id.
Issue-ID: POLICY-3410
Change-Id: Ifcb216d45fba7d6b10043f39fcb299daffe86b69
Signed-off-by: Jim Hahn <jrh3@att.com>
a.sreekumar [Tue, 22 Jun 2021 14:55:46 +0000 (15:55 +0100)]
Changes to support multiple outputs from a state
This review addresses two main changes:
1) inputFields and outputFields are not tied to task definition anymore.
Instead inputEvent and outputEvents associated to a task is populated
as part of the policy state definition, as the state definition have
the information anyway.
- Clean up of the usage of inputFields and outputFields in task
definition will happen in a future review
- inputFields and outputFields defined in task definition in
policies until honolulu will not make the policy invalid as the
changes are done in backward compatible way.
2) Multiple output events can come out of a final state now.
- Define another policy state output with the relevant eventName in
the command file
- In the task logic, create a map to store the fields of the relevant
outputEvent, and then just call
"executor.addFieldsToOutput(<the_map_of_fields>)"
These 2 steps are enough to send multiple events to relevant
components as per the apex configuration.
Change-Id: Id88ca402704106404f529e595e1a76f6bf167876
Issue-ID: POLICY-3336
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Ajith Sreekumar [Mon, 28 Jun 2021 09:35:23 +0000 (09:35 +0000)]
Merge "Update policy-apex-pdp for checkstyle 8.43"
liamfallon [Mon, 28 Jun 2021 09:15:14 +0000 (10:15 +0100)]
Update policy-apex-pdp for checkstyle 8.43
Issue-ID: POLICY-3209
Change-Id: I0cb6fc8f5693fe03b4d68af2fde5116e9e248115
Signed-off-by: liamfallon <liam.fallon@est.tech>
Ajith Sreekumar [Mon, 28 Jun 2021 08:49:09 +0000 (08:49 +0000)]
Merge "Update apex-pdp for checkstyle 8.43"
lapentafd [Fri, 25 Jun 2021 13:52:51 +0000 (14:52 +0100)]
Fix sonar issues in apex plugins and testsuites
Replacing local-variable type inference
Issue-ID: POLICY-3093
Change-Id: I715231d6cf71d13c87b260b9f903910f9a5c434f
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
liamfallon [Thu, 24 Jun 2021 16:01:11 +0000 (17:01 +0100)]
Update apex-pdp for checkstyle 8.43
Issue-ID: POLICY-3206
Change-Id: I3873c85aab577e85a9ae6b610c3871ee4de6ea53
Signed-off-by: liamfallon <liam.fallon@est.tech>
lapentafd [Tue, 22 Jun 2021 11:29:11 +0000 (12:29 +0100)]
Sonar Issues in Apex plugins-context
Replacing local-variable type inference, and checkstyle fix
Refactor lambda expression to have one invocation to throw exception
Issue-ID: POLICY-3093
Change-Id: I6f89793a3652c50897d7f8e0fda35fffba903acc
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
lapentafd [Wed, 16 Jun 2021 11:23:23 +0000 (12:23 +0100)]
Fix Sonar Issues in apex-pdp-services-engine
Test refactoring and local-variable type inference replaced
Issue-ID: POLICY-3093
Change-Id: I0c5506f27ea53da7740acce87a25060ba2bce7f4
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
lapentafd [Tue, 15 Jun 2021 10:09:52 +0000 (11:09 +0100)]
Fix Sonar issues in apex-pdp
Issue-ID: POLICY-3093
Change-Id: I4def597b054a9ab2f3cc9a4665df04dd1d515ebf
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
lapentafd [Thu, 10 Jun 2021 15:38:21 +0000 (16:38 +0100)]
Fix Rebase Issue on Sonar Issues apex-pdp-model
Deleting a duplicate method inserted in two different reviews
Issue-ID: POLICY-3093
Change-Id: Ie7c06c17ad1df380ebcd7129c218f5784152ff0e
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Pamela Dragosh [Thu, 10 Jun 2021 13:30:35 +0000 (13:30 +0000)]
Merge "Fix Sonar Issues in apex-pdp-basic-model"
Ram Krishna Verma [Wed, 9 Jun 2021 18:20:27 +0000 (18:20 +0000)]
Merge "Fix Sonar Issues in apex-pdp-model"
lapentafd [Tue, 8 Jun 2021 12:20:41 +0000 (13:20 +0100)]
Fix Sonar Issues in apex-pdp-basic-model
Test refactoring and use of Local-Variable Type Inference
Issue-ID: POLICY-3093
Change-Id: If19c9ec96ba440a58eff679f276e4b53a26ce1ab
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
lapentafd [Wed, 2 Jun 2021 11:02:46 +0000 (12:02 +0100)]
Fix Sonar Issues in apex-pdp-model
Changes made into model/basic-model
Renamed test classes to match the others
Issue-ID: POLICY-3093
Change-Id: I7a0d6046ead42a9165aaf96b89511dd8d064d109
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Ajith Sreekumar [Wed, 2 Jun 2021 11:44:06 +0000 (11:44 +0000)]
Merge "Fix Sonar Issues on Apex-pdp"
lapentafd [Thu, 27 May 2021 09:18:49 +0000 (10:18 +0100)]
Fix Sonar Issues on Apex-pdp
Changes made into cli-codegen, cli-editor, and core-engine
Renamed one test class to match other test classes
Issue-ID: POLICY-3093
Change-Id: Ib2d947782021590ffc08d426e7a1607a8c33f98a
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
a.sreekumar [Fri, 28 May 2021 10:40:37 +0000 (11:40 +0100)]
Fixing issues around policy deployment in APEX
Following items are fixed.
1) When in PASSIVE state, any policiesToBeUndeployed received
in PDP_UPDATE message are not handled.
2) APEX policy deployment fails when policiesToBeUndeployed
and policiesToBeDeployed come together in PDP_UPDATE message from PAP.
3) Improve response messages after deployment/undeployment.
Change-Id: I8f9c802db4b19c43881c734570b65ad66b3867d5
Issue-ID: POLICY-3332
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Ram Krishna Verma [Thu, 13 May 2021 19:31:07 +0000 (15:31 -0400)]
Remove csit folder from policy/apex-pdp
The csit test files for all repos have been consolidated in policy/docker to maintain them at single place and allow us to trigger verify jobs in gerrit reviews.
Issue-ID: POLICY-3257
Change-Id: I26d281b75d91e7bf1250e97b22d0e7a303815ed6
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
a.sreekumar [Wed, 12 May 2021 16:32:01 +0000 (17:32 +0100)]
Fix issue where apex-pdp test is failing in gitlab
One of the testcases in APEX-PDP is failing only in gitlab,
but not failing in jenkins or local builds.
The reason is "/I/Dont/Exist*" is an invlaid path in jenkins etc,
but it is valid in gitlab somehow.
Changing this to "/I/Dont/Exist\0" so that the path is invalid
irrespective of the build platform.
Change-Id: I42bbc9ae21f0d827082f446f8dd416dcc10349e2
Issue-ID: POLICY-3306
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Pamela Dragosh [Tue, 11 May 2021 19:09:55 +0000 (19:09 +0000)]
Merge "Support ':' in Apex Event Avro schema fieldnames"
a.sreekumar [Tue, 11 May 2021 11:27:42 +0000 (12:27 +0100)]
Update the default logback.xml in APEX to log to STDOUT
Update the default logback.xml to log to STDOUT,
so that while running in standalone mode, logs can be seen easily.
Change-Id: Ie0ccdbe11672c33723c920767ce14d1b26fa9762
Issue-ID: POLICY-3303
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
JohnKeeney [Mon, 10 May 2021 12:19:46 +0000 (13:19 +0100)]
Support ':' in Apex Event Avro schema fieldnames
Similar to '.' (_DoT_) and '-' (_Dash_), the ':' (_ColoN_) character
can now be used in Apex Event Field names specified using Avro Schema
Change-Id: I320058441a1a1a544b9f1619e45c96e71e5aa9e3
Signed-off-by: JohnKeeney <john.keeney@est.tech>
Issue-ID: POLICY-3301
Signed-off-by: JohnKeeney <john.keeney@est.tech>
Jim Hahn [Fri, 7 May 2021 22:19:15 +0000 (22:19 +0000)]
Merge "Code coverage for Service Engine Event"
arkadiusz.adamski [Tue, 27 Apr 2021 08:17:47 +0000 (09:17 +0100)]
Code coverage for Service Engine Event
- Increase code coverage for service engine events
Issue-ID: POLICY-3092
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I40bda05fc53168d86ec4ac1c72b69a1badb02b38
arkadiusz.adamski [Thu, 22 Apr 2021 11:24:48 +0000 (12:24 +0100)]
Code coverage for File Carrier Plugin
- Increase code coverage for file carrier plugin in service engine
Issue-ID: POLICY-3092
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I8c08ee55c9d31792e35a1acc79330c8eef42af56
Pamela Dragosh [Thu, 6 May 2021 12:35:29 +0000 (12:35 +0000)]
Merge "Add testcases for policy status and pdp statistics"
a.sreekumar [Wed, 5 May 2021 10:45:51 +0000 (11:45 +0100)]
Updating APEX base image from policy-jre-alpine to policy-jdk-alpine
The stackoverflow issue is happening only in standalone mode when
RestManager class is called from APEX Javascript logic to post a
JSON body, that too 6-7 out of 10 times.
To identify the exact root cause may need more investigation,
but changing the base image from policy-jre-alpine to policy-jdk-alpine
seems to have fixed the issue during local testing.
(Issue didn't happen 10 out of 10 times)
Change-Id: Ibe718294ff9ab04c70349b3bc52c3c66619f2093
Issue-ID: POLICY-3066
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Ram Krishna Verma [Tue, 4 May 2021 20:30:16 +0000 (16:30 -0400)]
Add testcases for policy status and pdp statistics
Adding testcases to validate policy status and pdp statistics api's.
Issue-ID: POLICY-3257
Change-Id: I730451c4abb19bab6ddf10cba58f63ab5ca3a11a
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Tue, 4 May 2021 11:56:38 +0000 (11:56 +0000)]
Merge "Remove GroupValidationResult"
Jim Hahn [Wed, 28 Apr 2021 19:45:22 +0000 (15:45 -0400)]
Remove GroupValidationResult
Removed GroupValidationResult, replacing it with BeanValidationResult.
Modified the ParameterGroup subclasses to use BeanValidator, adding
annotations where needed to trigger the validations that had been
automatically performed by GroupValidationResult.
Issue-ID: POLICY-2059
Change-Id: I2c0c01fac355e6cde4d8d6998dc42f8a2e2ebb65
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Fri, 30 Apr 2021 17:07:29 +0000 (17:07 +0000)]
Merge "Changes to retain executionProperties per event flow for better context handling"
Ram Krishna Verma [Wed, 28 Apr 2021 16:51:38 +0000 (16:51 +0000)]
Merge "Support delta policies in apex-pdp"
a.sreekumar [Wed, 28 Apr 2021 10:51:23 +0000 (11:51 +0100)]
Changes to retain executionProperties per event flow for better context handling
Change-Id: I11668e9222dd9c61cc3096fa5c754c8702a781bf
Issue-ID: POLICY-3227
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
waynedunican [Wed, 14 Apr 2021 12:19:35 +0000 (13:19 +0100)]
Support delta policies in apex-pdp
Remove scanning of policy list from apex engine. Use the
policiesToBeDeployed and policiesToBeUndeployed lists from PDP_UPDATE
message instead.
Issue-ID: POLICY-3170
Change-Id: Icdde66ef87d9feab83ccb1cf99a64d7870bcaaaa
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Ram Krishna Verma [Thu, 22 Apr 2021 14:13:17 +0000 (14:13 +0000)]
Merge "Changes to support Kafka over SSL in APEX"
Ram Krishna Verma [Thu, 22 Apr 2021 14:12:28 +0000 (14:12 +0000)]
Merge "Refactor of command line classes"
Liam Fallon [Thu, 22 Apr 2021 13:15:45 +0000 (13:15 +0000)]
Merge "Fix name of target-database property in persistence.xml files"
adheli.tavares [Tue, 13 Apr 2021 13:51:44 +0000 (14:51 +0100)]
Refactor of command line classes
ApexCommandLineArguments class to have parse() overriden to keep
remainingArgs taking the tosca file without -p.
Issue-ID: POLICY-3129
Change-Id: Ib067bf4c32992c4477cb6751f65269c103513d10
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
a.sreekumar [Wed, 21 Apr 2021 14:01:30 +0000 (15:01 +0100)]
Changes to support Kafka over SSL in APEX
The Kafka plugin in APEX-PDP already has a field "kafkaProperties" that
can take in any properties required for the Kafka client. This is apt to
store the SSL related properties as they could change based on the
server implementation.
To make the communication possible, the only change required in APEX is
to allow a property to have an empty value.
For e.g., to disable the server host name verification, ssl.endpoint.identification.algorithm must to be explicitly set to an empty string on the client.
Change-Id: If3adaeaf11e5fbbd2aff582b5d4ba7824017ea8a
Issue-ID: POLICY-3194
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Liam Fallon [Wed, 21 Apr 2021 12:41:44 +0000 (12:41 +0000)]
Merge "Code coverage for plugins jms event carrier"
arkadiusz.adamski [Mon, 12 Apr 2021 08:52:25 +0000 (09:52 +0100)]
Code coverage for plugins jms event carrier
- Increase code coverage for plugins jms event carrier
Issue-ID: POLICY-3109
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I28dd8c5b32eb91f8f5047916e8899439d4c62374
ktimoney [Wed, 14 Apr 2021 11:56:13 +0000 (12:56 +0100)]
Fix name of target-database property in persistence.xml files
Updated property javax.persistence.target-database to eclipselink.target-database
Removed tools/tools-common/testing.txt
Added Modifications Copyright to headers
Updated Postgres references to MySQL
Updated user information
Issue-ID: POLICY-3059
Change-Id: I42ad294458809c0a3dca4d3ce9dd1ae5a7daa417
Signed-off-by: ktimoney <kevin.timoney@est.tech>
Jorge Hernandez [Mon, 19 Apr 2021 13:30:41 +0000 (13:30 +0000)]
Merge "Update jMeter test files"
arkadiusz.adamski [Thu, 1 Apr 2021 11:43:14 +0000 (12:43 +0100)]
Code coverage for service engine event package
- Increase code coverage for service engine event package
Issue-ID: POLICY-3092
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: Iaed5fc31f242a47dd1dc46f5d5c74c43c720e9ee
Ajith Sreekumar [Thu, 15 Apr 2021 15:44:26 +0000 (15:44 +0000)]
Merge "Code coverage for jms protocol event plugin"
arkadiusz.adamski [Fri, 9 Apr 2021 14:23:46 +0000 (15:23 +0100)]
Update jMeter test files
- Update performance test file
- Update stability test file
Issue-ID: POLICY-3109
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: Ibcab9cd012ed9ea50cb389f45ae7d8149b850a2d
arkadiusz.adamski [Tue, 6 Apr 2021 08:56:55 +0000 (09:56 +0100)]
Code coverage for jms protocol event plugin
- Increase code coverage for jms protocol event plugin
Issue-ID: POLICY-3092
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I615d56736b548b3d5f552ae1becac771d445b477
a.sreekumar [Thu, 8 Apr 2021 10:06:14 +0000 (11:06 +0100)]
APEX-PDP incorrectly reports successful policy deployment to PAP
Change-Id: I2fbf0303805b4c5feead522ad78fd4ef518659af
Issue-ID: POLICY-3173
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Pamela Dragosh [Wed, 7 Apr 2021 15:34:57 +0000 (15:34 +0000)]
Merge "Use sh instead of ash in apex-pdp"
Jim Hahn [Tue, 6 Apr 2021 19:42:08 +0000 (15:42 -0400)]
Use sh instead of ash in apex-pdp
Issue-ID: POLICY-3160
Change-Id: Ic48de952b5717e4f33d0eac47b41c41a2a97b883
Signed-off-by: Jim Hahn <jrh3@att.com>
arkadiusz.adamski [Wed, 31 Mar 2021 11:23:35 +0000 (12:23 +0100)]
Update jMeter test file
Issue-ID: POLICY-3093
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: If9600785d46bed5596847991690fe1631b97bbf3
arkadiusz.adamski [Wed, 24 Mar 2021 16:24:22 +0000 (16:24 +0000)]
Fix sonar issues
- reduce methods Cognitive Complexity from 19 to the 15 allowed in CommandLineParser
- iteration replaced with bulk 'Collection.addAll' call
- remove redundant initializers
- replace try with try-with-resources
Issue-ID: POLICY-3093
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: Ia727b3145ef8f63bcfc07723191c85e1ec8c923c
Jim Hahn [Fri, 26 Mar 2021 19:17:39 +0000 (19:17 +0000)]
Merge "Fix sonar issues"
Jorge Hernandez [Thu, 25 Mar 2021 13:29:02 +0000 (13:29 +0000)]
Merge "Fix sonar issues"
arkadiusz.adamski [Wed, 24 Mar 2021 16:55:39 +0000 (16:55 +0000)]
Fix sonar issues
- change test method name to avoid triggering SQ warning
Issue-ID: POLICY-3093
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: Id2997319e9986582a85f383c1f737340f4b4ea2c
Ram Krishna Verma [Tue, 23 Mar 2021 17:03:52 +0000 (13:03 -0400)]
Override to default entry point in apex-pdp
Overriding to default entry point (/bin/sh) in apex-pdp docker file to support stand alone installations of docker image.
Issue-ID: POLICY-3062
Change-Id: I100674cedf78f7221128bc87dd562835f297e0dd
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
arkadiusz.adamski [Tue, 23 Mar 2021 18:29:25 +0000 (18:29 +0000)]
Fix sonar issues
- fix method name on ApexModel
Issue-ID: POLICY-3093
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: I853de0f48bbe683249b4c60c4189fb053c5c12a2
Jim Hahn [Tue, 23 Mar 2021 14:19:55 +0000 (14:19 +0000)]
Merge "Fixing issues around deploying APEX policies with duplicate concepts"
Ram Krishna Verma [Mon, 22 Mar 2021 21:45:22 +0000 (21:45 +0000)]
Merge "Delete keystores from apex"
a.sreekumar [Fri, 19 Mar 2021 17:49:07 +0000 (17:49 +0000)]
Fixing issues around deploying APEX policies with duplicate concepts
Deploying invalid APEX policies with duplicate concepts resulting in
corrupting all the policies in memory. This is fixed here.
This entire functionality handling multiple policies will be
revisited as part of https://jira.onap.org/browse/POLICY-3018
Change-Id: I751102d5dddcb92cdcede8222855e2f467bb724d
Issue-ID: POLICY-3141
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Jim Hahn [Fri, 19 Mar 2021 16:51:26 +0000 (12:51 -0400)]
Delete keystores from apex
The Keystore is no longer needed in the tarball, as it is supplied
externally by the CSITs and Helm charts. Deleted that file.
Also modified the junits to use utils-test to generates keystores at
runtime, thus deleted the junit keystore file, too.
Issue-ID: POLICY-3143
Change-Id: I9bb53fcb5887e73d661ec4c4083970630c61e5c1
Signed-off-by: Jim Hahn <jrh3@att.com>
a.sreekumar [Thu, 18 Mar 2021 12:39:46 +0000 (12:39 +0000)]
Fixing parallel event execution problem in APEX-PDP REST layer
Parallel event execution in APEX was resulting in incorrect dynamic REST url. This issue is fixed in this review.
Change-Id: Id8a28c001a7fd7915df1f5909109bb369667ab40
Issue-ID: POLICY-3019
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Jim Hahn [Thu, 18 Mar 2021 16:39:01 +0000 (16:39 +0000)]
Merge "Bump policy references to latest snapshot versions"
liamfallon [Thu, 18 Mar 2021 15:46:21 +0000 (15:46 +0000)]
Bump policy references to latest snapshot versions
Issue-ID: POLICY-3105
Change-Id: I59daab64c4e36fc382d3c1c6a9f4ffe805ddc252
Signed-off-by: liamfallon <liam.fallon@est.tech>
Liam Fallon [Thu, 18 Mar 2021 14:29:12 +0000 (14:29 +0000)]
Merge "Increase code coverage"
arkadiusz.adamski [Thu, 11 Mar 2021 10:09:10 +0000 (10:09 +0000)]
Increase code coverage
- increased test coverage in plugins-event-carrier-restserver package
Issue-ID: POLICY-3092
Change-Id: I10ad7f0dd24293de6ce426553c7bc7a2fe3be013
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
jhh [Tue, 16 Mar 2021 15:29:52 +0000 (10:29 -0500)]
Update policy-keystore with newer certificates
Issue-ID: POLICY-3139
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia67cb1486a5625385a710c5f6c2b4325ca108820
Ram Krishna Verma [Mon, 15 Mar 2021 18:19:50 +0000 (18:19 +0000)]
Merge "Increase code coverage"
arkadiusz.adamski [Thu, 11 Mar 2021 09:55:54 +0000 (09:55 +0000)]
Increase code coverage
- increased test coverage in the event.protocol.xml package
Issue-ID: POLICY-3092
Change-Id: Ie68f8acf49d258536ddc23a14d05302273687634
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
liamfallon [Fri, 12 Mar 2021 09:23:56 +0000 (09:23 +0000)]
Bump apex-pdp to 2.6.0-SNAPSHOT
Issue-ID: POLICY-3105
Change-Id: I53abd7e9cf8c1425d115b0bb917db6389e9ded92
Signed-off-by: liamfallon <liam.fallon@est.tech>
a.sreekumar [Wed, 10 Mar 2021 13:21:56 +0000 (13:21 +0000)]
Bump apex-pdp to 2.5.2-SNAPSHOT
Change-Id: I291f968367b1f864bb417a72fd0bdb22a07ba0f7
Issue-ID: POLICY-3127
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Wed, 10 Mar 2021 12:16:21 +0000 (12:16 +0000)]
Release apex-pdp 2.5.1 docker
Change-Id: I9b5ee20c4760d4f9adcc28c708af62922d6952fa
Issue-ID: POLICY-3127
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Wed, 10 Mar 2021 10:33:47 +0000 (10:33 +0000)]
Release apex-pdp 2.5.1 maven artifacts
Change-Id: Ib32e0a9dc3d3b9a27f712a02c0317bf7640bc12d
Issue-ID: POLICY-3127
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Tue, 9 Mar 2021 18:03:40 +0000 (18:03 +0000)]
Point to policy-models 2.4.1
Change-Id: I142f196ddcd71048b6812af2d6af014ca42aa5a9
Issue-ID: POLICY-3127
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Ram Krishna Verma [Wed, 24 Feb 2021 15:39:51 +0000 (10:39 -0500)]
Update info.yaml in apex-pdp
Issue-ID: POLICY-3028
Change-Id: Icf1319122ed19a0ba36b148bab7d77be626ba20e
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
a.sreekumar [Wed, 24 Feb 2021 13:40:41 +0000 (13:40 +0000)]
Bump apex-pdp to 2.5.1-SNAPSHOT
Change-Id: I761ded255a97128f858d3a7ce95f2479b6208a4e
Issue-ID: POLICY-3088
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Ram Krishna Verma [Wed, 24 Feb 2021 03:31:41 +0000 (22:31 -0500)]
Release apex-pdp 2.5.0 docker image
Issue-ID: POLICY-3088
Change-Id: Id5754dac1e8bab68cdb280800750ad98f14c76b1
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Tue, 23 Feb 2021 20:45:51 +0000 (20:45 +0000)]
Merge "Fixing intermittent test failures in APEX"
Ram Krishna Verma [Tue, 23 Feb 2021 19:45:50 +0000 (14:45 -0500)]
Release apex-pdp 2.5.0 maven artifacts
Issue-ID: POLICY-3088
Change-Id: Ifa746c534623e43f883f9101c4beb0f34dffbaac
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
a.sreekumar [Tue, 23 Feb 2021 19:07:08 +0000 (19:07 +0000)]
Fixing intermittent test failures in APEX
This review should fix the intermittent test failures in
TestExecutionPropertyRest class in APEX.
Change-Id: I1871a3ac1a40985ad44bbd1433c54930793c7b3c
Issue-ID: POLICY-3096
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Tue, 23 Feb 2021 15:45:34 +0000 (15:45 +0000)]
Point to released version of docker, parent, common and models
Change-Id: I17e2e093421733fc94a3de8f5946b867b3b73ba9
Issue-ID: POLICY-3088
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
liamfallon [Wed, 17 Feb 2021 17:19:41 +0000 (17:19 +0000)]
Convert Date to Instant in stats
Issue-ID: POLICY-3069
Change-Id: Ib30782485652ec693d2dbea79514183c7cfbb0c4
Signed-off-by: liamfallon <liam.fallon@est.tech>
Ram Krishna Verma [Fri, 19 Feb 2021 17:42:41 +0000 (17:42 +0000)]
Merge "Fix sonars in apex-pdp"
a.sreekumar [Thu, 18 Feb 2021 15:51:32 +0000 (15:51 +0000)]
Update CSIT to check for 202 response during PAP Deployment
Change-Id: I947207f10cfd3bc54193ee7c8d356ad40587f072
Issue-ID: POLICY-2526
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Jim Hahn [Wed, 17 Feb 2021 20:23:38 +0000 (15:23 -0500)]
Fix sonars in apex-pdp
Addressed the following issues:
- initialize mocks before use
- use parameterized queries
- Random() is not secure
- provide parameterized type for generics
- unused imports
- constructor visibility
- use compute() instead of containsKey()/put()
- make final fields static
- rename constants to all upper case
- no assert() in Thread.run() methods
- nested try
- nested if/else
- too many break/continue
- use try-with-resources
- repeatable annotations
- overlapping characters in reg ex
- hashcode is not sufficient in compareTo()
- need equals() with compareTo()
- make class an interface
- use parameterized test
- multiple calls in assert()
- log or re-throw
- use different type of lambda
- use parameterized logging
- use StringBuilder instead of concatenation
- use StandardCharsets.UTF_8
Issue-ID: POLICY-2906
Change-Id: I2cf8c885e3e22c2c6cbe6403a34906928afad022
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 17 Feb 2021 21:07:33 +0000 (16:07 -0500)]
Replace GsonXxxAdapters
The GsonXxxAdapters were removed from the models Serialization classes
and replaced with type adapters from common. Modified the code to refer
to the new adapters.
Without this fix, examples-onap-vcpe will not compile. Could that be
the cause of the apex-pdp standalone issue, POLICY-3066?
Allow TypeAdapter in lieu of JsonSerializer/Deserializer adapters in
config files.
Note: examples-ona-bbs refers to the following, which were removed
several releases ago (during the actor re-write?):
- appclcm.util.Serialization$RequestAdapter & Serialization$ResponseAdapter
Issue-ID: POLICY-2905
Change-Id: Ia57e0346343614cbd4a1cffd9c8393f207284244
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 11 Feb 2021 18:41:45 +0000 (13:41 -0500)]
Fix jackson version in apex-pdp
The kafka_2.12 jar depends on jackson-module-scala, but the default
version does not work with the version of jackson used by policy.
Modified the dependency tree to include a version that does work.
Issue-ID: POLICY-3005
Change-Id: I06fd5b99d6e5c1053e17a754f22f815062f907b2
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Wed, 10 Feb 2021 17:59:54 +0000 (12:59 -0500)]
move csit to policy/apex-pdp repo
move csit to policy/apex-pdp repo
Issue-ID: POLICY-2895
Change-Id: I73bd2f59c09f4ae213cab9b1dd2a83e909b218c6
Signed-off-by: Taka Cho <takamune.cho@att.com>
a.sreekumar [Tue, 9 Feb 2021 18:21:49 +0000 (18:21 +0000)]
Changes related to multi policy handling improvement in APEX
This review fixes an issue identified during testing the changes done
for improving multiple policy handling in APEX.
Changes done to a few test files in the previous review are reverted as
well.
Change-Id: I98324da708239d314aadd4c45dc377137fd552ba
Issue-ID: POLICY-2883
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
liamfallon [Wed, 10 Feb 2021 14:01:23 +0000 (14:01 +0000)]
Remove URL and useerid from JMS plugin
This review makes the default URL and userid for JMS null, the actual
values must be specified as parameters.
Issue-ID: POLICY-3035
Change-Id: I9c06d94d8816092425e2df58b849d837ad953fb2
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Sun, 7 Feb 2021 18:52:13 +0000 (18:52 +0000)]
Remove security credentials from JMS plugin
The default security credential of "password" was encoded in a constant
in the JMS plugin parameters file. This commit removes these credentials
and defaults the credentials to null.
Issue-ID: POLICY-3035
Change-Id: I6313340e64c893c4f99de78d9dd448ac53d81246
Signed-off-by: liamfallon <liam.fallon@est.tech>
a.sreekumar [Mon, 25 Jan 2021 11:03:42 +0000 (11:03 +0000)]
Improve handling of multiple policy in APEX PDP
Change-Id: Ic4adf5bd8876dc31fc93993298e90389baaa2c39
Issue-ID: POLICY-2883
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>