liamfallon [Thu, 27 Sep 2018 15:52:23 +0000 (16:52 +0100)]
Add JUnit for web service client tool
JUnit, SOnar fixes, and some minor bug fixes.
Issue-ID: POLICY-1034
Change-Id: I72f46e944051f7d65d6b106afe33c759975283af
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Thu, 27 Sep 2018 14:40:13 +0000 (15:40 +0100)]
Add missing example policy models to install
The policy models for the decision maker, periodic, and
vCPE examples were not included in the install because the
policy model json files are generated from CLI commands.
THis review installs the generated policy models.
Issue-ID: POLICY-954
Change-Id: Ie2076ddfb6199dac0c8b272de8d7c47f1652485e
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Thu, 27 Sep 2018 13:29:21 +0000 (14:29 +0100)]
Add unit test for Apex command line tools
THere was no unit test for the command line tools. This
review adds unit test and also fixes a few small bugs that
showed up when uit test was run.
Issue-ID: POLICY-1034
Change-Id: Ic19aacdb168fb5a6faa0cd83ed22ccfcedaa51f5
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Wed, 26 Sep 2018 17:30:37 +0000 (18:30 +0100)]
Allow custom JSON adapter specification
In order to decode and encode complex Java POJOs with GSON,
type adapters must be specified. This change allows specification
of GSON type adapters for decoding and encoding of JSON in apex.
Issue-ID: POLICY-954
Change-Id: Ib402d4e82c4f22fa4d532c016f77fb8e7bb568d3
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Wed, 26 Sep 2018 15:50:18 +0000 (16:50 +0100)]
Fix boolean constants in examples
When the checkstyle changes were made in the java code
the .TRUE and .FALSE values were changed to .isTrue and
.isFalse to comply with checkstyle. THis change needs to
be propogated into example scripts.
Issue-ID: POLICY-103
Change-Id: I419b5f398ef4f43b1b877d52bbe4ec638870f31d
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Tue, 25 Sep 2018 21:53:45 +0000 (22:53 +0100)]
Add JUnit for engine service
Although the Apex engine service is called by the policy engine
tests and the various interface tests, the test coverage on these
classes is not showing up in Sonar. In any event it is better
that specific JUint is done for them.
Issue-ID: POLICY-1034
Change-Id: I0028c7e5e870c18649870536cf3691fce2ab689c
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Tue, 25 Sep 2018 13:34:08 +0000 (14:34 +0100)]
JUnit for evaluation test model generator
Issue-ID: POLICY-1034
Change-Id: Ic8f9971d612dd5500c73f95e5cbbb786c5ad51f3
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Tue, 25 Sep 2018 12:03:21 +0000 (13:03 +0100)]
Fix sonar issues in Command line editor
THe Apex command line editor had issues in teh way its loops for processing
commands were written. The loops are simplified in this review.
Issue-ID: POLICY-1034
Change-Id: If684a57de79bd56211e1ca3e8c446bd9698666be
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Sun, 23 Sep 2018 13:37:49 +0000 (14:37 +0100)]
Fix more sonar issues
These are the last few easy to fix issues. Most remaining
issues are to do with code coverage.
Othersare due tot he way script interpreters work and will
have to be exempted.
Issue-ID: POLICY-1034
Change-Id: Ie1d1def43d33ef78a13d7f9b43ae4e22ef00cb5b
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Sat, 22 Sep 2018 20:07:43 +0000 (21:07 +0100)]
Fix sonar problems in Apex
Fixed some easy to resolve Sonar issues.
Issue-ID: POLICY-1034
Change-Id: Ia8e4606bd4307daca499b4a74c96135211e572fd
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Thu, 20 Sep 2018 20:13:19 +0000 (21:13 +0100)]
Fix bug with POJO events in APex
When an envet should be decoded entirely into a POJO
and is too complex for Avro, apex decoding breaks.
This reviuew fixes thsi issue.
Issue-ID: POLICY-1034
Change-Id: Iccd739c4bb5c1645a2a7165f5bbfdfd4b964d79e
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Wed, 19 Sep 2018 16:23:48 +0000 (17:23 +0100)]
Refactor Editor REST servlet
Issue-ID: POLICY-1034
Change-Id: Ifa08c7a31b4fe19eb62c2035b67b6f5cad313b5f
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Wed, 19 Sep 2018 20:44:33 +0000 (21:44 +0100)]
Fix examples broken by checkstyle changes
Checkstyle changes to some class names must be propgated
into example configurations and name changes meant some
examples were not being packaged.
Issue-ID: POLICY-1034
Change-Id: I5485fc2ffc22c496bbae9465e1c3b09c4feade97
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Wed, 19 Sep 2018 19:08:03 +0000 (20:08 +0100)]
Fix license issue with Hibernate dependency
Change-Id: I0f0ce81661c505a7df4b6199c6d0baf7a9d0ce3e
Issue-ID: POLICY-1059
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Pamela Dragosh [Tue, 18 Sep 2018 16:15:29 +0000 (16:15 +0000)]
Merge "remove license issues"
liamfallon [Tue, 18 Sep 2018 15:20:26 +0000 (16:20 +0100)]
remove license issues
Change the versions of some second order dependencies to
mitigate license issues.
Change-Id: I39745ec1eb7c72fb481a4adafc2805e4bbbd8386
Issue-ID: POLICY-1059
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
ramverma [Tue, 18 Sep 2018 14:39:34 +0000 (15:39 +0100)]
Fix issue in apex client editor
Change-Id: If12bd289d9c8a22b86b4a9c9bff21c1a9d42a3d1
Issue-ID: POLICY-954
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
liamfallon [Mon, 17 Sep 2018 14:50:34 +0000 (15:50 +0100)]
Fix sonar issues in apex utilties
This change fixes Sonar issues in apex command line
utilities.
Issue-ID: POLICY-1034
Change-Id: Ib63a3d4107260c5909405e6f0d899279da869028
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Mon, 17 Sep 2018 14:38:09 +0000 (14:38 +0000)]
Merge "Re-implement Kafka tests that periodically fail"
liamfallon [Sun, 16 Sep 2018 01:03:12 +0000 (02:03 +0100)]
Fix Sonar issues in apex
Fixing various Sonar issues in apex.
Issue-ID: POLICY-1034
Change-Id: Ie693637d75bd7e38c71b7ba04886fb75636276ed
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Fri, 14 Sep 2018 22:05:56 +0000 (23:05 +0100)]
Re-implement Kafka tests that periodically fail
The Kafla integration tests fail, this change re-implements
the tests using a test framework from salesforce.com
i
Issue-ID: POLICY-1034
Change-Id: Iffcc9e0a9f419c8ec439771be7a7a58faa2f9860
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Fri, 14 Sep 2018 15:45:06 +0000 (16:45 +0100)]
Fix exception not logged or rethrown
Eclipse sonarlint does not check for exception dropping by default,
it must be configured. This commit addresses exception dropping in
apex.
Change-Id: I406838990b3424c2912124b25d7326502cacc96c
Issue-ID: POLICY-1034
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Pamela Dragosh [Fri, 14 Sep 2018 13:42:12 +0000 (13:42 +0000)]
Merge "Try new version of JRuby"
Jorge Hernandez [Fri, 14 Sep 2018 13:19:52 +0000 (13:19 +0000)]
Merge "Address sonar/Checkstyle Issues"
liamfallon [Fri, 14 Sep 2018 12:00:30 +0000 (13:00 +0100)]
Try new version of JRuby
We had to use an old versino of JRuby due to security issues.
A new version of JRuby was released in May, it
seems to have a lower vulnerability level when tested
using the "pom" test. Raising this review to check it
in CLM.
Change-Id: I77bf8bae4f7efe66d7e244d0ff9a52432b00a5ce
Issue-ID: POLICY-1065
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
mmis [Fri, 14 Sep 2018 10:54:23 +0000 (11:54 +0100)]
Updated examples for renamed parameter classes
Parameter classes were renamed to correct camel case names, hence
the references to those parameter classes in the example config files
needs to be updated
Issue-ID: POLICY-1034
Change-Id: Ie388d6e25cf4bbec6984d4386cdeb19a7a3916c0
Signed-off-by: mmis <michael.morris@ericsson.com>
liamfallon [Thu, 13 Sep 2018 22:48:50 +0000 (23:48 +0100)]
Address sonar/Checkstyle Issues
Sweep through Apex codebase to fix most ceheckstyle and
straightforward sonar issues.
Issue-ID: POLICY-1034
Change-Id: I149d9a94ad893affc93573e8de5e3304b6bdde2d
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Thu, 13 Sep 2018 14:25:32 +0000 (15:25 +0100)]
Sonar/Checkstyle in service/plugins
Sonar and Checkstyle changes in plugins and services, and
knock on changes
Issue-ID: POLICY-1034
Change-Id: Iff7df74e54fce2c661dcc2fae75ae93d4cacfe5b
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Wed, 12 Sep 2018 22:29:25 +0000 (23:29 +0100)]
Sonar/Checkstyle in model/context/core
Checkstyle and sonar changes in the model, contexot
and core modules.
Issue-ID: POLICY-1034
Change-Id: I2d40bc877f3a548844470fc290fc89d63fa465ae
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Pamela Dragosh [Wed, 12 Sep 2018 19:54:09 +0000 (19:54 +0000)]
Merge "Fix soft stop and start of engine"
liamfallon [Wed, 12 Sep 2018 15:12:14 +0000 (16:12 +0100)]
Fix soft stop and start of engine
Stopping an apexc engine is a soft stop, allowing the engine
to be restarted again. However, when a model upgrade is carried out
the engine must be stopped and cleared to clear the previous model,
loaded with the new model and started again.
THis handling must work over the Web Socket admin interface and
also when apex is started as a service.
This change fixes the handling so that it is consistent and
works the same when apex is stopped/started/upgraded from
the command line or over the management web socket interface
Issue-ID: POLICY-1101
Change-Id: I1fe619641cb6ecd34d0669b4b7df105280e5e2c0
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Wed, 12 Sep 2018 14:40:10 +0000 (15:40 +0100)]
Fix build fails
Apex end to end tests often fail because the tests are not tuned correctly
for Jenkins.
The JRuby test needs a delay to allow the first test to completely clear dowm
The volume of events sent in the Kafka tests is reduced from 100 to 10
The dom4j version is also changed back to 1.6.1 because 1.6 has the same security
issues.
Issue-ID: POLICY-954
Change-Id: Id38bf9fe526942870181bfd9c0762f0a471c0c02
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Liam Fallon [Wed, 12 Sep 2018 08:35:30 +0000 (08:35 +0000)]
Merge "Updated example config for CSIT test"
liamfallon [Tue, 11 Sep 2018 15:09:02 +0000 (16:09 +0100)]
Use parent version of websocket
Two conflicting versions of the websocket library were being used,
causing an exception to be thrown on apex shutdown.
Using the common version of websocket solves this issue.
Issue-ID: POLICY-954
Change-Id: Id1a004b1f09931b53ec389c776f74c58f7b29e99
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Pamela Dragosh [Tue, 11 Sep 2018 14:29:27 +0000 (14:29 +0000)]
Merge "Fix install script/examples on apex"
Pamela Dragosh [Tue, 11 Sep 2018 14:11:01 +0000 (14:11 +0000)]
Merge "Checkstyle changes for apex model"
mmis [Tue, 11 Sep 2018 10:45:11 +0000 (11:45 +0100)]
Updated example config for CSIT test
Changed the config for the CSIT test to use javascript instead of mvel and
changed the REST server host to enable communication from outside the
docker container
Issue-ID: POLICY-1099
Change-Id: I6173545d70d6b83c86bbee132cf057985487a501
Signed-off-by: mmis <michael.morris@ericsson.com>
liamfallon [Tue, 11 Sep 2018 10:30:44 +0000 (11:30 +0100)]
Fix install script/examples on apex
The install script for apex did not coreate the soft link for apex
correctly.
One of the example json files was named incorrectlu.
Issue-ID: POLICY-954
Change-Id: If7923e2287aebb956bd4bc9ed4b26b23a40d048b
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Mon, 10 Sep 2018 16:05:36 +0000 (17:05 +0100)]
Checkstyle changes for apex model
Fix checkstyle warnings in the apex mode
and knock on changes.
Issue-ID: POLICY-1034
Change-Id: I10537e4288e9cad5ef18165ed2cdc1d3ab3139c1
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
mmis [Mon, 10 Sep 2018 14:20:00 +0000 (15:20 +0100)]
Added config and model to examples
Added a config and model file to examples to be used in CSIT test
Issue-ID: POLICY-1099
Change-Id: Idbd3bf323b366273bca9a5472abcf528725b2f77
Signed-off-by: mmis <michael.morris@ericsson.com>
Pamela Dragosh [Mon, 10 Sep 2018 13:10:59 +0000 (13:10 +0000)]
Merge "Address level 4-6 security issues"
ramverma [Sun, 9 Sep 2018 14:07:34 +0000 (15:07 +0100)]
Adding jacoco plugin to main pom
Overriding jacoco plugin setting in main pom of apex-pdp to build
cumulative coverage report at project level so that the same gets
reflected in sonar dashboard
Change-Id: Ia4272192dae3af73806ed1caf3186b537ef10df1
Issue-ID: POLICY-1034
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
liamfallon [Sat, 8 Sep 2018 14:22:21 +0000 (15:22 +0100)]
Address level 4-6 security issues
Remove commons-compress and chage version of dom4j
Also fix checkstyle in affected modules
Issue-ID: POLICY-1065
Change-Id: Id37e54a54997656674af37dfd924aec5f69e410a
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Fri, 7 Sep 2018 14:11:46 +0000 (15:11 +0100)]
Parameter group fields must have getters
Modifications to apex parameters to include getters
that follow naming conventions, and knock on changes.
Also checkstyle fixes taken in modifified classes.
Issue-ID: POLICY-1095
Change-Id: Iff5ccc7a069a4ec2b2b974ed9f5ed70a88692e00
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Wed, 5 Sep 2018 14:46:31 +0000 (15:46 +0100)]
Fix package of apex examples and documents
The examples are not packaged correctly in the apex build
and the client wars are missing
The links and location of the documents are corrected.
Some POM duplicate dependencies removed.
Javadoc warnings removed.
Issue-ID: POLICY-867
Change-Id: I555c29191c61c0a9887365d95005dbc584eddf04
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Dinh Danh Le [Wed, 29 Aug 2018 16:21:52 +0000 (17:21 +0100)]
Fix checkstyle warnings in examples
Change-Id: Iad533f3987792d8713426234f3277c1ef6b72284
Issue-ID: POLICY-1034
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Jorge Hernandez [Tue, 4 Sep 2018 20:13:38 +0000 (20:13 +0000)]
Merge "Fix checkstyle issues in apex model basic"
liamfallon [Tue, 4 Sep 2018 16:49:55 +0000 (17:49 +0100)]
Dependency version changes for security
Versions of Jython and hazelcast changed to more
secure versions.
Change-Id: Iad918705170846b8813512c4bd8087ba429f6e82
Issue-ID: POLICY-1065
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Tue, 4 Sep 2018 16:24:15 +0000 (17:24 +0100)]
Fix checkstyle issues in apex model basic
CHeckstyle issues in apex model basic and knock on changes
in other apex modules.
Issue-ID: POLICY-1034
Change-Id: I65823f5e2e344526abc74b0812877113acb056ec
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Thu, 30 Aug 2018 08:37:29 +0000 (09:37 +0100)]
Use parameter service in apex
Switch parameter handling in apex to use
the ONAP PF common parameter service
Change-Id: Id318d19c726b18b1a69c630fa81ca7d695355e9c
Issue-ID: POLICY-954
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Dinh Danh Le [Mon, 27 Aug 2018 14:57:41 +0000 (15:57 +0100)]
Fix checkstyle warning in tools & context packages
Change-Id: I5b72c7a35d56296cd5053659a9d4c1e8f3b058be
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-1034
Dinh Danh Le [Wed, 22 Aug 2018 23:41:47 +0000 (00:41 +0100)]
Add docs for the examples package
This review is big because it contains examples for the whole project.
The big size is mainly due to the site.xml, logos and css files which
are repeatedly created, and more aciidoc files are needed. The pom.xml
files are changed properly.
Change-Id: I42a94e4d898529f9249ef03de908c8b1a0142c7f
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-867
Dinh Danh Le [Wed, 22 Aug 2018 23:00:00 +0000 (00:00 +0100)]
Add docs for Testsuites package
Change-Id: I807ec0fe35775226b611567904a9ac4627b33775
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-867
Dinh Danh Le [Wed, 22 Aug 2018 17:02:01 +0000 (18:02 +0100)]
Add docs for client package
Change-Id: I820e70463e1715a342d78fa9d413638068a05125
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-867
Dinh Danh Le [Wed, 22 Aug 2018 11:41:50 +0000 (12:41 +0100)]
Add docs for tools package & update main apex-pdp
Change-Id: I2990157eb7bae51f7d38a652fd8dd488b7287cea
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-867
Dinh Danh Le [Mon, 20 Aug 2018 16:25:25 +0000 (17:25 +0100)]
Updating docs for Plugins module
Change-Id: Ia0837cf2f86c42eea71c3f71e8cd99d684912485
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-867
Pamela Dragosh [Wed, 15 Aug 2018 16:57:31 +0000 (16:57 +0000)]
Merge "Adding documentation for the packages module"
Jorge Hernandez [Wed, 15 Aug 2018 16:20:36 +0000 (16:20 +0000)]
Merge "Fix checkstyle warnings in core-engine module"
Jorge Hernandez [Wed, 15 Aug 2018 16:20:14 +0000 (16:20 +0000)]
Merge "Fix checkstyle warnings in context-test-utils"
Dinh Danh Le [Tue, 14 Aug 2018 16:05:56 +0000 (17:05 +0100)]
Fix checkstyle warnings in core-engine module
Change-Id: Ie79c88e21a3d1f4cd53fd678a7afcffe1c6c202c
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-1034
Dinh Danh Le [Tue, 14 Aug 2018 15:31:54 +0000 (16:31 +0100)]
Fix checkstyle warnings in context-test-utils
Change-Id: I6d6e7bdc19e4e90f5f0a31ac3c8f06514ac10264
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-1034
Dinh Danh Le [Tue, 14 Aug 2018 14:15:43 +0000 (15:15 +0100)]
Adding documentation for the packages module
Change-Id: I51c9963aca8381559643123ae2664c25117e3bee
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-867
Dinh Danh Le [Tue, 14 Aug 2018 11:32:51 +0000 (12:32 +0100)]
Fix checkstyle warnings in the auth package
Change-Id: I64f783d5325301862e2438ac5d22cfcc0a150579
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-1034
Dinh Danh Le [Mon, 13 Aug 2018 10:20:21 +0000 (11:20 +0100)]
Fix checkstyle warnings in the client module
Change-Id: I3263a833cc9dd6d86afdf2ae53de0e53c92850c9
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-1034
Dinh Danh Le [Sat, 11 Aug 2018 16:17:34 +0000 (17:17 +0100)]
Checkstyle the context-management package
Change-Id: Ifc4fef920681f21b0a965ea55d9bb78785ec66f9
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-1034
Dinh Danh Le [Thu, 9 Aug 2018 09:51:44 +0000 (10:51 +0100)]
Checkstyle the services-engine package
Change-Id: I0d7fd6f867ba280953eb4fd0dc2a5ad1779fb045
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-1034
Pamela Dragosh [Wed, 8 Aug 2018 19:12:34 +0000 (19:12 +0000)]
Merge "Adding Apex docs for Plugins module"
Dinh Danh Le [Sun, 5 Aug 2018 08:54:13 +0000 (09:54 +0100)]
Adding Apex docs for Plugins module
Change-Id: Icf68473b472a5896972de5b07b275682a77a1c9f
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-867
liamfallon [Fri, 3 Aug 2018 15:12:01 +0000 (16:12 +0100)]
Use common components in apex
Common ResourceUtil class replaces specific one in APEX
Managed dependency version clashes removed in POMs
Dependency versions with security vulnerabilities changed for
zookeeper
kafka
infinispan
Change-Id: I3c4b367cb5556b2dc255ab62c84f85738165eb81
Issue-ID: POLICY-954
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Thu, 2 Aug 2018 23:49:47 +0000 (23:49 +0000)]
Merge "Fixing sonar vulnerabilities in apex-pdp"
ramverma [Thu, 2 Aug 2018 11:50:09 +0000 (12:50 +0100)]
Fixing sonar vulnerabilities in apex-pdp
Changed the Console class to use logger only for printing stack trace,
as the class is meant to be used for CLI usage.
Changed the CLIParser to use Console class for printing messages.
Changed the client-editor to be hosted on localhost by default, to follow
the same what others clients (deployment, monitoring & client full) are doing.
Change-Id: I6565b4b35a93b3708b926bfee04d79ead6b5346e
Issue-ID: POLICY-954
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
ramverma [Tue, 31 Jul 2018 17:25:39 +0000 (18:25 +0100)]
Adding first set of apex-pdp document changes
Adding document changes for auth, context, core, model, services & the
main apex-pdp module.
Change-Id: Id0d026baa258f1dc6998978f9911f3c4a73b5b3b
Issue-ID: POLICY-867
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
ramverma [Mon, 30 Jul 2018 18:13:47 +0000 (19:13 +0100)]
Adding examples-servlet module to apex-pdp
Adding examples-servlet module to demonstrate the capability that
apex-pdp can be simply started as a servlet deployed in any application
server.
Change-Id: I5c9e323f1468cc14c6277c0037029679d00cd751
Issue-ID: POLICY-861
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
Jorge Hernandez [Mon, 30 Jul 2018 17:37:07 +0000 (17:37 +0000)]
Merge "Add test case for plugin event carrier RESTServer"
Jorge Hernandez [Mon, 30 Jul 2018 14:46:13 +0000 (14:46 +0000)]
Merge "Fixing UI bug in apex-pdp client"
Ronan Kenny [Mon, 30 Jul 2018 11:36:25 +0000 (12:36 +0100)]
Fixing UI bug in apex-pdp client
Minor change was needed in the .css file to correct a visual error.
Change-Id: If84a95c079b34e3395da0864ba4009fbd13640c9
Issue-ID: POLICY-954
Signed-off-by: Ronan Kenny <ronan.kenny@ericsson.com>
Dinh Danh Le [Sat, 28 Jul 2018 22:01:04 +0000 (23:01 +0100)]
Add test case for plugin event carrier RESTServer
Change-Id: Ia81a35e359c1f7072f4a39db871076d478dd7dab
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-954
ramverma [Fri, 27 Jul 2018 09:40:01 +0000 (10:40 +0100)]
Fixing sonar bugs in apex-pdp
Sonar was complaining about direct comparision of double values. Changed
the comparision to Double.compare(d1,d2).
Change-Id: I3821924e606180626434d5bc41e29b9a8451a9b2
Issue-ID: POLICY-861
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
ramverma [Wed, 25 Jul 2018 16:26:52 +0000 (17:26 +0100)]
Renaming examples in apex-pdp
Renaming the examples as per what the documentation expects them.
Otherwise the documents won't work.
Change-Id: Ib9e30bf5a4cec0fec981372e1d9f3a0ee5d60f2f
Issue-ID: POLICY-861
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
Jorge Hernandez [Wed, 25 Jul 2018 13:56:20 +0000 (13:56 +0000)]
Merge "Adding more examples to apex-pdp"
ramverma [Tue, 24 Jul 2018 16:36:53 +0000 (17:36 +0100)]
Adding more examples to apex-pdp
- Adding more examples (DecisionMaker, Periodic & ONAPvCPE) to apex-pdp.
- Fixed CORS issue in plugin-event-carrier-restserver module.
Added a ContainerResponseFilter to intercept every request/response coming to
REST server and add the required headers to support CORS.
Change-Id: Ic3e36c683f2a78992ce1417d2c00233b34066f2f
Issue-ID: POLICY-861
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
liamfallon [Tue, 24 Jul 2018 13:23:37 +0000 (14:23 +0100)]
Fix bug in APEX parameter service
The parameter calss name was not initialized in the constructor
of the parameter service
The web socket connections() method is depricated and replaced by getConnections()
Fixed order of build in main pom to put packages module last
fixed some comments that were incorrect
Change-Id: I6340655100655e181e2d97fe39def4874873dff5
Issue-ID: POLICY-954
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
ramverma [Fri, 20 Jul 2018 15:52:38 +0000 (16:52 +0100)]
Fix sonar bugs and vulnerabilities in apex-pdp
Change-Id: I7ecabd3705de4a5352d5a98d1ab3a01677172651
Issue-ID: POLICY-954
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
ramverma [Thu, 19 Jul 2018 17:45:16 +0000 (18:45 +0100)]
Adding examples module to apex-pdp
Adding examples (MyFirstPolicy, AADM, Adaptive, PCVS) to apex-pdp
so that anyone can try out running few sample policies
and understand how to create and run policies in apex-pdp.
Change-Id: I0dff6d54ef94d8b5bdb63eabcb09e9f64d76fd0c
Issue-ID: POLICY-861
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
Jorge Hernandez [Thu, 19 Jul 2018 14:08:50 +0000 (14:08 +0000)]
Merge "Fix security vulnerability, upgrad jquery version"
Jorge Hernandez [Thu, 19 Jul 2018 14:02:15 +0000 (14:02 +0000)]
Merge "Fix apex-pdp packaging issue"
liamfallon [Wed, 18 Jul 2018 16:21:39 +0000 (17:21 +0100)]
Fix security vulnerability, upgrad jquery version
The version of jquery used in the APEX client was old
and had a security vulnerability. THis review updates the
versino of jquery to a newere version that does not have
a vulnerability.
Issue-ID: POLICY-905
Change-Id: Iefa5202ca80ba03d3a6ab84a693fa8d3da21c536
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
ramverma [Wed, 18 Jul 2018 15:28:07 +0000 (16:28 +0100)]
Fix apex-pdp packaging issue
Fix apex-pdp packaging issue and add SampleDomain examples to try out
how apex-pdp works.
Change-Id: I4018b0902d06345e86ddbef80100e63232cee49d
Issue-ID: POLICY-861
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
waqas.ikram [Tue, 17 Jul 2018 14:35:47 +0000 (15:35 +0100)]
Refactoring Metrics test
Change-Id: I99290a3dec61b3ce0f4d5fd33d6b429d091b48ca
Issue-ID: POLICY-954
Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
Jorge Hernandez [Wed, 18 Jul 2018 15:02:13 +0000 (15:02 +0000)]
Merge "Fix incorrect naming on context plugins"
liamfallon [Wed, 18 Jul 2018 10:23:20 +0000 (11:23 +0100)]
Fix incorrect naming on context plugins
This change fixes inconsistent naming on the context plugins
in APEX. All plugins should fillow the naming convention of
plugin-A.plugin-A.B.plugin.A.B.C and so on. Not following
this convention breaks the APEX documentation build.
Issue-ID: POLICY-954
Change-Id: I8aad4a28d143427e60017eaa119ee4f7ce9f5b3d
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Tue, 17 Jul 2018 13:57:24 +0000 (13:57 +0000)]
Merge "Set user in Dockerfile to apexuser"
Jorge Hernandez [Tue, 17 Jul 2018 13:56:14 +0000 (13:56 +0000)]
Merge "Refactor persistence JPA testing"
mmis [Mon, 16 Jul 2018 23:30:34 +0000 (00:30 +0100)]
Set user in Dockerfile to apexuser
Set the user in Dockerfile to apexuser so as the user will be set to
apexuser upon container starts up. Only apexuser is permitted to start
apex.
Issue-ID: POLICY-866
Change-Id: Ib9e29503d8fc252760df6385a78f353e8961c3d2
Signed-off-by: mmis <michael.morris@ericsson.com>
ramverma [Mon, 16 Jul 2018 14:23:45 +0000 (15:23 +0100)]
Adding tools module to apex-pdp
The tools module contains the utility applications for apex
like converting policy model to cli, generating json events from policy
model, simple websocket client example etc.
The tools are defined to work in console and hence contain sysouts which
are actually needed.
Change-Id: Ia6d40fa7d3f6609ef86abd91a438d6ccbcd1f277
Issue-ID: POLICY-863
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
Dinh Danh Le [Sun, 15 Jul 2018 01:52:33 +0000 (02:52 +0100)]
Refactor persistence JPA testing
Adding tests for EclipseLink and refactoring Hibernate testcases.
As both tests use the same test entities, the two existing test entity
classes from org.onap.policy.apex.plugins.persistence.jpa.hibernate
are moved to a newly created package
org.onap.policy.apex.context.test.entities under context-test-utils.
Relevent POM files are changed w.r.t this change. In particular,
1) add version infos as properties in apex-pdp/pom.xml
2) common dependencies related to Junit testing for EclipseLink and
Hibernate are moved to their parent plugins-persistence-jpa's POM.
Change-Id: I9d9387154cbfdfc69be49960b80e040b6fd35b5a
Signed-off-by: Dinh Danh Le <dinh.danh.le@ericsson.com>
Issue-ID: POLICY-862
ramverma [Sat, 14 Jul 2018 18:05:57 +0000 (19:05 +0100)]
Adding client full module to apex-pdp
Change-Id: Id6e4e37b7740eeb3d83998e596c0c963c93e64f2
Issue-ID: POLICY-864
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
ramverma [Fri, 13 Jul 2018 11:32:32 +0000 (12:32 +0100)]
Adding client editor module to apex-pdp
The size of the review is big because of following:
1. edit_area & jquery are 3PP's used in the client editor
2. ui elements like svg, gifs, png
Change-Id: Ib62d8e6dda6e6dc1b6e604298e23505523f77cf2
Issue-ID: POLICY-864
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
Jorge Hernandez [Fri, 13 Jul 2018 14:02:26 +0000 (14:02 +0000)]
Merge "Adding Benchmark module"
Jorge Hernandez [Fri, 13 Jul 2018 14:01:05 +0000 (14:01 +0000)]
Merge "Adding client deployment module to apex-pdp"
Code Review / policy / apex-pdp.git / log