Timoney, Dan (dt5972) [Wed, 28 Mar 2018 23:01:21 +0000 (19:01 -0400)]
Update versions to resolve security issues
Update versions of sdc distribution client and jackson to address
security issues.
Issue-ID: CCSDK-164
Change-Id: Id02d879e87bb1a957968482578818928b6e3c281
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
Dan Timoney [Wed, 28 Mar 2018 18:09:37 +0000 (18:09 +0000)]
Merge "Add Aai event listener"
Jeremy Wolf [Wed, 28 Mar 2018 17:22:09 +0000 (17:22 +0000)]
coverage sli-northbound
adding junit test files for AsdcApiSliClient, AsdcApiUtil, DataChangeClient, SdncFlatJsonDmaapConsumer, SdncARModel, SdncNodeModel, SdncVFCModel, SdncVFModuleModel, SdncUebCallback
Change-Id: Ia7fb307b84957292f9080654c7ae31992434317f
Issue-ID: CCSDK-230
Signed-off-by: Jeremy Wolf <jw720x@us.att.com>
Serban Popescu [Wed, 28 Mar 2018 16:43:24 +0000 (16:43 +0000)]
Add Aai event listener
Add support for Aai and Pserver incoming messages from Dmaap
Change-Id: Ie799cb57f5c00eed70c9f6fd30825f907962a094
Issue-ID: CCSDK-226
Signed-off-by: Serban Popescu <sp5226@att.com>
Serban Popescu [Wed, 28 Mar 2018 15:11:05 +0000 (15:11 +0000)]
Add Aai event listener
Add support for Aai generic-vnf incoming messages from Dmaap
Change-Id: I6dcb3d935afdfee5a6e71398cfb2381265dfee92
Issue-ID: CCSDK-226
Signed-off-by: Serban Popescu <sp5226@att.com>
Dan Timoney [Wed, 28 Mar 2018 14:27:23 +0000 (14:27 +0000)]
Merge "coverage SdncAaiDmaapConsumer"
Dan Timoney [Wed, 28 Mar 2018 14:10:52 +0000 (14:10 +0000)]
Merge "Add Aai event listener"
shashikanth.vh [Wed, 28 Mar 2018 12:02:01 +0000 (17:32 +0530)]
coverage SdncAaiDmaapConsumer
Coverage improvement for SdncAaiDmaapConsumer
https://jira.onap.org/browse/CCSDK-213?jql=project%20%3D%20CCSDK%20AND%20text%20~%20coverage
Issue-ID: CCSDK-213
Change-Id: Icc9af3a9f27d4bae543525b5651d1f6485ef8857
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Serban Popescu [Wed, 28 Mar 2018 13:32:44 +0000 (13:32 +0000)]
Add Aai event listener
Add support for Aai and Pserver incoming messages from Dmaap
Change-Id: I6ace2395476a1410ea3b7ffe0bebc1766d19e474
Issue-ID: CCSDK-223
Signed-off-by: Serban Popescu <sp5226@att.com>
shashikanth.vh [Wed, 28 Mar 2018 09:19:39 +0000 (14:49 +0530)]
coverage SdncFlatJsonDmaapConsumer
Coverage improvement for SdncFlatJsonDmaapConsumer
https://jira.onap.org/browse/CCSDK-213?jql=project%20%3D%20CCSDK%20AND%20text%20~%20coverage
Issue-ID: CCSDK-213
Change-Id: Idb08f426e1626f8aa2b12d2c53f1960474af59c2
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Dan Timoney [Tue, 27 Mar 2018 19:38:27 +0000 (19:38 +0000)]
Merge "SdncOdlConnection coverage"
Dan Timoney [Tue, 27 Mar 2018 18:59:34 +0000 (18:59 +0000)]
Merge "coverageSdncFlatJsonDmaapConsumer"
shashikanth.vh [Tue, 27 Mar 2018 13:47:33 +0000 (19:17 +0530)]
SdncOdlConnection coverage
Coverage improvement for SdncOdlConnection
https://jira.onap.org/browse/CCSDK-213?jql=project%20%3D%20CCSDK%20AND%20text%20~%20coverage
Issue-ID: CCSDK-213
Change-Id: I8045722de77e8884be485bd6f1ed2243c08d2d2b
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth.vh [Mon, 26 Mar 2018 13:54:35 +0000 (19:24 +0530)]
coverageSdncFlatJsonDmaapConsumer
Coverage improvement for SdncFlatJsonDmaapConsumer
https://jira.onap.org/browse/CCSDK-213?jql=project%20%3D%20CCSDK%20AND%20text%20~%20coverage
Issue-ID: CCSDK-213
Change-Id: I95e824c5c83b9c36ce0c475368235182e851c254
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Serban Popescu [Mon, 26 Mar 2018 13:36:17 +0000 (13:36 +0000)]
Add Aai event listener
Add support for Aai and Pserver incoming messages from Dmaap
Change-Id: I57fedcaf6668d09189f0246571e8aaf515fc3fa0
Issue-ID: CCSDK-223
Signed-off-by: Serban Popescu <sp5226@att.com>
Dan Timoney [Wed, 28 Feb 2018 15:33:10 +0000 (15:33 +0000)]
Merge "Fixed DmaapListener multiple consumer thread issue"
Dan Timoney [Thu, 22 Feb 2018 23:22:31 +0000 (17:22 -0600)]
Nitrogen port: sli/northbound
Update sli/northbound to compile for ODL Nitrogen
Change-Id: Ib14fea5dd3922175bd183afb9f3c85edaa7a2f0c
Issue-ID: CCSDK-177
Signed-off-by: Dan Timoney <dtimoney@att.com>
shashikanth.vh [Tue, 16 Jan 2018 13:23:23 +0000 (18:53 +0530)]
Fixed DmaapListener multiple consumer thread issue
DmaapListener handleSubscriptions method returns after creating
consumer thread for first subscription string, issue is fixed by
removing return.
https://jira.onap.org/browse/CCSDK-173
Issue-ID: CCSDK-173
Change-Id: I796b000b22762cda0a4f4fa929d5e2aabdcc7e8b
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
prakash.e [Tue, 9 Jan 2018 15:57:21 +0000 (21:27 +0530)]
Removed of unused parameter
*unused parameter and unused function is removed
Change-Id: Ibf0f72d2948ad27313967ecadfb54f2a2bf0060b
Issue-ID: CCSDK-151
Signed-off-by: prakash.e <prakash.e@huawei.com>
prakash.e [Tue, 9 Jan 2018 15:44:18 +0000 (21:14 +0530)]
Removal of unused variables
*Romoved unused variables and code changes for performance improvement
Change-Id: Ibe1993b750653d24379ffcc3638b71f6cefcaa6b
Issue-ID: CCSDK-151
Signed-off-by: prakash.e <prakash.e@huawei.com>
Dan Timoney [Mon, 8 Jan 2018 14:52:45 +0000 (14:52 +0000)]
Merge "Exception issue"
prakash.e [Fri, 5 Jan 2018 06:45:29 +0000 (12:15 +0530)]
Exception issue
*deployList is used before initialization which results in
NullPointer Exception.
Change-Id: I53d43d7656577368ac35db78ba27c015a2c8ac52
Issue-ID: CCSDK-170
Signed-off-by: prakash.e <prakash.e@huawei.com>
SRINIVAS V [Sat, 6 Jan 2018 17:07:33 +0000 (22:37 +0530)]
Fixed as per Java Code Conventions
*Removed the commented code of addParameter function
*Code optimized
Change-Id: Ibd711561d1f94854df464d6e94de6ef2fc8b6cd6
Issue-ID: CCSDK-151
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
SRINIVAS V [Thu, 4 Jan 2018 16:27:52 +0000 (21:57 +0530)]
Removed unused code
*Deleted commented code
Change-Id: I03ebfab9d66f2a9e51233ec6312698af7ed91584
Issue-ID: CCSDK-151
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
Dan Timoney [Thu, 4 Jan 2018 12:35:46 +0000 (12:35 +0000)]
Merge "Fixed as per Java Code Conventions"
Dan Timoney [Thu, 4 Jan 2018 12:35:31 +0000 (12:35 +0000)]
Merge "Fixed as per Java Code Conventions"
Dan Timoney [Thu, 4 Jan 2018 12:29:41 +0000 (12:29 +0000)]
Merge "Fixed as per Java Code Conventions"
Dan Timoney [Thu, 4 Jan 2018 12:28:37 +0000 (12:28 +0000)]
Merge "Fixed as per Java Code Conventions"
SRINIVAS V [Thu, 4 Jan 2018 06:17:12 +0000 (11:47 +0530)]
Fixed as per Java Code Conventions
*Changed to svcOperation rather than svc_OPERATION
Change-Id: I3e5f704368ba5d0de8af92a84e298aab5008742b
Issue-ID: CCSDK-151
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
SRINIVAS V [Thu, 4 Jan 2018 06:06:13 +0000 (11:36 +0530)]
Fixed as per Java Code Conventions
*Changed to svcOperation rather than svc_OPERATION
Change-Id: I6267aa3396b3601a3673460ca776f1e46edd4ba6
Issue-ID: CCSDK-151
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
SRINIVAS V [Fri, 29 Dec 2017 10:41:33 +0000 (16:11 +0530)]
Fixed as per Java Code Conventions
Change-Id: I0b2315c4a48b5c1c267dec10ce22ded559c98192
Issue-ID: CCSDK-151
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
prakash.e [Tue, 2 Jan 2018 07:18:58 +0000 (12:48 +0530)]
Exception issue fix
Change-Id: I75eafe5267909dc1102287ef9bc8dffdb1d5dcba
Issue-ID: CCSDK-151
Signed-off-by: prakash.e <prakash.e@huawei.com>
prakash.e [Tue, 2 Jan 2018 06:25:42 +0000 (11:55 +0530)]
Removal of unused variable
Change-Id: Idaf07c98ef0fef3923ddd7a9e185b727cb93b16f
Issue-ID: CCSDK-151
Signed-off-by: prakash.e <prakash.e@huawei.com>
SRINIVAS V [Fri, 29 Dec 2017 10:01:54 +0000 (15:31 +0530)]
Fixed as per Java Code Conventions
Change-Id: I3a6fef42ba03db226705d96382f6cd6b4cfe14e7
Issue-ID: CCSDK-151
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
SRINIVAS V [Thu, 28 Dec 2017 06:53:54 +0000 (12:23 +0530)]
Removal of useless parenthesis
Change-Id: I27289de2837414d45efcdd3f617d2b399a8f8ac6
Issue-ID: CCSDK-151
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
Dan Timoney [Thu, 21 Dec 2017 14:26:56 +0000 (14:26 +0000)]
Merge "typeCasting issue and useless assignment fix"
Dan Timoney [Thu, 21 Dec 2017 14:24:42 +0000 (14:24 +0000)]
Merge "Fixed as per Java Code Conventions"
Dan Timoney [Thu, 21 Dec 2017 14:24:19 +0000 (14:24 +0000)]
Merge "Removal of useless parenthesis"
prakash.e [Thu, 21 Dec 2017 11:22:36 +0000 (16:52 +0530)]
Removal of unused private field
Change-Id: Ie2d33f7f9dba20a4d0fdf6a33f8574e953633a69
Issue-ID: CCSDK-151
Signed-off-by: prakash.e <prakash.e@huawei.com>
prakash.e [Thu, 21 Dec 2017 10:29:52 +0000 (15:59 +0530)]
Impact on performance fix
Change-Id: I36e82265087ebce69c7f01c8e75b7c932a969d0e
Issue-ID: CCSDK-151
Signed-off-by: prakash.e <prakash.e@huawei.com>
root1 [Tue, 19 Dec 2017 13:32:44 +0000 (19:02 +0530)]
Fixed as per Java Code Conventions
Change-Id: Ib17c601ad6a2999e4396f84e18831b5f907557eb
Issue-ID: CCSDK-151
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
root1 [Tue, 19 Dec 2017 14:58:25 +0000 (20:28 +0530)]
Removal of useless parenthesis
Change-Id: I6ef27a2795e91948b996055decffc051373d6113
Issue-ID: CCSDK-151
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
prakash.e [Tue, 19 Dec 2017 13:53:28 +0000 (19:23 +0530)]
typeCasting issue and useless assignment fix
Change-Id: Iab98bdec347fc9b15afc78de1b99eab8fbff5ad1
Issue-ID: CCSDK-151
Signed-off-by: prakash.e <prakash.e@huawei.com>
Dan Timoney [Tue, 19 Dec 2017 15:29:37 +0000 (15:29 +0000)]
Merge "Removal of useless parenthesis"
root1 [Wed, 13 Dec 2017 08:54:43 +0000 (14:24 +0530)]
Fixed to improve the Maintainability of code
Issue-ID: CCSDK-151
Change-Id: If8bf17dd0e5387855ddbff9198107f334ded59c5
Signed-off-by: SRINIVAS V <srinivasa.mohan@huawei.com>
root1 [Wed, 13 Dec 2017 06:26:13 +0000 (11:56 +0530)]
Removal of useless parenthesis
Issue-ID: CCSDK-151
Change-Id: Id27a026c599803705dd0675253b212e16228000a
Signed-off-by: root1 <srinivasa.mohan@huawei.com>
Dan Timoney [Mon, 18 Dec 2017 14:57:17 +0000 (14:57 +0000)]
Merge "Removal of useless parenthesis"
Dan Timoney [Mon, 18 Dec 2017 14:55:45 +0000 (14:55 +0000)]
Merge "Removal of unused variables"
prakash.e [Thu, 14 Dec 2017 10:57:14 +0000 (16:27 +0530)]
Removal of useless parenthesis
Change-Id: Ida52e0fab68d33ef446378024441ca3af0762f70
Issue-ID: CCSDK-151
Signed-off-by: prakash.e <prakash.e@huawei.com>
prakash.e [Fri, 15 Dec 2017 13:24:34 +0000 (18:54 +0530)]
Removal of unused variables
Change-Id: I73dff3b51f1895fc0282e4d3d662bc9019a87e31
Issue-ID: CCSDK-151
Signed-off-by: prakash.e <prakash.e@huawei.com>
prakash.e [Thu, 14 Dec 2017 09:41:04 +0000 (15:11 +0530)]
Removal of unused parenthesis
Change-Id: I5050503d1993e880851fb56f6b7c3ef8ece192b6
Issue-ID: CCSDK-151
Signed-off-by: prakash.e <prakash.e@huawei.com>
ramu.n [Wed, 13 Dec 2017 13:31:16 +0000 (19:01 +0530)]
Fix dmaapClient version
Fix org.onap.dmaap.messagerouter.dmaapClinet:dmappClient.jar version
Change-Id: I5bbf068b21eb3563195c55b0156f2ff401873e45
Issue-ID: CCSDK-154
Signed-off-by: Ramu N <ramu.n@huawei.com>
Dan Timoney [Tue, 21 Nov 2017 20:33:09 +0000 (15:33 -0500)]
Fix version.properties
Reset patch version to 0 in version.properties
Change-Id: Ife38d85b4aef218a98901c7b5c7d951e11690f54
Issue-ID: CIMAN-120
Signed-off-by: Dan Timoney <dtimoney@att.com>
Jessica Wagantall [Sat, 18 Nov 2017 00:56:52 +0000 (16:56 -0800)]
Bump minor version
Bump minor version in preparation for Amsterdam
branching. (part 2)
Change-Id: If8259634fe96f9a78cf59a9346dd051cc674e6c3
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Jessica Wagantall [Fri, 17 Nov 2017 07:51:48 +0000 (23:51 -0800)]
Bump minor version
Bump minor version in preparation for Amsterdam
branching.
Change-Id: I3d8c31a414a0539e2e59cb103f3395b863e7c18a
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Rich Bennett [Wed, 15 Nov 2017 11:55:41 +0000 (06:55 -0500)]
Rm docs in repo consolidated w/ ccsdk/distribution
Change-Id: I6d02b60651b48ff279be7b7207cd422207c5481f
Issue-ID: DOC-130
Signed-off-by: Rich Bennett <rb2745@att.com>
lalena.aria [Tue, 14 Nov 2017 19:04:51 +0000 (19:04 +0000)]
Update CCSDK northbound ueb-listener
Changes made:
Corrected extraction locations for role, type, ecomp_generated_naming and naming_policy in ALLOTTED_RESOURCE_MODEL.
Change-Id: I59d1625ee226e194ecba81c84ead964df6307676
Issue-ID: SDNC-194
Signed-off-by: lalena.aria <lalena.aria@att.com>
Dan Timoney [Mon, 13 Nov 2017 15:04:11 +0000 (10:04 -0500)]
Handle duplicate DHCP event
Handle case where 2 DHCP events received for same mac addr. Should use
most recent IP address.
Change-Id: I90399ce3c39e07c2472366c78115812a64e9124b
Issue-ID: CCSDK-142
Signed-off-by: Dan Timoney <dtimoney@att.com>
Brian Freeman [Sun, 12 Nov 2017 22:34:34 +0000 (22:34 +0000)]
Change dmaapClient dependency
Issue-ID: CCSDK-142
Change-Id: I5a3cd0626c71eadd414ab9939774d159638b99a6
Signed-off-by: Brian Freeman <bf1936@att.com>
Dan Timoney [Thu, 9 Nov 2017 20:18:24 +0000 (15:18 -0500)]
Add dhcp event handler
Add event handler for DHCP event
Change-Id: I2e23ace8ae481bf100f236a4e2723d721eec3470
Issue-ID: CCSDK-142
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Thu, 9 Nov 2017 12:19:49 +0000 (07:19 -0500)]
Roll to version 0.1.1-SNAPSHOT
Roll to next release version
Change-Id: I7df5f5c516db6b4459a6f6063bf754e058a4048d
Issue-ID: CCSDK-141
Signed-off-by: Dan Timoney <dtimoney@att.com>
Lalena Aria [Wed, 8 Nov 2017 16:25:41 +0000 (16:25 +0000)]
Abstract
Changes made:
update AAI Service path list from the latest version published by AAI Team
Change-Id: Ie6d5451777cfd45b528acdfe098e31f26ab3714c
Issue-ID: SDC-564
Signed-off-by: lalena.aria <lalena.aria@att.com>
Dan Timoney [Mon, 6 Nov 2017 22:19:46 +0000 (17:19 -0500)]
Ignore TOSCA YML
TOSCA is passed in 2 formats : YML and CSAR. The SDC TOSCA parser only
handles CSAR, so YML artifact cannot be passed to it. Since CSAR
artifact all data needed (that is, there is nothing in YML that SDNC
needs that is not in the CSAR), it can be safely ignored.
Change-Id: I54aa2ae49e3ba0aa23b280fa106ada3d588897a0
Issue-ID: SDNC-169
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 1 Nov 2017 17:19:42 +0000 (13:19 -0400)]
Update SDC version
Per SDC PTL, we should be using version 1.1.32 of both the
distribution client and Tosca parser.
Change-Id: Ib1a059db9e71fc98ff0c6b961577c1fa1cdaa67b
Issue-ID: SDNC-144
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 25 Oct 2017 19:37:22 +0000 (15:37 -0400)]
Use version 0.1.0 of parent
Update to use version 0.1.0 (released version) of parent pom
Change-Id: Ie639cffd028efd67d4e91765f25ba6ed29af21bc
Issue-ID: CCSDK-80
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Mon, 16 Oct 2017 18:42:00 +0000 (14:42 -0400)]
Fix ueb-listener client name
Fix package name of ueb listener client in jar manifest
Change-Id: I1db2acd8b269ffbf88d41f827c3baaa22b253bd7
Issue-ID: SDNC-129
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Fri, 13 Oct 2017 19:51:22 +0000 (15:51 -0400)]
Fix sli/northbound blueprint
Wrong package name is used for NotificationPublishService in blueprint,
resulting in asdcApi and dataChange not being loaded properly.
Change-Id: I144f8e4bd48e547e7c7241e9ebaacf744d808022
Issue-ID: CCSDK-119
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Thu, 12 Oct 2017 15:03:55 +0000 (15:03 +0000)]
Merge "Add readthedocs documentation for sli/northbound"
Dan Timoney [Thu, 12 Oct 2017 13:04:22 +0000 (09:04 -0400)]
Add readthedocs documentation for sli/northbound
Add readthedocs documentation for sli/northbound.
Change-Id: I8ca9d7e839408094ab3754500d71fe7463f0b0e4
Issue-ID: CCSDK-107
Signed-off-by: Dan Timoney <dtimoney@att.com>
surya-huawei [Thu, 12 Oct 2017 06:47:55 +0000 (12:17 +0530)]
Remove IOException in method declaration
*This is done because IOException cannot be thrown
from the method and is hence superflous
Issue-Id: CCSDK-117
Change-Id: I0712cfbf610f815e76ed33b0039ecb5e3cc7bbbe
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Mon, 9 Oct 2017 14:02:22 +0000 (10:02 -0400)]
Add retry to ueb-listener
Added retry mechanism to ueb-listener to handle case where
ueb-listener comes up before DMaap or SDC.
Change-Id: I0d96bd1fe4d3d0fdb5e01d9f42304b54bea0a550
Issue-ID: CCSDK-112
Signed-off-by: Dan Timoney <dtimoney@att.com>
surya-huawei [Thu, 5 Oct 2017 10:19:13 +0000 (15:49 +0530)]
Add a test for DummyDmaapConsumer
*Add a unit test in sli/northbound module
This is to improve code coverage of DummyDmaapConsumer class
Issue-Id: CCSDK-106
Change-Id: Iecd4970a0cd82c94a219b1a2e861fcc3da11f23c
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Thu, 5 Oct 2017 09:50:33 +0000 (15:20 +0530)]
Add a test for SdncJsonDmaapConsumer
*Add a unit test in sli/northbound module
This Test checks whether an InvalidMessageException is
thrown when null is passed to processMsg method
Issue-Id: CCSDK-106
Change-Id: I52327377f4582d8c24cef87f0360b977f2f216fc
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Wed, 4 Oct 2017 20:58:38 +0000 (16:58 -0400)]
Test TOSCA table insertion
Add code to create TOSCA tables in test driver to test TOSCA table
insertion in ueb-listener TOSCA parser test.
Change-Id: Ib8c3fcdb25fbdba39b4700553d8c01b684efa384
Issue-ID: CCSDK-102
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 4 Oct 2017 00:34:31 +0000 (20:34 -0400)]
Improve ueb-listener tests
Use Maria4JDB to improve test coverage of ueb-listener.
Change-Id: Ifb88916434bb1b293b4bbd6fae069cd1e88c9d8d
Issue-ID: CCSDK-106
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 4 Oct 2017 00:04:32 +0000 (20:04 -0400)]
Add ueb-listener test case
Add test case for license-model parsing in ueb-listener.
Change-Id: I279e269f7ba3c6f37c09f71b99b20d4e9e661e23
Issue-ID: CCSDK-106
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 3 Oct 2017 20:15:20 +0000 (20:15 +0000)]
Merge "Improve SDNC coverage"
Dan Timoney [Tue, 3 Oct 2017 18:30:51 +0000 (14:30 -0400)]
Add ueb-listener unit test
Enhance ueb-listener unit test to verify TOSCA parse
Change-Id: Iedc675ead3ef69e4fa7151c8c4c500990c0ee6a7
Issue-ID: CCSDK-106
Signed-off-by: Dan Timoney <dtimoney@att.com>
shashikanth [Tue, 3 Oct 2017 11:28:51 +0000 (16:58 +0530)]
Improve SDNC coverage
Added initial test cases for dataChange.
Issue-Id: SDNC-101
Change-Id: I112a6695f4d4ca92b78884d25fef12f382598b37
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Dan Timoney [Tue, 3 Oct 2017 11:34:22 +0000 (07:34 -0400)]
Add unit test for dmaap-listener
Add unit test case for dmaap-listener.
Change-Id: I501614016c96d8300bc15cdf1819691f95c467f4
Issue-ID: CCSDK-106
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 3 Oct 2017 08:04:30 +0000 (04:04 -0400)]
Add unit test for ueb-listener
Add unit test case for ueb-listener.
Change-Id: Ia61f8e5bc0e817aa0f4a042d8e05b02ec9e2013b
Issue-ID: CCSDK-106
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Thu, 28 Sep 2017 13:02:39 +0000 (13:02 +0000)]
Merge "Improve SDNC Sonar coverage"
Dan Timoney [Thu, 28 Sep 2017 13:02:25 +0000 (13:02 +0000)]
Merge "Deleted redundant try catch block"
Brian Freeman [Thu, 28 Sep 2017 11:03:28 +0000 (11:03 +0000)]
Setup ReadTheDocs
Issue-ID: CCSDK-107
Change-Id: I98bc6f3a3827bb1f4e03eb08474b15e26662705f
Signed-off-by: Brian Freeman <bf1936@att.com>
shashikanth [Wed, 27 Sep 2017 10:13:48 +0000 (15:43 +0530)]
Improve SDNC Sonar coverage
Added initial test cases for ASDC-APIs
Issue-Id: SDNC-101
Change-Id: Iad8be979e39099e4ece8210dbd5d2c9c64b60990
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Tue, 26 Sep 2017 09:26:41 +0000 (14:56 +0530)]
Deleted redundant try catch block
Extract this nested try block into a separate method.
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.northbound%3Accsdk-sli-northbound#resolved=false|severities=MAJOR|rules=squid%3AS1141
Issue-Id: CCSDK-87
Change-Id: I989791d876b5a199f75983ba5137770f80995ef1
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
surya-huawei [Mon, 25 Sep 2017 12:01:57 +0000 (17:31 +0530)]
Fix some sonar issues in sli/northbound
*Replace type specification with diamond operator
This is done to reduce the verbosity of generics code
*Replace ("") with ('') in String.lastIndexOf()
This is more efficient for single character
*Remove temp variable which is immediately returned
New variable is not necessary as the caller cannot see this
Issue-Id: CCSDK-87
Change-Id: I353652de723a624935d819b2bc817b4907af98ed
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Fri, 22 Sep 2017 19:46:40 +0000 (19:46 +0000)]
Merge "Fix sli dependency"
surya-huawei [Fri, 22 Sep 2017 11:20:44 +0000 (16:50 +0530)]
Remove unnecessary constructs
*Remove unused imports
*Remove useless paranthesis
This is done as sometimes they can be misleading
*Replace type specification with diamond operator(<>)
This is done to reduce verbosity of generics code
Issue-Id: CCSDK-87
Change-Id: Ic356859939fe40cecec2e65c96d79cd6a655787e
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Bharat saraswal [Thu, 21 Sep 2017 12:55:09 +0000 (18:25 +0530)]
Resolved below sonar issues.
Method complextity.
Redudant code and varibales.
Exception handling.
Refacting of code.
Issue-Id:CCSDK-87
Change-Id: I757c6a6d3c403f81f725ad97a7759225d0709468
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
surya-huawei [Thu, 21 Sep 2017 10:25:14 +0000 (15:55 +0530)]
Use Integer.toString for type conversion
*Used Integer.toString instead of implicit type conversion
This is done to make use of static and reduce cycles
*Removed one unused import
*Removed unnecessary parantheses
Sometimes useless parantheses can be misleading hence removed
Issue-Id: CCSDK-87
Change-Id: I23f56cb7c5a6dafa79f64d5cd8faa0994f0ff288
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Wed, 20 Sep 2017 20:01:37 +0000 (20:01 +0000)]
Merge "Some minor refinements in CCSDK SLI Northbound"
ramu.n [Wed, 20 Sep 2017 11:44:38 +0000 (17:14 +0530)]
Some minor refinements in CCSDK SLI Northbound
Fix few Critical/Major sonar issues in CCSDK SLI Northbound module
* Remove useless parentheses
* Remove useless assignment to local variable
* Use built-in logger method string formatting instead of string concatination
* code indentation
* Replace for loop with foreach
Change-Id: I9a2e3345f23feb2d96045ac714d8acc528de464b
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
surya-huawei [Wed, 20 Sep 2017 10:48:41 +0000 (16:18 +0530)]
Remove useless assigment to local variables
*Removed dead stores
This is done to avoid waste of resources
Issue-Id: CCSDK-87
Change-Id: Ie36255c6583792e2535000ee1bd5b2a3018632ff
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Tue, 19 Sep 2017 23:52:47 +0000 (23:52 +0000)]
Merge "Fix critical sonar issues"
Brian Freeman [Tue, 19 Sep 2017 16:49:28 +0000 (16:49 +0000)]
Fix sli dependency
Issue-ID: SDNC-86
Change-Id: I91280ab218e2f1f25ab381eaa9f94dce8f2abdc9
Signed-off-by: Brian Freeman <bf1936@att.com>
Gaurav Agrawal [Tue, 19 Sep 2017 13:36:33 +0000 (19:06 +0530)]
Fix critical sonar issues
Fix critical sonar issues in CCSDK SLI Northbound by either logging or
rethrowing the exception
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.northbound%3Accsdk-sli-northbound#resolved=false|severities=CRITICAL
Change-Id: I718f13b5801ea9d69b5c36f75b5387a0ae59cc6a
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
surya-huawei [Tue, 19 Sep 2017 10:02:16 +0000 (15:32 +0530)]
Fix Sonar Issues
few major issues in sli/northbound
*Remove unused imports
*Iterate over the "entrySet" instead of the "keySet"
*Replace the type specification with the diamond operator ("<>")
Issue-Id: CCSDK-87
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Change-Id: Ib2a6f97d3de759b937c1e2acd2e39312e88ad10b
Dan Timoney [Mon, 18 Sep 2017 20:02:55 +0000 (20:02 +0000)]
Merge "Replace deprecated APIs with newer one"
Gaurav Agrawal [Mon, 18 Sep 2017 13:07:49 +0000 (18:37 +0530)]
Replace deprecated API with newer one
Replace following deprecated API
1) NotificationProviderService replaced with NotificationPublishService
2) InstanceIdentifier<T> toInstance() replace with build()
Change-Id: I50195bf123052270edf3fd9f74af00262a01e650
Issue-Id: CCSDK-93
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Code Review / ccsdk / sli / northbound.git / log