mojahidi [Wed, 27 Dec 2017 07:31:30 +0000 (13:01 +0530)]
Fixed sonar issues - CSARConstants
Fixed all sonar issues
Change-Id: Ia0db69f41abe5557faf1e845590ba98f667bea1e
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 05:50:50 +0000 (11:20 +0530)]
Fixed sonar issues - OnboardingMethodErrorBuilder
Fixed all sonar issues
Change-Id: Iec00a6d2b8028861fdab6e34e17d421fe3de1334
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 05:45:13 +0000 (11:15 +0530)]
Fixed sonar issues - ImageErrorBuilder
Fixed all sonar issues
Change-Id: I1a4f289524425999f019817cbc8df060d83e252b
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 06:49:03 +0000 (12:19 +0530)]
Fix sonar issues - ResourceWalker
Code refactor and Javadoc
Change-Id: Ic14f3fe0cc8e1903ec3ec73b9a6b63a694e0db81
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 09:35:52 +0000 (15:05 +0530)]
Fixing sonar qube issues
Added Override annotation to method and removed runtime exception from method specification.
Change-Id: I12640d880c262fc301cafe8ede228e2a4772af88
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 09:21:38 +0000 (14:51 +0530)]
Fixing sonar qube issues
Fixed critical , major , minor issues in DefaultOutput class. Updated license header.
Change-Id: Ie79498108433c5cc16a3adb04c6f6072724d381d
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 09:12:51 +0000 (14:42 +0530)]
Sonar fixes for module - Configuration mgmt api
1. Fixed major sonar violations configuration management api module
Change-Id: I83863213e35cf092ffd1c1ff84f408318d5ce8e9
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
Michael Lando [Wed, 27 Dec 2017 08:20:55 +0000 (10:20 +0200)]
sonar plug in test
Change-Id: I22f2680267edf4dabe21dd6736fa71f88000628c
Issue-ID: SDC-776
Signed-off-by: Michael Lando <ml636r@att.com>
shrek2000 [Wed, 27 Dec 2017 08:10:56 +0000 (10:10 +0200)]
Avoid Null Pointer
Change-Id: Ie6f78934a1c6407a05bd988fb234bf5662fb26e8
Issue-ID: SDC-799
Signed-off-by: shrek2000 <orenkle@amdocs.com>
Idan Amit [Tue, 26 Dec 2017 16:01:01 +0000 (18:01 +0200)]
Fix documentation offered APIs
Replace the Read the Docs offered APIs to show the correct swagger.json data
Change-Id: Ife2fddca2646a169d538ded5d84f0afbec104184
Issue-ID: SDC-754
Signed-off-by: Idan Amit <ia096e@intl.att.com>
mojahidi [Wed, 27 Dec 2017 05:56:38 +0000 (11:26 +0530)]
Fixed sonar issues -NicInternalNetworkErrorBuilder
Fixed all sonar issues
Change-Id: I206a6529b85c501f06747178ff0571b7547428ad
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shrek2000 [Wed, 27 Dec 2017 07:40:11 +0000 (09:40 +0200)]
Avoid Null Pointer
Change-Id: I91eb26e842495271017d0c918bdae81d03c192f2
Issue-ID: SDC-797
Signed-off-by: shrek2000 <orenkle@amdocs.com>
mojahidi [Wed, 27 Dec 2017 08:50:14 +0000 (14:20 +0530)]
Fixed sonar issues - OrchestrationTemplateFileHand
Fixed all sonar issues
Change-Id: Ieece2d0e081a918e841e8ecbaf2b6af1a5d0f3b8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 06:13:21 +0000 (11:43 +0530)]
Fix sonar issues
Modified access modifier and few refactor
Change-Id: I9386cce2dd90c411a262b3dbc0b95525dd1362c5
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Wed, 27 Dec 2017 07:28:58 +0000 (12:58 +0530)]
Fixed sonar issues - OnboardingManifest
Fixed all sonar issues
Change-Id: I7f07c7dba6713e76b24ad5bb4bf994a867769edc
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 05:53:59 +0000 (11:23 +0530)]
Fixed sonar issues - DeploymentFlavorErrorBuilder
Fixed all sonar issues
Change-Id: I528de8e970f40b03af183f499bd9ff61792c174a
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
talio [Wed, 27 Dec 2017 08:40:47 +0000 (10:40 +0200)]
fix TOSCA structure tree
when uploading a csar with two different directories that share the same name, the files structure that appears on the validation screen shows all of the files written under the same directory. this issue got fixed
Change-Id: I6da7399271fa1cde384f6feb51d60724584aa8f9
Issue-ID: SDC-535
Signed-off-by: talio <tali.orenbach@amdocs.com>
ojasdubey [Wed, 13 Dec 2017 10:53:43 +0000 (16:23 +0530)]
Simplified the return condition
Note: Sonar violations will be handled as a separate
task
Change-Id: I862247f5c693f4d64dff4ce18f2f71e42c85355a
Issue-ID: SDC-749
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
shrek2000 [Wed, 27 Dec 2017 08:32:14 +0000 (10:32 +0200)]
add private constructor
Change-Id: I89c40a4e566fcc00de2b3e9b49def9b04c366d24
Issue-ID: SDC-793
Signed-off-by: shrek2000 <orenkle@amdocs.com>
mojahidi [Wed, 27 Dec 2017 06:34:55 +0000 (12:04 +0530)]
Fixed sonar issues - NicManagerImpl
Fixed all sonar issues
Change-Id: Ic56ea70826845f94a3a8d83193fc75f1179bb62b
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Michael Lando [Tue, 26 Dec 2017 17:14:02 +0000 (19:14 +0200)]
sonar plug in fix
Change-Id: Ib8fdef1f537b93494402aece3e145ff716363b68
Issue-ID: SDC-776
Signed-off-by: Michael Lando <ml636r@att.com>
mojahidi [Tue, 26 Dec 2017 14:44:32 +0000 (20:14 +0530)]
Fixed sonar issues - ComputeErrorBuilder
Fixed all sonar issues
Change-Id: If38e9ec81c72da6a96e9d0c12312416b239c2d02
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Tue, 26 Dec 2017 14:40:02 +0000 (20:10 +0530)]
Fixed sonar issues - ComponentDependencyModel
Fixed all sonar issues
Change-Id: I4469b63b6a2291a7780e591edda36827c7bf51a1
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Tue, 26 Dec 2017 14:46:50 +0000 (20:16 +0530)]
Fixed sonar issues - DeleteNicErrorBuilder
Fixed all sonar issues
Change-Id: I5a71e83bce19bff06f6d9d7609c3b959abcda066
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Tue, 26 Dec 2017 09:22:15 +0000 (14:52 +0530)]
Fix sonar issues
Argument name change and no-op comment
Change-Id: I3087310fe8dfedadbeac8408051fded0225838f2
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Tue, 26 Dec 2017 07:20:48 +0000 (12:50 +0530)]
Fixed sonar issues - VendorLicenseManagerImpl
Refactored as per given comment
Change-Id: I92ec3c5a0152a625c1cad33ef2a92292b10977b2
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Tue, 26 Dec 2017 09:11:57 +0000 (14:41 +0530)]
Fix sonar issues
Code correction as per suggestion
Change-Id: Ia7772c1f257b90fc38ff4b12ee71b37354f7606b
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Tue, 26 Dec 2017 07:09:34 +0000 (12:39 +0530)]
Fixed sonar issues - NovaServerGuideLineValidator
Fixed all sonar issues
Change-Id: I5152c860c925ce0532d1b5053a3738d82e1bfafe
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Tue, 26 Dec 2017 13:44:23 +0000 (19:14 +0530)]
Fix sonar issues
Removed commented code, and refactor
Change-Id: I3cb107ab3931e323dd11c32c8285f871e5082531
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:34:17 +0000 (17:04 +0530)]
Fixed sonar issues - HeatResourceValidator
Done refactoring as per given comment
Change-Id: Id1cd659af6ddd9e24d281a1bb0d1ae9431bcaf98
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
ojasdubey [Wed, 13 Dec 2017 09:52:01 +0000 (15:22 +0530)]
Update Global Types for TOSCA Import
Migrated ONAP specific types to a new folder
Change-Id: I992a12ac4913c6df5ad616b8d32ecdd706682102
Issue-ID: SDC-749
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
sheetalm [Tue, 26 Dec 2017 07:59:08 +0000 (13:29 +0530)]
Fixed sonar issues - ToscaNodeType
Adding private constructor. Making constant final. Corrected copyright
Change-Id: I025aaddbae4133a2bd0b4bba450726a166ebeb1a
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
mojahidi [Tue, 26 Dec 2017 07:13:36 +0000 (12:43 +0530)]
Fixed sonar issues - LimitErrorBuilder
Fixed all sonar issues
Change-Id: I6243f40a4bf400f834166f813154455cae9b7ab1
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
talig [Tue, 26 Dec 2017 07:22:12 +0000 (09:22 +0200)]
Add Item Manager and Dao impl unit tests
Change-Id: I30df90a7ca543195d286f322e8bfa52ffabca849
Issue-ID: SDC-779
Signed-off-by: talig <talig@amdocs.com>
siddharth0905 [Tue, 26 Dec 2017 07:07:18 +0000 (12:37 +0530)]
Fix sonar issues
Added static inner class for initializing system prop
Change-Id: I63c23640058a68c7f8d228a2a509d1b440fd20e6
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Tue, 26 Dec 2017 06:40:29 +0000 (12:10 +0530)]
Fixed sonar issues - ContrailServiceTemplate
Fixed all sonar issues
Change-Id: I2ecf439dac9e180fd1640c53abb0e15991434704
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Tue, 26 Dec 2017 06:43:02 +0000 (12:13 +0530)]
Fixed sonar issues - NeutronPortNamingConvention
Fixed all sonar issues
Change-Id: Ibc328c6e7d7d6e71837107d34dc24731735db9d6
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Tue, 26 Dec 2017 06:31:11 +0000 (12:01 +0530)]
Fixed sonar issues - ContrailServiceInstance
Fixed all sonar issues
Change-Id: Ia1f1f73dd5c0d7f6151b9cab91a3bcb11bd787ed
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
sheetalm [Tue, 26 Dec 2017 05:41:31 +0000 (11:11 +0530)]
Fixed sonar issues - ToscaExtensionYamlUtil
Introduced new variable instead of using parameter. Added Copyright
Change-Id: I8f7ff38c987acb1d6919c95e4a430df29927c1f9
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
sheetalm [Tue, 26 Dec 2017 05:29:42 +0000 (10:59 +0530)]
Fixed sonar issues - FileDataStructureHealer
Remove no arg constructor and unwanted logger. Corrected Copyright
Change-Id: I3417663d57eefe21051ac033415f3364e90351a3
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
sheetalm [Tue, 26 Dec 2017 05:15:35 +0000 (10:45 +0530)]
Fixed sonar issues - Healer
Add functional interface annotation. Corrected Copyright
Change-Id: Ia271a0c335756c8d4369d6921d43c9b9282bd412
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
Michael Lando [Mon, 25 Dec 2017 19:12:47 +0000 (21:12 +0200)]
fix licensing issues
in the project we are required to have a license text in the root dir.
we have it there and it references both AT&T and Amdocs.
other license were removed and and the text in the package json changed to onap.
Change-Id: I1584d3c56df3287d02f899d45f18ddc3f32d082c
Issue-ID: SDC-737
Signed-off-by: Michael Lando <ml636r@att.com>
Tal Gitelman [Sun, 24 Dec 2017 19:22:51 +0000 (21:22 +0200)]
fix VM grouping
ignoring fixed_ips value when consolidating VMs
Issue-ID: SDC-774
Change-Id: Icdd88af94ff0609f6efabf69b00ed09836270fff
Signed-off-by: talio <tali.orenbach@amdocs.com>
Michael Lando [Mon, 25 Dec 2017 18:07:37 +0000 (20:07 +0200)]
fix pom
Change-Id: I159f5de10d16d018d63c020115a5231716826c99
Issue-ID: SDC-777
Signed-off-by: Michael Lando <ml636r@att.com>
Yuli Shlosberg [Mon, 18 Dec 2017 13:06:12 +0000 (15:06 +0200)]
Kibana and import normative API fix
Change-Id: Ic365ed2122dc16f35b54a064166f4774650c9029
Issue-ID: SDC-265
Signed-off-by: Yuli Shlosberg <ys9693@att.com>
talig [Mon, 25 Dec 2017 13:05:31 +0000 (15:05 +0200)]
Refactor list revisions api
Remove zusammen-api dependency in versioning-api, enhance version zusammen dao impl UT.
Issue-ID: SDC-779
Change-Id: Ic792462eac52f1f5129f92ce80d3deb641c90916
Signed-off-by: talig <talig@amdocs.com>
shrek2000 [Sun, 24 Dec 2017 06:55:14 +0000 (08:55 +0200)]
Import Export Tool add executors
Issue-ID: SDC-773
Change-Id: Id203b671e9af0b3478b75032111b73a509a9a5df
Signed-off-by: shrek2000 <orenkle@amdocs.com>
Tal Gitelman [Sun, 24 Dec 2017 19:22:51 +0000 (21:22 +0200)]
Align configuration files after 1802E sync
Change-Id: Ic25c0d6db92d82d52d9784ee8ec7065a710942ca
Issue-ID: SDC-764
Signed-off-by: Tal Gitelman <tg851x@intl.att.com>
Michael Lando [Sun, 24 Dec 2017 18:23:35 +0000 (20:23 +0200)]
soner enable fix
Change-Id: Ibcc38fd80f2cd3470db461fcc434760925a93a9b
Issue-ID: SDC-777
Signed-off-by: Michael Lando <ml636r@att.com>
siddharth0905 [Wed, 13 Dec 2017 12:06:42 +0000 (17:36 +0530)]
Fix sonar issues
Rearranged the code
Change-Id: Ic08659d8c56aec1a001a2e3e1de2f8e200a10a4e
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Fri, 22 Dec 2017 05:26:49 +0000 (10:56 +0530)]
Fixed sonar issues - NovaServerGroupResourceValid
Fixed all sonar issues
Change-Id: I4eb6f2923e9b2605e048d4b8ad720bf8bd05c6c9
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Fri, 22 Dec 2017 05:33:21 +0000 (11:03 +0530)]
Fixed sonar issues - NovaServerResourceValidator
Fixed all sonar issues
Change-Id: I4ee3a6fdc33a3874ce36d32296ab508ee7089468
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Fri, 22 Dec 2017 05:24:34 +0000 (10:54 +0530)]
Fixed sonar issues - NeutronPortResourceValidator
Fixed all sonar issues
Change-Id: I15953126b263c5746551f024f5ff34ae5848eba8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:53:49 +0000 (17:23 +0530)]
Fixed sonar issues - SharedResourceGuideLineVal
Removed unused method parameters
Used isEmpty() to check whether the collection is empty or not
Change-Id: Id812b2fd4d9b16b399eb9edc0f41e5e0c5d54211
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 13 Dec 2017 12:00:36 +0000 (17:30 +0530)]
Fixed sonar issues - YamlValidator
Removed unused logger
Removed useless parentheses
Change-Id: Ia804c7c461690172f67d610df0bfa46c17525ae8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:41:11 +0000 (17:11 +0530)]
Fixed sonar issues - HeatValidator
Refactored code to not nest more than 3 if/for/while/switch/try statements
and fixed other sonar violations
Change-Id: I0bcef3c45a894c9e1da9a16ad82b6f5140c789ce
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:23:52 +0000 (16:53 +0530)]
Fixed sonar issues - YamlValidatorUtil
Added private constructor to hide the implicit public one
Change-Id: Iaedd9c5fe8f55025af6b26a41837da2c6e75a5fc
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:29:11 +0000 (16:59 +0530)]
Fixed sonar issues - ForbiddenResourceGuideLineVal
Added license, removed Removed unnecessary cast to Logger
Change-Id: Icf1cac7841e26224573820addd85f3497ee5ae3d
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:17:59 +0000 (16:47 +0530)]
Fixed sonar issues - ContrailValidator
Removed unnecessary cast to Logger
Removed unused method parameters
Change-Id: I766e6333f8309b83d0725c1c6d25109fb81d47f7
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
sheetalm [Wed, 13 Dec 2017 11:15:34 +0000 (16:45 +0530)]
Fixed sonar issues - ServiceTemplateEntity
Add override annotations to methods. Remove no arg default constructor
Corrected Copyright. Not fixing duplicate code violation since same
code block exists but for different entities
Change-Id: Ib776e280fb7e67100ac75f3312ad0c19dc709d46
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:49:34 +0000 (17:19 +0530)]
Fixed sonar issues - ManifestValidator
Removed unnecessary cast to Logger
Moved private methods into ManifestScanner
Change-Id: I40e581ec03a5400b8728057d766317615299b3e8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
talig [Wed, 20 Dec 2017 12:30:43 +0000 (14:30 +0200)]
Add collaboration feature
Issue-ID: SDC-767
Change-Id: I14fb4c1f54086ed03a56a7ff7fab9ecd40381795
Signed-off-by: talig <talig@amdocs.com>
Michael Lando [Thu, 21 Dec 2017 08:22:39 +0000 (10:22 +0200)]
fix incorrect dependency
Change-Id: Ie90efc5a9d1264d1d8d0f7048233be4f859bea23
Issue-ID: SDC-762
Signed-off-by: Michael Lando <ml636r@att.com>
Tal Gitelman [Sun, 17 Dec 2017 16:53:53 +0000 (18:53 +0200)]
fix jetty log system out logging
Change-Id: I57129bf5854043425a7bc2d6f11f71a2a3a15cda
Issue-ID: SDC-581
Signed-off-by: Tal Gitelman <tg851x@intl.att.com>
Tal Gitelman [Sun, 17 Dec 2017 10:33:39 +0000 (12:33 +0200)]
fix jetty log system out logging
Change-Id: I1602c768b0bea7599df518622c440dd6cf825719
Issue-ID: SDC-581
Signed-off-by: Tal Gitelman <tg851x@intl.att.com>
Tal Gitelman [Thu, 14 Dec 2017 13:05:17 +0000 (15:05 +0200)]
fix jetty log system out logging
Change-Id: I96505e1fdb29836a7b0bc4d6a8e33235a6491d4a
Issue-ID: SDC-581
Signed-off-by: Tal Gitelman <tg851x@intl.att.com>
Tal Gitelman [Mon, 27 Nov 2017 13:44:36 +0000 (15:44 +0200)]
Fix swagger.json errors
Issue-ID: SDC-534
catalog-be/src/main/java/org/openecomp/sdc/be/externalapi/servlet/
ArtifactExternalServlet.java
Change-Id: I68aa03b9c8a2c255b6e58ba00dac1c79a64de7e2
Signed-off-by: Tal Gitelman <tg851x@intl.att.com>
Tal Gitelman [Thu, 14 Dec 2017 09:38:57 +0000 (11:38 +0200)]
Fix Togglez dependency BE error
Change-Id: I46bf587e31f7e0f0c8bf493991d656644642c7ab
Issue-ID: SDC-581
Signed-off-by: Tal Gitelman <tg851x@intl.att.com>
sheetalm [Wed, 13 Dec 2017 09:55:05 +0000 (15:25 +0530)]
Rearranging togglez to avoid dependency issues
Added new profile "dev-integ" which will allow togglez-console
dependency to be added. When built with default profile togglez-console
will be excluded
Change-Id: I8a918fe1ad56620d4215acb70dc126b0bc986802
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
mojahidi [Mon, 11 Dec 2017 09:54:11 +0000 (15:24 +0530)]
Adding Error code in HEAT Validators
added error code in NestedResourceValidator and ResourceGroupResourceValidator
fixed sonar issues
Change-Id: I1705b7103a3b3c42338f97cb4a7a255a6c85e88f
Issue-ID: SDC-572
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
mojahidi [Mon, 11 Dec 2017 13:38:11 +0000 (19:08 +0530)]
Fixed sonar issues - LoggerFactory
Refactored as per previous patch comment
Change-Id: Ia971105a56df62575cd3871e3488b6d2c6903d3c
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
sheetalm [Tue, 12 Dec 2017 12:34:46 +0000 (18:04 +0530)]
Fixed sonar issues - ServiceArtifactEntity
Add override annotations to methods. Remove no arg default constructor
Corrected Copyright. Not fixing duplicate code violation since same
code block exists but for different entities
Change-Id: I64a25f2fe9805774f704700cd5a345db461f152a
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
sheetalm [Tue, 12 Dec 2017 12:13:03 +0000 (17:43 +0530)]
Fixed sonar issues - EnrichedServiceTemplateEntity
Add override annotations to methods. Remove no arg default constructor
Corrected Copyright. Not fixing duplicate code violation since same
code block exists but for different entities
Change-Id: Ie718ed87dac2be84257e9cedfa20fb98857f907e
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
mojahidi [Mon, 11 Dec 2017 12:12:50 +0000 (17:42 +0530)]
Fixed sonar issues - LoggerTragetServiceName
Added private constructor to hide public one
Change-Id: I5f4f7d67513c6d4f792ad68ad986867a255356f0
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
sheetalm [Tue, 12 Dec 2017 06:45:09 +0000 (12:15 +0530)]
Fixed sonar issues - EnrichedServiceArtifactEntity
Add override annotations to methods. Remove no arg default constructor
Corrected Copyright. Not fixing duplicate code violation since same
code block exists but for different entities
Change-Id: Idb1d58396b40205cc534cec56f26a2914f58b9c3
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
ojasdubey [Tue, 12 Dec 2017 09:48:30 +0000 (15:18 +0530)]
Fix - Translator core tests stuck
Updated invalid dbhost config value to empty
based on review comments
Issue-ID: SDC-748
Change-Id: Idc691bdc7e2b988654ae87c2581ccbdd86586aae
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
sheetalm [Tue, 12 Dec 2017 04:48:53 +0000 (10:18 +0530)]
Fixed sonar issues - AbstractComponentFactory
Declaring functional interface. Removing unused code. Correct copyright
Change-Id: I749929be60eb0e87b6c4b12b30c211bf778af331
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
mojahidi [Mon, 11 Dec 2017 10:32:30 +0000 (16:02 +0530)]
Fixed sonar issues - DebugMessages
Added private constructor to hide public one
Change-Id: I0689d9a4c920a910324b0db298e325c3e87d37f6
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Mon, 11 Dec 2017 10:22:46 +0000 (15:52 +0530)]
Fixed sonar issues - DebugConstants
Added private constructor to hide public one
Change-Id: I535017906f12d69333360b1994d87e506f5bf142
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Mon, 11 Dec 2017 10:16:47 +0000 (15:46 +0530)]
Fixed sonar issues - AuditMessages
Added private constructor to hide public one
Change-Id: Icddef8c59eb1f4cc77ed6646cfb7b362d4921da1
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Mon, 11 Dec 2017 12:03:04 +0000 (17:33 +0530)]
Fixed sonar issues - LoggerConstants
Added private constructor to hide public one
Change-Id: I8958d8906d7339d8bc0c7d0188de5d397aa04c79
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Mon, 11 Dec 2017 13:44:33 +0000 (19:14 +0530)]
Fixed sonar issues - ContextPropagationService
Added FunctionalInterface annotation
Change-Id: Ia8c68be7a2154d68d0d472cd0bb757c01ad59e27
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Mon, 11 Dec 2017 12:08:55 +0000 (17:38 +0530)]
Fixed sonar issues - LoggerErrorDescription
Added private constructor to hide public one
Change-Id: I06eca13ddcd6ca4e2eae427c2fb8a12e7c603e64
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Mon, 11 Dec 2017 12:23:55 +0000 (17:53 +0530)]
Resolved all possible sonar issues
Resolved all Sonar qube issues and changes discussed with Vitaliy
Change-Id: I8e49fb3d05a6735f0f6b109525de9184b3fd5d18
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
vempo [Mon, 11 Dec 2017 09:11:05 +0000 (11:11 +0200)]
Corrected copyright header
Change-Id: Ib437d6c321c8142a72b5b8f4584d84f240b7d36c
Issue-ID: SDC-738
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
Avi Ziv [Mon, 11 Dec 2017 09:56:18 +0000 (11:56 +0200)]
Error in Jetty logs - add docs folder
Issue-ID: SDC-581
Change-Id: Ibe634463eb780491ce4000996ef6613418c5ecd9
Signed-off-by: Avi Ziv<avi.ziv@amdocs.com>
avigaffa [Mon, 11 Dec 2017 09:31:02 +0000 (11:31 +0200)]
Corrected copyright header
Change-Id: I7eb690262e5613c838d6df06d592dd0a903d8eb3
Issue-ID: SDC-738
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
vempo [Mon, 11 Dec 2017 09:11:52 +0000 (11:11 +0200)]
Corrected copyright header
Change-Id: I23f3e27b0d628288b6c21b7465a36b3fd2d407b2
Issue-ID: SDC-738
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Mon, 11 Dec 2017 09:12:07 +0000 (11:12 +0200)]
Corrected copyright header
Change-Id: I037e766fa1734186054e3658b4908498ce67dd2a
Issue-ID: SDC-738
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Mon, 11 Dec 2017 09:12:21 +0000 (11:12 +0200)]
Corrected copyright header
Change-Id: Ie294ac695538f759c4a38382c7b45dc9660d178c
Issue-ID: SDC-738
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
Tal Gitelman [Sun, 10 Dec 2017 16:55:03 +0000 (18:55 +0200)]
Final commit to master merge from
Change-Id: Ib464f9a8828437c86fe6def8af238aaf83473507
Issue-ID: SDC-714
Signed-off-by: Tal Gitelman <tg851x@intl.att.com>
Idan Amit [Sun, 10 Dec 2017 13:00:20 +0000 (15:00 +0200)]
Rename dockers from openecomp to onap
Updated the sdc-simulator docker to use the new bae jetty docker
Change-Id: I5afe31338761ce94b7527d6b85681d058680095b
Issue-ID: SDC-710
Signed-off-by: Idan Amit <ia096e@intl.att.com>
Idan Amit [Thu, 7 Dec 2017 09:33:32 +0000 (11:33 +0200)]
clean up and update docker run script
Removed unneeded code from docker run script and fixed indentation problems
Changed sdc-FE dockerfile java options to run with only 512m
Change-Id: I76239673cc0740a43854bbb0e56707c7539712be
Issue-ID: SDC-717
Signed-off-by: Idan Amit <ia096e@intl.att.com>
Idan Amit [Wed, 6 Dec 2017 15:21:38 +0000 (17:21 +0200)]
Rename dockers from openecomp to onap
Updated the name of the dockers from openecomp to onap.
Updated the docker files to use the latest version of the dockers base images
Change-Id: I5403cf4b25a032bdebcbcabef9a709e5bd9ea2b0
Issue-ID: SDC-710
Signed-off-by: Idan Amit <ia096e@intl.att.com>
noahs [Wed, 6 Dec 2017 11:11:38 +0000 (13:11 +0200)]
Duplicate logging frameworks merging
There was two copies of the SDC logging framework
Change-Id: I55c94c9817a83162c6d90e504dfd91e4858c7269
Issue-ID: SDC-703
Signed-off-by: noahs <noah.shogan@amdocs.com>
Yuli Shlosberg [Sun, 26 Nov 2017 17:05:23 +0000 (19:05 +0200)]
sync 1.1.0 to master
Change-Id: I6e040f039895dd2ced55f95824473946b226fb5d
Issue-ID: SDC-707
Signed-off-by: Yuli Shlosberg <ys9693@att.com>
Tal Gitelman [Sun, 26 Nov 2017 14:32:13 +0000 (16:32 +0200)]
Add EOL=LF attribute to .gitattribute file
Change-Id: Ice3bf953ddc7d1908d61795e23c28a007715186d
Issue-ID: SDC-672
Signed-off-by: Tal Gitelman <tg851x@intl.att.com>
mojahidi [Wed, 22 Nov 2017 13:22:02 +0000 (18:52 +0530)]
NovaServerResourceValidator
This task is about updating error messages with error codes for NovaServerResourceValidator
Change-Id: I90638b7c736b75b8cdadd440dbaafed146eec140
Issue-ID: SDC-572
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 22 Nov 2017 13:16:42 +0000 (18:46 +0530)]
NovaServerGroupResourceValidator
This task is about updating error messages with error codes for NovaServerGroupResourceValidator
Change-Id: I72efa7954e846a094268dbda4399bea9c841305d
Issue-ID: SDC-572
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 22 Nov 2017 13:07:15 +0000 (18:37 +0530)]
NeutronSecurityGroupResourceValidator
This task is about updating error messages with error codes for NeutronSecurityGroupResourceValidator
Change-Id: I6279c76dae5aeff46bee0ffc9d097ba5b7ff267e
Issue-ID: SDC-572
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Code Review / sdc.git / log