Oleksandr Moliavko [Thu, 26 Sep 2019 06:21:39 +0000 (09:21 +0300)]
Added null checks for bp to prevent exceptions at
bp.getId() calls; fixed omissions in methods
control logic; removed unneeded catch blocks
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I8347b953381ebb4a112a22fc8c58a9a32f2dbfb7
Seshu Kumar M [Tue, 10 Sep 2019 10:14:25 +0000 (10:14 +0000)]
Merge "Distribution fails when no user input required in design"
Lukasz Muszkieta [Tue, 10 Sep 2019 07:33:34 +0000 (07:33 +0000)]
Merge "General sonar fixes"
Arindam Mondal [Thu, 5 Sep 2019 12:35:06 +0000 (21:35 +0900)]
General sonar fixes
+)Format logger
++) Remove toString()
+++) Extract nested IF
Issue-ID: SO-2226
Change-Id: Iff28408584b04ffd03b6aca0f647d0af9090a9c2
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
Steve Smokowski [Mon, 9 Sep 2019 18:02:15 +0000 (18:02 +0000)]
Merge "Add SO Update Check if SDC activities deployment end point for custom worlflows is alive"
Bonkur, Venkat (vb8416) [Mon, 9 Sep 2019 15:18:36 +0000 (11:18 -0400)]
Add SO Update Check if SDC activities deployment end point for custom worlflows is alive
Make changes to verify if SDC activities deployment
end point(mso.asdc.config.activity.endpoint) for custom worlflows is alive
Issue-ID: SO-2294
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: Iff916a33b403d507a383cebf8d668bb5cbf9fb55
sarada prasad sahoo [Mon, 9 Sep 2019 09:28:34 +0000 (14:58 +0530)]
Distribution fails when no user input required in design
When we distribute a design from SDC and design does
not have any user input in properties, then distribution
fails with error ArrayIndexOutOfBoundException
Issue-ID: SO-2279
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: I47bd724e25d81befc09ec452aa63d8519c927520
Elena Kuleshov [Mon, 9 Sep 2019 05:49:01 +0000 (01:49 -0400)]
Change names of two of catalogdb tables to lowercase
Table name used in Hibernate for catalogdb tables all need to be in lowercase.
Issue-ID: SO-2292
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Ic2079a9d65c9c6d9d5468b9d62422b328f54d72c
Steve Smokowski [Fri, 6 Sep 2019 19:54:32 +0000 (19:54 +0000)]
Merge "Set AAIClient on AAIValidatorImpl"
Steve Smokowski [Fri, 6 Sep 2019 19:54:27 +0000 (19:54 +0000)]
Merge "- Convert NetworkCollection to use GetEntity API."
Steve Smokowski [Fri, 6 Sep 2019 19:54:02 +0000 (19:54 +0000)]
Merge "Added index infra_active_requests optimal query"
Elena Kuleshov [Fri, 6 Sep 2019 03:31:35 +0000 (23:31 -0400)]
Set AAIClient on AAIValidatorImpl
AAIValidatorImpl requires setting an initialized AAIClient before validation calls
Issue-ID: SO-2286
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I254e8e01812e47af2855e1c1afaa5904ed792d22
Merkel, Jeff [Thu, 5 Sep 2019 18:08:07 +0000 (14:08 -0400)]
- Convert to use the GetEntity API
- Converted to use the GetEntity API for AllottedResources
Issue-ID: SO-2282
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: If5774c95473563e46f345e5d0c5f6880dd315e35
Parthasarathy, Ramesh [Thu, 5 Sep 2019 19:41:04 +0000 (15:41 -0400)]
Added index infra_active_requests optimal query
Added index infra_active_requests optimal query
Issue-ID: SO-2285
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ia8af787661701c8ae5593c54581e76ba1696d967
Merkel, Jeff [Thu, 5 Sep 2019 18:16:06 +0000 (14:16 -0400)]
- Convert NetworkCollection to use GetEntity API.
- Convert NetworkCollection to use GetEntity API.
- Updated to correctly format the code..
- Fix setting of parsing of the quantity field.
Issue-ID: SO-2283
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I1948a5bae2f9b1df5367bf3dd5a35357d196bdaf
Lukasz Muszkieta [Thu, 5 Sep 2019 08:17:41 +0000 (08:17 +0000)]
Merge "Log exception"
Parshad Patel [Wed, 4 Sep 2019 10:03:56 +0000 (19:03 +0900)]
Log exception
Either log or rethrow this exception
Use isEmpty() to check whether the collection is empty or not
Issue-ID: SO-1841
Change-Id: Ia964a871497df8a7211260ad1ad8f1efa8ae4d42
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Seshu Kumar M [Thu, 5 Sep 2019 04:11:11 +0000 (04:11 +0000)]
Merge "fix public NS distribution issue"
Max Benjamin [Wed, 4 Sep 2019 15:29:25 +0000 (15:29 +0000)]
Merge "Fix rollback for ConfigAssignBB"
sarada prasad sahoo [Tue, 3 Sep 2019 09:57:13 +0000 (15:27 +0530)]
fix public NS distribution issue
Fix Multiple VFModule under single service distribution
Issue-ID: SO-2275
Change-Id: I7a4a7dbb68d23c0e44f9985b3fdc89816dbfd232
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Lukasz Muszkieta [Wed, 4 Sep 2019 12:16:53 +0000 (12:16 +0000)]
Merge "General sonar fix add logger"
Steve Smokowski [Wed, 4 Sep 2019 12:13:24 +0000 (12:13 +0000)]
Merge "fix create call to A&AI"
Arindam Mondal [Mon, 2 Sep 2019 07:00:18 +0000 (16:00 +0900)]
General sonar fix add logger
Issue-ID: SO-2226
Change-Id: I5a826a9ea75b3065987a274ab7962c4a5fc1d614
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
Arindam Mondal [Wed, 4 Sep 2019 02:19:18 +0000 (11:19 +0900)]
General Sonar fixes
+) Make field transient or serializable
++) Organize imports
Issue-ID: SO-2273
Change-Id: I04eeb02c4052e3a790db865b59f873694fc1514d
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
Parshad Patel [Mon, 2 Sep 2019 06:02:28 +0000 (15:02 +0900)]
Fix issues in so-cloudify-client
Annotate the "CloudifyClientConnector" interface with the @FunctionalInterface annotation
Make this field final
Either log or rethrow this exception
Make "response" transient or serializable
Issue-ID: SO-1841
Change-Id: I13fa6b911d8789aed26fd27da23318f6dbca3760
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Gamboa, Gilbert [Fri, 30 Aug 2019 17:02:22 +0000 (13:02 -0400)]
fix create call to A&AI
createIfNotExists should be used rather than create
Issue-ID: SO-2269
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I03af6a83460acbb1d7bde01f108d2a5a03d05adf
Lukasz Muszkieta [Fri, 30 Aug 2019 13:09:08 +0000 (13:09 +0000)]
Merge "sonar fix for ExtractPojosForBB class"
Steve Smokowski [Fri, 30 Aug 2019 12:22:35 +0000 (12:22 +0000)]
Merge "Added back MDC.put to generated missing requestID"
Steve Smokowski [Fri, 30 Aug 2019 12:21:15 +0000 (12:21 +0000)]
Merge "- Make association from the cvnfc to the fabric"
Steve Smokowski [Fri, 30 Aug 2019 12:21:01 +0000 (12:21 +0000)]
Merge "Update requestStatus to FAILED on activity error."
Lukasz Muszkieta [Fri, 30 Aug 2019 08:37:57 +0000 (08:37 +0000)]
Merge "sonar fix-remove unused import"
Elena Kuleshov [Thu, 29 Aug 2019 20:47:28 +0000 (16:47 -0400)]
Update requestStatus to FAILED on activity error.
Update status and related fields in Requests DB on activity error, add a junit to verify error reporting.
Issue-ID: SO-2263
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I1a2e97afb95e4510b4860486c2b7836b014f990e
Chan, Mercy [Thu, 29 Aug 2019 20:12:22 +0000 (16:12 -0400)]
added fix for missing Error from SDNC prefix
added fix for missing Error from SDNC prefix to SDNC callback flow
reverted implementation from bpmn-tasks package and moved them to apih
side, added junit test
renamed error message constant, removed regex check, add error message
porefix directly to actual message
Issue-ID: SO-2267
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I440cf9eff12571f576fcc5f2d28d9f2c8130e4b6
Merkel, Jeff [Tue, 27 Aug 2019 17:26:30 +0000 (13:26 -0400)]
- Make association from the cvnfc to the fabric
- Make association from the cvnfc to the fabric config.
Issue-ID: SO-2262
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I8d9c1e5b738ec36fb3c6d9bae4acfef155b0e058
Munir Ahmad [Thu, 29 Aug 2019 18:15:53 +0000 (14:15 -0400)]
Fix rollback for ConfigAssignBB
Issue-ID: SO-2266
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Change-Id: Iff2faa9f9b919818c4a5f98a62ec2a66ee7589e4
Sangalang, Felix [Thu, 29 Aug 2019 13:59:30 +0000 (09:59 -0400)]
Added back MDC.put to generated missing requestID
Added back MDC.put to generated missing requestID in logfiles.
Issue-ID: SO-2265
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I67e0b01dfeb609e7a5d7e29f976ec3ec6549e96b
Thugutla sailakshmi [Thu, 29 Aug 2019 15:47:17 +0000 (21:17 +0530)]
sonar fix-remove unused import
sonar fix-remove unused import
Issue-ID: SO-2174
Change-Id: I5c13bbf27aa0f03b448fca5c2cea7329512aff01
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
subhash kumar singh [Tue, 27 Aug 2019 12:06:21 +0000 (17:36 +0530)]
Fixing ccvpn parsing issue
Fixing ccvpn parsing issue.
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Change-Id: Iaee7d003f8d657a93901b51bef9bedab0433b75c
Lukasz Muszkieta [Wed, 28 Aug 2019 13:43:29 +0000 (15:43 +0200)]
sonar fix for ExtractPojosForBB class
Change-Id: I2d568604fa5d2e688b367644de620c8e91508aae
Issue-ID: SO-2187
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Lukasz Muszkieta [Wed, 28 Aug 2019 07:42:16 +0000 (07:42 +0000)]
Merge "Removed unused methods injectSNIROCallbacks() according to comments by maintainer"
Lukasz Muszkieta [Tue, 27 Aug 2019 07:19:25 +0000 (07:19 +0000)]
Merge "Fix issue in mso-api-handler-infra"
Parshad Patel [Tue, 27 Aug 2019 05:29:12 +0000 (14:29 +0900)]
Fix issue in mso-api-handler-infra
Either log or rethrow this exception
Define a constant instead of duplicating this literal
Immediately throw this expression instead of assigning it to the temporary variable
Remove the declaration of thrown exception 'org.json.JSONException' which is a runtime exception
Issue-ID: SO-1841
Change-Id: I193f21ec2c4214863c8b51faf25fc3561d6be818
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Seshu Kumar M [Tue, 27 Aug 2019 05:07:26 +0000 (05:07 +0000)]
Merge "Add generic neutron network parameters"
Byung-Woo Jun [Mon, 26 Aug 2019 16:03:39 +0000 (16:03 +0000)]
Merge "Fix parsing issue for ccvpn"
subhash kumar singh [Fri, 2 Aug 2019 15:47:09 +0000 (21:17 +0530)]
Fix parsing issue for ccvpn
Fix csar parsing issue for ccvpn.
Change-Id: Ie99acbec8a52de7a08d1627c210c0e3fda986520
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Boslet, Cory [Mon, 26 Aug 2019 14:09:09 +0000 (10:09 -0400)]
Added default value for when ErrorCode is null in
Added default value for when ErrorCode is null in mdc
test to see if 404 log gets enhanced by change.
Removed test id from class that was put to test via docker.
Removed setting of partner name and tested with using try/catch
Reverted change to request uri filter per comments
Removed the request filter uri class that rerouted old uri orders
Removed request filter from jersey config files
Updated junit test that were pointing to the old uri to be failure test
corrected formatting issues on ServiceInstancesTest
Issue-ID: SO-2259
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Id8f9daef139a82ee9e934d4d37906ffb7a7aadff
Steve Smokowski [Mon, 26 Aug 2019 13:58:50 +0000 (13:58 +0000)]
Merge "Add the check Fabric Config in"
Steve Smokowski [Mon, 26 Aug 2019 13:58:44 +0000 (13:58 +0000)]
Merge "- Updated VNF and VfModules to use the getEntity"
Steve Smokowski [Mon, 26 Aug 2019 13:58:39 +0000 (13:58 +0000)]
Merge "path prefix now stripped off per system"
Steve Smokowski [Mon, 26 Aug 2019 13:58:32 +0000 (13:58 +0000)]
Merge "added in exception handling if auditResult is null"
Steve Smokowski [Mon, 26 Aug 2019 13:58:26 +0000 (13:58 +0000)]
Merge "added additional mock to MsoGroovyTest"
Steve Smokowski [Mon, 26 Aug 2019 13:58:20 +0000 (13:58 +0000)]
Merge "fixed dsl builder to correctly add output"
Manamohan [Mon, 26 Aug 2019 06:50:52 +0000 (12:20 +0530)]
Javadoc and logging improvement
Added Javadocs and logging for these classes.
Change-Id: I26dd974357cfb9ccaed3f9afd0510dc07e9bc33e
Issue-ID: SO-2052
Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
Bonkur, Venkat [Fri, 23 Aug 2019 12:54:58 +0000 (08:54 -0400)]
Add the check Fabric Config in
Add the check Fabric Config in configuration-subtype
after format file run and commit
Issue-ID: SO-2256
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: If47f81a985e6321cd84ccfc8d35c51f3ee79e1c2
Seshu Kumar M [Fri, 23 Aug 2019 08:51:33 +0000 (08:51 +0000)]
Merge "url correction and improve API doc Issue-ID: SO-2245"
Lukasz Muszkieta [Fri, 23 Aug 2019 08:22:40 +0000 (08:22 +0000)]
Merge "Fix issue in so-bpmn-tasks"
Rene_Robert [Thu, 22 Aug 2019 14:57:27 +0000 (16:57 +0200)]
url correction and improve API doc
Issue-ID: SO-2245
Signed-off-by: Rene_Robert <rene.robert@orange.com>
Change-Id: Ife95e64f0bed03e779f8ffef180f2a68ed0eb371
Merkel, Jeff [Thu, 22 Aug 2019 12:27:19 +0000 (08:27 -0400)]
- Updated VNF and VfModules to use the getEntity
- Updated VNF and VfModules to use the getEntity API.
- Added the processFlexware step back in.
Issue-ID: SO-2244
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I1274ccb9b2c2e600f3c24f8ac86dd1ff673c66da
Lukasz Muszkieta [Thu, 22 Aug 2019 11:07:46 +0000 (11:07 +0000)]
Merge "Moved setNeutronNetworkId() call inside null check to prevent crash at outputs.get() call"
Parshad Patel [Thu, 22 Aug 2019 07:30:16 +0000 (16:30 +0900)]
Fix issue in so-bpmn-tasks
Either log or rethrow this exception
Define a constant instead of duplicating this literal
Move the string literal on the left side of this string comparison
Issue-ID: SO-1841
Change-Id: I828e744be9e71b84d85850d56373e921c174d26b
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Lukasz Muszkieta [Thu, 22 Aug 2019 09:41:16 +0000 (09:41 +0000)]
Merge "Moved null check for outputs so that get() method call won't result in crash."
Arindam Mondal [Mon, 19 Aug 2019 02:24:37 +0000 (11:24 +0900)]
General sonar fixes
+) Use format specifier to log exception
++) remove unused import
Issue-ID: SO-2226
Change-Id: I0938d624b918eddf30e96da4f12d7a06cc0ddfe1
Signed-off-by: arindamm <arind.mondal@samsung.com>
Eric Multanen [Thu, 22 Aug 2019 04:48:53 +0000 (21:48 -0700)]
Add generic neutron network parameters
Add the generic neutron network heat template parameters
to the catalogdb. This will allow providing a name to
networks different than the default network
Change-Id: I22adea6eed11eeea7d99c9f3d753b6cf77088d6a
Issue-ID: SO-2083
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Oleksandr Moliavko [Wed, 21 Aug 2019 06:55:13 +0000 (09:55 +0300)]
Added null check for latestStack to prevent crash
at method calls; moved latestStack declaration
according to comment by maintainer
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ic4bfeca94103f6c902808de39df752569580c066
Seshu Kumar M [Wed, 21 Aug 2019 13:26:49 +0000 (13:26 +0000)]
Merge "Javadoc and logging improvement"
Seshu Kumar M [Wed, 21 Aug 2019 13:24:58 +0000 (13:24 +0000)]
Merge "Added null check for httpResponse to prevent crash at throwing exception"
Oleksandr Moliavko [Tue, 20 Aug 2019 08:32:52 +0000 (11:32 +0300)]
Added null check for rootNode to prevent crash at
for loop.
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5ec16f3d73982c89e2bf5b14758274f1d4dd7740
Oleksandr Moliavko [Wed, 21 Aug 2019 08:10:49 +0000 (11:10 +0300)]
Removed unused methods injectSNIROCallbacks()
according to comments by maintainer
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I22af32a50cc08954861232a8e38d23166a88c442
Oleksandr Moliavko [Mon, 19 Aug 2019 14:56:28 +0000 (17:56 +0300)]
Rewritten checks for status according to comments
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I6023a043e2cf532de330060973d23a402a742e36
Benjamin, Max [Tue, 20 Aug 2019 16:56:16 +0000 (12:56 -0400)]
path prefix now stripped off per system
path prefix now stripped off per system
Issue-ID: SO-2243
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ie74e7c68f927a49b612c433b4a664887058a1726
Kalkere Ramesh, Sharan [Tue, 20 Aug 2019 13:45:01 +0000 (09:45 -0400)]
added in exception handling if auditResult is null
added in exception handling if auditResult is null
maven process format the file that is not formatted
fix formsatting again because it failed last time
Issue-ID: SO-2242
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I6a83c7fe120e02e808470dbc9e7e431e0b62f4f4
Boslet, Cory [Tue, 20 Aug 2019 13:26:00 +0000 (09:26 -0400)]
added additional mock to MsoGroovyTest
added additional mock to MsoGroovyTest
Issue-ID: SO-2241
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I441d79f4951184b0ca79f2c568978fe3d2043025
Seshu Kumar M [Mon, 19 Aug 2019 11:38:40 +0000 (11:38 +0000)]
Merge "Solve the vnfc_instance_group_customization_id insertion failure problem"
k.kazak [Wed, 14 Aug 2019 08:18:31 +0000 (10:18 +0200)]
Close input streams via try-with-resources
DefaultDmaapPropertiesImpl: close FileInputStream after loading
ServicePluginFactory: close HttpClient if processing fails
close application.properties InputStream after loading
remove redundant catch block if behavior is the same
add logging of exception in finally block
BpmnInstaller: close csarFile if processing fails
Change-Id: Ic6f942c401277c5150c5cc1297aba27ccd40694c
Coverity-scan: CID-203903, CID-211476, CID-211615, CID-219308
Issue-ID: SO-2211
Signed-off-by: k.kazak <k.kazak@samsung.com>
Oleksandr Moliavko [Mon, 19 Aug 2019 07:54:42 +0000 (10:54 +0300)]
Added null check for heat to remove static
analyzer warning
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I71eb14adcc1227af4470853e6e1acdb631a7efe8
Benjamin, Max [Fri, 16 Aug 2019 14:59:18 +0000 (10:59 -0400)]
fixed dsl builder to correctly add output
fixed dsl builder to correctly add output
look for lambda key rather than parent class null
Issue-ID: SO-2233
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I251b9b8b4c391354b9759ee16a2462df43c188f9
Steve Smokowski [Fri, 16 Aug 2019 13:59:29 +0000 (13:59 +0000)]
Merge "add junit coverage for SvnfmService"
Steve Smokowski [Fri, 16 Aug 2019 13:09:41 +0000 (13:09 +0000)]
Merge "Add retrieval of vmIds and vServerIds for APPC"
Steve Smokowski [Fri, 16 Aug 2019 13:08:37 +0000 (13:08 +0000)]
Merge "Add SO Same deployment id on deployed custom workflows"
Steve Smokowski [Fri, 16 Aug 2019 13:06:00 +0000 (13:06 +0000)]
Merge "Initial commit of validation framework to APIH"
Steve Smokowski [Fri, 16 Aug 2019 13:05:51 +0000 (13:05 +0000)]
Merge "asdc controller treat distributionid as requestid"
Steve Smokowski [Fri, 16 Aug 2019 13:05:39 +0000 (13:05 +0000)]
Merge "apih format statusdetail to return granular"
Oleksandr Moliavko [Fri, 16 Aug 2019 12:21:20 +0000 (15:21 +0300)]
Added null check for httpResponse to prevent crash
at throwing exception
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Iffbaaddea9c9bb1609ce2e0755f6f3ca49e0ad31
Oleksandr Moliavko [Wed, 14 Aug 2019 07:42:25 +0000 (10:42 +0300)]
Removed unused CSAR class.
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I0efbb38cb34b0b36d2659ebf36f6cd2d109e5deb
Oleksandr Moliavko [Fri, 16 Aug 2019 06:53:30 +0000 (09:53 +0300)]
Replaced string concatenations in a loop with
StringBuffer appends to remove static analyzer
warning about inefficient string operations
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I89e0e5b599a8263882b0f91fb0f9191734a04ec1
Lukasz Muszkieta [Fri, 16 Aug 2019 10:04:05 +0000 (10:04 +0000)]
Merge "Added check for empty processInstanceList"
Parshad Patel [Tue, 13 Aug 2019 04:38:06 +0000 (13:38 +0900)]
Sonar fix in MSOCommonBPMN
Either log or rethrow this exception
Remove this useless assignment to local variable "serviceInstance"
Remove the declaration of thrown exception which is a runtime exception
Move the string literal on the left side of this string comparison
Issue-ID: SO-1841
Change-Id: I24cdd3682eddd2e5ceb7e961477a61457ef91ab2
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Manamohan [Fri, 16 Aug 2019 06:15:52 +0000 (11:45 +0530)]
Javadoc and logging improvement
Added Javadocs and logging for these classes.
Change-Id: I365fc0677c0d5136e4579de3947d0478b26c22d3
Issue-ID: SO-2052
Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
zm330 [Fri, 16 Aug 2019 03:29:04 +0000 (11:29 +0800)]
Solve the vnfc_instance_group_customization_id insertion failure problem
Change-Id: Iac9eea25895d9f048b00218b67db5d7bfb3efb58
Issue-ID: SO-2164
Signed-off-by: zm330 <zhangminyj@chinamobile.com>
Smokowski, Steven [Fri, 16 Aug 2019 01:40:16 +0000 (21:40 -0400)]
Initial commit of validation framework to APIH
Move ListenerRunner to common location
Adjust request params name, update junit tests
Update validations to work properly
Properly escape period for the string split
Issue-ID: SO-2232
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ia468cf7062cccf30e28afeb7a5cddc37ceb2e002
Plummer, Brittany [Tue, 13 Aug 2019 23:12:07 +0000 (19:12 -0400)]
Added check for empty processInstanceList
Added check for empty processInstanceList
Issue-ID: SO-2225
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: If4569d94dbda794c9a347e6dc73102acf7664558
Bhatt, Prema [Thu, 15 Aug 2019 19:54:22 +0000 (15:54 -0400)]
asdc controller treat distributionid as requestid
Setting RequestId in MDC using DistributionID value in ASDC-controller
Setting RequestId in MDC using DistributionID value in ASDC-controller.
Cleaned up code.
Removing the log line as per the review comments.
Issue-ID: SO-2231
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I07880a80d479ad01411e0c5ece12d77722b8cb6c
Plummer, Brittany [Thu, 15 Aug 2019 19:48:49 +0000 (15:48 -0400)]
apih format statusdetail to return granular
Should return unchanged requestState on statusDetail queryParam
Formatted files with changes to fix build
Added enum validation for setting requestStatus
Updated test to send in "statusDetail"
Issue-ID: SO-2230
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I8f5d79bc287581635a1543a00ddc69fb9eba2295
Bonkur, Venkat (vb8416) [Thu, 15 Aug 2019 04:07:09 +0000 (00:07 -0400)]
Add SO Same deployment id on deployed custom workflows
Added the change to call the DeploymentBuilder.deploy() method after
going through all the custom workflows. Thus all the workflows
deployed and they startup correctly.
Issue-ID: SO-2210
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: Ieaa5d1447405f75744d7c05bd8f7603c16edf5ea
Steve Smokowski [Thu, 15 Aug 2019 12:11:45 +0000 (12:11 +0000)]
Merge "- Updated vnfc instance groups to use the"
anjali.walsatwar [Mon, 12 Aug 2019 10:26:51 +0000 (15:56 +0530)]
public keyword removed for DoCreateServiceInstanceRollback.groovy
groovy file correction
Issue-ID: SO-2212
Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: If2b6f5d1416042dd8ce88ae9d467ae24b00a1c55
Lukasz Muszkieta [Wed, 14 Aug 2019 10:27:45 +0000 (10:27 +0000)]
Merge "DoCreateVFCNetworkServiceInstance.groovy corrected"
Elena Kuleshov [Fri, 9 Aug 2019 22:21:32 +0000 (18:21 -0400)]
Add retrieval of vmIds and vServerIds for APPC
2nd take, resolving build issu - port retrieval of vmIds and vserverIds from groovy to java
Issue-ID: SO-2189
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Ic666a65336e40eb38ab91c0037b85236ec1eebb5
Merkel, Jeff [Tue, 13 Aug 2019 23:10:26 +0000 (19:10 -0400)]
- Updated vnfc instance groups to use the
- Updated vnfc instance groups to use the getEntity API.
Issue-ID: SO-2224
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I278aebe5174dfb52ad3db86957c262dca5eac359
Lukasz Muszkieta [Tue, 13 Aug 2019 14:42:41 +0000 (14:42 +0000)]
Merge "Removed unused CryptoHandler, ICryptoHandler and CryptoHandlerTest classes"
Code Review / so.git / log