sdc.git
5 years agoAdd unit tests for DataModelNormalizeUtil 63/88463/3
m.kowalski3 [Fri, 24 May 2019 12:26:18 +0000 (14:26 +0200)]
Add unit tests for DataModelNormalizeUtil

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I31dbd12b2d897da83327c17af2f2d83bd4459f1d

5 years agoFix service proxy node type 23/88323/1
ojasdubey [Thu, 23 May 2019 06:39:35 +0000 (12:09 +0530)]
Fix service proxy node type

Added properties, interfaces and requirements
of the child service to the node type of proxy
in the parent

cherry picked commit from
dublin: e50b5687b62edbafa12bf3825b0441077c5a4820

Change-Id: I2b4bb695c0b3819ada889b144d536b48dd9d1f30
Issue-ID: SDC-2313
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
5 years agomiss a "/" in the directory path in docker_run.sh 34/85734/2
Liang Ding [Fri, 19 Apr 2019 01:59:53 +0000 (18:59 -0700)]
miss a "/" in the directory path in docker_run.sh

Change-Id: I9ca1bfd62d535ebaa6bc668ab5931f0d425856b3
Issue-ID: SDC-2247
Signed-off-by: Liang Ding <liang.ding@intel.com>i
5 years agoFix minor typos in documentation 82/87982/3
kaihlavi [Fri, 17 May 2019 11:54:25 +0000 (14:54 +0300)]
Fix minor typos in documentation

Change-Id: I0c1468fc0f7f9a03ee7c23c2ca1b9debd136c671
Issue-ID: SDC-2315
Signed-off-by: kaihlavi <l.kaihlavirt@partner.samsung.com>
5 years agoRename "Ecomp Generated value" to "Generated Value" 53/88153/1
avigaffa [Tue, 21 May 2019 11:36:27 +0000 (14:36 +0300)]
Rename "Ecomp Generated value" to "Generated Value"

Rename "Ecomp Generated value" to "Generated Value" in create service screen

Change-Id: I4e0439117e77ca9fa68719c970f3e13e4491b81b
Issue-ID: SDC-2318
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
5 years agoFixed declared properties are not updated properly 62/88062/2
Satoshi Fujii [Mon, 20 May 2019 07:00:56 +0000 (16:00 +0900)]
Fixed declared properties are not updated properly

Change-Id: I3712f9656d7cdeb8fa9c4212b2dd1496043c1006
Issue-ID: SDC-2314
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
5 years agofix bug [SDC-2317] - Auto collapse properties tables after sorting by capability... 59/88059/1
miriame [Mon, 20 May 2019 06:59:19 +0000 (09:59 +0300)]
fix bug [SDC-2317] - Auto collapse properties tables after sorting by capability column is not applied

Change-Id: Ife53616c79b9cc5271dfde6204775afdfaa3b646
Issue-ID: SDC-2317
Signed-off-by: miriame <miriam.eini@amdocs.com>
5 years agofix bug [SDC-2316] - Unable to select a type from Operation screen when using Capabil... 54/88054/1
miriame [Mon, 20 May 2019 06:39:06 +0000 (09:39 +0300)]
fix bug [SDC-2316] - Unable to select a type from Operation screen when using Capabilities Properties

Change-Id: Ie9ad5034fc3f2ef2ae9038d05e2a56f9c78ac1d6
Issue-ID: SDC-2316
Signed-off-by: miriame <miriam.eini@amdocs.com>
5 years agoProperties are missing in TOSCA fix 68/87968/2
Sonsino, Ofir (os0695) [Wed, 8 May 2019 07:34:06 +0000 (10:34 +0300)]
Properties are missing in TOSCA fix

Change-Id: Iacceb798cb24408e232b9b59c751b0e984871728
Issue-ID: SDC-2283
Signed-off-by: Sonsino, Ofir (os0695) <os0695@intl.att.com>
(cherry picked from commit 08f1f67956928d52427d101607f2e11d578d4b82)

5 years agoTest case failure CSAR file corrected 66/87966/1
sarada prasad sahoo [Fri, 17 May 2019 08:52:26 +0000 (14:22 +0530)]
Test case failure CSAR file corrected

Fix the vSBC CSAR file as per NFV SOL0001 v2.5.1

Change-Id: I637312e91452ffa47f5a9fd14152c3966a39beaf
Issue-ID: SDC-2170
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
5 years agoUpdate test coverage 57/87757/1
kooper [Wed, 15 May 2019 10:39:07 +0000 (10:39 +0000)]
Update test coverage

Change-Id: Ib92d00266d17635b53593eaa544ca3b312c7ddb2
Issue-ID: SDC-2310
Signed-off-by: kooper <sergey.sachkov@est.tech>
5 years agoFix test coverage 73/87673/3
talio [Tue, 14 May 2019 12:29:47 +0000 (15:29 +0300)]
Fix test coverage

Fix license in test files

Change-Id: I27207ca5b3e5482c9545c02de28eebdb599e6f76
Issue-ID: SDC-2298
Signed-off-by: talio <tali.orenbach@amdocs.com>
5 years agoFix test coverage 68/87668/3
talio [Tue, 14 May 2019 11:52:37 +0000 (14:52 +0300)]
Fix test coverage

Fix test coverage for PropertyDeclarationOrchestrator.java

Change-Id: I8f787017713dc2218ecfadbe31aee0831c303e2b
Issue-ID: SDC-2298
Signed-off-by: talio <tali.orenbach@amdocs.com>
5 years agoFix test coverage 66/87666/2
talio [Tue, 14 May 2019 08:28:43 +0000 (11:28 +0300)]
Fix test coverage

Fix test coverage for PolicyUtils.java

Change-Id: I7fc4fd36ced11706a867f9b8b5e29f9c0f75b368
Issue-ID: SDC-2298
Signed-off-by: talio <tali.orenbach@amdocs.com>
5 years agoFix test coverage 55/87655/2
talio [Tue, 14 May 2019 07:33:22 +0000 (10:33 +0300)]
Fix test coverage

Fix test coverage for UiComponentDataConverter.java

Change-Id: I745acb3bd3e40c58c12d1d359bb3b06c8bc95f09
Issue-ID: SDC-2298
Signed-off-by: talio <tali.orenbach@amdocs.com>
5 years agoFix test coverage 56/87656/2
talio [Tue, 14 May 2019 07:44:09 +0000 (10:44 +0300)]
Fix test coverage

Fix test coverage for InputsBusinessLogic.java

Change-Id: I6e140a08cf7d3c605b5446117617b7a574eaca88
Issue-ID: SDC-2298
Signed-off-by: talio <tali.orenbach@amdocs.com>
5 years agoFix test coverage 57/87657/2
talio [Tue, 14 May 2019 07:54:33 +0000 (10:54 +0300)]
Fix test coverage

Fix test coverage for PolicyBusinessLogic.java

Change-Id: I98f5918b2e25599747ac0feb0d7ecf7ab76bf0f6
Issue-ID: SDC-2298
Signed-off-by: talio <tali.orenbach@amdocs.com>
5 years agoFix test coverage 59/87659/2
talio [Tue, 14 May 2019 08:03:19 +0000 (11:03 +0300)]
Fix test coverage

Fix test coverage for ComponentInstanceInputPropertyDeclarator.java

Change-Id: Ie52b56ce07ad8eaec47166311cd8e7942b153bd0
Issue-ID: SDC-2298
Signed-off-by: talio <tali.orenbach@amdocs.com>
5 years agoFix test coverage 60/87660/2
talio [Tue, 14 May 2019 08:12:47 +0000 (11:12 +0300)]
Fix test coverage

Fix test coverage for ComponentInstancePropertyDeclarator.java

Change-Id: I8c504990863147af421bc7e0333241d1a9bcc746
Issue-ID: SDC-2298
Signed-off-by: talio <tali.orenbach@amdocs.com>
5 years agoFix test coverage 64/87664/2
talio [Tue, 14 May 2019 08:23:50 +0000 (11:23 +0300)]
Fix test coverage

Fix test coverage for GetInputUtils.java

Change-Id: Ibc9137b3087beb4fac48cd57fa440da2c23ce8f6
Issue-ID: SDC-2298
Signed-off-by: talio <tali.orenbach@amdocs.com>
5 years agoFix test coverage 62/87662/1
talio [Tue, 14 May 2019 11:00:35 +0000 (14:00 +0300)]
Fix test coverage

Fix test coverage for ComponentPropertyDeclarator.java

Change-Id: I1a065460a5c1816b2cc1c3146aefa4a82e597ff7
Issue-ID: SDC-2298
Signed-off-by: talio <tali.orenbach@amdocs.com>
5 years agoSupport Capability Properties 25/87625/1
Mojahidul Islam [Tue, 14 May 2019 07:19:31 +0000 (12:49 +0530)]
Support Capability Properties

This change includes following changes
1. Get capability properties from global types- BE
2. Show capability properties in cap/req screen
3. Support Capability Properties in assingment, operation and consumption screens

Change-Id: Ieb4fa5705007c8bed3d82eb4fe4604572aa202d7
Issue-ID: SDC-2294
Signed-off-by: Mojahidul Islam <mojahidul.islam@amdocs.com>
5 years agooperation artifact optional and fixes 48/87548/2
Arielk [Mon, 13 May 2019 12:30:27 +0000 (15:30 +0300)]
operation artifact optional and fixes

Change-Id: Ibce96d60248b26716ed518747444836b437f209f
Issue-ID: SDC-2249
Signed-off-by: Arielk <Ariel.Kenan@amdocs.com>
5 years agoFunctional Test Automation: VSP 17/86117/3
Vodafone [Wed, 24 Apr 2019 06:35:09 +0000 (12:05 +0530)]
Functional Test Automation: VSP

Change-Id: Ifd417c2ecfe1e82a69f64b3908c768fbd3b0af4f
Issue-ID: SDC-2047
Co-authored-by: rahul.ghugikar@vodafone.com, soumyarup.paul@vodafone.com
Signed-off-by: Vodafone <onap@vodafone.com>
5 years agoWorkflow artifact missing in CSAR for PNF 51/87251/2
siddharth0905 [Wed, 8 May 2019 15:25:16 +0000 (20:55 +0530)]
Workflow artifact missing in CSAR for PNF

Artifact Delivery call failing in SDC for PNF

Change-Id: I8fde881d4364974ec77b4f2523773a57a3d8aeba
Issue-ID: SDC-2274
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
5 years agoAdded JUnit Test for coverage 78/87478/1
bilal.iqbal [Fri, 10 May 2019 17:45:07 +0000 (17:45 +0000)]
Added JUnit Test for coverage

Change-Id: I7bbd5fca6847f30f64cba6d9beb521c3ba61d1cb
Issue-ID: SDC-2279
Signed-off-by: bilal.iqbal <bilal.iqbal@est.tech>
5 years agoFixed properties merge logic not to lose properties from inputs 87/86387/3
Satoshi Fujii [Fri, 26 Apr 2019 11:00:07 +0000 (20:00 +0900)]
Fixed properties merge logic not to lose properties from inputs

Change-Id: I9dbc244c667272062bc4de90d616ea1c5458ed0a
Issue-ID: SDC-2255
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
5 years agoJacoco doesn't show coverage for tests that use PowerMock 23/86823/3
kooper [Tue, 7 May 2019 08:44:41 +0000 (08:44 +0000)]
Jacoco doesn't show coverage for tests that use PowerMock

Change-Id: I28ff85e10dc449bf41b7ce6657ecdf455e9360d4
Issue-ID: SDC-2260
Signed-off-by: kooper <sergey.sachkov@est.tech>
5 years agoChange to enable SDC list type input 69/84769/9
Toshimichi Fukuda [Thu, 18 Apr 2019 12:38:46 +0000 (21:38 +0900)]
Change to enable SDC list type input

Change-Id: Ic3a9c6e714a5afd22b58bf2cb066932b1ec2a5c0
Issue-ID: SDC-2046
Signed-off-by: Toshimichi Fukuda <t_fukuda@jp.fujitsu.com>
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
Signed-off-by: Ayumu Ueha <ueha.ayumu@jp.fujitsu.com>
5 years agoUpdate SDC version 1.5.0 63/87163/1
Sonsino, Ofir (os0695) [Tue, 7 May 2019 15:30:15 +0000 (18:30 +0300)]
Update SDC version 1.5.0

Change-Id: I22d2273103230bd9ee7c3655b5f33e4308bb9f92
Issue-ID: SDC-1913
Signed-off-by: Sonsino, Ofir (os0695) <os0695@intl.att.com>
5 years agoRevert "Workflow artifact missing in CSAR for PNF" 41/87141/2
Ofir Sonsino [Tue, 7 May 2019 12:33:50 +0000 (12:33 +0000)]
Revert "Workflow artifact missing in CSAR for PNF"
This reverts commit f2a0762e0a589f5e422efa0adb6caa1158d210ef.

Issue-ID: SDC-2274
Change-Id: Iaabe39728418c79f179d1a20dd8c72c6a8dc4905
Signed-off-by: Sonsino, Ofir (os0695) <os0695@intl.att.com>
5 years agoSome unit tests for catalog-be 83/85183/3
Tomasz Golabek [Fri, 12 Apr 2019 10:25:50 +0000 (12:25 +0200)]
Some unit tests for catalog-be

This is the last part of tests for info-models so at least this
package should be quite nice covered by test since now.
Some refactor made if needed.

Change-Id: I78303ae8c5976b4a2c97422517a6df0cbae88e26
Issue-ID: SDC-2220
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoFix license header typo 66/86966/2
Sonsino, Ofir (os0695) [Sun, 5 May 2019 08:45:02 +0000 (11:45 +0300)]
Fix license header typo

Change-Id: I10ddaec9888c60778adf0f7b92d9d3c810103f60
Issue-ID: SDC-2276
Signed-off-by: Sonsino, Ofir (os0695) <os0695@intl.att.com>
5 years agofix bug: [SDC-2275]Service properties - issue on save multiple properties 65/86965/1
miriame [Sun, 5 May 2019 08:28:34 +0000 (11:28 +0300)]
fix bug: [SDC-2275]Service properties - issue on save multiple properties
 Issue-ID: SDC-2275

Change-Id: If9e44517727547dbf2bd28ecbaa96be6114bd848
Signed-off-by: miriame <miriam.eini@amdocs.com>
5 years agoTest case failure CSAR file corrected 12/86812/2
sarada prasad sahoo [Thu, 2 May 2019 12:53:18 +0000 (18:23 +0530)]
Test case failure CSAR file corrected

Fix the vSBC CSAR file as per NFV SOL0001 v2.5.1, changed property name from 'layer_protocol' to 'layer_protocols'

Change-Id: I28895943855367174f5c7866b68686a4fa6ec6cf
Issue-ID: SDC-2170
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
5 years agoWorkflow artifact missing in CSAR for PNF 91/86891/1
siddharth0905 [Fri, 3 May 2019 09:21:04 +0000 (14:51 +0530)]
Workflow artifact missing in CSAR for PNF

Artifact Delivery call failing in SDC for PNF

Change-Id: I4d5227d32debc4c13fe6d9c057d63fb09da47bb5
Issue-ID: SDC-2274
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
5 years agoWorkflow artifact missing in CSAR 09/86809/1
siddharth0905 [Thu, 2 May 2019 11:36:33 +0000 (17:06 +0530)]
Workflow artifact missing in CSAR

Artifact Delivery call failing in SDC
if any artifact in having artifact name as NULL

Change-Id: I20212434a8fe0ea2960d5b55a7a6834679153526
Issue-ID: SDC-2273
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
5 years agoenabled NFV Affinity and Anti-affinity Rules 14/86014/2 1.4.0
sarada prasad sahoo [Tue, 23 Apr 2019 04:46:13 +0000 (10:16 +0530)]
enabled NFV Affinity and Anti-affinity Rules

Fix the issue tosca.policies.nfv.AffinityRule and tosca.policies.nfv.AntiAffinityRule which was getting failed at first attempt with 404 error

Change-Id: I6630193343729051b41e4eb880832dee85b098ee
Issue-ID: SDC-2231
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
5 years agoSanity test failure for signed PNF onboarding packages 29/86629/2
AndyWalshe [Tue, 30 Apr 2019 14:27:22 +0000 (14:27 +0000)]
Sanity test failure for signed PNF onboarding packages

Change-Id: I622cc596b229904e2871f5977cde2b8f21acb6ba
Issue-ID: SDC-2259
Signed-off-by: AndyWalshe <andy.walshe@est.tech>
5 years agoAdded JUnit Test for code coverage 53/86553/5
bilal.iqbal [Tue, 30 Apr 2019 14:47:17 +0000 (14:47 +0000)]
Added JUnit Test for code coverage

Change-Id: I21527430218d00cbc0760bbf8415fa7205d75f90
Issue-ID: SDC-2238
Signed-off-by: bilal.iqbal <bilal.iqbal@est.tech>
5 years agoUpgrade SDC to use common cassandra cluster 73/85673/2
mahendrr [Thu, 18 Apr 2019 10:39:30 +0000 (10:39 +0000)]
Upgrade SDC to use common cassandra cluster

Change-Id: Ib6a45de3b10cb57466b7b3ef2e18b2fe07639c0f
Issue-ID: SDC-2199
Signed-off-by: mahendrr <mahendra.raghuwanshi@amdocs.com>
5 years agoAbility to disable GAB filters. 27/85027/3
Tomasz Golabek [Thu, 11 Apr 2019 08:21:52 +0000 (10:21 +0200)]
Ability to disable GAB filters.

Filters for preconfigured columns can be disabled using props.
(Should be merged after 'Dynamic columns in GAB table')

Change-Id: Id740ceb211c3978499b9c69197929a43e61e9cdc
Issue-ID: SDC-2234
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoGAB UI sanity 06/85806/2
Piotr Darosz [Fri, 19 Apr 2019 11:08:36 +0000 (13:08 +0200)]
GAB UI sanity

Prepare UI sanity check for basic GAB functionality.

Change-Id: If9b3a45f615ed3e88259b713f3776c22080d7a6d
Issue-ID: SDC-2242
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agoAdded some JUnit tests to improve coverage. Additional work could be added to improv... 87/86287/2
James Guistwite [Thu, 25 Apr 2019 12:58:06 +0000 (08:58 -0400)]
Added some JUnit tests to improve coverage.  Additional work could be added to improve results checking in the future.

Issue-ID: SDC-2238

Change-Id: Ief48b90eff33f166ca5f3fa5abb921e0e8c34d26
Signed-off-by: James Guistwite <jguistwite@iconectiv.com>
5 years agoAdd missing parameter in GAB dynamic columns 15/86615/1
Piotr Darosz [Tue, 30 Apr 2019 12:18:33 +0000 (14:18 +0200)]
Add missing parameter in GAB dynamic columns

Add a missing parameter in GAB dynamic columns logic.

Change-Id: Id50ad23ee9ad1ab9de91a812258518d684f5a86d
Issue-ID: SDC-2094
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agoSome unit tests for catalog-be 52/85052/3
Tomasz Golabek [Thu, 11 Apr 2019 12:29:49 +0000 (14:29 +0200)]
Some unit tests for catalog-be

Code coverage for some classes from catalog-be increased.
Some refactor made if needed.

Change-Id: Ia9348f624984ab7e5f9aa53c0adf33cf5867fa07
Issue-ID: SDC-2220
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoFixing expiry date for package cert 07/86607/2
kooper [Tue, 30 Apr 2019 09:50:21 +0000 (09:50 +0000)]
Fixing expiry date for package cert

Change-Id: I6d893f3ba67aefe1250ac4746fcb7221c594bcbd
Issue-ID: SDC-2256
Signed-off-by: kooper <sergey.sachkov@est.tech>
5 years agoDynamic columns in GAB table 27/84727/4
Tomasz Golabek [Tue, 9 Apr 2019 10:39:08 +0000 (12:39 +0200)]
Dynamic columns in GAB table

Possibility to add and remove new columns in GAB table.
Currently additional columns are not stored anywhere.

Change-Id: Idc204ef3da5be8f9509289461165e22d4c0068bf
Issue-ID: SDC-2229
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoRefactor hardcoded column config 21/84521/6
Piotr Darosz [Mon, 8 Apr 2019 12:35:40 +0000 (14:35 +0200)]
Refactor hardcoded column config

Move hardcoded GAB columns configuration to configuration.yaml file

Change-Id: Ie70a1d44c9a04a37c3ba0d3b5f64ad2989b11166
Issue-ID: SDC-2225
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agoSecurityManager test failing the build 20/86520/1
kooper [Mon, 29 Apr 2019 13:09:09 +0000 (13:09 +0000)]
SecurityManager test failing the build

Change-Id: I8ff3be7cdc2a1ebf2b3c8b55ac4199bd849865c9
Issue-ID: SDC-2256
Signed-off-by: kooper <sergey.sachkov@est.tech>
5 years agoUpdate Sanity tests to verify PNF package onboarding 38/85638/3
AndyWalshe [Thu, 25 Apr 2019 11:20:38 +0000 (11:20 +0000)]
Update Sanity tests to verify PNF package onboarding

Change-Id: Ibf7af544bf5fb9c63cf8d9c1573dafe50a395560
Issue-ID: SDC-1970
Signed-off-by: AndyWalshe <andy.walshe@est.tech>
5 years agoFix for incorrect count of coverage 56/86056/2
Tomasz Golabek [Tue, 23 Apr 2019 14:26:08 +0000 (16:26 +0200)]
Fix for incorrect count of coverage

Increased version of junit-jupiter.version and junit-vintage.version
Removed junit-platform-surefire-provider (not needed since surefire2.22)
Enabled jacoco for some tests from onboarding package

Change-Id: I05093b263de1ce93af88a3f99587a4050568caa3
Issue-ID: SDC-2250
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoadd an option of 'direct' into vnic_type of DM 46/86346/2
Liang Ding [Fri, 26 Apr 2019 04:00:41 +0000 (21:00 -0700)]
add an option of 'direct' into vnic_type of DM

this modification is for vCPE use case to enable
it work

Change-Id: I54488a4e847fa21238f5d2279ad86145375258e8
Issue-ID: SDC-2254
Signed-off-by: Liang Ding <liang.ding@intel.com>
5 years agoUpdate policy name in policyTypes.json 01/86301/1
Marco Platania [Thu, 25 Apr 2019 14:43:44 +0000 (10:43 -0400)]
Update policy name in policyTypes.json

Change-Id: Ic85397e450293647b2f3d262a58848a7f2e952db
Issue-ID: SDC-2251
Signed-off-by: Marco Platania <platania@research.att.com>
5 years agoFix policy definition in normative types 61/86161/1
Marco Platania [Wed, 24 Apr 2019 15:25:53 +0000 (11:25 -0400)]
Fix policy definition in normative types

Change "onap.policy.monitoring.cdap.tca.hi.lo.app" to "onap.policies.monitoring.cdap.tca.hi.lo.app"

Change-Id: I354184909472fea07fe566a2f9fdb832aca5675d
Issue-ID: SDC-2251
Signed-off-by: Marco Platania <platania@research.att.com>
5 years agoArtifactsBusinessLogic handlePayload() method refactoring and code coverage 02/85302/2
dermot123 [Mon, 15 Apr 2019 10:47:39 +0000 (10:47 +0000)]
ArtifactsBusinessLogic handlePayload() method refactoring and code coverage

Change-Id: I256520e3921c445b9972c78305af615155f7a2c7
Issue-ID: SDC-2239
Signed-off-by: dermot123 <dermot.melia@est.tech>
5 years agobug fixes to operation screen and External workflowartifact completion 61/85961/4
Arielk [Sun, 21 Apr 2019 13:07:44 +0000 (16:07 +0300)]
bug fixes to operation screen and External workflowartifact completion

Change-Id: I9d71385d6e29e1736a24f9d84581e465187e9f26
Issue-ID: SDC-2249
Signed-off-by: Arielk <Ariel.Kenan@amdocs.com>
5 years agoFix property name regex 29/85929/2
shrek2000 [Mon, 22 Apr 2019 05:07:24 +0000 (08:07 +0300)]
Fix property name regex

Error message number is invalid
Issue-ID: SDC-2243

Change-Id: Ib3eb658fa2c97a34cb4c1c4fd20aa9ad1084e677
Signed-off-by: shrek2000 <orenkle@amdocs.com>
5 years agoSome unit tests for catalog-be 39/84339/5
Tomasz Golabek [Fri, 5 Apr 2019 12:46:13 +0000 (14:46 +0200)]
Some unit tests for catalog-be

Code coverage for some classes from catalog-be increased.
Some refactor made if needed.

Change-Id: I1b292cfbe4b0d2aa4fbe22871da3228aa434b823
Issue-ID: SDC-2220
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoFix property name regex 04/85904/4
talio [Sun, 21 Apr 2019 09:43:15 +0000 (12:43 +0300)]
Fix property name regex

property name should contain only letters, numbers and / or underscores

Change-Id: Ic6b8d627a30f5f157bed1617a8af819b66352136
Issue-ID: SDC-2243
Signed-off-by: talio <tali.orenbach@amdocs.com>
5 years agoFix for jupiter tests execution. 34/85034/5
Tomasz Golabek [Thu, 11 Apr 2019 09:47:50 +0000 (11:47 +0200)]
Fix for jupiter tests execution.

Currently mvn-surefire-plugin doesnt execute junit5 tests.
Purpose of this merge request is to resolve the problem.

Change-Id: Idb63483c87b1137b21beabed9d24bbff6f01cf53
Issue-ID: SDC-2094
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoSome unit tests for catalog-be 51/84251/3
Tomasz Golabek [Thu, 4 Apr 2019 15:52:26 +0000 (17:52 +0200)]
Some unit tests for catalog-be

Code coverage for some classes from catalog-be increased.
Some refactor made if needed.

Change-Id: I5cd63fe61425f5eb05336545d714cbe2df83e116
Issue-ID: SDC-2220
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoVSP Compliance Check for Compute Flavor-BE Code-Review fixes 58/85158/2
Vodafone [Fri, 12 Apr 2019 06:49:30 +0000 (12:19 +0530)]
VSP Compliance Check for Compute Flavor-BE Code-Review fixes

Change-Id: Iec0e76518e669effdb9d2ca860d108f564f9253f
Issue-ID: SDC-2051
Co-authored-by: jguistwite@iconectiv.com
Signed-off-by: Vodafone <onap@vodafone.com>
5 years agoAdds a new artifact for controller blueprint 70/85370/2
agileone [Mon, 15 Apr 2019 20:06:45 +0000 (13:06 -0700)]
Adds a new artifact for controller blueprint

Defines CONTROLLER_BLUEPRINT_ARCHIVE artifact type
for PNF and VF.

Issue-ID: SDC-2139

Change-Id: Ib28bb25a6751b053ffe50323bb7c16576bc181f4
Signed-off-by: agileone <serge@agilitae.com>
5 years agoSupport BBS Modeling in SDC 32/84632/2
Victor Gao [Tue, 9 Apr 2019 08:32:10 +0000 (16:32 +0800)]
Support BBS Modeling in SDC

Change-Id: I9d5e960ed7ae46ea94d52fd14438f01948ff53dc
Issue-ID: SDC-2228
Signed-off-by: Victor Gao <victor.gao@huawei.com>
5 years agoIntroduce column filters in GAB table 83/83683/6
Tomasz Golabek [Fri, 29 Mar 2019 07:31:43 +0000 (08:31 +0100)]
Introduce column filters in GAB table

Additional input is available in each GABs headers providing
possibility to filter data-rows

Change-Id: I3d782673e275a2dc3b2d297520ace774348a8e68
Issue-ID: SDC-2214
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoDeclare properties as policies 66/85266/5
talio [Sun, 14 Apr 2019 12:37:20 +0000 (15:37 +0300)]
Declare properties as policies

Change-Id: I54dc7b444e08117097c314cf5f51bd356ac5287d
Issue-ID: SDC-2240
Signed-off-by: talio <tali.orenbach@amdocs.com>
5 years agoRevert "Upgrade SDC to use common cassandra cluster" 64/85264/1
Sonsino, Ofir (os0695) [Sun, 14 Apr 2019 09:41:54 +0000 (12:41 +0300)]
Revert "Upgrade SDC to use common cassandra cluster"

This reverts commit 00a6a4d66b0d22d530314816b4b5697fbc975e37.

Change-Id: I308844556aea66e91064d9067e3ba54179a0bb46
Issue-ID: SDC-2199
Signed-off-by: Sonsino, Ofir (os0695) <os0695@intl.att.com>
5 years agoFunctional Test Automation: VSP 38/85038/2
Vodafone [Thu, 11 Apr 2019 10:37:52 +0000 (16:07 +0530)]
Functional Test Automation: VSP

Change-Id: I2090a0646c1f1c7077830dbf49294f9a711774e4
Issue-ID: SDC-2047
Co-authored-by: rahul.ghugikar@vodafone.com, soumyarup.paul@vodafone.com
Signed-off-by: Vodafone <onap@vodafone.com>
5 years agoApply Valid Value Constraints validation 36/85036/2
siddharth0905 [Thu, 11 Apr 2019 10:08:15 +0000 (15:38 +0530)]
Apply Valid Value Constraints validation

Service consumption scenario fix

Change-Id: I5ad7beb18b0490385d24ce30b750ca5c2ebb28a8
Issue-ID: SDC-2224
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
5 years agosdc-backend-init docker container exits unsuccessfully with 404 error in importNormat... 98/84998/2
sarada prasad sahoo [Thu, 11 Apr 2019 04:01:34 +0000 (09:31 +0530)]
sdc-backend-init docker container exits unsuccessfully with 404 error in importNormativeAll.py

import of osca.policies.nfv.AffinityRule and tosca.policies.nfv.AntiAffinityRule getting failed at first attempt, comment execute , then un-comment execute it is working, strange issue

Change-Id: Ia8799b4221b771ed34d61d09f87e2d9973861ebe
Issue-ID: SDC-2231
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
5 years agoApply Valid Value Constraints validation 63/84863/3
siddharth0905 [Wed, 10 Apr 2019 12:19:51 +0000 (17:49 +0530)]
Apply Valid Value Constraints validation

Apply Valid Value Constraints validation for FE and BE in
Property Assignment, Input, Service Consumption screen

Change-Id: I01c7523bad702f003cd52fd88bc69fe950b2b4f3
Issue-ID: SDC-2224
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
5 years agoSome unit tests for catalog-be 25/84525/3
Tomasz Golabek [Mon, 8 Apr 2019 13:04:16 +0000 (15:04 +0200)]
Some unit tests for catalog-be

Code coverage for some classes from catalog-be increased.
Some refactor made if needed.

Change-Id: I1c5a35f99fcc0ace2f7b6ba4f7ef4f41acbed5e7
Issue-ID: SDC-2220
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoUpgrade SDC to use common cassandra cluster 82/82882/5
Mahendra Raghuwanshi [Thu, 21 Mar 2019 04:19:23 +0000 (04:19 +0000)]
Upgrade SDC to use common cassandra cluster

Issue-ID: SDC-2199
Change-Id: I139f38f3f3d968b775c9962bfe3ad6d13ea7f678
Signed-off-by: Mahendra Raghuwanshi <mahendra.raghuwanshi@amdocs.com>
5 years agoAdd cds consumer to the SDC. 85/84885/2
prathamesh morde [Wed, 10 Apr 2019 13:55:55 +0000 (09:55 -0400)]
Add cds consumer to the SDC.

Change-Id: Ib11a4d8806ecd3568e50d28f471655dea1d3cf9f
Issue-ID: CCSDK-1213
Signed-off-by: prathamesh morde <prathamesh.morde@bell.ca>
5 years agoREADME 15/84515/5
Tomasz Golabek [Mon, 8 Apr 2019 11:24:32 +0000 (13:24 +0200)]
README

README for the yaml parser.

Change-Id: Id94ec7bf4ba27ccffb31765b279e1ba3b8b50cd1
Issue-ID: SDC-2094
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agofix a typo: enzble --> enable 57/83557/3
Liang Ding [Thu, 28 Mar 2019 06:34:12 +0000 (23:34 -0700)]
fix a typo: enzble --> enable

Change-Id: I9639fe1777b98eed3fc340044d57d6f007ed58f0
Issue-ID: SDC-2212
Signed-off-by: Liang Ding <liang.ding@intel.com>
5 years agoWorkflow artifact in distribution notification 30/84830/1
priyanshu [Wed, 10 Apr 2019 08:57:19 +0000 (14:27 +0530)]
Workflow artifact in distribution notification

1. Support workflow artifact in distribution notification.
2. Only save unique artifacts by name per component in SDC irrespective of it being used in multiple operations under same component.
3. Any other call to save same artifact as part of same component will not upload a new artifact and will update the new operation to refer to existing artifact.
4. The generated CSAR and distribution notification will only have unique artifacts.
5. Delete or Update operation will only delete artifact if it is not being used in any other operation under same component.

Change-Id: I74d4ee4f8e543ea9e730301a210deb08b00c64bc
Issue-ID: SDC-2233
Signed-off-by: priyanshu <pagarwal@amdocs.com>
5 years agoVSP Compliance Check for Compute Flavor-BE 48/84648/2
Vodafone [Tue, 9 Apr 2019 09:48:21 +0000 (15:18 +0530)]
VSP Compliance Check for Compute Flavor-BE

Change-Id: Ife3eb83ab49e50fde1b0eb128e7e1abd5043432f
Issue-ID: SDC-2051
Co-authored-by: jguistwite@iconectiv.com
Signed-off-by: Vodafone <onap@vodafone.com>
5 years agoTosca artifacts - Error 500 01/84801/1
priyanshu [Wed, 10 Apr 2019 06:48:24 +0000 (12:18 +0530)]
Tosca artifacts - Error 500

Tosca artifacts - Error 500 - Service proxy with WF assigned

Change-Id: I1d75c0b9980ab42c7c825e4423ff4994600dd6fa
Issue-ID: SDC-2232
Signed-off-by: priyanshu <pagarwal@amdocs.com>
5 years agoSupporting PNFD (SOL001) mapping to Internal AID model 99/84499/4
dermot123 [Mon, 8 Apr 2019 16:31:20 +0000 (16:31 +0000)]
Supporting PNFD (SOL001) mapping to Internal AID model

This maps the PNF descriptor containing etsi defined types
according to SOL001 v2.5.1 to openecomp internal model. The
transformation is done in the "Create VSP" stage. As the main
PNF type gets mapped to the outer container in internal ecomp
model, it is possible to have no "resource instances" when
importing the PNF model into the catalog. The code was updated
to allow this for PNFs.

Change-Id: I961e91746ca638d858dd468e6c82aeb57993f7a3
Issue-ID: SDC-1976
Issue-ID: SDC-2160
Signed-off-by: dermot123 <dermot.melia@est.tech>
5 years agoVSP Compliance Check for Compute Flavor 23/84323/3
Vodafone [Fri, 5 Apr 2019 10:19:06 +0000 (15:49 +0530)]
VSP Compliance Check for Compute Flavor

Change-Id: I04768a20413393026606a3f5b200e959e37c1410
Issue-ID: SDC-2051
Co-authored-by: rahul.ghugikar@vodafone.com, soumyarup.paul@vodafone.com
Signed-off-by: Vodafone <onap@vodafone.com>
5 years agospecify a new type to cloud specific artifacts 75/82075/16
Liang [Wed, 13 Mar 2019 01:49:25 +0000 (01:49 +0000)]
specify a new type to cloud specific artifacts

Change-Id: I26e9533989a377d407290451063d97263a814d6b
Issue-ID: SDC-2041
Signed-off-by: Liang Ding <liang.ding@intel.com>
5 years agoadd file extentions for cloud specific artifacts 54/83554/5
Liang Ding [Thu, 28 Mar 2019 06:10:03 +0000 (23:10 -0700)]
add file extentions for cloud specific artifacts

Change-Id: I23c98ac6963bc4f708461d40dbda40a97a6939bc
Issue-ID: SDC-2041
Signed-off-by: Liang Ding <liang.ding@intel.com>
5 years agoInternal API for interface artifact upload 93/84593/2
priyanshu [Tue, 9 Apr 2019 03:54:51 +0000 (09:24 +0530)]
Internal API for interface artifact upload

Internal API for interface artifact upload

Change-Id: I9934a6d6aa11680b883f51ba8f231aeb866f2487
Issue-ID: SDC-2226
Signed-off-by: priyanshu <pagarwal@amdocs.com>
5 years agoshow cloud specific artifacts IDs in vf module meta 89/82389/12
Liang.Ding [Fri, 15 Mar 2019 08:16:42 +0000 (08:16 +0000)]
show cloud specific artifacts IDs in vf module meta

Change-Id: I42c54b2b94513c1dd69c3ec662a05a71a89fd3d0
Issue-ID: SDC-2041
Signed-off-by: Liang.Ding <liang.ding@intel.com>
5 years agoYaml parser exposed via SDC endpoint 74/83374/8
Tomasz Golabek [Tue, 26 Mar 2019 15:36:22 +0000 (16:36 +0100)]
Yaml parser exposed via SDC endpoint

GAB parser exposed as POST /v1/catalog/gab/searchFor endpoint.
Introduced OWASP ESAPI initial configuration

Change-Id: I2ee575b6092a97bc6acb1a5378bc66321e9fb182
Issue-ID: SDC-2209
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoupdating the VNFD (SOL001) type based on SOL001 v2.5.1 66/84466/2
sarada prasad sahoo [Mon, 8 Apr 2019 05:04:40 +0000 (10:34 +0530)]
updating the VNFD (SOL001) type based on SOL001 v2.5.1

updated VNFD types (tosca*.*nfv.) based on latest v2.5.1 version, not supported backward compatibility of SOL draft version, will be documented as limitation while upgrading from SOL draft version, updated importscript for new nodes, Also fixed java files for policyType having groupType reference, also updated with review comments

Change-Id: I1e128098cd1ebd602fe5aa01e617363634b25148
Issue-ID: SDC-2170
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
5 years agoupdating the VNFD (SOL001) type based on SOL001 v2.5.1 25/84325/3
sarada prasad sahoo [Fri, 5 Apr 2019 10:41:50 +0000 (16:11 +0530)]
updating the VNFD (SOL001) type based on SOL001 v2.5.1

updated VNFD types (tosca*.*nfv.) based on latest v2.5.1 version, not supported backward compatibility of SOL draft version, will be documented as limitation while upgrading from SOL draft version, updated importscript for new nodes, Also fixed java files for policyType having groupType reference

Change-Id: I8b8175ec908809608e6bdac990052d909792a2ba
Issue-ID: SDC-2170
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
5 years agoSome unit tests for catalog-be 35/84435/3
Tomasz Golabek [Sun, 7 Apr 2019 13:05:51 +0000 (15:05 +0200)]
Some unit tests for catalog-be

Code coverage for some classes from catalog-be increased.
Some refactor made if needed.

Change-Id: I33114eed03d4e176896fd803b54fb77787c34283
Issue-ID: SDC-2220
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoAdd build commit information to artifacts 33/84433/2
Oleg Beltz [Sun, 7 Apr 2019 05:26:50 +0000 (08:26 +0300)]
Add build commit information to artifacts

Change-Id: I38c230b8ebf3996300e4a5548ea807a020c3293b
Issue-ID: SDC-2222
Signed-off-by: Oleg Beltz <olegb@amdocs.com>
5 years agoCertificate location is configurable 43/84243/3
kooper [Thu, 4 Apr 2019 14:03:36 +0000 (14:03 +0000)]
Certificate location is configurable

Change-Id: I05cf96dd21c891312a5b5e67da3baf7a37e50e54
Issue-ID: SDC-2195
Signed-off-by: kooper <sergey.sachkov@est.tech>
5 years agoGeneric Artifact Browser SDC UI 96/83496/7
Piotr Darosz [Wed, 27 Mar 2019 14:25:50 +0000 (15:25 +0100)]
Generic Artifact Browser SDC UI

Introduce Generic Artifact Browser SDC UI in VF -> Deployment Artifacts
view.

Change-Id: I312c6c9d77f42ad2d073a8ad21c983ede39dfd0b
Issue-ID: SDC-2211
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agoMake Cassandra port configurable add defaults. 56/84256/1
Tal Gitelman [Thu, 4 Apr 2019 16:27:24 +0000 (19:27 +0300)]
Make Cassandra port configurable add defaults.

SDC-BE & Onboarding - BE.
Reviewer: Evgenia A & Areli F.

Change-Id: I4f11e354619a3f5cc276c128149a34f72c4b21bd
Issue-ID: SDC-2077
Signed-off-by: Tal Gitelman <tal.gitelman@att.com>
5 years agoMake Cassandra port configurable. 14/83614/8
Tal Gitelman [Thu, 28 Mar 2019 09:00:54 +0000 (11:00 +0200)]
Make Cassandra port configurable.

SDC-BE & Onboarding - BE.
Reviewer: Evgenia A & Areli F.

Change-Id: Iaf86d647b0560764ef65d9148c85bffaf934992d
Issue-ID: SDC-2077
Signed-off-by: Tal Gitelman <tal.gitelman@att.com>
5 years agoREvert Sanity Fix 89/84189/1
shrek2000 [Thu, 4 Apr 2019 06:40:12 +0000 (09:40 +0300)]
REvert Sanity Fix

Add dependent child service to service
Issue-ID: SDC-1987

Change-Id: I4393228a1577ccb7dc0b16db3f14a9b65d2db690
Signed-off-by: shrek2000 <orenkle@amdocs.com>
5 years agoAdd artifact types 92/84092/1
kooper [Wed, 3 Apr 2019 13:23:08 +0000 (13:23 +0000)]
Add artifact types

Change-Id: I48f2926623441d0729c5d5b476f3e72f962b64f8
Issue-ID: SDC-2156
Signed-off-by: kooper <sergey.sachkov@est.tech>
5 years agoAbility to update PNF with new version of VSP 75/84075/1
kooper [Wed, 3 Apr 2019 09:53:53 +0000 (09:53 +0000)]
Ability to update PNF with new version of VSP

Change-Id: Ie08d905bd40761b23198ad806be1750291343aae
Issue-ID: SDC-2219
Signed-off-by: kooper <sergey.sachkov@est.tech>
5 years agoVerify signature 47/83847/3
kooper [Tue, 2 Apr 2019 09:22:01 +0000 (09:22 +0000)]
Verify signature

Change-Id: I8fc5d50d74d3dd8031c96ee16708489dc7c789b8
Issue-ID: SDC-2163
Signed-off-by: kooper <sergey.sachkov@est.tech>
5 years agoupdate INFO.yaml 64/83564/5
avigaffa [Thu, 28 Mar 2019 08:15:00 +0000 (10:15 +0200)]
update INFO.yaml

removing Vitaliy
ident 4 spaces

Change-Id: I83986d90c2693c8e425d56b623dde1563715ce5d
Issue-ID: CIMAN-246
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>