Hockla, Ali (ah999m) [Wed, 4 Oct 2017 16:58:13 +0000 (11:58 -0500)]
Fixed Sonar blockers/criticals
Issue-ID: POLICY-292
Change-Id: Id53e9d3b6ba23b20d7e45d4d3b39f8092f126333
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
Jorge Hernandez [Thu, 28 Sep 2017 23:52:46 +0000 (18:52 -0500)]
missing $ in guard expansion variables
Change-Id: I05c577e8760f5b4b8e6375f50a327c9dde575e06
Issue-ID: POLICY-260
Signed-off-by: Jorge Hernandez <jh1730@att.com>
daniel [Thu, 28 Sep 2017 21:17:04 +0000 (16:17 -0500)]
Make Guard Configurable
This allows the user to disable or enable guard
through the .properties.environment file. Verified
and tested in a pdp. Properties were added to the
simulators properties file for the simulators to
work out of the box.
Issue-ID: POLICY-259
Change-Id: I0027a5d28f1b30e81bdbe42fa17621b36a61c850
Signed-off-by: Daniel Cruz <dc443y@att.com>
Jorge Hernandez [Thu, 28 Sep 2017 20:21:15 +0000 (20:21 +0000)]
Merge "Fix Sonar Criticals"
Hockla, Ali (ah999m) [Thu, 28 Sep 2017 18:44:26 +0000 (13:44 -0500)]
Fix Sonar Criticals
Made MSBServiceFactory serializable
Issue-ID: POLICY-115
Change-Id: I8c8abdf656a49bc20ecefb42a7f4f7bacde57726
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
Temoc Rodriguez [Thu, 28 Sep 2017 17:33:40 +0000 (10:33 -0700)]
Delete ControlLoopXacmlGuardTest.java
Deleted ControlLoopXacmlGuardTest.java so avoid sonar blockers. This
junit will reduce coverage a bit but is not significant. This junit is
already covered by the other use case junit files in template demo. A
more robust junit is in need to test guard permit, deny, and pdp-x
misconnecion in relation to the drl operations and rules. For now, this
file does not add useful testing.
Issue-ID: POLICY-260
Change-Id: Iaed0ad62f72ddc5b9a6b7626a037c26d6fd1ca52
Signed-off-by: Temoc Rodriguez <cr056n@att.com>
Jorge Hernandez [Thu, 28 Sep 2017 18:14:53 +0000 (18:14 +0000)]
Merge "Fix Sonar criticals"
Charles Cole [Tue, 26 Sep 2017 19:43:58 +0000 (14:43 -0500)]
Fix Sonar criticals
Fixed two Sonar criticals. Changed VFC actor service provider to
eliminate redundant AAI queries.
Issue-ID: POLICY-115
Change-Id: Ic4993b5d498a1cb3d3fc51ce1d2b4e90bb26353d
Signed-off-by: Charles Cole <cc847m@att.com>
daniel [Thu, 28 Sep 2017 15:01:21 +0000 (10:01 -0500)]
Fix Retries for Policies
This applies changes to make retries work properly
for all control loops. The current design was ignoring
the upper bound of the retries and retrying until either
a success or control loop timeout occured. This is now
fixed to only do retries until the limit is reached that
is specified from the policy.
The operation is now started in the GUARD.PERMITTED rule.
I think this is better because it stops Policy from doing
extra processing if there is a guard deny. This is also
needed so that we can properly do retries for all cases.
The notifications sent in GUARD_NOT_YET_QUERIED and
GUARD.RESPONSE are now more informative with the
message specifying the actor and recipe. The not queried
rule has a message stating that we are sending a query
to guard and the guard response message in the guard
response rule specifices the result from guard.
During a retest of vDNS it appeared that the archetype
template was no longer working, this was because there
were changes in the JUnit template that were not
reflected in the archetype template. These were added
to archetype and vDNS is verified to work again.
Another small fix needed was making sure the action for
vCPE is "Restart" instead of "restart". APPC will
reject our request if "Restart" is not sent as the
action.
Issue-ID: POLICY-259
Change-Id: I28dd3c9a629d297b408775a01afadd5c19351e37
Signed-off-by: Daniel Cruz <dc443y@att.com>
Jorge Hernandez [Thu, 28 Sep 2017 15:27:50 +0000 (15:27 +0000)]
Merge "Add missing auth headers to guard request"
Temoc Rodriguez [Tue, 26 Sep 2017 23:03:34 +0000 (16:03 -0700)]
Add missing auth headers to guard request
Added guard authentication, client authentication, and environment http
headers to the pdp-x guard restful request. Properties are set to
PolicyEngine.manager. Property getter, setter, and properties in
guard/.../Util.java. Test properties defined in junits themselves. Added
code from GuardContext.java to grab the properties and make restful request.
PolicyGuardXacmlHelper now closely resembles GuardContext in order to mimic
functionality. Guard url no longer is passed into CallGuardTask, it is now
a property.
Issue-ID: POLICY-260
Change-Id: I5b144764828b6da0e7b738a578e4f6596a0f4f36
Signed-off-by: Temoc Rodriguez <cr056n@att.com>
Pamela Dragosh [Thu, 28 Sep 2017 04:40:23 +0000 (04:40 +0000)]
Merge "Fix major sonar issues"
Pamela Dragosh [Thu, 28 Sep 2017 04:38:36 +0000 (04:38 +0000)]
Merge "Use MSB for service discovery"
Jorge Hernandez [Thu, 28 Sep 2017 03:51:49 +0000 (03:51 +0000)]
Merge "Fix major sonar issues"
Jorge Hernandez [Thu, 28 Sep 2017 02:51:54 +0000 (02:51 +0000)]
Merge "Add functionality for VFC request retries"
Jorge Hernandez [Thu, 28 Sep 2017 02:49:17 +0000 (02:49 +0000)]
Merge "Cleanup for VFC Actor code"
Jorge Hernandez [Wed, 27 Sep 2017 20:16:00 +0000 (20:16 +0000)]
Merge "Added @Override annotation to method signature"
Jorge Hernandez [Wed, 27 Sep 2017 17:54:23 +0000 (17:54 +0000)]
Merge "Create common object to consolidate AAI response"
Hockla, Ali (ah999m) [Wed, 27 Sep 2017 14:40:07 +0000 (09:40 -0500)]
Added changes for SO Request retries
This change will allow the control loop to increment the operation
attempts in the case of an SO failure in order to retry the
operation if defined in the yaml.
Issue-ID: POLICY-268
Change-Id: I1fee2ce64524e58fc3068f19c5cf31ed91159e0f
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
Ritu Sood [Wed, 27 Sep 2017 10:19:57 +0000 (03:19 -0700)]
Add functionality for VFC request retries
This allows the control loop to track operation
attempts in case of VFC failures. This will
allow retries of the operation if required in the
YAML file.
Issue-ID: POLICY-270
Change-Id: Ieeaf6770a8d03fa4eecc976535301d9236d19972
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Wed, 27 Sep 2017 09:47:57 +0000 (02:47 -0700)]
Cleanup for VFC Actor code
Fix some sonar critical issues and
other clean up
Issue-ID: POLICY-57
Change-Id: Iec9b94ff238ea6a65cfe39fd5cdfb200c773c1a9
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
shashikanth [Tue, 26 Sep 2017 10:41:41 +0000 (16:11 +0530)]
Fix major sonar issues
Fix major sonar issues in policy/drools-applications module
https://sonar.onap.org/component_issues?id=org.onap.policy.drools-applications%3Adrools-pdp-apps#resolved=false|severities=MAJOR|rules=squid%3AS1161
Added "@Override" annotation above this method signature.
Issue-Id:POLICY-239
Change-Id: I578d0e740a6c04ba02df400a3abc99f9b774908a
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Tue, 26 Sep 2017 10:22:47 +0000 (15:52 +0530)]
Added @Override annotation to method signature
Fix major sonar issues in policy/drools-applications module
https://sonar.onap.org/component_issues?id=org.onap.policy.drools-applications%3Adrools-pdp-apps#resolved=false|severities=MAJOR|rules=squid%3AS1161
Added the "@Override" annotation above this method signature.
Issue-Id:POLICY-239
Change-Id: Ibb71db82d78b0df02d5d6416ac3f3f00a3780695
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Tue, 26 Sep 2017 10:06:17 +0000 (15:36 +0530)]
Fix major sonar issues
Fix major sonar issues in policy/drools-applications module
https://sonar.onap.org/component_issues?id=org.onap.policy.drools-applications%3Adrools-pdp-apps#resolved=false|severities=MAJOR|rules=squid%3AS1132
Fixed string literal comparison for for SO and VF Module Create and few optimizations.
Issue-Id:POLICY-239
Change-Id: I8e228463ebc7f3114e5caba9b423552bb84dd52d
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Joseph Chou [Tue, 26 Sep 2017 19:55:47 +0000 (15:55 -0400)]
Create common object to consolidate AAI response
Remove duplicate/obsolete code (NQF199)
Change-Id: Ibe0d4d958a1fe5ae0bae93f740e8b32196a3b07b
Issue-ID: POLICY-228
Signed-off-by: Joseph Chou <jc2555@att.com>
daniel [Tue, 26 Sep 2017 21:21:02 +0000 (16:21 -0500)]
Fix Use Case Template
This is a WIP for getting guard to work. Currently
the A&AI GET and named queries are connecting to
the simulator and working in the labs. Guard is not
connecting to simulator and needs further analysis.
Issue-ID: POLICY-259
Change-Id: If9875bfd83cbd82dcae04a876b3818ec9c07b1f7
Signed-off-by: Daniel Cruz <dc443y@att.com>
Jorge Hernandez [Tue, 26 Sep 2017 19:50:03 +0000 (14:50 -0500)]
force maven dependency plugin version to latest
the 2.1 version that comes with the ubuntu installation
have problems with the maven repositoryUrls.
disable asserts in fact counts, it seems almost impossible
to get clean builds in jenkins server because these
junit failures.
Change-Id: I551f00a4a927f87a5e6294d936e9b9c926f21880
Issue-ID: POLICY-265
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Temoc Rodriguez [Tue, 26 Sep 2017 17:28:40 +0000 (10:28 -0700)]
Fix TestSO properties
TestSO was missing the environment properties for AAI and SO url, user,
and pass. Set SO and AAI properties in TestSO.java. If this is not set,
then the response will be null and the junit will fail. Moved setting
properties to Util.java to promote code reuse.
Issue-ID: POLICY-259
Change-Id: Id73611abab900675a1f2b543f71566baa05318b2
Signed-off-by: Temoc Rodriguez <cr056n@att.com>
wangxinyuan10113332 [Tue, 26 Sep 2017 03:01:49 +0000 (11:01 +0800)]
Use MSB for service discovery
Change-Id: I524946a1c352b5e9225b7fb37d35fa03a3f77e82
Issue-ID: POLICY-172
Signed-off-by: wangxinyuan10113332 <wang.xinyuan1@zte.com.cn>
Jorge Hernandez [Mon, 25 Sep 2017 22:39:40 +0000 (22:39 +0000)]
Merge "Create common object to consolidate AAI response"
Jorge Hernandez [Mon, 25 Sep 2017 21:25:04 +0000 (21:25 +0000)]
Merge "Fix Usecase Template for VoLTE"
daniel [Mon, 25 Sep 2017 20:50:33 +0000 (15:50 -0500)]
Fix Usecase Template for VoLTE
This includes VoLTE support for the amsterdam template.
As of right now all use cases are able to get a final
success with guard disabled and no A&AI GET queries.
Currently, the GET query is not working in the lab.
I will address this in another pull request.
Issue-ID: POLICY-259
Change-Id: I216aa84daaa1e93ab12c56ee53283b4cb413a7c3
Signed-off-by: Daniel Cruz<dc443y@att.com>
Jorge Hernandez [Mon, 25 Sep 2017 20:17:44 +0000 (15:17 -0500)]
override guard url when simulator feature enabled
Change-Id: I6af04238d043b95960a29484bcfbb08d2eab5b13
Issue-ID: POLICY-256
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Jorge Hernandez [Mon, 25 Sep 2017 19:42:02 +0000 (14:42 -0500)]
add guard simulator to pdp-d feature for labs
Change-Id: Id1852e55c3b03cf2c9e3800e40067806c6b9be5e
Issue-ID: POLICY-256
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Jorge Hernandez [Mon, 25 Sep 2017 17:16:04 +0000 (12:16 -0500)]
stand up amsterdam controller at initialization
Change-Id: I9bcbaf50e802fceb07c0db3bf13df8f8403a6dea
Issue-ID: POLICY-265
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Joseph Chou [Mon, 25 Sep 2017 17:11:51 +0000 (13:11 -0400)]
Create common object to consolidate AAI response
Add Junit test to improve sonar coverage
Change-Id: I32688dad756d2cba80559cd1d090e334ebf77aa3
Issue-ID: POLICY-228
Signed-off-by: Joseph Chou <jc2555@att.com>
Jorge Hernandez [Mon, 25 Sep 2017 16:36:08 +0000 (11:36 -0500)]
apps environment properties for pdp-x client auth
Change-Id: I23d2e8d16abe6ccbfda6f7d1a3e3d69b209d5b20
Issue-ID: POLICY-260
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Jorge Hernandez [Mon, 25 Sep 2017 14:04:40 +0000 (14:04 +0000)]
Merge "Added the Override annotation"
Jorge Hernandez [Mon, 25 Sep 2017 13:54:48 +0000 (13:54 +0000)]
Merge "Fix Blocker/Critical sonar issues"
rama-huawei [Mon, 25 Sep 2017 13:37:04 +0000 (19:07 +0530)]
Added the Override annotation
Added diamond symbol on RHS side
Change-Id: I3945e5f2217f74b71fa143b128f271e48b4882a7
Issue-ID: POLICY-239
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
Jorge Hernandez [Mon, 25 Sep 2017 13:16:03 +0000 (13:16 +0000)]
Merge "Added Override annotation"
Jorge Hernandez [Mon, 25 Sep 2017 13:15:32 +0000 (13:15 +0000)]
Merge "Added private constructor"
Jorge Hernandez [Mon, 25 Sep 2017 13:14:45 +0000 (13:14 +0000)]
Merge "Fix for Sonar major issues"
Jorge Hernandez [Mon, 25 Sep 2017 13:13:24 +0000 (13:13 +0000)]
Merge "Fix for Sonar major issues"
ramanjaneya [Mon, 25 Sep 2017 10:12:01 +0000 (15:42 +0530)]
Added Override annotation
Issue-ID: POLICY-239
Change-Id: Ia84e5656744289be52cf22b1b68d870a03b85404
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
ramanjaneya [Mon, 25 Sep 2017 10:25:29 +0000 (15:55 +0530)]
Added private constructor
Reorder the modifiers to comply with the Java Language Specification
Issue-ID: POLICY-239
Change-Id: I1c156dd420d27c45d496b07841f6375aec1b8de3
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
Pamela Dragosh [Fri, 22 Sep 2017 23:41:07 +0000 (23:41 +0000)]
Merge "Added private constructor"
Pamela Dragosh [Fri, 22 Sep 2017 22:30:27 +0000 (22:30 +0000)]
Merge "Add simple JUnit test for LCMResponse"
Pamela Dragosh [Fri, 22 Sep 2017 20:08:57 +0000 (16:08 -0400)]
Add simple JUnit test for LCMResponse
This covers all the methods
Issue-ID: POLICY-32
Change-Id: I6da6c54c257f6254f5116c99a64c02dbf0c77e05
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Fri, 22 Sep 2017 19:48:18 +0000 (19:48 +0000)]
Merge "Fix Use Case Testing"
ramanjaneya [Fri, 22 Sep 2017 11:51:58 +0000 (17:21 +0530)]
Added private constructor
Issue-ID: POLICY-239
Change-Id: I2ed90fc27c70ae03a772913bf3fefd28b692cec7
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
ramanjaneya [Fri, 22 Sep 2017 11:23:13 +0000 (16:53 +0530)]
Added private constructor
Issue-ID: POLICY-239
Change-Id: I261d3aa1b9f67c3e78e1016a84ed64924e306f43
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
daniel [Thu, 21 Sep 2017 19:29:07 +0000 (14:29 -0500)]
Fix Use Case Testing
These changes are necessary to get the use cases working
on an actual PDP. So far vCPE, vFW, and vDNS have been tested
successfully on a pdp. These are priliminary tests to just
test a FINAL SUCCESS without A&AI GET queries being used.
A&AI named queries for vFW and vDNS have been verified to
work.
Changes in the template were made for SO as there were
changes in the JUnit template that did not get reflected
in the archetype template.
Changes in the code were made in various places to use
the environment properties for REST urls, usernames, and
passwords. Due to VoLTE not being tested yet, the url
for VFC is still hard coded and will be changed later.
It has been confirmed with APPC that LCM will have two
topics: APPC-LCM-READ and APPC-LCM-WRITE. Policy needs
to sink to APPC-LCM-READ and pull from source
APPC-LCM-WRITE. This has been reflected in the controller
properties file.
Issue-ID: POLICY-259
Change-Id: Ib9a8df07ae5ad9d3052c88907c1e522952af474d
Signed-off-by: Daniel Cruz <dc443y@att.com>
Joseph Chou [Fri, 22 Sep 2017 15:37:03 +0000 (11:37 -0400)]
Create common object to consolidate AAI response
Create base object for AAI GET query
Change-Id: I874b10f89054d8adcc28b1e601e9ff15ee884784
Issue-ID: POLICY-228
Signed-off-by: Joseph Chou <jc2555@att.com>
Pamela Dragosh [Fri, 22 Sep 2017 15:08:34 +0000 (15:08 +0000)]
Merge "Add VFC Response in Working Memory & JUNIT"
Charles Cole [Thu, 21 Sep 2017 19:20:42 +0000 (14:20 -0500)]
Add guard simulator and multiple AAI responses
Added a guard simulator that can permit or deny (it sends a deny if the
clname is denyGuard). Added responses to the AAI simulator to set the
is-closed-loop-disabled to true (use a get query with a key of
disableClosedLoop). Changed the content-type of all responses to
application/json.
Issue-ID: POLICY-256
Change-Id: If84813968d3ea59d9ebe029caa69f444a1f413c8
Signed-off-by: Charles Cole <cc847m@att.com>
Jorge Hernandez [Thu, 21 Sep 2017 19:38:11 +0000 (19:38 +0000)]
Merge "ONAP AAI GET QUERY code to support ONAP project"
Joseph Chou [Tue, 19 Sep 2017 20:39:56 +0000 (16:39 -0400)]
ONAP AAI GET QUERY code to support ONAP project
check in code to use simulator url
Issue-ID: POLICY-103
Change-Id: I352140dd3cb3159fc2c5738bf02dbb6272de48bc
Signed-off-by: Joseph Chou <jc2555@att.com>
Jorge Hernandez [Thu, 21 Sep 2017 17:49:29 +0000 (17:49 +0000)]
Merge "Implement restful call to xacml pdp guard"
Jorge Hernandez [Thu, 21 Sep 2017 17:30:13 +0000 (17:30 +0000)]
Merge "Upgrade to oparent release version"
Jorge Hernandez [Thu, 21 Sep 2017 04:12:27 +0000 (23:12 -0500)]
pdp-d feature to simulate aai/mso/vfc in lab
implemented as an optional loadable feature, this
capability enables to bring up simulators used by
junits in a pdp-d lab configuration.
After lab installation, perform:
1. features enable controlloop-util
2. policy start
Now the simulators are opened at ports 6666, 6667, and 6668.
netstat output:
tcp6 0 0 127.0.0.1:6666 :::* LISTEN 21562/java
tcp6 0 0 127.0.0.1:6667 :::* LISTEN 21562/java
tcp6 0 0 127.0.0.1:6668 :::* LISTEN 21562/java
21562 is the pdp-d PID in the lab.
curl http://localhost:6666/aai/v11/network/generic-vnfs/generic-vnf/vnfIdA
{ "vnf-id": "
5e49ca06-2972-4532-9ed4-
6d071588d792", ... }
Change-Id: I3f05333ce5549b2274eb967b2b8866189b7f8843
Issue-ID: POLICY-259
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Pamela Dragosh [Thu, 21 Sep 2017 15:23:35 +0000 (11:23 -0400)]
Upgrade to oparent release version
Following independent release and versioning process guidelines.
Issue-ID: POLICY-225
Change-Id: If679e4002690bb7614c72fb846c383eb265fb2e0
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Temoc Rodriguez [Tue, 19 Sep 2017 18:13:34 +0000 (11:13 -0700)]
Implement restful call to xacml pdp guard
Removed the embedded guard decision and replace with restful call to
xacml pdp to restore guard functionality. Set guard URL with PolicyEngine env properties. Modified templates accordingly.
Issue-Id: POLICY-260
Change-Id: Ic1558a6ebdd5f6d1b74a748f69433f6213dbf984
Signed-off-by: Temoc Rodriguez <cr056n@att.com>
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
Ritu Sood [Mon, 11 Sep 2017 21:20:13 +0000 (14:20 -0700)]
Add VFC Response in Working Memory & JUNIT
Adding code to insert VFC reponse in working
memory and handling that response. Also adding
JUNIT and yaml file for VoLTE usecase.
Issue-Id: POLICY-212
Change-Id: I74a13272ccd931478d27d80715d8c3ac756fb5c7
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Jorge Hernandez [Wed, 20 Sep 2017 21:06:10 +0000 (21:06 +0000)]
Merge "Fix for Sonar major issues"
SwapnilPathak [Wed, 20 Sep 2017 12:17:33 +0000 (17:47 +0530)]
Fix for Sonar major issues
Add override annotation above the method signature.
Issue-ID: POLICY-248
Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab556ae9
Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
SwapnilPathak [Wed, 20 Sep 2017 12:00:07 +0000 (17:30 +0530)]
Fix for Sonar major issues
Move the String literal on left side of string comparison.
Issue-ID: POLICY-249
Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab555ae9
Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
Pamela Dragosh [Wed, 20 Sep 2017 11:20:28 +0000 (11:20 +0000)]
Merge "Fixing VFC simulator for junit tests"
Pamela Dragosh [Wed, 20 Sep 2017 10:54:52 +0000 (10:54 +0000)]
Merge "Fix Major sonar issues"
SwapnilPathak [Wed, 20 Sep 2017 07:34:50 +0000 (13:04 +0530)]
Fix for Sonar major issues
Add override annotation above the method signature.
Issue-ID: POLICY-248
Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab453ae9
Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>
shashikanth [Tue, 19 Sep 2017 08:39:45 +0000 (14:09 +0530)]
Fix Major sonar issues
Fix Major sonar issues in policy/drools-applications module
https://sonar.onap.org/component_issues?id=org.onap.policy.drools-applications%3Adrools-pdp-apps#resolved=false|severities=MAJOR
Add the "@Override" annotation above this method signature
"value" is already a string, there's no need to call "toString()" on it
Issue-Id:POLICY-239
Change-Id: Ia64ac87c13d88c5d961b943e0b2286b273bd4831
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Jorge Hernandez [Wed, 20 Sep 2017 00:55:42 +0000 (19:55 -0500)]
test tooling to generate vcpe use case in lab
run successully vcpe case in lab in 2 steps:
1. docker-install load
2. run create-cl-amsterdam (with defaults)
3. injecting dcae.onset and appc.success packaged
with archetypes
Change-Id: Idb20c0078228da962510dbf36dae96aceb43546c
Issue-ID: POLICY-162
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Jorge Hernandez [Tue, 19 Sep 2017 19:11:51 +0000 (19:11 +0000)]
Merge "Adding reading service-id from AA&I"
Jorge Hernandez [Tue, 19 Sep 2017 14:09:05 +0000 (09:09 -0500)]
enhancements to archetype and apps packaging
Change-Id: I3e659d35d3cb397c011657f39ef12b10b0564fc9
Issue-ID: POLICY-162
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Pamela Dragosh [Tue, 19 Sep 2017 13:03:19 +0000 (09:03 -0400)]
Remove sonar blocker and unused import
Remove the 3 sonar blockers and unused import in AAI code.
Issue-ID: POLICY-111
Change-Id: I73001a06810ecff3f22da627583a0238c4a09967
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
shashikanth [Tue, 19 Sep 2017 09:27:58 +0000 (14:57 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in policy/drools-applications module
https://sonar.onap.org/component_issues?id=org.onap.policy.drools-applications%3Adrools-pdp-apps#resolved=false|severities=CRITICAL%2CMAJOR
Fixed 2 issues,
Used isEmpty() to check whether the collection is empty or not.
getActor returns a string, there's no need to call toString()
Issue-Id:POLICY-111
Change-Id: I645420ee370ceb5fca959f870e76db2390e19929
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Jorge Hernandez [Mon, 18 Sep 2017 16:26:58 +0000 (11:26 -0500)]
Inherit guard install env properties for cl.
Clean up a few "mso" references.
Disable 1.0.0 template build for now (note that some
references are still pointing to old mso).
Ie., see
https://git.onap.org/policy/drools-applications/tree/controlloop
/templates/template.demo.v1.0.0/template.demo
/src/test/java/org/onap/policy/template/demo/TestSO.java
Since this
is going away, rather than maintaining it, and changing this
code, disabling it for the build.
It will be deleted within the next few days.
Issue-ID: POLICY-162
Change-Id: Ibb819a318fbbb2b7f3aa14cdf76155bdec321024
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Jorge Hernandez [Mon, 18 Sep 2017 13:52:01 +0000 (13:52 +0000)]
Merge "Fix sonar critical"
Ritu Sood [Mon, 18 Sep 2017 10:01:54 +0000 (03:01 -0700)]
Fixing VFC simulator for junit tests
Added response type to post and removed
response id as it is unused.
Breaking up from the junit patch for ease of
review.
Issue-id: POLICY-212
Change-Id: I0c6b0c02b240cfe81246587184fe6a589dcc2367
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Ritu Sood [Sun, 17 Sep 2017 22:34:16 +0000 (15:34 -0700)]
Adding reading service-id from AA&I
For VFC adding getting service-id from AA&I.
Issue-Id: POLICY-57
Change-Id: I740c7749bfb2d395851cbd5eb3e486bf4eb9b560
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Pamela Dragosh [Fri, 15 Sep 2017 21:05:44 +0000 (17:05 -0400)]
Fix sonar critical
Last transient/serializable issues.
Throw a dedicated exception for DateUtil class
Unused imports
Make the enclosing method "static" or remove this set.
Issue-ID: POLICY-115
Change-Id: I366f85922c4d4d290b320e0b88678c805de59872
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Fri, 15 Sep 2017 19:47:25 +0000 (19:47 +0000)]
Merge "ONAP AAI GET Query code"
Jorge Hernandez [Fri, 15 Sep 2017 18:58:52 +0000 (18:58 +0000)]
Merge "Fix sonar criticals"
Joseph Chou [Wed, 13 Sep 2017 21:15:49 +0000 (17:15 -0400)]
ONAP AAI GET Query code
Update ControlLoopEventManager to raise exception on null AAI response
Issue-ID: POLICY-103
Change-Id: Iebe8b03269a1801c4293600920aa267490cea1af
Signed-off-by: Joseph Chou <jc2555@att.com>
Pamela Dragosh [Fri, 15 Sep 2017 15:41:47 +0000 (11:41 -0400)]
Fix sonar criticals
Either re-interrupt this method or rethrow Exception
Transient/Serializable issues
Unused imports
logging exceptions
Issue-ID: POLICY-115
Change-Id: I4c8a0c780e2f6c6e8218c1457f18470f7d95919c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Hockla, Ali (ah999m) [Fri, 15 Sep 2017 17:17:37 +0000 (12:17 -0500)]
Master lab template changes for MSO rename to SO
Issue-ID: POLICY-162
Change-Id: Ieb0952379cd854e0ed8e4a3b068b7e29f3b93770
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
Pamela Dragosh [Fri, 15 Sep 2017 16:42:40 +0000 (16:42 +0000)]
Merge "Modify AAI simulator to support new requests"
Charles Cole [Wed, 13 Sep 2017 16:00:21 +0000 (11:00 -0500)]
Modify AAI simulator to support new requests
Updated the AAI simulator to support new AAI queries. Also, modified
the post response to allow multiple responses. Added code to ensure the
simulators were able to sucessfully start up.
Change-Id: I3e855b5e54c073f55fbaadc0064c140695fc1a58
Issue-ID: POLICY-200
Signed-off-by: Charles Cole <cc847m@att.com>
Pamela Dragosh [Thu, 14 Sep 2017 22:00:36 +0000 (18:00 -0400)]
Clear eclipse warnings and sonar
Removing warnings introduced with A&AI code. This should also
address sonar criticals and majors.
Issue-ID: POLICY-140
Change-Id: I3f8186dd9c5aa52bfbb061bf95d67b5614b3fb2e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Thu, 14 Sep 2017 21:35:26 +0000 (21:35 +0000)]
Merge "Move credential information out of persistence.xml"
Jorge Hernandez [Thu, 14 Sep 2017 21:30:58 +0000 (21:30 +0000)]
Merge "master lab template maintained under archetype"
Jorge Hernandez [Thu, 14 Sep 2017 06:55:30 +0000 (01:55 -0500)]
master lab template maintained under archetype
This is work in progress, the official pom.xml with dependencies,
drl template, and support files for controller deployment
are maintained here. In the near future the junit template
should be consolidated with this one.
Added controlloop.properties.environment, this environment file
will be populated at installation time with the lab's aai url,
etc .. and will be accessible by any drools application such as
control loops through the PolicyEngine interface. Note that PDP-D
server already supports these environment files, so it is just natural.
Therefore, this is the default mechanism to provide to applications, the url, username,
and passwords to use at runtime by the control loops for the time being.
In the future MSB could set them globally here through existing APIs,
or it can be queried by any drools application using MSB library,
doesn't matter.
There's been some trouble playing nicely with the dependencies used
by a control loop application classsloader, and the pdp-d middleware one,
causing issues between dependencies version of libraries. Specifically,
the snakeyaml library does not play well across classloader when using
constructor functionality, note that the snakeyaml libraries are pulled
also from jackson parsers used in the pdp-d. I made a change in ControlLoopProcessor
to specifically tell the "Yaml" object which classloader to use in order to
find the class with the constructor that is intended to be built, otherwise,
yaml libraries use a different classloader that does not have visibility
into the ControlLoopPolicy that is trying to construct, and fails. This also
should respect junits that use the same classloader I pressume and does not
give issues.
Change-Id: I36271d29cdbf8ff861f9c03ff91cf7116927906a
Issue-ID: POLICY-162
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Temoc Rodriguez [Wed, 13 Sep 2017 19:23:46 +0000 (12:23 -0700)]
Move credential information out of persistence.xml
Move credential information out of persistence.xml. Define properties
file which will contain the credentials instead. Access db using new
properties file.
Issue-ID: POLICY-55
Change-Id: I01ad0611c053ad4285de2a225fca7920a3b1bc8f
Signed-off-by: Temoc Rodriguez <cr056n@att.com>
Jorge Hernandez [Thu, 14 Sep 2017 18:26:20 +0000 (18:26 +0000)]
Merge "Added changes for vDNS Use Case"
Hockla, Ali (ah999m) [Wed, 13 Sep 2017 14:24:43 +0000 (09:24 -0500)]
Added changes for vDNS Use Case
-Renamed remaining MSO classes and packages to SO and modified drl
accordingly
-Connected SO Interface to SO Simulator
-Added vDNS Control Loop junit
-Modified SOActorServiceProvider to reflect AAI class changes (POLICY-103)
Issue-ID: POLICY-102
Change-Id: Iea5d3f096c4ccfedde68e79d7593d66331127aaf
Signed-off-by: Hockla, Ali (ah999m) <ah999m@att.com>
daniel [Wed, 13 Sep 2017 16:49:12 +0000 (11:49 -0500)]
Fix AAINQF199 object references to AAINQ objects
This is a small change to now reference the new AAI model
instead of using the older AAINQF199 model.
Issue-ID: POLICY-104
Change-Id: I2a1d2830fbd3bd7d62a9e27067a8c32a1c1ab4b1
Signed-off-by: daniel <dc443y@att.com>
Jorge Hernandez [Wed, 13 Sep 2017 13:59:58 +0000 (13:59 +0000)]
Merge "Fix A&AI Named Query for vFW"
Jorge Hernandez [Wed, 13 Sep 2017 13:58:47 +0000 (13:58 +0000)]
Merge "ONAP code for AAI, consolidate name and get query"
daniel [Tue, 12 Sep 2017 14:44:59 +0000 (09:44 -0500)]
Fix A&AI Named Query for vFW
The vFW named query has now been verified with the
A&AI simulator. Null checks were added to make the
namedQuery method work properly. In addition, a
recursive A&AI response parser was added to traverse
the response to find the correct generic-vnf object
with the target vnf-id.
For now the simulator URL is hard coded and the UUID
of the named query is hard coded. These should be
configurable in future releases.
Issue-ID: POLICY-104
Change-Id: I05a1a992ff68ca2c17fb6a578983e6b21626bf44
Signed-off-by: Daniel Cruz <dc443y@att.com>
Joseph Chou [Wed, 6 Sep 2017 20:54:33 +0000 (16:54 -0400)]
ONAP code for AAI, consolidate name and get query
Adding AAI GET query feature to support ONAP project (1 commit)
Issue-ID: POLICY-103
Change-Id: I0a55f41c3edd7a0bc0562ae4e12a19f262a50d74
Signed-off-by: Joseph Chou <jc2555@att.com>