sourabh_sourabh [Tue, 11 Jun 2024 07:56:54 +0000 (08:56 +0100)]
#2: Used async version of web client for single cm handle read operation
- Code change is done to use async web client for single cm handle
read data operation.
- CpsNcmpTaskExecutor class and groovy test code is removed.
- Use of supplier code is removed from cm handle Query service.
Issue-ID:CPS-2259
Change-Id: I2b7a36e8a151a9224937afd876fceb30be6a24ce
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
sourabh_sourabh [Fri, 7 Jun 2024 18:10:45 +0000 (19:10 +0100)]
#1: Used async version of web client for batch read operation
- Exposed async version of post method into dmi rest client.
- Code change is done to use async web client for batch data
operation.
- Use of CpsNcmpTaskExecutor code is removed.
Issue-ID: CPS-2174
Change-Id: I7840fd8c6d9debe42e50c860f9cf39d64274df72
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Lee Anjella Macabuhay [Mon, 10 Jun 2024 08:31:59 +0000 (08:31 +0000)]
Merge "[k6] Refactor k6 tests for CM handle searches"
Lee Anjella Macabuhay [Thu, 6 Jun 2024 20:01:42 +0000 (20:01 +0000)]
Merge "Cm Subscription: Predicates optional now"
danielhanrahan [Thu, 6 Jun 2024 19:43:21 +0000 (20:43 +0100)]
[k6] Refactor k6 tests for CM handle searches
A cleanup of the k6 tests to avoid code duplication
Issue-ID: CPS-2208
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If1e58ee87300cd28ed72b365d9a86e2709dc6c13
sourabh_sourabh [Mon, 27 May 2024 17:28:10 +0000 (18:28 +0100)]
#1: Dedicated web client instance is assigned for data, model and health services
- Switched web client instance based on dmi service type (like data or model)
- 3 diff. beans are configured for data, model and health dmi service.
- Added configurable properties for data and model.
- Hard coded properties are assigned for health service.
Issue-ID: CPS-2231
Change-Id: I39fb739c07c41430dae43509fe29ece5306b7d71
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
mpriyank [Thu, 6 Jun 2024 10:47:46 +0000 (11:47 +0100)]
Cm Subscription: Predicates optional now
- making the predicates sectional OPTIONAL as the schemas are common for
both create and delete use case and we dont have the need to send in
the predicates information for DELETE use case.
- Delete is done based on the incoming subscriptionId only
Issue-ID: CPS-2252
Change-Id: I43ec480821a6088c5fa161480ce2b29b660a2ba5
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Arpit Singh [Thu, 7 Sep 2023 11:35:37 +0000 (17:05 +0530)]
CPS Delta API 2: Delta between anchor and payload
- Second API to get Delta between an anchor and JSON payload
- added new API getDeltaByDataspaceAnchorAndPayload
- added controller and service layer methods
getDeltaByDataspaceAnchorAndPayload
- Core Delta algorithm remains same as the first API.
getDeltaByDataspaceAnchorAndPayload will call getDeltaBetweenDataNodes
Issue-ID: CPS-1836
Signed-off-by: Arpit Singh <as00745003@techmahindra.com>
Change-Id: Id74cd930ce48e5cb414aa62c5381b79675788a37
Toine Siebelink [Thu, 6 Jun 2024 08:16:39 +0000 (08:16 +0000)]
Merge "Change ApplicationEvent for ModelLoading"
Rudrangi Anupriya [Wed, 5 Jun 2024 18:25:14 +0000 (23:55 +0530)]
XML content support on update node leaves
Issue-ID: CPS-2071
Change-Id: Ibe7f59fbfcbb03703626132c6d5c2afde0e7ab4b
Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
mpriyank [Tue, 7 May 2024 12:57:48 +0000 (13:57 +0100)]
Change ApplicationEvent for ModelLoading
- Application to use ApplicationStartedEvent as the trigger to start the
ModelLoading process instead of ApplicationReadyEvent
- Modified the testware to reflect the same
Issue-ID: CPS-2211
Change-Id: I3176b6373f585ec1915c3d43c553e233660225f5
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Priyank Maheshwari [Wed, 5 Jun 2024 08:20:20 +0000 (08:20 +0000)]
Merge "CM SUBSCRIPTION: Add delete use case #2 (DMI-NCMP)"
Toine Siebelink [Wed, 5 Jun 2024 07:11:05 +0000 (07:11 +0000)]
Merge "Added OpenTelemetry to CPS"
Priyank Maheshwari [Tue, 4 Jun 2024 15:10:48 +0000 (15:10 +0000)]
Merge "CM SUBSCRIPTION: Add delete use case #1 (Client-NCMP)"
david.mcweeney [Thu, 25 Apr 2024 13:37:33 +0000 (14:37 +0100)]
Added OpenTelemetry to CPS
Change-Id: I192fa53e293ea43cdff92ebd44d0382eb290bb76
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2172
emaclee [Thu, 30 May 2024 05:48:23 +0000 (06:48 +0100)]
CM SUBSCRIPTION: Add delete use case #2 (DMI-NCMP)
Issue-ID: CPS-2241
Change-Id: I218c46e9c16cc78025450494f5019bde1f351a40
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
emaclee [Thu, 30 May 2024 05:33:51 +0000 (06:33 +0100)]
CM SUBSCRIPTION: Add delete use case #1 (Client-NCMP)
Issue-ID: CPS-2241
Change-Id: Idd074ff4d29cf11f45f1c69200788b2f39b49e74
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
mpriyank [Fri, 31 May 2024 08:46:11 +0000 (09:46 +0100)]
CM SUBSCRIPTION: Update schemas
- updated the cm subscription schemas with proper case as agreed before
for the events
- fixed the tests to reflect the camelCase change
Issue-ID: CPS-2245
Change-Id: I64fb8b27a5f64280dfa19d86ae310e6b5309de39
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
ToineSiebelink [Mon, 27 May 2024 14:02:35 +0000 (15:02 +0100)]
Simplify Code around building DMI URLs
- Bug analysis showed some unclear and complicated code for building URLs
- This patch is to clean up the related code and show more clearly what is encoded and what is not
- Use SPringBoot provided builder to apply correct encoding of all URI parts
- DmiOperations base class no longer need as no common code model and data operations anymore
- Converted builder to POJO (client needs to provide the only dmi properties upon build)
- Added some missing test (in affected code) to increase coverage percntage
(as the production code has significantly reduced in size the overal coverage was inadvertently reduced below the treshold)
- Added more unit test. Now impl.operations' package has 100%
- removed the test fro Dmi Exception that was incorrectly callign the handleException methdod directly instead of mocking an exception
it was really a dupclicate of a test I added but I was able to re-use the event checkign in my test
Issue-ID: CPS-2246
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I1ff196cd03bbb95f5877ee590c321febeb672800
Sourabh Sourabh [Wed, 29 May 2024 14:14:37 +0000 (14:14 +0000)]
Merge "CPS-2187 - Move Module Set Tag into request body for dmi data access passthrough calls"
david.mcweeney [Tue, 28 May 2024 11:48:38 +0000 (12:48 +0100)]
CPS-2187 - Move Module Set Tag into request body for dmi data access passthrough calls
Change-Id: I9c807d2ef5b3712bf3f8ee5db7663d9628eef3bb
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2187
danielhanrahan [Tue, 28 May 2024 17:28:32 +0000 (18:28 +0100)]
Adjust K6 thresholds
- Adjust timings based on previous runs.
- Reduce from 5 to 4 parallel clients for CM handle searches
to avoid OutOfMemoryErrors.
Issue-ID: CPS-2208
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I339cc3df84b2295bb11371ab73b4948f43615c15
leventecsanyi [Thu, 23 May 2024 14:40:13 +0000 (16:40 +0200)]
Restructure(package) DataJobs feature in NCMP Service
- restructured already existing classes
- added testware for AlternateIdMatcher
Issue-ID: CPS 2240
Change-Id: I5691ed99627353903689cd2929163f77ed8c4eca
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Lee Anjella Macabuhay [Tue, 28 May 2024 11:30:04 +0000 (11:30 +0000)]
Merge "CmDataSubscription status code update"
Daniel Hanrahan [Tue, 28 May 2024 10:16:20 +0000 (10:16 +0000)]
Merge "Print summary report for K6 tests"
halil.cakal [Mon, 27 May 2024 15:06:59 +0000 (16:06 +0100)]
Print summary report for K6 tests
- add a generic template to print summary of k6 test results
- remove container logs since its around 50 mb
Issue-ID: CPS-2215
Change-Id: I8971fc30b9dc8be2ed16eda6755d17a91f608b48
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Signed-off-by: halil.cakal <halil.cakal@est.tech>
mpriyank [Mon, 27 May 2024 12:33:36 +0000 (13:33 +0100)]
CmDataSubscription status code update
- Removing the unused NcmpRespnseStatus internal codes and messages
- Introducing statusCode 1 for ACCEPTED and 104 for REJECTED of
CmSubscription
- Added check for status code and message both in the flow
Issue-ID: CPS-2238
Change-Id: Id99f099a398392dbef1504f9d7c658665d163902
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
mpriyank [Fri, 24 May 2024 10:38:06 +0000 (11:38 +0100)]
CmSubscription overlapping case
- Directly ACCEPT the CmSubscription request in case of overlapping
scenario
- The confirmation will be sent out when the DMI timeout has happened
- No request sent out to DMI plugin in this scenario
Issue-ID: CPS-2237
Change-Id: Ic799801058e9c8e1c2db8780a42ab85ea306f45e
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Priyank Maheshwari [Thu, 23 May 2024 15:29:37 +0000 (15:29 +0000)]
Merge "CM SUBSCRIPTION: add new subscription for non existing xpath"
Lee Anjella Macabuhay [Thu, 23 May 2024 14:36:15 +0000 (14:36 +0000)]
Merge "Add k6 performance tests for NCMP"
Toine Siebelink [Thu, 23 May 2024 12:26:32 +0000 (12:26 +0000)]
Merge "Remove un-used code of RestTemplate"
emaclee [Mon, 20 May 2024 07:54:44 +0000 (08:54 +0100)]
CM SUBSCRIPTION: add new subscription for non existing xpath
- added new method for when adding new subscription for non
existing xpath but existing cmhandle
Issue-ID: CPS-2207
Change-Id: I149fbaea2f276503cb9d45c8807519bbe0417f3b
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
danielhanrahan [Mon, 29 Apr 2024 15:16:42 +0000 (16:16 +0100)]
Add k6 performance tests for NCMP
This commit adds K6 tests for NCMP functionalities:
- Registration of 20000 CM-handles
- Synchronous single CM-handle passthrough read operation
- CM-handle and ID searches for no filter, module, and public property
- De-registration of 20000 CM-handles
- A mixed load test
Also includes a README and shell scripts to run all tests.
Issue-ID: CPS-2199
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ia2e59674057ed28f5f9ceed9465133f7c0ce8318
sourabh_sourabh [Tue, 21 May 2024 11:16:43 +0000 (12:16 +0100)]
Remove un-used code of RestTemplate
- Removed unused property belons to resttemplate
- Refactored dmi properties class (from static internal class)
- Overriden getter method of dmi basepath that removes any leading and trailing slashes from it.
Issue-ID: CPS-2202
Change-Id: I16f61388fce2a6b9e258788fa826d485581d6138
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
ToineSiebelink [Wed, 22 May 2024 11:05:24 +0000 (12:05 +0100)]
Remove allowReserved from Swagger definitions for CPS & NCMP
- this option was used on some URL parameters (by accident)
- does not seem to affect production code but is at least misleading
Issue-ID: CPS-2230
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I32712a840346715f4891304c2059d49f10e959d6
Toine Siebelink [Wed, 22 May 2024 10:40:38 +0000 (10:40 +0000)]
Merge "re-enable Operation Too Large Exception: limit 200"
Lee Anjella Macabuhay [Wed, 22 May 2024 09:40:13 +0000 (09:40 +0000)]
Merge "Fix performance build output being lost"
ToineSiebelink [Wed, 22 May 2024 08:41:55 +0000 (09:41 +0100)]
re-enable Operation Too Large Exception: limit 200
- settign limit to 200
Issue-ID:CPS-2164
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I728af7658e3f4e0900f286a544dea3bdb5d6773f
halil.cakal [Mon, 20 May 2024 14:10:45 +0000 (15:10 +0100)]
Fix performance build output being lost
- this fix for CpsPath Registry attributes Query plot
- also include bump up lombok to latest to fix the error
does not have member field
com.sun.tools.javac.tree.JCTree qualid
- rename conflicting the performance
test name: CpsPath Registry attributes Query to fix plot issue
Issue-ID: CPS-2232
Change-Id: I7a0536ac2b48565df62fa46dddd27785addafa42
Signed-off-by: halil.cakal <halil.cakal@est.tech>
david.mcweeney [Wed, 8 May 2024 14:11:12 +0000 (15:11 +0100)]
CPS-2182 - #4 Add module Set tag to NCMPs DMI Batch Data interface
Change-Id: I46b261e0a0ef2d37a307291931ba67762fb7767d
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2182
Toine Siebelink [Mon, 20 May 2024 08:46:02 +0000 (08:46 +0000)]
Merge "CPS-2187 - #6 Add module Set Tag to ncmp (single cm handle) data request to dmi"
Lee Anjella Macabuhay [Mon, 20 May 2024 08:26:25 +0000 (08:26 +0000)]
Merge "CmSubscription topics param update"
sourabh_sourabh [Tue, 7 May 2024 11:31:44 +0000 (12:31 +0100)]
Replaced RestTemplate with WebClient in synchronous DMI calls
- added DmiWebClientConfiguration
- use WebClient in DmiRestClient
- fixed unit tests
- encode query params for DMI request
- added configurable buffer size
- Re-used ncmp.dmi.httpclient.maximumConnectionsTotal parameter
(as documented in RTD) to control webclient connection poolsize
Issue-ID: CPS-2173
Change-Id: I21584563034d58e8ae3ff3cbcf172e0d14b408fb
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
mpriyank [Thu, 16 May 2024 15:35:49 +0000 (16:35 +0100)]
CmSubscription topics param update
- topic application parameters updated to be in sync with the actual
convention we are following for the flow.
- environment variables also updated to follow the same
- removed the unused parameters related to notification
Issue-ID: CPS-2210
Change-Id: If5adb3dac1ce81df5afe2e99f99513adc2011cc9
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
ToineSiebelink [Thu, 16 May 2024 14:33:16 +0000 (15:33 +0100)]
Set CPS Project Status to 'Mature'
As approved by TSC on 2024-05-16
See also https://wiki.onap.org/display/DW/ONAP+Project+and+Component+Lifecycle
Issue-ID: CPS-2224
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I60933c208a98adb65cf68e7fdc352839846a772c
Toine Siebelink [Thu, 16 May 2024 13:42:27 +0000 (13:42 +0000)]
Merge "Integration for getting cm handle by longest alternate id match"
david.mcweeney [Wed, 15 May 2024 15:35:48 +0000 (16:35 +0100)]
CPS-2187 - #6 Add module Set Tag to ncmp (single cm handle) data request to dmi
Change-Id: I59cdb021d8f2f767b943f09715f4becad820e786
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2187
Toine Siebelink [Thu, 16 May 2024 08:18:10 +0000 (08:18 +0000)]
Merge "CPS-2181 - #1 Included Module Set Tag in NCMP calls to DMI for Yang Module Resources"
Toine Siebelink [Wed, 15 May 2024 14:34:52 +0000 (14:34 +0000)]
Merge "More fine tuning around remainin plots"
halil.cakal [Wed, 15 May 2024 13:50:33 +0000 (14:50 +0100)]
More fine tuning around remainin plots
- Fine tuning for the plots only:
- Read datatrees for multiple xpaths
- Query with all descendants
- Writing 200 devices
- Saving list of 50 devices
Issue-ID: CPS-2192
Change-Id: I508e31cd861a4006cac41ebbbe307b7bd2acde2f
Signed-off-by: halil.cakal <halil.cakal@est.tech>
david.mcweeney [Wed, 1 May 2024 11:08:00 +0000 (12:08 +0100)]
CPS-2181 - #1 Included Module Set Tag in NCMP calls to DMI for Yang Module Resources
Change-Id: I4f8cf79667e3155f49b9109d26b5807f5d54f90c
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2181
sourabh_sourabh [Thu, 2 May 2024 15:46:21 +0000 (16:46 +0100)]
Integration for getting cm handle by longest alternate id match
- Added a new integration test to check total time and memory taken to
get cm handle by its longest match alternate id.
Issue-ID: CPS-2176
Change-Id: I7a6b299c46803a0878406f1e16fdae970b361dd9
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
mpriyank [Wed, 15 May 2024 09:39:02 +0000 (10:39 +0100)]
Bump CPS to 3.5.0-SNAPSHOT
- bump cps to 3.5.0-SNAPSHOT
Issue-ID: CPS-2228
Change-Id: I8a6d7e702b557d5b90dd384bbe429de4958ef77f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Daniel Hanrahan [Tue, 14 May 2024 12:25:36 +0000 (12:25 +0000)]
Merge "CPS Bump to 3.4.10-SNAPSHOT"
Toine Siebelink [Tue, 14 May 2024 11:51:10 +0000 (11:51 +0000)]
Merge "Adjust percentage limits to 10 percent below the threshold"
mpriyank [Tue, 14 May 2024 09:09:55 +0000 (10:09 +0100)]
CPS Bump to 3.4.10-SNAPSHOT
- bumping CPS to 3.4.10-SNAPSHOT version
Issue-ID: CPS-2221
Change-Id: I8513582791078762bfb9d828966028c233e031db
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Daniel Hanrahan [Tue, 14 May 2024 08:59:23 +0000 (08:59 +0000)]
Merge "container yaml for cps 3.4.9"
mpriyank [Mon, 13 May 2024 17:28:53 +0000 (18:28 +0100)]
container yaml for cps 3.4.9
- container yaml to release CPS 3.4.9
Issue-ID: CPS-2221
Change-Id: I8dee6c42230f38c7a1fdf1dc7821e71c5da2af06
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
mpriyank [Mon, 13 May 2024 17:22:14 +0000 (18:22 +0100)]
Maven stage yaml for CPS 3.4.9
- maven stage yaml to release CPS 3.4.9
Issue-ID: CPS-2221
Change-Id: Ifc16ed01cc4d7928d5f9ec86ebe668ab26285584
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
halil.cakal [Mon, 13 May 2024 12:43:55 +0000 (13:43 +0100)]
Adjust percentage limits to 10 percent below the threshold
Issue-ID: CPS-2192
Change-Id: Iac37751b17f186e550ce12e3e17968d90cbf432a
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Daniel Hanrahan [Fri, 10 May 2024 13:22:05 +0000 (13:22 +0000)]
Merge "Ncmp out event for REJECTED scenario"
mpriyank [Thu, 9 May 2024 15:04:40 +0000 (16:04 +0100)]
Ncmp out event for REJECTED scenario
- Handling and publishing the event to client when dmi plugin rejects
applying the subscription
- test scenarios to support the same
Issue-ID: CPS-2214
Change-Id: I2ac6d125a7262a7428a962d81a26a33594b570d9
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
halil.cakal [Thu, 9 May 2024 14:24:46 +0000 (15:24 +0100)]
Fine tuning of the performance plots
- Fine tune some of the performance plots which are
not align to the limit
Issue-ID: CPS-2200
Change-Id: I925443aa74a4eb814728d0642db0951c76f86186
Signed-off-by: halil.cakal <halil.cakal@est.tech>
mpriyank [Thu, 9 May 2024 10:46:09 +0000 (11:46 +0100)]
Release note for cps-change-event toggle
- Release notes to enable and disable the toggle functionality
introduced.
- If the CPS change events are of no interest to them then they can be
disabled by the environment variable CPS_CHANGE_EVENT_NOTIFICATIONS_ENABLED
Issue-ID: CPS-2211
Change-Id: If2fddb6a499e24194b3eeca2ecdf99b8fb5ec687
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
mpriyank [Tue, 7 May 2024 14:33:19 +0000 (15:33 +0100)]
Conditional cps change events
- introduced a parameter to control the cps core change event
notifications. we should be able to disable these notifications
without affecting other notification flows.
- fixed the LayeredArchitectureTest as we are accessing the Anchor model
in the events package now.
Issue-ID: CPS-2213
Change-Id: Id875925bc14de1cc6e8fa3193c0df470e09fe43f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Lee Anjella Macabuhay [Tue, 7 May 2024 09:57:09 +0000 (09:57 +0000)]
Merge "Schedule response to client"
Lee Anjella Macabuhay [Fri, 3 May 2024 14:55:32 +0000 (14:55 +0000)]
Merge "[BUG] Correctly parse observedTimestamp"
mpriyank [Fri, 3 May 2024 12:45:03 +0000 (13:45 +0100)]
[BUG] Correctly parse observedTimestamp
- Using the DateTimeUtility to parse the passed OffsetDateTime and using
it for conversion to string
- Moving to actual src/main/java from test side as it is to be used in
the prod code as well and only keeping the methods in use.
- Added test to fix the coverage issue
Issue-ID: CPS-2211
Change-Id: I2b4325bb77a6da7fd470986b1da293f455650375
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Priyank Maheshwari [Fri, 3 May 2024 13:13:36 +0000 (13:13 +0000)]
Merge "Release notes is updated for error hanndling related to upgrade operation"
sourabh_sourabh [Fri, 3 May 2024 12:10:36 +0000 (13:10 +0100)]
Release notes is updated for error hanndling related to upgrade
operation
Issue-ID: CPS-2204
Change-Id: Iaa3f61c53e4120cdf19b7ad1c3313fc32f904866
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
sourabh_sourabh [Thu, 2 May 2024 09:26:16 +0000 (10:26 +0100)]
Make NCMP integration tests use MockWebServer
Change from using MockRestServiceServer - which is only compatible
with RestTemplate - to MockWebServer, which will allow tests to work
using WebClient instead of RestTemplate.
Issue-ID: CPS-2183
Change-Id: I7494fe17cba6e92f7df81f0fd0185e1d2b5a5541
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
mpriyank [Fri, 3 May 2024 09:48:04 +0000 (10:48 +0100)]
Schedule response to client
- Scheduling sending the response by reading whatever is present in the
cache for subscription after a pre-configured time.
- Also added test validation for the same
Issue-ID: CPS-2209
Change-Id: Ifacb0b12734a0529e671b0b63836189a243e453c
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Daniel Hanrahan [Thu, 2 May 2024 09:42:34 +0000 (09:42 +0000)]
Merge "Query operation path by alternate id"
sourabh_sourabh [Thu, 2 May 2024 09:08:04 +0000 (10:08 +0100)]
Handle error in case of upgrade operation
- Send an error response if cm handle not found for upgrade operation.
- Restrict upgrade operation if it is already in progress.
Issue-ID:CPS-2204
Change-Id: Iad63732c5b1d2215b06a09ddda1c0c604cd7648c
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Priyank Maheshwari [Thu, 2 May 2024 08:58:44 +0000 (08:58 +0000)]
Merge "Add Notification support in cps core"
Daniel Hanrahan [Wed, 1 May 2024 13:45:20 +0000 (13:45 +0000)]
Merge "CM Subscription: Link method to publish to DMI in service layer"
danielhanrahan [Wed, 1 May 2024 12:53:00 +0000 (13:53 +0100)]
Bump CPS version
- bump cps to 3.4.9-SNAPSHOT
- also updated the release notes
Issue-ID: CPS-2205
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ifd7feb413baac30e3cbbdf2aeaac5fbb5ae2e463
danielhanrahan [Wed, 1 May 2024 12:22:56 +0000 (13:22 +0100)]
Container YAML for CPS 3.4.8
- added container yaml for cps 3.4.8
Issue-ID: CPS-2205
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Id6ef50ab413bb910fa6ea866964ffe01d90b9b29
danielhanrahan [Wed, 1 May 2024 11:43:16 +0000 (12:43 +0100)]
Maven stage yaml for 3.4.8
- added maven stage yaml to release CPS 3.4.8 version
Issue-ID: CPS-2205
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ic734ec947de86a30cf7b3f080a82c518403a4f5f
danielhanrahan [Wed, 1 May 2024 10:25:36 +0000 (11:25 +0100)]
Update OpenAPI docs for 3.4.8
Issue-ID: CPS-2205
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ib520a55b099b7a89751dab7032cabeba19b6a934
emaclee [Tue, 30 Apr 2024 17:18:31 +0000 (18:18 +0100)]
CM Subscription: Link method to publish to DMI in service layer
- Add call to method to publish to DMI for create request
- Refactor calls to all Mappers to a single Mapper class handler
Issue-ID: CPS-2196
Change-Id: I6476f47684ea9a0f55a7d207c1931a0fef8aa672
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
danielhanrahan [Fri, 26 Apr 2024 10:55:55 +0000 (11:55 +0100)]
Release notes update for 3.4.8
Add release notes updates for bug fix CPS-2190 (slow module search)
Issue-ID: CPS-2190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I9c4500727640040593aacbd209c2d5ec6a86a315
Daniel Hanrahan [Tue, 30 Apr 2024 14:50:15 +0000 (14:50 +0000)]
Merge "[BUG]Defaults for cps and dmi user and pass"
Priyank Maheshwari [Tue, 30 Apr 2024 14:44:15 +0000 (14:44 +0000)]
Merge "CM Subscription: REfactor classes of producers and consumers"
mpriyank [Tue, 30 Apr 2024 09:14:26 +0000 (10:14 +0100)]
[BUG]Defaults for cps and dmi user and pass
- provided default values for DMI_USERNAME and DMI_PASSWORD which is
required to set when DMI_AUTH_ENABLED is true
- Also provided defaults for CPS_USERNAME and CPS_PASSWORD as its
been used in the logback xml file and if not provided then causes an
issue with the logger
Issue-ID: CPS-2194
Change-Id: I70fdbeca970556c7bd19f27c1b6b5123fd591283
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
sourabh_sourabh [Tue, 30 Apr 2024 12:19:11 +0000 (13:19 +0100)]
Reverted web client changes as it breaking CPS functionality:
1. Error handling not working
2. Unable to make dmi call as url appens extra "/"
Commit 1: Replace RestTemplate with WebClient in synchronous DMI calls
- added DmiWebClientConfiguration
- use WebClient in DmiRestClient
- fixed unit tests
- ingnored failing NCMP related integration tests (related to WebClient, will be fixed in a future patch)
- encode query params for DMI requests
Commit 2: Module sync task failing with WebClient
- added configurable buffer size
Commit 3: Re-use ncmp.dmi.httpclient.maximumConnectionsTotal parameter
(as documented in RTD) to control webclient connection poolsize
Issue-ID:CPS-989, CPS-2195, CPS-2198
Change-Id: I6c71ab2801b222708404f51bd60f2b3031ebf32e
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
rajesh.kumar [Fri, 23 Feb 2024 14:59:59 +0000 (20:29 +0530)]
Add Notification support in cps core
Add notification support using cloud events
Issue-ID:CPS-2068
Change-Id: I56c34400dc73c71b936a51260efd240223babacd
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
Daniel Hanrahan [Tue, 30 Apr 2024 09:15:24 +0000 (09:15 +0000)]
Merge "Ajust time limits for performance tests"
emaclee [Mon, 29 Apr 2024 09:30:20 +0000 (10:30 +0100)]
CM Subscription: REfactor classes of producers and consumers
Issue-ID: CPS-2196
Change-Id: I0b56f37a1b615b9615d6bd7005348733e1739a46
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
sourabh_sourabh [Mon, 29 Apr 2024 14:42:22 +0000 (15:42 +0100)]
Re-use ncmp.dmi.httpclient.maximumConnectionsTotal parameter
(as documented in RTD) to control webclient connection poolsize
Issue-ID: CPS-2198
Change-Id: Id441208c66433b2539adf83a0881c3c3c79d2b15
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
sourabh_sourabh [Wed, 24 Apr 2024 11:29:53 +0000 (12:29 +0100)]
Query operation path by alternate id
- New method is written to find longest match for fdn path
- Introduced new exception for alternate id
Issue-ID: CPS-2142
Change-Id: Ifd048574db88586a2d37a3681034a083eb2b7691
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
halil.cakal [Mon, 29 Apr 2024 14:39:10 +0000 (15:39 +0100)]
Ajust time limits for performance tests
- new time limits adjusted for dedicated
physical cps-performance test-server
Issue-ID: CPS-2192
Change-Id: Ia258a8f7460b3fbe68e5b3b61bc918f7d394c1b1
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Daniel Hanrahan [Mon, 29 Apr 2024 10:52:08 +0000 (10:52 +0000)]
Merge "Module sync task failing with WebClient"
Priyank Maheshwari [Mon, 29 Apr 2024 10:21:46 +0000 (10:21 +0000)]
Merge "CM SUBSCRIPTION: Remove accepted and rejected cache entries"
leventecsanyi [Fri, 26 Apr 2024 11:35:32 +0000 (13:35 +0200)]
Module sync task failing with WebClient
- added configurable buffer size
Issue-ID: CPS-2195
Change-Id: I7cdb09856fd4d80134a91e54faa7e6600f3721dc
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
emaclee [Thu, 25 Apr 2024 12:01:06 +0000 (13:01 +0100)]
CM SUBSCRIPTION: Remove accepted and rejected cache entries
Issue-ID: CPS-2185
Change-Id: I01ba8e4f6e0e42a31ad5234ad468ac4625c2b0f3
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
danielhanrahan [Fri, 26 Apr 2024 09:09:54 +0000 (10:09 +0100)]
Faster module searches (CPS-2190 #3)
This greatly improves performance of module searches by eliminating
unneeded SQL queries via Hibernate lazy fetching.
Issue-ID: CPS-2190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ie9e65017d0027366456f1741cc37b10679317b25
danielhanrahan [Thu, 25 Apr 2024 13:33:05 +0000 (14:33 +0100)]
[BUG] Remove slow validation check during module search (CPS-2190 #2)
The check for existing modules is extremely slow, being dependent on
the file sizes of the Yang modules being queries.
The validation check is also completely unnecessary, since it simply
ignores any exceptions and returns an empty set, which the main logic
does implicitly. (The Dataspace check is also not needed, as the NCMP
dataspace is guaranteed to exist.)
Issue-ID: CPS-2190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I329c1f8aac3f50bda0333e6c9c686f47af2e009f
danielhanrahan [Wed, 24 Apr 2024 13:15:47 +0000 (14:15 +0100)]
Perf Test for Module Search is dependent on module size (CPS-2190 #1)
Add a new test showing that Yang module search is dependent on the
file size of the Yang modules being searched for.
Issue-ID: CPS-2190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I8fd28f4c91be11ef7428251397a887af17649015
leventecsanyi [Thu, 18 Apr 2024 14:30:29 +0000 (16:30 +0200)]
Replace RestTemplate with WebClient in synchronous DMI calls
- added DmiWebClientConfiguration
- use WebClient in DmiRestClient
- fixed unit tests
- ingnored failing NCMP related integration tests (related to WebClient, will be fixed in a future patch)
- encode query params for DMI requests
Issue-ID:CPS-989
Change-Id: I26434568f68266e95669a51c134978ddd197d802
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>