Oleksandr Moliavko [Tue, 30 Jul 2019 07:51:07 +0000 (10:51 +0300)]
Replaced constructor calls with valueOf() method calls
to remove static analyzer warnings about inefficient
constructor calls
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: If5b0c9c3569759f738e01c0352e267ee8a995c5f
Steve Smokowski [Mon, 29 Jul 2019 14:11:55 +0000 (14:11 +0000)]
Merge "Implement TLS for calls into VNFM adapter"
Steve Smokowski [Mon, 29 Jul 2019 12:42:01 +0000 (12:42 +0000)]
Merge "Vulnerability fixes in ServicePluginFactory"
Steve Smokowski [Mon, 29 Jul 2019 12:39:09 +0000 (12:39 +0000)]
Merge "Upgrade springboot.version from 2.0.5 to 2.1.5."
Steve Smokowski [Mon, 29 Jul 2019 12:38:33 +0000 (12:38 +0000)]
Merge "validate model info for existing service with"
Steve Smokowski [Mon, 29 Jul 2019 12:38:27 +0000 (12:38 +0000)]
Merge "Use BuildingBlockExecution for PauseForManualTasks"
Steve Smokowski [Mon, 29 Jul 2019 12:38:12 +0000 (12:38 +0000)]
Merge "Add SpringClientFilter in ValetClient to autolog"
Steve Smokowski [Mon, 29 Jul 2019 12:38:06 +0000 (12:38 +0000)]
Merge "set multi-stage flag in listener to log success"
Steve Smokowski [Mon, 29 Jul 2019 12:37:40 +0000 (12:37 +0000)]
Merge "store heat env file sent to heat"
r.bogacki [Mon, 29 Jul 2019 11:15:40 +0000 (13:15 +0200)]
Vulnerability fixes in ServicePluginFactory
Vulnerability fixes in ServicePluginFactory according to the Sonar.
-Made constants final.
-Changed access scopes from public to private.
Issue-ID: SDC-2106
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Iabaca0bd138b5dee22c95a4a0cc6cb5ebe442fd2
Sangalang, Felix [Thu, 25 Jul 2019 15:07:49 +0000 (10:07 -0500)]
Upgrade springboot.version from 2.0.5 to 2.1.5.
Upgrade springboot.version from 2.0.5 to 2.1.5.
Fixed APIHandler junit test cases with expected DB error messages.
Issue-ID: SO-2157
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I77ce873018b88268b9221226b95c9c106f93a8d0
Mnushkin, Dmitry [Fri, 26 Jul 2019 17:17:12 +0000 (13:17 -0400)]
validate model info for existing service with
verify modelVersionId equals during SI AAI validation
correct SI name in junit test
update SI name in junit test comparison
add name/module id verifications for other objects
add back junit file after merge from remote
format jnit file after verify job failure
updated test input values for clarity
update name verifications with related ID values
adding junit for Configuration name verification
updated aai verify call, service dup error msg
removed aai depth 2 and refactored private test method
implement SI name verification with 3 additional fields
fix formatting comment line length limitation
Issue-ID: SO-2161
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I43f5cb0601dfa8b41f474615b639fce0572f5613
subhash kumar singh [Fri, 26 Jul 2019 12:13:00 +0000 (12:13 +0000)]
Merge changes I3e363f64,I52ec2fc9
* changes:
include a bak folder for obsolete files
updated the doc as per the request
Seshu Kumar M [Fri, 26 Jul 2019 12:11:43 +0000 (12:11 +0000)]
Merge "Fixed sonar issue in QueryServiceVnfs.java"
subhash kumar singh [Fri, 26 Jul 2019 12:10:24 +0000 (12:10 +0000)]
Merge "Fix the License issue inside the sample csar"
Seshu Kumar M [Fri, 26 Jul 2019 12:10:09 +0000 (12:10 +0000)]
Merge "Enhanced List Level flow with backward support"
Seshu Kumar M [Fri, 26 Jul 2019 12:09:44 +0000 (12:09 +0000)]
Merge "Javadoc and logging improvement"
Byung-Woo Jun [Fri, 26 Jul 2019 11:32:53 +0000 (11:32 +0000)]
Merge "fix image urls in docs"
sarada prasad sahoo [Mon, 22 Jul 2019 11:25:12 +0000 (16:55 +0530)]
Enhanced List Level flow with backward support
Modified the e2e service instance flow to
support both new list types groups along with
backward compatibility to support old types
alloted resources, network etc.
Change-Id: I1cb128e259c54b80009840914b2c1cee8cf8a4df
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Elena Kuleshov [Fri, 26 Jul 2019 06:34:19 +0000 (02:34 -0400)]
Use BuildingBlockExecution for PauseForManualTasks
Fix variable settings and execution object usage for manual tasks.
Issue-ID: SO-2113
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I3fa24d70b46658ce5afcdc843d5482e157641112
SunilB [Fri, 26 Jul 2019 04:07:49 +0000 (09:37 +0530)]
Javadoc and logging improvement
Added Javadocs for VnfAdapterVfModuleResources and
VnfTopologyOperationRequestMapper classes
Issue-ID: SO-2052
Signed-off-by: sunilb <sb00577584@techmahindra.com>
Change-Id: Iec6addb415720f63c32b5ab99e63aefe0ef3235a
Byung-Woo Jun [Fri, 26 Jul 2019 00:29:36 +0000 (00:29 +0000)]
Merge "update readme.md"
Mcblain, Thomas [Thu, 25 Jul 2019 17:57:43 +0000 (13:57 -0400)]
Add SpringClientFilter in ValetClient to autolog
Add SpringClientFilter in ValetClient to autolog msgs
Modify to use our RestTemplateConfig for RestTemplate
Use Provider for thread-safe RestTemplate autowire
Issue-ID: SO-2160
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I02d1995ebd6d2c93477008feb13193d3c0b3cd05
Benjamin, Max [Thu, 25 Jul 2019 17:36:18 +0000 (13:36 -0400)]
set multi-stage flag in listener to log success
fixed null pointer error when multistage not set
Issue-ID: SO-2159
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I1f2313d074bea404776877ef56607a814e46e514
Gamboa, Gilbert [Thu, 25 Jul 2019 15:10:05 +0000 (11:10 -0400)]
store heat env file sent to heat
Initial commit, include heat environment info in cloud-api_requests.
Updated MSOHeatUtilsTest.saveStackTest unit test to assert
cloudApiRequests requestBody
Issue-ID: SO-2158
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I333cae7746459917ba5e64feb07db4f710b8d99b
Katsiaryna Kazak/ONAP (NC) /SRPOL/Engineer/삼성전자 [Thu, 25 Jul 2019 14:08:58 +0000 (16:08 +0200)]
fix image urls in docs
Corrected image URL for SO Install Docker documentation page
Corrected images URLs for SO Configure git & gerrit documentation page
Issue-ID: SO-2150, SO-2151
Signed-off-by: Katsiaryna Kazak <k.kazak@samsung.com>
Change-Id: Ib163c3159ae284f6c731795b0cbb53ed176ade11
Katsiaryna Kazak/ONAP (NC) /SRPOL/Engineer/삼성전자 [Tue, 23 Jul 2019 17:44:54 +0000 (19:44 +0200)]
update readme.md
Updated developer documentation in readme.md:
components, how to compile, format, build docker images,
images list, how to start them
Issue-ID: SO-2148
Signed-off-by: Katsiaryna Kazak <k.kazak@samsung.com>
Change-Id: Ib0e8e78af3e4497d8d9a6789c3af49f7025ba428
Seshu Kumar M [Thu, 25 Jul 2019 09:41:15 +0000 (09:41 +0000)]
Merge "Fix delete of generic neutron network"
Eric Multanen [Thu, 25 Jul 2019 05:36:13 +0000 (22:36 -0700)]
Fix delete of generic neutron network
Delete of Generic Neutron network was not working.
Logic checking for association with vf-module appears to
have been reversed.
Change-Id: If541c1133322f75c70f86cd77d8bccd88b94f356
Issue-ID: SO-2082
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Mnushkin, Dmitry [Wed, 24 Jul 2019 16:44:16 +0000 (12:44 -0400)]
set multi-stage flag in listener to log success
set multi-stage flag in listener to log success msg
added post listener for requests db object
Issue-ID: SO-2153
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I4b27cbb69b983bd2f7c0d72c8ebb4d9c43201120
Steve Smokowski [Wed, 24 Jul 2019 15:02:34 +0000 (15:02 +0000)]
Merge "Major Sonar fixes in InstanceManagement"
Steve Smokowski [Wed, 24 Jul 2019 15:02:17 +0000 (15:02 +0000)]
Merge "Removed not used loggers"
Steve Smokowski [Wed, 24 Jul 2019 15:00:37 +0000 (15:00 +0000)]
Merge "Major Sonar fixes in E2EServiceInstances"
Steve Smokowski [Wed, 24 Jul 2019 14:59:27 +0000 (14:59 +0000)]
Merge "Major Sonar fixes"
Steve Smokowski [Wed, 24 Jul 2019 14:59:12 +0000 (14:59 +0000)]
Merge "enhance get orchestration request"
Steve Smokowski [Wed, 24 Jul 2019 14:59:09 +0000 (14:59 +0000)]
Merge "Update SO to handle Async VNF operations to SDNC"
seshukm [Wed, 24 Jul 2019 10:07:40 +0000 (15:37 +0530)]
include a bak folder for obsolete files
Issue-ID: SO-1230
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I3e363f6445f6f76b62f0ca1bf9467fd795db50e7
seshukm [Wed, 24 Jul 2019 10:06:05 +0000 (15:36 +0530)]
updated the doc as per the request
Issue-ID: SO-1230
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I52ec2fc97abfd71b31a59fcb0416b0472e83d39c
r.bogacki [Wed, 24 Jul 2019 08:45:01 +0000 (10:45 +0200)]
Removed not used loggers
-Removed unnecessary loggers according to Sonar.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I05a0cc3187692fa17a6734d1c2a6be33d4b5ee34
r.bogacki [Wed, 24 Jul 2019 07:06:26 +0000 (09:06 +0200)]
Major Sonar fixes in InstanceManagement
-Removed unnecessary code.
-Removed unused variables.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ie85cb51da959dacc80b61aa9d5bb608b4198a5fb
r.bogacki [Wed, 24 Jul 2019 06:57:43 +0000 (08:57 +0200)]
Major Sonar fixes in E2EServiceInstances
-Removed unnecessary code.
-Removed unused variables.
-Introduced constants for repeating Strings.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I4ac692849508178390796d149b2c3f2fddcd093b
Merkel, Jeff [Tue, 23 Jul 2019 15:43:21 +0000 (11:43 -0400)]
- Converted NetworkResource to use the parser
- Converted NetworkResource to use the parser getEntity method.
- run the formatting command so that it aligns correctly.
Issue-ID: SO-2147
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Id6aa6c2967ec4014d6512851fa7dfff088946081
r.bogacki [Tue, 23 Jul 2019 07:20:28 +0000 (09:20 +0200)]
Major Sonar fixes
Major Sonar fixes in different classes:
-Removed unnecessary code.
-Removed unused variables.
-Removed unnecessary imports.
-Simplified diamond operators.
-Improved String comparisons in equals.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I279c63f8e7161d6e33d5d6a28b938c0c64e90f1f
Seshu Kumar M [Tue, 23 Jul 2019 05:30:31 +0000 (05:30 +0000)]
Merge "Enhanced List Level flow with backward support"
MichaelMorris [Mon, 22 Jul 2019 14:28:09 +0000 (14:28 +0000)]
Implement TLS for calls into VNFM adapter
Issue-ID: SO-2143
Change-Id: I2fcacab7aebc9a22b952d881b0bf2404e1638b37
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Plummer, Brittany [Mon, 22 Jul 2019 13:44:15 +0000 (08:44 -0500)]
enhance get orchestration request
Enhance get orchestration request to include workflow step
Began working on adding call for activity name
Added call to return activity information
Updated to return last task executed
Added last task executed info to returned string
Updated mocks to fix failing unit tests
Added responses for mocks to Camunda for process and activity history
Added tests to cover taskName changes
Began adding tests to cover changes to RequestHandlerUtils
Added more unit tests for activity lookup
Updated error messages for taskName
Moved properties to application.yaml file
Added unit tests to add more coverage to task retrieval
Moved Camunda calls to CamundaRequestHandler class
Removed unused imports from RequestHandlerUtils
Fixed formatting of tests and removed handler where not used
Removed CamundaRequestHandler from JerseyConfiguration
Added retryTemplate for camunda calls
Issue-ID: SO-2142
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I09a82e3458e8f611e4bbaf3ce9ab5de36b1b060a
Smokowski, Steven [Mon, 22 Jul 2019 13:42:42 +0000 (08:42 -0500)]
Update SO to handle Async VNF operations to SDNC
Update SO to handle Async VNF operations to SDNC
Issue-ID: SO-2141
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I20037306e9ce5b8df434511a46c0a3399e335c3d
Steve Smokowski [Mon, 22 Jul 2019 13:17:29 +0000 (13:17 +0000)]
Merge "Added servicename to MDC so that it gets logged"
r.bogacki [Mon, 22 Jul 2019 09:28:57 +0000 (11:28 +0200)]
Vulnerability fixes in ServicePluginFactory
Sonar vulnerability fixes in ServicePluginFactory:
-Added logger.
Issue-ID: SO-2139
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Id1752ea35db970b20d02e730dac9900c411958ca
Boslet, Cory [Thu, 18 Jul 2019 20:20:38 +0000 (16:20 -0400)]
Added servicename to MDC so that it gets logged
Added servicename to MDC so that it gets logged and added enter and
exit markers.
Issue-ID: SO-2122
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I63ff5e5de21d851c989ffa5db2051755751d9ead
Byung-Woo Jun [Fri, 19 Jul 2019 13:58:55 +0000 (13:58 +0000)]
Merge "basic auth for so-monitoring"
k.kazak [Fri, 19 Jul 2019 12:59:18 +0000 (14:59 +0200)]
basic auth for so-monitoring
Add basic auth for so-monitoring app
Issue submitted in pentest report
Change-Id: I8e826da9b9f66e893826fd9b40b3b26623b2ab8d
Issue-ID: OJSI-169
Signed-off-by: k.kazak <k.kazak@samsung.com>
Steve Smokowski [Fri, 19 Jul 2019 12:04:33 +0000 (12:04 +0000)]
Merge "Set networkName value to the name from L3network"
seshukm [Fri, 19 Jul 2019 11:11:56 +0000 (16:41 +0530)]
Fix the License issue inside the sample csar
Issue-ID: SO-2138
Change-Id: I0dd532abf983a248b60f91aea4a6fbd05e33daab
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Steve Smokowski [Thu, 18 Jul 2019 20:41:44 +0000 (20:41 +0000)]
Merge "Added null check for yaml to prevent crash at getParameterListFromEnvt()"
Steve Smokowski [Thu, 18 Jul 2019 20:41:30 +0000 (20:41 +0000)]
Merge "Commented out updatedAttribute declaration to prevent static analyzer warning about unused variable"
Steve Smokowski [Thu, 18 Jul 2019 20:40:57 +0000 (20:40 +0000)]
Merge changes I5e72e1c6,I5e1cb624
* changes:
Added null check for function param pFqdns to prevent crash at for loop.
Added check for null ptr before dereferencing at gBBInput.getCustomer().getServiceSubscription() - to prevent static analyzer warning
Steve Smokowski [Thu, 18 Jul 2019 20:40:14 +0000 (20:40 +0000)]
Merge "Fix error updating request_processing_data"
Steve Smokowski [Thu, 18 Jul 2019 20:40:04 +0000 (20:40 +0000)]
Merge "Remove duplicate name check in createAAITasks."
Kuleshov, Elena [Thu, 18 Jul 2019 20:40:01 +0000 (16:40 -0400)]
Set networkName value to the name from L3network
Set networkName value to the name from L3network object.
Add JUnit argument captures for naming creates
Fix formatting errors in the JUnit file.
Issue-ID: SO-2123
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ie4d2bd86f1a47bd5742aa7786dc9cba47fa11392
Roy, Amresh [Thu, 18 Jul 2019 19:21:23 +0000 (14:21 -0500)]
Removing application-local.yaml files
Removing the application-local.yaml files because they're no longer
maintained or working.
Issue-ID: SO-2121
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I191c8775de931671a4657be8940e6aec64023359
Gamboa, Gilbert [Thu, 18 Jul 2019 18:37:21 +0000 (14:37 -0400)]
Fix error updating request_processing_data
Fix error when updating existing record in request_processing_data
table.
Use correct field name in the toString method in RequestProcessingData
bean class.
RequestDbClient.updateRequestProcessingData should include entity id in
the URI on the PUT request.
Add new Config class ExposeEntityIdResourceConfiguration to make
Spring data Rest return id in the response for RequestProcessingData.
Make spring-boot-starter-data-rest not optional dependency in
mso-requests-db-repositories
Added unit test for RequestDbClient.updateRequestProcessingData()
method.
Issue-ID: SO-2120
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I733be06185e5c19a0b7112918ce0a0f2abf861d7
Steve Smokowski [Thu, 18 Jul 2019 18:22:15 +0000 (18:22 +0000)]
Merge "Implement TLS for calls from VNFM adapter to VNFM"
Gamboa, Gilbert [Thu, 18 Jul 2019 15:28:01 +0000 (11:28 -0400)]
Remove duplicate name check in createAAITasks.
Remove duplicate name check in createAAITasks. This hould be done prior
to status check in WorkflowAction or BBInputSetup.
Issue-ID: SO-2119
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: I0d6d34476b1ab2b351314c9a23926f2fff0e4f89
Steve Smokowski [Thu, 18 Jul 2019 11:55:25 +0000 (11:55 +0000)]
Merge "Commented out initialization of workflowResponse to prevent static analyzer warning about workflowResponse never being set to anything but null."
Steve Smokowski [Thu, 18 Jul 2019 11:53:25 +0000 (11:53 +0000)]
Merge "Fixes in WorkflowAction"
Steve Smokowski [Thu, 18 Jul 2019 11:53:09 +0000 (11:53 +0000)]
Merge "Major Sonar fixes"
Steve Smokowski [Thu, 18 Jul 2019 11:52:22 +0000 (11:52 +0000)]
Merge "Vulnerability fixes in ServicePluginFactory"
Steve Smokowski [Thu, 18 Jul 2019 11:52:03 +0000 (11:52 +0000)]
Merge "Add requestContext to unassignVfModule tasks and"
Steve Smokowski [Thu, 18 Jul 2019 11:51:52 +0000 (11:51 +0000)]
Merge "Add SO BPMN name for NAME in tbl workflow"
Steve Smokowski [Thu, 18 Jul 2019 11:51:36 +0000 (11:51 +0000)]
Merge "We need to expand column request_status"
MichaelMorris [Thu, 18 Jul 2019 11:42:07 +0000 (11:42 +0000)]
Implement TLS for calls from VNFM adapter to VNFM
Issue-ID: SO-2116
Change-Id: I1e5bdfcf3164545c89fb370014d49ef3ae6a9cf1
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Bonkur, Venkat (vb8416) [Thu, 18 Jul 2019 04:30:31 +0000 (00:30 -0400)]
Add SO BPMN name for NAME in tbl workflow
Added SO update the R__WorkflowDesignerData.sql script to insert name of BPMN process
instead of description in the NAME field of workflow table for VnfInPlaceUpdate and
VnfConfigUpdate
Issue-ID: SO-2112
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I288a1159e95c3798c37ff41a599662e5df8317ba
Mcblain, Thomas [Wed, 17 Jul 2019 22:42:01 +0000 (18:42 -0400)]
Add requestContext to unassignVfModule tasks and
Add requestContext to unassignVfModule tasks and tests
Issue-ID: SO-2115
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: Ifddfe32fab9406afb69ad9192351500cfbed3610
Gamboa, Gilbert [Wed, 17 Jul 2019 21:36:28 +0000 (17:36 -0400)]
We need to expand column request_status
New script to expand column request_status on table
archived_infra_requests as well.
Issue-ID: SO-2114
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: Ife1168e658bbb9e7fa69541de42173947564cac8
Boslet, Cory [Wed, 17 Jul 2019 17:36:05 +0000 (13:36 -0400)]
add query stack data and populate table step
Need to check if audit is enabled first in the delete record task
Updates to audit delete redeisgn and data to table
Various updates to logging, audit object, added tag to query, updated
tag value.
Updated write method to make sure an entry for this heat stack doesnt
already exist to avoid duplicate entrys
Updated unit test to account for get query
Added so that id is not hidden from query results
Updated the was delete is done plus minor updates.
Updated delete method to use resttemplate instead of bowman client
Combined the write and get stack data task into the external tasks.
Removed the task to delete the stack data from db
Updates to junit request id so its not a random id for test
Updated service tasks in att BB to call external task
Update to be a real uuid format due to failing unit test
Updated fields to protected and updated unit test
Issue-ID: SO-2111
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: I8f479a046cf837403f60c330ed6ad8bc08a9c82f
Oleksandr Moliavko [Mon, 15 Jul 2019 07:20:42 +0000 (10:20 +0300)]
Added null check for yaml to prevent crash at
getParameterListFromEnvt()
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I8fabba8d99e311f01a5fd5dad166e0bb643044e3
waqas.ikram [Fri, 12 Jul 2019 16:51:59 +0000 (17:51 +0100)]
Fixing ASDCRestInterface for CSIT to simulate SDC req
Change-Id: I6331d08441b9bf1f621f56ec1b7d911851010e62
Issue-ID: SO-1948
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
Oleksandr Moliavko [Fri, 12 Jul 2019 12:29:32 +0000 (15:29 +0300)]
Commented out updatedAttribute declaration to prevent
static analyzer warning about unused variable
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I0d46bcc817d08a6fbad3501c56336dc532bb5907
Oleksandr Moliavko [Wed, 10 Jul 2019 11:04:26 +0000 (14:04 +0300)]
Added null check for function param pFqdns to
prevent crash at for loop.
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5e72e1c6d74c5f197479062348090ab2b87fafae
Oleksandr Moliavko [Fri, 5 Jul 2019 12:14:07 +0000 (15:14 +0300)]
Commented out initialization of workflowResponse to prevent
static analyzer warning about workflowResponse never being
set to anything but null.
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ib150e3836fda9b7d9785a574f904b2c61bfa39f4
Oleksandr Moliavko [Tue, 9 Jul 2019 13:33:07 +0000 (16:33 +0300)]
Added check for null ptr before dereferencing at
gBBInput.getCustomer().getServiceSubscription() -
to prevent static analyzer warning
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5e1cb6248412ae9e3036011bd96d708f36170d70
r.bogacki [Wed, 10 Jul 2019 09:29:37 +0000 (11:29 +0200)]
Fixes in WorkflowAction
Fixes in WorkflowAction according to the Sonar analysis:
-Fixed String comparison.
-Removed unnecessary method parameters.
-Updated junit test.
Issue-ID: SO-2107
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I7522269e237f736521a627bcd1c8f77b0c776a70
r.bogacki [Wed, 10 Jul 2019 09:09:31 +0000 (11:09 +0200)]
Major Sonar fixes
Major Sonar fixes in different classes:
-Removed unused variables.
-Simplified diamond operators.
-Removed unnecessary imports.
-Removed unnecessary code.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ib54fbe048700a4e31042481f0a9b13838552aee7
r.bogacki [Wed, 10 Jul 2019 08:38:42 +0000 (10:38 +0200)]
Vulnerability fixes in ServicePluginFactory
Sonar vulnerability fixes in ServicePluginFactory.
-Moved hardcoded IP addresses to the property file.
-Added junit test.
Issue-ID: SO-2106
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Id33e17f7845c106212bbf4d4a8ca78641cea1396
Steve Smokowski [Thu, 11 Jul 2019 12:48:58 +0000 (12:48 +0000)]
Merge "Sonar Fix: SDNCAdapterApplication.java"
Lukasz Muszkieta [Wed, 10 Jul 2019 07:20:01 +0000 (07:20 +0000)]
Merge "Major Sonar fixes in E2EServiceInstances"
Arundathi Patil [Wed, 10 Jul 2019 03:53:11 +0000 (09:23 +0530)]
Sonar Fix: SDNCAdapterApplication.java
Removed unused imports from the file
Issue-ID: SO-2103
Change-Id: Id126f5203789d866b340d86b55bbc616991afc99
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Marcus Williams [Tue, 9 Jul 2019 19:36:38 +0000 (19:36 +0000)]
Merge "Sonar fix in CreateInventoryTask.java"
Lukasz Muszkieta [Tue, 9 Jul 2019 17:24:19 +0000 (17:24 +0000)]
Merge "Sonar fixes in ManualTasks"
Lukasz Muszkieta [Tue, 9 Jul 2019 17:22:41 +0000 (17:22 +0000)]
Merge "Sonar fixes in OrchestrationRequests"
r.bogacki [Tue, 9 Jul 2019 12:10:53 +0000 (14:10 +0200)]
Major Sonar fixes
Major Sonar fixes in different classes:
-Removed unnecessary code.
-Removed unused variables.
-Removed unnecessary imports.
-Simplified diamond operators.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I098e3dcd93b804e58220bb41ea15325e820e3a59
r.bogacki [Tue, 9 Jul 2019 11:45:37 +0000 (13:45 +0200)]
Sonar fixes in OrchestrationRequests
Sonar fixes in OrchestrationRequests according to the Sonar analysis.
-Removed unnecessary code.
-Removed unused variables.
Issue-ID: SO-2101
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I564f35519c5063028e1cf540eb81ab81cf923fd5
r.bogacki [Tue, 9 Jul 2019 11:31:36 +0000 (13:31 +0200)]
Sonar fixes in ManualTasks
Code fixes in ManualTasks according to the Sonar analysis.
-Removed unnecessary code.
-Removed unused imports.
-Removed unused variables.
Issue-ID: SO-2100
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I79848456cc88b7f2cb812f7054bb6cec12b584c0
r.bogacki [Tue, 9 Jul 2019 11:05:34 +0000 (13:05 +0200)]
Major Sonar fixes in E2EServiceInstances
Major code fixes in E2EServiceInstances according to the Sonar analysis.
-Removed unnecessary code.
-Removed unnecessary method parameters.
-Removed unused variables.
Issue-ID: SO-2099
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I0e217174455a6748c663b3d5cc92fdc22b67ce2d
Arundathi Patil [Tue, 9 Jul 2019 03:05:24 +0000 (08:35 +0530)]
Sonar fix in CreateInventoryTask.java
Fixed multiple sonar issues in this file
Issue-ID: SO-2098
Change-Id: I7da9ffae8ee11d8475445b5263bc7cfb78834a9c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Steve Smokowski [Mon, 8 Jul 2019 15:27:43 +0000 (15:27 +0000)]
Merge "remove unneeded code"
Steve Smokowski [Mon, 8 Jul 2019 15:26:41 +0000 (15:26 +0000)]
Merge "Added null check to prevent call of getVnfResources() method for null vf object"
Steve Smokowski [Mon, 8 Jul 2019 14:19:14 +0000 (14:19 +0000)]
Merge "Added null check for heatStack to prevent crash at getCanonicalName() call"
Steve Smokowski [Mon, 8 Jul 2019 14:18:29 +0000 (14:18 +0000)]
Merge "add junit coverage for VnfmHelper"